From nobody Sun Apr 12 05:51:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772007245; cv=none; d=zohomail.com; s=zohoarc; b=g3YRFbs6kPLx8P1lhBQNN0tBJzW+YGPzJMsHpymuKBTOvtqRMLoe7i37M7WZQO+j6ArwjeI8He6gMIctZP0gUhahRYW9cJE3nGSYdW2n+RVsyV6rYKHdbRowSsl1FFcq/E1uOLFaZ7H4fjfy4oxSDG8gWK/Kqq3lO9FAT7Zvh5w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772007245; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IQS3Y5nMTKw5gDI6HAbJElvI3dA9SdUjFn0c8BGqiT4=; b=W1HNzcN8n0ZxUZxdVZykEFNbeoGmt2S+mGEcAsyOqqUa3WEPbUe8F14FRrvNYsKJRAd8krr7/bYYX43u5HHyqP4RV4DovGgWWyvOr8fmanwguAbHPnxbB2wTL0zR0+80+drVe7Z3QraVaB5UFdykjl47EK15lB1e67cAj0teQmc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772007245617233.8994801141165; Wed, 25 Feb 2026 00:14:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vvA1s-0000Gp-3X; Wed, 25 Feb 2026 03:13:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvA1q-0000G7-8F for qemu-devel@nongnu.org; Wed, 25 Feb 2026 03:13:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvA1o-0001mM-Eu for qemu-devel@nongnu.org; Wed, 25 Feb 2026 03:13:54 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-dtAGnXt3NmeR-MLCzSwpzg-1; Wed, 25 Feb 2026 03:13:46 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 19BE219560B7; Wed, 25 Feb 2026 08:13:45 +0000 (UTC) Received: from localhost (unknown [10.2.16.120]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D43761800465; Wed, 25 Feb 2026 08:13:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772007231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IQS3Y5nMTKw5gDI6HAbJElvI3dA9SdUjFn0c8BGqiT4=; b=YjWVrfAeHWfJIsPnor3BZza6hIgM/A9lZHCAIULCzoA8uQb18XC44OuCFO51d1pWIc4kH/ 0pLpfcGVynHp49vCnRtUXS1ySgEYM6vBYkofiMLUQXkAxC7ZbvZP2c/7RefK8v3BBvBx+O K9+NGYFJ3IjNTd8x0KQjpV8LM7FFgE8= X-MC-Unique: dtAGnXt3NmeR-MLCzSwpzg-1 X-Mimecast-MFC-AGG-ID: dtAGnXt3NmeR-MLCzSwpzg_1772007225 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , qemu-block@nongnu.org, Kevin Wolf , Fam Zheng , Jens Axboe Subject: [PATCH v2 1/4] iothread: create AioContext in iothread_run() Date: Wed, 25 Feb 2026 16:13:33 +0800 Message-ID: <20260225081336.1639325-2-stefanha@redhat.com> In-Reply-To: <20260225081336.1639325-1-stefanha@redhat.com> References: <20260225081336.1639325-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.358, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.659, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772007248694158500 Content-Type: text/plain; charset="utf-8" The IOThread's AioContext is currently created in iothread_init() where it's easy to propagate errors before spawning the thread that runs iothread_run(). However, this means that aio_context_new() is called from the main loop thread rather than from the IOThread. In order to use Linux io_uring's IORING_SETUP_SINGLE_ISSUER feature in the next commit, only one thread can use the io_uring context and therefore iothread.c must call aio_context_new() from iothread_run() instead of iothread_init(). Extract the iothread_run() arguments into an IOThreadRunArgs struct where an Error *error field can be used to report back initialization errors. This works pretty well thanks to the init_done_sem semaphore that is already used by iothread_init() to wait for iothread_run() to initialize. Move iothread_run() further down for proximity with iothread_init() and to avoid adding a function prototype for iothread_set_aio_context_params(). Signed-off-by: Stefan Hajnoczi --- include/system/iothread.h | 1 - iothread.c | 140 +++++++++++++++++++++----------------- 2 files changed, 78 insertions(+), 63 deletions(-) diff --git a/include/system/iothread.h b/include/system/iothread.h index e26d13c6c7..9c70c7fa0b 100644 --- a/include/system/iothread.h +++ b/include/system/iothread.h @@ -29,7 +29,6 @@ struct IOThread { bool run_gcontext; /* whether we should run gcontext */ GMainContext *worker_context; GMainLoop *main_loop; - QemuSemaphore init_done_sem; /* is thread init done? */ bool stopping; /* has iothread_stop() been called? */ bool running; /* should iothread_run() continue? */ int thread_id; diff --git a/iothread.c b/iothread.c index caf68e0764..6e79c02d02 100644 --- a/iothread.c +++ b/iothread.c @@ -36,46 +36,6 @@ #define IOTHREAD_POLL_MAX_NS_DEFAULT 0ULL #endif =20 -static void *iothread_run(void *opaque) -{ - IOThread *iothread =3D opaque; - - rcu_register_thread(); - /* - * g_main_context_push_thread_default() must be called before anything - * in this new thread uses glib. - */ - g_main_context_push_thread_default(iothread->worker_context); - qemu_set_current_aio_context(iothread->ctx); - iothread->thread_id =3D qemu_get_thread_id(); - qemu_sem_post(&iothread->init_done_sem); - - while (iothread->running) { - /* - * Note: from functional-wise the g_main_loop_run() below can - * already cover the aio_poll() events, but we can't run the - * main loop unconditionally because explicit aio_poll() here - * is faster than g_main_loop_run() when we do not need the - * gcontext at all (e.g., pure block layer iothreads). In - * other words, when we want to run the gcontext with the - * iothread we need to pay some performance for functionality. - */ - aio_poll(iothread->ctx, true); - - /* - * We must check the running state again in case it was - * changed in previous aio_poll() - */ - if (iothread->running && qatomic_read(&iothread->run_gcontext)) { - g_main_loop_run(iothread->main_loop); - } - } - - g_main_context_pop_thread_default(iothread->worker_context); - rcu_unregister_thread(); - return NULL; -} - /* Runs in iothread_run() thread */ static void iothread_stop_bh(void *opaque) { @@ -104,7 +64,6 @@ static void iothread_instance_init(Object *obj) =20 iothread->poll_max_ns =3D IOTHREAD_POLL_MAX_NS_DEFAULT; iothread->thread_id =3D -1; - qemu_sem_init(&iothread->init_done_sem, 0); /* By default, we don't run gcontext */ qatomic_set(&iothread->run_gcontext, 0); } @@ -135,7 +94,6 @@ static void iothread_instance_finalize(Object *obj) g_main_loop_unref(iothread->main_loop); iothread->main_loop =3D NULL; } - qemu_sem_destroy(&iothread->init_done_sem); } =20 static void iothread_init_gcontext(IOThread *iothread, const char *thread_= name) @@ -176,47 +134,105 @@ static void iothread_set_aio_context_params(EventLoo= pBase *base, Error **errp) base->thread_pool_max, errp); } =20 +typedef struct { + IOThread *iothread; + const char *thread_name; + QemuSemaphore init_done_sem; /* is thread init done? */ + Error *error; /* filled in before init_done_sem is posted */ +} IOThreadRunArgs; =20 -static void iothread_init(EventLoopBase *base, Error **errp) +static void *iothread_run(void *opaque) { - Error *local_error =3D NULL; - IOThread *iothread =3D IOTHREAD(base); - g_autofree char *thread_name =3D NULL; + IOThreadRunArgs *args =3D opaque; + IOThread *iothread =3D args->iothread; =20 - iothread->stopping =3D false; - iothread->running =3D true; - iothread->ctx =3D aio_context_new(errp); + rcu_register_thread(); + + iothread->ctx =3D aio_context_new(&args->error); if (!iothread->ctx) { - return; + goto out; } =20 - thread_name =3D g_strdup_printf("IO %s", - object_get_canonical_path_component(OBJECT(base))); + iothread_set_aio_context_params(EVENT_LOOP_BASE(iothread), &args->erro= r); + if (args->error) { + aio_context_unref(iothread->ctx); + iothread->ctx =3D NULL; + goto out; + } =20 /* * Init one GMainContext for the iothread unconditionally, even if * it's not used */ - iothread_init_gcontext(iothread, thread_name); + iothread_init_gcontext(iothread, args->thread_name); =20 - iothread_set_aio_context_params(base, &local_error); - if (local_error) { - error_propagate(errp, local_error); - aio_context_unref(iothread->ctx); - iothread->ctx =3D NULL; - return; + /* + * g_main_context_push_thread_default() must be called before anything + * in this new thread uses glib. + */ + g_main_context_push_thread_default(iothread->worker_context); + qemu_set_current_aio_context(iothread->ctx); + + iothread->stopping =3D false; + iothread->running =3D true; + + iothread->thread_id =3D qemu_get_thread_id(); + qemu_sem_post(&args->init_done_sem); + + while (iothread->running) { + /* + * Note: from functional-wise the g_main_loop_run() below can + * already cover the aio_poll() events, but we can't run the + * main loop unconditionally because explicit aio_poll() here + * is faster than g_main_loop_run() when we do not need the + * gcontext at all (e.g., pure block layer iothreads). In + * other words, when we want to run the gcontext with the + * iothread we need to pay some performance for functionality. + */ + aio_poll(iothread->ctx, true); + + /* + * We must check the running state again in case it was + * changed in previous aio_poll() + */ + if (iothread->running && qatomic_read(&iothread->run_gcontext)) { + g_main_loop_run(iothread->main_loop); + } } =20 + g_main_context_pop_thread_default(iothread->worker_context); +out: + rcu_unregister_thread(); + return NULL; +} + +static void iothread_init(EventLoopBase *base, Error **errp) +{ + IOThread *iothread =3D IOTHREAD(base); + g_autofree char *thread_name =3D NULL; + IOThreadRunArgs args =3D { + .iothread =3D iothread, + }; + + qemu_sem_init(&args.init_done_sem, 0); + + thread_name =3D g_strdup_printf("IO %s", + object_get_canonical_path_component(OBJECT(base))); + args.thread_name =3D thread_name; + /* This assumes we are called from a thread with useful CPU affinity f= or us * to inherit. */ - qemu_thread_create(&iothread->thread, thread_name, iothread_run, - iothread, QEMU_THREAD_JOINABLE); + qemu_thread_create(&iothread->thread, thread_name, iothread_run, &args, + QEMU_THREAD_JOINABLE); =20 /* Wait for initialization to complete */ while (iothread->thread_id =3D=3D -1) { - qemu_sem_wait(&iothread->init_done_sem); + qemu_sem_wait(&args.init_done_sem); } + + qemu_sem_destroy(&args.init_done_sem); + error_propagate(errp, args.error); } =20 typedef struct { --=20 2.53.0 From nobody Sun Apr 12 05:51:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772007251; cv=none; d=zohomail.com; s=zohoarc; b=nkAsdZxvwp5xFv9eaBqv6DdLckGjptM80oIvUA2R4L1ws7vT3pRM9UNlxFV+5SO1tLlcb8o7arJJwTJZNvMwZodvkdAs6YChsNFSC/wTyOeAAJZOtgjRsvQ25uzfQjoZi6WWC6EQea8yzVhg9Z1nQ7HGTHb2o0xv6XtfoYGcMJQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772007251; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=L83tmmVEdGQV/uGUec+kZ4/BaRD7oWY0T8JaJvvXus0=; b=kUKzJ+epJk7sDvgwjedHcQUByWS6G8ZIVtw5EqQctzY+o6U/iFKdrGve0A3jXGjo1fhwmag51svRBm2l5KKBzIYkSaREc3893Y9ynjuExb9Zrl31kkGIC99In/RWzFa9Xky6Cxyefl5VZl8SUYiX4qMI/ree4zoRtV856pRO4zg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772007251249114.55219286499948; Wed, 25 Feb 2026 00:14:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vvA1u-0000HT-1M; Wed, 25 Feb 2026 03:13:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvA1s-0000Gx-9W for qemu-devel@nongnu.org; Wed, 25 Feb 2026 03:13:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvA1q-0001ma-RE for qemu-devel@nongnu.org; Wed, 25 Feb 2026 03:13:56 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-247-nPinB27OO16c3e1UBhRgvA-1; Wed, 25 Feb 2026 03:13:50 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0771B19560AD; Wed, 25 Feb 2026 08:13:49 +0000 (UTC) Received: from localhost (unknown [10.2.16.120]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0C6E71800348; Wed, 25 Feb 2026 08:13:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772007234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L83tmmVEdGQV/uGUec+kZ4/BaRD7oWY0T8JaJvvXus0=; b=TFFU/G+cHAhvqZs+43nCf8+kK4RFEPAcXhq3/tOjuXhVXldyQCimWaJxkZTlB9XpCIdBb5 gemDkss0n4njhD8aGHzBSc3tMz7gPksIkc5fE6GbjOIYCZMJ0SRnaRX+yl3ZhoY/f2Ztv3 yCPuXapzKZfvi1OeWGS2WDLplawH2Fw= X-MC-Unique: nPinB27OO16c3e1UBhRgvA-1 X-Mimecast-MFC-AGG-ID: nPinB27OO16c3e1UBhRgvA_1772007229 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , qemu-block@nongnu.org, Kevin Wolf , Fam Zheng , Jens Axboe Subject: [PATCH v2 2/4] aio-posix: enable IORING_SETUP_SINGLE_ISSUER Date: Wed, 25 Feb 2026 16:13:34 +0800 Message-ID: <20260225081336.1639325-3-stefanha@redhat.com> In-Reply-To: <20260225081336.1639325-1-stefanha@redhat.com> References: <20260225081336.1639325-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.358, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.659, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772007252700158500 Content-Type: text/plain; charset="utf-8" IORING_SETUP_SINGLE_ISSUER enables optimizations in the host Linux kernel's io_uring code when the io_uring context is only used from a single thread. This is true is QEMU because io_uring SQEs are submitted from the same thread that processes the CQEs. Signed-off-by: Stefan Hajnoczi --- util/fdmon-io_uring.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/util/fdmon-io_uring.c b/util/fdmon-io_uring.c index d0b56127c6..ec056b4818 100644 --- a/util/fdmon-io_uring.c +++ b/util/fdmon-io_uring.c @@ -452,13 +452,31 @@ static const FDMonOps fdmon_io_uring_ops =3D { .add_sqe =3D fdmon_io_uring_add_sqe, }; =20 +static inline bool is_creating_iothread(void) +{ + return qemu_get_thread_id() !=3D getpid(); +} + bool fdmon_io_uring_setup(AioContext *ctx, Error **errp) { + unsigned flags =3D 0; int ret; =20 + /* + * The main thread's AioContexts are created from the main loop thread= but + * may be accessed from multiple threads (e.g. vCPUs or the migration + * thread). IOThread AioContexts are only accessed from the IOThread + * itself. + */ +#if IORING_SETUP_SINGLE_ISSUER + if (is_creating_iothread()) { + flags |=3D IORING_SETUP_SINGLE_ISSUER; + } +#endif + ctx->io_uring_fd_tag =3D NULL; =20 - ret =3D io_uring_queue_init(FDMON_IO_URING_ENTRIES, &ctx->fdmon_io_uri= ng, 0); + ret =3D io_uring_queue_init(FDMON_IO_URING_ENTRIES, &ctx->fdmon_io_uri= ng, flags); if (ret !=3D 0) { error_setg_errno(errp, -ret, "Failed to initialize io_uring"); return false; --=20 2.53.0 From nobody Sun Apr 12 05:51:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772007261; cv=none; d=zohomail.com; s=zohoarc; b=DNStT7q+GT8dCv3ZNKDvR9lX8Lav2hpmlBpJZgISlzV1cBuNiJz0B+PHOTdaBMm81O2r4CQwTFAZO/piI0pX/++sUCTFDF+nSlwwZQDLa4toS5DFi3CLRS2+8pYwURpDWsh9ZSHmqMXktlEWgJuri9IgfOY3PwuWZJmKR6gXX00= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772007261; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IwK+4U3rA5gsM5s8bZtHt3GmDGzP9xFTquIJLV4EUZ8=; b=S2VA1cmt9rz+Efioy19b/s78dH3Sf7kgL0lb9tR4G5+3Fl7G0gEu397zix7FoWIZsTm+CY29E2MsSS5e6ekpyO6Sjw8ma+OF+zklNodCWCHAB8/uxZQ80RX55DDc5bAsxfzlfxC9FvqVMClSm67fBmUOVtLTCSPSpbCkLAhKon8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772007261203131.9618622684984; Wed, 25 Feb 2026 00:14:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vvA1y-0000KV-Dj; Wed, 25 Feb 2026 03:14:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvA1w-0000IK-Cu for qemu-devel@nongnu.org; Wed, 25 Feb 2026 03:14:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvA1v-0001n0-1y for qemu-devel@nongnu.org; Wed, 25 Feb 2026 03:14:00 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-9XxlWmXXM6eZbo-Q3GGWOA-1; Wed, 25 Feb 2026 03:13:54 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 784211800464; Wed, 25 Feb 2026 08:13:53 +0000 (UTC) Received: from localhost (unknown [10.2.16.120]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 13A331955F43; Wed, 25 Feb 2026 08:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772007238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IwK+4U3rA5gsM5s8bZtHt3GmDGzP9xFTquIJLV4EUZ8=; b=E9dikzebZt8k4K2mdAj/1rvbCA99blah5dc8jAy0fw+tRN6yvOj3WrwY1q91k3AGH4vZ0/ vLAqgQi4ExmYtA0p9pdez7ykB5bxTv9ahT85bnGfljhNYYVYeP+5Jhq63WxrFEAx0TeUGn d5E6kfNHxwYrEQkI6Omoo2jveLFnii8= X-MC-Unique: 9XxlWmXXM6eZbo-Q3GGWOA-1 X-Mimecast-MFC-AGG-ID: 9XxlWmXXM6eZbo-Q3GGWOA_1772007233 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , qemu-block@nongnu.org, Kevin Wolf , Fam Zheng , Jens Axboe Subject: [PATCH v2 3/4] aio-posix: enable IORING_SETUP_COOP_TASKRUN | IORING_SETUP_TASKRUN_FLAG Date: Wed, 25 Feb 2026 16:13:35 +0800 Message-ID: <20260225081336.1639325-4-stefanha@redhat.com> In-Reply-To: <20260225081336.1639325-1-stefanha@redhat.com> References: <20260225081336.1639325-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.358, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.659, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772007262332158500 Content-Type: text/plain; charset="utf-8" The IORING_SETUP_COOP_TASKRUN flag reduces interprocessor interrupts when an io_uring event occurs on a different CPU. The idea is that the QEMU thread will wait for a CQE anyway, so there is no need to interrupt the CPU that it is on. The IORING_SETUP_TASKRUN_FLAG ensures that QEMU's io_uring CQ ring polling still works with COOP_TASKRUN. The kernel will set a flag in the SQ ring (this is not a typo, the flag is located in the SQ ring even though it pertains to the CQ ring) that can be polled from userspace. Signed-off-by: Stefan Hajnoczi --- util/fdmon-io_uring.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/util/fdmon-io_uring.c b/util/fdmon-io_uring.c index ec056b4818..2e2c0e6785 100644 --- a/util/fdmon-io_uring.c +++ b/util/fdmon-io_uring.c @@ -423,13 +423,16 @@ static int fdmon_io_uring_wait(AioContext *ctx, AioHa= ndlerList *ready_list, =20 static bool fdmon_io_uring_need_wait(AioContext *ctx) { + struct io_uring *ring =3D &ctx->fdmon_io_uring; + /* Have io_uring events completed? */ - if (io_uring_cq_ready(&ctx->fdmon_io_uring)) { + if (io_uring_cq_ready(ring) || + IO_URING_READ_ONCE(*ring->sq.kflags) & IORING_SQ_TASKRUN) { return true; } =20 /* Are there pending sqes to submit? */ - if (io_uring_sq_ready(&ctx->fdmon_io_uring)) { + if (io_uring_sq_ready(ring)) { return true; } =20 @@ -459,7 +462,15 @@ static inline bool is_creating_iothread(void) =20 bool fdmon_io_uring_setup(AioContext *ctx, Error **errp) { - unsigned flags =3D 0; + /* Enable modern flags supported by the host kernel */ + unsigned flags =3D +#ifdef IORING_SETUP_COOP_TASKRUN + IORING_SETUP_COOP_TASKRUN | +#endif +#ifdef IORING_SETUP_TASKRUN_FLAG + IORING_SETUP_TASKRUN_FLAG | +#endif + 0; int ret; =20 /* --=20 2.53.0 From nobody Sun Apr 12 05:51:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1772007303; cv=none; d=zohomail.com; s=zohoarc; b=dFGdT0xPwzhtFve1ltvDF2qQ0s04n+bu+lEmE3eMxkkGzAoms0+41V3ynQ52yDOnFraS+I6g99K+Zefu5ShM0ENqjIXa4FmINtW2sU+mp5A86TzACZIvWwwEj7+1oBTR8mHc4CznyCMPC/uBb2z7gcjm/d2ZZ5k3i0fcY/pjMp4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772007303; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=71PvqljC8jrcUr+AnYkZa4bsSGBsKYrIu/Noafc+YSg=; b=Y6KTg42l4cA0I/U+m94DjLbInRKBmNlVNlJQcFAMth0HaD3VP5BU+fVQHI2p5SB/jeELh2BPsHgdUfZOL011Uo/cms2n8IAl8nEXD1SqBB4mGi0ngZ44qBJZN6GyIA9+UPU/v3HTsHjUo/O1g3AzIvFBCq+/df2P/1c2bwcYxwE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1772007303292160.73039135062947; Wed, 25 Feb 2026 00:15:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vvA21-0000R4-SM; Wed, 25 Feb 2026 03:14:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvA20-0000MK-51 for qemu-devel@nongnu.org; Wed, 25 Feb 2026 03:14:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvA1y-0001nL-Tk for qemu-devel@nongnu.org; Wed, 25 Feb 2026 03:14:03 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-523-_uU6tOYGOs-7poSEx_II9A-1; Wed, 25 Feb 2026 03:13:58 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 60A071800349; Wed, 25 Feb 2026 08:13:57 +0000 (UTC) Received: from localhost (unknown [10.2.16.120]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6FDBC3003D88; Wed, 25 Feb 2026 08:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772007242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=71PvqljC8jrcUr+AnYkZa4bsSGBsKYrIu/Noafc+YSg=; b=GZzdh6LB5igU5chUEJrjbZAgqB0uWF2Sll6pUtXzrCP+644yc5YyVgTSzf8K4QWeEshYGe EgtuRVW5vO507cnV3+s/GHBbKwtxXgbbXKIL0BHJyrJex5jRbBXmVZ7tYQ+lJPpMqqlDhJ eyIW5eaQqE42TmZdcxdrcoLeu0RA6kI= X-MC-Unique: _uU6tOYGOs-7poSEx_II9A-1 X-Mimecast-MFC-AGG-ID: _uU6tOYGOs-7poSEx_II9A_1772007237 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , qemu-block@nongnu.org, Kevin Wolf , Fam Zheng , Jens Axboe Subject: [PATCH v2 4/4] aio-posix: enable IORING_SETUP_NO_SQARRAY Date: Wed, 25 Feb 2026 16:13:36 +0800 Message-ID: <20260225081336.1639325-5-stefanha@redhat.com> In-Reply-To: <20260225081336.1639325-1-stefanha@redhat.com> References: <20260225081336.1639325-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.358, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.659, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1772007304541158501 Content-Type: text/plain; charset="utf-8" This simplifies SQ ring processing and saves CPU cycles. A big improvement is not expected, but it doesn't hurt to enable this flag. Signed-off-by: Stefan Hajnoczi --- util/fdmon-io_uring.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/fdmon-io_uring.c b/util/fdmon-io_uring.c index 2e2c0e6785..99c4932937 100644 --- a/util/fdmon-io_uring.c +++ b/util/fdmon-io_uring.c @@ -469,6 +469,9 @@ bool fdmon_io_uring_setup(AioContext *ctx, Error **errp) #endif #ifdef IORING_SETUP_TASKRUN_FLAG IORING_SETUP_TASKRUN_FLAG | +#endif +#ifdef IORING_SETUP_NO_SQARRAY + IORING_SETUP_NO_SQARRAY | #endif 0; int ret; --=20 2.53.0