From nobody Sun Apr 12 04:21:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1771968241; cv=none; d=zohomail.com; s=zohoarc; b=kcfUd2fSLdRof3ipQqHNEYq/Vcz7/e2Xu+fzyu7KEJO9Jfim3fu2xT8Zsy0dOQaxWp/5GmSdkv+VsXph6btecXuOwknlaBl84H4lMYupj0yf6PMN3j+l9MQQEZb9EjKNTlD3JgV/QlAbc5Ey5FA/hDDDhg9et+MVWSXAdcKIZho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771968241; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=v7DCqEvyzrckcFdroWeW1cjCCZ2EZdMePnVfutEI11Y=; b=HxvCVlnlX7KDZ1k2XTeeuOpwcImj989ahn7DI13Nli63Ap5mzyZJD+09f+v/lbqEXdR1URcN1TmF9ovUVHk6DdZvza1uWxkqB6QABMonHqEJubx/dZdEEKtxDqqFKmbVfrW5He3/NC60CHoy4HwtoGc65Ltf8oy1tXvISQv6RWs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771968241886117.89209096182924; Tue, 24 Feb 2026 13:24:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vuzsL-0002sW-M1; Tue, 24 Feb 2026 16:23:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vuxeQ-00073m-6B for qemu-devel@nongnu.org; Tue, 24 Feb 2026 14:00:54 -0500 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vuxeO-0003KA-NE for qemu-devel@nongnu.org; Tue, 24 Feb 2026 14:00:53 -0500 Received: by mail-qt1-x832.google.com with SMTP id d75a77b69052e-506251815a3so56457871cf.0 for ; Tue, 24 Feb 2026 11:00:51 -0800 (PST) Received: from localhost.localdomain ([207.98.184.46]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5070d3a2dc8sm102616291cf.0.2026.02.24.11.00.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 24 Feb 2026 11:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771959650; x=1772564450; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v7DCqEvyzrckcFdroWeW1cjCCZ2EZdMePnVfutEI11Y=; b=i3A6tm/QYySc18SVRm193mQRB5wBdha6BDQpUlbf8J8YPH59UrdsQldbSQlXoim8T0 WErubc/cU8KwVNokhX9KmA4pna/4COM/9h9DRnu7MOej6G1e+3veQaDX7Tjy6gCB2GgX Fh6ji55yewn8P+O1ALVbMog/HIoWW8jYENu5m1oKQbAh7HEonOXNlltvlPVujoX5pkZy yWmjYEXqWW+4n+35TEW2HR3G5K6G/laKp75YoIQjq/O6gSDXhHTCw489lE8dDvAajg7S 2RbVA0VqrbGNgxWTZNeXDSibG/WVGmnHlkj9rlctkPMxRdQlLMLD2RL7rv6DcsVYqfpl NdWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771959650; x=1772564450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=v7DCqEvyzrckcFdroWeW1cjCCZ2EZdMePnVfutEI11Y=; b=IPMpuZkQqy1R0mHzhEf0eAAdmBSe0P/OoArtQulpvIfCL8mLMqOhK738NbyObAKGwR i+D4TQ2C8GMI5e4tX+GQhcmaBh+VR/7kCuadnou82EOsA4eZfOSVYfL4xefwC8OFkhw0 vl9d3PRhYGCTGwswxfepTnD0PYMuUnihnwO/O5JcOrFAGrI/1Ev9J1GosqNkQ4cPpWXn 7RnzXoxeLt4cryG+lpzxKTlrxQRNgcslM+9//ZkuoC4bfKg8lpiNfWOSoFd4a34Ht8Nx Jy3QhPByga7oqqo2lMs312tq6hupCP1U4bmyevUHN3oId/6XA+8QeniRcy1ZIDz/vSbF 98UA== X-Gm-Message-State: AOJu0YxrX0gBbPoRndvK7MOXc0MJlwHB/bJl9anscUZXuEeBh6qXBV+Z u+QkTrjMDOwP8PjqSw36CP2NJjvoVtwbb1VEpN1pgRmL3G6GySoIqYhmNuXACA== X-Gm-Gg: AZuq6aKdviWfSuXhTbbb6syhaC/YcFIONm6guxe1mP8Alffmwtv6/vdKxRg90iQMvIg Qb+WZbwreo74ui56oy8mhT8ik2HfXTqHfbLv1eNRtZZmkAtg6KEmaBorGjpVdXrX4hMsoMu/1Gl h3rsqLRTeMxiQ3CpT3lqUZ1tEtjWs7Wmw5Gq5khkJjhbXhqNyVBwgak5J7va4vozmesNPMp1rLx GIf/dk8hbw9iaKqD+KL0Q5P02zOeWvw+3G+j6ZEOsec3mSQB/cmTXVfRyjhIc6AE80Je3o9M0/4 LE859v3CpkHmzF980Ji4y74vUDkrCLoMh7QZu6AALhX0p+ihJFK91K80q0YVpKUFL5/dbPWJKaS XfyWMJP+sf+gpRzxJSzC+WfIHSOyv0rVuDA3QWaFb1nrM7IXTPjlwQxikPWLJ9+aAwPiW27Tfan +p3ZqhC6e+2/iHz7Z1LF8b0HI/VEci3qmEmy+K4ucb73icsoyUYIs= X-Received: by 2002:ac8:5711:0:b0:502:a2c0:dc4e with SMTP id d75a77b69052e-5070bba253cmr189366581cf.15.1771959648825; Tue, 24 Feb 2026 11:00:48 -0800 (PST) From: David Hamilton To: qemu-devel@nongnu.org Cc: David Hamilton Subject: [PATCH 1/2] hw/misc/ivshmem-pci: Handle error from kvm_irqchip_add_irqfd_notifier_gsi() Date: Tue, 24 Feb 2026 14:00:03 -0500 Message-ID: <20260224190004.84187-2-dahamilt0@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260224190004.84187-1-dahamilt0@gmail.com> References: <20260224190004.84187-1-dahamilt0@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::832; envelope-from=dahamilt0@gmail.com; helo=mail-qt1-x832.google.com X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FORGED_GMAIL_RCVD=1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 24 Feb 2026 16:23:21 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1771968242719158500 Content-Type: text/plain; charset="utf-8" The return value of kvm_irqchip_add_irqfd_notifier_gsi() was being ignored. Propagate the error to the caller via errp. Resolves the TODO comment at the call site. Signed-off-by: David Hamilton --- hw/misc/ivshmem-pci.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/misc/ivshmem-pci.c b/hw/misc/ivshmem-pci.c index a3a43f53bd..45b0e20363 100644 --- a/hw/misc/ivshmem-pci.c +++ b/hw/misc/ivshmem-pci.c @@ -449,6 +449,7 @@ static void setup_interrupt(IVShmemState *s, int vector= , Error **errp) ivshmem_has_feature(s, IVSHMEM_MSI); PCIDevice *pdev =3D PCI_DEVICE(s); Error *err =3D NULL; + int ret; =20 IVSHMEM_DPRINTF("setting up interrupt for vector: %d\n", vector); =20 @@ -464,9 +465,13 @@ static void setup_interrupt(IVShmemState *s, int vecto= r, Error **errp) } =20 if (!msix_is_masked(pdev, vector)) { - kvm_irqchip_add_irqfd_notifier_gsi(kvm_state, n, NULL, + ret =3D kvm_irqchip_add_irqfd_notifier_gsi(kvm_state, n, NULL, s->msi_vectors[vector].virq= ); - /* TODO handle error */ + if (ret < 0) { + error_setg(errp, "Failed to configure irqfd notifier" + " for vector %d, vector"); + return; + } } } else { /* it will be delayed until msix is enabled, in write_config */ --=20 2.50.1 (Apple Git-155) From nobody Sun Apr 12 04:21:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1771968241; cv=none; d=zohomail.com; s=zohoarc; b=h0Kcp2k27876buQqZJqmPdmRpBXfptZiPkMrmtmP4yMYFmn6WLRRCI3fMjC5yu7s6HIALcCWQ0myalz50JYs7ytoKMIkKoVIcnOdNNTH/7Y95u+SU2gxMo62NEcXmpEU7iOh069WCutlvx1Lh/AgdpOPP4NixlzND9816zALgsk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771968241; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zHVwHrUI/Y9B2elM5BR9o0qWvDqrPxdtG8wtGZdfRks=; b=nVLOVW4wqVIuMpZkDDl52Ka4buDw88Q0fevG4XsOUgrQIqT6GA8y17Z2sVx7KHRiqG/0CRfIayHfJCDwziBHmEPxJn+yHFyelkwAg69sl8wu3ZdJPz4ToECpIfUdE9qxCMj2j1fS7Y8iDXHIlVYd7HYFT6EWBkPp20805bzHiRo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771968241787840.516616740344; Tue, 24 Feb 2026 13:24:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vuzsN-0002sf-AD; Tue, 24 Feb 2026 16:23:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vuxeQ-00073u-Td for qemu-devel@nongnu.org; Tue, 24 Feb 2026 14:00:54 -0500 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vuxeP-0003KF-HU for qemu-devel@nongnu.org; Tue, 24 Feb 2026 14:00:54 -0500 Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-506bad34f51so50314561cf.2 for ; Tue, 24 Feb 2026 11:00:53 -0800 (PST) Received: from localhost.localdomain ([207.98.184.46]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5070d3a2dc8sm102616291cf.0.2026.02.24.11.00.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 24 Feb 2026 11:00:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771959652; x=1772564452; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zHVwHrUI/Y9B2elM5BR9o0qWvDqrPxdtG8wtGZdfRks=; b=L3GcAmfzrLHsrzCztDmnmiAc6dbIk/ev69lpK2V8F1LsOEjCSKKhMs/swM5vT0wyqw ZqwYBKEbqmovvvBEVJaNdHbErkEMHhw6ZLHiekzqTQ9UarWT23ojxPV7gMmmSgI2OIA/ PhRi/tzBP9wztMTlHLpcBfnF+KfAYn48tQjuZPL7X64MVhzHMlYYLJtXjFbpmxNP1TH/ HCxbCi0Imj6jY3AuBtiFSFc1AGfG+mDGKthyI4LTHPJLhHDpGSv8oPQaeJXDvR5WsKFO QB7UuYrzNQzql84RiDS3iA9JTfj3tTv/Nswwx+0UsY7dKl45WV/UhvUyN6za4FQbj0NP H+Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771959652; x=1772564452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zHVwHrUI/Y9B2elM5BR9o0qWvDqrPxdtG8wtGZdfRks=; b=meweH+9Di6W5/bH0qAhcRFWB58WJNiTpNvcbUEDdkFhqY5WIjfgQzgDuLpCfFAM5xN bs3LYMe67ewxPH0vjTiQ9X/VThUp5DVsl1dB+XjAWCMvqejfvBongb6sww4IdN6TGQdJ cbpTsrMtiPyjn3VQ7k2n20PyJAAotFyPN5C9fFVGQhKZidxlronXYANsFSD8rJL0ZDZ6 2M1aS2Ite8HfWoJoTpBSK6jFzNNEzyKYGQkI1JmpPthXy1uXCoCXPA9X91KQdUZOXgzC BLnW82TfQ2PA9xTN24jdsy13inDdEQDWcrCsjPgg+tbvbmX8Hxy43kK8m+3Ka4Pd/bTs zfRw== X-Gm-Message-State: AOJu0YwGcV2PhquziSm0KnuPjKsmJE0rqNrHfqqNTbGcdSHuhE4FiJGF Z8cqY/s8Y3gcuBTsFEglXK6Rz7SEL4bWjExi4lmw8nY2X8YMV24QvRED6oQYAQ== X-Gm-Gg: AZuq6aLb44Zvt9LdN3OmvOa9fzyk8gIQFhVBsF3Jb5eNyFF1kTbl3rRrqog7vpyZRsk p9FkrUaRINfvqnVstp90qZKS7UGLUe6DrwUUbloJUX7TiruhYoiTg3xaEDe9kLEwiOu6qYvHCKZ aaxo2OdB8SpNphaq6ebU2l997O4hrKqOvZpApZYljnUGLkBDrJW1XA4bb7cicdr+IyPKpdLZLa/ O1/ogZIPUwnM9BSIb4wT/STVQ0YDEcrrFThkQlAOMXhfrdVAbD+OQTBS1B34wpb79FBCFSb9UMa DWQSXPihsWiKMjJg7Kfy4WjNunJG36TOjdKixDLshLoNMHFzZENIAE4tFtVp2Mfg7qjs/kL4u8U BN8bSUe6M8RsSBKNCDhxzWh4aJR6bhEK6wr1I8SmNOr4xLQlkRgiJeHNwLN6hFW/g6I/sGIEqCf iw4/XbpZMt0b2I66niRyUvEzBX54nWBZ1BCsUcieWOZaUK/SQzWCmcE8abHMa3PQ== X-Received: by 2002:a05:622a:48:b0:4ee:2459:3d6c with SMTP id d75a77b69052e-5070bcb29e2mr169570411cf.58.1771959651727; Tue, 24 Feb 2026 11:00:51 -0800 (PST) From: David Hamilton To: qemu-devel@nongnu.org Cc: David Hamilton Subject: [PATCH 2/2] hw/misc/ivshmem-pci: Check error after setup_interrupt() in process_msg_connect() Date: Tue, 24 Feb 2026 14:00:04 -0500 Message-ID: <20260224190004.84187-3-dahamilt0@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260224190004.84187-1-dahamilt0@gmail.com> References: <20260224190004.84187-1-dahamilt0@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::82c; envelope-from=dahamilt0@gmail.com; helo=mail-qt1-x82c.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 24 Feb 2026 16:23:21 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1771968242220158500 Content-Type: text/plain; charset="utf-8" setup_interrupt() can fail and report via errp, but process_msg_connect() was ignoring the error and continuing to ivshmem_add_eventfd(). Add ERRP_GUARD() and check *errp to avoid operating on a vector whose interrupt setup failed. Resolves the TODO comment at the call site. Signed-off-by: David Hamilton --- hw/misc/ivshmem-pci.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/misc/ivshmem-pci.c b/hw/misc/ivshmem-pci.c index 45b0e20363..85614feca0 100644 --- a/hw/misc/ivshmem-pci.c +++ b/hw/misc/ivshmem-pci.c @@ -528,6 +528,7 @@ static void process_msg_disconnect(IVShmemState *s, uin= t16_t posn, static void process_msg_connect(IVShmemState *s, uint16_t posn, int fd, Error **errp) { + ERRP_GUARD(); Peer *peer =3D &s->peers[posn]; int vector; =20 @@ -554,7 +555,9 @@ static void process_msg_connect(IVShmemState *s, uint16= _t posn, int fd, =20 if (posn =3D=3D s->vm_id) { setup_interrupt(s, vector, errp); - /* TODO do we need to handle the error? */ + if (*errp) { + return; + } } =20 if (ivshmem_has_feature(s, IVSHMEM_IOEVENTFD)) { --=20 2.50.1 (Apple Git-155)