From nobody Sun Apr 12 04:23:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1771950810; cv=none; d=zohomail.com; s=zohoarc; b=eHG7k1quwr5AZrFk/zzk+BzZZxlUac0C5V/zAA2Zc5IVZoz1yPze6fy7HqcVwoUKXhQbyQD+40ep3wenYq2Zom55n9R4JVFmQnjerhd1TZU8rFyT9bQSTCKO/VKJxIxt4xWlJvORGenr8zGimkEKKJeCcpkS5nB180Y3RnAWghE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771950810; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9ATjKtjnyfdb9iiy9lvTT5oh4WNvvYjgp4AvpGx137Q=; b=YJYd44VSau9C1jX6d+RrxjtWByEmRhSR6v3xSgO/MIfAaRBKratOg2HS7MzUkOIA6IxsAAp+rQhAhDCaXUoHBrDEATCG9wFU6m4bUJEK9KnTTCWUxm67HRkouc0WCiRoUFjs+Gpvg5eVjg2/+6IGYhl7X78XiBFqd0wAFrO5Lho= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177195081063429.97127170595695; Tue, 24 Feb 2026 08:33:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vuvLJ-00061U-Ee; Tue, 24 Feb 2026 11:33:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vuvL3-0005xv-Mh for qemu-devel@nongnu.org; Tue, 24 Feb 2026 11:32:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vuvKw-0006zP-RC for qemu-devel@nongnu.org; Tue, 24 Feb 2026 11:32:40 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-X5PzgzSTN86Im28-h6qI6w-1; Tue, 24 Feb 2026 11:32:32 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6A7781956080; Tue, 24 Feb 2026 16:32:31 +0000 (UTC) Received: from localhost (unknown [10.48.0.202]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8BE7419560A2; Tue, 24 Feb 2026 16:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771950757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9ATjKtjnyfdb9iiy9lvTT5oh4WNvvYjgp4AvpGx137Q=; b=fNQ2TD2UhKC0dLVIooYO2F1LHG/FmqId6BOvimj6kl9oF5/2fvEf/WNC+ATQYIBNllIqHR HSoLzabjlBBcRAHpRVGUIrigBDTfdirTcsoYJaK4LI1padF2vmfJPK6gveyPLgR4jyfvum MuUaIB5KBEFk0A6db4y7USu0b5FJEK0= X-MC-Unique: X5PzgzSTN86Im28-h6qI6w-1 X-Mimecast-MFC-AGG-ID: X5PzgzSTN86Im28-h6qI6w_1771950751 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Subject: [PATCH] audio/mixeng: drop some needless checks Date: Tue, 24 Feb 2026 17:32:29 +0100 Message-ID: <20260224163229.2918858-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.358, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.659, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1771950813166158500 From: Marc-Andr=C3=A9 Lureau The NULL checks for be, name, callback_fn, and as in audio_mixeng_backend_open_{in,out} are redundant: the callers audio_be_open_{in,out} already assert that name, callback_fn, and as are non-NULL, and dereference be unconditionally via AUDIO_BACKEND_GET_CLASS(be) before the call. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- audio/audio_template.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/audio/audio_template.h b/audio/audio_template.h index 228369cf9a1..fe769cde667 100644 --- a/audio/audio_template.h +++ b/audio/audio_template.h @@ -497,12 +497,6 @@ static SW *glue(audio_mixeng_backend_open_, TYPE) ( AudioMixengBackendClass *k; AudiodevPerDirectionOptions *pdo; =20 - if (!be || !name || !callback_fn || !as) { - audio_bug("backend=3D%p name=3D%p callback_fn=3D%p as=3D%p", - be, name, callback_fn, as); - goto fail; - } - k =3D AUDIO_MIXENG_BACKEND_GET_CLASS(s); pdo =3D glue(audio_get_pdo_, TYPE)(s->dev); =20 --=20 2.53.0