From nobody Sun Apr 12 05:51:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1771941409; cv=none; d=zohomail.com; s=zohoarc; b=IVCA+c4UORWHOOmo+PB26x0dj4BYYJvbsWPMYhm4UW9H5hRCtQ0TmECWfMGkZ+QZMjQSPEKGCr0SXnnz6HodUgVRr6cREf24LayJn9VAmTAJhsY4QI7CQ3WzifcJrW0gnMBOSueWWoQ7ICs9Pkex2N5AFXfVtPrjmOS1RwwaxsA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771941409; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cU/0LG7CvSD/ElHhaJzwX+s0/1C+e0sN+ZoFBRB8gcQ=; b=etiI9z1vM01b1CQeZPybayPNjBrTwrbaaCFlCJ7Zs4zvdoqtqdhBxrHBfIdOcCFEVBHEF0xebzES9TXz+fUCm0tDdVm0Nk0Z1ScSkqvr1Ac83EAdPI+Kban0RD/oevZfL0lo4HP/LmEQdz53Hy6GtgxGN4JCHV1HkmVtIR4rJJs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771941409738247.50624201981282; Tue, 24 Feb 2026 05:56:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vustj-0001YO-Kx; Tue, 24 Feb 2026 08:56:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vupgf-0001rl-Ea for qemu-devel@nongnu.org; Tue, 24 Feb 2026 05:30:41 -0500 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vupge-0000Qw-0i for qemu-devel@nongnu.org; Tue, 24 Feb 2026 05:30:41 -0500 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-824adc96ad2so5381439b3a.3 for ; Tue, 24 Feb 2026 02:30:39 -0800 (PST) Received: from kali ([223.223.131.147]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70b7243d48sm10977171a12.21.2026.02.24.02.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 02:30:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771929037; x=1772533837; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cU/0LG7CvSD/ElHhaJzwX+s0/1C+e0sN+ZoFBRB8gcQ=; b=IjCBKiyKZywGb3PLITnMJHXbdXgxEd2MrIYxHrg3CAEJaiJdOtBIi0pRNQ3uIpPAmI vl+6XKn3Yv58tZNT+WeWfpiaHdS4H1ZEQvHciKnUhXF3f1SB7RGhp2baftz8BrZQqjpE pq13e52GV/ldiTBUNKAChn7RJol5OItWNVyfZnO7O1dv8GUVVAZVPxhepYPQE9Ns5wh5 rUESguxqVLRW29hJWwiIL63Db/sXdkbFuMTSiOUrbdmHSeb+8RRjfYk6LTlfTF1yTQ5t JtmzT6qJ90/bQHig5DqcCI2VijnOiKtjKxFbtOeDsJcVt0+/9NRQMX9D30ET0laXbMvD +tig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771929037; x=1772533837; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cU/0LG7CvSD/ElHhaJzwX+s0/1C+e0sN+ZoFBRB8gcQ=; b=uGhsvkXoXjf/OOMDbgpJyipinrGGOYTaTu6xmAjK1IGDmztyMJcln0LsBqaYo+qN5Q bqcO8NM2aarZEZ6PqxNE30LYKWQ1voatyv597lBMREfV6ohPBIZdRcxbxeUJH5mk7y2U psEUpspIq4fKiOq1rAI27B4z2jkD+MJnzfMVyilFDzg4D1KI7Iw4hRigKyrjpzpHGlCV 0TNPAdJnMnjGlNBgv2PVwA5Ez7s198g5dPh2b5g8qbxM1G8E079srf86gKUq3QfLSPnJ WLNzlvp4zLu0CAVWE2WFQ+Br0ok0SbAajiL8d5+3qX164FtbQEp8A3n1u3uvM/ARm3Nz kGVg== X-Gm-Message-State: AOJu0Yx7azAsGPPYthvH3cyHb4bJoPpm5O2irxoSRV8WHFD6oiXwFEPL hvVcGgkC+DJvnEnioEfKiwygHFx1H1BouY9WyFgxkZb6CvtvgYMq4ImuURCQrmtLgw== X-Gm-Gg: AZuq6aK47snduYOBqclndafWle73yoDduObzHDFixZ1b/QMCHant1xx1D9GUU9/7QT5 c3U5dVd/5jDo40Mn8Jm5pq04YmlMbOOgTX5oQoN2/EAJTMay2jO3IQzUiyc1IOLatfaEhKK9cMd WKPEshkKWWh1YvT2mljHnAg17KS8yTAu4XUtgpGvd38P5BVRxPdtjDEMmbdQI/JKb+VrbW7cnnn kCGsPFpttb5Qlj9FhwuzQ/aDaNvo+1oIYE3saLidm8Z9qSdyXXDvOjwlqhdZlrPkxozUyAhs0Io VYryvtFo3MlWwG6MY5xQX0p+/nhqxkSTlpaULMVlwX4y1rO7WRUrGZujEnnkQ3NCZR8BP8Xlu1p 5iReP2bK+2fXKAAb1g44sBZDpl/XiNIIail0/LM11xMGGxy7POgutJNIFZ8n6qwpXKN3l9viUob JMIN9Y5uPsJhZXcXP8u3moQdPLh+NE3g== X-Received: by 2002:a05:6a21:3b89:b0:392:f895:66b5 with SMTP id adf61e73a8af0-39545fc60a4mr10407210637.49.1771929037295; Tue, 24 Feb 2026 02:30:37 -0800 (PST) From: Sourish Dutta Sharma To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, richard.henderson@linaro.org, eduardo@habkost.net, mst@redhat.com, marcel.apfelbaum@gmail.com, Sourish Dutta Sharma Subject: [PATCH] hw/i386/fw_cfg: Use g_new() and g_new0() instead of g_malloc() Date: Tue, 24 Feb 2026 16:00:20 +0000 Message-ID: <20260224160020.137036-1-sourishduttasharma770@gmail.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=sourishduttasharma770@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_03_06=3.027, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 24 Feb 2026 08:56:19 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1771941411773158500 Content-Type: text/plain; charset="utf-8" Replace g_malloc() and g_malloc0() calls that calculate the allocation size using sizeof() with the type-safe g_new() and g_new0() macros. This aligns the code with QEMU's coding style guidelines, improving readability and protecting against potential integer overflow vulnerabilities when allocating arrays. Signed-off-by: Sourish Duttta Sharma --- hw/i386/fw_cfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/fw_cfg.c b/hw/i386/fw_cfg.c index 5670e8553e..ae1ba3b6a2 100644 --- a/hw/i386/fw_cfg.c +++ b/hw/i386/fw_cfg.c @@ -91,7 +91,7 @@ void fw_cfg_build_smbios(PCMachineState *pcms, FWCfgState= *fw_cfg, =20 /* build the array of physical mem area from e820 table */ nr_e820 =3D e820_get_table(NULL); - mem_array =3D g_malloc0(sizeof(*mem_array) * nr_e820); + mem_array =3D g_new0(struct smbios_phys_mem_area, nr_e820); for (i =3D 0, array_count =3D 0; i < nr_e820; i++) { uint64_t addr, len; =20 @@ -207,7 +207,7 @@ void fw_cfg_build_feature_control(MachineState *ms, FWC= fgState *fw_cfg) return; } =20 - val =3D g_malloc(sizeof(*val)); + val =3D g_new(uint64_t, 1); *val =3D cpu_to_le64(feature_control_bits | FEATURE_CONTROL_LOCKED); fw_cfg_add_file(fw_cfg, "etc/msr_feature_control", val, sizeof(*val)); } --=20 2.51.0