From nobody Sun Apr 12 07:21:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=scaleway.com ARC-Seal: i=1; a=rsa-sha256; t=1771948430; cv=none; d=zohomail.com; s=zohoarc; b=AMYVeT3rq4I5kUuDLKpPuY5JxYoLa3CZbc7+K7hNSm10a10eI63v7hqzxIGAzPQ2ui1Y791UbEUtE2UkuGLuO3qBBb2xsMeZIYM3W5CZMQZp1tJZIdZW/yrlhS6AEMcAgJNOeFHcqYC98PPo+uZyMCsKWH41hofLReBSRPNEUy4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771948430; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HBzph0yd8ODlMrDm3zgIFroU1WmXKib1kj+ismUWb8c=; b=ZQhS9yQ5jB7UGaJUznA76qpGmK1edvb9ScYbAK+Lu+eYtRkSpvd63wMnqYmxrclfnITYnVK12yokpLbadJjVl/6KzmSCWQLRY1R4N5IYpJLsQrTL/ipLzSUn8Iek33bbhR2/9fakTN9ZPTBLL/WzEu0NL0yqKwOi0yAtMH/K7yE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771948430646848.4773620701746; Tue, 24 Feb 2026 07:53:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vuuj7-0003jv-GA; Tue, 24 Feb 2026 10:53:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vuuj5-0003i9-7v for qemu-devel@nongnu.org; Tue, 24 Feb 2026 10:53:31 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vuuj1-00084q-I0 for qemu-devel@nongnu.org; Tue, 24 Feb 2026 10:53:30 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4806ce0f97bso46070765e9.0 for ; Tue, 24 Feb 2026 07:53:27 -0800 (PST) Received: from localhost ([2a01:e0a:e9e:c3d0:7a5b:f76a:6cf6:aac2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd765604sm5827415e9.15.2026.02.24.07.53.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 07:53:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scaleway.com; s=google; t=1771948406; x=1772553206; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HBzph0yd8ODlMrDm3zgIFroU1WmXKib1kj+ismUWb8c=; b=I7rX6EREfB9R2/9ez2shqC0DXHpKj7qInHcXGgFpNpUG2O0QZEMBqsUY8FZ48IN9c3 3rJIItiGQX47y5+546wP3bXuCxewKxewLEggURMKY8GOkUzHhSM/PF8mLQFK+4SNofhd kpZ/sOayDCJDFX54G63X7IUyTMSgQLFp5TYo8Xy/m398AvDVJK4ImnPk5jIGBml/1JsR EAAKEER9OdQrKo2DalWVskTMDiOVKK4aElElOHdjAgVbk6Az0BvPpeZre/vz2EHhfY0p GDkr99M1vYjJvvszHMDwtk38T5bM+/nB+XkKchRPnhISJKDSgJV7m9Hn8A+bBpopiWrA J3CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771948406; x=1772553206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HBzph0yd8ODlMrDm3zgIFroU1WmXKib1kj+ismUWb8c=; b=i48K4oJjpZW2T4gWMa/rwjwaAC2Tx3JX1LPsfSuCkNpDxa55z+njCuKaZyfKpurddB VNBdkNVbDzb3yy4Ithb2V0pndb57IOT2T4EhDdhXYuAQKxMMN/yP/Rkh44SgR2M/Vv09 ChgBPPgTD99cOhZu1e724dYu1+09pKfn+0rusxfvlZHIQKrDMS+tYhfxkejyoHYR+CvZ HYuBJ0ICMleBGPs2GnpWegn14bCH/IL4pCbG0X5ymQZDBXNbcCFy85q0fEnxO5yaJ5OX 5XCeqFU8BtvmKFdVYzUR41uVlNBr1iQ7y/Yw2uwFARpSpjLmVmfkXG6MlkpHtQpn82md X6dQ== X-Gm-Message-State: AOJu0YzbeUXgyyhv3Ybi0fIKMJl0VP11EUivn+gaIarIIrWRzPUqWage Fho2RiCqzo3vi82baPieeESCNhdY6BFimujm/uOcReYZUFuv2tMLx2PkxgbvqpmKsaXUvjJebhe 58YJA X-Gm-Gg: AZuq6aKBOvs1u3873tM7hhkE6XtbR1kFXwxSNi1gkkeyY+91PR0TFCwNl90ZMDr/oeo vKJiAaQBodcl5uboH/yDHL/cKEzCK0GOwGXmy31Ih1F1h8rSZWTH/MGxzg46BQj5P5aF5LlBC2p b/VV7s8cq4d6juRuQLbr2Wx+oVeZwCxRgZRRW8lkMLPA5GCtE1evQWtjSCrmKFse97vMJXG2l0F 9m8hAccs98rBJ8yMQ0KuSFzj8jYIiP4xu0cNTxnXLPZ8Z8Ye75zAzxUiBYBHSgX+ohgIoVkuAl1 xgRoWd4EB5P6J/yXyOKCm6BEuLViICUs8SI4gP/5xaq1LFtA5ORUc/01XcP+V2D0TDtun8oYVIb /h+YBalGmtRBvwdR27ZJ9Jh7phjJAOC1MJc8uLIfAHzj1AehH1MfuQJ7vM+sZAs7zIIwzcy2o6S WEa+9RKN4kU0ys/M28U7KJypE= X-Received: by 2002:a05:600c:8b71:b0:483:7980:4687 with SMTP id 5b1f17b1804b1-483a95dd932mr192661685e9.17.1771948405899; Tue, 24 Feb 2026 07:53:25 -0800 (PST) From: Antoine Damhet To: qemu-devel@nongnu.org Cc: Antoine Damhet , qemu-block@nongnu.org, Kevin Wolf , Hanna Reitz , qemu-stable@nongnu.org Subject: [PATCH v2 1/3] block/curl: fix concurrent completion handling Date: Tue, 24 Feb 2026 16:51:29 +0100 Message-ID: <20260224155314.1658988-2-adamhet@scaleway.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260224155314.1658988-1-adamhet@scaleway.com> References: <20260224155314.1658988-1-adamhet@scaleway.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=adamhet@scaleway.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @scaleway.com) X-ZM-MESSAGEID: 1771948433712158500 Content-Type: text/plain; charset="utf-8" curl_multi_check_completion would bail upon the first completed transfer even if more completion messages were available thus leaving some in flight IOs stuck. Rework a bit the loop to make the iterations clearer and drop the breaks. The original hang can be somewhat reproduced with the following command: $ qemu-img convert -p -m 16 -O qcow2 -c --image-opts \ 'file.driver=3Dhttps,file.url=3Dhttps://scaleway.testdebit.info/10G.iso,f= ile.readahead=3D1M' \ /tmp/test.qcow2 Fixes: 1f2cead32443 ("curl: Ensure all informationals are checked for compl= etion") Cc: qemu-stable@nongnu.org Signed-off-by: Antoine Damhet Reviewed-by: Kevin Wolf --- block/curl.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/block/curl.c b/block/curl.c index 4e77c93b46e6..6dccf002564e 100644 --- a/block/curl.c +++ b/block/curl.c @@ -324,17 +324,11 @@ curl_find_buf(BDRVCURLState *s, uint64_t start, uint6= 4_t len, CURLAIOCB *acb) static void curl_multi_check_completion(BDRVCURLState *s) { int msgs_in_queue; + CURLMsg *msg; =20 /* Try to find done transfers, so we can free the easy * handle again. */ - for (;;) { - CURLMsg *msg; - msg =3D curl_multi_info_read(s->multi, &msgs_in_queue); - - /* Quit when there are no more completions */ - if (!msg) - break; - + while ((msg =3D curl_multi_info_read(s->multi, &msgs_in_queue))) { if (msg->msg =3D=3D CURLMSG_DONE) { int i; CURLState *state =3D NULL; @@ -397,7 +391,6 @@ static void curl_multi_check_completion(BDRVCURLState *= s) } =20 curl_clean_state(state); - break; } } } --=20 2.53.0