From nobody Sun Apr 12 02:58:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1771880241; cv=none; d=zohomail.com; s=zohoarc; b=BKbViVjZh0qBAuZYg9sePUBHn8cdirT89K77DNT0z6caZ+aCV6eSx9Vb3V1Fz0gD8DOUxLl5PTE73dUqPz0U5qJwR4DqdEajBBDai6/vQ/tMqTfJD+slUy79VdXHRKc4NA+PC761fodn31pQn4F/2+lju2jBHIWMfiR8w0lSSmE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771880241; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IMYAT0UdSq0H7pvUQzIReqBF5jE1ZDXuCD8wUNNtE9o=; b=cjqONStrIjQGT+7JulXxZ8QU9YNAhNYsUkQf/jKRZI9OQKIGU9d0WGWArJRr4+EDgxx3I/Y/corqO4KDLe46mW7LNiA3ZsRBxaQVYJKDq8TYDqFgV1AX/V/hyMofnRsPffPnaE3kcrClF/5lwjn36KFWUuNgg5+la+wj2m0rqeA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771880241251984.0766050372006; Mon, 23 Feb 2026 12:57:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vucyt-0006aV-Vs; Mon, 23 Feb 2026 15:56:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vucys-0006a6-Hd for qemu-devel@nongnu.org; Mon, 23 Feb 2026 15:56:38 -0500 Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vucyq-000811-UA for qemu-devel@nongnu.org; Mon, 23 Feb 2026 15:56:38 -0500 Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-7d4ba9abbecso4720227a34.1 for ; Mon, 23 Feb 2026 12:56:36 -0800 (PST) Received: from taylor-ubuntu.hsd1.co.comcast.net (c-75-70-169-246.hsd1.co.comcast.net. [75.70.169.246]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d52d04dbf1sm8011996a34.22.2026.02.23.12.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 12:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771880195; x=1772484995; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IMYAT0UdSq0H7pvUQzIReqBF5jE1ZDXuCD8wUNNtE9o=; b=CMlASvLunkEByf3FaYURu76ThHSPqctte0VxZqAXcHrk3e0az87AJAXXM332VRlhKY MSN3Lf8ItgtznFt4pseOQFfrMUVZjP5FoD6OCOQPxBCYdKJGfyHU7wqjd3YsldZMIQvG yox5Ew/0ffhIuIeDnFQ1Wu8STJBUbyP42vyxJKlmDKDhPLyJrhQE4Ie7yKf2L6oYMdih q694D324ZCLsOYyf0f3bb5cubZ1OH/7ebdtSRzN3/v4ayxQ3X6b+qxXTlYX41cOXXOOk yzN3RG3q6V+6W6OZzHL7GPZpYKevo39D4T4z10d7bG8DljLwojTfNEadOemBtQbtPxwJ FIlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771880195; x=1772484995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IMYAT0UdSq0H7pvUQzIReqBF5jE1ZDXuCD8wUNNtE9o=; b=O0jIKrVVn59OUvet+0LYrmmryklZYeIJ4ucXoDla9eJQ+imJ71IGWUEZOJP8GRA7yF mDa6eyOOw7l7gGtrpuv4qKIOroquutTTrQsnAVKf941sZL/P6R7dcxG3KKC9pNGOouai SnLR40txPxtTbfDawYnVX5jRhsH9xkEwJNKdx78Ru9hXJVPO0lbBApHxlYqgP84yaRDs TiP0VSvSJSlp3c28Aj12nTNTC53ZAhPuvL4bxc7RJ8wK1p2wKw6hsZMlYnmof1Jruu/s BECYnwOTHy7FqUZuitd0OACy8OmEWpeXbDBWFJ0zlVDgjCfmp4R5extoysPKQMB9cunQ g1Lw== X-Gm-Message-State: AOJu0YyximKuc7tTs0d9Mdf3i9A2prfavwlO132n4wHTIwPJWwV32B36 6Nq1LfNaT4I1wGxFLoHXsSP3XILyK/vkz2WOjL1rFZXl1u9tW473SwGnDDuE5A== X-Gm-Gg: AZuq6aIiM8PsSLVfsv3ybB8T5p1eT+Qlonu0F+OZQYG1Se2oCwUmPAvE8GtQZbSYiGi GS3NH6FibwS3KeZX9c4FEeLkjrZJE1yRyXM+4gv8U5Gb9m7bHqT1lpL5Wuxwr1V1s0E7MjvsyPZ /qBz3Y1hRUryBCIIa1EQoe5+AwHdZFiDbwW6qqSt/7p2GDyjCMLYg1NfEv5buMqHdQXifGt7/pI bEyp1mE2bxNAWix++JV6smiACkQMRav7v3+tzZZvrx4WhGpP0RjdYaZ5gsSrxVIZyjaG57vGRHQ b2dPMu5G9MrtsuUosHoFRSS+3QCKke287ouoZ3wa88uNh6bVHJcC7AP187uxsjaHUZW8T7yrt6T NbsWzUg2cgE3qQgfDNjh7SK0OdtaSfP6CpQ2pusbBo8wmU/93x+q0hyVnuBDE8lo6LU5N/x4zoK RrvpJyvdx6KHpOQAkz6gAE9iGoM15bKedq/jYaNGSetTvF06Zd0FAHTwoOVlF5NyL15OIJifSJ2 LlxEgFJjqgqIaqS5Cq55N/hXri9maKTVb10Mg== X-Received: by 2002:a05:6830:2aa4:b0:7d4:9679:5797 with SMTP id 46e09a7af769-7d52bf3759cmr7188003a34.28.1771880195074; Mon, 23 Feb 2026 12:56:35 -0800 (PST) From: Taylor Simpson To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, matheus.bernardino@oss.qualcomm.com, sid.manning@oss.qualcomm.com, marco.liebel@oss.qualcomm.com, richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng, anjo@rev.ng, ltaylorsimpson@gmail.com Subject: [PATCH 1/8] Hexagon (target/hexagon) Move code out of gen_start_packet Date: Mon, 23 Feb 2026 13:56:25 -0700 Message-ID: <20260223205632.223714-2-ltaylorsimpson@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223205632.223714-1-ltaylorsimpson@gmail.com> References: <20260223205632.223714-1-ltaylorsimpson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::334; envelope-from=ltaylorsimpson@gmail.com; helo=mail-ot1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1771880242197158500 Move clear_pkt_ctx and analyze_packet out of gen_start_packet Precursor to adding packet validity checks to analyze_packet Signed-off-by: Taylor Simpson --- target/hexagon/translate.c | 46 ++++++++++++++++++++++---------------- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 2fdc956bf9..6e32805202 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -407,29 +407,12 @@ static void mark_implicit_writes(DisasContext *ctx) mark_implicit_pred_writes(ctx); } =20 -static void analyze_packet(DisasContext *ctx) -{ - Packet *pkt =3D ctx->pkt; - ctx->read_after_write =3D false; - ctx->has_hvx_overlap =3D false; - for (int i =3D 0; i < pkt->num_insns; i++) { - Insn *insn =3D &pkt->insn[i]; - ctx->insn =3D insn; - if (opcode_analyze[insn->opcode]) { - opcode_analyze[insn->opcode](ctx); - } - } - - ctx->need_commit =3D need_commit(ctx); -} - -static void gen_start_packet(DisasContext *ctx) +static void clear_pkt_ctx(DisasContext *ctx) { Packet *pkt =3D ctx->pkt; target_ulong next_PC =3D ctx->base.pc_next + pkt->encod_pkt_size_in_by= tes; int i; =20 - /* Clear out the disassembly context */ ctx->next_PC =3D next_PC; ctx->reg_log_idx =3D 0; bitmap_zero(ctx->regs_written, TOTAL_PER_THREAD_REGS); @@ -458,8 +441,29 @@ static void gen_start_packet(DisasContext *ctx) for (i =3D 0; i < NUM_PREGS; i++) { ctx->new_pred_value[i] =3D NULL; } +} =20 - analyze_packet(ctx); +static void analyze_packet(DisasContext *ctx) +{ + Packet *pkt =3D ctx->pkt; + ctx->read_after_write =3D false; + ctx->has_hvx_overlap =3D false; + for (int i =3D 0; i < pkt->num_insns; i++) { + Insn *insn =3D &pkt->insn[i]; + ctx->insn =3D insn; + if (opcode_analyze[insn->opcode]) { + opcode_analyze[insn->opcode](ctx); + } + } + + ctx->need_commit =3D need_commit(ctx); +} + +static void gen_start_packet(DisasContext *ctx) +{ + Packet *pkt =3D ctx->pkt; + target_ulong next_PC =3D ctx->base.pc_next + pkt->encod_pkt_size_in_by= tes; + int i; =20 /* * pregs_written is used both in the analyze phase as well as the code @@ -957,6 +961,10 @@ static void decode_and_translate_packet(CPUHexagonStat= e *env, DisasContext *ctx) words_read =3D decode_packet(ctx, nwords, words, &pkt, false); if (words_read > 0) { pkt.pc =3D ctx->base.pc_next; + + clear_pkt_ctx(ctx); + analyze_packet(ctx); + if (pkt.pkt_has_write_conflict) { gen_exception_decode_fail(ctx, words_read, HEX_CAUSE_REG_WRITE_CONFLICT); --=20 2.43.0