From nobody Sun Apr 12 04:27:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1771866395; cv=none; d=zohomail.com; s=zohoarc; b=moXrbHQt5o2oUuEjHS7qEHB+eqmMQ4ZDpXX3Zv1M91MB9y1dV/0rQ5U7nZRAdtOOpC2+hwnLULGyhW66xGkr0Gmlo/tn1n51KWCfKgieVRrQXKx7cz2x1qH7Esw/CKYtWFFSfurM7Blxoyx38QeeIdyNzkJW+yn3nlrj/4Gq3Ew= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771866395; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=3CiLooo2/Er7yqErGfmdNwNkycKNCQ+U0Fgk+KNKPMo=; b=XKw5iGdUBJWLlJWWWtpvX43JdNyUueicEZw6tC6c0v3JK5tM0cdX2JJQuURJsgkGAqXt3qgZ094osLdWxVi3h2aiBIuMkSWmbWWL+SejvCaXsP1Se/jcTABKP2wAWRVDOzqRiS6LT5NoXfJmIF/24kMQP67Tu3MjmqSCciMv0UE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771866395025701.4756982765729; Mon, 23 Feb 2026 09:06:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vuZKH-0001N3-2v; Mon, 23 Feb 2026 12:02:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vuZKF-0001LU-K7 for qemu-devel@nongnu.org; Mon, 23 Feb 2026 12:02:27 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vuZKD-00005p-OA for qemu-devel@nongnu.org; Mon, 23 Feb 2026 12:02:27 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4806ce0f97bso36855455e9.0 for ; Mon, 23 Feb 2026 09:02:25 -0800 (PST) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a9b21ceasm200155625e9.0.2026.02.23.09.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 09:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771866144; x=1772470944; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=3CiLooo2/Er7yqErGfmdNwNkycKNCQ+U0Fgk+KNKPMo=; b=Gk8EFRWF4KqC+rxYuYYbKh9Us7KizUiTT31OIThBrFDBcNtVrMfjZh6hHkf2/C/NBy VF21+Fkylo8NcRn2hSx2QG9Q0Vooods5pJwHLz31OpfHhQvWXrIP0sR09S8Jp3LP8gZF WbHxyBbDqIkvu15Sl5PMtj4xBI7gLSEEzzWmP0iIAGaso8jrdfGYDFHxdFu8IweRmMNP DsIS/P+YncxLdok85L/2UdNVMwxWqF8q2Mh9f6eHRgwETK+MIV6RlrRMDhPVOBkPB3G8 /VURs+MUC4we6ecd5Zg9Ph1D+6QCVtc5C4TUpuxYjMpLHuZ7Kix4EAXwfHNAhh6wsyWG WGyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771866144; x=1772470944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3CiLooo2/Er7yqErGfmdNwNkycKNCQ+U0Fgk+KNKPMo=; b=wk2d0heJWa0Wk7oN4I9PErKLGUMlCmq03ywWEq+WbA71G0gMfUPFrzLTo8YcXwci4b WTEhDwVWm6h41QrmHQTWAbb1Nll3JiPN75lDnpErFNw2d0hgskNe1h1dHgK4Gr7CyElu YXvAu5UkMUJfrnXGGIFHUxKiczctumK5lBKwC2bUeOlk+uI2fsKGs7m5p06DapkIclhK /ss9aFdMokGgCrofmxcbO2JHte4uvI0w2k7ykd0gQ8AB4Zpjz2XSUcnjHpPEq7DWWw75 Q29Uq+80DE0HcnrnST0N16srrpoc323r/8ClJk7EmMmSBzQ5e4MHqCHnjJHiWZ5p2CLJ N5yw== X-Forwarded-Encrypted: i=1; AJvYcCXu3YwgrT4/YrNvOpGH5n4H9WNSaZhoxIBFQRHFJdrsiRaPgfOCis4zQ1hPZVNRMKAJaq6QdiLFtWdl@nongnu.org X-Gm-Message-State: AOJu0Yx1LcMqEUkdaGCcsfo2wMNHBtrJl0vOxxWtjbjPjoDOid1MWEeA F4gJzSUiPXAMSEoJNpkrXcJJxg/8HQcnvavSuzX54OH6N0C7GbEe2CxzR9Hr+6jg8mk= X-Gm-Gg: AZuq6aKYk0ettLqEH1HTl3c6e5JroJ7GFacOF7XivL5R93ih7xCOpXw/BtAUD4qMYn5 r6Oz6ZY6eXu5nF1G5ghjLw7ffXgA6moQIJolLYOhrNq921PAhxz4aLx0vOC+yfSTLf7zZc0WF9a aAbV1spcezQWG4eAp1PKvKjgL48qTA1Ah1jmPY02gNQt8OWZBjuhv0vv8pgz+gwsavAUmNXgPBu BCVpbos0K6q+qQsyzrnEjzA7EtKlv/Sxqyy28100GRmGywDtyFRN1lCRluY7fCwyBy0q9dP0c/E Fhw0SPcP86n1AwARoShiMmNtoLbUd9DejweJtl+yDA2PlMs+d/ebHngt6b0dqL62MNisO3Y3sdH JaFQV0U2MQwTY1LkESLbPgjVFzBgXDxK/Ov17hzXmk8+c64Xkewokfjz5lEo1bRMItFGI0i8Gho Bdm3rsHBHUO2zBG23lyfP+LvEfI1wHSS0c401q1SRxmePkhDIlUU7GOkdeOhZ6Nnez6911f6Ciw 7tQ7cfb/mKtHM+hodVXmDOhxLF13rU= X-Received: by 2002:a05:600c:4589:b0:480:1e9e:f9b with SMTP id 5b1f17b1804b1-483a95dea3emr195439745e9.16.1771866144121; Mon, 23 Feb 2026 09:02:24 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 09/65] hw/intc/arm_gicv5: Implement IRS ID regs Date: Mon, 23 Feb 2026 17:01:16 +0000 Message-ID: <20260223170212.441276-10-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260223170212.441276-1-peter.maydell@linaro.org> References: <20260223170212.441276-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1771866414272158500 Content-Type: text/plain; charset="utf-8" Implement the IRS frame ID registers IRS_IDR[0-7], IRS_IIDR and IRS_AIDR. These are all 32-bit registers. We make these fields in the GIC state struct rather than just hardcoding them in the register read function so that we can later code "do this only if X is implemented" as a test on the ID register value. Signed-off-by: Peter Maydell --- hw/intc/arm_gicv5.c | 112 +++++++++++++++++++++++++++++ include/hw/intc/arm_gicv5_common.h | 39 ++++++++++ 2 files changed, 151 insertions(+) diff --git a/hw/intc/arm_gicv5.c b/hw/intc/arm_gicv5.c index db754e7681..f34bb81966 100644 --- a/hw/intc/arm_gicv5.c +++ b/hw/intc/arm_gicv5.c @@ -268,6 +268,62 @@ REG64(IRS_SWERR_SYNDROMER1, 0x3d0) static bool config_readl(GICv5 *s, GICv5Domain domain, hwaddr offset, uint64_t *data, MemTxAttrs attrs) { + GICv5Common *cs =3D ARM_GICV5_COMMON(s); + uint32_t v =3D 0; + + switch (offset) { + case A_IRS_IDR0: + v =3D cs->irs_idr0; + /* INT_DOM reports the domain this register is for */ + v =3D FIELD_DP32(v, IRS_IDR0, INT_DOM, domain); + if (domain !=3D GICV5_ID_REALM) { + /* MEC field RES0 except for the Realm domain */ + v &=3D ~R_IRS_IDR0_MEC_MASK; + } + if (domain =3D=3D GICV5_ID_EL3) { + /* VIRT is RES0 for EL3 domain */ + v &=3D ~R_IRS_IDR0_VIRT_MASK; + } + return true; + + case A_IRS_IDR1: + *data =3D cs->irs_idr1; + return true; + + case A_IRS_IDR2: + *data =3D cs->irs_idr2; + return true; + + case A_IRS_IDR3: + /* In EL3 IDR0.VIRT is 0 so this is RES0 */ + *data =3D domain =3D=3D GICV5_ID_EL3 ? 0 : cs->irs_idr3; + return true; + + case A_IRS_IDR4: + /* In EL3 IDR0.VIRT is 0 so this is RES0 */ + *data =3D domain =3D=3D GICV5_ID_EL3 ? 0 : cs->irs_idr4; + return true; + + case A_IRS_IDR5: + *data =3D cs->irs_idr5; + return true; + + case A_IRS_IDR6: + *data =3D cs->irs_idr6; + return true; + + case A_IRS_IDR7: + *data =3D cs->irs_idr7; + return true; + + case A_IRS_IIDR: + *data =3D cs->irs_iidr; + return true; + + case A_IRS_AIDR: + *data =3D cs->irs_aidr; + return true; + } return false; } =20 @@ -443,6 +499,60 @@ static void gicv5_reset_hold(Object *obj, ResetType ty= pe) } } =20 +static void gicv5_set_idregs(GICv5Common *cs) +{ + /* Set the ID register value fields */ + uint32_t v; + + /* + * We don't support any of the optional parts of the spec currently, + * so most of the fields in IRS_IDR0 are zero. + */ + v =3D 0; + /* + * We can handle physical addresses of any size, so report + * support for 56 bits of physical address space. + */ + v =3D FIELD_DP32(v, IRS_IDR0, PA_RANGE, 7); + v =3D FIELD_DP32(v, IRS_IDR0, IRSID, cs->irsid); + cs->irs_idr0 =3D v; + + v =3D 0; + v =3D FIELD_DP32(v, IRS_IDR1, PE_CNT, cs->num_cpus); + v =3D FIELD_DP32(v, IRS_IDR1, IAFFID_BITS, QEMU_GICV5_IAFFID_BITS - 1); + v =3D FIELD_DP32(v, IRS_IDR1, PRI_BITS, QEMU_GICV5_PRI_BITS - 1); + cs->irs_idr1 =3D v; + + v =3D 0; + /* We always support physical LPIs with 2-level ISTs of all sizes */ + v =3D FIELD_DP32(v, IRS_IDR2, ID_BITS, QEMU_GICV5_ID_BITS); + v =3D FIELD_DP32(v, IRS_IDR2, LPI, 1); + v =3D FIELD_DP32(v, IRS_IDR2, MIN_LPI_ID_BITS, QEMU_GICV5_MIN_LPI_ID_B= ITS); + v =3D FIELD_DP32(v, IRS_IDR2, IST_LEVELS, 1); + v =3D FIELD_DP32(v, IRS_IDR2, IST_L2SZ, 7); + /* Our impl does not need IST metadata, so ISTMD and ISTMD_SZ are 0 */ + cs->irs_idr2 =3D v; + + /* We don't implement virtualization yet, so these are zero */ + cs->irs_idr3 =3D 0; + cs->irs_idr4 =3D 0; + + /* These three have just one field each */ + cs->irs_idr5 =3D FIELD_DP32(0, IRS_IDR5, SPI_RANGE, cs->spi_range); + cs->irs_idr6 =3D FIELD_DP32(0, IRS_IDR6, SPI_IRS_RANGE, cs->spi_irs_ra= nge); + cs->irs_idr7 =3D FIELD_DP32(0, IRS_IDR7, SPI_BASE, cs->spi_base); + + v =3D 0; + v =3D FIELD_DP32(v, IRS_IIDR, IMPLEMENTER, QEMU_GICV5_IMPLEMENTER); + v =3D FIELD_DP32(v, IRS_IIDR, REVISION, QEMU_GICV5_REVISION); + v =3D FIELD_DP32(v, IRS_IIDR, VARIANT, QEMU_GICV5_VARIANT); + v =3D FIELD_DP32(v, IRS_IIDR, PRODUCTID, QEMU_GICV5_PRODUCTID); + cs->irs_iidr =3D v; + + /* This is a GICv5.0 IRS, so all fields are zero */ + cs->irs_aidr =3D 0; +} + static void gicv5_realize(DeviceState *dev, Error **errp) { GICv5Common *cs =3D ARM_GICV5_COMMON(dev); @@ -469,6 +579,8 @@ static void gicv5_realize(DeviceState *dev, Error **err= p) * NS domain. */ cs->implemented_domains =3D (1 << GICV5_ID_NS); + + gicv5_set_idregs(cs); gicv5_common_init_irqs_and_mmio(cs, gicv5_set_spi, config_frame_ops); } =20 diff --git a/include/hw/intc/arm_gicv5_common.h b/include/hw/intc/arm_gicv5= _common.h index be898abcd5..bcf7cd4239 100644 --- a/include/hw/intc/arm_gicv5_common.h +++ b/include/hw/intc/arm_gicv5_common.h @@ -65,6 +65,18 @@ struct GICv5Common { /* Bits here are set for each physical interrupt domain implemented */ uint8_t implemented_domains; =20 + /* ID register values: set at realize, constant thereafter */ + uint32_t irs_idr0; + uint32_t irs_idr1; + uint32_t irs_idr2; + uint32_t irs_idr3; + uint32_t irs_idr4; + uint32_t irs_idr5; + uint32_t irs_idr6; + uint32_t irs_idr7; + uint32_t irs_iidr; + uint32_t irs_aidr; + /* Properties */ uint32_t num_cpus; ARMCPU **cpus; @@ -84,6 +96,33 @@ struct GICv5CommonClass { =20 #define IRS_CONFIG_FRAME_SIZE 0x10000 =20 +/* + * The architecture allows a GICv5 to implement less than the + * full width for various ID fields. QEMU's implementation + * always supports the full width of these fields. These constants + * define our implementation's limits. + */ + +/* Number of INTID.ID bits we support */ +#define QEMU_GICV5_ID_BITS 24 +/* Min LPI_ID_BITS supported */ +#define QEMU_GICV5_MIN_LPI_ID_BITS 14 +/* IAFFID bits supported */ +#define QEMU_GICV5_IAFFID_BITS 16 +/* Number of priority bits supported in the IRS */ +#define QEMU_GICV5_PRI_BITS 5 + +/* + * There are no TRMs currently published for hardware + * implementations of GICv5 that we might identify ourselves + * as. Instead, we borrow the Arm Implementer code and + * pick an arbitrary product ID (ASCII "Q") + */ +#define QEMU_GICV5_IMPLEMENTER 0x43b +#define QEMU_GICV5_PRODUCTID 0x51 +#define QEMU_GICV5_REVISION 0 +#define QEMU_GICV5_VARIANT 0 + /** * gicv5_common_init_irqs_and_mmio: Create IRQs and MMIO regions for the G= ICv5 * @s: GIC object --=20 2.43.0