From nobody Sun Apr 12 04:21:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass(p=none dis=none) header.from=collabora.com ARC-Seal: i=2; a=rsa-sha256; t=1771546925; cv=pass; d=zohomail.com; s=zohoarc; b=SMUEAA2pZx6yvVnk6qkyqbYntQtI6DK3jkkSkK2QrX6JokIO+8it6lk0Xu+yKeYZJ8pcec+PumvW15MsOdG6YyKdZbtcCiwzPoErRSs9X9/IiY1f858Zncsp31kVh1J9v+oKHn4RZ7Nc2BvvX+kXEH6cNCdpHYkdZa5YJfM1UMg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771546925; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=F/EWxhbeU7VTOhY4KWpq/G0UseqvLCxgV+eog6p5bcs=; b=fZ1yeEHaj4+4dPud44gSKpD52Yqhq4vxSGQutlUG5fTMZ4C9rcJgdqUOxL+E/zsxn1KqT/xLbn2y2bMzXiLqjwtyyCkumZdXRdzZJTHpTcmLDBndImaRSTAEWkUE9s0cZag9X9Zfo6Glxh39ocAhtSF4BEhChfSq/5WMnbY7IPc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771546925923422.2976107716844; Thu, 19 Feb 2026 16:22:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vtEHP-000079-Uq; Thu, 19 Feb 2026 19:22:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vtEHN-0008KZ-Qm for qemu-devel@nongnu.org; Thu, 19 Feb 2026 19:21:57 -0500 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vtEHM-0004uE-79 for qemu-devel@nongnu.org; Thu, 19 Feb 2026 19:21:57 -0500 Received: by mx.zohomail.com with SMTPS id 1771546898020622.9233293168195; Thu, 19 Feb 2026 16:21:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771546899; cv=none; d=zohomail.com; s=zohoarc; b=JbnGw0PCRxtEUcwe4OMEQcvV8Eu5ORJNyRrZABVwRRFOdsoKFjvqTW/p4TO0p1CqbC8jQfKPyNTYhk1KsRJa+aLfGUgVGptY38MchiKQMSC3ki5l/Jj/ZkaV/8XpDjqks+0IjWR/C1chrRUwDC3IYVLh5gSlkjgVnmLDJetLPBY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771546899; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=F/EWxhbeU7VTOhY4KWpq/G0UseqvLCxgV+eog6p5bcs=; b=DYXOTIGWiUdbOkkGYx6AWr0loEziLNNL2JSV72F87rdPZImIjyQEX390wet6lQXlDe1irI12akyMLCDKct32e2x8GBS75OJ/SHEIRhyi6xoMa8b1pwxrh6Cz4HcbBRgt1cFxLXKrfcWYOEKNg3jfrJIjptsEIjUSrF16iWdx+q4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771546899; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=F/EWxhbeU7VTOhY4KWpq/G0UseqvLCxgV+eog6p5bcs=; b=O8ej53Np9i88IRJPWVbBFL/XcDgF+CNudNyx45i9tvu1S/xFuXT5UydPX4T9bugP 6y5tUaXMFUvu/9RSxmQQWkIThPP9uYU3LlRW3hLfg0dwmNpoJOXoZ3XyIIFVrjDx+/K jX9Poa8gi/jybxXQK0tlml8O0MiAYgVOOwF1mFUc= From: Dmitry Osipenko To: Akihiko Odaki , Huang Rui , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierre-Eric Pelloux-Prayer , "Michael S . Tsirkin" , Paolo Bonzini , Yiwei Zhang , Sergio Lopez Pascual Cc: Gert Wollny , qemu-devel@nongnu.org, Gurchetan Singh , Alyssa Ross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian , Rob Clark , Robert Beckett Subject: [PATCH v19 16/20] virtio-gpu: Remove superfluous memory_region_set_enabled() Date: Fri, 20 Feb 2026 03:16:30 +0300 Message-ID: <20260220001634.3579257-17-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260220001634.3579257-1-dmitry.osipenko@collabora.com> References: <20260220001634.3579257-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.188.112; envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com) X-ZM-MESSAGEID: 1771546927639158500 There is no need to explicitly enable/disable memory region when it's added or deleted respectively. Remove superfluous set_enabled() calls for consistency. Suggested-by: Akihiko Odaki Reviewed-by: Akihiko Odaki Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index d21767b45d11..b24386544e1b 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -171,7 +171,6 @@ virtio_gpu_virgl_map_resource_blob(VirtIOGPU *g, mr =3D &vmr->mr; memory_region_init_ram_ptr(mr, OBJECT(vmr), "mr", size, data); memory_region_add_subregion(&b->hostmem, offset, mr); - memory_region_set_enabled(mr, true); =20 res->mr =3D mr; =20 @@ -225,7 +224,6 @@ virtio_gpu_virgl_unmap_resource_blob(VirtIOGPU *g, b->renderer_blocked++; =20 /* memory region owns self res->mr object and frees it by itself */ - memory_region_set_enabled(mr, false); memory_region_del_subregion(&b->hostmem, mr); object_unparent(OBJECT(vmr)); } --=20 2.52.0