From nobody Sun Apr 12 07:20:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1771509366; cv=pass; d=zohomail.com; s=zohoarc; b=C4GFaT5SclKFgKDr6i6VuPCVhimU8zp9gDKb5LNfg5N1LzoFZbFJDw1A6+w4Q96WVTwBWBIvaCa20N7V0L6D/0YpjdiqK9c6PzfN7gxCyR6730W1xX12bL3yyS6FlhDpfisdeHBweWvRHfw9nODfsimBCrZTmOt1ysIMRXmlzKI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771509366; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=71o6qenLaZ7N1XnkNxV11kgRCkClxcrws2LdMb8phAk=; b=JXC50wl1AZKFeHQV9sPkRLMpOKVCrXgwnDlwJtcQo3+MTjz22wQY0mDUzNqKSjAXKXXTiDAydqqZGv2QHbnxAJ1QXiF1RkGWfnjnmRMj5/fLy2E7BM9a/wRLRaIHs4sq+LgXksk+5CmXgB0vJjRIloG0GIAHKeoW5aE6jzCAdEs= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771509366128316.5014573503904; Thu, 19 Feb 2026 05:56:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vt4VK-0007PY-Bg; Thu, 19 Feb 2026 08:55:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vswp3-0006LA-Vt for qemu-devel@nongnu.org; Thu, 19 Feb 2026 00:43:34 -0500 Received: from mail-westusazlp170120002.outbound.protection.outlook.com ([2a01:111:f403:c001::2] helo=SJ2PR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vswp2-0007hi-2s for qemu-devel@nongnu.org; Thu, 19 Feb 2026 00:43:33 -0500 Received: from SJ0PR05CA0064.namprd05.prod.outlook.com (2603:10b6:a03:332::9) by DM4PR12MB6375.namprd12.prod.outlook.com (2603:10b6:8:a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.13; Thu, 19 Feb 2026 05:43:26 +0000 Received: from SJ1PEPF00001CDD.namprd05.prod.outlook.com (2603:10b6:a03:332:cafe::84) by SJ0PR05CA0064.outlook.office365.com (2603:10b6:a03:332::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.13 via Frontend Transport; Thu, 19 Feb 2026 05:42:51 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF00001CDD.mail.protection.outlook.com (10.167.242.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Thu, 19 Feb 2026 05:43:25 +0000 Received: from brahmaputra.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 18 Feb 2026 23:43:22 -0600 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YR+9AnmQF+oDC8pwMoxyeamnBsmxr4kbKkknIdA5bxmYTfKFqN0zfGLv65BnB5Uiuk/8GnXehGSyrlhkQHscx0YI/L1dzntspi71WabPD4TH0qlTelE3un2ER9K81tZ8u+/JtQcsZXKYQVHsqEgPIKmjsqCqqTVOFtQfdD2cH240BKhzMDMva18UnoNkymadA0CMmDIElFZ8QfR1WhZFoRt3pANLRuW+yR9UJji8nPvxyxXEs1Bl741aDEA9cS9y0iDiboqWltCinIEytUajPf/2s62oiTeItrHFe2T14qdF1PEywsfsBWID9AnoUE0MxaiRUXfIltPG/xFM5fmGkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=71o6qenLaZ7N1XnkNxV11kgRCkClxcrws2LdMb8phAk=; b=qM51Z4QZXO7egccDRUKjVs9Ca+aP6sA0e4XtWxaz4WRLOlgH96yEEHsTzUeM8N8aLJ6ZdYcn3Ja78F925osvSPz03tfzBEBKlppXTGWLX/G6KWd7woxG7R1BZS290m6auwuxfTUUgOg6VtRe1F69j1u5HxGwPAFneEOV8DkdRcvjGaruiXFEh07l46dU+vyehTSmIPk51SgXM2Fj0wjkB6BogBoVcVHFrdci57Pi5QIB4dCTQ7GLj3YYb270PyYSJk/u2A+kju77z4daSjVMSegpdIcdmBWqOQM3LyqKx2YVT3BxHji8AyWNyr4B7FUvLVXFCFhKNF/UpnnBx5YCwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=71o6qenLaZ7N1XnkNxV11kgRCkClxcrws2LdMb8phAk=; b=jdpwZMqExJZfUdelyCYYDbNTAXwmJ6wAyuMcMxl7S0fiNyONB+QNaUaSp3FCqzNTXWJs7xu57oudhhUTvo8dhPonDoOSb/DsIsuurYWRh42yGzGJcCUSCQUfT6oqnfy64gb+AN2xBokQ/nDtmMZJ62UbFNxQf1mXq92IM/bL9tY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C From: Manali Shukla To: CC: Cornelia Huck , Eduardo Habkost , , Marcel Apfelbaum , "Marcelo Tosatti" , "Michael S . Tsirkin" , "Paolo Bonzini" , Sean Christopherson , Richard Henderson , Naveen N Rao , Nikunj Dadhaniya , Subject: [PATCH v1 2/8] i386/kvm: Pass APICCommonState directly to kvm_get_apic_state() Date: Thu, 19 Feb 2026 05:42:01 +0000 Message-ID: <20260219054207.471303-3-manali.shukla@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260219054207.471303-1-manali.shukla@amd.com> References: <20260219054207.471303-1-manali.shukla@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CDD:EE_|DM4PR12MB6375:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bc12135-9b33-4fd6-6586-08de6f79cd58 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|7416014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?jSlA4wsCmnL1E+bTUJEoUBcI3d0sthvKw6RPoZ+Eufi7IUc0hQNzGQm/nsp+?= =?us-ascii?Q?T1TnnDliV2zJe3TYjZ/zGBpWOEOaRbucCkqaO1hj3wD6osg/b4W02gbFYEbb?= =?us-ascii?Q?MiD8bYw6rW2nLsqurw2i7MOkbB5yy+pcYSGDyub/GlbNrrEz6ezwewb7ZeLY?= =?us-ascii?Q?vraLdlQ35TkFSooEjx4gsy83Vt2tcRlyIV4OtrlP8Q08YYgoG6fl0sVAeh6z?= =?us-ascii?Q?e00jUtAo/v7AMJTU2veS2L9mlkpggVA3RWANDUAk8Lhmi7QtEbLhksuP4AdG?= =?us-ascii?Q?JAjzLSV3n8toSU2cI3M8IoLzUnvRKYn7Gwpu7y99DnVvBumn2ZJSQYUIctNM?= =?us-ascii?Q?+4D7Kzy9IaIgz8mBpiQiyfn4USuy9qI3uOkZg2uAFfaOeahbf73iMVFJn7ZS?= =?us-ascii?Q?Gozo4HNbL/tT0Ui7hVsk3L5BtrZO8CI7ZHNWIOdbNzzSxZQKNjRt6fdHX9g0?= =?us-ascii?Q?JOcMREV1SH8+KAEki4GPNSfO97kRfIL25XjEj5Q1Cr70cNtHSHwiZoJ0QrA6?= =?us-ascii?Q?mfa9IvF35Jxn+4A9dZuQMaJ/h3m6hoO0ttiJYdPT+sR+UydHc3OYE8aTWfoP?= =?us-ascii?Q?u5jZmvUNfZWDgFU9jf6pNBi7wNSaZs8eTPoj1B4218lRGMa79moeWIgNZoJP?= =?us-ascii?Q?yXReKQfLzNqrZRvPjHhpHDbz3S89wavZ9neNA3YlBgmN6Am33Fp81Z+dh/vB?= =?us-ascii?Q?2R70/t4ca7QDB6LMfGUq3odomOA7/bXC5gzjpKcWWiI95IwDR4ZYZtVAYdO2?= =?us-ascii?Q?zuc05u+Bnk+u3RBp08VK3zjRdO8Bl7QYk746B0+vOaErdfTnAnT+ZodPaHAv?= =?us-ascii?Q?soKr58o688aJe2eO9PGPcZXnu9IO/DEPTssSHB0cnpl35d7u0fDnR4LDK7Px?= =?us-ascii?Q?gRSoxUL9jKAoUPZ6i2XdmyTKUsrAni9/Os/T+1l/rJpeHiqiGlk2B2VjBx0d?= =?us-ascii?Q?W3vfLow44ncnNAmEiutzEN5K/mSOkUZZkMSZXO0lNQSvY4h2jv1axvP2L44T?= =?us-ascii?Q?5/++ZW61xLgqvrIXpEl4c9PTBZciJ2z1KO73y3/C+MNoygz1bFevWSh+v/Rx?= =?us-ascii?Q?qbQTV4ZEqq4sdSR0AdL2+bJmIffNSnk6OIs8rq8PVxWMvV/ZZ+qfZM0GUydF?= =?us-ascii?Q?4G4b2M+gmCSJicPuV2zzimZW3EEPrJAaq/lB+4G0D/ySlxeeF/LjEDE06xs5?= =?us-ascii?Q?mdhQYhScDMpq03JcBOjLUtaST841hAYMORyyhZR+/5LVzbAQYWKUDQ8IuPKU?= =?us-ascii?Q?Z1wT5FAWd37f/eoUnx+6H0KwdFbUg02dzfHN6zrCgPuMKhAHaKxf92HMiWHB?= =?us-ascii?Q?2FyLk4r9daA5o+uIHPfnvbBTUIJ8aPr8MOEr4VjysSqfKB/USK+mhww9LOdO?= =?us-ascii?Q?dF142vbssYu+i8st1FIPBQstrRBGAwXKnkMBhM3N4s0PgEz4lOMNyunqoDvW?= =?us-ascii?Q?E8i2dbW9XX04w1JCrZD5Q5xW/ECymDIsisTbzGXTzkmi4yDBWegfSfN1hZ9Y?= =?us-ascii?Q?DFS47Gp8BivISYllLWQ+iuR94YJbgUH54WOOWT+JnOJENpP8eLbYSxkvqKu/?= =?us-ascii?Q?paw97dJ+dwNeaEDK2NCxYX9TweQ8aJtzsEpphy3oObyMc23BSvrGGD3Tozbd?= =?us-ascii?Q?ugLQH9YnqmnWiY2ODKNHNPFXwsqDVerrRGJzklndDERaYfaJ6HHb5VTylQVL?= =?us-ascii?Q?r7SqaA=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(376014)(7416014)(36860700013)(82310400026); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: K62JlbuKG4aeIQblucZMx+BGDq1YW51eFwkSjLUMKTmrU6f/j2gKHATuRkRS2VQgbicgStu1dbqfriCzCCSM/XgXtmp7Cy6NSpEC+VtyZkej6EsqDJCffXSuUZVDGCsr+la3aHgLDcVPz59lTAnKPrULL3myMrPJJAyAGiXAabq6xJ5ApcZO8STlCRxCMyhNSGN0DcDw5VyjZoUKm3y/k+oGvXo0bplfIH8OM/0Xxh41u4Y/gMkdysI15f6Lmwe5m7yJzXGKvbqRfVDexZzyoYFY/OI8sgCaWuMGpwS9GKCW5IpZwwoB1BdYLD5TcsUjz1CehV+bMIM/lIwFWmnbiaHt2zjkF7eUTl+RgqpPO9uSt39daODX/gmr2VQnBZQBH4DOwqEgj2tHMydKxuIEAlN2ilYQkIXgSFsZj2pG1WzDNV5npJt2A9wN+XT2V6nl X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2026 05:43:25.9019 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc12135-9b33-4fd6-6586-08de6f79cd58 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CDD.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6375 Received-SPF: permerror client-ip=2a01:111:f403:c001::2; envelope-from=Manali.Shukla@amd.com; helo=SJ2PR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 19 Feb 2026 08:55:31 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1771509371750154100 Content-Type: text/plain; charset="utf-8" Change kvm_get_apic_state() to accept APICCommonState pointer directly instead of DeviceState, eliminating the need for APIC_COMMON() cast inside the function. The caller (kvm_get_apic) now performs the cast once, making the code cleaner and preparing for extended APIC state handling. No functional change intended. Signed-off-by: Manali Shukla --- hw/i386/kvm/apic.c | 3 +-- target/i386/kvm/kvm.c | 3 ++- target/i386/kvm/kvm_i386.h | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c index c1866c3939..9489614bca 100644 --- a/hw/i386/kvm/apic.c +++ b/hw/i386/kvm/apic.c @@ -60,9 +60,8 @@ static void kvm_put_apic_state(APICCommonState *s, void *= regs) =20 } =20 -void kvm_get_apic_state(DeviceState *dev, void *kapic) +void kvm_get_apic_state(APICCommonState *s, void *kapic) { - APICCommonState *s =3D APIC_COMMON(dev); int i, v; =20 if (kvm_has_x2apic_api() && s->apicbase & MSR_IA32_APICBASE_EXTD) { diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 369626f8c8..ea22aa7180 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -5012,10 +5012,11 @@ static int kvm_get_mp_state(X86CPU *cpu) =20 static int kvm_get_apic(X86CPU *cpu) { - DeviceState *apic =3D cpu->apic_state; + APICCommonState *apic; struct kvm_lapic_state kapic; int ret; =20 + apic =3D APIC_COMMON(cpu->apic_state); if (apic && kvm_irqchip_in_kernel()) { ret =3D kvm_vcpu_ioctl(CPU(cpu), KVM_GET_LAPIC, &kapic); if (ret < 0) { diff --git a/target/i386/kvm/kvm_i386.h b/target/i386/kvm/kvm_i386.h index ecf21c2cc1..00f8ae0ee4 100644 --- a/target/i386/kvm/kvm_i386.h +++ b/target/i386/kvm/kvm_i386.h @@ -12,6 +12,7 @@ #define QEMU_KVM_I386_H =20 #include "system/kvm.h" +#include "hw/i386/apic_internal.h" =20 #define KVM_MAX_CPUID_ENTRIES 100 =20 @@ -56,7 +57,7 @@ bool kvm_has_adjust_clock_stable(void); bool kvm_has_exception_payload(void); void kvm_synchronize_all_tsc(void); =20 -void kvm_get_apic_state(DeviceState *d, void *kapic); +void kvm_get_apic_state(APICCommonState *s, void *kapic); void kvm_put_apicbase(X86CPU *cpu, uint64_t value); =20 bool kvm_has_x2apic_api(void); --=20 2.43.0