From nobody Sun Apr 12 05:57:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1771450630; cv=none; d=zohomail.com; s=zohoarc; b=HV56m5r83oMkIfwWYzwVP/j9jk3cdY+ioYuZBwjk1j+OG3hvQnmJ06k+kGQAe5K36yKcmMG4Ow+EjZRhT/JVmBuZsLfElADwz8+ALmZQzAxDVNIKEPWVFfygDzCPnRAq/G+RHAokKzdlZ8t5iqOuRdPn6cB2moUBJTj4oBoGik8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771450630; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=q9tp8GC/RTNaNpGvJgYnr/BI6IgypHkGhTOPTKYJ+Gg=; b=Tw8wKleTTjSUQMOin81bpMYGaaEpjddUTxaK8uK5vzVPyz/18rE/3brMEFwQ8nw8qGY+8Uu1G02QXky8kuWONGLLqlYqDKq49oFfk4nwodqsUo0SHXsMIfC6PG8YXI18YbCCHzw/H2ywFfGpd5pGCZCb8Gr0DNfvklrYNvv93VI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771450630641418.3916822813577; Wed, 18 Feb 2026 13:37:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vspE3-0002V5-De; Wed, 18 Feb 2026 16:36:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vspDW-0001ka-2T for qemu-devel@nongnu.org; Wed, 18 Feb 2026 16:36:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vspDS-0002Ki-Sx for qemu-devel@nongnu.org; Wed, 18 Feb 2026 16:36:17 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-o9blFiWmN16FCnqhDa6VHg-1; Wed, 18 Feb 2026 16:36:10 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6230A195606D; Wed, 18 Feb 2026 21:36:08 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.65.233]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4425319560B5; Wed, 18 Feb 2026 21:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771450574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q9tp8GC/RTNaNpGvJgYnr/BI6IgypHkGhTOPTKYJ+Gg=; b=L6GgKONpFkpuwwS5MPktGvwmhYWVfDqNHNID8Imz/+00ERemURo5EZNksYixm1RthCHaqV TLAcbEwyBOg0YXFsf32u4+DxiIx0nFp/zb/D7uXuiSnVy+N/ObhsuKr5hweKemghx4JOOn fn6ttkHF3dllyV9FrGiCFgNMRSVxi3E= X-MC-Unique: o9blFiWmN16FCnqhDa6VHg-1 X-Mimecast-MFC-AGG-ID: o9blFiWmN16FCnqhDa6VHg_1771450568 From: John Snow To: qemu-devel@nongnu.org Cc: Kevin Wolf , Warner Losh , Mauro Carvalho Chehab , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-block@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Fabiano Rosas , John Snow , Michael Roth , Pierrick Bouvier , Markus Armbruster , Peter Xu , Yonggang Luo , Hanna Reitz , Maksim Davydov , Thomas Huth , Ed Maste , Alexandre Iooss , Cleber Rosa , Li-Wen Hsu , Mahmoud Mandour , Kyle Evans , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Vladimir Sementsov-Ogievskiy Subject: [PATCH v8 15/20] configure: unconditionally install "tooling" group Date: Wed, 18 Feb 2026 16:34:10 -0500 Message-ID: <20260218213416.674483-16-jsnow@redhat.com> In-Reply-To: <20260218213416.674483-1-jsnow@redhat.com> References: <20260218213416.674483-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1771450631541158500 Alongside meson, always ensure our in-tree tooling group and its out-of-tree dependency, qemu.qmp, is always installed. As a result, several "check-venv" invocations can be removed from various testing scripts. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrang=C3=A9 --- configure | 2 +- .gitlab-ci.d/buildtest.yml | 2 -- scripts/device-crash-test | 3 +-- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 4b61fd3bbf8..c4837eba2b1 100755 --- a/configure +++ b/configure @@ -966,7 +966,7 @@ mkvenv=3D"$python ${source_path}/python/scripts/mkvenv.= py" # Finish preparing the virtual environment using vendored .whl files =20 $mkvenv ensuregroup --dir "${source_path}/python/wheels" \ - ${source_path}/pythondeps.toml meson || exit 1 + ${source_path}/pythondeps.toml meson tooling || exit 1 =20 # At this point, we expect Meson to be installed and available. # We expect mkvenv or pip to have created pyvenv/bin/meson for us. diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index b2db70ff904..1b656b9eb08 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -101,7 +101,6 @@ crash-test-debian: IMAGE: debian script: - cd build - - make NINJA=3D":" check-venv - ./run scripts/device-crash-test -q --tcg-only ./qemu-system-i386 =20 build-system-fedora: @@ -158,7 +157,6 @@ crash-test-fedora: IMAGE: fedora script: - cd build - - make NINJA=3D":" check-venv - ./run scripts/device-crash-test -q ./qemu-system-ppc - ./run scripts/device-crash-test -q ./qemu-system-riscv32 =20 diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 8a91dcaee31..fc86babdf43 100755 --- a/scripts/device-crash-test +++ b/scripts/device-crash-test @@ -40,8 +40,7 @@ try: except ModuleNotFoundError as exc: path =3D Path(__file__).resolve() print(f"Module '{exc.name}' not found.") - print(" Try 'make check-venv' from your build directory,") - print(" and then one way to run this script is like so:") + print(" Try running this script like so:") print(f' > $builddir/run "{path}"') sys.exit(1) =20 --=20 2.53.0