From nobody Sun Apr 12 07:20:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1771409898; cv=none; d=zohomail.com; s=zohoarc; b=Ia6EQH1YEQDvEFrjvBE9Shq+LHr+oxvE6HtEy9l6HzhEZmpPA5280Q8n8LDYbTucybXe775sVPDLZegymarkgpY2v0AdT8xcZ8qzn6OTFudDhqYE+tSA2BM0+bATFsBNlkjOpupxh1H9xukRTeKuZ9i0zJN4kBVl8RXsXz1mWfY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771409898; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=HqDwu0T0oJAOwK1ffJHuITlC5Gc0NgpKr7ZD1XAqwTQ=; b=KmNWb9UeQqs6niWu2EhRoFGJmrdJY69uZBQ4VvRMa5dE0wqGbsEWYh6tgrccUM47NG1XiMyzZNcXaT/jFnCgLe+jefhJ8i9SpevKIS7XQOYUmD1xNy39k1+WCulOXOB81GMpnFskvGWELOVeNa8rHXICU779Te5BAT4bH1ML/Pk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771409898729915.0948451248959; Wed, 18 Feb 2026 02:18:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vsecv-0000Pk-EG; Wed, 18 Feb 2026 05:17:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsecs-0000P9-IU for qemu-devel@nongnu.org; Wed, 18 Feb 2026 05:17:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsecq-0005vJ-6y for qemu-devel@nongnu.org; Wed, 18 Feb 2026 05:17:46 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-gUis1d5NO1C08-Q409XzpQ-1; Wed, 18 Feb 2026 05:17:39 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9DB1E1956053; Wed, 18 Feb 2026 10:17:38 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.45.224.201]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6725530001A5; Wed, 18 Feb 2026 10:17:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771409863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HqDwu0T0oJAOwK1ffJHuITlC5Gc0NgpKr7ZD1XAqwTQ=; b=WrR8Q3yV+j7MP2C67FDDwXgBDcEA1k90EahCyK2trFnG706kE2XZiuOaqMrjq/aQKhRVTG 8NoqThfjetcaiq6P3FqGMfiEcjTLnnkh5FAywvlUKYYZzcTWp9c4Zhod844UJt7W8uB3cW 5rNEFEqkEET3S/mJudsh+8bAxcbsWts= X-MC-Unique: gUis1d5NO1C08-Q409XzpQ-1 X-Mimecast-MFC-AGG-ID: gUis1d5NO1C08-Q409XzpQ_1771409859 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org, Peter Maydell , Richard Henderson Subject: [PULL v2 3/3] qga: Fix VSS provider GetSnapshotProperties return value Date: Wed, 18 Feb 2026 12:17:29 +0200 Message-ID: <20260218101729.92630-4-kkostiuk@redhat.com> In-Reply-To: <20260218101729.92630-1-kkostiuk@redhat.com> References: <20260218101729.92630-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1771409900795158500 Content-Type: text/plain; charset="utf-8" From: Elizabeth Ashurov GetSnapshotProperties() returned VSS_E_OBJECT_NOT_FOUND causing "Snapshot id not found" errors during VSS operations. Any error in this function causes a similar error in Windows VSS, so we must return S_OK there. Signed-off-by: Elizabeth Ashurov Reviewed-by: Kostiantyn Kostiuk Link: https://lore.kernel.org/qemu-devel/20260211101744.757548-2-eashurov@r= edhat.com Signed-off-by: Kostiantyn Kostiuk --- qga/vss-win32/provider.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp index a102a23fbf..2b5c6f8e8e 100644 --- a/qga/vss-win32/provider.cpp +++ b/qga/vss-win32/provider.cpp @@ -263,7 +263,7 @@ STDMETHODIMP CQGAVssProvider::SetContext(LONG lContext) STDMETHODIMP CQGAVssProvider::GetSnapshotProperties( VSS_ID SnapshotId, VSS_SNAPSHOT_PROP *pProp) { - return VSS_E_OBJECT_NOT_FOUND; + return S_OK; } =20 STDMETHODIMP CQGAVssProvider::Query( --=20 2.52.0