From nobody Sun Apr 12 05:51:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1771409909; cv=none; d=zohomail.com; s=zohoarc; b=l6ILwbPbGFu9USPqP8AD1tlGQSjCKEZG4TFUwg5EvqZAhWYUCLsmXzD0VLZaUiR1vCqfAMaBwvZl4sdqZMfsa1fiW4attqVU3WwnGhgEVw0JrhSjH9Di6fxtfNuCB8Rb2KVusDyXP3OQW/FPXZM4Uq2JZoH/+3wrkDl7ojpWMcE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771409909; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=C8rs4UIYOqQJ5dZaTVWTyVV+fDwqE9CQaogpGh9sLSM=; b=eB2whYqklEm0F99XadRK+2vbImQXZRMXwsT3mF7HVP1kKpd8A7fj5rUoKaiOGR4nAKLRurkPP7PAvkcR6ymXHpFH10oaXpSvwNwNjSeeDHmTtTPfzcCGk3FTmMZC7ivgQSw36rOPaI3MdjKublEaqvf9w3vbpIbphVucEM1E2bA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771409909199468.36933851009655; Wed, 18 Feb 2026 02:18:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vsect-0000PQ-70; Wed, 18 Feb 2026 05:17:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsecr-0000Ol-Ll for qemu-devel@nongnu.org; Wed, 18 Feb 2026 05:17:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vseco-0005px-Rj for qemu-devel@nongnu.org; Wed, 18 Feb 2026 05:17:45 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-616-U9hM0osAPC-6CzVRNFOK6Q-1; Wed, 18 Feb 2026 05:17:36 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 393F918002E2; Wed, 18 Feb 2026 10:17:35 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.45.224.201]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DCB0330001A5; Wed, 18 Feb 2026 10:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771409862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C8rs4UIYOqQJ5dZaTVWTyVV+fDwqE9CQaogpGh9sLSM=; b=W4ikXLBZp4+pYm8gKr3Z/BzGoqARHmxc4X/cxsY655n4LNftJBrOr/kqjoPvTqHcyNULtZ wYiZ04fMhmYFEbzES71taotqcYwqr01eDovuoa7xbYO7m9lkHEiYL2z9/LlTrSyAD1yMd8 AWtiFgZWJ+tK4pDJNAqO2Xx1qHoAHIM= X-MC-Unique: U9hM0osAPC-6CzVRNFOK6Q-1 X-Mimecast-MFC-AGG-ID: U9hM0osAPC-6CzVRNFOK6Q_1771409855 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org, Peter Maydell , Richard Henderson Subject: [PULL v2 1/3] qga: implement guest-network-get-route for Windows Date: Wed, 18 Feb 2026 12:17:27 +0200 Message-ID: <20260218101729.92630-2-kkostiuk@redhat.com> In-Reply-To: <20260218101729.92630-1-kkostiuk@redhat.com> References: <20260218101729.92630-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1771409912907154100 Content-Type: text/plain; charset="utf-8" From: Elizabeth Ashurov Add Windows implementation of guest-network-get-route command to provide network routing information on Windows guests. Features implemented: - IPv4 and IPv6 route information retrieval using GetIpForwardTable2 - Human-readable interface names via GetAdaptersAddresses - Proper route metrics combining route and interface metrics - MTU information for network interfaces - Support for destination, gateway, mask, and metric fields for IPv4 - Support for destination, nexthop, and desprefixlen fields for IPv6 Implementation uses modern Windows IP Helper API (GetIpForwardTable2, GetIfEntry2). Signed-off-by: Elizabeth Ashurov Reviewed-by: Kostiantyn Kostiuk Link: https://lore.kernel.org/qemu-devel/20251222144031.3115317-1-eashurov@= redhat.com Signed-off-by: Kostiantyn Kostiuk --- qga/commands-win32.c | 172 +++++++++++++++++++++++++++++++++++++++++++ qga/qapi-schema.json | 11 +-- 2 files changed, 178 insertions(+), 5 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 0fd0c966e4..c0bf3467bd 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -2592,3 +2592,175 @@ GuestLoadAverage *qmp_guest_get_load(Error **errp) ret->load15m =3D load_avg_15m; return ret; } + +/* Helper function to get interface name with fallbacks */ +static char *get_interface_name(const MIB_IPFORWARD_ROW2 *row, + IP_ADAPTER_ADDRESSES *adptr_addrs) +{ + IP_ADAPTER_ADDRESSES *adapter; + char *iface_name =3D NULL; + + if (adptr_addrs) { + for (adapter =3D adptr_addrs; adapter; adapter =3D adapter->Next) { + if (adapter->Luid.Value =3D=3D row->InterfaceLuid.Value) { + iface_name =3D guest_wctomb_dup(adapter->FriendlyName); + break; + } + } + } + + if (!iface_name) { + iface_name =3D g_strdup_printf("if%lu", row->InterfaceIndex); + } + + return iface_name; +} + +/* Helper function to fill IPv4 route information */ +static void fill_ipv4_route_info(GuestNetworkRoute *route, + const MIB_IPFORWARD_ROW2 *row) +{ + struct sockaddr_in *addr_in; + char addr_str[INET_ADDRSTRLEN]; + + addr_in =3D (struct sockaddr_in *)&row->DestinationPrefix.Prefix; + if (inet_ntop(AF_INET, &addr_in->sin_addr, addr_str, INET_ADDRSTRLEN))= { + route->destination =3D g_strdup(addr_str); + } else { + route->destination =3D g_strdup("0.0.0.0"); + } + + if (row->DestinationPrefix.PrefixLength =3D=3D 0) { + route->mask =3D g_strdup("0.0.0.0"); + } else { + uint32_t mask =3D htonl(0xFFFFFFFF << (32 - + row->DestinationPrefix.PrefixLength)); + struct in_addr mask_addr =3D { .s_addr =3D mask }; + route->mask =3D g_strdup(inet_ntoa(mask_addr)); + } + + addr_in =3D (struct sockaddr_in *)&row->NextHop; + if (inet_ntop(AF_INET, &addr_in->sin_addr, addr_str, INET_ADDRSTRLEN))= { + route->gateway =3D g_strdup(addr_str); + } else { + route->gateway =3D g_strdup("0.0.0.0"); + } + + route->version =3D 4; +} + +/* Helper function to fill IPv6 route information */ +static void fill_ipv6_route_info(GuestNetworkRoute *route, + const MIB_IPFORWARD_ROW2 *row) +{ + struct sockaddr_in6 *addr_in6; + char addr_str[INET6_ADDRSTRLEN]; + + addr_in6 =3D (struct sockaddr_in6 *)&row->DestinationPrefix.Prefix; + if (inet_ntop(AF_INET6, &addr_in6->sin6_addr, addr_str, INET6_ADDRSTRL= EN)) { + route->destination =3D g_strdup(addr_str); + } else { + route->destination =3D g_strdup("::"); + } + + addr_in6 =3D (struct sockaddr_in6 *)&row->NextHop; + if (inet_ntop(AF_INET6, &addr_in6->sin6_addr, addr_str, INET6_ADDRSTRL= EN)) { + route->nexthop =3D g_strdup(addr_str); + } else { + route->nexthop =3D g_strdup("::"); + } + + route->desprefixlen =3D g_strdup_printf("%u", + row->DestinationPrefix.PrefixLen= gth); + route->version =3D 6; +} + +GuestNetworkRouteList *qmp_guest_network_get_route(Error **errp) +{ + GuestNetworkRouteList *head =3D NULL, **tail =3D &head; + PMIB_IPFORWARD_TABLE2 pIpForwardTable2; + DWORD dwRetVal =3D 0; + DWORD i; + PMIB_IPFORWARD_ROW2 row; + GuestNetworkRoute *route; + IP_ADAPTER_ADDRESSES *adptr_addrs; + MIB_IPINTERFACE_ROW ipifrow; + MIB_IF_ROW2 ifrow2; + Error *local_err =3D NULL; + GHashTable *interface_metric_cache; + + dwRetVal =3D GetIpForwardTable2(AF_UNSPEC, &pIpForwardTable2); + if (dwRetVal !=3D NO_ERROR) { + error_setg_win32(errp, dwRetVal, "failed to get IP routes"); + return NULL; + } + + interface_metric_cache =3D g_hash_table_new_full(g_str_hash, g_str_equ= al, + g_free, NULL); + adptr_addrs =3D guest_get_adapters_addresses(&local_err); + if (local_err) { + error_free(local_err); + adptr_addrs =3D NULL; + } + + for (i =3D 0; i < pIpForwardTable2->NumEntries; i++) { + row =3D &pIpForwardTable2->Table[i]; + + if (row->DestinationPrefix.Prefix.si_family =3D=3D AF_INET) { + route =3D g_new0(GuestNetworkRoute, 1); + fill_ipv4_route_info(route, row); + } else if (row->DestinationPrefix.Prefix.si_family =3D=3D AF_INET6= ) { + route =3D g_new0(GuestNetworkRoute, 1); + fill_ipv6_route_info(route, row); + } else { + continue; + } + + route->iface =3D get_interface_name(row, adptr_addrs); + + /* + * Get interface metric for combined route metric calculation. + * Windows calculates effective route metric as route + interface = metric. + * This matches the values displayed by Windows 'route print' comm= and. + * See: + * https://learn.microsoft.com/en-us/windows/win32/api/netioapi/ns= -netioapi-mib_ipforward_row2 + */ + gchar *luid_key =3D g_strdup_printf("%" G_GUINT64_FORMAT, + row->InterfaceLuid.Value); + gpointer cached_metric =3D g_hash_table_lookup(interface_metric_ca= che, + luid_key); + + if (cached_metric) { + route->metric =3D (int)row->Metric + GPOINTER_TO_INT(cached_me= tric); + g_free(luid_key); + } else { + memset(&ipifrow, 0, sizeof(ipifrow)); + InitializeIpInterfaceEntry(&ipifrow); + ipifrow.InterfaceLuid =3D row->InterfaceLuid; + ipifrow.Family =3D row->DestinationPrefix.Prefix.si_family; + if (GetIpInterfaceEntry(&ipifrow) =3D=3D NO_ERROR) { + g_hash_table_insert(interface_metric_cache, luid_key, + GINT_TO_POINTER(ipifrow.Metric)); + route->metric =3D (int)row->Metric + (int)ipifrow.Metric; + } else { + route->metric =3D (int)row->Metric; + g_free(luid_key); + } + } + + memset(&ifrow2, 0, sizeof(ifrow2)); + ifrow2.InterfaceLuid =3D row->InterfaceLuid; + if (GetIfEntry2(&ifrow2) =3D=3D NO_ERROR) { + route->has_mtu =3D true; + route->mtu =3D (int)ifrow2.Mtu; + } + + QAPI_LIST_APPEND(tail, route); + route =3D NULL; + } + + FreeMibTable(pIpForwardTable2); + g_free(adptr_addrs); + g_hash_table_destroy(interface_metric_cache); + return head; +} diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 5791b49dde..c57bc9a02f 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -1879,7 +1879,8 @@ ## # @GuestNetworkRoute: # -# Route information, currently, only linux supported. +# Route information. Supported on Linux (since 9.1) and Windows +# (since 11.0). # # @iface: The destination network or host's egress network interface # in the routing table @@ -1916,7 +1917,7 @@ # # @version: IP version (4 or 6) # -# Since: 9.1 +# Since: 9.1 (Linux only); 11.0 (Windows) ## { 'struct': 'GuestNetworkRoute', 'data': {'iface': 'str', @@ -1936,7 +1937,7 @@ '*nexthop': 'str', 'version': 'int' }, - 'if': 'CONFIG_LINUX' } + 'if': { 'any': ['CONFIG_LINUX', 'CONFIG_WIN32'] } } =20 ## # @guest-network-get-route: @@ -1945,9 +1946,9 @@ # # Returns: List of route info of guest. # -# Since: 9.1 +# Since: 9.1 (Linux only); 11.0 (Windows) ## { 'command': 'guest-network-get-route', 'returns': ['GuestNetworkRoute'], - 'if': 'CONFIG_LINUX' + 'if': { 'any': ['CONFIG_LINUX', 'CONFIG_WIN32'] } } --=20 2.52.0 From nobody Sun Apr 12 05:51:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1771409897; cv=none; d=zohomail.com; s=zohoarc; b=Lk+0+YwGpKJPCHVF9n+94mqJzFxtZq7+3YcWNTcpF2XSSI840Q7PVlurzTjLNyIt5MuSTeme2UOjNzal4558XQlW8c0QT2Y+j3/YYdbfYtJ4tTYzLbX3tphm7GCkXzlxzVkZEIWkcQDzxS7IHbh6rLpP62Ba3Kk6B8UklgB/tnU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771409897; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=cRn1s4kAttQw1nbcEBQDiFcdN2d570X/bYyzLWn5q7Q=; b=XRWaI4LQzUEootCkiYbv7Tw1Z6eYNpYkRqlLcn6PGhe9mAnVE8ZARVEuFOtUcy6OdG7g8lSdC0fd7QfacN4h4rLB/DUxr+8OTvLk1mOixFp5uOsqv0IXbRt4PHD7HjpAw7nwAJzj66cH7whAPu05CmT3obY9krCTg4PocaFHHLs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771409897969965.6792420941358; Wed, 18 Feb 2026 02:18:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vsecv-0000QF-HY; Wed, 18 Feb 2026 05:17:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsecs-0000PI-Ua for qemu-devel@nongnu.org; Wed, 18 Feb 2026 05:17:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsecp-0005qW-1j for qemu-devel@nongnu.org; Wed, 18 Feb 2026 05:17:46 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-YQaTkrRCP5O1U5KMZYubcw-1; Wed, 18 Feb 2026 05:17:38 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EB6E918002C3; Wed, 18 Feb 2026 10:17:36 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.45.224.201]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A8CE730001BB; Wed, 18 Feb 2026 10:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771409862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cRn1s4kAttQw1nbcEBQDiFcdN2d570X/bYyzLWn5q7Q=; b=DsP2hTWek8Iemp5/iDjYvGzr8RO6XjUxEldJuN7ZDPHZJEchRhimVLnWru1iRnJPbJ5kMG HbR1f4BR+dGVYkE9hdImouN8L3XFUdi8z9QH/dRpAxTq8ykEsYWY8SXCYaEtsh/Ax5HWlC o2EkmEh0AEqvkZuX4dKW7I82JlWhHBw= X-MC-Unique: YQaTkrRCP5O1U5KMZYubcw-1 X-Mimecast-MFC-AGG-ID: YQaTkrRCP5O1U5KMZYubcw_1771409857 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org, Peter Maydell , Richard Henderson Subject: [PULL v2 2/3] qga: Move CoInitialize/CoInitializeSecurity to main process thread Date: Wed, 18 Feb 2026 12:17:28 +0200 Message-ID: <20260218101729.92630-3-kkostiuk@redhat.com> In-Reply-To: <20260218101729.92630-1-kkostiuk@redhat.com> References: <20260218101729.92630-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1771409900491158500 Content-Type: text/plain; charset="utf-8" From: Elizabeth Ashurov Problem: Two issues with COM initialization: Issue #1: Incorrect call order - requester_init() called CoInitializeSecurity first - Per Microsoft documentation, CoInitialize() must be called BEFORE CoInitializeSecurity() Issue #2: Incorrect call location - CoInitializeSecurity was called from dll instead of the main process - Per Microsoft documentation, CoInitializeSecurity() must be called exactl= y once per process from the main executable, not from a DLL Reference: https://learn.microsoft.com/en-us/windows/win32/api/combaseapi/nf-combaseap= i-coinitializesecurity https://learn.microsoft.com/en-us/windows/win32/api/objbase/nf-objbase-coin= itialize This caused incorrect COM initialization, preventing VSS Writers from calling back via IVssWriterCallback (hr =3D 0x80070005, Access denied, Event ID 8194). Fix: - Initialize COM in main.c for both service and CLI modes - Call CoInitialize() followed by CoInitializeSecurity() in correct order in the main thread before any VSS operations - Add proper CoUninitialize() cleanup Result: VSS Writers can now successfully call back to the agent. Event ID 8194 error is resolved. Signed-off-by: Elizabeth Ashurov Reviewed-by: Kostiantyn Kostiuk Tested-by: Dehan Meng Link: https://lore.kernel.org/qemu-devel/20260211101744.757548-1-eashurov@r= edhat.com Signed-off-by: Kostiantyn Kostiuk --- qga/main.c | 42 +++++++++++++++++++++++++++++++++++++ qga/vss-win32/requester.cpp | 13 ------------ 2 files changed, 42 insertions(+), 13 deletions(-) diff --git a/qga/main.c b/qga/main.c index dd1c216f9a..fd19c7037d 100644 --- a/qga/main.c +++ b/qga/main.c @@ -32,6 +32,8 @@ #include "qemu/systemd.h" #include "qemu-version.h" #ifdef _WIN32 +#include +#include #include #include #include "qga/service-win32.h" @@ -830,6 +832,29 @@ DWORD WINAPI service_ctrl_handler(DWORD ctrl, DWORD ty= pe, LPVOID data, return ret; } =20 +/* Initialize COM for VSS operations */ +static HRESULT init_com(void) +{ + HRESULT hr; + + hr =3D CoInitialize(NULL); + if (FAILED(hr)) { + return hr; + } + + hr =3D CoInitializeSecurity( + NULL, -1, NULL, NULL, + RPC_C_AUTHN_LEVEL_PKT_PRIVACY, + RPC_C_IMP_LEVEL_IDENTIFY, + NULL, EOAC_NONE, NULL); + if (FAILED(hr)) { + CoUninitialize(); + return hr; + } + + return S_OK; +} + VOID WINAPI service_main(DWORD argc, TCHAR *argv[]) { GAService *service =3D &ga_state->service; @@ -842,6 +867,13 @@ VOID WINAPI service_main(DWORD argc, TCHAR *argv[]) return; } =20 + /* Initialize COM for VSS operations in the service thread */ + HRESULT hr_com =3D init_com(); + if (FAILED(hr_com)) { + g_critical("Failed to initialize COM in service thread: 0x%lx", hr= _com); + return; + } + service->status.dwServiceType =3D SERVICE_WIN32; service->status.dwCurrentState =3D SERVICE_RUNNING; service->status.dwControlsAccepted =3D SERVICE_ACCEPT_STOP | SERVICE_A= CCEPT_SHUTDOWN; @@ -866,6 +898,8 @@ VOID WINAPI service_main(DWORD argc, TCHAR *argv[]) =20 run_agent(ga_state); =20 + CoUninitialize(); + UnregisterDeviceNotification(service->device_notification_handle); service->status.dwCurrentState =3D SERVICE_STOPPED; SetServiceStatus(service->status_handle, &service->status); @@ -1719,7 +1753,15 @@ int main(int argc, char **argv) StartServiceCtrlDispatcher(service_table); ret =3D EXIT_SUCCESS; } else { + HRESULT hr_com =3D init_com(); + if (FAILED(hr_com)) { + g_critical("Failed to initialize COM: 0x%lx", hr_com); + ret =3D EXIT_FAILURE; + goto end; + } + ret =3D run_agent(s); + CoUninitialize(); } #else ret =3D run_agent(s); diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 74489fcd0a..626d6ab1ff 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -60,15 +60,6 @@ STDAPI requester_init(void) { qga_debug_begin; =20 - COMInitializer initializer; /* to call CoInitializeSecurity */ - HRESULT hr =3D CoInitializeSecurity( - NULL, -1, NULL, NULL, RPC_C_AUTHN_LEVEL_PKT_PRIVACY, - RPC_C_IMP_LEVEL_IDENTIFY, NULL, EOAC_NONE, NULL); - if (FAILED(hr)) { - qga_debug("failed to CoInitializeSecurity (error %lx)", hr); - return hr; - } - hLib =3D LoadLibraryA("VSSAPI.DLL"); if (!hLib) { qga_debug("failed to load VSSAPI.DLL"); @@ -320,8 +311,6 @@ void requester_freeze(int *num_vols, void *mountpoints,= ErrorSet *errset) return; } =20 - CoInitialize(NULL); - /* Allow unrestricted access to events */ InitializeSecurityDescriptor(&sd, SECURITY_DESCRIPTOR_REVISION); SetSecurityDescriptorDacl(&sd, TRUE, NULL, FALSE); @@ -562,7 +551,6 @@ out: =20 out1: requester_cleanup(); - CoUninitialize(); =20 qga_debug_end; } @@ -643,7 +631,6 @@ void requester_thaw(int *num_vols, void *mountpints, Er= rorSet *errset) *num_vols =3D vss_ctx.cFrozenVols; requester_cleanup(); =20 - CoUninitialize(); StopService(); =20 qga_debug_end; --=20 2.52.0 From nobody Sun Apr 12 05:51:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1771409898; cv=none; d=zohomail.com; s=zohoarc; b=Ia6EQH1YEQDvEFrjvBE9Shq+LHr+oxvE6HtEy9l6HzhEZmpPA5280Q8n8LDYbTucybXe775sVPDLZegymarkgpY2v0AdT8xcZ8qzn6OTFudDhqYE+tSA2BM0+bATFsBNlkjOpupxh1H9xukRTeKuZ9i0zJN4kBVl8RXsXz1mWfY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771409898; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=HqDwu0T0oJAOwK1ffJHuITlC5Gc0NgpKr7ZD1XAqwTQ=; b=KmNWb9UeQqs6niWu2EhRoFGJmrdJY69uZBQ4VvRMa5dE0wqGbsEWYh6tgrccUM47NG1XiMyzZNcXaT/jFnCgLe+jefhJ8i9SpevKIS7XQOYUmD1xNy39k1+WCulOXOB81GMpnFskvGWELOVeNa8rHXICU779Te5BAT4bH1ML/Pk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771409898729915.0948451248959; Wed, 18 Feb 2026 02:18:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vsecv-0000Pk-EG; Wed, 18 Feb 2026 05:17:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsecs-0000P9-IU for qemu-devel@nongnu.org; Wed, 18 Feb 2026 05:17:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsecq-0005vJ-6y for qemu-devel@nongnu.org; Wed, 18 Feb 2026 05:17:46 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-gUis1d5NO1C08-Q409XzpQ-1; Wed, 18 Feb 2026 05:17:39 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9DB1E1956053; Wed, 18 Feb 2026 10:17:38 +0000 (UTC) Received: from srv1.redhat.com (unknown [10.45.224.201]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6725530001A5; Wed, 18 Feb 2026 10:17:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771409863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HqDwu0T0oJAOwK1ffJHuITlC5Gc0NgpKr7ZD1XAqwTQ=; b=WrR8Q3yV+j7MP2C67FDDwXgBDcEA1k90EahCyK2trFnG706kE2XZiuOaqMrjq/aQKhRVTG 8NoqThfjetcaiq6P3FqGMfiEcjTLnnkh5FAywvlUKYYZzcTWp9c4Zhod844UJt7W8uB3cW 5rNEFEqkEET3S/mJudsh+8bAxcbsWts= X-MC-Unique: gUis1d5NO1C08-Q409XzpQ-1 X-Mimecast-MFC-AGG-ID: gUis1d5NO1C08-Q409XzpQ_1771409859 From: Kostiantyn Kostiuk To: qemu-devel@nongnu.org, Peter Maydell , Richard Henderson Subject: [PULL v2 3/3] qga: Fix VSS provider GetSnapshotProperties return value Date: Wed, 18 Feb 2026 12:17:29 +0200 Message-ID: <20260218101729.92630-4-kkostiuk@redhat.com> In-Reply-To: <20260218101729.92630-1-kkostiuk@redhat.com> References: <20260218101729.92630-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1771409900795158500 Content-Type: text/plain; charset="utf-8" From: Elizabeth Ashurov GetSnapshotProperties() returned VSS_E_OBJECT_NOT_FOUND causing "Snapshot id not found" errors during VSS operations. Any error in this function causes a similar error in Windows VSS, so we must return S_OK there. Signed-off-by: Elizabeth Ashurov Reviewed-by: Kostiantyn Kostiuk Link: https://lore.kernel.org/qemu-devel/20260211101744.757548-2-eashurov@r= edhat.com Signed-off-by: Kostiantyn Kostiuk --- qga/vss-win32/provider.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp index a102a23fbf..2b5c6f8e8e 100644 --- a/qga/vss-win32/provider.cpp +++ b/qga/vss-win32/provider.cpp @@ -263,7 +263,7 @@ STDMETHODIMP CQGAVssProvider::SetContext(LONG lContext) STDMETHODIMP CQGAVssProvider::GetSnapshotProperties( VSS_ID SnapshotId, VSS_SNAPSHOT_PROP *pProp) { - return VSS_E_OBJECT_NOT_FOUND; + return S_OK; } =20 STDMETHODIMP CQGAVssProvider::Query( --=20 2.52.0