From nobody Fri Mar 27 03:58:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1771435210; cv=none; d=zohomail.com; s=zohoarc; b=CGeX/Xbnx/jU+pjXI/j02tLketWb4qqZKHRjsQyXAo8ZP/RzoW3brapCKIY2yKITXME4LjeLZDR9S8WK6udx2IISnY1oziPIJd5slAExT0baqQAKK2fr40LU7hFIJ5yo7+VxEcF3kIEl0HKljyItFwPAqZ8sA44JJbmno9FTvKs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771435210; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=j4vUtF2bTSisfTwWKQKqiQ0VOxfjv/5QD100QYYlQKQ=; b=SQG3BhtUB4cx118kiFd+Oi0WaSBfmlfhAa0Pjzcq8JbsTwXhc73q+3qaseYiDt1bqpbg3wKHV8EyzM3DEyTil93MqZkgfr03LlWmnlRhALD2Rjgv3UFbXK7p+ITYpbSPumBoN7PDZZYlBbL6ojiAbsa863yqu42jwFuw7AE4eUE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771435209942530.2998689362156; Wed, 18 Feb 2026 09:20:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vslCl-0005VV-DY; Wed, 18 Feb 2026 12:19:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vslCS-0005Q4-Ue for qemu-devel@nongnu.org; Wed, 18 Feb 2026 12:19:01 -0500 Received: from rev.ng ([94.130.142.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vslCO-0005bB-6K for qemu-devel@nongnu.org; Wed, 18 Feb 2026 12:18:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=j4vUtF2bTSisfTwWKQKqiQ0VOxfjv/5QD100QYYlQKQ=; b=G2ZtE3dlcsyAtDG QKrLSvcPtY0oNelWDX4Th/GGUfs4De9YHZOAGaRXDalzVCKsngRwWQ2rNE92qVFv44QfW3IvR99G2 ApGpHLlf2gZ+PVIXVZVu5SRxZbECsmXAq7b4v/JnFUw6GHhHA4aQrVbJgUnuaCKUZe7UexV3K5tfO f4=; Date: Wed, 18 Feb 2026 18:21:29 +0100 Subject: [PATCH v6 3/7] target/i386: Drop physical address range checks MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260218-phys_addr-v6-3-a603bf363218@rev.ng> References: <20260218-phys_addr-v6-0-a603bf363218@rev.ng> In-Reply-To: <20260218-phys_addr-v6-0-a603bf363218@rev.ng> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson , Helge Deller , Paolo Bonzini , Song Gao , Bibo Mao , Palmer Dabbelt , Alistair Francis , Brian Cain , Chao Liu , Anton Johansson X-Developer-Signature: v=1; a=ed25519-sha256; t=1771435335; l=2321; i=anjo@rev.ng; s=20260210; h=from:subject:message-id; bh=i23GXQKeS9TedGL1KxSFVh/SZoh3QgE6FHYttgcvJN4=; b=uD5qF35U5TpUnQKPYnui+qmqBlv1+rmQcSKoS3WZFI/0e6yVObZnosC451Ethk3U3SwsvHXB7 vfr9DTiPQH6Ci971By48LehugUNYR9xrAZ1iV8Q/NF/W9WNzoRGO72G X-Developer-Key: i=anjo@rev.ng; a=ed25519; pk=dKsZvj/g3kgDxnV1/SWg8a0YNGSpWtFGNsWIepQYKow= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=94.130.142.21; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via qemu development Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771435211095158500 Since TARGET_PHYS_ADDR_SPACE_BITS is now fixed to 64 bits for all targets we can remove range checks on cpu->phys_bits and TCG_PHYS_ADDR_BITS. Reviewed-by: Richard Henderson Signed-off-by: Anton Johansson --- target/i386/tcg/helper-tcg.h | 2 -- target/i386/cpu.c | 9 +++------ target/i386/kvm/kvm.c | 3 +-- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/target/i386/tcg/helper-tcg.h b/target/i386/tcg/helper-tcg.h index e41cbda407..f4b2ff740d 100644 --- a/target/i386/tcg/helper-tcg.h +++ b/target/i386/tcg/helper-tcg.h @@ -31,8 +31,6 @@ # define TCG_PHYS_ADDR_BITS 36 #endif =20 -QEMU_BUILD_BUG_ON(TCG_PHYS_ADDR_BITS > TARGET_PHYS_ADDR_SPACE_BITS); - /** * x86_cpu_do_interrupt: * @cpu: vCPU the interrupt is to be handled by. diff --git a/target/i386/cpu.c b/target/i386/cpu.c index eaa01438c1..9b9ed2d1e3 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -9941,12 +9941,9 @@ static void x86_cpu_realizefn(DeviceState *dev, Erro= r **errp) * accel-specific code in cpu_exec_realizefn. */ if (env->features[FEAT_8000_0001_EDX] & CPUID_EXT2_LM) { - if (cpu->phys_bits && - (cpu->phys_bits > TARGET_PHYS_ADDR_SPACE_BITS || - cpu->phys_bits < 32)) { - error_setg(errp, "phys-bits should be between 32 and %u " - " (but is %u)", - TARGET_PHYS_ADDR_SPACE_BITS, cpu->phys_bits); + if (cpu->phys_bits && cpu->phys_bits < 32) { + error_setg(errp, "phys-bits should be at least 32" + " (but is %u)", cpu->phys_bits); return; } /* diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 9f1a4d4cbb..3b66ec8c42 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -4983,8 +4983,7 @@ static int kvm_get_msrs(X86CPU *cpu) */ =20 if (cpu->fill_mtrr_mask) { - QEMU_BUILD_BUG_ON(TARGET_PHYS_ADDR_SPACE_BITS > 52); - assert(cpu->phys_bits <=3D TARGET_PHYS_ADDR_SPACE_BITS); + assert(cpu->phys_bits <=3D 52); mtrr_top_bits =3D MAKE_64BIT_MASK(cpu->phys_bits, 52 - cpu->phys_b= its); } else { mtrr_top_bits =3D 0; --=20 2.52.0