From nobody Wed Feb 18 20:11:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass(p=none dis=none) header.from=collabora.com ARC-Seal: i=2; a=rsa-sha256; t=1771365190; cv=pass; d=zohomail.com; s=zohoarc; b=Dbw5/DA4nZpDg8Quugk31hMplnnL+QHiSew1/mjo9HOQo9D2QiiBSd4PqlWhiZgGuGheO6GcSjIERjgSNPKOoHrC/m4PcXlf88zFTOxR2EnkCoYtFyrvUzym3A+beIJiaoe9DzjGBPdL6Q0p4/chZ4A3dmShXWTVtOQhQDzfLPc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771365190; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=J/wGnnKUwfFEENYgdBBSURKPYypfT8xIgF2rUNs5Qtk=; b=Ey0a0zyzGEMKZ6EXEqmjMQdsQeEa8wit5iXBhAiX2kc6E08bFkXde7aR8i4PWoodC2HSn19h625asxtCrMfuIqK5XTMkmAmLjgk0gaHTlqe+Ccw49MKoWOQgyPlTIy9HZE6nH1iLraI52ELxEHtallz14pWxlr8hZg1di1KA8R4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771365190631677.8800081789407; Tue, 17 Feb 2026 13:53:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vsSzv-0000Ox-EY; Tue, 17 Feb 2026 16:52:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsSzQ-00006n-LG for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:52:17 -0500 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsSzO-0001Rt-Sx for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:52:16 -0500 Received: by mx.zohomail.com with SMTPS id 1771365117725973.6097785397513; Tue, 17 Feb 2026 13:51:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771365120; cv=none; d=zohomail.com; s=zohoarc; b=L+PW8nk+641yp+6VfghKmdO72FB/T2f+9sRT97fTXdSSfxSdtTlHGUVd6NArU5rN3/LBtgAks3w16LqRGMLfHvb19d9auCdG9L3Eev00qDf6bh0B2Zqrrr/BV1qCBRrCTSF6WUuiw0sM3+VDtTObpj9SbQAJMMpEBpvFS89Cl5M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771365120; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=J/wGnnKUwfFEENYgdBBSURKPYypfT8xIgF2rUNs5Qtk=; b=j2SWN+xKf/zAgCkNz5bM+V8kFQlVzO+3fY6hVsdpHzkrwgmfKCZZtC70im41hxJQZy2BseGd7D2rTxdqlJTlPbaHqoUpeeUry3QcrYF1CL4udK7kztm0raQbuzCGEDLkOHWQjJSD6OzjS60voZq58Eg8CuzLf8/7codU3hY91Mw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771365120; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=J/wGnnKUwfFEENYgdBBSURKPYypfT8xIgF2rUNs5Qtk=; b=bKcnfTP8+DgJ1NT/y2CngGtKAe0hLMCkcwhO221nM221hKlQzgYAt0yIwLuriOxO q9yW9i2YW000b59cvINjZy+crbsliupZEaEeV7KN5pAx+UYLiEA040yI7LqxtVkVSXG M7Pfvm5JKvbqsGfD85eb1SKUwXppSHxCXcjKGZdA= From: Dmitry Osipenko To: Akihiko Odaki , Huang Rui , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierre-Eric Pelloux-Prayer , "Michael S . Tsirkin" , Paolo Bonzini , Yiwei Zhang , Sergio Lopez Pascual Cc: Gert Wollny , qemu-devel@nongnu.org, Gurchetan Singh , Alyssa Ross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian , Rob Clark , Robert Beckett Subject: [PATCH v18 07/19] virtio-gpu: Unset context after GL operations Date: Wed, 18 Feb 2026 00:49:16 +0300 Message-ID: <20260217214928.2970885-8-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260217214928.2970885-1-dmitry.osipenko@collabora.com> References: <20260217214928.2970885-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.188.112; envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com) X-ZM-MESSAGEID: 1771365193364154100 Content-Type: text/plain; charset="utf-8" VirtIO-GPU commands may be processed outside of main-loop, from a CPU thread. This results in GL context switch failure because context is held by main-loop thread when GL is invoked from CPU thread. Always release GL context after performing GL operations such that other threads could take over the context. 0 SDL_GL_MakeCurrent() (libSDL3) 1 SDL_GL_MakeCurrent_REAL() (libSDL2) 2 sdl2_gl_make_context_current() (ui/sdl2-gl.c:201) 3 make_current() (virglrenderer.c:639) 4 vrend_finish_context_switch() (vrend_renderer.c:11630) 5 vrend_hw_switch_context() (vrend_renderer.c:11613) 6 vrend_renderer_force_ctx_0() (vrend_renderer.c:12986) 7 virgl_renderer_force_ctx_0() (virglrenderer.c:460) 8 virtio_gpu_virgl_process_cmd() (virtio-gpu-virgl.c:1013) 9 virtio_gpu_process_cmdq() (virtio-gpu.c:1050) 10 virtio_gpu_gl_handle_ctrl() (virtio-gpu-gl.c:86) 11 aio_bh_poll() (util/async.c) 12 aio_poll() (util/aio-posix.c) 13 blk_pwrite() (block/block-gen.c:1985) 14 pflash_update() (pflash_cfi01.c:396) 15 pflash_write() (pflash_cfi01.c:541) 16 memory_region_dispatch_write() (system/memory.c:1554) 17 flatview_write() (system/physmem.c:3333) 18 address_space_write() (system/physmem.c:3453) 19 kvm_cpu_exec() (accel/kvm/kall-all.c:3248) 20 kvm_vcpu_thread_fn() (accel/kvm/kaccel-ops.c:53) Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 0f754829fb71..0021df45d4b2 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -896,14 +896,20 @@ static void virgl_cmd_set_scanout_blob(VirtIOGPU *g, } #endif =20 -void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, - struct virtio_gpu_ctrl_command *cmd) +static void virtio_gpu_virgl_unset_ctx_0(VirtIOGPU *g) +{ + /* Virglrender always uses first scanout for GL. */ + dpy_gl_ctx_make_current(g->parent_obj.scanout[0].con, NULL); +} + +static void +virtio_gpu_virgl_process_cmd_with_ctx_0(VirtIOGPU *g, + struct virtio_gpu_ctrl_command *cm= d) { bool cmd_suspended =3D false; =20 VIRTIO_GPU_FILL_CMD(cmd->cmd_hdr); =20 - virgl_renderer_force_ctx_0(); switch (cmd->cmd_hdr.type) { case VIRTIO_GPU_CMD_CTX_CREATE: virgl_cmd_context_create(g, cmd); @@ -1010,6 +1016,14 @@ void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, virgl_renderer_create_fence(cmd->cmd_hdr.fence_id, cmd->cmd_hdr.type); } =20 +void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, + struct virtio_gpu_ctrl_command *cmd) +{ + virgl_renderer_force_ctx_0(); + virtio_gpu_virgl_process_cmd_with_ctx_0(g, cmd); + virtio_gpu_virgl_unset_ctx_0(g); +} + static void virgl_write_fence(void *opaque, uint32_t fence) { VirtIOGPU *g =3D opaque; @@ -1136,8 +1150,10 @@ static void virtio_gpu_fence_poll(void *opaque) VirtIOGPU *g =3D opaque; VirtIOGPUGL *gl =3D VIRTIO_GPU_GL(g); =20 + virgl_renderer_force_ctx_0(); virgl_renderer_poll(); virtio_gpu_process_cmdq(g); + virtio_gpu_virgl_unset_ctx_0(g); if (!QTAILQ_EMPTY(&g->cmdq) || !QTAILQ_EMPTY(&g->fenceq)) { timer_mod(gl->fence_poll, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + = 10); } --=20 2.52.0