From nobody Wed Feb 18 20:13:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass(p=none dis=none) header.from=collabora.com ARC-Seal: i=2; a=rsa-sha256; t=1771365223; cv=pass; d=zohomail.com; s=zohoarc; b=Ko/eFtrCJb736HLbiptgBRKsdFkgPyyzke4y/IwVEVdN8Ipnh6du6fEl+M3JPIKYdk78AcgkhWCqcQXXzs0I1Cri8GsemCKrehv3/0ACCeB3nRgJnBg3MpoWwyLEfbGs97K0wX1qnJVuj5OYErZVWhY46VJ/YQ3gBQ7W2Fq2Yyg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771365223; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bO3vb6eXrvOiruuM3MlG6czB4HrHDDg4YqBXrGUmM7c=; b=nF3Bs3LHWyXyg6MgDiovf9gsKNv0/IM0aEjPD+pnYDPz7yv1NfbfKVDxisPgzQELfHhdFNF9I/NCAT0FWgJrWbfJFwbdu9uhSdFjn69eRuCg6TrTu+grYffGjBmdDjS0WIwBmBZxllifJdu66Vapi24lqU8ZyLUtzeA3LAEe8Bg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771365223172283.36924029267516; Tue, 17 Feb 2026 13:53:43 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vsT0G-000166-MX; Tue, 17 Feb 2026 16:53:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsSzt-0000WA-22 for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:52:48 -0500 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsSzn-0001Ur-B4 for qemu-devel@nongnu.org; Tue, 17 Feb 2026 16:52:41 -0500 Received: by mx.zohomail.com with SMTPS id 1771365129043529.9722359271836; Tue, 17 Feb 2026 13:52:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771365130; cv=none; d=zohomail.com; s=zohoarc; b=APAvMylmnVT31X7tc7QgenrrBH+R+k6LvEdTXHXi0RhrAS4vELUVlAqi2CTAJ6LjO7Vsr1JNsFNNOequE0NnrbeFt+/iszQkleb0L57D0Hxxh/YBc6r7TOsRblLOLDfdQkvxW6INmkyy9z0A0niEEzYfSmiaCTjMFP04Ztk/eVs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771365130; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=bO3vb6eXrvOiruuM3MlG6czB4HrHDDg4YqBXrGUmM7c=; b=U1iiKsn01t3FsnJ/18x4S3Fr1ZWD/Nybklc1KprlhF+g0cKbGo78QStvYyUrzc+dc9a3PEtZ7eSGA9HZiGd+yayVAUz7Q65kyHiwr5gc08C28NNjqtDdgWiIH9g+aj7LcmDfeuqmqfEJtSPexCCKlO1pgUGIFW+CF5qRnx8fJGs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771365130; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=bO3vb6eXrvOiruuM3MlG6czB4HrHDDg4YqBXrGUmM7c=; b=ZBt64aDMJ2RjEE/oUBrx7T3YnxUsFVAUcHELSlQM49FnStegnthxVecdM1NipnkV zOewb+kWgDlqp0KkSqZ9dYOQc5vGQXQ1T7auBr62gGbIf7bFLFHXGSWIeaRF1hKfOk5 3qJLrYncgj+bugkYu02fgq5Uy6MVmD1Dph2Tv6g4= From: Dmitry Osipenko To: Akihiko Odaki , Huang Rui , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierre-Eric Pelloux-Prayer , "Michael S . Tsirkin" , Paolo Bonzini , Yiwei Zhang , Sergio Lopez Pascual Cc: Gert Wollny , qemu-devel@nongnu.org, Gurchetan Singh , Alyssa Ross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian , Rob Clark , Robert Beckett Subject: [PATCH v18 09/19] virtio-gpu: Handle virgl fence creation errors Date: Wed, 18 Feb 2026 00:49:18 +0300 Message-ID: <20260217214928.2970885-10-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260217214928.2970885-1-dmitry.osipenko@collabora.com> References: <20260217214928.2970885-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.188.112; envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com) X-ZM-MESSAGEID: 1771365225884154100 Print out error messages when virgl fence creation fails to aid debugging of the fence-related bugs. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Benn=C3=A9e Acked-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Yiwei Zhang Tested-by: Yiwei Zhang Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c | 27 ++++++++++++++++++++++----- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 0021df45d4b2..5b144211fad8 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -907,6 +907,7 @@ virtio_gpu_virgl_process_cmd_with_ctx_0(VirtIOGPU *g, struct virtio_gpu_ctrl_command *cm= d) { bool cmd_suspended =3D false; + int ret; =20 VIRTIO_GPU_FILL_CMD(cmd->cmd_hdr); =20 @@ -1006,14 +1007,30 @@ virtio_gpu_virgl_process_cmd_with_ctx_0(VirtIOGPU *= g, trace_virtio_gpu_fence_ctrl(cmd->cmd_hdr.fence_id, cmd->cmd_hdr.type); #if VIRGL_VERSION_MAJOR >=3D 1 if (cmd->cmd_hdr.flags & VIRTIO_GPU_FLAG_INFO_RING_IDX) { - virgl_renderer_context_create_fence(cmd->cmd_hdr.ctx_id, - VIRGL_RENDERER_FENCE_FLAG_MERG= EABLE, - cmd->cmd_hdr.ring_idx, - cmd->cmd_hdr.fence_id); + const uint32_t flags =3D VIRGL_RENDERER_FENCE_FLAG_MERGEABLE; + + ret =3D virgl_renderer_context_create_fence(cmd->cmd_hdr.ctx_id, f= lags, + cmd->cmd_hdr.ring_idx, + cmd->cmd_hdr.fence_id); + if (ret) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: virgl_renderer_context_create_fence error: = %s", + __func__, strerror(-ret)); + } return; } #endif - virgl_renderer_create_fence(cmd->cmd_hdr.fence_id, cmd->cmd_hdr.type); + + /* + * Unlike other virglrenderer functions, this one returns a positive + * error code. + */ + ret =3D virgl_renderer_create_fence(cmd->cmd_hdr.fence_id, 0); + if (ret) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: virgl_renderer_create_fence error: %s", + __func__, strerror(ret)); + } } =20 void virtio_gpu_virgl_process_cmd(VirtIOGPU *g, --=20 2.52.0