From nobody Sun Apr 12 06:08:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass(p=none dis=none) header.from=collabora.com ARC-Seal: i=2; a=rsa-sha256; t=1771269263; cv=pass; d=zohomail.com; s=zohoarc; b=WjGaRxiG87FxFMXmaqarrwRm/J3f43X4vDY5nzjfVDY33eiGlga3U7laTSL/ygCndN0wO/1jcy0POkb3CKVo/TclmVmDyFlF9/+ifF5j8i5GGXnhqrqqrghL8KlnY3Ku5gYeHX6u0yMTGQqiqWO25mFgGneDZNijbYasnWqZnSg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771269263; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tMuuSYDErcV8h4Nk0lnQAaM6c4X/fM/cFF7p8GocgcQ=; b=aLUt2CF2U4IDiZ57//aYZ5mavNHvw8qHz4ovqIEV+MfY+u2OQ/f/Yi0NN+prx5ScIwEXZBoN9olh7bYoAM2+I7mt9/f4Fw/doK3IsJn0CtiFPsOPtC5N4BTNlhsrp5ilZ/9c0G1skIbhh+nMsIBodVQii75YUd8BxFvp+IvQKQM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771269263440887.6994293656098; Mon, 16 Feb 2026 11:14:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vs42O-0007zC-WB; Mon, 16 Feb 2026 14:13:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vs42M-0007yv-Dr for qemu-devel@nongnu.org; Mon, 16 Feb 2026 14:13:38 -0500 Received: from sender4-pp-e105.zoho.com ([136.143.188.105]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vs42K-0003ZU-7C for qemu-devel@nongnu.org; Mon, 16 Feb 2026 14:13:38 -0500 Received: by mx.zohomail.com with SMTPS id 1771269198520731.0716908357117; Mon, 16 Feb 2026 11:13:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771269200; cv=none; d=zohomail.com; s=zohoarc; b=L/9GQFWSBDuFEZAdDj6b7RpYjx1deLZhMdlG8IEGM/9RnUpK0o02/ZwuuWGTB2hYIZFDxhwsm2j0ZtpUG6aHUGPQqdrTIh1JeCEBL3UHItURYXwUzxAoI692vNCc+MIERc3r5LAZIsk5x99nzTDOzbs28L2GptxcmEJA45BNtsA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771269200; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=tMuuSYDErcV8h4Nk0lnQAaM6c4X/fM/cFF7p8GocgcQ=; b=nGccA3QGxZqigA2Njh8EhBdsc8UgRTJQCARL8pdJEkYJWpSOP2FR2mOIdz1uZWEqzNSIzLTb38/vruPicRvsx5I1Lm0UkUYi8LIBIvR9r+vSCnjKy7wL9TZ3CLnI6G53A+Zn6jFiKTfkl09g+6w1fqBgH3Qki8ShlCyHDZDD3y4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771269200; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=tMuuSYDErcV8h4Nk0lnQAaM6c4X/fM/cFF7p8GocgcQ=; b=BH1fHtW2+Fvf9e+k5w4LfGIpecZsA40RGbzPuLrItgZHUJk5540XjJWcICK6JtZO cJEtaKShGcQ4fUsXr8PGi+Th7wYwnUcEaQllR07U5iXnAq3aAa161sQ5YsROcKaF6Ar GuYUeE7UzUntXQfKLggQ7KLNs5K99yOJlknuu9YM= From: Dmitry Osipenko To: Akihiko Odaki , Huang Rui , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierre-Eric Pelloux-Prayer , "Michael S . Tsirkin" , Paolo Bonzini , Yiwei Zhang , Sergio Lopez Pascual Cc: Gert Wollny , qemu-devel@nongnu.org, Gurchetan Singh , Alyssa Ross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian , Rob Clark , Robert Beckett Subject: [PATCH v17 05/18] ui/gtk-egl: Unset context after GL operations Date: Mon, 16 Feb 2026 22:12:00 +0300 Message-ID: <20260216191213.2556073-6-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260216191213.2556073-1-dmitry.osipenko@collabora.com> References: <20260216191213.2556073-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.188.105; envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-e105.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com) X-ZM-MESSAGEID: 1771269265305158500 Content-Type: text/plain; charset="utf-8" VirtIO-GPU commands may be processed outside of main-loop, from a CPU thread. This results in GL context switch failure because context is held by main-loop thread when GL is invoked from CPU thread. Always release GL context after performing GL operations such that other threads could take over the context. Signed-off-by: Dmitry Osipenko --- ui/gtk-egl.c | 16 ++++++++++++++++ ui/gtk-gl-area.c | 7 ++++++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index 0dbb429958e5..157b000f45fb 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -39,6 +39,8 @@ static void gtk_egl_set_scanout_mode(VirtualConsole *vc, = bool scanout) surface_gl_destroy_texture(vc->gfx.gls, vc->gfx.ds); surface_gl_create_texture(vc->gfx.gls, vc->gfx.ds); } + eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE, + EGL_NO_SURFACE, EGL_NO_CONTEXT); } } =20 @@ -125,6 +127,9 @@ void gd_egl_draw(VirtualConsole *vc) surface_height(vc->gfx.ds)); =20 glFlush(); + + eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE, + EGL_NO_SURFACE, EGL_NO_CONTEXT); } } =20 @@ -261,6 +266,9 @@ void gd_egl_scanout_texture(DisplayChangeListener *dcl, gtk_egl_set_scanout_mode(vc, true); egl_fb_setup_for_tex(&vc->gfx.guest_fb, backing_width, backing_height, backing_id, false); + + eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE, + EGL_NO_SURFACE, EGL_NO_CONTEXT); } =20 void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl, @@ -277,6 +285,8 @@ void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl, egl_dmabuf_import_texture(dmabuf); texture =3D qemu_dmabuf_get_texture(dmabuf); if (!texture) { + eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE, + EGL_NO_SURFACE, EGL_NO_CONTEXT); return; } =20 @@ -294,6 +304,9 @@ void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl, if (qemu_dmabuf_get_allow_fences(dmabuf)) { vc->gfx.guest_fb.dmabuf =3D dmabuf; } + + eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE, + EGL_NO_SURFACE, EGL_NO_CONTEXT); #endif } =20 @@ -397,6 +410,9 @@ void gd_egl_scanout_flush(DisplayChangeListener *dcl, #endif =20 eglSwapBuffers(qemu_egl_display, vc->gfx.esurface); + + eglMakeCurrent(qemu_egl_display, EGL_NO_SURFACE, + EGL_NO_SURFACE, EGL_NO_CONTEXT); } =20 void gd_egl_flush(DisplayChangeListener *dcl, diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index c709b2ce0f63..0036f1490740 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -389,6 +389,11 @@ void gtk_gl_area_init(void) int gd_gl_area_make_current(DisplayGLCtx *dgc, QEMUGLContext ctx) { - gdk_gl_context_make_current(ctx); + if (!ctx) { + gdk_gl_context_clear_current(); + } else { + gdk_gl_context_make_current(ctx); + } + return 0; } --=20 2.52.0