From nobody Sun Apr 12 06:08:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass(p=none dis=none) header.from=collabora.com ARC-Seal: i=2; a=rsa-sha256; t=1771269404; cv=pass; d=zohomail.com; s=zohoarc; b=lZHqHcJXzdA4guDw5AAbcdo70jehB+t3XShoOwyEQ2WUO4SelR4uMGM1Nzy7/zejrA1zpwmkL/rVbn45jeSRU5elY4EC+74Zkg1tyagivxxlFwwUrAXKZR2Ot5hrJxzHupr6PEtsGK123wjzJSatC90IzmAI+w/LcZqDpL7jTfw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771269404; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aQaG6nS4+RzGmjU/24LUpRpZp6FwJ6sMEExKWN7vBb0=; b=buI4kPqUUhDT1DA1DRNlk59/Hh25zjnORUbLtqXlkBYZaqAF7hz57IzkNIlsGxuIj3c/mNIXW7fd9/Wcdz/r47uHYEwP6KNYccGyIyep3YgqHlSyRKUfoTeHdiBgfd1YfjuzxojjzCSlSWIjKWD/hARr6s98+/PMRI86VycJY4U= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771269404190734.1245442938629; Mon, 16 Feb 2026 11:16:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vs42M-0007yc-Og; Mon, 16 Feb 2026 14:13:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vs42G-0007yF-Q5 for qemu-devel@nongnu.org; Mon, 16 Feb 2026 14:13:34 -0500 Received: from sender4-pp-g124.zoho.com ([136.143.188.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vs42E-0003Z9-M3 for qemu-devel@nongnu.org; Mon, 16 Feb 2026 14:13:32 -0500 Received: by mx.zohomail.com with SMTPS id 17712691929841008.3265234117447; Mon, 16 Feb 2026 11:13:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771269194; cv=none; d=zohomail.com; s=zohoarc; b=ONxJkf0hPvNBovgmzzT8aBZQLfqw62G7Fh/pfZPhh73vSn0UlOUDUC26ELz7l1O4nppL6B7Qm3PaBEfHmRidVNE6iraxLTywt6vB4vKeRbl6pRMqi4gGfxE+ADeyY7O/JVLpbwXNJvCRgyYj2C4XkNxnAGBTjQH0GqHn5bGoxOQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771269194; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=aQaG6nS4+RzGmjU/24LUpRpZp6FwJ6sMEExKWN7vBb0=; b=mbO1GPBp/otdwdWHEqs5NBSFx9QcunKF/7h3on3scCElR51aj3SwLwHkAMeI65WL9mJuRFJn/aY34B/lxRWlmJslQZuHrRAx23O6H+CPyQmy+5eT2hYc2FpFT3JePdqj3gbVDB3mGEQjuveUoiL9GlJ7IP1AMN9EASwpN9lIbsI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1771269194; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=aQaG6nS4+RzGmjU/24LUpRpZp6FwJ6sMEExKWN7vBb0=; b=j0fZXqV5YeJ7f2s2dKTOMSPOhCy5Ee01qmRZ5PjnwEqKRmrM9ST2kPooG+wdazUA VCG7TxYUo46HkaqCm1wtgbWFvlhxGbtIB1JeEG++SGJ0dX9shrSVOo/NtRrRAg7jkWj TXtQ82EdfgBth6PCpTiFyGOzw0+Ttd2W7agHXHzc= From: Dmitry Osipenko To: Akihiko Odaki , Huang Rui , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierre-Eric Pelloux-Prayer , "Michael S . Tsirkin" , Paolo Bonzini , Yiwei Zhang , Sergio Lopez Pascual Cc: Gert Wollny , qemu-devel@nongnu.org, Gurchetan Singh , Alyssa Ross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian , Rob Clark , Robert Beckett Subject: [PATCH v17 04/18] ui/sdl2: Unset context after GL operations Date: Mon, 16 Feb 2026 22:11:59 +0300 Message-ID: <20260216191213.2556073-5-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260216191213.2556073-1-dmitry.osipenko@collabora.com> References: <20260216191213.2556073-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.188.124; envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-g124.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com) X-ZM-MESSAGEID: 1771269405242154100 Content-Type: text/plain; charset="utf-8" VirtIO-GPU commands may be processed outside of main-loop, from a CPU thread. This results in GL context switch failure because context is held by main-loop thread when GL is invoked from CPU thread. Always release GL context after performing GL operations such that other threads could take over the context. 0 SDL_GL_MakeCurrent() (libSDL3) 1 SDL_GL_MakeCurrent_REAL() (libSDL2) 2 sdl2_gl_make_context_current() (ui/sdl2-gl.c:201) 3 make_current() (virglrenderer.c:639) 4 vrend_finish_context_switch() (vrend_renderer.c:11630) 5 vrend_hw_switch_context() (vrend_renderer.c:11613) 6 vrend_renderer_force_ctx_0() (vrend_renderer.c:12986) 7 virgl_renderer_force_ctx_0() (virglrenderer.c:460) 8 virtio_gpu_virgl_process_cmd() (virtio-gpu-virgl.c:1013) 9 virtio_gpu_process_cmdq() (virtio-gpu.c:1050) 10 virtio_gpu_gl_handle_ctrl() (virtio-gpu-gl.c:86) 11 aio_bh_poll() (util/async.c) 12 aio_poll() (util/aio-posix.c) 13 blk_pwrite() (block/block-gen.c:1985) 14 pflash_update() (pflash_cfi01.c:396) 15 pflash_write() (pflash_cfi01.c:541) 16 memory_region_dispatch_write() (system/memory.c:1554) 17 flatview_write() (system/physmem.c:3333) 18 address_space_write() (system/physmem.c:3453) 19 kvm_cpu_exec() (accel/kvm/kall-all.c:3248) 20 kvm_vcpu_thread_fn() (accel/kvm/kaccel-ops.c:53) Signed-off-by: Dmitry Osipenko --- ui/sdl2-gl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index 55e22a7a3d59..936b15f737d8 100644 --- a/ui/sdl2-gl.c +++ b/ui/sdl2-gl.c @@ -57,6 +57,8 @@ static void sdl2_gl_render_surface(struct sdl2_console *s= con) =20 surface_gl_render_texture(scon->gls, scon->surface); SDL_GL_SwapWindow(scon->real_window); + + SDL_GL_MakeCurrent(scon->real_window, NULL); } =20 void sdl2_gl_update(DisplayChangeListener *dcl, @@ -73,6 +75,8 @@ void sdl2_gl_update(DisplayChangeListener *dcl, SDL_GL_MakeCurrent(scon->real_window, scon->winctx); surface_gl_update_texture(scon->gls, scon->surface, x, y, w, h); scon->updates++; + + SDL_GL_MakeCurrent(scon->real_window, NULL); } =20 void sdl2_gl_switch(DisplayChangeListener *dcl, @@ -91,6 +95,7 @@ void sdl2_gl_switch(DisplayChangeListener *dcl, if (surface_is_placeholder(new_surface) && qemu_console_get_index(dcl-= >con)) { qemu_gl_fini_shader(scon->gls); scon->gls =3D NULL; + SDL_GL_MakeCurrent(scon->real_window, NULL); sdl2_window_destroy(scon); return; } @@ -105,6 +110,8 @@ void sdl2_gl_switch(DisplayChangeListener *dcl, } =20 surface_gl_create_texture(scon->gls, scon->surface); + + SDL_GL_MakeCurrent(scon->real_window, NULL); } =20 void sdl2_gl_refresh(DisplayChangeListener *dcl) --=20 2.52.0