From nobody Sun Apr 12 05:57:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1771240635; cv=none; d=zohomail.com; s=zohoarc; b=kb0NtibSIxLtKo2+Xk6p+/soyJNxPfeX0Syfn92L9IVMMv6/VnjKT+PMsweFKju5/NJhXdTs0nea7xIXpSFP/TWA2NMXyzEuxtDrknuVds+rnlW35yk3d23Edy+MqqkP1dj3kQ+DCRXe9mMiE1IrewfYsNyTYs1IlNUeN6jSca4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771240635; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=D9XkBQ/oXbUz12+FCnU0YeeeK3GbFA4EHm+vljyv3ok=; b=Ehn3v47+sVNFVJBshxnXx0I/12iyUSS/riTbVnGuREV+JLImRDiexIAPe3EKX6rEDhdzkoVzpnP8DnhhEbLNVfKmSS/qVNmhvPLB6Y6sEmjxWPPQuaG1AfuWqvb5lg3hYteWwGk3u/rp2i2biCUbTTySxrMgtOZeg88Ct01yLnY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177124063540966.11912832370649; Mon, 16 Feb 2026 03:17:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vrwaG-0004pu-9z; Mon, 16 Feb 2026 06:16:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vrwaE-0004pU-HI for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:16:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vrwaC-0007LY-UP for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:16:06 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-RpNXw8lZM26MNj3Q9FJTrA-1; Mon, 16 Feb 2026 06:15:59 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 47A771955D7A; Mon, 16 Feb 2026 11:15:57 +0000 (UTC) Received: from localhost (unknown [10.45.242.26]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5094B30001B9; Mon, 16 Feb 2026 11:15:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771240564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D9XkBQ/oXbUz12+FCnU0YeeeK3GbFA4EHm+vljyv3ok=; b=Ok5tkaCb8c54zATvrMy5MwQ/QDc+yGEpWQ718DHJjXIQmt3GYfjl5GRtyN4tUDYFrfXmOf NAo2N259OqfzGus34Xuow7jdWXAStscWK37Zo/nV/mpskbk2frGJ9ekJy9WeHtLRm6vgbL pCIKTlAylbSJEWGHarZItzm0OjC/S68= X-MC-Unique: RpNXw8lZM26MNj3Q9FJTrA-1 X-Mimecast-MFC-AGG-ID: RpNXw8lZM26MNj3Q9FJTrA_1771240557 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 16 Feb 2026 12:14:56 +0100 Subject: [PATCH 07/85] audio: replace vm_running with runstate_is_running() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260216-audio-v1-7-e676662e4514@redhat.com> References: <20260216-audio-v1-0-e676662e4514@redhat.com> In-Reply-To: <20260216-audio-v1-0-e676662e4514@redhat.com> To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Eduardo Habkost , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , John Snow , Cleber Rosa , Christian Schoenebeck , Akihiko Odaki , Thomas Huth , Alexandre Ratchov , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , "Michael S. Tsirkin" , Manos Pitsidianakis , Alistair Francis , "Edgar E. Iglesias" , Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Mark Cave-Ayland X-Developer-Signature: v=1; a=openpgp-sha256; l=2337; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=n+3siSegRS3y0Lxy97FkNncK5ldFf6lqIw8dDZCokNw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxOGDvONvX02CPcOt6tkRs08xUDFu7ySc7+o /ReRylaG5KJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8TgAKCRDa6OEJdZac 5ZvSEACF2/YXNBDalAjxOarQ9NhDg6+Me+DQI1mfjYl7a+xqJ3DlQDt5g9pX0AyBIJSyZfwIige ih68uFC8nxwmzcVIhUECrfI7lGATri2iDpo6BSPcngqoJECDFbC68jvYBNEtLbD/4wA7DWKbiIN htHfkm9Ae6ZWwTjk3phiDFvOSWZ/B0xVXNDrjs9//whji+TiulX4gb1xT3KkmBJkk/XEexw7V98 650BGJPNEDdAXRvo4YmpBiSv5o4xaNJcdhNgT0UuvL4mSrZPhJEHUMkTmsp/l2RxGul+N2HILSP 1WwfErpdFtlXOIKxsYfIaSJ7aIWEc2coafvlahyxpIys3zcX4MDjo4fxR+fpzg0k3E4ev94LJgy DsyfBFXUgbeQL0XlJMxv6VuA+1VdXUtArf39F2PCwAujAOYweymWJEJpyYTQbtcXxBXijA25ohf JZbrLo99l0vERhLPbEoN4UbdFrQODP8kfK40S1fS0fvwpcG59gt1f/LGWG035fLDku6L4U3bw18 8F3JZbyvXR/Z6G5ExnN7SN+ciAQrbRHfAkH9w5hhrTJpqef8hXvfS13MTTBFMmHQoYpEK+30UHa HJGOd6PRfJo2Jr5bWcr6S4NRF0zxmIEX/zkzrz9/lxNsqjpE+6KhJZ8wFdEZ0iyyZpkbl4ia0tc bNe/xNhM9RlzMkw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1771240637351158500 AudioBackend had a vm_running field which was set in audio_vm_change_state_handler(). The state change handler "bool running" argument is true when vm_prepare_start() calls it, and the VM runstate is either SUSPENDED or RUNNING. Audio hw voices shouldn't be running when the VM is suspended, but only when running. Thus replacing the vm_running field with a call to runstate_is_running() is both simpler and more correct. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Mark Cave-Ayland --- audio/audio_int.h | 1 - audio/audio.c | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/audio/audio_int.h b/audio/audio_int.h index 20b4c87b0b6..25de0e3f9cf 100644 --- a/audio/audio_int.h +++ b/audio/audio_int.h @@ -252,7 +252,6 @@ typedef struct AudioBackend { QLIST_HEAD (cap_listhead, CaptureVoiceOut) cap_head; int nb_hw_voices_out; int nb_hw_voices_in; - int vm_running; int64_t period_ticks; =20 bool timer_running; diff --git a/audio/audio.c b/audio/audio.c index 9563583cd1e..68698b13e15 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -933,7 +933,7 @@ void AUD_set_active_out(SWVoiceOut *sw, bool on) hw->pending_disable =3D 0; if (!hw->enabled) { hw->enabled =3D true; - if (s->vm_running) { + if (runstate_is_running()) { if (hw->pcm_ops->enable_out) { hw->pcm_ops->enable_out(hw, true); } @@ -979,7 +979,7 @@ void AUD_set_active_in(SWVoiceIn *sw, bool on) if (on) { if (!hw->enabled) { hw->enabled =3D true; - if (s->vm_running) { + if (runstate_is_running()) { if (hw->pcm_ops->enable_in) { hw->pcm_ops->enable_in(hw, true); } @@ -1598,7 +1598,6 @@ static void audio_vm_change_state_handler (void *opaq= ue, bool running, HWVoiceOut *hwo =3D NULL; HWVoiceIn *hwi =3D NULL; =20 - s->vm_running =3D running; while ((hwo =3D audio_pcm_hw_find_any_enabled_out(s, hwo))) { if (hwo->pcm_ops->enable_out) { hwo->pcm_ops->enable_out(hwo, running); --=20 2.53.0