From nobody Sun Apr 12 05:51:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1771242588; cv=none; d=zohomail.com; s=zohoarc; b=gsOQMDHdsDfnZkjshxuPjtLb1hvq/mn/Mn5u7IAJSvq6/p5H85FgVTbeEdVxXpnA9mDyV7VnIetBE1vLYqI8LGLzq6M6cYcMPmb0J1hXa5U1wtbt+vYKmC64fs9eCq6PBiLMgiTpW4hd3XVtxexu6d+O2w5stMSYlr+4eE6WCvE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771242588; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zZPwP50pYxUr6MP+yYvCFJCeqAndqgUmshxGKnX4ZHc=; b=gcRZMPAKd0Wy/K7Wq9h+bL11fQ+iwlj0ahyzcrZvBEwUZaTxlq+hZF+SoSGgOMD3EHi4ZR/3M5/3dHY/ozIpuEuED+iO4233/4erurdvYXAIuVT0YKOmgLBwflWqcuiS5zOTFa++gomq4E1poe6JKGqaG93B0faO0EzRyP77Yc8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771242588479741.401456001256; Mon, 16 Feb 2026 03:49:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vrwfV-0007aW-7J; Mon, 16 Feb 2026 06:21:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vrwd3-0007Sp-UF for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vrwd1-0008Pv-62 for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:19:01 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-8W2w716eMz2pe1Ymxx73KA-1; Mon, 16 Feb 2026 06:18:54 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DD35C1956089; Mon, 16 Feb 2026 11:18:51 +0000 (UTC) Received: from localhost (unknown [10.45.242.26]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 546601800464; Mon, 16 Feb 2026 11:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771240738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zZPwP50pYxUr6MP+yYvCFJCeqAndqgUmshxGKnX4ZHc=; b=bY3/3rUoUuvd6WdNtEbpT3v9Z8APV4CV782cX9cOIuLcjkb5OkP2zcRUmU1L6alq7GnLxV MGjMFqr5XoRLRqgqJA8/7I16hXkvWArvzsZ2R9EWjvOHsL+kcbkeGpIQtfIkH8oQ2ZOPP/ Z+ThBY1Wq7J60/Ss3UhEm4SDN/Bwe64= X-MC-Unique: 8W2w716eMz2pe1Ymxx73KA-1 X-Mimecast-MFC-AGG-ID: 8W2w716eMz2pe1Ymxx73KA_1771240732 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 16 Feb 2026 12:15:58 +0100 Subject: [PATCH 69/85] audio/sndio: replace custom logging with error_report MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260216-audio-v1-69-e676662e4514@redhat.com> References: <20260216-audio-v1-0-e676662e4514@redhat.com> In-Reply-To: <20260216-audio-v1-0-e676662e4514@redhat.com> To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Eduardo Habkost , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , John Snow , Cleber Rosa , Christian Schoenebeck , Akihiko Odaki , Thomas Huth , Alexandre Ratchov , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , "Michael S. Tsirkin" , Manos Pitsidianakis , Alistair Francis , "Edgar E. Iglesias" , Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Thomas Huth , Mark Cave-Ayland X-Developer-Signature: v=1; a=openpgp-sha256; l=3292; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=8yW9wJ3mIfAWUvsc6PEfigNiDWoTGEQkRlzr3mI/fbs=; b=kA0DAAoB2ujhCXWWnOUByyZiAGmS/FGj/RWAwCaalX3Sad3mihLN/7gHO9AimlvuTKXg6QHZW IkCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJpkvxRAAoJENro4Ql1lpzlf+AP/0Hf 9dfWzN4T09rWtuvAlg1E/wN4VBXt0eI3AatGe5dpxfHfpDTW8Gf1zggK5Qx7mNMyI2KMJUJJwDM UTXQ5P7Y1Ic6ZXnEpfdCb/DIJl1Pf4YrGcItguC5V5aOoi6PpjZEwfDnotJRPyJkJDNYJEnYpdR zfkd7dVkVSrWfN3NU91ql4qSJgp/0p1qvHeUeLCtzdqux6NUiyT8QQqLfHnuRlf+hKXDP3qeLoS H/jylL1pNwpj86uuWs/d6zo2+SzI/X+ZV+tk7rzB1h5g7xiBYY//U7iKMsOf5JD/R/URdsKG74C kUavivCFGwenRs38C5IdjZA14Ux520EYvlipOUd3D77am1d5fmsZk7VWCfwMZF0b121LJ/ubwSw dovC0BR2Xzu1tigP7BYQQDg38dCLxtuhXICuOFeraMJrFRI0jRJiB/DJdgMEEI1D4lT8EiXu9Vo raL2REVIggU7YvUbB3aDVdFObTivxJhssArngKrEvUeKRPiBT2ZcJoAxgNyCJktyqir1hwkMECW QViUnBOFVaoQM+dhnK9XO9bIKTGS1NyXSbK9dNJsoolFyJxjLuRDat5U9DawIKfxrEfMuLsJV9A tEQq8fWxNIhZBtdRnSOPAiSxCgExnHzhM+ZtloJ6Ya8IELrwEcQrij7HcUyjD5CqQg9DXM41f3b U0XhE X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1771242604197158500 Replace the custom audio logging infrastructure (dolog macro) with standard QEMU error reporting (error_report). Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Thomas Huth Reviewed-by: Mark Cave-Ayland --- audio/sndioaudio.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/audio/sndioaudio.c b/audio/sndioaudio.c index 21f43836fd1..766eceeeefe 100644 --- a/audio/sndioaudio.c +++ b/audio/sndioaudio.c @@ -18,12 +18,12 @@ #include #include #include "qemu/main-loop.h" +#include "qemu/error-report.h" #include "qemu/audio.h" -#include "trace.h" #include "qom/object.h" =20 -#define AUDIO_CAP "sndio" #include "audio_int.h" +#include "trace.h" =20 #define TYPE_AUDIO_SNDIO "audio-sndio" OBJECT_DECLARE_SIMPLE_TYPE(AudioSndio, AUDIO_SNDIO) @@ -348,7 +348,7 @@ static int sndio_init(SndioVoice *self, /* open the device in non-blocking mode */ self->hdl =3D sio_open(dev_name, mode, 1); if (self->hdl =3D=3D NULL) { - dolog("failed to open device\n"); + error_report("sndio: failed to open device"); return -1; } =20 @@ -382,7 +382,7 @@ static int sndio_init(SndioVoice *self, req.sig =3D 0; break; default: - dolog("unknown audio sample format\n"); + error_report("sndio: unknown audio sample format"); return -1; } =20 @@ -401,12 +401,12 @@ static int sndio_init(SndioVoice *self, req.appbufsz =3D req.rate * latency / 1000000; =20 if (!sio_setpar(self->hdl, &req)) { - dolog("failed set audio params\n"); + error_report("sndio: failed to set audio params"); goto fail; } =20 if (!sio_getpar(self->hdl, &self->par)) { - dolog("failed get audio params\n"); + error_report("sndio: failed to get audio params"); goto fail; } =20 @@ -419,7 +419,7 @@ static int sndio_init(SndioVoice *self, if (self->par.bits !=3D req.bits || self->par.bps !=3D req.bits / 8 || self->par.sig !=3D req.sig || (req.bits > 8 && self->par.le !=3D r= eq.le) || self->par.rate !=3D as->freq || nch !=3D as->nchannels) { - dolog("unsupported audio params\n"); + error_report("sndio: unsupported audio params"); goto fail; } =20 @@ -431,7 +431,7 @@ static int sndio_init(SndioVoice *self, =20 self->buf =3D g_malloc(self->buf_size); if (self->buf =3D=3D NULL) { - dolog("failed to allocate audio buffer\n"); + error_report("sndio: failed to allocate audio buffer"); goto fail; } =20 @@ -439,13 +439,13 @@ static int sndio_init(SndioVoice *self, =20 self->pfds =3D g_malloc_n(nfds, sizeof(struct pollfd)); if (self->pfds =3D=3D NULL) { - dolog("failed to allocate pollfd structures\n"); + error_report("sndio: failed to allocate pollfd structures"); goto fail; } =20 self->pindexes =3D g_malloc_n(nfds, sizeof(struct pollindex)); if (self->pindexes =3D=3D NULL) { - dolog("failed to allocate pollindex structures\n"); + error_report("sndio: failed to allocate pollindex structures"); goto fail; } =20 --=20 2.53.0