From nobody Sun Apr 12 05:58:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1771243245; cv=none; d=zohomail.com; s=zohoarc; b=lk/xEjUUvKDP9CKh9VcqvmqSgohZLgncajoZeaqOyAWd+7iQhJX48r/yJucwdn2VbrYYIcPsk2WGwvD4aIFpwqI5giouXDmGUphmD3Eik6wDBbp62WCLQv2fai/9PrERKjTKcJGHU9bLN/8Yz67rYey9k8Pcq2kfhF7zSfY25DE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771243245; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uH9F5ZbfheqEuQKcQaxVN621xVlRLtEAcdHBWTCahY4=; b=ELScSh2lpKVi1Z/XFemTQ1JfES82R6eeNbrtphxocT2uSwIE+QL3QzmYa9z6fVtm8ufUwHt/qDDMVDQPjE9ZO2bjQAR32UK2rh90lP53va0jrwRDjzOFEBi0V26JlJBijV2h6Xv5unOsq0MkVrK8Nj1Si3kDX4k6bcj0Zv9Qpu8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1771243245876567.9936745804919; Mon, 16 Feb 2026 04:00:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vrwfI-0005ky-Gy; Mon, 16 Feb 2026 06:21:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vrwcL-0006i3-Og for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vrwcI-0008D2-PR for qemu-devel@nongnu.org; Mon, 16 Feb 2026 06:18:17 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-Stq9VjIlP7qh-Q1F_XVTLA-1; Mon, 16 Feb 2026 06:18:09 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E956E1956058; Mon, 16 Feb 2026 11:18:06 +0000 (UTC) Received: from localhost (unknown [10.45.242.26]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EF7B230001A5; Mon, 16 Feb 2026 11:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771240692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uH9F5ZbfheqEuQKcQaxVN621xVlRLtEAcdHBWTCahY4=; b=NSaQlktooaxvaPEq+12d7y8ViY3r8GhfdpLd8YDj5ZFVziaGLYccLDAhCe1/EO0hcN00mG uM2sAj68lUzwv5urti74Z/+7n80N6M8glseLvrX4QgT9Jhv9i5xGzpXZts3oV4NCxgYu43 uYatZhx8Mo0wlhXdYCYOuX5NI6QYzzQ= X-MC-Unique: Stq9VjIlP7qh-Q1F_XVTLA-1 X-Mimecast-MFC-AGG-ID: Stq9VjIlP7qh-Q1F_XVTLA_1771240687 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 16 Feb 2026 12:15:42 +0100 Subject: [PATCH 53/85] audio/coreaudio: convert to QOM lifecycle methods MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260216-audio-v1-53-e676662e4514@redhat.com> References: <20260216-audio-v1-0-e676662e4514@redhat.com> In-Reply-To: <20260216-audio-v1-0-e676662e4514@redhat.com> To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Eduardo Habkost , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , John Snow , Cleber Rosa , Christian Schoenebeck , Akihiko Odaki , Thomas Huth , Alexandre Ratchov , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier , "Michael S. Tsirkin" , Manos Pitsidianakis , Alistair Francis , "Edgar E. Iglesias" , Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Mark Cave-Ayland X-Developer-Signature: v=1; a=openpgp-sha256; l=1859; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=vQiHwzIc9rV8//NbzAafizGFjxFI5+TEF7+H85FTPW8=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBpkvxQsEj/x84XZ2zrVn1c7YV6t77/ljjT9YCwC JsYIyqPEyeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaZL8UAAKCRDa6OEJdZac 5fVVD/4p1ZxH28XdPxkA+QQ2lt2h4PAapFFsNv7e480/s5PeKu78gV9oO7RANBomYL6Lst26reU xdbR4UlIHQbEHEqTUITsPBLex2EBf3g6DUbVVrZtdRkXUqD+tha5dNNfXgEBb4MU6UtcKZvQolX 8ZbSEbDLWmayLkwTAPwRduDr6H/hpZ0An54UC+YeKgCdgo4Q9Aikttfqd/w6fKRZX41oPoiQK5S J+BwO2qH3WXTG4N8ZkFIUPs26RedCggjeYa5SDAtmUY7VID0ukQBpzanZ8Yo4zl3FvB0AsFKU26 phXYUF85kWV+6itdoGICZNBIdDi9cHqZwkU1E+1Di1mdBaxbq1m2uBx2MS45moyeBSdeeOOL+CZ u1k2cX3yev5qsJqpWrOWBuWZbdu6TKBxjYYRdYUOsz+6JvCHWafXDYJO6pbX+fPmFDCMnNYWkEF XQZnVEkaGLMANY3zujxHWa/gkmZtAwIDRsuOgBL6OEy8q9OdUHL6m7ZYvW0UCm0qrwfnaHYZ4Ju lUn5z6+XW1TrJvlSdeTzxD6KnsxZHoZl4VZpQAbwl6k3Wk/peSmkytAHa93a0Uef2OavU8CDLln 1+wIWNRvvzD+FIOps5cWQwi0nRIwxwTDsr6hS4xcVMwVcgG+cKyIEi4ugPmaIs6gRsX9PfK8+Na DhMIiUNRXFay7lA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1771243248288158500 Remove the legacy driver init/fini callbacks from the CoreAudio backend. Both coreaudio_audio_init() and coreaudio_audio_fini() were no-ops that performed no real initialization or cleanup work. Access to the Audiodev is now through hw->s->dev instead of the drv_opaque pointer. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Mark Cave-Ayland Reviewed-by: Akihiko Odaki --- audio/coreaudio.m | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/audio/coreaudio.m b/audio/coreaudio.m index 862cb9dd9b0..4a0904f0073 100644 --- a/audio/coreaudio.m +++ b/audio/coreaudio.m @@ -579,7 +579,7 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct au= dsettings *as, OSStatus status; coreaudioVoiceOut *core =3D (coreaudioVoiceOut *) hw; int err; - Audiodev *dev =3D drv_opaque; + Audiodev *dev =3D hw->s->dev; AudiodevCoreaudioPerDirectionOptions *cpdo =3D dev->u.coreaudio.out; struct audsettings obt_as; =20 @@ -656,15 +656,6 @@ static void coreaudio_enable_out(HWVoiceOut *hw, bool = enable) update_device_playback_state(core); } =20 -static void *coreaudio_audio_init(Audiodev *dev, Error **errp) -{ - return dev; -} - -static void coreaudio_audio_fini (void *opaque) -{ -} - static struct audio_pcm_ops coreaudio_pcm_ops =3D { .init_out =3D coreaudio_init_out, .fini_out =3D coreaudio_fini_out, @@ -681,8 +672,6 @@ static void coreaudio_audio_fini (void *opaque) =20 static struct audio_driver coreaudio_audio_driver =3D { .name =3D "coreaudio", - .init =3D coreaudio_audio_init, - .fini =3D coreaudio_audio_fini, .pcm_ops =3D &coreaudio_pcm_ops, .max_voices_out =3D 1, .max_voices_in =3D 0, --=20 2.53.0