From nobody Sun Apr 12 06:04:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770940030; cv=none; d=zohomail.com; s=zohoarc; b=MYtKoZzpq/3vstnUbUfXi6hV76JXJ+ul/RGzQx1KxHennR3WgJSe2wXfslDlIt67cQh7qEiek/Rck1zaMu07WtLEpHTNL3C9kuadlh3I6eoE5YjeFks9ZC+ZxvDOysuEFptGusFRktbMg/1k/h9EemheL+oOVHJ0m5hwPp7tThk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770940030; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gEmb+NuIA92kpdVxEe8MYTCkuvizaCU9Eyv3aVlm5ok=; b=Kkh5/s45sclX3TJfzQWen/IKP0a8uqjX7PV9Azl4viJxgmrR3gOG/GX5Jy2g/zzU1Jo2Oq0NydjtHf1oXjZaD4L9PbPJbCk7L44CNcwtqOQ92c7yXDQ4F/0jp1WqxdJWRYyZrqGAWHvP829qKMLF2a/hpYfpeYMUrALYcb4WEr4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770940030601822.3368911358699; Thu, 12 Feb 2026 15:47:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqgO2-0004iX-Kb; Thu, 12 Feb 2026 18:46:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqgNy-0004gO-DY for qemu-devel@nongnu.org; Thu, 12 Feb 2026 18:46:14 -0500 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vqgNv-0008BG-En for qemu-devel@nongnu.org; Thu, 12 Feb 2026 18:46:13 -0500 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-82311f4070cso217541b3a.0 for ; Thu, 12 Feb 2026 15:46:11 -0800 (PST) Received: from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net. [216.71.219.44]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6e1ac0e004sm5609936a12.6.2026.02.12.15.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 15:46:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770939970; x=1771544770; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gEmb+NuIA92kpdVxEe8MYTCkuvizaCU9Eyv3aVlm5ok=; b=JMRz/3Liil+BgWILxGICt2E54KOZhcjo1lYPjGG3fKlnAFnSfntFrLgZugihDbkEbp 81wbom1rWIpwWlvaICXOusuNUZmP1uihiUG4xBWhVjd3xBcLbnwpO+BoraIPOh8soFn+ f3UhLnobEuIxM5HOE/A/uTYofKs9j9H5WRuUVmZ3TY22xy2dkcbUeojST0AenzdFfYH2 SUQ1Mc9pp1l/SfYkAo3gW7ieSNAb30IKNDLhctomWOseb+SGTiTTF9t13Nda9brDnJJ4 xgAYDQlo6LfhkXGAPX0LKFPwmZsdWG5CvpVDkRdlNTZXzi8WPqpgxcGXrFCEQTbEzebC F92w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770939970; x=1771544770; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gEmb+NuIA92kpdVxEe8MYTCkuvizaCU9Eyv3aVlm5ok=; b=MRu85AfBPACyLXV+Q3dWFzwf4zXyFojIdxA+9sUBEHskV8ek9aPDyAqolV+3PpOV4N 2d7jcoGyfM3Tejyc9K9/XaHdnBbmwygAQ+/XZYSObhyj2MKKCKDlL7ij1DPaZCKsUR5s jIvleLnYk/MvPHxEQpIa1r0DwS5WKRpIAqcPiMpOGlMzczER3I856woaRLNwNtcAHKc4 wHUvTlKd5LasNtgtj6rLWUwjr6PJgDVEMm0Hb5DsPGpJH/1yX/oNHu0AaIrayC+0iumY SBcIpGF89m81MNpKpOZRhPs4oM5IMOX7Whty52YzZ3BBaLusguUBjUaPVZB5QGqh3oUu 6y0g== X-Gm-Message-State: AOJu0YyICLCuNqfeTnzWDUZexOuy7eM8Kp0/1CYoW+hRsnfByTmifWoT LE07T9SVJ9R76PT4ZlSivWKj5GCiTRtOCpXfvJlDJUmVOyUczyZp6Z/T8Oy6KAMyYHOoIwfGyVc LQX75 X-Gm-Gg: AZuq6aLGjjaLDyLud1rtIEKGIILOiO6vCBcm/WSIx3gcA2pdRxs3MF8jm1u82e5TQ/l 50ShN1jW3AksPztryfZDN8CR617ewhsYYrSrNqePx2E6QSyGSsgP8Y0NWO5F0m37XH02jiouuQz s9yHbIV9okHbRhVra4KW6O9oW3yWo0sL35ZkEs/iw6nH/isKb7K615lc0fSryD2w73o1UcX9YdW ZoGUK+PtE44ZMaGqDUrDnAu9yP3F5FezhpXmQ6B2H7T5+tzZh161lgmq1HfCKaXL4piD/hzSE1R gPWZ2KDH+Pj+mQAYz1HNL8JUWZkf/VhmrmobEmVANW3Lz3PbvILrWVyM6wYNIB19BhyoLdJL4J7 41l5iicCDAkAuIq2vs0JML66z0Z7Kh4KxXt3Z8Ys7AJ0WJLPdHUB/45We/5yniafn0hXnKFozLr A9ja4KXALkT3DlaahIgjcg0607BUcdv+Y+MyGmOBbbX5VJ6K4u8LCdYvKUY0tMhpeM5sTaILyhQ T2j X-Received: by 2002:a05:6a21:6f0d:b0:37c:b74c:d8c7 with SMTP id adf61e73a8af0-3946a887081mr31448637.22.1770939969849; Thu, 12 Feb 2026 15:46:09 -0800 (PST) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Pierrick Bouvier , Harsh Prateek Bora , Stefano Garzarella , Jason Wang , Nicholas Piggin , stefanha@redhat.com, richard.henderson@linaro.org, "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] hw/virtio: rename virtio_is_big_endian to virtio_vdev_is_big_endian Date: Thu, 12 Feb 2026 15:46:01 -0800 Message-ID: <20260212234602.338131-3-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260212234602.338131-1-pierrick.bouvier@linaro.org> References: <20260212234602.338131-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770940031954158500 Content-Type: text/plain; charset="utf-8" Renaming this function removes the confusion with existing virtio_is_big_endian cpu ops. Indeed, virtio_vdev_is_big_endian is *not* calling cpu virtio_is_big_endian everytime. Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/virtio/virtio-access.h | 2 +- include/hw/virtio/virtio.h | 2 +- hw/net/virtio-net.c | 4 ++-- hw/virtio/vhost.c | 4 ++-- hw/virtio/virtio-pci.c | 8 ++++---- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-a= ccess.h index 324ba907e93..0c5514178e4 100644 --- a/include/hw/virtio/virtio-access.h +++ b/include/hw/virtio/virtio-access.h @@ -28,7 +28,7 @@ static inline bool virtio_access_is_big_endian(VirtIODevice *vdev) { #if defined(LEGACY_VIRTIO_IS_BIENDIAN) - return virtio_is_big_endian(vdev); + return virtio_vdev_is_big_endian(vdev); #elif TARGET_BIG_ENDIAN if (virtio_vdev_is_modern(vdev)) { return false; diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index 8f1e4323599..ed1a0967ed8 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio/virtio.h @@ -478,7 +478,7 @@ static inline bool virtio_vdev_is_legacy(const VirtIODe= vice *vdev) return !virtio_vdev_is_modern(vdev); } =20 -static inline bool virtio_is_big_endian(VirtIODevice *vdev) +static inline bool virtio_vdev_is_big_endian(VirtIODevice *vdev) { if (virtio_vdev_is_legacy(vdev)) { assert(vdev->device_endian !=3D VIRTIO_DEVICE_ENDIAN_UNKNOWN); diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 313d3b88400..ec85e5a949a 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -301,7 +301,7 @@ static void virtio_net_vhost_status(VirtIONet *n, uint8= _t status) if (n->needs_vnet_hdr_swap) { error_report("backend does not support %s vnet headers; " "falling back on userspace virtio", - virtio_is_big_endian(vdev) ? "BE" : "LE"); + virtio_vdev_is_big_endian(vdev) ? "BE" : "LE"); return; } =20 @@ -343,7 +343,7 @@ static int virtio_net_set_vnet_endian_one(VirtIODevice = *vdev, NetClientState *peer, bool enable) { - if (virtio_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { return qemu_set_vnet_be(peer, enable); } else { return qemu_set_vnet_le(peer, enable); diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 70a112242b0..1f5e70ad197 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1306,7 +1306,7 @@ int vhost_virtqueue_start(struct vhost_dev *dev, =20 if (vhost_needs_vring_endian(vdev)) { r =3D vhost_virtqueue_set_vring_endian_legacy(dev, - virtio_is_big_endian(v= dev), + virtio_vdev_is_big_end= ian(vdev), vhost_vq_index); if (r) { return r; @@ -1423,7 +1423,7 @@ static int do_vhost_virtqueue_stop(struct vhost_dev *= dev, */ if (vhost_needs_vring_endian(vdev)) { vhost_virtqueue_set_vring_endian_legacy(dev, - !virtio_is_big_endian(vdev= ), + !virtio_vdev_is_big_endian= (vdev), vhost_vq_index); } =20 diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 6126187a164..33c5cec01cd 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -586,13 +586,13 @@ static uint64_t virtio_pci_config_read(void *opaque, = hwaddr addr, break; case 2: val =3D virtio_config_readw(vdev, addr); - if (virtio_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { val =3D bswap16(val); } break; case 4: val =3D virtio_config_readl(vdev, addr); - if (virtio_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { val =3D bswap32(val); } break; @@ -625,13 +625,13 @@ static void virtio_pci_config_write(void *opaque, hwa= ddr addr, virtio_config_writeb(vdev, addr, val); break; case 2: - if (virtio_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { val =3D bswap16(val); } virtio_config_writew(vdev, addr, val); break; case 4: - if (virtio_is_big_endian(vdev)) { + if (virtio_vdev_is_big_endian(vdev)) { val =3D bswap32(val); } virtio_config_writel(vdev, addr, val); --=20 2.47.3