From nobody Sun Apr 12 07:21:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770907941; cv=none; d=zohomail.com; s=zohoarc; b=nYoT9LuM9mwvrJCGZ7gtV8sCqvdO0IFc/5uOqU+hrxshv2GQj2ZD1TwY/Ajy+h8x6ONC8pnE9EZYZnZggCYCZRGI+SXG6Lv76JpFDy8EXEfBu/4Nynefu6V0rdBpM7CtYaH8iWGxF1dIKIkX3SG8G8VrGk+WlZuXwkawVoL2Hm8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770907941; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1pZJeSsRKhhmEscgZ7YYP5vcNGqC0Rr9KYF4FasGN1I=; b=KtmeAvI1QsNjqiT3UiMBAIImSQQ47PsFD4RA44wtLJuheRQ0U8MNONFcmDyzTgDFxKHmyzY1KnmBzMQqq4Y1rbBpcI/s+zoT/MlopCh2mWEdatakNG9DXKhgWSuCkWTVTXrSINoXlTXdFrz5NCR9mDAN/qpbMR+0lmMeFkPlSAs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770907941271122.731055335017; Thu, 12 Feb 2026 06:52:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqXvL-0005t2-5W; Thu, 12 Feb 2026 09:44:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqXv1-0005OZ-VO for qemu-devel@nongnu.org; Thu, 12 Feb 2026 09:43:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqXuz-0006AO-RI for qemu-devel@nongnu.org; Thu, 12 Feb 2026 09:43:47 -0500 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-9avk3JidOjGhIinwgDtbcg-1; Thu, 12 Feb 2026 09:43:43 -0500 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4802bb29400so72399665e9.0 for ; Thu, 12 Feb 2026 06:43:43 -0800 (PST) Received: from [10.60.241.123] (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4836131d48fsm33303475e9.24.2026.02.12.06.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 06:43:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770907425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1pZJeSsRKhhmEscgZ7YYP5vcNGqC0Rr9KYF4FasGN1I=; b=Xuq94094af0JPZhYBvMhH2adRptKXfLYKcHdwo7WFXucf5BN+XDIVXWFP9hNl4tUhBtjmQ P8e03MpunMbzKi1EMn4WnoBPPKRMmgfS3RlGjU17QkZY71YDUz5blM7IepNjAS5/2ROd9J bbMgFZO706XYhtJjn5yV/+1TbLJW5Eo= X-MC-Unique: 9avk3JidOjGhIinwgDtbcg-1 X-Mimecast-MFC-AGG-ID: 9avk3JidOjGhIinwgDtbcg_1770907423 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770907422; x=1771512222; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1pZJeSsRKhhmEscgZ7YYP5vcNGqC0Rr9KYF4FasGN1I=; b=fZM+RLnERBSXthjXD5vCXUshXj8sVb91b0IOFuYEy2BH0h41wVmfjxlZb8AmxaU6XC D/133xLkgHg/YqRj/9eVTU1P2+miwyvsHAkwzFmOq2q4fjeAfhv8K7om4WwwSiQSUpuy Cl12YrF/lzMP0LMqAIa1H20u7QZGsOibCf7yrCUTpIgRjVrD9aRCCWbkWhOU8k5Gg3EK BqvOts+ufLIBoLZJnYg7GG77cA7p0sd1yKmcBzdjOeOsb3FZjZl0xdvRl0ztNTcTBO7f ALTf3IUAy9NYTRcemEl66l3s78YKgFKd5Zbq7VW3LuesWfXuuiRwcQXGviUsM5z5Wik+ pJ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770907422; x=1771512222; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1pZJeSsRKhhmEscgZ7YYP5vcNGqC0Rr9KYF4FasGN1I=; b=gfhSs9jxtwwCFBToc2iTJoB3I2Oc2zO+3OEzB1WFLrkc8lcxV3n8sp1CzV9tiQiEy3 ofXa4uxp5bwcM0od3jd7t5csfXs9fOxgFU5w5IvLDMaz9btzI6uRuDkpMMMBsg31MljP 5dyV5jkI0MpBoPt6M6W1wFY7+/jUGbWEJeD5DcJZaXJQdRm/iIdi4bg0t6hoxQ6gaALD DP2kX/8qy+e6L8VB5G9intHEC42blWZisOaGr9Y6/hWDjSo18e6RHF48Zg6NRAy3l3an 0ZxckVJUm/kTZ+CqRNE8m2O/Xu1BF4kCwK46lXwuj0tfPYu/A0onRmzE0Jmj8yinlpC3 UCqw== X-Gm-Message-State: AOJu0YywwIuYRYFBRF/q0DlDGf5jppit9N2ZOION/w4RCLWtbhfL4pld 4f5N5VPGWfZLjlXdF2ibMS83xZsdxlyrZlub5d8wxdaiWEb1CK9wGrEKSkYxfHPK4P+vIQ0+qTV +CDUunye0+OdUsKoUkATKTHH41trFU/Wa6L0EjYVNOA5PIoOfvPYCcwbpbBIQ8yl3fqbK717XBt 1hDBoynpdIt/YI1JLmgWBzGVu/WMU3SHbTTbCLhp3Z X-Gm-Gg: AZuq6aK+Pxlh5urCSZ57N+vHzfp590hTeCtAAB7k5trUpQHaheHcI0+u79xsIGB9DOL 852hpLOCYH5h0vUCPycVcHcMDteTs5oe6fj1S1AvxQ8cDs0A5g4L8E4Lor1K+sKpZ/GDIVmz1j2 NDz3s/L2l2J4Xa1nREbfOSOtN0XGMFnKO8OkB3+Pd0gQ7PbwcUMAFMS2fh31bb3GPJOIwZFTXv0 79ws7SlMar9+17X++3q1qumvotg0RmIa4SyCC7BnNEg1erbVBE5lk9coRfdy+YS8Q8ATrLzGZcX U27r40MKFRMaHa6NYARJcXZ+Vxc5rivKLbOhto5uFfv3pSIRHKfQoYea1dWuJouMT1n34RYGOJz 1PMKv57V1c27gji6cQEyhWGU7weIegYuQTNPL/YFJJvTJbF+AwxuWRdYrzqc0vX3rqwcm9V2Wix WKfwmUZDplH4GZpBknZRW7Qhimg1NSxkBQOVQslLkwVEcpHXg6+sU= X-Received: by 2002:a05:600c:35cc:b0:483:6fe1:c057 with SMTP id 5b1f17b1804b1-4836fe1c12dmr2079885e9.21.1770907422152; Thu, 12 Feb 2026 06:43:42 -0800 (PST) X-Received: by 2002:a05:600c:35cc:b0:483:6fe1:c057 with SMTP id 5b1f17b1804b1-4836fe1c12dmr2079335e9.21.1770907421673; Thu, 12 Feb 2026 06:43:41 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mark Cave-Ayland , Thomas Huth , Igor Mammedov , Zhao Liu Subject: [PULL 24/41] hw/audio/pcspk: Remove PCSpkState::migrate field Date: Thu, 12 Feb 2026 15:42:26 +0100 Message-ID: <20260212144244.22579-25-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260212144244.22579-1-pbonzini@redhat.com> References: <20260212144244.22579-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770907942710154100 From: Philippe Mathieu-Daud=C3=A9 The PCSpkState::migrate boolean was only set in the pc_compat_2_7[] array, via the 'migrate=3Doff' property. We removed all machines using that array, lets remove that property, simplifying vmstate_spk[]. Reviewed-by: Mark Cave-Ayland Reviewed-by: Thomas Huth Reviewed-by: Igor Mammedov Reviewed-by: Zhao Liu Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Zhao Liu Link: https://lore.kernel.org/r/20260108033051.777361-24-zhao1.liu@intel.com Signed-off-by: Paolo Bonzini --- hw/audio/pcspk.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c index 916c56fa4c0..0b01544941c 100644 --- a/hw/audio/pcspk.c +++ b/hw/audio/pcspk.c @@ -57,7 +57,6 @@ struct PCSpkState { unsigned int play_pos; uint8_t data_on; uint8_t dummy_refresh_clock; - bool migrate; }; =20 static const char *s_spk =3D "pcspk"; @@ -202,18 +201,10 @@ static void pcspk_realizefn(DeviceState *dev, Error *= *errp) } } =20 -static bool migrate_needed(void *opaque) -{ - PCSpkState *s =3D opaque; - - return s->migrate; -} - static const VMStateDescription vmstate_spk =3D { .name =3D "pcspk", .version_id =3D 1, .minimum_version_id =3D 1, - .needed =3D migrate_needed, .fields =3D (const VMStateField[]) { VMSTATE_UINT8(data_on, PCSpkState), VMSTATE_UINT8(dummy_refresh_clock, PCSpkState), @@ -224,7 +215,6 @@ static const VMStateDescription vmstate_spk =3D { static const Property pcspk_properties[] =3D { DEFINE_AUDIO_PROPERTIES(PCSpkState, audio_be), DEFINE_PROP_UINT32("iobase", PCSpkState, iobase, 0x61), - DEFINE_PROP_BOOL("migrate", PCSpkState, migrate, true), DEFINE_PROP_LINK("pit", PCSpkState, pit, TYPE_PIT_COMMON, PITCommonSta= te *), }; =20 --=20 2.52.0