From nobody Sun Apr 12 07:21:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770907807; cv=none; d=zohomail.com; s=zohoarc; b=VvwPLPJo16KOnlbWE5HNlWUgbVovojtuMx7+UG9hnvoLI/oGRWuMuCUzFm8i0dPqW9QbiOZTJet+PDX6RNx9oD37uN/ahfjpEEiXiFml8/BcEMhIC51TvEY3iX4V1jH2yBxW9qUI0jrQBML9HuxW49l0umJm2dBGvgk5zcC7h6s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770907807; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VMvh1T7VSlWdNvOAnSK+e5XNAASrexQ0cLNtJxfMpMI=; b=anMfx4nBsnIcg+ESu3FZ8pMWm5wZC17swlqWQz4qSkhOItw2FBDCBE6oGHhJLHFge39oxJJqlGzzfy94Sx/1ETJ3CWIXizpbM+DXPoicTGSi4QBinDxReHoueT3BkMbDLffy0YJSnYpzW9LtpJ95pNqH1CjGAiDfcyKP+kGwGJ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770907807847453.7322161897674; Thu, 12 Feb 2026 06:50:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqXvG-0005jm-89; Thu, 12 Feb 2026 09:44:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqXuz-0005O5-FJ for qemu-devel@nongnu.org; Thu, 12 Feb 2026 09:43:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqXum-000651-4Y for qemu-devel@nongnu.org; Thu, 12 Feb 2026 09:43:44 -0500 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-PHNLb-qYPbyf94BUN4bywA-1; Thu, 12 Feb 2026 09:43:29 -0500 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4836b7fbf4fso5777185e9.2 for ; Thu, 12 Feb 2026 06:43:28 -0800 (PST) Received: from [10.60.241.123] (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835dd0e327sm125281235e9.14.2026.02.12.06.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 06:43:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770907410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VMvh1T7VSlWdNvOAnSK+e5XNAASrexQ0cLNtJxfMpMI=; b=AC7c7RvP+uFL3XB4N5gx+42vHBJQVr9NfaFUCS7zq1Q9QsFoXm7zy52jDjPQ2/mt7Qo/bk yj4EAevj4RW+yEa7SxBG/suTQlRS48isHCcAB/1JjjGkdWb19GEPI4+JIF154TSxKcPNBh 4APLf2DrUOxyM7fp14hC7Jp2E6QQux8= X-MC-Unique: PHNLb-qYPbyf94BUN4bywA-1 X-Mimecast-MFC-AGG-ID: PHNLb-qYPbyf94BUN4bywA_1770907408 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770907407; x=1771512207; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VMvh1T7VSlWdNvOAnSK+e5XNAASrexQ0cLNtJxfMpMI=; b=PU5gYeC9X3107F2S11cHQP65nXQMqct+6ypm4RwHhnQ9/3POTgX/TWE1cszqcFuvUm j/Sbsh58oR3rmx9aQDJ1bmnkgMW/7exQz+NVZ6xFPCoGY7ISOntav3AH3N51z93KIM+D oTAUmJZmph0HEeDzZacWnI9+N0pv+9DB6O3tSM84KTxkVLPplCu8fHWpnVMtVJQKTz1k DL7de6QabJADAnlM7LIJ19OYYcruPK+i64tkHT2ywk9fER6sEb/8xUr4pIrWZo+s6h1i Ds434ZQsSLv4iZt+b6Fu1+rs4JnUppoxHt0zAUZ3cmJZqNss8FVyLdv0FpVEpGVivgPM kaVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770907407; x=1771512207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VMvh1T7VSlWdNvOAnSK+e5XNAASrexQ0cLNtJxfMpMI=; b=rt3IvVOjAifg4Cl8I1dtTrJeyXfPVd3Qz2eLtKHWuYgF63sMqhd8TevDJE1YnO60rF C7HE6vo3sH+irva+Pgs5DaD3uyGNjL0/Y8Fv7WL3My13W5qM9vk1/QuEpr+uPi2oE7mH jiFz1xcEKC2WfznAQjKJYlCGqt9X5kCkSmz0tHr/CkVfgmS1sTnGnZTAZJALOA560ITt FhcnAgEfyoduV9uUZtIb2TFv9Lab99riZT8TXuvYrLkzVLkIGFyhDI9MGf8FGOeYWn2S f0A+qqWsF1n08iyuM5Nt87r/bmXh31TEaX3XV6m4JE8Bqj5rAeYUxBRlwgDDckFNdMP0 a7nQ== X-Gm-Message-State: AOJu0YwjQp+Q6z3T6H/qEW8NlPOMdtH1B3aYPm9aN8MdtVRriHr5tj56 CE8xzJ0afRiH1Ibxxwese0gMHeydalbQph3ZKEM9f1c/2dx5KNFy4dptRnqd6PEpg7a5/8c5oEE LJLjZCl+w1oLTYFkjAtEKq+gJ9ttF0s+RyVsEQVxlAf+Df2f1dvJZY3LwcOEGxZvSpAq1ZyqYDN 5MwJDP7iUXKYwllg3/9GkzZsEh9mOBa1yHTFkpAt/p X-Gm-Gg: AZuq6aIbqNlqo6dFxv4P+P+uKeNgiILRY3Uzf3nv/MWXBcyxZynQHAdYWj6oNCEPWUD pdCKAOH3q/9h4PdK3UVMaob6OHDmH/dqLwbMumZ2n31q1d4nWyRGFegUREJS/QLOj1UI6nvZv57 82S31FlBh73Kw/RncDp5z0ZyRYtWiElOJ46EVViu8bOic/beQm/SkhcOfGs1tb3qcVJxSBMkmDT 5MeMznmFKwDnIzGHHttPqH2hRqagy4EYk2ptIf4+Wo1fEcEm0ktQayblzWcJNFR+E9NVaxN7oTJ KEoVUatdUYDhy6lfVv5N7UPv+fCEsv3T1PSa3ZYLSo+5TCh/NhcwDh4uUeZ13I6e/WHKbUSwfbm 7VH6Z27S/t1xtOQCBqFTMfwuJG9xoGdrdHxrbDES3sIBTudoCH0IDobOooHqWtAOi0zJPo3uUSO 2SN2aQvi+eQnngT9W3pxWdsUG5RpFmiHxk6xxocUyTKKTOTUJiIfQ= X-Received: by 2002:a05:600c:6095:b0:477:89d5:fdb2 with SMTP id 5b1f17b1804b1-483656cb1b1mr39478525e9.14.1770907406995; Thu, 12 Feb 2026 06:43:26 -0800 (PST) X-Received: by 2002:a05:600c:6095:b0:477:89d5:fdb2 with SMTP id 5b1f17b1804b1-483656cb1b1mr39477915e9.14.1770907406494; Thu, 12 Feb 2026 06:43:26 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mark Cave-Ayland , Thomas Huth , Igor Mammedov , Zhao Liu Subject: [PULL 18/41] hw/intc/apic: Remove APICCommonState::legacy_instance_id field Date: Thu, 12 Feb 2026 15:42:20 +0100 Message-ID: <20260212144244.22579-19-pbonzini@redhat.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260212144244.22579-1-pbonzini@redhat.com> References: <20260212144244.22579-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770907810611154100 From: Philippe Mathieu-Daud=C3=A9 The APICCommonState::legacy_instance_id boolean was only set in the pc_compat_2_6[] array, via the 'legacy-instance-id=3Don' property. We removed all machines using that array, lets remove that property, simplifying apic_common_realize(). Because instance_id is initialized as initial_apic_id, we can not register vmstate_apic_common directly via dc->vmsd. Reviewed-by: Mark Cave-Ayland Reviewed-by: Thomas Huth Reviewed-by: Igor Mammedov Reviewed-by: Zhao Liu Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Zhao Liu Link: https://lore.kernel.org/r/20260108033051.777361-18-zhao1.liu@intel.com Signed-off-by: Paolo Bonzini --- include/hw/i386/apic_internal.h | 1 - hw/intc/apic_common.c | 5 ----- 2 files changed, 6 deletions(-) diff --git a/include/hw/i386/apic_internal.h b/include/hw/i386/apic_interna= l.h index 4a62fdceb4e..0cb06bbc76c 100644 --- a/include/hw/i386/apic_internal.h +++ b/include/hw/i386/apic_internal.h @@ -187,7 +187,6 @@ struct APICCommonState { uint32_t vapic_control; DeviceState *vapic; hwaddr vapic_paddr; /* note: persistence via kvmvapic */ - bool legacy_instance_id; uint32_t extended_log_dest; }; =20 diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index 4e9e3089945..bf4abc21d7b 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -276,9 +276,6 @@ static void apic_common_realize(DeviceState *dev, Error= **errp) info->enable_tpr_reporting(s, true); } =20 - if (s->legacy_instance_id) { - instance_id =3D VMSTATE_INSTANCE_ID_ANY; - } vmstate_register_with_alias_id(NULL, instance_id, &vmstate_apic_common, s, -1, 0, NULL); =20 @@ -395,8 +392,6 @@ static const Property apic_properties_common[] =3D { DEFINE_PROP_UINT8("version", APICCommonState, version, 0x14), DEFINE_PROP_BIT("vapic", APICCommonState, vapic_control, VAPIC_ENABLE_= BIT, true), - DEFINE_PROP_BOOL("legacy-instance-id", APICCommonState, legacy_instanc= e_id, - false), }; =20 static void apic_common_get_id(Object *obj, Visitor *v, const char *name, --=20 2.52.0