From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886230; cv=none; d=zohomail.com; s=zohoarc; b=jFOKIonT6jAH1y3NuU7YE7V388Kyqy1dE07MPigjDD7PU13GF3C+BlgoCAqFd6qgv/QKqW8JZFN/siOMAdTV+gBRbXQK6f+oo3Efl5I1DD5jXxxXsdVjuTZUgsWlmJcUf8zzogZIRDJ2KdHl9IfJHJtjoHmBj+Xj/LLgseJA3Eg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886230; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4iPUxUZvKj5VCmjr47PfvJopHfp4tra/jlk+ZwBNhS0=; b=iZrxJ0dytZyEcuzgIEpB9ZkBC6nUcgBlVv446eN2yzEfiei78FM/WLk2HTk0lBQTljB8lpZKrGr2igVj2XeVdbeXKQ7XTLfbflmYrNhcgfTDAEtBHJJaMYR+MBru0V4Tr8cvEji+8LzeliQR0pfSXO2+gnyG1UCoFPVqy7+rln0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770886230382217.98204824715515; Thu, 12 Feb 2026 00:50:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSOO-0001Zx-2P; Thu, 12 Feb 2026 03:49:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOL-0001Z9-7P for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:49:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOJ-0001Lb-SS for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:49:40 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-hcWpZHjgM3KVWJvhjfUr2Q-1; Thu, 12 Feb 2026 03:49:35 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A0E321956067; Thu, 12 Feb 2026 08:49:34 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 11A0030001B9; Thu, 12 Feb 2026 08:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4iPUxUZvKj5VCmjr47PfvJopHfp4tra/jlk+ZwBNhS0=; b=Z9cgpoJ5J9Gd6ibw8+JbpVEHPD407VDejEMyjklJ1lFnHaqCbEYe9uU+SmwosLtVzaSn3p zPlVUPFJ9x0cxsM2MUOZCc7Rfh6MF7o/CXYiCvba/Bsy7C89au1t8Noy90qayTMvFk8SzA KiAVkDi2+3oNrC0cl6NDXx243j6NTtY= X-MC-Unique: hcWpZHjgM3KVWJvhjfUr2Q-1 X-Mimecast-MFC-AGG-ID: hcWpZHjgM3KVWJvhjfUr2Q_1770886174 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Raphael Norwitz Subject: [PULL 01/14] MAINTAINERS: Switch to my NVIDIA email Date: Thu, 12 Feb 2026 09:49:14 +0100 Message-ID: <20260212084927.258642-2-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886232896154100 Content-Type: text/plain; charset="utf-8" From: Raphael Norwitz Signed-off-by: Raphael Norwitz Reviewed-by: Thomas Huth Message-ID: <20260204194923.17704-1-rnorwitz@nvidia.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 29f88d48f30..2bb8bba893b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2797,7 +2797,7 @@ F: tests/functional/aarch64/test_virt_gpu.py F: tests/functional/x86_64/test_virtio_gpu.py =20 vhost-user-blk -M: Raphael Norwitz +M: Raphael Norwitz S: Maintained F: contrib/vhost-user-blk/ F: contrib/vhost-user-scsi/ --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886235; cv=none; d=zohomail.com; s=zohoarc; b=nRcoXFwyhpB2EgNdqFdYoTro/FMuk5lWcmJehrWQORnCyLPTL6k33vr3uREFhOJr9iHqoSw/Q/enGl7P5TqkuLYAuALQa7mxGV0guWWbVrW2hOlJqWjPLzU1apmagXKz78UxVdIGUv2W04FQq2BvgVH90b84ufcSsRVioel9CmQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886235; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fmxxv24ZMTniz07J3kVm1uZAxZa+K8UQ9XxfOaY1QR8=; b=UrsSjf8hjosbfXlhH92dJHX77lCUUQvYhCRwQT4pglpFZtIB6JF8twjdPu/jg5KxeRW506iMPlrckaBsDRP+MakH+GujL1/n4dQoLJ9lTduHjYs2/GX/EfzsO3DufvSbNAyYEhKJA/Wn3iT+FQZmAEHmzGlFWlOryocOhgnoD94= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177088623528248.62902647616977; Thu, 12 Feb 2026 00:50:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSOU-0001al-1g; Thu, 12 Feb 2026 03:49:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOS-0001aH-Hj for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:49:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOR-0001M6-0t for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:49:48 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-513-BRt8PWULP0ackrRwsW8U_Q-1; Thu, 12 Feb 2026 03:49:41 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CCFE91954B0E; Thu, 12 Feb 2026 08:49:39 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6E1ED30001B9; Thu, 12 Feb 2026 08:49:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fmxxv24ZMTniz07J3kVm1uZAxZa+K8UQ9XxfOaY1QR8=; b=jEW4iBg2U0TXN2x37jGMP18ip6GUF1ZCWqeeap1xsQxdi9+SzbeREoCiTC/8mkOmg/b7yi dulbk2VNGXIrBpL4EFcWVIa/SLrKriJ8Oi31PVMugn2X/3DSww1t+oHBsCVuifiRTUr0sz y2B3v74z0df95efaEyH27+q4cJ4kIUo= X-MC-Unique: BRt8PWULP0ackrRwsW8U_Q-1 X-Mimecast-MFC-AGG-ID: BRt8PWULP0ackrRwsW8U_Q_1770886180 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Eric Farman , Farhan Ali , Hendrik Brueckner , Matthew Rosato , Christian Borntraeger , Alex Williamson Subject: [PULL 02/14] MAINTAINERS: Replace backup for s390 PCI Date: Thu, 12 Feb 2026 09:49:15 +0100 Message-ID: <20260212084927.258642-3-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886237642158500 Content-Type: text/plain; charset="utf-8" From: Eric Farman Farhan has been doing a masterful job coming on in the s390 PCI space, and my own attention has been lacking. Let's make MAINTAINERS reflect reality. Signed-off-by: Eric Farman Acked-by: Farhan Ali Acked-by: Hendrik Brueckner Acked-by: Matthew Rosato Acked-by: Christian Borntraeger Acked-by: Alex Williamson Message-ID: <20260202144702.1783102-1-farman@linux.ibm.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2bb8bba893b..50ab7129ff4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1864,7 +1864,8 @@ L: qemu-s390x@nongnu.org =20 S390 PCI M: Matthew Rosato -M: Eric Farman +M: Farhan Ali +R: Eric Farman S: Supported F: hw/s390x/s390-pci* F: include/hw/s390x/s390-pci* --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886237; cv=none; d=zohomail.com; s=zohoarc; b=Pbr8oUR/ScwRkqTKDHDxmeMoYsHbBi+IHz9StvMkJNR/gEmam5Z+x2mdafc+G69da0PX67asR8Kj1Vm5tAy8J4AzixQ9u/fYf6pdW8oWFplWLGEPi88IWp7m/XszftSMb9c+cdIbApgu7b+jGNYvf1IfU9b4j5aKZJGOZ+WAMaw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886237; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TD0Pg2vzQFX1D6MHJBg5f+fb46wxb1TLIVUwptVYGVg=; b=E9/qwxBtlRLiUfxrbRXJnDq/EFPoLijUyg/72mUjIKmNo2u4jYGORz8Fw8KSxjNL6h6feY9fSbTAY+eM3siQrYsv3F71C9kJaCVXdbMYyIIy+SG4FJtQLzjYVwInTKKieTYBmDlRuBF9JwPn/dK2mARbVoqifFOe3qmNym9YXq4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770886237893254.13777942472473; Thu, 12 Feb 2026 00:50:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSOS-0001aW-M1; Thu, 12 Feb 2026 03:49:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOR-0001a4-Ab for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:49:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOP-0001M2-R1 for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:49:47 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-jFqff7wrMOiEVFHgVfrPNA-1; Thu, 12 Feb 2026 03:49:43 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9159A1956048; Thu, 12 Feb 2026 08:49:42 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C4EC330001B9; Thu, 12 Feb 2026 08:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TD0Pg2vzQFX1D6MHJBg5f+fb46wxb1TLIVUwptVYGVg=; b=YiSnJR73CpY6CHmIbLAfpt9cWm/bwaKgR5EA4CoNaPlBy2REcVeQODimkGoAm+jASDJusU qw2YxL1EpGaLFBlLnmU3oLUdL7BsLyPfOBLh4KXOjFNp/5ckHzHGK6D+STkaRCmz4Zjx4F ifLDzGRzfHodtzX6YHjzNAEet0aiyJ0= X-MC-Unique: jFqff7wrMOiEVFHgVfrPNA-1 X-Mimecast-MFC-AGG-ID: jFqff7wrMOiEVFHgVfrPNA_1770886182 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Yodel Eldar Subject: [PULL 03/14] tests/.../reverse_debugging: Remove unsatisfiable condition Date: Thu, 12 Feb 2026 09:49:16 +0100 Message-ID: <20260212084927.258642-4-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886239693158500 Content-Type: text/plain; charset="utf-8" From: Yodel Eldar get_qemu_img() already skips the test if qemu-img is not found and does not return None. Eliminate the check for None on its result, and the unreachable skipTest() gated by it. Signed-off-by: Yodel Eldar Reviewed-by: Thomas Huth Message-ID: <20260203182153.75276-1-yodel.eldar@yodel.dev> Signed-off-by: Thomas Huth --- tests/functional/reverse_debugging.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/functional/reverse_debugging.py b/tests/functional/rever= se_debugging.py index 8e6f0b0e923..eaf178da496 100644 --- a/tests/functional/reverse_debugging.py +++ b/tests/functional/reverse_debugging.py @@ -73,9 +73,6 @@ def reverse_debugging(self, gdb_arch, shift=3D7, args=3DN= one, big_endian=3DFalse): self.log.info('creating qcow2 image for VM snapshots') image_path =3D os.path.join(self.workdir, 'disk.qcow2') qemu_img =3D get_qemu_img(self) - if qemu_img is None: - self.skipTest('Could not find "qemu-img", which is required to= ' - 'create the temporary qcow2 image') out =3D check_output([qemu_img, 'create', '-f', 'qcow2', image_pat= h, '128M'], encoding=3D'utf8') self.log.info("qemu-img: %s" % out) --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886295; cv=none; d=zohomail.com; s=zohoarc; b=TJhhJgzq9a2YwbU1tirFTtWsXZasBfJnYY4+hRr7nknTpmMFPZrHKGgALKh2LiK+/jOGS8RqmhzWgGaRrsmkHcppKOFE94ct4tACHU9JRuIRCmsYgShRrcXC5V8KICs61jlB8C87xfScl2NoTCNdT6Owjkpb7m1KmPQWB/d0o3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886295; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NGa594vdaxZMNqUSsyfyH8cIJvoq1KL0e1V4ObKCg8k=; b=hwdfImsAgNN35JNKIzsawWWRoOcbG20Rzv3UZFLjEVluilrEl27+1OMVI89zYQXU4bOb+8QIs44MzGmfvIPlonbolX69XRvEd+cMzgjvZpO0RFAsQK8W5YXm9yPxteii/BjmICOEngtjqSeY7vS4vUmRZFOuZp+SfUHu8iIrKco= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770886295166899.6197954226634; Thu, 12 Feb 2026 00:51:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSOZ-0001bY-3Q; Thu, 12 Feb 2026 03:49:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOX-0001bA-HZ for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:49:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOV-0001Mb-VD for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:49:53 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-475-S4erk78cNi6d3Qd7DhOpVQ-1; Thu, 12 Feb 2026 03:49:47 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E22E21955D8C; Thu, 12 Feb 2026 08:49:45 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 533CE30001B9; Thu, 12 Feb 2026 08:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NGa594vdaxZMNqUSsyfyH8cIJvoq1KL0e1V4ObKCg8k=; b=UVu0UAdbIA3wxx34zf95+09+RU9ixoFNG1rhyuB1ilwZEJxzamgRVnZgZwPxGIVktmGXj4 IigwnNX4wMZ0ZVlHQZG65fmlO0BrhLJUcZIJwNJb7jYtty69E4r6X5FcXdQCJ6a1BWaQK3 jD5BNWzg9V+ymzy3YPz6Zrp/KHwxXmk= X-MC-Unique: S4erk78cNi6d3Qd7DhOpVQ-1 X-Mimecast-MFC-AGG-ID: S4erk78cNi6d3Qd7DhOpVQ_1770886186 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Vladimir Sementsov-Ogievskiy , Halil Pasic , Eric Farman Subject: [PULL 04/14] virtio-ccw: virtio_ccw_set_guest_notifier(): fix failure path Date: Thu, 12 Feb 2026 09:49:17 +0100 Message-ID: <20260212084927.258642-5-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886296438158500 Content-Type: text/plain; charset="utf-8" From: Vladimir Sementsov-Ogievskiy We leak notifier initialization on that failure path. Let's cleanup it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Halil Pasic Reviewed-by: Eric Farman Reviewed-by: Thomas Huth Message-ID: <20260119185228.203296-8-vsementsov@yandex-team.ru> Signed-off-by: Thomas Huth --- hw/s390x/virtio-ccw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 6855e20d09e..ba55bf4fe97 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -1038,6 +1038,7 @@ static int virtio_ccw_set_guest_notifier(VirtioCcwDev= ice *dev, int n, if (r) { virtio_queue_set_guest_notifier_fd_handler(vq, false, with_irqfd); + event_notifier_cleanup(notifier); return r; } } --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886276; cv=none; d=zohomail.com; s=zohoarc; b=dGqw7QM0taWt41dhFLXVHHkd2fv7wlvYyRbNGUhi5jiWzKLfkh/jQ3tQ8QlTKH1oGkQSHtgYACpMgt5g82Jpn88bpPbei56LASDHDQpfsJwXqibKUOeN19018Vx8C5UuXNnWQECtmSBHbI1QztpswiQGblndX0Lnjg5T+dZ39GY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886276; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pTMUfTLBP3siZVKRvBSgPtyl1JF9n3OVxDFJEwc5d4U=; b=CCqNRcUkqB4OWQAjeGV7yd/rNTcw3ZAfa8j+AuMt3mRM5isX0XuORO/NhrMgps5Hj5Xumxu/bijRHC9O5g+9GgTR0oBiSw46Kq2GvYB9zi0MNxlLRFNnQSg8zNiMAYMBLyxs/5Bb7v5TdhLeSjcEyKIsVWSJzYpzzh69HQZbTFs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770886276565708.717015496484; Thu, 12 Feb 2026 00:51:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSPC-0002en-JP; Thu, 12 Feb 2026 03:50:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSPA-0002a0-HA for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSP8-0001bm-Th for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:32 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-pe3hKnePOGm3dWRbJAnM1A-1; Thu, 12 Feb 2026 03:49:50 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7DBFE19560B2; Thu, 12 Feb 2026 08:49:49 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A408130001B9; Thu, 12 Feb 2026 08:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pTMUfTLBP3siZVKRvBSgPtyl1JF9n3OVxDFJEwc5d4U=; b=OX4vSwSbn2wyobLBFm1E5i4K0tslbHgARcKUbp3fQ62F0zSqBuSqYz0ppOqcLVqNePvn0P XdBHAD34LWD+hhu0wCvsghjDRmz9Wp/K897dRFSDvP8m2IlWIIU4VytODzNW81Qq/PZ0iv RjCJvwcSi0e68jItakcE9yTcx+QYxi4= X-MC-Unique: pe3hKnePOGm3dWRbJAnM1A-1 X-Mimecast-MFC-AGG-ID: pe3hKnePOGm3dWRbJAnM1A_1770886189 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Jaehoon Kim , Matthew Rosato , Farhan Ali , Eric Farman Subject: [PULL 05/14] s390x/pci: Fix endianness for zPCI BAR values. Date: Thu, 12 Feb 2026 09:49:18 +0100 Message-ID: <20260212084927.258642-6-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886279094154100 Content-Type: text/plain; charset="utf-8" From: Jaehoon Kim During zPCI scan, BAR configuration data retrieved via CLP Query was misinterpreted due to an endianness mismatch between QEMU and the guest kernel. The guest kernel's clp_store_query_pci_fn() expects BAR values in little-endian format and converts them with le32_to_cpu(). However, QEMU was incorrectly sending them in big-endian format, not following the architecture specification. This caused incorrect bit-swapping in the kernel, leading zpci_setup_bus_resources() to perform registration checks against invalid flags, making the process ineffective. Observation values for zPCI device (NVMe passthrough): LPAR from real CLP: [ 0.865595] Resource: PCI Bus 0000:00 -> zdev->bar[0].val: 0x4 [ 0.865597] start: 0x4000000000000000 [ 0.865598] end: 0x4000000000003fff [ 0.865600] flags: 0x100200 QEMU before fix (wrong): [ 0.601083] Resource: PCI Bus 0001:00 -> zdev->bar[0].val: 0x4000000 [ 0.601085] start: 0x4003000000000000 [ 0.601086] end: 0x4003000000003fff [ 0.601087] flags: 0x200 QEMU after fix (correct): [ 0.601116] Resource: PCI Bus 0001:00 -> zdev->bar[0].val: 0x4 [ 0.601117] start: 0x4003000000000000 [ 0.601118] end: 0x4003000000003fff [ 0.601119] flags: 0x100200 Signed-off-by: Jaehoon Kim Reviewed-by: Matthew Rosato Reviewed-by: Farhan Ali Reviewed-by: Eric Farman Message-ID: <20260206164645.1845366-1-jhkim@linux.ibm.com> Signed-off-by: Thomas Huth --- hw/s390x/s390-pci-inst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c index 6b67c3c109f..10066ca6180 100644 --- a/hw/s390x/s390-pci-inst.c +++ b/hw/s390x/s390-pci-inst.c @@ -307,7 +307,7 @@ int clp_service_call(S390CPU *cpu, uint8_t r2, uintptr_= t ra) uint32_t data =3D pci_get_long(pbdev->pdev->config + PCI_BASE_ADDRESS_0 + (i * 4)); =20 - stl_be_p(&resquery->bar[i], data); + stl_le_p(&resquery->bar[i], data); resquery->bar_size[i] =3D pbdev->pdev->io_regions[i].size ? ctz64(pbdev->pdev->io_regions[i].size)= : 0; trace_s390_pci_bar(i, --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886226; cv=none; d=zohomail.com; s=zohoarc; b=fPGsCg2v0Id5UP+27vLPLQE64npgR/xiCxsLjxoTDniXIb92e6G9Mt6f3Iwq7RS0LLxbZ1jF6QE4iQfHZnkmZCebDH+thbIKTZEh0wMtJwgzh9L1+fhcf924N/l3AIdnEJ+Lekzz5oT7049Bmfcs7eVDW38VrHfltcRB/SFsOAI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886226; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OZ37/LfqqllKFjk+3ut64Hwsv/HDV487dbnHYbxpmjA=; b=mQYLet4qhwYqW5op5IK+M0gmqg9uS8XP73UzFWCrSFfgTEpf+cKI6Lbn4a+v/nlNY/VjwbSWiBBH13NhCvq3TOS6oGFF16HbyIBvTYZQ1apdqmq/hRMOU66sOMP/IY1ljQ/dtu3lFR77dBKk3vk8LZVw+P4uO+x6H3NL58A06DE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770886226050875.3217322429824; Thu, 12 Feb 2026 00:50:26 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSOk-0001cu-7H; Thu, 12 Feb 2026 03:50:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOe-0001c6-Di for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOc-0001N0-2Z for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:00 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-169-V5fbif67MsyLvYbfsjGGGA-1; Thu, 12 Feb 2026 03:49:53 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8DD361800465; Thu, 12 Feb 2026 08:49:52 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7E25730001B9; Thu, 12 Feb 2026 08:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OZ37/LfqqllKFjk+3ut64Hwsv/HDV487dbnHYbxpmjA=; b=BANKhxpcothloA9wCoPOhEUCunrIlf19OMb2XG8VexMGW+WDMCfDBmJC/YPnz3bmJrIJlt TIO4j8ARnZ3MTl48dUUkqNjqT0XTIKu6pvSwovHENasB2Q7TJVPDWcwTdicfFnYCgBKP0C CDpSB21VvzjR/1C3VkV/xzya6+XEfnk= X-MC-Unique: V5fbif67MsyLvYbfsjGGGA-1 X-Mimecast-MFC-AGG-ID: V5fbif67MsyLvYbfsjGGGA_1770886192 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Akihiko Odaki Subject: [PULL 06/14] Revert "rcu: Unify force quiescent state" Date: Thu, 12 Feb 2026 09:49:19 +0100 Message-ID: <20260212084927.258642-7-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886228655158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth This reverts commit 55d98e3edeeb17dd8445db27605d2b34f4c3ba85. The commit introduced a regression in the replay functional test on alpha (tests/functional/alpha/test_replay.py), that causes CI failures regularly. Thus revert this change until someone has figured out what is going wrong here. Buglink: https://gitlab.com/qemu-project/qemu/-/issues/3197 Reviewed-by: Akihiko Odaki Signed-off-by: Thomas Huth Message-ID: <20260209120336.41454-1-thuth@redhat.com> --- util/rcu.c | 79 +++++++++++++++++++----------------------------------- 1 file changed, 28 insertions(+), 51 deletions(-) diff --git a/util/rcu.c b/util/rcu.c index acac9446ea9..b703c86f15a 100644 --- a/util/rcu.c +++ b/util/rcu.c @@ -43,14 +43,10 @@ #define RCU_GP_LOCKED (1UL << 0) #define RCU_GP_CTR (1UL << 1) =20 - -#define RCU_CALL_MIN_SIZE 30 - unsigned long rcu_gp_ctr =3D RCU_GP_LOCKED; =20 QemuEvent rcu_gp_event; static int in_drain_call_rcu; -static int rcu_call_count; static QemuMutex rcu_registry_lock; static QemuMutex rcu_sync_lock; =20 @@ -80,29 +76,15 @@ static void wait_for_readers(void) { ThreadList qsreaders =3D QLIST_HEAD_INITIALIZER(qsreaders); struct rcu_reader_data *index, *tmp; - int sleeps =3D 0; - bool forced =3D false; =20 for (;;) { - /* - * Force the grace period to end and wait for it if any of the - * following heuristical conditions are satisfied: - * - A decent number of callbacks piled up. - * - It timed out. - * - It is in a drain_call_rcu() call. - * - * Otherwise, periodically poll the grace period, hoping it ends - * promptly. + /* We want to be notified of changes made to rcu_gp_ongoing + * while we walk the list. */ - if (!forced && - (qatomic_read(&rcu_call_count) >=3D RCU_CALL_MIN_SIZE || - sleeps >=3D 5 || qatomic_read(&in_drain_call_rcu))) { - forced =3D true; + qemu_event_reset(&rcu_gp_event); =20 - QLIST_FOREACH(index, ®istry, node) { - notifier_list_notify(&index->force_rcu, NULL); - qatomic_set(&index->waiting, true); - } + QLIST_FOREACH(index, ®istry, node) { + qatomic_set(&index->waiting, true); } =20 /* Here, order the stores to index->waiting before the loads of @@ -124,6 +106,8 @@ static void wait_for_readers(void) * get some extra futex wakeups. */ qatomic_set(&index->waiting, false); + } else if (qatomic_read(&in_drain_call_rcu)) { + notifier_list_notify(&index->force_rcu, NULL); } } =20 @@ -131,8 +115,7 @@ static void wait_for_readers(void) break; } =20 - /* - * Sleep for a while and try again. + /* Wait for one thread to report a quiescent state and try again. * Release rcu_registry_lock, so rcu_(un)register_thread() doesn't * wait too much time. * @@ -150,20 +133,7 @@ static void wait_for_readers(void) * rcu_registry_lock is released. */ qemu_mutex_unlock(&rcu_registry_lock); - - if (forced) { - qemu_event_wait(&rcu_gp_event); - - /* - * We want to be notified of changes made to rcu_gp_ongoing - * while we walk the list. - */ - qemu_event_reset(&rcu_gp_event); - } else { - g_usleep(10000); - sleeps++; - } - + qemu_event_wait(&rcu_gp_event); qemu_mutex_lock(&rcu_registry_lock); } =20 @@ -203,11 +173,15 @@ void synchronize_rcu(void) } } =20 + +#define RCU_CALL_MIN_SIZE 30 + /* Multi-producer, single-consumer queue based on urcu/static/wfqueue.h * from liburcu. Note that head is only used by the consumer. */ static struct rcu_head dummy; static struct rcu_head *head =3D &dummy, **tail =3D &dummy.next; +static int rcu_call_count; static QemuEvent rcu_call_ready_event; =20 static void enqueue(struct rcu_head *node) @@ -285,27 +259,30 @@ static void *call_rcu_thread(void *opaque) rcu_register_thread(); =20 for (;;) { - int n; + int tries =3D 0; + int n =3D qatomic_read(&rcu_call_count); =20 - /* + /* Heuristically wait for a decent number of callbacks to pile up. * Fetch rcu_call_count now, we only must process elements that we= re * added before synchronize_rcu() starts. */ - for (;;) { - qemu_event_reset(&rcu_call_ready_event); - n =3D qatomic_read(&rcu_call_count); - if (n) { - break; - } - + while (n =3D=3D 0 || (n < RCU_CALL_MIN_SIZE && ++tries <=3D 5)) { + g_usleep(10000); + if (n =3D=3D 0) { + qemu_event_reset(&rcu_call_ready_event); + n =3D qatomic_read(&rcu_call_count); + if (n =3D=3D 0) { #if defined(CONFIG_MALLOC_TRIM) - malloc_trim(4 * 1024 * 1024); + malloc_trim(4 * 1024 * 1024); #endif - qemu_event_wait(&rcu_call_ready_event); + qemu_event_wait(&rcu_call_ready_event); + } + } + n =3D qatomic_read(&rcu_call_count); } =20 - synchronize_rcu(); qatomic_sub(&rcu_call_count, n); + synchronize_rcu(); bql_lock(); while (n > 0) { node =3D try_dequeue(); --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886265; cv=none; d=zohomail.com; s=zohoarc; b=CQgFoxPihalxop7+Q23YUhIQ/v8/qikDeWl1PAA95FCUP1NgeN4mRaYnqM88ABh9m98/90+GYs6qeM2FJ9sdIXthBoiHF4dUKoCceKFQs894UsvgqvQyQwkogfja6DodnGX1+JsxoAy3bskMsFIFuKJpcUhpcqvGqhjPvM6jsz4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886265; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gZfGTX4NYlWHnlaaRpCMn8U29PRDA0XewDCqCAnfIEc=; b=ik8Fuvz+u9HUuZ/t2SShEO9KZ0jXUPVpGh6FEdzWC3Q5R/tA9Q3MzHaFN5H8SAISgP2UvFaRkGTjWdtp5ktL2ERyIIitrFfxNbMwLPHjQgssfkghI/Z5nCJlYfgUDQWH0yZ9nQBTxg+hj8XdlE+5l+1i2JaIsc7x2jqS10XcdnU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770886265436406.8475784212196; Thu, 12 Feb 2026 00:51:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSOh-0001cW-MB; Thu, 12 Feb 2026 03:50:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOe-0001c7-Ds for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOc-0001N5-OD for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:00 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-474-PlYxfoYTM7Kr7ycj0iMH6g-1; Thu, 12 Feb 2026 03:49:56 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2AAEA1956094; Thu, 12 Feb 2026 08:49:55 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 50DBB30001B9; Thu, 12 Feb 2026 08:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gZfGTX4NYlWHnlaaRpCMn8U29PRDA0XewDCqCAnfIEc=; b=hNGm300/GHXvwGK2W8ONSzT1gD4StzoJm+eXGdGW4DfUBkr+frqVGe9lsEDK90I6rPQpOe pA8YNdyqxQ99zy3+LiyjLAb7mN4fQNsi5aVr5TLSPUTI6ywgc0uWz07wvMmjHnBaxr8wXb 2U9sUeI10wC/NLDTIUG357wf1GzxtHQ= X-MC-Unique: PlYxfoYTM7Kr7ycj0iMH6g-1 X-Mimecast-MFC-AGG-ID: PlYxfoYTM7Kr7ycj0iMH6g_1770886195 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Ilya Leoshkevich Subject: [PULL 07/14] target/s390x: Dump Floating-Point-Control Register Date: Thu, 12 Feb 2026 09:49:20 +0100 Message-ID: <20260212084927.258642-8-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886266862154100 From: Ilya Leoshkevich Knowing the value of this register is very useful for debugging floating-point code. Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Thomas Huth Signed-off-by: Ilya Leoshkevich Message-ID: <20260210214044.1174699-2-iii@linux.ibm.com> Signed-off-by: Thomas Huth --- target/s390x/cpu-dump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/cpu-dump.c b/target/s390x/cpu-dump.c index 869d3a4ad54..5b852928031 100644 --- a/target/s390x/cpu-dump.c +++ b/target/s390x/cpu-dump.c @@ -63,6 +63,7 @@ void s390_cpu_dump_state(CPUState *cs, FILE *f, int flags) (i % 4) =3D=3D 3 ? '\n' : ' '); } } + qemu_fprintf(f, "FPC=3D%08" PRIx32 "\n", env->fpc); } =20 #ifndef CONFIG_USER_ONLY --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886241; cv=none; d=zohomail.com; s=zohoarc; b=FvGttAlP1ea1vKIFowpfGQS45Iy0hffMjEWb+RIk5BvTNe3jQbOvoCiTEbhxhdQvmLg3rlCsUKDrWVDjevWU+lXoU/VN4jLsnKQCdsc65MjXUpZvlepS6mRBXnc3+kE+jX/DU4LYMAKWE41LDSGzN1rmCDdWBbCWanTYcDIVOJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886241; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V1PMvhmU+0X5bb/vrd/ZtltYn0OOHbEDaP+XQQ2cnKo=; b=RGKuvhfqdgnVkd0bxi9JLPb3e0KtRxmivTyk5K8/PBFOCzocer3O2VAk8nCi4+PAzTPzAfec48UHlJAQ6z3PDDdFa5uyJhMIjrhAh+fYRVcYJAtMpTqfP6oEdWpBz6erFJ6fwAi/wp61T1oMQI53Jcm7IIU9bZvZwyYgyU59ovA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177088624117786.57297724769558; Thu, 12 Feb 2026 00:50:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSOo-0001hQ-O4; Thu, 12 Feb 2026 03:50:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOj-0001cm-4W for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOh-0001Nm-KE for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:04 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-UwHeZJTeNTinRg8HVn-2tA-1; Thu, 12 Feb 2026 03:49:59 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7BA371956066; Thu, 12 Feb 2026 08:49:58 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E3F7730001BB; Thu, 12 Feb 2026 08:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V1PMvhmU+0X5bb/vrd/ZtltYn0OOHbEDaP+XQQ2cnKo=; b=IIbTFJXX/1u+zP90lxUhLE5mis700cAbnCdGCzlVcsxwontZpfAzPfAHPr8LmF1HQkNoFC qbtpHcxQlwCdu+FrOuPfx9EsIZOoRr5L7r4V/iv3KyJ/HRDTIh3ps7k+pS1BvvmR82vA9n IjFEp5ZHVsFXTGdLYvMTqe2e3ZH7w9Y= X-MC-Unique: UwHeZJTeNTinRg8HVn-2tA-1 X-Mimecast-MFC-AGG-ID: UwHeZJTeNTinRg8HVn-2tA_1770886198 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Richard Henderson , Ilya Leoshkevich Subject: [PULL 08/14] target/s390x: Extract s390_get_bfp_rounding_mode() Date: Thu, 12 Feb 2026 09:49:21 +0100 Message-ID: <20260212084927.258642-9-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886242618154100 Content-Type: text/plain; charset="utf-8" From: Ilya Leoshkevich For DIVIDE TO INTEGER it will be helpful to pass final-quotient rounding mode around explicitly rather than setting it in fpu_status implicitly. To facilitate this, extract a function for converting the mask to the rounding mode. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Ilya Leoshkevich Message-ID: <20260210214044.1174699-3-iii@linux.ibm.com> Signed-off-by: Thomas Huth --- target/s390x/tcg/fpu_helper.c | 62 +++++++++++++++++------------------ 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/target/s390x/tcg/fpu_helper.c b/target/s390x/tcg/fpu_helper.c index 1ba43715ac1..7a3ff501a46 100644 --- a/target/s390x/tcg/fpu_helper.c +++ b/target/s390x/tcg/fpu_helper.c @@ -56,6 +56,35 @@ uint8_t s390_softfloat_exc_to_ieee(unsigned int exc) return s390_exc; } =20 +static int s390_get_bfp_rounding_mode(CPUS390XState *env, int m3) +{ + switch (m3) { + case 0: + /* current mode */ + return env->fpu_status.float_rounding_mode; + case 1: + /* round to nearest with ties away from 0 */ + return float_round_ties_away; + case 3: + /* round to prepare for shorter precision */ + return float_round_to_odd; + case 4: + /* round to nearest with ties to even */ + return float_round_nearest_even; + case 5: + /* round to zero */ + return float_round_to_zero; + case 6: + /* round to +inf */ + return float_round_up; + case 7: + /* round to -inf */ + return float_round_down; + default: + g_assert_not_reached(); + } +} + /* Should be called after any operation that may raise IEEE exceptions. */ static void handle_exceptions(CPUS390XState *env, bool XxC, uintptr_t reta= ddr) { @@ -416,37 +445,8 @@ int s390_swap_bfp_rounding_mode(CPUS390XState *env, in= t m3) { int ret =3D env->fpu_status.float_rounding_mode; =20 - switch (m3) { - case 0: - /* current mode */ - break; - case 1: - /* round to nearest with ties away from 0 */ - set_float_rounding_mode(float_round_ties_away, &env->fpu_status); - break; - case 3: - /* round to prepare for shorter precision */ - set_float_rounding_mode(float_round_to_odd, &env->fpu_status); - break; - case 4: - /* round to nearest with ties to even */ - set_float_rounding_mode(float_round_nearest_even, &env->fpu_status= ); - break; - case 5: - /* round to zero */ - set_float_rounding_mode(float_round_to_zero, &env->fpu_status); - break; - case 6: - /* round to +inf */ - set_float_rounding_mode(float_round_up, &env->fpu_status); - break; - case 7: - /* round to -inf */ - set_float_rounding_mode(float_round_down, &env->fpu_status); - break; - default: - g_assert_not_reached(); - } + set_float_rounding_mode(s390_get_bfp_rounding_mode(env, m3), + &env->fpu_status); return ret; } =20 --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886249; cv=none; d=zohomail.com; s=zohoarc; b=bchsfiGFH1a7ikUH2/tPU9cXP9KqgqUDVydfCdMFguv+B65/ymq2jUe5Bk0jSqiTlmjhPcwMvRb1HG/8wjGq1liMmdWwqxNQxJ+DiR5BBwihvjn2svvxA+9nueqp0lUfT8mGqJwf/FylEz+lDKE5ItauB8pdMxEZPKY+q14I+2E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886249; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=62fbNyXOrCl7euGwjO06XPPerP37OxSU9/Ge6DrdZK4=; b=Q7tqi9uHVwt7C83ExdXwDfOoguVHHUqXgJDWmYw37dRgcLVXeBo5MoBacJ/KiSA8wHc+Q7G/bjjAh5eOekjCljG+0xBt8+8fKIOp2WrUxbKWt5SmzrPM1yUkyGOcUGTiXminBWogRuFwztsFwm54zdSoh944BrcxwTNPBic7GYs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770886249944556.4564100353757; Thu, 12 Feb 2026 00:50:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSOw-0001mM-4X; Thu, 12 Feb 2026 03:50:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOp-0001i0-95 for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOl-0001Zz-CW for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:08 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-a3B6b3csPM-2NyMc62SHgw-1; Thu, 12 Feb 2026 03:50:03 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DBA6819560B5; Thu, 12 Feb 2026 08:50:01 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4253730001B9; Thu, 12 Feb 2026 08:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=62fbNyXOrCl7euGwjO06XPPerP37OxSU9/Ge6DrdZK4=; b=fJrvdaupXDfUcU1KkI9AoLH2uzKKYwCbfDFVcw2DfP3wfx8UiCEvhhlOAD3GvFwoMzCmTE HnKmpxtV+HE0/JpTJx/BxnmXYJajiLuodIUcHpjPyRMG8aKl7kZ85u0p1uQ5zzQxo7VMVR OrzAFe5xBBwrhSN8coXuvRW+5kH8J3c= X-MC-Unique: a3B6b3csPM-2NyMc62SHgw-1 X-Mimecast-MFC-AGG-ID: a3B6b3csPM-2NyMc62SHgw_1770886202 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Ilya Leoshkevich Subject: [PULL 09/14] fpu: Restrict parts_round_to_int_normal to target precision Date: Thu, 12 Feb 2026 09:49:22 +0100 Message-ID: <20260212084927.258642-10-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886252650154100 Content-Type: text/plain; charset="utf-8" From: Ilya Leoshkevich Currently parts_round_to_int_normal() assumes that its input has just been unpacked and therefore doesn't expect non-zero fraction bits past target precision. The upcoming DIVIDE TO INTEGER use cases needs it to support calculations on intermediate values that utilize all fraction bits, while at the same time restricting the result's precision to frac_size. Delete the "All integral" check, because even though really large values are always integer, their low fraction bits still need to be truncated. For the same reason, make sure rnd_mask covers at least fraction bits past target precision. Signed-off-by: Ilya Leoshkevich Reviewed-by: Thomas Huth Message-ID: <20260210214044.1174699-4-iii@linux.ibm.com> Signed-off-by: Thomas Huth --- fpu/softfloat-parts.c.inc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc index 5e0438fc0b7..79b56014ab9 100644 --- a/fpu/softfloat-parts.c.inc +++ b/fpu/softfloat-parts.c.inc @@ -1118,11 +1118,6 @@ static bool partsN(round_to_int_normal)(FloatPartsN = *a, FloatRoundMode rmode, return true; } =20 - if (a->exp >=3D frac_size) { - /* All integral */ - return false; - } - if (N > 64 && a->exp < N - 64) { /* * Rounding is not in the low word -- shift lsb to bit 2, @@ -1132,8 +1127,13 @@ static bool partsN(round_to_int_normal)(FloatPartsN = *a, FloatRoundMode rmode, frac_shrjam(a, shift_adj); frac_lsb =3D 1 << 2; } else { + /* + * Rounding is in the low word -- compute the lsb offset for round= ing + * and for clamping to the target precision, then map it to an off= set + * within frac_lo. + */ shift_adj =3D 0; - frac_lsb =3D DECOMPOSED_IMPLICIT_BIT >> (a->exp & 63); + frac_lsb =3D DECOMPOSED_IMPLICIT_BIT >> (MIN(a->exp, frac_size) & = 63); } =20 frac_lsbm1 =3D frac_lsb >> 1; --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886246; cv=none; d=zohomail.com; s=zohoarc; b=n/JX0KI2R2ZHpzc7BOX+BRPiMkzWEDx0VLQ9m/wyf8tAphxy0fME1njHKDbwoSu33I9tLqLv/1jVnitZFIAXW8mxrnv8hLRcbujHNiRX/5B7xbSLmG8pNA0Bg9ePM6UIFYCtCsPjeRbqMrwuZrDW6CXbBXENZj9g7Eu3CiHof6E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886246; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=S6nhZJMvOwkIA1E1Hj872OWt8/3KLzl3rw16ie6S3h8=; b=YxBiiwyEMD+GBXItDYpOHc+zUBN8RbA4Df8LUeGuffQwg/7Bsy7u1Uo5Hwr7ZC7ErnS3V8Xx8PXI1RTIphnnUMRGBMWhZ9wTvR7/hTkvM2sfwCWHCVHAS53bgifsmV/v6K7oDsXgenOwoYcnb7Ydbqw3+zPWREEelgb9nwlI+Zw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770886246647650.3543722168594; Thu, 12 Feb 2026 00:50:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSP4-0002AZ-T1; Thu, 12 Feb 2026 03:50:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOs-0001m0-3m for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOo-0001aC-2i for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:12 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-AFfrGZomNXGBgR6Trv9yEQ-1; Thu, 12 Feb 2026 03:50:05 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5F0B318003F5; Thu, 12 Feb 2026 08:50:04 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8526430001B9; Thu, 12 Feb 2026 08:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S6nhZJMvOwkIA1E1Hj872OWt8/3KLzl3rw16ie6S3h8=; b=ieZ409V2E/IwmVTHAyC24gGFPi3wbKa+uYqA39h58OahJVVJl673kyGKjIG432d4Cf/NrI s24gKV/Io6X+p+smHsIElY/VCxLAdWUV4Xi2uSM2HhA9KQLYRmQM8zwU66ZSjRYZkRXqCH oXuOcNBUz9daNhOr7SMFpifF8tV0DzU= X-MC-Unique: AFfrGZomNXGBgR6Trv9yEQ-1 X-Mimecast-MFC-AGG-ID: AFfrGZomNXGBgR6Trv9yEQ_1770886204 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Richard Henderson , Ilya Leoshkevich Subject: [PULL 10/14] target/s390x: Implement DIVIDE TO INTEGER Date: Thu, 12 Feb 2026 09:49:23 +0100 Message-ID: <20260212084927.258642-11-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886247913158500 Content-Type: text/plain; charset="utf-8" From: Ilya Leoshkevich DIVIDE TO INTEGER computes floating point remainder and is used by LuaJIT, so add it to QEMU. Put the main logic into fpu/, because it is way more convenient to operate on FloatParts than to convert floats back-and-forth. Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich Message-ID: <20260210214044.1174699-5-iii@linux.ibm.com> Signed-off-by: Thomas Huth --- include/fpu/softfloat.h | 11 +++ target/s390x/helper.h | 1 + target/s390x/tcg/insn-data.h.inc | 5 +- fpu/softfloat.c | 142 +++++++++++++++++++++++++++++++ target/s390x/tcg/fpu_helper.c | 56 ++++++++++++ target/s390x/tcg/translate.c | 26 ++++++ 6 files changed, 240 insertions(+), 1 deletion(-) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index c18ab2cb609..66b0c47b5eb 100644 --- a/include/fpu/softfloat.h +++ b/include/fpu/softfloat.h @@ -1372,4 +1372,15 @@ static inline bool float128_unordered_quiet(float128= a, float128 b, *-------------------------------------------------------------------------= ---*/ float128 float128_default_nan(float_status *status); =20 +#define DECLARE_S390_DIVIDE_TO_INTEGER(floatN) = \ +void floatN ## _s390_divide_to_integer(floatN a, floatN b, = \ + int final_quotient_rounding_mode, = \ + bool mask_underflow, bool mask_inex= act, \ + floatN *r, floatN *n, = \ + uint32_t *cc, int *dxc, = \ + float_status *status) +DECLARE_S390_DIVIDE_TO_INTEGER(float32); +DECLARE_S390_DIVIDE_TO_INTEGER(float64); + + #endif /* SOFTFLOAT_H */ diff --git a/target/s390x/helper.h b/target/s390x/helper.h index 1a8a76abb98..6a7426fdac7 100644 --- a/target/s390x/helper.h +++ b/target/s390x/helper.h @@ -46,6 +46,7 @@ DEF_HELPER_FLAGS_3(sxb, TCG_CALL_NO_WG, i128, env, i128, = i128) DEF_HELPER_FLAGS_3(deb, TCG_CALL_NO_WG, i64, env, i64, i64) DEF_HELPER_FLAGS_3(ddb, TCG_CALL_NO_WG, i64, env, i64, i64) DEF_HELPER_FLAGS_3(dxb, TCG_CALL_NO_WG, i128, env, i128, i128) +DEF_HELPER_6(dib, void, env, i32, i32, i32, i32, i32) DEF_HELPER_FLAGS_3(meeb, TCG_CALL_NO_WG, i64, env, i64, i64) DEF_HELPER_FLAGS_3(mdeb, TCG_CALL_NO_WG, i64, env, i64, i64) DEF_HELPER_FLAGS_3(mdb, TCG_CALL_NO_WG, i64, env, i64, i64) diff --git a/target/s390x/tcg/insn-data.h.inc b/target/s390x/tcg/insn-data.= h.inc index baaafe922e9..0d5392eac54 100644 --- a/target/s390x/tcg/insn-data.h.inc +++ b/target/s390x/tcg/insn-data.h.inc @@ -9,7 +9,7 @@ * OPC =3D (op << 8) | op2 where op is the major, op2 the minor opcode * NAME =3D name of the opcode, used internally * FMT =3D format of the opcode (defined in insn-format.h.inc) - * FAC =3D facility the opcode is available in (defined in DisasFacility) + * FAC =3D facility the opcode is available in (define in translate.c) * I1 =3D func in1_xx fills o->in1 * I2 =3D func in2_xx fills o->in2 * P =3D func prep_xx initializes o->*out* @@ -361,6 +361,9 @@ C(0xb91d, DSGFR, RRE, Z, r1p1, r2_32s, r1_P, 0, divs64, 0) C(0xe30d, DSG, RXY_a, Z, r1p1, m2_64, r1_P, 0, divs64, 0) C(0xe31d, DSGF, RXY_a, Z, r1p1, m2_32s, r1_P, 0, divs64, 0) +/* DIVIDE TO INTEGER */ + D(0xb35b, DIDBR, RRF_b, Z, 0, 0, 0, 0, dib, 0, 64) + D(0xb353, DIEBR, RRF_b, Z, 0, 0, 0, 0, dib, 0, 32) =20 /* EXCLUSIVE OR */ C(0x1700, XR, RR_a, Z, r1, r2, new, r1_32, xor, nz32) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 8094358c2e4..87409753483 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -5361,6 +5361,148 @@ floatx80 floatx80_round(floatx80 a, float_status *s= tatus) return floatx80_round_pack_canonical(&p, status); } =20 +static void parts_s390_divide_to_integer(FloatParts64 *a, FloatParts64 *b, + int final_quotient_rounding_mode, + bool mask_underflow, bool mask_in= exact, + const FloatFmt *fmt, + FloatParts64 *r, FloatParts64 *n, + uint32_t *cc, int *dxc, + float_status *status) +{ + /* POp table "Results: DIVIDE TO INTEGER (Part 1 of 2)" */ + if ((float_cmask(a->cls) | float_cmask(b->cls)) & float_cmask_anynan) { + *r =3D *parts_pick_nan(a, b, status); + *n =3D *r; + *cc =3D 1; + } else if (a->cls =3D=3D float_class_inf || b->cls =3D=3D float_class_= zero) { + parts_default_nan(r, status); + *n =3D *r; + *cc =3D 1; + status->float_exception_flags |=3D float_flag_invalid; + } else if (b->cls =3D=3D float_class_inf) { + *r =3D *a; + n->cls =3D float_class_zero; + n->sign =3D a->sign ^ b->sign; + *cc =3D 0; + } else { + FloatParts64 *q, q_buf, *r_precise, r_precise_buf; + int float_exception_flags =3D 0; + bool is_q_smallish; + uint32_t r_flags; + + /* Compute precise quotient */ + q_buf =3D *a; + q =3D parts_div(&q_buf, b, status); + + /* + * Check whether two closest integers can be precisely represented, + * i.e., all their bits fit into the fractional part. + */ + is_q_smallish =3D q->exp < (fmt->frac_size + 1); + + /* + * Final quotient is rounded using final-quotient-rounding method,= and + * partial quotient is rounded toward zero. + * + * Rounding of partial quotient may be inexact. This is the whole = point + * of distinguishing partial quotients, so ignore the exception. + */ + *n =3D *q; + parts_round_to_int_normal(n, + is_q_smallish ? + final_quotient_rounding_mode : + float_round_to_zero, + 0, fmt->frac_size); + + /* Compute precise remainder */ + r_precise_buf =3D *b; + r_precise =3D parts_muladd_scalbn(&r_precise_buf, n, a, 0, + float_muladd_negate_product, statu= s); + + /* Round remainder to the target format */ + *r =3D *r_precise; + status->float_exception_flags =3D 0; + parts_uncanon(r, status, fmt); + r_flags =3D status->float_exception_flags; + r->frac &=3D (1ULL << fmt->frac_size) - 1; + parts_canonicalize(r, status, fmt); + + /* POp table "Results: DIVIDE TO INTEGER (Part 2 of 2)" */ + if (is_q_smallish) { + if (r->cls !=3D float_class_zero) { + if (r->exp < 2 - (1 << (fmt->exp_size - 1))) { + if (mask_underflow) { + float_exception_flags |=3D float_flag_underflow; + *dxc =3D 0x10; + r->exp +=3D fmt->exp_re_bias; + } + } else if (r_flags & float_flag_inexact) { + float_exception_flags |=3D float_flag_inexact; + if (mask_inexact) { + bool saved_r_sign, saved_r_precise_sign; + + /* + * Check whether remainder was truncated (rounded + * toward zero) or incremented. + */ + saved_r_sign =3D r->sign; + saved_r_precise_sign =3D r_precise->sign; + r->sign =3D false; + r_precise->sign =3D false; + if (parts_compare(r, r_precise, status, true) < + float_relation_equal) { + *dxc =3D 0x8; + } else { + *dxc =3D 0xc; + } + r->sign =3D saved_r_sign; + r_precise->sign =3D saved_r_precise_sign; + } + } + } + *cc =3D 0; + } else if (n->exp > (1 << (fmt->exp_size - 1)) - 1) { + n->exp -=3D fmt->exp_re_bias; + *cc =3D r->cls =3D=3D float_class_zero ? 1 : 3; + } else { + *cc =3D r->cls =3D=3D float_class_zero ? 0 : 2; + } + + /* Adjust signs of zero results */ + if (r->cls =3D=3D float_class_zero) { + r->sign =3D a->sign; + } + if (n->cls =3D=3D float_class_zero) { + n->sign =3D a->sign ^ b->sign; + } + + status->float_exception_flags =3D float_exception_flags; + } +} + +#define DEFINE_S390_DIVIDE_TO_INTEGER(floatN) = \ +void floatN ## _s390_divide_to_integer(floatN a, floatN b, = \ + int final_quotient_rounding_mode, = \ + bool mask_underflow, bool mask_inex= act, \ + floatN *r, floatN *n, = \ + uint32_t *cc, int *dxc, = \ + float_status *status) = \ +{ = \ + FloatParts64 pa, pb, pr, pn; = \ + = \ + floatN ## _unpack_canonical(&pa, a, status); = \ + floatN ## _unpack_canonical(&pb, b, status); = \ + parts_s390_divide_to_integer(&pa, &pb, final_quotient_rounding_mode, = \ + mask_underflow, mask_inexact, = \ + &floatN ## _params, = \ + &pr, &pn, cc, dxc, status); = \ + *r =3D floatN ## _round_pack_canonical(&pr, status); = \ + *n =3D floatN ## _round_pack_canonical(&pn, status); = \ +} + +DEFINE_S390_DIVIDE_TO_INTEGER(float32) +DEFINE_S390_DIVIDE_TO_INTEGER(float64) + static void __attribute__((constructor)) softfloat_init(void) { union_float64 ua, ub, uc, ur; diff --git a/target/s390x/tcg/fpu_helper.c b/target/s390x/tcg/fpu_helper.c index 7a3ff501a46..122994960a6 100644 --- a/target/s390x/tcg/fpu_helper.c +++ b/target/s390x/tcg/fpu_helper.c @@ -315,6 +315,62 @@ Int128 HELPER(dxb)(CPUS390XState *env, Int128 a, Int12= 8 b) return RET128(ret); } =20 +void HELPER(dib)(CPUS390XState *env, uint32_t r1, uint32_t r2, uint32_t r3, + uint32_t m4, uint32_t bits) +{ + int final_quotient_rounding_mode =3D s390_get_bfp_rounding_mode(env, m= 4); + bool mask_underflow =3D (env->fpc >> 24) & S390_IEEE_MASK_UNDERFLOW; + bool mask_inexact =3D (env->fpc >> 24) & S390_IEEE_MASK_INEXACT; + float32 a32, b32, n32, r32; + float64 a64, b64, n64, r64; + int dxc =3D -1; + uint32_t cc; + + if (bits =3D=3D 32) { + a32 =3D env->vregs[r1][0] >> 32; + b32 =3D env->vregs[r2][0] >> 32; + + float32_s390_divide_to_integer( + a32, b32, + final_quotient_rounding_mode, + mask_underflow, mask_inexact, + &r32, &n32, &cc, &dxc, &env->fpu_status); + } else { + a64 =3D env->vregs[r1][0]; + b64 =3D env->vregs[r2][0]; + + float64_s390_divide_to_integer( + a64, b64, + final_quotient_rounding_mode, + mask_underflow, mask_inexact, + &r64, &n64, &cc, &dxc, &env->fpu_status); + } + + /* Flush the results if needed */ + if ((env->fpu_status.float_exception_flags & float_flag_invalid) && + ((env->fpc >> 24) & S390_IEEE_MASK_INVALID)) { + /* The action for invalid operation is "Suppress" */ + } else { + /* The action for other exceptions is "Complete" */ + if (bits =3D=3D 32) { + env->vregs[r1][0] =3D deposit64(env->vregs[r1][0], 32, 32, r32= ); + env->vregs[r3][0] =3D deposit64(env->vregs[r3][0], 32, 32, n32= ); + } else { + env->vregs[r1][0] =3D r64; + env->vregs[r3][0] =3D n64; + } + env->cc_op =3D cc; + } + + /* Raise an exception if needed */ + if (dxc =3D=3D -1) { + handle_exceptions(env, false, GETPC()); + } else { + env->fpu_status.float_exception_flags =3D 0; + tcg_s390_data_exception(env, dxc, GETPC()); + } +} + /* 32-bit FP multiplication */ uint64_t HELPER(meeb)(CPUS390XState *env, uint64_t f1, uint64_t f2) { diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 203afe265bc..92344441878 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -2283,6 +2283,32 @@ static DisasJumpType op_dxb(DisasContext *s, DisasOp= s *o) return DISAS_NEXT; } =20 +static DisasJumpType op_dib(DisasContext *s, DisasOps *o) +{ + const bool fpe =3D s390_has_feat(S390_FEAT_FLOATING_POINT_EXT); + uint8_t m4 =3D get_field(s, m4); + + if (get_field(s, r1) =3D=3D get_field(s, r2) || + get_field(s, r1) =3D=3D get_field(s, r3) || + get_field(s, r2) =3D=3D get_field(s, r3)) { + gen_program_exception(s, PGM_SPECIFICATION); + return DISAS_NORETURN; + } + + if (m4 =3D=3D 2 || (!fpe && m4 =3D=3D 3) || m4 > 7) { + gen_program_exception(s, PGM_SPECIFICATION); + return DISAS_NORETURN; + } + + gen_helper_dib(tcg_env, tcg_constant_i32(get_field(s, r1)), + tcg_constant_i32(get_field(s, r2)), + tcg_constant_i32(get_field(s, r3)), tcg_constant_i32(m4= ), + tcg_constant_i32(s->insn->data)); + set_cc_static(s); + + return DISAS_NEXT; +} + static DisasJumpType op_ear(DisasContext *s, DisasOps *o) { int r2 =3D get_field(s, r2); --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886264; cv=none; d=zohomail.com; s=zohoarc; b=A7rPbpmUEVz2WqnTSf3hZQDV19po63ebDxodpmGaJe4PEN4kyRCfONhtfv4vB8oFIEBGH4iKEa9DfwEFVsIXawMh78tzH7f3kHgV+5UgTVkQQpee9FkyCdP6+qwzCZtq0CwA0LAa1EENNDPlhBpoM9zcQr1f3hBqZcFEK63Qit8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886264; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=05YRZfxmloEIze4Q/i2AZPegKQ1jzaXLUfbpxx2j8fk=; b=KEerIihkEn8pqWxfv2TUHuLs+oXPNDR79K9n5jGLSKf34QZqwt3tyouY9pwGJ4bcDGUUdESMN3VFZzcyLeINI7odxvpeCS0IbeRGc8Dji+rc8Iequ4e2qT9AYZtbzmNNiobF4lKrYR0GxJoBhmkX1cG/PFuB698zKeb8GZCDWdk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770886264314861.7829196939456; Thu, 12 Feb 2026 00:51:04 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSP4-00026P-3b; Thu, 12 Feb 2026 03:50:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOs-0001ly-2y for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOp-0001aO-12 for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:12 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-167-GteSJoXRM4yof3njGG8_2Q-1; Thu, 12 Feb 2026 03:50:08 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C159219560B7; Thu, 12 Feb 2026 08:50:07 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 18BFD30001B9; Thu, 12 Feb 2026 08:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=05YRZfxmloEIze4Q/i2AZPegKQ1jzaXLUfbpxx2j8fk=; b=ibOr1K8DzPbiIXE3vrkWf0SMg9a2J57nyX0ef2YWNmI6WwTs85XC7qBVpoMTO3YxREZM7u 8FdcRNZCv865aFQ2Ob1+QkoCaPwVKFEilDnAX536eyIIsBSerpQZ1zxIgor0+dDXXbV9tN HtGZEbitKA4vwgZeAIzCMv4o4+7z8YQ= X-MC-Unique: GteSJoXRM4yof3njGG8_2Q-1 X-Mimecast-MFC-AGG-ID: GteSJoXRM4yof3njGG8_2Q_1770886207 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Ilya Leoshkevich Subject: [PULL 11/14] tests/tcg/s390x: Test DIVIDE TO INTEGER Date: Thu, 12 Feb 2026 09:49:24 +0100 Message-ID: <20260212084927.258642-12-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886266095158500 From: Ilya Leoshkevich Add a test to prevent regressions. Data is generated using a libFuzzer-based fuzzer and hopefully covers all the important corner cases. Acked-by: Alex Benn=C3=A9e Signed-off-by: Ilya Leoshkevich Message-ID: <20260210214044.1174699-6-iii@linux.ibm.com> Signed-off-by: Thomas Huth --- tests/tcg/s390x/divide-to-integer.c | 265 ++++++++++++++++++++++++++++ tests/tcg/s390x/Makefile.target | 5 + 2 files changed, 270 insertions(+) create mode 100644 tests/tcg/s390x/divide-to-integer.c diff --git a/tests/tcg/s390x/divide-to-integer.c b/tests/tcg/s390x/divide-t= o-integer.c new file mode 100644 index 00000000000..62b4787ec0e --- /dev/null +++ b/tests/tcg/s390x/divide-to-integer.c @@ -0,0 +1,265 @@ +/* + * Test DIEBR and DIDBR instructions. + * + * Most inputs were discovered by fuzzing and exercise various corner case= s in + * the helpers. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ +#include +#include +#include +#include + +static void sigfpe_handler(int sig, siginfo_t *info, void *puc) +{ + struct ucontext *uc =3D puc; + unsigned short *xr_insn; + int r; + + xr_insn =3D (unsigned short *)(uc->uc_mcontext.regs.psw.addr - 6); + r =3D *xr_insn & 0xf; + uc->uc_mcontext.regs.gprs[r] =3D sig; +} + +#define DIVIDE_TO_INTEGER(name, floatN) = \ +static inline __attribute__((__always_inline__)) int = \ +name(floatN *r1, floatN r2, floatN *r3, int m4, int *sig) = \ +{ = \ + int cc; = \ + = \ + asm(/* Make the initial CC predictable for suppression tests */ = \ + "xr %[sig],%[sig]\n" = \ + #name " %[r1],%[r3],%[r2],%[m4]\n" = \ + "ipm %[cc]\n" = \ + "srl %[cc],28" = \ + /* = \ + * Use earlyclobbers to prevent the compiler from reusing floating= \ + * point registers. This instruction doesn't like it. = \ + */ = \ + : [r1] "+&f" (*r1), [r3] "+&f" (*r3), [sig] "=3Dr" (*sig), [cc] "= =3Dd" (cc)\ + : [r2] "f" (r2), [m4] "i" (m4) = \ + : "cc"); = \ + = \ + return cc; = \ +} + +DIVIDE_TO_INTEGER(diebr, float) +DIVIDE_TO_INTEGER(didbr, double) + +#define TEST_DIVIDE_TO_INTEGER(name, intN, int_fmt, floatN, float_fmt) = \ +static inline __attribute__((__always_inline__)) int = \ +test_ ## name(unsigned intN r1i, unsigned intN r2i, int m4, int fpc, = \ + unsigned intN r1o, unsigned intN r3o, int cco, unsigned int = fpco,\ + int sigo) = \ +{ = \ + union { = \ + floatN f; = \ + unsigned intN i; = \ + } r1, r2, r3; = \ + int cc, err =3D 0, sig; = \ + = \ + r1.i =3D r1i; = \ + r2.i =3D r2i; = \ + r3.i =3D 0x12345678; = \ + printf("[ RUN ] %" float_fmt "(0x%" int_fmt = \ + ") / %" float_fmt "(0x%" int_fmt ")\n", r1.f, r1.i, r2.f, r2.i)= ; \ + asm volatile("sfpc %[fpc]" : : [fpc] "r" (fpc)); = \ + cc =3D name(&r1.f, r2.f, &r3.f, m4, &sig); = \ + asm volatile("stfpc %[fpc]" : [fpc] "=3DQ" (fpc)); = \ + if (r1.i !=3D r1o) { = \ + printf("[ FAILED ] remainder 0x%" int_fmt = \ + " !=3D expected 0x%" int_fmt "\n", r1.i, r1o); = \ + err +=3D 1; = \ + } = \ + if (r3.i !=3D r3o) { = \ + printf("[ FAILED ] quotient 0x%" int_fmt = \ + " !=3D expected 0x%" int_fmt "\n", r3.i, r3o); = \ + err +=3D 1; = \ + } = \ + if (cc !=3D cco) { = \ + printf("[ FAILED ] cc %d !=3D expected %d\n", cc, cco); = \ + err +=3D 1; = \ + } = \ + if (fpc !=3D fpco) { = \ + printf("[ FAILED ] fpc 0x%x !=3D expected 0x%x\n", fpc, fpco); = \ + err +=3D 1; = \ + } = \ + if (sig !=3D sigo) { = \ + printf("[ FAILED ] signal 0x%x !=3D expected 0x%x\n", sig, sigo)= ; \ + err +=3D 1; = \ + } = \ + = \ + return err; = \ +} + +TEST_DIVIDE_TO_INTEGER(diebr, int, "x", float, "f") +TEST_DIVIDE_TO_INTEGER(didbr, long, "lx", double, "lf") + +int main(void) +{ + struct sigaction act =3D { + .sa_sigaction =3D sigfpe_handler, + .sa_flags =3D SA_SIGINFO, + }; + int err =3D 0; + + /* Set up SIG handler */ + if (sigaction(SIGFPE, &act, NULL)) { + printf("[ FAILED ] sigaction(SIGFPE) failed\n"); + return EXIT_FAILURE; + } + + /* 451 / 460 */ + err +=3D test_diebr(0x43e1f1f1, 0x43e61616, 7, 0, + 0x43e1f1f1, 0, 0, 0, 0); + + /* 480 / 0 */ + err +=3D test_diebr(0x43f00000, 0, 0, 0, + 0x7fc00000, 0x7fc00000, 1, 0x800000, 0); + + /* QNaN / QNaN */ + err +=3D test_diebr(0xffffffff, 0xffffffff, 0, 0, + 0xffffffff, 0xffffffff, 1, 0, 0); + + /* -2.08E-8 / -2.08E-8 */ + err +=3D test_diebr(0xb2b2b2b2, 0xb2b2b2b2, 0, 0, + 0x80000000, 0x3f800000, 0, 0, 0); + + /* + * Test partial remainder without quotient scaling (cc2). + * + * a =3D 12401981 / 268435456 + * b =3D -5723991 / 72057594037927936 + * q =3D a / b =3D -3329131425038336 / 5723991 =3D~ -581610178.1 + * n =3D round(q, float32, nearest_even) =3D -581610176 + * r_precise =3D a - b * n =3D 189155 / 1125899906842624 + * r =3D round(r_precise, float32, nearest_even) =3D r_precise + */ + err +=3D test_diebr(0x3d3d3d3d, 0xaeaeaeae, 0, 0, + 0x2f38b8c0, 0xce0aaaab, 2, 0, 0); + + /* 1.07E-31 / 2.19 */ + err +=3D test_diebr(0x0c0c0c0c, 0x400c0c0c, 6, 0, + 0xc00c0c0c, 0x3f800000, 0, 0x80000, 0); + + /* + * Test partial remainder with quotient scaling (cc3). + * + * a =3D 298343530578310714772108083200 + * b =3D -592137/10384593717069655257060992658440192 + * q =3D a / b + * =3D -103272545105730134013704301472178067414107728960487231565332= 4800 / + * 197379 + * =3D~ -5232195173029052432817285601415452880707052369324357280426.6 + * n =3D round(q, float32, nearest_even) + * =3D -5232194943010009439437691768433469154159343131709361094656 + * n / 2^192 =3D -6992213 / 8388608 + * r_precise =3D a - b * n =3D 13115851209189604982784 + * r =3D round(r_precise, float32, nearest_even) =3D r_precise + */ + err +=3D test_diebr(0x7070ffff, 0x90909090, 0, 0, + 0x6431c0c0, 0xbf5562aa, 3, 0, 0); + + /* + * Test large, but representable quotient. + * + * a =3D -12040119 / 549755813888 + * b =3D 1 / 38685626227668133590597632 + * q =3D a / b =3D -847248053779631702016 + * n =3D round(q, float32, to_odd) =3D q + * r_precise =3D a - b * n =3D -0 + * r =3D round(r_precise, float32, nearest_even) =3D -0 + */ + err +=3D test_diebr(0xb7b7b7b7, 0x15000000, 7, 0, + 0x80000000, 0xe237b7b7, 0, 0, 0); + + /* 0 / 0 */ + err +=3D test_diebr(0, 0, 1, 0, + 0x7fc00000, 0x7fc00000, 1, 0x800000, 0); + + /* 4.3E-33 / -2.08E-8 with SIGFPE */ + err +=3D test_diebr(0x09b2b2b2, 0xb2b2b2b2, 0, 0xfc000007, + 0xb2b2b2b1, 0xbf800000, 0, 0xfc000807, SIGFPE); + + /* + * Test tiny remainder scaling when FPC Underflow Mask is set. + * + * 1.19E-39 / -1.28E-9 =3D { r =3D 1.19E-39 * 2^192, n =3D -0 } + */ + err +=3D test_diebr(0x000d0100, 0xb0b0b0b0, 6, 0xfc000000, + 0x5ed01000, 0x80000000, 0, 0xfc001000, SIGFPE); + + /* + * Test "inexact and incremented" DXC. + * + * a =3D 53555504 + * b =3D -520849213389117849600 + * q =3D a / b =3D -3347219 / 32553075836819865600 + * n =3D round(q, float32, to_odd) =3D -1 + * r_precise =3D a - b * n =3D -520849213389064294096 + * r =3D round(r_precise, float32, to_odd) =3D -520849213389117849600 + * abs(r) - abs(r_precise) =3D 53555504 + */ + err +=3D test_diebr(0x4c4c4c4c, 0xe1e1e1e1, 0, 0xfc000007, + 0xe1e1e1e1, 0xbf800000, 0, 0xfc000c07, SIGFPE); + + /* 0 / 0 with SIGFPE */ + err +=3D test_diebr(0, 0, 0, 0xfc000007, + 0, 0x12345678, 0, 0xfc008007, SIGFPE); + + /* 5.76E-16 / 5.39E+34 */ + err +=3D test_diebr(0x26262626, 0x79262626, 6, 0, + 0xf9262626, 0x3f800000, 0, 0x80000, 0); + + /* -4.97E+17 / 2.03E-38 */ + err +=3D test_diebr(0xdcdcdcdc, 0x00dcdcdc, 7, 0xfc000000, + 0x80000000, 0xbb800000, 1, 0xfc000000, 0); + + /* -1.23E+17 / SNaN */ + err +=3D test_diebr(0xdbdb240b, 0xffac73ff, 4, 0, + 0xffec73ff, 0xffec73ff, 1, 0x800000, 0); + + /* 2.34E-38 / 3.27E-33 with SIGFPE */ + err +=3D test_diebr(0x00ff0987, 0x0987c6f6, 6, 0x08000000, + 0x8987c6b6, 0x3f800000, 0, 0x8000800, SIGFPE); + + /* -5.93E+11 / -2.7E+4 */ + err +=3D test_diebr(0xd30a0040, 0xc6d30a00, 0, 0xc4000000, + 0xc74a4400, 0x4ba766c6, 2, 0xc4000000, 0); + + /* 9.86E-32 / -inf */ + err +=3D test_diebr(0x0c000029, 0xff800000, 0, 0, + 0xc000029, 0x80000000, 0, 0, 0); + + /* QNaN / SNaN */ + err +=3D test_diebr(0xffff94ff, 0xff94ff24, 4, 7, + 0xffd4ff24, 0xffd4ff24, 1, 0x800007, 0); + + /* 2.8E-43 / -inf */ + err +=3D test_diebr(0x000000c8, 0xff800000, 0, 0x7c000007, + 0x000000c8, 0x80000000, 0, 0x7c000007, 0); + + /* -1.7E+38 / -inf */ + err +=3D test_diebr(0xff00003d, 0xff800000, 0, 0, + 0xff00003d, 0, 0, 0, 0); + + /* 1.94E-304 / 1.94E-304 */ + err +=3D test_didbr(0x00e100e100e100e1, 0x00e100e100e100e1, 0, 1, + 0, 0x3ff0000000000000, 0, 1, 0); + + /* 4.82E-299 / 5.29E-308 */ + err +=3D test_didbr(0x0200230200230200, 0x0023020023020023, 0, 0, + 0x8001a017d247b3f4, 0x41cb2aa05f000000, 0, 0, 0); + + /* -1.38E-75 / -3.77E+208 */ + err +=3D test_didbr(0xb063eb3d63b063eb, 0xeb3d63b063eb3d63, 3, 0xe8000= 000, + 0x6b3d63b063eb3d63, 0x3ff0000000000000, 0, 0xe8000c0= 0, + SIGFPE); + + /* 4.78E-299 / 6.88E-315 */ + err +=3D test_didbr(0x0200000000000000, 0x0000000053020000, 0, 0, + 0x8000000020820000, 0x4338ac20dd47c6c1, 0, 0, 0); + + return err ? EXIT_FAILURE : EXIT_SUCCESS; +} diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.tar= get index da5fe71a407..0ca030ded01 100644 --- a/tests/tcg/s390x/Makefile.target +++ b/tests/tcg/s390x/Makefile.target @@ -49,14 +49,19 @@ TESTS+=3Dcvd TESTS+=3Dcvb TESTS+=3Dts TESTS+=3Dex-smc +TESTS+=3Ddivide-to-integer =20 cdsg: CFLAGS+=3D-pthread cdsg: LDFLAGS+=3D-pthread =20 +# The following tests contain inline assembly that requires inlining, +# and thus cannot be built with -O0. rxsbg: CFLAGS+=3D-O2 +divide-to-integer: CFLAGS+=3D-O2 =20 cgebra: LDFLAGS+=3D-lm clgebr: LDFLAGS+=3D-lm +divide-to-integer: LDFLAGS+=3D-lm =20 include $(S390X_SRC)/pgm-specification.mak $(PGM_SPECIFICATION_TESTS): pgm-specification-user.o --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886291; cv=none; d=zohomail.com; s=zohoarc; b=mEcAi2B8uh8rwUYF05YA7IeSo/BVoC1GGftBdQhbvf5hd9OoRrM2aXODsMu+SoDUQU7OH43G0wBXWoOm2L5iuAoabrP2bO2ZZhta8vchbUxpIFCk+J+vJ8y2+FoK4JhmXxUv7j0OQS7d7AzmF93Qm20TJ6ep2lUngtkfsdt66Iw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886291; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=C2xyaYP2BDRcc+OR+FvMKUQM+xkDZa/U2/AKtbiHuF8=; b=ldSCaA7HjOIsMpjHt/0aQzVS2FSEZpQGFAWluHhMmvamyUtl+nGmcv1rtvc9pXfTVFXwUgDiNfiie1OFHHmk/HFwBvYpQVNp/5S5z3as7cN/N9WRJe1sfxRSwcPSx6PmuHo+1ePEXkX6Lxna/r9hxGLxqpZl3LtY360k/l1v1Uk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177088629177114.08260989696987; Thu, 12 Feb 2026 00:51:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSP8-0002Q1-7D; Thu, 12 Feb 2026 03:50:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOv-0001qb-Qx for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOt-0001az-Mn for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:17 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224-vfZd3GsqNJ6A9rrDZsHvVw-1; Thu, 12 Feb 2026 03:50:10 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F36591800473; Thu, 12 Feb 2026 08:50:09 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3861930001B9; Thu, 12 Feb 2026 08:50:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C2xyaYP2BDRcc+OR+FvMKUQM+xkDZa/U2/AKtbiHuF8=; b=KmMbUrmwNQaswz5lkmdMnLI7g7c4DiulXXrGgX5YrGWywx/b6m6z8sFp9afGN4tNjhnumd guCSUQIJeVhZ88NdXtsWTGkGhlfVJPm/XRBZLTkpMNILeHhUV+r4625WOtRmAmp+TsFd9k zjpXQKeoujKxuDDUpOTwaMhZGdgXN4U= X-MC-Unique: vfZd3GsqNJ6A9rrDZsHvVw-1 X-Mimecast-MFC-AGG-ID: vfZd3GsqNJ6A9rrDZsHvVw_1770886210 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 12/14] python/setup.py: Drop version checking via pkg_resources Date: Thu, 12 Feb 2026 09:49:25 +0100 Message-ID: <20260212084927.258642-13-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886293934158500 From: Thomas Huth pkg_resources has been dropped from setuptools v82.0 and newer, so our setup.py script is currently failing there, breaking our CI. To fix it, switch to a direct version check instead. While we're at it, also bump the minimum version of setuptools to v44 now since that is the minimum that might still be in use on the distros we care about according to: https://repology.org/project/python%3Asetuptools/versions Reviewed-by: Daniel P. Berrang=C3=A9 Message-ID: <20260211161154.740256-1-thuth@redhat.com> Signed-off-by: Thomas Huth --- python/setup.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/python/setup.py b/python/setup.py index c5bc45919a4..ae242ac95ac 100755 --- a/python/setup.py +++ b/python/setup.py @@ -7,7 +7,6 @@ import setuptools from setuptools.command import bdist_egg import sys -import pkg_resources =20 =20 class bdist_egg_guard(bdist_egg.bdist_egg): @@ -30,8 +29,8 @@ def main(): QEMU tooling installer """ =20 - # https://medium.com/@daveshawley/safely-using-setup-cfg-for-metadata-= 1babbe54c108 - pkg_resources.require('setuptools>=3D39.2') + if int(setuptools.__version__.split('.')[0]) < 44: + raise ModuleNotFoundError('version of setuptools is too old') =20 setuptools.setup(cmdclass=3D{'bdist_egg': bdist_egg_guard}) =20 --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886257; cv=none; d=zohomail.com; s=zohoarc; b=MJ+Hh6DF24DJInWaoHGyVmW+x09igU/SOql20zb4Xoppn1pht0UbaL5m1F+/K3VXWi9czJd696lSaynX+BBBRLwdAfjAgrIKGpIkte6pO/a3vistgFwdyv6ss9oIoY22U7JSGnlNwL2CJ4Ep6ovFQdsT+fNY32nPnhSx3BhgHjw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886257; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=id70y4pm34MdQLex05aMQJihyAnpSVIJL6a8OWLggQ8=; b=dslBl58Kr0UIsPJxo+boSdiQhX4vcIhinKSrUEGulQsInk7xMNFVkpAu+af33eMclDAdsE9evc/HZg9lt3eMqKs/NVjld1iPMOrPxm5AP3XEICfPxT2qTe6jNUE+X5ukwa+ulXN17Cf3Bq8x+QsxrTrdOZSrGDxO+f1jGOhaQZQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770886257004612.678478679742; Thu, 12 Feb 2026 00:50:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSP4-00029B-MN; Thu, 12 Feb 2026 03:50:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOy-000203-Hg for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOw-0001bE-K2 for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:20 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-Y3Rc4RKfOMONnGAHJBYznQ-1; Thu, 12 Feb 2026 03:50:14 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4EC43195605B; Thu, 12 Feb 2026 08:50:13 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F3FD130001BB; Thu, 12 Feb 2026 08:50:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=id70y4pm34MdQLex05aMQJihyAnpSVIJL6a8OWLggQ8=; b=U7QgdrYT7DaGgVyjjL1jVp3Hab9LjT1liqRwiqe3ha4SLh4K7mNLg2zIl7p6nvOYQhHsNo 2tqV16DCJ/cXVRfSNcOtdzOsP4Wd9Aw0rdeg8KL2XvUbphJbeUHubPrb14B/vp+vRYpGaw g7xSieDsiVxhfB95YpqvwhMsXDfbhXE= X-MC-Unique: Y3Rc4RKfOMONnGAHJBYznQ-1 X-Mimecast-MFC-AGG-ID: Y3Rc4RKfOMONnGAHJBYznQ_1770886213 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , ck Subject: [PULL 13/14] tests/Makefile.include: add run-tcg-tests-TARGET to check-help Date: Thu, 12 Feb 2026 09:49:26 +0100 Message-ID: <20260212084927.258642-14-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886258879154100 From: Choon Keong User can execute TCG tests for a specific TARGET using the command: $ make run-tcg-tests-TARGET-softmmu However, this command is not showing in 'make check-help' documentation, making it hard for new contributors to discover. This commit help to resolve this by adding the description for the command, to the "check-tcg" section, as suggested by Thomas, in tests/Makefile.include. Additionally, reformat the alignment to accommodate the length of the new command, ensuring the consistency of the output. Suggested-by: Thomas Huth Reported-by: Philippe Mathieu-Daud=C3=A9 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/228 Signed-off-by: ck Reviewed-by: Thomas Huth Message-ID: <20260206170059.4913-1-ckeong.teo17@gmail.com> Signed-off-by: Thomas Huth --- tests/Makefile.include | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 7728098981d..be3b78fdfb7 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -3,29 +3,30 @@ .PHONY: check-help check-help: @echo "Regression testing targets:" - @echo " $(MAKE) check Run block, qapi-schema, unit, so= ftfloat, qtest and decodetree tests" - @echo " $(MAKE) bench Run speed tests" + @echo " $(MAKE) check Run block, qapi-schema, uni= t, softfloat, qtest and decodetree tests" + @echo " $(MAKE) bench Run speed tests" @echo @echo "Individual test suites:" - @echo " $(MAKE) check-qtest-TARGET Run qtest tests for given target" - @echo " $(MAKE) check-qtest Run qtest tests" - @echo " $(MAKE) check-functional Run python-based functional test= s" - @echo " $(MAKE) check-functional-TARGET Run functional tests for a given= target" - @echo " $(MAKE) check-unit Run qobject tests" - @echo " $(MAKE) check-qapi-schema Run QAPI schema tests" - @echo " $(MAKE) check-tracetool Run tracetool generator tests" - @echo " $(MAKE) check-block Run block tests" + @echo " $(MAKE) check-qtest-TARGET Run qtest tests for given t= arget" + @echo " $(MAKE) check-qtest Run qtest tests" + @echo " $(MAKE) check-functional Run python-based functional= tests" + @echo " $(MAKE) check-functional-TARGET Run functional tests for a = given target" + @echo " $(MAKE) check-unit Run qobject tests" + @echo " $(MAKE) check-qapi-schema Run QAPI schema tests" + @echo " $(MAKE) check-tracetool Run tracetool generator tes= ts" + @echo " $(MAKE) check-block Run block tests" ifneq ($(filter $(all-check-targets), check-softfloat),) - @echo " $(MAKE) check-tcg Run TCG tests" - @echo " $(MAKE) check-softfloat Run FPU emulation tests" + @echo " $(MAKE) check-tcg Run TCG tests" + @echo " $(MAKE) check-softfloat Run FPU emulation tests" + @echo " $(MAKE) run-tcg-tests-TARGET-softmmu Run TCG tests for a given t= arget" endif @echo - @echo " $(MAKE) check-report.junit.xml Generates an aggregated XML test= report" - @echo " $(MAKE) check-venv Creates a Python venv for tests" - @echo " $(MAKE) check-clean Clean the tests and related data" + @echo " $(MAKE) check-report.junit.xml Generates an aggregated XML= test report" + @echo " $(MAKE) check-venv Creates a Python venv for t= ests" + @echo " $(MAKE) check-clean Clean the tests and related= data" @echo @echo "The following are useful for CI builds" - @echo " $(MAKE) check-build Build most test binaries" + @echo " $(MAKE) check-build Build most test binaries" @echo @echo @echo "The variable SPEED can be set to control the gtester speed setting= ." --=20 2.53.0 From nobody Sun Apr 12 04:21:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770886258; cv=none; d=zohomail.com; s=zohoarc; b=ZUd04Nl0/DGY2ZvekFI8W6YDjwLKqO3fKyWILtc1dEGCxjSukqDAT/4Hcbi8R3uMDOBhRFb44reMx57D+z/D4xJibZSyAiz7t0IpjvS/DQAwJUV8hKAX4BV68bcVIfMDGl/NH5rapOTVNcXKz8v9vM6Dtj9CRLbpffRJ7HNDziQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770886258; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PqdDXNaeqeryB4xkdT9NDKEckIvbzE9szTH2oYYLCcw=; b=mWVMPqiQUEWrBTzxmX7D9CYQjTAZCp36sMEm0WaUqae1r/f1xOH1FuD/a2beNPCIsFicn62yVevM3zZbXzVeXzTJzMvIjkht9mo5gMyXLIYjnSbV6oBwW2rOPWPqTm1R806YknDgXtQ+l4unSVDxFyiwUs8UtaqWwnFghsJ3WHw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770886258243700.07356126825; Thu, 12 Feb 2026 00:50:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqSP5-0002Dr-DU; Thu, 12 Feb 2026 03:50:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSP1-00020I-67 for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqSOz-0001bN-E3 for qemu-devel@nongnu.org; Thu, 12 Feb 2026 03:50:22 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-552-n_vBAfQSORedRp675Ek-mw-1; Thu, 12 Feb 2026 03:50:16 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D60011800464; Thu, 12 Feb 2026 08:50:15 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.225.23]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C62AB3000225; Thu, 12 Feb 2026 08:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770886220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PqdDXNaeqeryB4xkdT9NDKEckIvbzE9szTH2oYYLCcw=; b=M3K5Fe00VUNaZczYRvXuqv9x9C8gGcZY3nXRowvDr71LPLs0yjmYIxylm+PPh2GqmHWoHb mxB3grQuh152407iQL81Q6xgQ4UGLzUVML3lX5nt377G005KFpIs7flRFnsGifaCbLgMo8 eJ3vPDdjtkVIQfzMjqpP5WeWfnBlpSc= X-MC-Unique: n_vBAfQSORedRp675Ek-mw-1 X-Mimecast-MFC-AGG-ID: n_vBAfQSORedRp675Ek-mw_1770886216 From: Thomas Huth To: Peter Maydell Cc: qemu-devel@nongnu.org, Choon Keong Subject: [PULL 14/14] hw/i386/pc.c: add description for fd-bootchk option Date: Thu, 12 Feb 2026 09:49:27 +0100 Message-ID: <20260212084927.258642-15-thuth@redhat.com> In-Reply-To: <20260212084927.258642-1-thuth@redhat.com> References: <20260212084927.258642-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770886260785154100 Content-Type: text/plain; charset="utf-8" From: Choon Keong The 'fd-bootchk' option for pc and q35 machines currently lacks of description in the help output. This makes it difficult for users to understand the purpose of the command. This commit solve this issue by adding description using object_class_property_set_description() in hw/i386/pc.c, adding the the description message for the option 'fd-bootchk'. Suggested-by: Peter Maydell Suggested-by: Thomas Huth Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3193 Signed-off-by: Choon Keong Message-ID: <20260211162909.6550-1-ckeong.teo17@gmail.com> Signed-off-by: Thomas Huth --- hw/i386/pc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5cb074c0a08..46877197662 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1822,6 +1822,8 @@ static void pc_machine_class_init(ObjectClass *oc, co= nst void *data) object_class_property_add_bool(oc, "fd-bootchk", pc_machine_get_fd_bootchk, pc_machine_set_fd_bootchk); + object_class_property_set_description(oc, "fd-bootchk", + "Enable/disable boot signature checking for floppy disks in BIOS"); =20 #if defined(CONFIG_IGVM) object_class_property_add_link(oc, "igvm-cfg", --=20 2.53.0