From nobody Sun Apr 12 05:51:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1770826155; cv=none; d=zohomail.com; s=zohoarc; b=cTTJm197lJlzltH7mxhkYFQgeDJlpdA11BrB/t2GiGbSPdi3/gQi6Ca2FEDGGkajoZUDOXhCPE4RzIo7hN6gjfM0H2MxHBODbdvx9a9EXOsuJ2/G6jPjVKTpodh8adw5h9xrlMjmoM4wBzjPOjBc/7J87ITQcMByHhfddY8ySvk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770826155; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eh+qZ3pav78zuxhcFlBSXV75jt9gIA7420fX9KdU4PU=; b=XrPHdm5uIENyJmwxdwySLaOY+PG6XEZxsmp2qwBjHabCN8UMOht+mWMGCkA42cm7sHx3F27RNU4l2f6UicZ13xE8Qzt0AN4RnH5DAezje8xJPPqH75Oh9zZXre/9jx9+0wZtG7LGpHdieankcukYnUlJ9BdD0SCIL6ygL9d6paU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177082615545640.0455317326755; Wed, 11 Feb 2026 08:09:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqCl6-00031l-2q; Wed, 11 Feb 2026 11:08:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqCXr-0007EG-D5 for qemu-devel@nongnu.org; Wed, 11 Feb 2026 10:54:27 -0500 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqCXp-0003QP-SJ for qemu-devel@nongnu.org; Wed, 11 Feb 2026 10:54:27 -0500 Received: from DESKTOP-TUU1E5L.localdomain (unknown [167.220.208.59]) by linux.microsoft.com (Postfix) with ESMTPSA id 080DB20B716B; Wed, 11 Feb 2026 07:54:22 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 080DB20B716B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1770825264; bh=eh+qZ3pav78zuxhcFlBSXV75jt9gIA7420fX9KdU4PU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PMKlSlBGa5z5ezifnKD/QcvRzYq0Hghg32eF6bljI9NNzyHDwrQiw9JrrrG4xQW0E YrDNaO3UeQ6kDvyKuGAI4U/4AEUuNPkPkHz/Wki/2YqjJjoQBkvKpWFg+z+HAbibYc ASjf+azvPo5tnplfr4fepEyg+v2DZSxXLZ/aM4lo= From: Magnus Kulke To: qemu-devel@nongnu.org Cc: Magnus Kulke , Wei Liu , Wei Liu , Zhao Liu , Paolo Bonzini , Magnus Kulke Subject: [PATCH 04/10] target/i386/mshv: fix cpuid propagation bug Date: Wed, 11 Feb 2026 16:54:04 +0100 Message-Id: <20260211155410.203883-5-magnuskulke@linux.microsoft.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260211155410.203883-1-magnuskulke@linux.microsoft.com> References: <20260211155410.203883-1-magnuskulke@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=13.77.154.182; envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 11 Feb 2026 11:07:31 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.microsoft.com) X-ZM-MESSAGEID: 1770826157924154100 Content-Type: text/plain; charset="utf-8" The list argument was missing a pointer and hence e.g. -cpu qemu64 and -cpu EPYC would produce the same of cpuid leaves. Signed-off-by: Magnus Kulke Acked-by: Wei Liu (Microsoft) --- target/i386/mshv/mshv-cpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c index 586383b882..5c46cd67ec 100644 --- a/target/i386/mshv/mshv-cpu.c +++ b/target/i386/mshv/mshv-cpu.c @@ -441,7 +441,7 @@ int mshv_load_regs(CPUState *cpu) return 0; } =20 -static void add_cpuid_entry(GList *cpuid_entries, +static void add_cpuid_entry(GList **cpuid_entries, uint32_t function, uint32_t index, uint32_t eax, uint32_t ebx, uint32_t ecx, uint32_t edx) @@ -456,10 +456,10 @@ static void add_cpuid_entry(GList *cpuid_entries, entry->ecx =3D ecx; entry->edx =3D edx; =20 - cpuid_entries =3D g_list_append(cpuid_entries, entry); + *cpuid_entries =3D g_list_append(*cpuid_entries, entry); } =20 -static void collect_cpuid_entries(const CPUState *cpu, GList *cpuid_entrie= s) +static void collect_cpuid_entries(const CPUState *cpu, GList **cpuid_entri= es) { X86CPU *x86_cpu =3D X86_CPU(cpu); CPUX86State *env =3D &x86_cpu->env; @@ -615,7 +615,7 @@ static int set_cpuid2(const CPUState *cpu) struct hv_cpuid_entry *entry; GList *entries =3D NULL; =20 - collect_cpuid_entries(cpu, entries); + collect_cpuid_entries(cpu, &entries); n_entries =3D g_list_length(entries); =20 cpuid_size =3D sizeof(struct hv_cpuid) --=20 2.34.1