From nobody Wed Feb 11 09:01:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770754475; cv=none; d=zohomail.com; s=zohoarc; b=SDdK3SoApSDwxKlcf3GGKWTzGLorKZPHzlYHqm4q0k/ba13BPd5XASfMxsgmLaIn5k0ibET7wc15e+Vd4fKBNZxON90FWdFV7vT2A3whoxavniZSzfHPvwy3X634O9MWmJfxV54tm6f2FVS5xl07sQDCLLGo2s24B0VaDkd9UDE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770754475; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TUXohQh66NEYdqhO2tX9stkTnV8Hh6W32mBAqP3BQwU=; b=AKM6i3myK6N2INiNgeQX9UMkB4FduaM+YNCKk8iGQYawGBWm8/SWlxlUc7zLYQWoP2bnuRCCCljctWNJzeNqGKWVnBv6c6hb3W4D83hISF8kRuUmFsH+CEQMhAVTmkzNRYOcmyhEH05bnVya9r+F9XhZEIw2sHB3daDlB0m0O9M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770754475824536.1336887884801; Tue, 10 Feb 2026 12:14:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vpu7V-0005nh-Ha; Tue, 10 Feb 2026 15:14:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vpu7U-0005nM-3Y for qemu-devel@nongnu.org; Tue, 10 Feb 2026 15:14:00 -0500 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vpu7S-0007nR-Le for qemu-devel@nongnu.org; Tue, 10 Feb 2026 15:13:59 -0500 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-8230f8f27cfso2898444b3a.0 for ; Tue, 10 Feb 2026 12:13:58 -0800 (PST) Received: from pc.taild8403c.ts.net (216-71-219-44.dyn.novuscom.net. [216.71.219.44]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6dcb5e3e8csm13930031a12.21.2026.02.10.12.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 12:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770754437; x=1771359237; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TUXohQh66NEYdqhO2tX9stkTnV8Hh6W32mBAqP3BQwU=; b=tkNjyPCHZDGW+ayP+lnwgOUBAymzOTfluBwMtQvZ4hF/DNFrkt4K0ZYzFQmlLGrRG/ KmKIRWilu24AeSHjEI+7JQBvkUI+RuyqH9kcO5Dbqc3FjkChOEMYl4lUBa5MnWAorRwZ +ikqUb7XHxJM1+H1p1CBVhdfhq1ZjVeCwn70k5u+nTH51n12LSWFh9tx2OvmF8PXj9+L Rlua9UvalF6iT4znge+PLeTIeVU+gueSJtOaXIokwQuvGtdVaRVCbnDBwd3uooluwQvh NLelRXkQE/Q4Ke2UyXQOLE3jQPH0N2zZj0RBeFFrQfpLBJ0xY3+cx69qQxblo6rEKWsW OhkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770754437; x=1771359237; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TUXohQh66NEYdqhO2tX9stkTnV8Hh6W32mBAqP3BQwU=; b=FlnmhCETwUV6BI41siGQwQp0nEQY6dBr9a6v7zNtZbDmq1IliLMhjdQOQ8qnS09q3A Kp5wrO6OzB6BrXO3+rT+vku4gEws9Yw1cxeCrsEfiD4ofPQJMaQqCmYQ26T6djMzi/tm zFRMLp4l8A1Drd6H7AjQLnMj7xO5p4D1tNLPfKFqebX+04klbaqdIEAYl3zeetLfJElH Tg3VIkUpC/Yye5Oy+K1suwRrOLh/hfTODCKMnJL7dk9X0w4PZO/SaGl8Nszse4OB6lRA v2PDxCiGhM62Mowz6Xz56c0ydjmYF2X07iDzfOuj3a1JJLV5DwSuAtqcfXXFbK9LP5k+ HDLg== X-Gm-Message-State: AOJu0YxS9vlJ6nhHbCDz2H6/AgHE+ZTuzLyf/uO0uUseUDXFgx7onZJ/ 46BHHMmIx6EO7RgEwarRpC/zX5fOntj7vXJSBAlUxfhdE/pNgFW4bj0klnYTYDJOU+aQVukrR+b QtQsB X-Gm-Gg: AZuq6aLeteOEgs7RWgNhGEBJY8nOHqJFz5w0jKaQo7f9ggWa8beW3CMomY/WtsRqZbY LgiVEuT9LZ/OdTE1IxkYQLgFqwNwwYw2/pJJR+8Rd4kwy356lENpqp6riSIuyOceeYto2vR3sPV hWy7xPn28EAkGoofqh0LX0u1HYTA1KLSYUhAoxqhw+yA1t2MdpFYkSaEmg43D0tzrc0s85B3+I/ 2Y8Ty6jwAuhoDY1LQNMrT6fXXpWkdJDhOhIJmzPW4b1A86IJWL2HB9c2gtXhlLGHsIYD2/oHKum rhK/9a+6Pk5pllaI6r/qvnWFrfNobvs0wgcKXX2cXSqGMum1Ris56FwIMk+jriOjA5IktAmrCuJ okbQrHt+CYL4/g5GWdc2MOCfXvY76DOrn579FyXZ19mfavd/kufUjdIK45g8MILv1q19Q23nLHT AZCNrky8DcVEt7jZ7T0sNMX/Dkwos3ZxIANNefgET2GqBFhDAbPPuP+pldwAZ0H94YKhkmMqmcA u9M X-Received: by 2002:a05:6a21:8202:b0:304:313a:4bcd with SMTP id adf61e73a8af0-39417c1fae3mr3025900637.30.1770754436624; Tue, 10 Feb 2026 12:13:56 -0800 (PST) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Alexandre Iooss , Pierrick Bouvier , alistair.francis@wdc.com, Mahmoud Mandour , manos.pitsidianakis@linaro.org, philmd@linaro.org, anjo@rev.ng, brian.cain@oss.qualcomm.com Subject: [PATCH 1/4] contrib/plugins/uftrace: fix infinite stack unwind detection Date: Tue, 10 Feb 2026 12:13:41 -0800 Message-ID: <20260210201344.1403613-2-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260210201344.1403613-1-pierrick.bouvier@linaro.org> References: <20260210201344.1403613-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770754477346158500 Content-Type: text/plain; charset="utf-8" So far, we were detecting infinite stacks but not stopping unwinding since break only exited inner loop. Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- contrib/plugins/uftrace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/plugins/uftrace.c b/contrib/plugins/uftrace.c index a7e21b5b87a..1ed982999ed 100644 --- a/contrib/plugins/uftrace.c +++ b/contrib/plugins/uftrace.c @@ -443,7 +443,7 @@ static void cpu_unwind_stack(Cpu *cpu, uint64_t frame_p= ointer, uint64_t pc) /* check we don't have an infinite stack */ for (size_t i =3D 0; i < depth; ++i) { if (frame_pointer =3D=3D unwind[i].frame_pointer) { - break; + goto after_unwind; } } CallstackEntry e =3D {.frame_pointer =3D frame_pointer, .pc =3D pc= }; @@ -456,6 +456,7 @@ static void cpu_unwind_stack(Cpu *cpu, uint64_t frame_p= ointer, uint64_t pc) } while (frame_pointer && pc && depth < UNWIND_STACK_MAX_DEPTH); #undef UNWIND_STACK_MAX_DEPTH =20 +after_unwind: /* push it from bottom to top */ while (depth) { callstack_push(cpu->cs, unwind[depth - 1]); --=20 2.47.3