From nobody Wed Feb 11 03:24:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1770730510; cv=none; d=zohomail.com; s=zohoarc; b=BnrbpIXA4gmZHHVpSWIFe0Ie+ZvgCfSEg0WD2dDtFbE5bw166FwJTguTgfKKaH4oyNL5zVVqSYDGpjEpfosUB2GsGXWWd6G2OkFjPYsVqzAakmE8lLrFQDu9aQ2EFTXjXu8peiZFm7AjSmXphzisbqWkNBRz6W7E2jc6dA6cIdo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770730510; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GexMtmgfGvMqUlr405tGcNusaInSecWFUKDx3/DCuI8=; b=L8P6Tkp9FhWoljJgmFQUj1N0OI5HFGPz5LYz4A0JYVIt6fMS1lLZ9d3uGLX6IU1bHkl2K9qKuUlSvXtssEFiPYHgW7myjxByTJtimL28H5EFir6v5RQzpUN0C1JQ8LuLAsLFxJvpMJFCOORrXjERI0END6yVVKbz7RacOZFP3Do= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770730510792931.7281466043913; Tue, 10 Feb 2026 05:35:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vpnsr-0005f5-JY; Tue, 10 Feb 2026 08:34:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vpnsn-0005e1-0l for qemu-devel@nongnu.org; Tue, 10 Feb 2026 08:34:25 -0500 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vpnsj-0001nd-Nc for qemu-devel@nongnu.org; Tue, 10 Feb 2026 08:34:24 -0500 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61A6jRRr442377 for ; Tue, 10 Feb 2026 13:34:19 GMT Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c7qp9jqv0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Feb 2026 13:34:18 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2ba745f54c6so5132967eec.0 for ; Tue, 10 Feb 2026 05:34:18 -0800 (PST) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ba7e149c58sm2716162eec.26.2026.02.10.05.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 05:34:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GexMtmgfGvMqUlr405tGcNusaInSecWFUKDx3/DCuI8=; b=mkJtRSBSlB+8+7pZ hmeJZk6inWTkDtR1a+SuX5VzyR9NNZmjjC2gZ+KcH1svuvSe5BFli4q15TfMvbFZ awCAutNA9/bArvVMDaD6GYQw+3k1GGJLtqfj8pVpHA7jVDbWlaXhBC//bdIhPID3 n183vx5wdVkQhXSX1b55GMpTec9vSmu21STpsuSCXw+uwBQ3ScNPxLqznSfAp6vw KPH5+DrgkYdQkGOZ/ExD8ebcAyyAam0jFbqMC6jB1E6K5h4mzcGM+IEwHJsaUSwE mX3LNXt3mVdt3eXDogJOFlIx/Q3lA1WK1wwwz2HIj3VZdbZztbpg+tn7jn3GYXfh R/iiqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770730458; x=1771335258; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GexMtmgfGvMqUlr405tGcNusaInSecWFUKDx3/DCuI8=; b=EMhKYVjY0rFijeJi6jW1sSGE+t5ehvgtUo8lXe2Q9mq4NFigBiXKOKGJ/eaKvqlIIp vsN0pZ5IC1rgw/9rXSxcs4KsTN6uluzx1D8Y7s8x2UpLXgt1+0+Wx+dWsqw15vrcchW1 F/2DxxG40NA4J6bZ9NGMN8aY2zmnprSvLHggk+0gvmxbZgWa8h5SWs23f2X5fXX3jtp2 SSG83bZMkA/tthxxbhUvUTOB1Ioz5yHmf9gV9ycpyGPsnn6fUxRFcH8/B/UoLP6IK3sA 1l1LNM+dppaip/whiiHL6zpNcUsR8tIsxFnSD32MpTqPLYM/9iYAGJxryW5sl2kI/fRa bBTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770730458; x=1771335258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GexMtmgfGvMqUlr405tGcNusaInSecWFUKDx3/DCuI8=; b=P2AwZQZ0PjVZXxLw0FxxVLmRhVuyGtthxZoWtJsLnPKjckkacMvKBOiFpTN6Uc75lH 2zOCkTJGRkOJK/7k2SXob3XnOxCYYLJppfO/GIs8hzmpbwIBQuvygSTJp3FOQ9BxwsMN sHYr85psXerU1UckqizaGuF2UwMogZ4/Fv2+h3rbDnmiKqRZEipHxkE3WS+jrOHzZPpc q9Is7UeXHVJfwu8aLMbIAukTKUOdxgFVnbQrbU9PJGvYF6OV0Gt8jJyeSq1omMdw/Vvf WzkhD+2QCa4ESN9iQJ+eMQ9au8o3HUfImGSTH5vG6gwQmMvl6SK6rR74hLtf4Anvtsg1 zvqg== X-Gm-Message-State: AOJu0YxThM7yJ2DdgyhIuaZGaZ+OiF5cQf99s3mXTJGYYcCb3r1cswMH hPV7siSCFZ3PCrmms6fYmCUwoLAK8bIuKzNQkaAyTi5uhM5MLKfTj0mezDOaxk0mrwS6GMyhbUR QXXzV3xBenMMX0wbGJ8skh8Ck3lWynGqFEkUaRamDc0nuqD7BC+mS9XXRdAHNqlz8Zg== X-Gm-Gg: AZuq6aJSO1hUOGMRmqy1cuZurHSTVZtnCEbnynXGPLZN5wbwbQnkledEhAhbyabZwgi kTNhFkdix0T10OPF63+0XXbBUBxK5xh15pUDzsb5pUk4hDq0GE4+Dt3V8Zs4Fm9jEi5s8I4yLii 0DAw07pUpigpTRwuuB4MAWcNtZbmE5n2RQVZjpsVnkWfYcbjNm9kpeBbBbSrFG9om+ZfJ+aGv8I Yu/M6fRJ7jCmj1bWsRHK8zNBfXZpYnMrHBcC4hJ/JMo9lAHPuAOewJk+TPjx8/2rkZGltsgUwCz FqDZNiNBXqA004phQrT1knmq4nk32JOCP+sor1UIxteCQkf4Fhlm1j0HvUDTrIX1EKD3gt2fmb0 CRRldMC7ZKoeOl+HH40+ahrS4DxRtG/W+2DtKoBR/51166nNoKUt4wDpE4lqiYprkUagBjQ== X-Received: by 2002:a05:693c:37c7:b0:2b6:c617:f795 with SMTP id 5a478bee46e88-2b856486ab7mr6821721eec.17.1770730457955; Tue, 10 Feb 2026 05:34:17 -0800 (PST) X-Received: by 2002:a05:693c:37c7:b0:2b6:c617:f795 with SMTP id 5a478bee46e88-2b856486ab7mr6821704eec.17.1770730457442; Tue, 10 Feb 2026 05:34:17 -0800 (PST) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex@alexrp.com, Pierrick Bouvier Subject: [PATCH v3 2/4] target/hexagon: Return decode failure for invalid non-duplex encodings Date: Tue, 10 Feb 2026 05:33:52 -0800 Message-Id: <20260210133355.16093-3-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260210133355.16093-1-brian.cain@oss.qualcomm.com> References: <20260210133355.16093-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 9qw5PkAqcubCNGmDbsp3NtbiKwyMBv0s X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEwMDExNCBTYWx0ZWRfX/mTXFx9oHJFX rJTthrIPLtfJWU74yjx5rVKVlpVw1xg39DVAHQB8pWwpNnRWiR++IlQQ1XgLhNslMTDxRbW5lzG bC867KIO5jNl0VOWPriDy6RoVi5aMXuOTFeAO2/9jZPBPIgQcJ1Lo6CSgjVUMzbve5XovHDU1qz eBdbKYy1ikUxUwF+OcV0Nyj0UDJwKpZ4paLoBK16HGNb0/9C/523y4JiOu72ioCXoxH+M6nwK1R llJGNm8f63MW3fAW6RKQoGoBNMe/+bM/qRV24QFFnyfDlkiG6aJT1nHmTC9b9QuiBdH10Gf12v6 wg2Q7EvFUV245EHEvo9e6mFdwe6NPeXK9Ucja1LSVEy6RKdqvsWoL2Mj9LuBxEJfE15sLB+XKkN 4c8Z3DUQJPUJ79phWfz2XiYr5Og4b693BZmSXYRdlwx6tcMnSrD1eQSr33j3lQzugiwSF4H2cGq Ft/LE1TeOAnphxRQypQ== X-Authority-Analysis: v=2.4 cv=dP2rWeZb c=1 sm=1 tr=0 ts=698b33da cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=D67r-eMCZ0zeLs--bqkA:9 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 9qw5PkAqcubCNGmDbsp3NtbiKwyMBv0s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-10_01,2026-02-10_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100114 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1770730513526154100 When a non-duplex encoding (parse_bits !=3D 0) fails both decode_normal() and decode_hvx(), the decoder hit an unreachable. Instead, handle the decode failure and raise an exception. Reviewed-by: Pierrick Bouvier Reviewed-by: Taylor Simpson Signed-off-by: Brian Cain --- target/hexagon/decode.c | 3 ++- tests/tcg/hexagon/invalid-encoding.c | 25 +++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c index 69ba1ec96c..33ad60c5b4 100644 --- a/target/hexagon/decode.c +++ b/target/hexagon/decode.c @@ -489,7 +489,8 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t en= coding) insn->iclass =3D iclass_bits(encoding); return 1; } - g_assert_not_reached(); + /* Invalid non-duplex encoding */ + return 0; } else { uint32_t iclass =3D get_duplex_iclass(encoding); unsigned int slot0_subinsn =3D get_slot0_subinsn(encoding); diff --git a/tests/tcg/hexagon/invalid-encoding.c b/tests/tcg/hexagon/inval= id-encoding.c index 010a5eb741..639d7f2495 100644 --- a/tests/tcg/hexagon/invalid-encoding.c +++ b/tests/tcg/hexagon/invalid-encoding.c @@ -65,6 +65,30 @@ static int test_invalid_duplex(void) return sig; } =20 +/* + * Invalid non-duplex encoding: + * The encoding 0xffffc000 has parse bits [15:14] =3D 0b11, making it a + * non-duplex instruction and packet end. The remaining bits do not match + * any valid normal or HVX instruction encoding, so this should raise SIGI= LL. + */ +static int test_invalid_nonduplex(void) +{ + int sig; + + asm volatile( + "r0 =3D #0\n" + "r1 =3D ##1f\n" + "memw(%1) =3D r1\n" + ".word 0xffffc000\n" + "1:\n" + "%0 =3D r0\n" + : "=3Dr"(sig) + : "r"(&resume_pc) + : "r0", "r1", "memory"); + + return sig; +} + int main() { struct sigaction act; @@ -75,6 +99,7 @@ int main() assert(sigaction(SIGILL, &act, NULL) =3D=3D 0); =20 assert(test_invalid_duplex() =3D=3D SIGILL); + assert(test_invalid_nonduplex() =3D=3D SIGILL); =20 puts("PASS"); return EXIT_SUCCESS; --=20 2.34.1