From nobody Tue Feb 10 22:17:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1770707018; cv=none; d=zohomail.com; s=zohoarc; b=OEH4yWicvDPxsoO/RJd7ja9+HDbggro/b406Qa4o1KtWBnrDth1p5Hxigfa3CMRsYeP7m+3058uQZkfMhflyNMVVmI8TfuyFoPmU4R5rWW8Zrx4SrFqji8s4CSgdfIQh1dEY1h8W+SWpuMXvfcO0IzyCP3sshsHzKfYhUsknUjg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770707018; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OQU4mJNfPlU0RTrZoliwWhNONrJ2KKAnWEuIN9nfMQs=; b=RTjUhcdcbsaaPOgy0d+o7hAWqV6u0SToymvSIk/Hc5+sfAA0jD13Ho+jWHxASs1xvjWbBjUr2EknIUGK6W0Q/JIJ8EKmoYveJciMlAOCyi/xeipFZiFglIYkqqjpPMUxIcznbPqjlKFdlQuwcutHn/cdtPNa9gHPZt4l1Aghuu0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770707018398858.6311960066197; Mon, 9 Feb 2026 23:03:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vphlT-0004zR-Dh; Tue, 10 Feb 2026 02:02:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vphlR-0004yc-Oh for qemu-devel@nongnu.org; Tue, 10 Feb 2026 02:02:25 -0500 Received: from mgamail.intel.com ([198.175.65.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vphlO-0004oY-NA for qemu-devel@nongnu.org; Tue, 10 Feb 2026 02:02:24 -0500 Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2026 23:02:14 -0800 Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2026 23:02:14 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770706942; x=1802242942; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=oQRCKzfMfTFAgGPsOzk5OTOODedydtNxeQxzJaxB35U=; b=nvLbluS6R5bTpvt9+bRCL2cpzAVpV0yI/R5OlVDPxHRIdtNyUIBThwrD xpw4SbNqe9HehTq48Rc3bjPaPMp1GnYiW7DBN13Ln4kgrWpwX/bBNUlDZ WkaD0N9+cScKmYkbHcLHltIX2dQIXrhZsI9eZWMUayMLnemfgvT6/k6qv AsHAdDnUDNjJFO+/bjdRkpI5Fm/9MS/GcRliztYXxGirCE7XWnSA+5dtm FULnaOH4mKScMRSxQMguWeXnuGHjKFQx5XCvFlFYuwrTh+UkfV9DDUgNC aIdMfJ9FX/gLocsp1TuGGYHi+ZiC05CPGfwqATMu6yN5RJpDlOVpNc4w5 A==; X-CSE-ConnectionGUID: t3JFEOLLTn2eDgrA4LRtTg== X-CSE-MsgGUID: f7hVfzNrS/KMrefojQYUxA== X-IronPort-AV: E=McAfee;i="6800,10657,11696"; a="72012169" X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="72012169" X-CSE-ConnectionGUID: RKusPD1zTyiacbGCT8WMag== X-CSE-MsgGUID: +Zb4Q3djSeu3tZd//bg5tw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="210920547" From: Vivek Kasireddy To: qemu-devel@nongnu.org Cc: Vivek Kasireddy , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Alex Williamson , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH v6 06/11] virtio-gpu-dmabuf: Improve error handling by introducing 'Error **' Date: Mon, 9 Feb 2026 22:59:46 -0800 Message-ID: <20260210070155.1176081-7-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260210070155.1176081-1-vivek.kasireddy@intel.com> References: <20260210070155.1176081-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.16; envelope-from=vivek.kasireddy@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1770707019996154100 Make the error handling more robust in virtio_gpu_init_udmabuf() by passing in 'Error **' parameter to capture errors from virtio_gpu_create_udmabuf() and virtio_gpu_remap_dmabuf(). And, since they now take in 'Error **' parameter, have them return a bool to adhere to best practices. Cc: Marc-Andr=C3=A9 Lureau Cc: Alex Benn=C3=A9e Cc: Akihiko Odaki Cc: Dmitry Osipenko Cc: Alex Williamson Cc: C=C3=A9dric Le Goater Signed-off-by: Vivek Kasireddy --- hw/display/virtio-gpu-dmabuf.c | 45 ++++++++++++++++++++++------------ 1 file changed, 30 insertions(+), 15 deletions(-) diff --git a/hw/display/virtio-gpu-dmabuf.c b/hw/display/virtio-gpu-dmabuf.c index 8d67ef7c2a..d9b2ecaf31 100644 --- a/hw/display/virtio-gpu-dmabuf.c +++ b/hw/display/virtio-gpu-dmabuf.c @@ -27,7 +27,8 @@ #include "standard-headers/linux/udmabuf.h" #include "standard-headers/drm/drm_fourcc.h" =20 -static void virtio_gpu_create_udmabuf(struct virtio_gpu_simple_resource *r= es) +static bool virtio_gpu_create_udmabuf(struct virtio_gpu_simple_resource *r= es, + Error **errp) { g_autofree struct udmabuf_create_list *list =3D NULL; RAMBlock *rb; @@ -36,7 +37,8 @@ static void virtio_gpu_create_udmabuf(struct virtio_gpu_s= imple_resource *res) =20 udmabuf =3D udmabuf_fd(); if (udmabuf < 0) { - return; + error_setg(errp, "udmabuf device not available"); + return false; } =20 list =3D g_malloc0(sizeof(struct udmabuf_create_list) + @@ -45,7 +47,10 @@ static void virtio_gpu_create_udmabuf(struct virtio_gpu_= simple_resource *res) for (i =3D 0; i < res->iov_cnt; i++) { rb =3D qemu_ram_block_from_host(res->iov[i].iov_base, false, &offs= et); if (!rb || rb->fd < 0) { - return; + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Could not find valid ramblock\n", + __func__); + return false; } =20 list->list[i].memfd =3D rb->fd; @@ -58,20 +63,26 @@ static void virtio_gpu_create_udmabuf(struct virtio_gpu= _simple_resource *res) =20 res->dmabuf_fd =3D ioctl(udmabuf, UDMABUF_CREATE_LIST, list); if (res->dmabuf_fd < 0) { - warn_report("%s: UDMABUF_CREATE_LIST: %s", __func__, - strerror(errno)); + error_setg_errno(errp, -res->dmabuf_fd, + "Could not create dmabuf fd via udmabuf driver"); + return false; } + return true; } =20 -static void virtio_gpu_remap_dmabuf(struct virtio_gpu_simple_resource *res) +static bool virtio_gpu_remap_dmabuf(struct virtio_gpu_simple_resource *res, + Error **errp) { - res->remapped =3D mmap(NULL, res->blob_size, PROT_READ, - MAP_SHARED, res->dmabuf_fd, 0); - if (res->remapped =3D=3D MAP_FAILED) { - warn_report("%s: dmabuf mmap failed: %s", __func__, - strerror(errno)); + void *map; + + map =3D mmap(NULL, res->blob_size, PROT_READ, MAP_SHARED, res->dmabuf_= fd, 0); + if (map =3D=3D MAP_FAILED) { + error_setg_errno(errp, errno, "dmabuf mmap failed"); res->remapped =3D NULL; + return false; } + res->remapped =3D map; + return true; } =20 static void virtio_gpu_destroy_dmabuf(struct virtio_gpu_simple_resource *r= es) @@ -125,6 +136,7 @@ bool virtio_gpu_have_udmabuf(void) =20 void virtio_gpu_init_dmabuf(struct virtio_gpu_simple_resource *res) { + Error *local_err =3D NULL; void *pdata =3D NULL; =20 res->dmabuf_fd =3D -1; @@ -132,12 +144,15 @@ void virtio_gpu_init_dmabuf(struct virtio_gpu_simple_= resource *res) res->iov[0].iov_len < 4096) { pdata =3D res->iov[0].iov_base; } else { - virtio_gpu_create_udmabuf(res); - if (res->dmabuf_fd < 0) { + if (!virtio_gpu_create_udmabuf(res, &local_err)) { + if (local_err) { + error_report_err(local_err); + } return; } - virtio_gpu_remap_dmabuf(res); - if (!res->remapped) { + + if (!virtio_gpu_remap_dmabuf(res, &local_err)) { + error_report_err(local_err); return; } pdata =3D res->remapped; --=20 2.50.1