From nobody Tue Feb 10 16:22:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1770712805; cv=none; d=zohomail.com; s=zohoarc; b=fo2F3fJr0xU2PhEVTAl7yd1DaAiUjaTSV39hV5iRzuFZNmhCH0rj3a2RvJnCCwZuKDaIDZk8WJkrLTTazoeJ7MXCNlEQlh0nIpry/NxBwpstndFP02KrAln33R++pe3Bc5rRqJXhAmJYZGLfYcalGtk7GyHoposQ419P58iUAog= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770712805; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=R/UV6HMEDUMIb9Q8VJA7rKMQ/NPZzRnfxT72mO0kBwI=; b=LBrfyuG4/01UEnoGntyVSgd7Xfb+iP4HsT2NgA+xgRRkOLXRr0AE1rN2YV5CtlEMt+St9GGd4vh9iLumB12/eBo6Ua3Lmnmo7IC2PzohwYBFnuMh8uuWfjHYe8K9ks8r0DbqY+pamhcwZc8u9gkObLFY22rwFO+v91f+tNL/d0Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770712805385992.6825277737104; Tue, 10 Feb 2026 00:40:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vpjHL-0001Wp-S7; Tue, 10 Feb 2026 03:39:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vphcT-0002n9-As; Tue, 10 Feb 2026 01:53:09 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vphcR-0003s6-L1; Tue, 10 Feb 2026 01:53:09 -0500 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 619G4jjD369791; Tue, 10 Feb 2026 06:53:04 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4c696ws0cj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Feb 2026 06:53:04 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 61A6FXdp001815; Tue, 10 Feb 2026 06:53:03 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4c6je1yxgc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Feb 2026 06:53:03 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 61A6qxAa24773060 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Feb 2026 06:52:59 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6F90420043; Tue, 10 Feb 2026 06:52:59 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B48C320040; Tue, 10 Feb 2026 06:52:58 +0000 (GMT) Received: from B02-B02RHL5-RH94-0370-9-114-17-225.pok.stglabs.ibm.com (unknown [9.114.17.225]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 10 Feb 2026 06:52:58 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=R/UV6HMEDUMIb9Q8VJA7rKMQ/NPZzRnfxT72mO0kB wI=; b=IPM3YP8qHKUHuSZrA14Zva7XpKWd3qXKUZZp8a9Sg54L2hp3wjLq9sior Fbm3GIb7tzVwmuqO//SPKPpSASuEd632MYQw8KxH5wV5OkHF5F8AgafPBiUcDNaN 1ExR973HABmoSPXScdSVNfvctZF9aOW6KssjjYAwwB/a/LvItMTeZkCVe3xCqpAB 1rnmFUcuZShooWinmbEtCsUGJOnlcN1pHxugyJrIfcheH7DD7lq67RRlIYvzaLSO VWEb3kNPlc4gdI8NXhXuC4MsCscGVeC+JpgqdkpVJa97A4s/ky6rC3kb0vyX95r4 T2KLrYUfjZsmI+VwnyLhAqZ8pX8Yg== From: Aby Sam Ross To: qemu-s390x@nongnu.org Cc: qemu-devel@nongnu.org, mjrosato@linux.ibm.com, farman@linux.ibm.com, Aby Sam Ross Subject: [PATCH] prevent null pointer dereference during zpci hot unplug Date: Tue, 10 Feb 2026 01:52:14 -0500 Message-ID: <20260210065214.2252464-1-abysamross@ibm.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=WZYBqkhX c=1 sm=1 tr=0 ts=698ad5d0 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VnNF1IyMAAAA:8 a=_df3JAyxEGjRhYUhYmcA:9 X-Proofpoint-GUID: iPFhh6fadNUuXTSWJiEXjvI4qRjRADN6 X-Proofpoint-ORIG-GUID: iPFhh6fadNUuXTSWJiEXjvI4qRjRADN6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEwMDA1NSBTYWx0ZWRfXwTBUNrMA7p27 9rAVEKOIPSUZELe1gtpjoSrlVHLCJ6stBxIBCZt3M/YxXQSY79Kxa36ZSczyvfJr4Ro6u09AnD4 /WFwhIG562mKlwRacSpQPjLD7Dg8Fkton2qlThkTbG1TLVu6rckhyF/7tVsY/e7NWMMTwv/RmBC qpSIG35vVY9T3/LtrCDZhUUEaXNT4eibJ3VKEM7CoOdezwxTr9KGZ/4qE/da4AAQm06oLIgk41x Iv1IY0ZsV8UTVcpEAN/GRVfK9R0hmWogeYtPHCHWT/IsKXVcgxwR7yGOWJKXO04vb9EoDC0YyxK a9JPQKZETg6kEJRWRoZDTmTeBYzfD29KftMpVTQKGOtisLtq8NOnxo00FLRlPfLogudXAS47tpx WoZIxwI3K+moYvsc7xmPTxT1zglyn1AXvYiZpMZAdykYU8tnHetSSNCzFJpVhzwY5iKNhnMkq4Y SLYGBwHnd83riCKU3cg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-09_01,2026-02-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1011 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100055 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=abysamross@ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 10 Feb 2026 03:39:27 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1770712822384158500 Content-Type: text/plain; charset="utf-8" vfio-pci hostdev realize during zpci hot plug fails (in `vfio_pci_realize()= `) if the vfio group file in `/dev/vfio/` lacks appropriate permissions and the hostdev[/properties] addition doesn't reach the point where it could be associated with previously added zpci device (in `s390_pcihost_plug()`). As a result, zpci iommu pointer remains null. The zpci hot unplug following= the failed hostdev addition assumes zpci iommu pointer was assigned and tries to make use of it to end the dma count resulting in a null pointer dereference. In the non-hotplug scenario, `qdev_unplug()` for the zpci device is not cal= led after hostdev addition failure and this issue is not encountered. Fixes: 37fa32de7073 Signed-off-by: Aby Sam Ross Acked-by: Eric Farman Reviewed-by: Matthew Rosato --- hw/s390x/s390-pci-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index b438d63c44..3166b91c46 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -1248,7 +1248,7 @@ static void s390_pcihost_unplug(HotplugHandler *hotpl= ug_dev, DeviceState *dev, pbdev->fid =3D 0; QTAILQ_REMOVE(&s->zpci_devs, pbdev, link); g_hash_table_remove(s->zpci_table, &pbdev->idx); - if (pbdev->iommu->dma_limit) { + if (pbdev->iommu && pbdev->iommu->dma_limit) { s390_pci_end_dma_count(s, pbdev->iommu->dma_limit); } qdev_unrealize(dev); --=20 2.52.0