From nobody Tue Feb 10 23:53:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1770691497; cv=pass; d=zohomail.com; s=zohoarc; b=PWNkls4BQYJO/9rpZHxFevgJuZe7usrpb3i469+I4UA7MdLZVuAPh0vvIfmCC0QrmlJ+SZn8dFjYJj/1LrFXbSFf9go3B4JVeDNqsmI7lGHY6U3Cll4Jmy+XyvjzEvfxNi+BJQNvrzz3nRc0KOjfr58w0Fz2yPNkIESxzefv/iY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770691497; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pIJ+iLDykOs5id3btVzlcGsJPZIa12RQ9PR7n3dHKoo=; b=NbPz1/C9ujwh7H/Zo8SommdqXJaqHt5aV5QyysoH4x97rPXKpsU7h4q/Sb4H4VIkReYIZ7ETJi7C8huqm2aAmkfr0rzQyaD/sgJ2kbWfGbWmL5aLZgv6hdUWggaeSQ5/a8OFHODHMI2btn93XcXoc2D3p46C5q+RbonSdDXPI90= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770691496836429.4775579999322; Mon, 9 Feb 2026 18:44:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vpdj8-0007mG-T4; Mon, 09 Feb 2026 21:43:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vpdj7-0007ly-2W; Mon, 09 Feb 2026 21:43:45 -0500 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vpdj5-000297-Ed; Mon, 09 Feb 2026 21:43:44 -0500 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by TYZPR06MB7118.apcprd06.prod.outlook.com (2603:1096:405:af::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.16; Tue, 10 Feb 2026 02:43:33 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9587.017; Tue, 10 Feb 2026 02:43:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ykYC5tw3CrQG31uL/sr7uVAK28z8zHxREniNM9zXzbc+y5KSAQnAUqwv+Y5DAsFJ45t9BeM3xudB+gPqW3ee+G2ks+NuRpB9IVpUYbgzZHzAHPMhMahPQgaXg7b6BbaiKq83+svozTFaeW54slHN/0ExAr8ZIdqGXY3YYVWRSBoStKNcv2Qs4/kpye8qvOMYjG7gOL7J2aBRmsPvS3oEiFQssHwpGBr2ppPwm4Aa2GQhKu3mQLHLIPsl9blV7CrwhZRWUDnx3LwlYKfFoeRwbEREuO7uUZgyznHLSYA2QSO+1qwBxco12MvV9Qhp9jCFSYDBirhbJFvGNiumruVgsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pIJ+iLDykOs5id3btVzlcGsJPZIa12RQ9PR7n3dHKoo=; b=ooUNeWScZOujQK/OHWd/nuAAqnSr2IpCU9LqTPOrnUTFmRCQwMk+1jx5qdQ0hJfAB3V7ycYUNZPMmzVe79mJCfxWh5tVS0v3NlVgI9GsLOmS7YplCvAVKPvjrb2HuE988tLS92viPFHuU+4d6VsJuLaLpW1pH9TPgGbDTsmB8WF1zwBUB71vtf/CUwinpJ5QcOBaxs7aN6cjFQv/pxH/8W4V6WbMnyvkTpCyDojnmNPT4a6aVn4pm/ejJCxCBQm7plWdxAsJA0P7RleLqFPg6S6kpx2cDJSKyflwbRR8E0WyTb092TZZJ39TzoIvxw3PMghPCli+D6Vo6LSfcbyj2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pIJ+iLDykOs5id3btVzlcGsJPZIa12RQ9PR7n3dHKoo=; b=Mhj+WAXZDbJRuk9Ys09uFfq+0Xy9ICqH+lE+XlAanVdWRvRxo1GHe7UaECCPkU9drw6HlNMEmIqE1HBkdt2Lk8sWUZvgFtOtw+BILHy5qwPrnLAK1kSSXv7ONS8wE4Y7jv+sPT3d2guiZ3DNaWFRilOuqoST3ADEn9KrZ1/TbKKAycS06M81aKXA9oBcNh0L+mclVJ4fgyE8zRpd0iGqFb4FNG1v7lDvc9CacjP1rX0oc7KW9kqwM3lAFqlcmd1trPANtsQ1Rw22A1A1V3kgAjNGUY/BkPlUFoR3HYbqRoIn81fY/ohdLjHUSxWbTCqwTc/varGmD8MMrCSMfMrzpg== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , Kane Chen Subject: [PATCH v2 1/2] hw/i2c/aspeed_i2c: Fix out-of-bounds read in I2C MMIO handlers Thread-Topic: [PATCH v2 1/2] hw/i2c/aspeed_i2c: Fix out-of-bounds read in I2C MMIO handlers Thread-Index: AQHcmjcLKKxxCIbY+UuyMY04HaSIxQ== Date: Tue, 10 Feb 2026 02:43:32 +0000 Message-ID: <20260210024331.3984696-2-jamin_lin@aspeedtech.com> References: <20260210024331.3984696-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260210024331.3984696-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|TYZPR06MB7118:EE_ x-ms-office365-filtering-correlation-id: ab9021c4-d4ab-4b2d-3887-08de684e2e82 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700021; x-microsoft-antispam-message-info: =?iso-8859-1?Q?vaWQqLWAItlesJLvxrIUhY9mGBZOkkc++iK6i7saC2Mz57V93oUrrp7F/F?= =?iso-8859-1?Q?wWrvbS6kbOxLVnlgk9xjLCJE66rIzclw43Fpjnj8WNYlTfsFZfUEGCvbF7?= =?iso-8859-1?Q?mcuCLhV9j979BHctgwVEkhH250/xS3dTy3v50UAuArbGJvncc5A37vMM7M?= =?iso-8859-1?Q?n6ZbvexF7qlgY2aTq5xMl30jwrnV01sucUNQ0K5QrZXD3SiWbwmSDbcCs5?= =?iso-8859-1?Q?HAkkC8k7XkQ1ymGaqkduVQ9+StCaJ3FPur/5tr0SFk7EnTh/hh6wxOX2C7?= =?iso-8859-1?Q?yjfmt058N5gNNrHnf6a/d9D8SRVfMhl9b+ZGUsDg1hTo7NzaAU2cozxGmM?= =?iso-8859-1?Q?INSWPf60vcopLIySaxgc1kZ+OEdzV++t/+F6eelmTWkWVBssUoWT1YJRb2?= =?iso-8859-1?Q?S37PpJZG590Hy2c3W8d+KB7tsqlWvkTp0OvX4wOdTgiFbvzAl5NxPndx5c?= =?iso-8859-1?Q?eAOgnahp0rx7XqSANr7HcJIuve4uOod0jHxxX6hDyqjckodEBIu62IyZHb?= =?iso-8859-1?Q?1wn39jcmHIMh/F6qVw1UPXUIepAYOPE/omxFabhAdjqzJKbNmfQNPs68OA?= =?iso-8859-1?Q?bKCKjlld5QEZyqZnLKn8fUToAnQTl3/K/qh5Y1hFXxos3DykXZW8sXFcQq?= =?iso-8859-1?Q?EmDEKwYPr6zS8un7y6ZM4gAI2MBqHwCmtfApRxhSPmb/EiCQHRnXTyMM+C?= =?iso-8859-1?Q?xU+FfpLtkbtVzsIjC8LbIUusljPQB8qNzx7p7+X1/+JnZBxJAyAlHVF4mw?= =?iso-8859-1?Q?9QxAtZUvPq5JA9rWWS/uY424OqrvoQfjHCFeXZN26MjfEabDd4RhR31Wpy?= =?iso-8859-1?Q?wPcpj4S4mkEKu7OVu7FnlIxyxCe8FVAiIbLIjUllOiiCNWzhO7kah/rhWZ?= =?iso-8859-1?Q?NtaUEIudvAQCPXlO9lG25GchjPbIfGWVf2vTPEjllgQv/rAzYq1T7Xw2nQ?= =?iso-8859-1?Q?R8ONePJH0mGO3OcCTTdAiFXwEmGzlVAb7bwCWYVHHqwg0wOJIOt8Fe0oJ2?= =?iso-8859-1?Q?uze8tqnkE6dMLgxaiMs0T9LOuKCrbYW4Yrawd0icMEYs8gdv/MM5Im/l8+?= =?iso-8859-1?Q?eYLcCNzJod1YImr2apfYNu3PaP6EuHga4SQtO6W3rHWZq1buLrr0Z5DXQF?= =?iso-8859-1?Q?6+w+Cm1ZO0Nfh8ZOZ2OTIk7RDpcwFxYxEVH+g1Wq5qfqNYlKzo6/1J6K8r?= =?iso-8859-1?Q?uhdeHDd5k7pR4InOFOYYOzKqzPZyEacILScgzdGR97SuKtLm9gw5yDHkE+?= =?iso-8859-1?Q?pMEWYtLcuq0ZMhnLh7FSMdhv6xNjBrvk4sFB7Ex8I+rfkaCU2RCPz38Bk0?= =?iso-8859-1?Q?+Uextxmi0gdjljZ5anreZi4EZkLLW8SHyLc3EMLKkz+VNrFL4/Nh4Ob0UY?= =?iso-8859-1?Q?KoXhNBYl7CCoVz1guBZgh/k2f5HM51XCqkoT3ibVZud56Kcmt9ZjaFzKoL?= =?iso-8859-1?Q?EYDV9z8yrBbEThpIEt6OBX4Kh82rxXyJBTFDk99Ptd+tXmA60a5nt8/hly?= =?iso-8859-1?Q?KbZF7NJERSIAeN7NNsJTpF5fEXnQQ1s5sfBBXGe3bOo+XnO/5QnmE5dqTR?= =?iso-8859-1?Q?beZKr3LvLULF8Qh2uKofyvHUewT4fcNaYCUQMrdFG5hB8uBbHwVf0ixHMB?= =?iso-8859-1?Q?qhfEfVrnS7HXlsu6qjWLaLIvIbhR/skluT0t37guzJ/pXdpuS7TZZclkwu?= =?iso-8859-1?Q?3UJjgwKvHJ70qZNVCV8=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?z3zThVCKAHrQFQLL7cBuFuNEy1HZE1O67EkWsxt6N0p6VIkQ9eDYlcFFWC?= =?iso-8859-1?Q?f6yQhiKFH+zdC4l3Yr/PrApnOUZ2iif/WnBqJTbNEwvJitaOqBXtCWSlJJ?= =?iso-8859-1?Q?JNIAsAie5ieWswZTUmGiEc+tNGqp04+7ho/kGnkdx2G7+5RZzZMFZm23bA?= =?iso-8859-1?Q?uTnfH7EEczBtDGTxOM3TsXvmb4fYXWaGuAtXBuKdHa6XPLXZuo/ZM09XOK?= =?iso-8859-1?Q?w8rX04P32MizLSOvRQfDSLhAm4OkguNH9GjwdeYBR/QbgS15juYwKbybHM?= =?iso-8859-1?Q?5lCWJX8hTkdvJwWystE2BHDWiHBmSCCXea+T++LvbUFQg+UxRqsMMkj2F+?= =?iso-8859-1?Q?u5nHREgVhGBinELvLr0hC6Yr+O7PG0TfNcPfvN3BotF++7mz7WFWt4eXcl?= =?iso-8859-1?Q?xndXi4tR/MHAiIZuB69XiVRs5Ic7nKXW4d4bhRDXO173vr9reFLMRn5BUb?= =?iso-8859-1?Q?hkDfh3EBbfkEfy+jdHnHkndjI+Qu7HKB7Q3xd+7dEny0Jw/OjdC7hncU1y?= =?iso-8859-1?Q?7GfRHDo9w/nrR5b7pyzG0SLYCeQ5hddHFnc6Kl0FbcNxtI7b1IItHfQWQW?= =?iso-8859-1?Q?2MXaJMoVo6uWrHaKjHe10feErhfVDwTFGVbFPXO1kQJPjj04sYVJ+2WRi3?= =?iso-8859-1?Q?FH6B6pMEgYbMhQCmzJV+FWalY6eytgRQCWta9oHObqiXMcXXgNhgpmj6nx?= =?iso-8859-1?Q?U2ujiOpYzTPR/FsUZMTgmWfODmBBYFE7pwFIDCa4h0sbozARRcCbH22K3k?= =?iso-8859-1?Q?P/fUi6uBBJ+E3eKrie5cV1onnIJItgxX0R87K3ioVJPqnZtFfEWBk8bVHC?= =?iso-8859-1?Q?b+n9OoEBaVsi+wksjuroBDlRdZekWaIlq8E+1ER+44pX0+JZMg65ECKqEx?= =?iso-8859-1?Q?etIHEbUYNmvN3HjgVgkw5tAaJ4ETipRykOEssE/v56htsmWiLo5R3CVsoB?= =?iso-8859-1?Q?s84U6r3UYGb5wRt0Q4+r9bUEfGZVTeipD/eTMlVAplaa2O+Qt1y+/i1r4z?= =?iso-8859-1?Q?Tyxtb1Hbk8dwwD5WWwtyBHIZdIvwAEZrBs71wAY+btwuBJAY70oLUNtiqU?= =?iso-8859-1?Q?Z7VU/+U90UWPuHbprsuAtyOA6+jRhDxTDlGZTtK34nNtClTKqYyPtJZnJk?= =?iso-8859-1?Q?0US3O+M83IQ9xNi5LPKuSUo3peonU7YFod2p9DiKHcMSZVcx25eA2Qvi8V?= =?iso-8859-1?Q?CO2Rzy/7WP9NiQ5S+q+r9QmJNvaHC4T37DmCa7o5pVt+afvfXq3Tm6FQMX?= =?iso-8859-1?Q?QzcEl8bTPF8laMwSI6b0+fTNLEQd8VtB2lw85LuxjZzvr6COYMHt4pTF4Z?= =?iso-8859-1?Q?lecVlqVJTYSw4X3CjTZ80TitnrvaN0H9e8vP4YUZad9A3TPObFTR+h8B9K?= =?iso-8859-1?Q?ersIcOGmqc6B+f3mj+XGI1/yWoQG1UoC8UQFvYrrBz7lUUnIadxSDB5W5r?= =?iso-8859-1?Q?1suU4Gsvqf6YFiKV9eUawP0eEfxQ2Yhfl9YA1q/0JjSg12Puih/8Bshdtl?= =?iso-8859-1?Q?3MDGiDc7CRtwlv566PJKZMfHKOn/XWK+8bxoVPVMONClR1PReDu3iFbntO?= =?iso-8859-1?Q?TnMhJIS3EoI7m/j2uf15ueFldJZDBkc2n9sr5PBRs0l68S8aINKgzAwfaa?= =?iso-8859-1?Q?WvIdGGwM+fijxCuNducu7rZ7kAU2lU2HQSkhhSTmZ8WkMkxcxdAlZDlTPn?= =?iso-8859-1?Q?+yrwFdeIoHH5puOXkwfP+A2biI1/S3rBT4ycUSbQ46QXLkyoxGslNIizsK?= =?iso-8859-1?Q?trdR9mm+FOdqC8GkNh6/pjSwwLHYcN9EoDVBZ9wkr2bPdLDU1WT5QEAKI4?= =?iso-8859-1?Q?KcF7VaWKVg=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab9021c4-d4ab-4b2d-3887-08de684e2e82 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2026 02:43:32.9663 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 21Vt0f1AbmxWHSoBdPFENIRf+DJ8F30ZvI613OfL8XRAn4pIUUCNRZ3AA3cB3ABYUuD8cguQFpLiI/QUoYRMdXDdrzsHR0Hm9c2zoDnKaVs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB7118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1770691499039158500 Content-Type: text/plain; charset="utf-8" The ASPEED I2C controller exposes a per-bus MMIO window of 0x80 bytes on AST2600/AST1030/AST2700, but the backing regs[] array was sized for only 28 dwords (0x70 bytes). This allows guest reads in the range [0x70..0x7f] to index past the end of regs[]. Fix this by: - Sizing ASPEED_I2C_NEW_NUM_REG to match the 0x80-byte window (0x80 >> 2 =3D 32 dwords). - Avoiding an unconditional pre-read from regs[] in the legacy/new read handlers. Initialize the return value to -1 and only read regs[] for offsets that are explicitly handled/valid, leaving invalid offsets to return -1 with a guest error log. Signed-off-by: Jamin Lin Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3290 Reviewed-by: C=C3=A9dric Le Goater --- include/hw/i2c/aspeed_i2c.h | 3 +-- hw/i2c/aspeed_i2c.c | 22 ++++++++++------------ 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/include/hw/i2c/aspeed_i2c.h b/include/hw/i2c/aspeed_i2c.h index 68bd138026..1ba0112cef 100644 --- a/include/hw/i2c/aspeed_i2c.h +++ b/include/hw/i2c/aspeed_i2c.h @@ -36,8 +36,7 @@ OBJECT_DECLARE_TYPE(AspeedI2CState, AspeedI2CClass, ASPEE= D_I2C) #define ASPEED_I2C_NR_BUSSES 16 #define ASPEED_I2C_SHARE_POOL_SIZE 0x800 #define ASPEED_I2C_BUS_POOL_SIZE 0x20 -#define ASPEED_I2C_OLD_NUM_REG 11 -#define ASPEED_I2C_NEW_NUM_REG 28 +#define ASPEED_I2C_NEW_NUM_REG (0x80 >> 2) =20 #define A_I2CD_M_STOP_CMD BIT(5) #define A_I2CD_M_RX_CMD BIT(3) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index fb3d6a5600..741c7a7297 100644 --- a/hw/i2c/aspeed_i2c.c +++ b/hw/i2c/aspeed_i2c.c @@ -94,7 +94,7 @@ static uint64_t aspeed_i2c_bus_old_read(AspeedI2CBus *bus= , hwaddr offset, unsigned size) { AspeedI2CClass *aic =3D ASPEED_I2C_GET_CLASS(bus->controller); - uint64_t value =3D bus->regs[offset / sizeof(*bus->regs)]; + uint64_t value =3D -1; =20 switch (offset) { case A_I2CD_FUN_CTRL: @@ -105,7 +105,7 @@ static uint64_t aspeed_i2c_bus_old_read(AspeedI2CBus *b= us, hwaddr offset, case A_I2CD_DEV_ADDR: case A_I2CD_POOL_CTRL: case A_I2CD_BYTE_BUF: - /* Value is already set, don't do anything. */ + value =3D bus->regs[offset / sizeof(*bus->regs)]; break; case A_I2CD_CMD: value =3D SHARED_FIELD_DP32(value, BUS_BUSY_STS, i2c_bus_busy(bus-= >bus)); @@ -113,21 +113,20 @@ static uint64_t aspeed_i2c_bus_old_read(AspeedI2CBus = *bus, hwaddr offset, case A_I2CD_DMA_ADDR: if (!aic->has_dma) { qemu_log_mask(LOG_GUEST_ERROR, "%s: No DMA support\n", __func= __); - value =3D -1; break; } + value =3D bus->regs[offset / sizeof(*bus->regs)]; break; case A_I2CD_DMA_LEN: if (!aic->has_dma) { qemu_log_mask(LOG_GUEST_ERROR, "%s: No DMA support\n", __func= __); - value =3D -1; + break; } + value =3D bus->regs[offset / sizeof(*bus->regs)]; break; - default: qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad offset 0x%" HWADDR_PRIx "\n", __func__, off= set); - value =3D -1; break; } =20 @@ -139,7 +138,7 @@ static uint64_t aspeed_i2c_bus_new_read(AspeedI2CBus *b= us, hwaddr offset, unsigned size) { AspeedI2CClass *aic =3D ASPEED_I2C_GET_CLASS(bus->controller); - uint64_t value =3D bus->regs[offset / sizeof(*bus->regs)]; + uint64_t value =3D -1; =20 switch (offset) { case A_I2CC_FUN_CTRL: @@ -159,13 +158,12 @@ static uint64_t aspeed_i2c_bus_new_read(AspeedI2CBus = *bus, hwaddr offset, case A_I2CS_CMD: case A_I2CS_INTR_CTRL: case A_I2CS_DMA_LEN_STS: - /* Value is already set, don't do anything. */ + case A_I2CS_INTR_STS: + value =3D bus->regs[offset / sizeof(*bus->regs)]; break; case A_I2CC_DMA_ADDR: value =3D extract64(bus->dma_dram_offset, 0, 32); break; - case A_I2CS_INTR_STS: - break; case A_I2CM_CMD: value =3D SHARED_FIELD_DP32(value, BUS_BUSY_STS, i2c_bus_busy(bus-= >bus)); break; @@ -176,13 +174,13 @@ static uint64_t aspeed_i2c_bus_new_read(AspeedI2CBus = *bus, hwaddr offset, if (!aic->has_dma64) { qemu_log_mask(LOG_GUEST_ERROR, "%s: No DMA 64 bits support\n", __func__); - value =3D -1; + break; } + value =3D bus->regs[offset / sizeof(*bus->regs)]; break; default: qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad offset 0x%" HWADDR_PRIx "\n", __func__, off= set); - value =3D -1; break; } =20 --=20 2.43.0 From nobody Tue Feb 10 23:53:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1770691495; cv=pass; d=zohomail.com; s=zohoarc; b=WS3EZ4hv0LubOWy7/dnXH5DPU/BAywQeuXmp1SnhkDh2MqjeHQ/iA4emOlIlxLx95PJhaEnY3WfIfT84XZpgYLfF/xEHyNN22nxE0DyuKSXqP3blNJ3RbMkFhbgad8QLliZp3claIAC6jfn4Yb7qUT6GjRdJznUwxGHiXc7yeYk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770691495; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=maa5TNK4qKtDl1z+j0jg8KeSJFq55agfZjuLNgia/wI=; b=PkrXhFX2zaPaa/O1nzKy/0KxdvSZllRjmDa+wP3jPUJdc9SffIWCs7AEJTQmwaAjEZpNVDnvzwiroaVFMOlU/nUGvLI/j/eAOfoE09/pUlOzKSvxqs4P1tjYXr5QpLS413qvQMIttXaUuu0f5EVhlWQsrmN8RU9ErwjemVr/Fvs= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177069149512224.592809373978298; Mon, 9 Feb 2026 18:44:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vpdjA-0007n9-Mi; Mon, 09 Feb 2026 21:43:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vpdj9-0007mr-Cg; Mon, 09 Feb 2026 21:43:47 -0500 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vpdj7-000297-QG; Mon, 09 Feb 2026 21:43:47 -0500 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com (2603:1096:405:383::19) by TYZPR06MB7118.apcprd06.prod.outlook.com (2603:1096:405:af::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.16; Tue, 10 Feb 2026 02:43:34 +0000 Received: from TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3]) by TYPPR06MB8206.apcprd06.prod.outlook.com ([fe80::e659:1ead:77cb:f6d3%3]) with mapi id 15.20.9587.017; Tue, 10 Feb 2026 02:43:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=T13zaaBjhiaAgG01QHWuAfT7HSlun+5BlYj5nqeeBuinSaIQX3xtuyYJ3OSrZHzSuVahkCmEUgrH29LXWPpOejUMCU9O6m9OhNYUEvNldN2+YGh2h7E+esP3f2jOFtGb2DOWFJ5lOlE1qlca5+PSTve8fU/RuFmIyIM19UJqa3RdNn+Dd5LHcBlCR/duzliRov3M5ny1LteioKCZUy1xUzE8h6x2gGVMXcs4Xxd1Scwj+2OO0qY8Y1+6ux4D9XFPmDujYLtD7KS9PetzMSE94I3wdMw0bR+BIEjTbLQFz1GEwQ0hfL+YGAYNdy8t98jE/sgh5xrlKz65fmoc/DRQ5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=maa5TNK4qKtDl1z+j0jg8KeSJFq55agfZjuLNgia/wI=; b=Tn/8SHnFlxb0Ai03JNtzDrVuOQuM6Ds4GqO3BL6F5wyMf3DMpSO4x2GDf9pnPknkic/Bv4hBP12UQbt/jNpF1wdIiR0zX3R4RTSFmfGkPwqiPdfTo3GUMd6E/wgAxbNYOgQzyuOg5EV2O60J208ZNZR05jyRLLGhL28ARg4o+xlMSNlm86+eQhxx8Kx1EEan2Nl35SyTtZnMA3joPWW2X6s4Vczv3/3pOw3ZV04mp7g9WolZYKUjerkch18uVZ7jSoZGTFZKaIIKNUV7v3L/qEV2Kq9r2OVsNeIpcd4+h+uTnqDeIat9ysYyVmVlNvpT9zA05Gns6C3j8MLSAwMhdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=maa5TNK4qKtDl1z+j0jg8KeSJFq55agfZjuLNgia/wI=; b=Xn8651tsJV7t3n2KDBUmVUmbfSnyxGoSsgjgsPogn0FR16CyjIBRghPSCRMLldxqImb3XcxPwMJlYqWy3aVp7qa4OLDKS60gnDdIRS4swoDzCwYLQbMQ8CE9vUd9OoTI2zaE9d2cuLvAoikn0PR0KXGIC/aSzhONfLDcEXxRnR5IoN1Asvs7RL9DbMbtxd8MtJan//UJ3PTGZUAwzAG1CsBJhKk0R0w4L8fS1cQJoDCnUgqXwpsi7bU19OWjU5zPTGctMOkyzKXGIj0uDh2TQ0ocVJ82sg7aX8orX3PgPNOWa4ljf7Kc/UID7yuj8WriATerujMag6aYg9MrVqcgxg== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee , Kane Chen Subject: [PATCH v2 2/2] hw/i2c/aspeed_i2c: Increase I2C device register size to 0xA0 Thread-Topic: [PATCH v2 2/2] hw/i2c/aspeed_i2c: Increase I2C device register size to 0xA0 Thread-Index: AQHcmjcM+drWFlMzskyoP3tfU71CLQ== Date: Tue, 10 Feb 2026 02:43:33 +0000 Message-ID: <20260210024331.3984696-3-jamin_lin@aspeedtech.com> References: <20260210024331.3984696-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260210024331.3984696-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYPPR06MB8206:EE_|TYZPR06MB7118:EE_ x-ms-office365-filtering-correlation-id: d003062e-4df1-4516-da2a-08de684e2f1c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700021; x-microsoft-antispam-message-info: =?iso-8859-1?Q?0i5Qaew45/nTiNTJVsWKK6RZvyujN/FMdv7QFs6lOapVwSqCkFUcKz8JiS?= =?iso-8859-1?Q?eG9YffWQVpRAArXUm/gEqZTOWkQjoLerOv38n+mr8h1/vMfmCU6ModbsTe?= =?iso-8859-1?Q?z1LUJyNlmOevbzW0g6Q3Aw38O3WxDuTfUEzgPcChAv5TQrUKiGkGWdsl6Q?= =?iso-8859-1?Q?mZWb9UHteL7VzuOJ6lLiRtW2Xa0XTsH4RN3IPCf7nAF7LOwQi8z/rxGMFK?= =?iso-8859-1?Q?l+I2VTLbEzjyf3SZjeXKpcUVfrZ3PxxktxPUHB5dbpO5KFLccOMW1c87yO?= =?iso-8859-1?Q?LGlk0M9CXAOGBy9zD1I5+o/j3W/wiVxvAcDu3awZn/yqKYjpqcJTjXz9dp?= =?iso-8859-1?Q?SUXsjxrkwsltiYTRI2hFzqCGJSQaon3SyEcjQW+Uhh8KG9ufGATNe5m12J?= =?iso-8859-1?Q?JOHXDiyimOOpkrAM+TAo+MdXeUVdfDZjgn9maXNCsaq4nSXacaBMSbSfMf?= =?iso-8859-1?Q?b1QAOEUYezgAFetgrp+81lsnoafwk49j83uyT4NEMRZVg11mZKoQoEwhu/?= =?iso-8859-1?Q?H4JaDUoigXmzToFLOJDL6Boj768YAce7IpxkclRKTVAPF9z91sd7C0yqJs?= =?iso-8859-1?Q?/vV95kzWpV2mWdv8OhSZXivV5/tsil7cArzs0ScLVBese6YohgNlTs9PoE?= =?iso-8859-1?Q?oYuK69f9awiTglJnKcs/8EzT+V5BOpRyi/XZwD5inZSgoyAE7zfLuoS/LK?= =?iso-8859-1?Q?PsuX1XaobRJfTT1GTG5MIyy8kyP1MoT1rq1ZQQG6zuOEvw3V5AwM2b6Ldz?= =?iso-8859-1?Q?2j5JrKJkhQFRX2Xw0UzIbC+xURycYwZKqi48sMCX9jZ34FJsfVmY7UBXIl?= =?iso-8859-1?Q?MYr1EvnIY2kGc4I8eJD8Gkhka7Y3LgLF2j7klg5a8F4iB/YLY7lp0oRetZ?= =?iso-8859-1?Q?U7dw8AMpZqdzzdueVKQoGnwyNWaVl5GNKKCtkVzzft6GK1mn++0LoodMA4?= =?iso-8859-1?Q?HnP0FfHUr0bRmL0a7FheWg/iCevLf9fjfKN0OYzJPv6MMOpoEqnlXeZkOG?= =?iso-8859-1?Q?KJ0x9tYw3OGPBhO4Y+mBagzkBESpyS110RqJOWWZhbSMyhTQ2ucUaNZfuo?= =?iso-8859-1?Q?5xYg/JcJzLgt5jv03VcR5CApI/aZmS2BEyDc9iBKNmRBZCC7lzb9vlTVV6?= =?iso-8859-1?Q?LcURasN/YACweu3ragOhnuJra3uoN7d+1EeTejrYFJwMj0Wf5z795rgdom?= =?iso-8859-1?Q?W0wAYK0p8m35YsEzqXNDoq+9Q9K5DAocNMB3uGZbMl76KSNIIaZQxOq0eK?= =?iso-8859-1?Q?IkSBi4YQ2IC5pi2nEXyJ0ykvopYMe3G+zdqxCgvRSngTBvK4CcNt+SkXO1?= =?iso-8859-1?Q?7HphGTO4WVaL0v5ZeKniq2dKdaS+CeQGFlhiZcFu6JUBEKd8UUteNi197t?= =?iso-8859-1?Q?wAUDkBzrScHbQakFCy+aIRGFSKfX2hzw+No3AeK76/CMGWPzz14mQAvz51?= =?iso-8859-1?Q?pS72BO0OlG/lh4sBeh/u5sO9pSC7Opyb8lUjEHI2HqUZGui2uDpURseY3j?= =?iso-8859-1?Q?rFLAeb9kU1ruQm8ma4G2MUO4LbVyq/FVn/agh2d5BU/qQG5gL5ez1rlr4l?= =?iso-8859-1?Q?97bkddj6ZjASwzDbQ4EANsoTxCaGEYtzOIRdfLO6yGBqJ9V8mKWl11A1TJ?= =?iso-8859-1?Q?3VgOv3fVn4wBOy51RQLi8DjHiCusD87GUC475j8TafwSXH6joNdZEbj5wP?= =?iso-8859-1?Q?NClM3oIdQpDLeuMM8Nk=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYPPR06MB8206.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?D+gGCmuHNPFy24SaqWQt05O4X23b+V2k+VN+/esvION5DPLw1TipGDhXhI?= =?iso-8859-1?Q?HfKFdT2jELMkyJYVPpFj46gBRgEvLWPBX5hXn5scaAVrs+vkmr+o4xkj8a?= =?iso-8859-1?Q?3BExFgdiVT/YuqrkLNKavqxn+xC/xtb43MZhdyjonRgMyoosWwDoRVdMKi?= =?iso-8859-1?Q?keVFEKwwe4+wLAszdTsPXRovnWVBUfqCDGfrWQTxDBgQtfN+ixBSS3UZZc?= =?iso-8859-1?Q?ag/dMjRm7N0KIhxd9IomTknkOOz10lIjeMYPfMHVW2e4FeHe0YX9CEO29G?= =?iso-8859-1?Q?FbcfVhRnKuF4WSvhjnwKnVUZvYYsDSuB2Ei8Qa60eQfswQULQMfQJPxRUn?= =?iso-8859-1?Q?TTSkws1D3UFkjjx54cYDKw+ugdtV4XqEHNbQBC8vwqIsaF5q/wrLW2sUFx?= =?iso-8859-1?Q?f2N5C/XIk1AmvLdPcC/tBWyXY5yuCvIab2pFyWCt77UrokU3usxEVusc93?= =?iso-8859-1?Q?K8qkV3hzw1YmvtZhxscxYiNsfaB3szQ6ooGhS/9PRg8q2pdTSDYRzy6rce?= =?iso-8859-1?Q?kHVUpi1QlTnygvdQ97tLFSxcgu6WXcFUlHe9IdBMvxZQ9GJiudex4+a9TU?= =?iso-8859-1?Q?vNEgzmh5CAr32XVbocJ2HBShu79MpuQqnts7YD5kfKA9i/agSfeMcj7/Pz?= =?iso-8859-1?Q?BmWXq6vUaAw4NrP38cORQJQHikd162P9kmGexv6hBwrAh6r2TE2LTddyK8?= =?iso-8859-1?Q?4LwKYTSpwQARw2WsE5OPau84BWag+euIxeCLuBYY3g+pVyJ8zI8IPNnv5C?= =?iso-8859-1?Q?LG1DU/6QqMSI8W3X4RhHRPsunbOLhZrVSfxETORSjq/yNTRMqVEVRN3kMT?= =?iso-8859-1?Q?Gj1QQZgltbIB7jPoGhbAzHgHQNC+0rXsusPgtAdPZ3Bmu8QK+kNViCNi00?= =?iso-8859-1?Q?xFiqiB3UKeDtQC438KG9a/S1Ks3t1qxYSN0X9rPDRWJRjJG47eG1pI0nJg?= =?iso-8859-1?Q?KGRoa/YKU/gVGpAzqEl4xhupGKgOYIhjcbiJxOKekplL+D3O42aiTYuOhi?= =?iso-8859-1?Q?65EKyAADhClf1goN0rzPJGwvBlZWhkDAE0trPftx39PYSzIOs936bQvOnt?= =?iso-8859-1?Q?NW55LoPUvdqvvPdqdRLgaQS5DFlxcFIPnuCUVkLcoXmLWppt7l4Q6AGNd3?= =?iso-8859-1?Q?+qd9lgOrQr9ZXwyeYPIaWdQ95SiBiJiVZmw9e0Bpv8LspekyEY5sXRAMDu?= =?iso-8859-1?Q?ESze0SnXnJTqUrYteHzkITzaMnOXcbTmrPd9xeGhRHoSAGUg9AkZbaCCn7?= =?iso-8859-1?Q?6AYgSQC3L2rhgO/eKt5Fm19xCZGAbhGGL1sqqNgLr11MpC+PH+X1hfR5Zo?= =?iso-8859-1?Q?82oL1dvPmh1h0AX6lPbctYqsDVgk1U9/mlCdF2Y1CGxEVGaoc/a9UweqLw?= =?iso-8859-1?Q?Ji3u60ug7pHQGmoihD7hke8x97PohlmTiM7sWH9AwvZlcQaOJGQCoYqG9u?= =?iso-8859-1?Q?+mo4tN1wuvREEQJPy1KMp841LkBZt2V5PgrnRxxRFJbnLj+wxds0kWUXnQ?= =?iso-8859-1?Q?V5ZlBzXwTXqtxw5rBu55ic6yGpCYRKsPQdFYt8bNjcZMLvGl4Ekka6u1xU?= =?iso-8859-1?Q?MNjGLLmDhUIadXj88C3IoWf6eEhLn3rTZDzXywCCy3lgSxr+bjP9eMLb2V?= =?iso-8859-1?Q?czRvsh5lIm+kRt6+2XKI1TPa2OUlcQ4BBQhpquWzSJyv3QhJMcnwDy5Atq?= =?iso-8859-1?Q?JQ2QLRQBnq8zLis8O0b7ABtEDqU4+Wgm6lRbLL9t6a+NIXQNd/G69t2hby?= =?iso-8859-1?Q?9K0QbsfLrIly0Pg035TChaWzkljqZPcPFaQHBHofTtSUmpWLrDX4grZ6Ef?= =?iso-8859-1?Q?NMzN3wtJbw=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYPPR06MB8206.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d003062e-4df1-4516-da2a-08de684e2f1c X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2026 02:43:33.9815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: liMyEmG0EQOBG9BeKj6zWlfdfe0b27X+aOV5BR1c18ucuDCGw3D/GBai6+9JhoteyPiQ76wOBULjzMY/594A/fsNeWHW1aK+a1yxj6fFvj8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB7118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::5; envelope-from=jamin_lin@aspeedtech.com; helo=TYPPR03CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1770691499087158500 Content-Type: text/plain; charset="utf-8" According to the AST2700 A1 datasheet, the register space for each I2C device instance has been expanded from 0x80 bytes to 0xA0 bytes. Update the AST2700 I2C controller configuration to reflect the new register layout by increasing the per-device register size to 0xA0 and adjusting the register gap size accordingly. Signed-off-by: Jamin Lin Fixes: 4f53de2f103d6dfb5ad0498995d91a9694f40dd2 ("hw/arm/aspeed_ast27x0: Re= move ast2700-a0 SOC") Reviewed-by: C=C3=A9dric Le Goater --- include/hw/i2c/aspeed_i2c.h | 2 +- hw/i2c/aspeed_i2c.c | 36 ++++++++++++++++++------------------ 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/include/hw/i2c/aspeed_i2c.h b/include/hw/i2c/aspeed_i2c.h index 1ba0112cef..53a9dba71b 100644 --- a/include/hw/i2c/aspeed_i2c.h +++ b/include/hw/i2c/aspeed_i2c.h @@ -36,7 +36,7 @@ OBJECT_DECLARE_TYPE(AspeedI2CState, AspeedI2CClass, ASPEE= D_I2C) #define ASPEED_I2C_NR_BUSSES 16 #define ASPEED_I2C_SHARE_POOL_SIZE 0x800 #define ASPEED_I2C_BUS_POOL_SIZE 0x20 -#define ASPEED_I2C_NEW_NUM_REG (0x80 >> 2) +#define ASPEED_I2C_NEW_NUM_REG (0xa0 >> 2) =20 #define A_I2CD_M_STOP_CMD BIT(5) #define A_I2CD_M_RX_CMD BIT(3) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index 741c7a7297..122bfdd63d 100644 --- a/hw/i2c/aspeed_i2c.c +++ b/hw/i2c/aspeed_i2c.c @@ -1205,37 +1205,37 @@ static void aspeed_i2c_instance_init(Object *obj) * * Address Definitions (AST2700) * 0x000 ... 0x0FF: Global Register - * 0x100 ... 0x17F: Device 0 + * 0x100 ... 0x19F: Device 0 * 0x1A0 ... 0x1BF: Device 0 buffer - * 0x200 ... 0x27F: Device 1 + * 0x200 ... 0x29F: Device 1 * 0x2A0 ... 0x2BF: Device 1 buffer - * 0x300 ... 0x37F: Device 2 + * 0x300 ... 0x39F: Device 2 * 0x3A0 ... 0x3BF: Device 2 buffer - * 0x400 ... 0x47F: Device 3 + * 0x400 ... 0x49F: Device 3 * 0x4A0 ... 0x4BF: Device 3 buffer - * 0x500 ... 0x57F: Device 4 + * 0x500 ... 0x59F: Device 4 * 0x5A0 ... 0x5BF: Device 4 buffer - * 0x600 ... 0x67F: Device 5 + * 0x600 ... 0x69F: Device 5 * 0x6A0 ... 0x6BF: Device 5 buffer - * 0x700 ... 0x77F: Device 6 + * 0x700 ... 0x79F: Device 6 * 0x7A0 ... 0x7BF: Device 6 buffer - * 0x800 ... 0x87F: Device 7 + * 0x800 ... 0x89F: Device 7 * 0x8A0 ... 0x8BF: Device 7 buffer - * 0x900 ... 0x97F: Device 8 + * 0x900 ... 0x99F: Device 8 * 0x9A0 ... 0x9BF: Device 8 buffer - * 0xA00 ... 0xA7F: Device 9 + * 0xA00 ... 0xA9F: Device 9 * 0xAA0 ... 0xABF: Device 9 buffer - * 0xB00 ... 0xB7F: Device 10 + * 0xB00 ... 0xB9F: Device 10 * 0xBA0 ... 0xBBF: Device 10 buffer - * 0xC00 ... 0xC7F: Device 11 + * 0xC00 ... 0xC9F: Device 11 * 0xCA0 ... 0xCBF: Device 11 buffer - * 0xD00 ... 0xD7F: Device 12 + * 0xD00 ... 0xD9F: Device 12 * 0xDA0 ... 0xDBF: Device 12 buffer - * 0xE00 ... 0xE7F: Device 13 + * 0xE00 ... 0xE9F: Device 13 * 0xEA0 ... 0xEBF: Device 13 buffer - * 0xF00 ... 0xF7F: Device 14 + * 0xF00 ... 0xF9F: Device 14 * 0xFA0 ... 0xFBF: Device 14 buffer - * 0x1000 ... 0x107F: Device 15 + * 0x1000 ... 0x109F: Device 15 * 0x10A0 ... 0x10BF: Device 15 buffer */ static void aspeed_i2c_realize(DeviceState *dev, Error **errp) @@ -1658,8 +1658,8 @@ static void aspeed_2700_i2c_class_init(ObjectClass *k= lass, const void *data) dc->desc =3D "ASPEED 2700 I2C Controller"; =20 aic->num_busses =3D 16; - aic->reg_size =3D 0x80; - aic->reg_gap_size =3D 0x80; + aic->reg_size =3D 0xa0; + aic->reg_gap_size =3D 0x60; aic->gap =3D -1; /* no gap */ aic->bus_get_irq =3D aspeed_2600_i2c_bus_get_irq; aic->pool_size =3D 0x20; --=20 2.43.0