From nobody Tue Feb 10 12:14:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.com ARC-Seal: i=1; a=rsa-sha256; t=1770547307; cv=none; d=zohomail.com; s=zohoarc; b=LMj0hdJhcrTnexnWAawCqbihZ+C58zZjpTtD7Xb1uMzUDR0ZfJmpkP7pbpDvC9JCelIP4wg24gPX/olbEK7NchuxNo+zjJQLxzxnhkr4hYiQajG2KuehQhxwRe0uHB0DIY2GNEAeC1qfuQOwMRx3+gQhztWykQUzAWy7gXpU9mE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770547307; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Y8T3sQ7myYRXFcyLO/RPNCMgHh3wQJni+Ls0PXgNJQQ=; b=hBOwNkD2JOYAl4ODNmcB9k6jOfnreXcvOLI33k2C11ttuFY9O5aKFCYzkDby3vvzYJpK+AXNcBj4GGq+Shp11P/Mtcr0X29h7dmQ4NJY0dG1RU8casKMJSsIE5hiqtlBPZbnfTokbHU2MIj5H6tqsHXtI/6jSxv3uBZzB1zusoY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770547307575428.3863171755206; Sun, 8 Feb 2026 02:41:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vp2EJ-0004FE-Nv; Sun, 08 Feb 2026 05:41:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vp2EI-0004Dn-BV; Sun, 08 Feb 2026 05:41:26 -0500 Received: from forwardcorp1d.mail.yandex.net ([178.154.239.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vp2EG-00079z-Pm; Sun, 08 Feb 2026 05:41:26 -0500 Received: from mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:94a9:0:640:a3fa:0]) by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 33F9B80605; Sun, 08 Feb 2026 13:41:23 +0300 (MSK) Received: from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:d25::1:35]) by mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id WeNYFo1Apa60-Q2qTpPXd; Sun, 08 Feb 2026 13:41:22 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com; s=default; t=1770547283; bh=Y8T3sQ7myYRXFcyLO/RPNCMgHh3wQJni+Ls0PXgNJQQ=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=i7jLCQZkWzBe8aGVU3aKtmvAWaW4IFPZQN0u9K8kSDtk0pWDpRkIV0Ei0ZMXq7xGe 7iI1jMcd4GH2HRx+c6qxZf97ZbMxqfbW4z5ctbqaph8g/TB6Gu0Q8fvoVZy0mAUJT0 5aCL/BhuSqtQsx5vM9N2QL4mBtEAX6rCFhufX2TE= Authentication-Results: mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net; dkim=pass header.i=@yandex-team.com From: Sergei Heifetz To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org Subject: [PATCH v3 3/4] system/physmem.c: remove useless assertion of block Date: Sun, 8 Feb 2026 15:39:57 +0500 Message-Id: <20260208103958.121455-4-heifetz@yandex-team.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260208103958.121455-1-heifetz@yandex-team.com> References: <20260208103958.121455-1-heifetz@yandex-team.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.200; envelope-from=heifetz@yandex-team.com; helo=forwardcorp1d.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.com) X-ZM-MESSAGEID: 1770547309789154100 Content-Type: text/plain; charset="utf-8" It is useless to assert that block is not NULL because it is already dereferenced in the first line of the function. We could split the declaration and initialization of oldsize, but then we would need to remove the const qualifier. This seems worse, as the assertion would be almost useless anyway. Signed-off-by: Sergei Heifetz --- system/physmem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/system/physmem.c b/system/physmem.c index b0311f4531..317b359ebe 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -2057,8 +2057,6 @@ int qemu_ram_resize(RAMBlock *block, ram_addr_t newsi= ze, Error **errp) const ram_addr_t oldsize =3D block->used_length; const ram_addr_t unaligned_size =3D newsize; =20 - assert(block); - newsize =3D TARGET_PAGE_ALIGN(newsize); newsize =3D REAL_HOST_PAGE_ALIGN(newsize); =20 --=20 2.34.1