From nobody Tue Feb 10 11:15:16 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.com ARC-Seal: i=1; a=rsa-sha256; t=1770545118; cv=none; d=zohomail.com; s=zohoarc; b=GIriVQwqfJ1e3rY5Xj8q6aJ3Zd92kcEu9tLg1lpdnmwqtLgDE0fvf+RWZRfe0+SAUNihYTsRkGSNiSoSx5taZDfW2ZCDAU7F2zSX/1wvUtuOjMkrE/Pu63QcpeZOd/BS6ymtFfEa7Cq6+/SsAq05sHKbSo28yhbLXnnXNPe1W/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770545118; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Qsul4O4z95xq9yphmhSiylpmeGjeIrFHxIxrbO2rFYY=; b=iiErBZTLWlFVhkcjJafwo7an8S8w/QReXUnj7xVM8hSE+sHcWvieByoUWEONgZWOwjP/mOCHAGhnLwJqLDcBTZJviIY27pDMQATgnnaREj2+bxHh2twDNLj3/Mn/8zwiOUFVfGZ8HBVT3s+qMK0yX6pAfZPQ4/wEfpRsus9UZqs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770545118052961.9698864016351; Sun, 8 Feb 2026 02:05:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vp1eJ-0004Ll-6h; Sun, 08 Feb 2026 05:04:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vp1eB-0004JX-J7; Sun, 08 Feb 2026 05:04:07 -0500 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vp1e6-0001oR-34; Sun, 08 Feb 2026 05:04:06 -0500 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c24:fa2:0:640:41ee:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 26B0580896; Sun, 08 Feb 2026 13:03:58 +0300 (MSK) Received: from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:d25::1:35]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id t3Njcn1A4eA0-phArVM8v; Sun, 08 Feb 2026 13:03:57 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com; s=default; t=1770545037; bh=Qsul4O4z95xq9yphmhSiylpmeGjeIrFHxIxrbO2rFYY=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=HvRUyCUjcCQ3aRa+wlY01og3TEhNpHIduXFAB40A/QxPKrfaRNpc1HWK1RKDyWTLj MuXsbG0hGBqw9YMlzp0uxpcIv0OFrOpqOIZzcfFZeDYtG8ZZph9zbyGzc5A7O2L3dj /A125ttGlzO2N12VUaOi5mxoNnO5aak2DdMKTFsY= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.com From: Sergei Heifetz To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org Subject: [PATCH 4/4] hw/usb/core.c: reorder usage and assertion of p->ep Date: Sun, 8 Feb 2026 15:03:54 +0500 Message-Id: <20260208100354.116102-5-heifetz@yandex-team.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260208100354.116102-1-heifetz@yandex-team.com> References: <20260208100354.116102-1-heifetz@yandex-team.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=heifetz@yandex-team.com; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.com) X-ZM-MESSAGEID: 1770545121187154100 Content-Type: text/plain; charset="utf-8" Reorder the code so the assertion of p->ep occurs before it is used in the subsequent lines. Signed-off-by: Sergei Heifetz --- hw/usb/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/core.c b/hw/usb/core.c index b3f811c513..9572a870cc 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -423,10 +423,10 @@ void usb_handle_packet(USBDevice *dev, USBPacket *p) p->status =3D USB_RET_NODEV; return; } + assert(p->ep); assert(dev =3D=3D p->ep->dev); assert(dev->state =3D=3D USB_STATE_DEFAULT); usb_packet_check_state(p, USB_PACKET_SETUP); - assert(p->ep !=3D NULL); =20 /* Submitting a new packet clears halt */ if (p->ep->halted) { --=20 2.34.1