From nobody Tue Feb 10 09:59:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.com ARC-Seal: i=1; a=rsa-sha256; t=1770545068; cv=none; d=zohomail.com; s=zohoarc; b=bW2JL8/CpgLWkQqC+igr0BDZ4re0d0vPuJWU705vBR91EKAT78B2q+d49+3lIUGAmS8KrFgthgHaby0Aa9SNlPvsAflimu/FX/nOMKmuZ2ISkFffnMF3J1JTya0vLKx2xu2s5wZOrRjLZ6CkxnCjfdtS7BDSnQXUrd6Mfd54ZfQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770545068; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=x2BACitWrsPLZRV91SG2I0BF2s7UC2JexW9F7xC6lbQ=; b=jG/0A4Q2Xth2dtuSHoIIFU3InRAwzYqe4e8lxbuDWIJAfHZ9sg0TAlpGYp+AGe10/+XEIG23e/J6FvBDHufyYvhuL5E6JMympn9/N3/KsBsbdRyPk+emEZj9vQpN9xreAg9aRug/ua1zjwBqt5Ur6OPolh9QyDYVj8uANfSe/gE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17705450682001023.5771207657133; Sun, 8 Feb 2026 02:04:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vp1eD-0004Jy-Eh; Sun, 08 Feb 2026 05:04:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vp1e9-0004JD-CT; Sun, 08 Feb 2026 05:04:05 -0500 Received: from forwardcorp1b.mail.yandex.net ([178.154.239.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vp1e5-0001oI-QV; Sun, 08 Feb 2026 05:04:05 -0500 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c24:fa2:0:640:41ee:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id E81CD80769; Sun, 08 Feb 2026 13:03:56 +0300 (MSK) Received: from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:d25::1:35]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id t3Njcn1A4eA0-LnXf7XBi; Sun, 08 Feb 2026 13:03:56 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com; s=default; t=1770545036; bh=x2BACitWrsPLZRV91SG2I0BF2s7UC2JexW9F7xC6lbQ=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=zhJB3pwZq7uD1Gf5w+eJSWNlPrnAfQWxFA9Rl9lY09ZnL3W8hjPOBx8bg4FzRJy/G HNbOtncdMYIM0osyWiTqZD5QgIlVJBdCOFiDc7xjM35xi0IYtAvD0HU7CKS9IyJHM2 W19uDIhwWC3jFoixZq+PiAhkM0777FgO6pggk950= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.com From: Sergei Heifetz To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org Subject: [PATCH 1/4] migration/savevm.c: reorder usage and assertion of mis->from_src_file Date: Sun, 8 Feb 2026 15:03:51 +0500 Message-Id: <20260208100354.116102-2-heifetz@yandex-team.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260208100354.116102-1-heifetz@yandex-team.com> References: <20260208100354.116102-1-heifetz@yandex-team.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.136; envelope-from=heifetz@yandex-team.com; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.com) X-ZM-MESSAGEID: 1770545071379154100 Content-Type: text/plain; charset="utf-8" Reorder the code so the assertion of mis->from_src_file occurs before the call to migration_ioc_unregister_yank_from_file, which dereferences it in qemu_file_get_ioc. Fixes: 39675ffffb3394 ("migration: Move the yank unregister of channel_clos= e out") Signed-off-by: Sergei Heifetz --- migration/savevm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/savevm.c b/migration/savevm.c index 3dc812a7bb..930a3391e3 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2885,13 +2885,14 @@ static bool postcopy_pause_incoming(MigrationIncomi= ngState *mis) =20 assert(migrate_postcopy_ram()); =20 + assert(mis->from_src_file); + /* * Unregister yank with either from/to src would work, since ioc behin= d it * is the same */ migration_ioc_unregister_yank_from_file(mis->from_src_file); =20 - assert(mis->from_src_file); qemu_file_shutdown(mis->from_src_file); qemu_fclose(mis->from_src_file); mis->from_src_file =3D NULL; --=20 2.34.1