From nobody Mon Feb 9 15:46:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1770487673; cv=none; d=zohomail.com; s=zohoarc; b=B0W+rDM+XSQU8sMaLbyYSvqhqMTaDk1u3QJX5Dwe2CGwwSbXG86v0ZlGaG686oJ5nWKU8Ok+9TbO6Ue8IleAFxxfnIYVO/F9+GFMGTnQMtTeO49Z3/78hrX+fiWtoohFy/z7iYW9X52ros91eL5n28isHwrZkfG/5m8QrrdtI6Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770487673; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SGn9Dx9TKhYwyyq6cn6DSMXoUDg7D4YZd5UT23z4be8=; b=mnQRVTQGyX5dwKpHXnTUsze6ljMsqrGZEh/VTEH3ZZOsz1p1+Xn8x8FFN9asSpUazWvR7CxmCNzC9UIeNhQdf0ymc04XwhzTHLojQRCfquq9KyVuj90+MySiteX6VLKMf4g+CYfg2ONNvUQQ8g2RbaCONglzPExyRS/d4pFznYE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770487673920388.4046935424284; Sat, 7 Feb 2026 10:07:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vomi9-0001Vf-PW; Sat, 07 Feb 2026 13:07:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vomhz-0001TZ-R2 for qemu-devel@nongnu.org; Sat, 07 Feb 2026 13:07:04 -0500 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vomhr-0005LY-Cv for qemu-devel@nongnu.org; Sat, 07 Feb 2026 13:07:01 -0500 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6174chvk1050589 for ; Sat, 7 Feb 2026 18:06:54 GMT Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c5xj1938u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 07 Feb 2026 18:06:53 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-2b708fa4093so9415553eec.0 for ; Sat, 07 Feb 2026 10:06:53 -0800 (PST) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b855c63152sm4002328eec.25.2026.02.07.10.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 10:06:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SGn9Dx9TKhYwyyq6cn6DSMXoUDg7D4YZd5UT23z4be8=; b=UPzu8Q3wpDgI26vz zbO24C9sDc4Gd+imdiPebjMx0n3khGuvoT1UkYo6y6jbMsL14bRgmuUgZA7JhS2L nyEcJqroAvDyWE1vMSyopde+tl6rUH+mmqOc9qe8inbHkc/+30wIdoVl4+nqB8R/ a9+bUbjtKhiR0J67JqcHM6Cp7/g0YldotKxwVcFe7I4vcEtX2eEK99PK/1fiFU8w ch71oqq1wig0ss2TrI1+o0o6bW8wYbN5dFpCzIRgblGnpDQ6r4NsBjPZLShR6T09 Uay9/hpebcylmTMXilb/4f0TiS+8m40sAKUbKtO44SzY6DY2fYW16CW6oRw5mpd1 XDQI8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770487613; x=1771092413; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SGn9Dx9TKhYwyyq6cn6DSMXoUDg7D4YZd5UT23z4be8=; b=g2iSfc1hWoVUCm+D7qiNk++SkQQOFK7v9Ql2LX8vT3tVIQL40M7jh19Xcw8KFpleVR borkWYzOikd6HeuhQtJnTbVeLAerGFM/OMRqZDHm1ydhEFx9yDK0Yt2CxA14jkuNKAHX e8keYbGillc/71mAlJgkRkwqV1MkIH+BwHaU6UscJdcJvfm0M3+b16/pNusfCsceYqmM 92rrvaQXAeaR5Z6qut8PQG+9FdrQF5j0NVGUG+WuiHh6D/3HNxLhH87S8XQyPX2JyZ9X hpEUpEr3cjuPpAwpW3il41xvS7oz9PvtMnpVWu8/YFk3u75ZN57FkB77+lXXpKKb0ZNE 46DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770487613; x=1771092413; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SGn9Dx9TKhYwyyq6cn6DSMXoUDg7D4YZd5UT23z4be8=; b=ivJDVSu/TEITVUolk5D3KVMWr4GvQuu/PEco1/HwWBec6p63UyxYxzLwK0JFnrjeia sp3SLVMdejOEMGa5H/JmHTsMPgSSrm2XWsMsql8incsLNsLdba5yTZhmqC/d2NNcpOBC +5tjm0gYpei+VdDMQXsXAQHmLjArUU4oDR9HUP9q9OsTn9nm1vaWZXQvlFLuhFPtNsWx WtE4bkmMhYY/do0cXnqWsxFvfKm14gCmoLcdjaelCOwlKILBP4OPWX2X/nhZcLgaKMkN dlXW6bOL1jvemVguz0nvvviHsCxgi6VyFPIHYZyL28ZHByR/p3CgfBkZ5ZdFYv6oJAYo U7nA== X-Gm-Message-State: AOJu0YyCJnbVHQE+Wsk05SO4KfD1i3cUOkOxSRpnm888g5+jjsHfF0wq siAmM6aRPLI2RvVyWqWL0Q8qmjxvAFcZUdZowfeeop9seX5QYfBW5BKA4mj5X8nnEbDfIhZX4cf QVkYtEjNHmp3031s771rSYkvg60PnsmZz2g4X0CwokEcP7SNSf96p1DF4GdKxk1/tjw== X-Gm-Gg: AZuq6aLMi0xp69EGnzN0zc4F/++lLDJFxE/bCZQkWUCmfVyGiEQlzhJeqIj7hk4gwpG 78vOSg4G3GAhwpBufDbYl5aaOy0wdmFJF2eeXVPTa8fqW47fCr7N666myzObfuiLbEiROo5sSYG dE2rRUstYvoWnFKBJSA1JsCPj59FnnJyyiZ/aLVX+YyQCeGRQheGF3MsWem8tOq2oXx6bvKzAxS toSooN494katJXO504d8Us7yovQ3Rop0OI8Wtc4bwmNAhRFUI96x4f/O8VjcZODtgPpL7CGfnvI mbj7kJu3OPeWVlZ/6QHd6QySpUfpVBiKoCQ5OO4Llt3disyNUlsTwz+CNRmiLJiiy9Qz1gMhI2d ubgMCutu4dtgL63erKAeQfZ/8UzGyHJ9TRLxhnqh1NzwOk+xRJ9XQTG3jqA== X-Received: by 2002:a05:7300:e82c:b0:2b8:26b8:3420 with SMTP id 5a478bee46e88-2b85646dfcfmr2996063eec.5.1770487612610; Sat, 07 Feb 2026 10:06:52 -0800 (PST) X-Received: by 2002:a05:7300:e82c:b0:2b8:26b8:3420 with SMTP id 5a478bee46e88-2b85646dfcfmr2996054eec.5.1770487612112; Sat, 07 Feb 2026 10:06:52 -0800 (PST) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex@alexrp.com, Pierrick Bouvier Subject: [PATCH v2 3/4] target/hexagon: Return decode failure for invalid non-duplex encodings Date: Sat, 7 Feb 2026 10:06:31 -0800 Message-Id: <20260207180632.1042754-4-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260207180632.1042754-1-brian.cain@oss.qualcomm.com> References: <20260207180632.1042754-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: Z-wkv2KEKX0WKULyRiwCpPmh3EaKlWbA X-Proofpoint-ORIG-GUID: Z-wkv2KEKX0WKULyRiwCpPmh3EaKlWbA X-Authority-Analysis: v=2.4 cv=F/tat6hN c=1 sm=1 tr=0 ts=69877f3d cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=D67r-eMCZ0zeLs--bqkA:9 a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA3MDE0OSBTYWx0ZWRfX6lgXRZnCwhgS kBmPD4GgCl8LumA7McuVW4f9LMD6BQoxSgG4bvYn25KyjzV2U3cvFjo/YYSiwaaaktztnlXOo/m sYzr+P7t2Q+t+H1Hh4lTr7Vvqxm6Fm3IuuvoYXt7CsyMwAjiVxNu/fnt+xt4WM6DrnVdiTCHKZ+ P2dK5KY0r3w3qY35DCLqYhU7JQEYsNh3xN6/CDT4AKuk/4C0zTv311viQhCixQVjjgBgYO2saif wMP60j6g9xsKj9zuRdk8uiZvjukXxg1B+NMjjNgp2W58dHKSJljeLjf8TGJHJEet4nV1XfPPfN3 P3ufz/TBwunoVJEbgQD2kXrseg5E7bCaE+LLyIA4tbKnG3/m40sw3hgrww4+4bDKNgp29Wu52Ma rqwQ/oumy8HxjQs2Lj6aLqItT6uRyyCv2UeZC9F3p7qG5v6DkaqJDNVI2RR5m1Fe1Gr+S5TL4YK +u1ACELAoUCFksRer1A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-06_05,2026-02-05_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602070149 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1770487675945154100 When a non-duplex encoding (parse_bits !=3D 0) fails both decode_normal() and decode_hvx(), the decoder hit an unreachable. Instead, handle the decode failure and raise an exception. Signed-off-by: Brian Cain Reviewed-by: Pierrick Bouvier Reviewed-by: Taylor Simpson --- target/hexagon/decode.c | 3 ++- tests/tcg/hexagon/invalid-encoding.c | 25 +++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c index 90499fc320..ebb4e02a17 100644 --- a/target/hexagon/decode.c +++ b/target/hexagon/decode.c @@ -489,7 +489,8 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t en= coding) insn->iclass =3D iclass_bits(encoding); return 1; } - g_assert_not_reached(); + /* Invalid non-duplex encoding */ + return 0; } else { uint32_t iclass =3D get_duplex_iclass(encoding); unsigned int slot0_subinsn =3D get_slot0_subinsn(encoding); diff --git a/tests/tcg/hexagon/invalid-encoding.c b/tests/tcg/hexagon/inval= id-encoding.c index 1bbd312b61..040a7d9147 100644 --- a/tests/tcg/hexagon/invalid-encoding.c +++ b/tests/tcg/hexagon/invalid-encoding.c @@ -93,6 +93,30 @@ static int test_invalid_dups(void) return sig; } =20 +/* + * Invalid non-duplex encoding: + * The encoding 0xffffc000 has parse bits [15:14] =3D 0b11, making it a + * non-duplex instruction and packet end. The remaining bits do not match + * any valid normal or HVX instruction encoding, so this should raise SIGI= LL. + */ +static int test_invalid_nonduplex(void) +{ + int sig; + + asm volatile( + "r0 =3D #0\n" + "r1 =3D ##1f\n" + "memw(%1) =3D r1\n" + ".word 0xffffc000\n" + "1:\n" + "%0 =3D r0\n" + : "=3Dr"(sig) + : "r"(&resume_pc) + : "r0", "r1", "memory"); + + return sig; +} + int main() { struct sigaction act; @@ -104,6 +128,7 @@ int main() =20 assert(test_invalid_duplex() =3D=3D SIGILL); assert(test_invalid_dups() =3D=3D SIGILL); + assert(test_invalid_nonduplex() =3D=3D SIGILL); =20 puts("PASS"); return EXIT_SUCCESS; --=20 2.34.1