From nobody Mon Feb 9 07:42:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770402032; cv=none; d=zohomail.com; s=zohoarc; b=Kf1mktCFZSxztCi3KQs3S5inQBlDcy8NPc+9uMOPy7nuf3LXdpq8RxbsRQPAJ0WiENyowYmOUHRFltUQ4FWKb9A8o/ws1+gJ9iGriP3kbcUiQFKkzuqzOh3Sk2oKaGJeWZ21gSq2Rr1DbP380l9XpoO60l3fwdnXY/kIZfHXD3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770402032; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=m0XJalfC5IqgU2W7JDKFGQzzc/v7gEN8vJtThzS7KrY=; b=IzK78WQA+G37KeUwgkfe9/8POiGt3H1k3XeNt0Hslz0N+2f2gX8FkCuFjU8v8+WaYsoVlxGRZgnmhoIRdky1g6ANvnrMHfhprK7n3pQ/eNBLT/7FKxoIR4EPTWSwkZbw7edoBuEFCgHo8BPF5Bu4W63L8awJsg6rcdReS9lTQX4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770402032879211.40950104335718; Fri, 6 Feb 2026 10:20:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1voQR9-0007Oi-B8; Fri, 06 Feb 2026 13:20:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1voQR7-0007OE-Ic for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:09 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1voQR5-0004fi-EJ for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:08 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-47f5c2283b6so22007825e9.1 for ; Fri, 06 Feb 2026 10:20:06 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483209c1a64sm23607335e9.12.2026.02.06.10.20.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Feb 2026 10:20:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770402004; x=1771006804; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m0XJalfC5IqgU2W7JDKFGQzzc/v7gEN8vJtThzS7KrY=; b=aN2kvCyZgUXK2hvw4PyfahCtC4h2v5FF7L0peT0HcML0aoRdtZCmTixNrzc6WLrIlg A4qNm5F88ewY8OWkWvmgeN6ctbxpcL0l+V6iUu2XLn3rsaI1gK5+dFgMz6hkiizLWa9G hsnEJDbEWXTNSr64LTjNc0c2jeWq4T3eW3Xy231gDzyX1lqkIKnkxp2J3wpI9UABqhDC qPMYJPD3/tJF+9S7O570c5bugb++jygFxLovDAvRql1OTqxW39LG76JJknPTcip/wsDe JW8mU8e+ZSWjBbsoWByd9jEOba0totOAoPNb14lGFQALn0r3kfgJpxqFD+97HmVxzrjs eRKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770402004; x=1771006804; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=m0XJalfC5IqgU2W7JDKFGQzzc/v7gEN8vJtThzS7KrY=; b=vuhguFbAWRGqLMxzqGUh3lBiRxuXGP9icQlowGnP97cE4IXMzDPs3A26UWGPskd2N7 byH6VsVGiiYoFW1iuwBBgsg51z7lDNANKiB71ygfCq9oQVGilkUvKF8zuyZGRvwaQRyu Vfvy4b4PlD6TUCS04NOPApIM5BOj14WweC1t9g0HZngNcuOj1ILK0AIq8mxpQ+41HNDp HlbFAROvMEtUEE7k8NH7dG20Pta9xBQh1bEp3HbpV6YZyKYO+2uwZE8v1GRIOyR8HgGc KMMgvDQSbTsOnZLTkU98PMkltLnz1pcXZrPcZnVjS77Z008Ovha86GgnUjqH7HAFsD6u ikpw== X-Gm-Message-State: AOJu0Yx8SqZQvWssiggcaZkA69QtPpzfwHLrIKMJZBelAUZu0kf8pN2y pN9BQuRm69svKv+H2PcpWnqiLs2AzYWw94uVt/OgA7KK4Iq1WOyaFln8XGnpad95r0x7z2hLOZk fJxWgaDA= X-Gm-Gg: AZuq6aLup0Efkc5QFMANMismZkZzvUCPbrp4TJE7Gx+Xpfp3abfjJSlE27tQXdS4PUE 05/hWXSSA95nhCRdJqeQOl7XZqUYVtgSwha+ukD/SzKPUwDoWgbrR1kW1aktHmCqSEL3eu05q/0 d7kxmCe1kQb2FJq5ly9EE6EYfywIxRsFvHixtM2Wx2jf3VvadYHmy8VNQmcH1KtjQIHKHKqtBKm 9Fg9dJqwNLtMy9kXptK56dQ4d0GWvbtZHyOW4fQGYbudWXK99zB0rbMczclMN2ScIoUOwGEk/3+ za+S5VBTesQ2D2RZHLZv+VBh4IqnTX+icB8w5wyNAge+AXt4hzlsK2ErHViNTyI8w38g4PgGa1x 3wLCS2MHdYMKnvxLMIt2+WB1G29pEz3dbEKKykeulWWhqD6jP2bw6ocL7vnnfsp45CnUhgvblFV hqT9wLwihs85LCKHDF9lPPQnJ7aBvgYI9U9CmK+1wSDVl6GMQufeYfQT4X05YhiAnH+0FOZk8= X-Received: by 2002:a05:600c:6289:b0:47d:18b0:bb9a with SMTP id 5b1f17b1804b1-483203393b7mr60222085e9.33.1770402004199; Fri, 06 Feb 2026 10:20:04 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Matthew Rosato , Thomas Huth , qemu-s390x@nongnu.org, Ilya Leoshkevich , Halil Pasic , Richard Henderson , Christian Borntraeger , Eric Farman , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 01/10] target/s390x: Use address_space_ldl_be() in read_table_entry() Date: Fri, 6 Feb 2026 19:19:44 +0100 Message-ID: <20260206181953.18683-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206181953.18683-1-philmd@linaro.org> References: <20260206181953.18683-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770402033792158500 address_space_read/write() is meant for accessing random amount of memory blobs. When the access size is known, use the address_space_ld/st() API which can directly swap endianness. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Eric Farman --- target/s390x/mmu_helper.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 026502a3e40..30f09ec3de4 100644 --- a/target/s390x/mmu_helper.c +++ b/target/s390x/mmu_helper.c @@ -108,6 +108,7 @@ static inline bool read_table_entry(CPUS390XState *env,= hwaddr gaddr, uint64_t *entry) { CPUState *cs =3D env_cpu(env); + MemTxResult ret; =20 /* * According to the PoP, these table addresses are "unpredictably real @@ -116,13 +117,9 @@ static inline bool read_table_entry(CPUS390XState *env= , hwaddr gaddr, * * We treat them as absolute addresses and don't wrap them. */ - if (unlikely(address_space_read(cs->as, gaddr, MEMTXATTRS_UNSPECIFIED, - entry, sizeof(*entry)) !=3D - MEMTX_OK)) { - return false; - } - *entry =3D be64_to_cpu(*entry); - return true; + *entry =3D address_space_ldq_be(cs->as, gaddr, MEMTXATTRS_UNSPECIFIED,= &ret); + + return ret =3D=3D MEMTX_OK; } =20 static int mmu_translate_asce(CPUS390XState *env, target_ulong vaddr, --=20 2.52.0 From nobody Mon Feb 9 07:42:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770402032; cv=none; d=zohomail.com; s=zohoarc; b=EnETXuaYNnV7taDcrppn87dx8E/btQQhHCGsw/eq1yYMrce0PZN2udXJovls85t/+JnuRqKAS8vBNyKBwjU1eJT4rBdIwkUGd1ZQyv9vp7z2r0fKvjXEc+OHRMhNG4CpNHueZnT9jBD+K98uUUOczKVkV2v9nyncrexhSVrDXwo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770402032; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UimlxoJjON/bhMTscr34JsqLf8392tVb5tXpZcah2yY=; b=IiK4+5CqDsSHFS9SQUo0Rc25yZyjlYlzcQjQWvtLQU4+qR7E+r4c5XxdoGm+boRW9sAFkKJpTbUYbLlul5HQtKBO/d8b4vmsR5IQoeve6/gYX0w7nYQ8gBTm67zaq4XHN2v7qTgx0K4rJapte/Pod/S8HVXxX4ykJI+TW7YSQDo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770402032752449.1927275722744; Fri, 6 Feb 2026 10:20:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1voQRF-0007R3-Iq; Fri, 06 Feb 2026 13:20:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1voQRD-0007PQ-Q4 for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:15 -0500 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1voQRC-0004nc-8K for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:15 -0500 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-43629377370so1120466f8f.3 for ; Fri, 06 Feb 2026 10:20:13 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4362974b176sm7022248f8f.37.2026.02.06.10.20.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Feb 2026 10:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770402012; x=1771006812; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UimlxoJjON/bhMTscr34JsqLf8392tVb5tXpZcah2yY=; b=EiDnOZDJC/CwGqpWtC0NLNZJ2gOTpcf4QfWaKiwCMB9Cvs7hMiQcDawKSRYq3PJCcN 66OYSqEXfA4Elb3kT/8MYzH55FAbOA/Hg8kcld5rXd/c78YGNvohP7ce0HuwG1G14YzP fXilY5pyGhdVpR4v5P6ImbG8+VLqLnpg5EFUKLOyXuOk1jefoLR9vpxu8TVSJD7wJEAq UVL6mnBsRtptdcM8PAMCC97KebgQVvmKXgrH8T2sduVwxy8QAfuRuv9UFnX5kudVQ9Ei uSs2e94UmmgwV0G//p8HgRaZDd1gA+iXTQhJP3XKP+tYNY6A7VgMIg1Im8QSKHp9rYCL Ciqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770402012; x=1771006812; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UimlxoJjON/bhMTscr34JsqLf8392tVb5tXpZcah2yY=; b=KFREZPyfJlaqvXdlLFSVvRwCNHxJbKxFbVo8Z+SweOmg4GYWpwPNxsuN51PX1w1y7f aZ8TnHjMvg7WUmhyFGTAavswH0W4YLjIPvI0HBXEbtI+e13KeKd7GIejy+l/t5vYQQS6 QyzC9aBTQdABwniZG/hAVXcsLZYtz7fqcC8cMPN8iWTXYoRRukkknQY1XyncRUY1dZ5V WlAg64h7B9qpShokX253RxH8KrPDKbPLsyMEKMkiCpY+GZuRLZyyP53nejMUzYfHf0io pLHFRPHB3RUAay21FK1qczePhd/sv8L457Aoe8APYGzDqE/ziFEt7iVQUuT1NhhgvRvh hXaA== X-Gm-Message-State: AOJu0Yy15y+r6QiHesW3ls1N9f7cZwoQfQo+6SieVSo1xkmbFJUJ8OuB e1RquwcSW5THBTwTyLmeXZIT1VOx8WP91SAwund0N/KLuWikpXnY2gRZu/yUntJrl7JN9XOLdjO uIvNSk7s= X-Gm-Gg: AZuq6aIalVAU4iPXaisamUbjQ/Ngv2vlGwT/uaFGZ3c9r8p9xj3ChvmG93pnywSUMim nIlOAtK8Mnj21/4TpNFfst41oBiBWGJRaAqgkrnQ4/LHC1mHvhJbwfO+EkzfzvRU6ZTVpee3aNL C35P0MFqBbXiT4qIffghCMUZLNTrrdHIaAeQhPLPcD8/q6nFtADkac8Wvonq+5I/xxlMbK+UvoZ iQUHusId+FSzxkx4+t+/FPdE7YVhHjPkN97SOcsah4dI+IHnXP365FcDfiXPei2EJ5POthFNE9X zzvyRLZ4opHuyj0bfgvBw/zce9SFwiY7XMO8b1IiQoA4M6UppfHKf8XuKCjOWve/RJR2ZLzY01y au6MwDpZUFBVq5wrscOkxTyZMiEISjdKnMV8ShubkUm+QNyAnkba1K3OJjAh9Dy7LUJIDNz61o0 qtrlPVSyYFk0AuZAP+5xd5ywMWWJth2tOTEXCUnrF3BLTrOmqNpdaSmalrWBwr X-Received: by 2002:a05:6000:2311:b0:436:18e5:48 with SMTP id ffacd0b85a97d-43629341c55mr5755737f8f.15.1770402011684; Fri, 06 Feb 2026 10:20:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Matthew Rosato , Thomas Huth , qemu-s390x@nongnu.org, Ilya Leoshkevich , Halil Pasic , Richard Henderson , Christian Borntraeger , Eric Farman , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 02/10] target/s390x: Rename get_phys_page_debug() @vaddr argument as @v_addr Date: Fri, 6 Feb 2026 19:19:45 +0100 Message-ID: <20260206181953.18683-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206181953.18683-1-philmd@linaro.org> References: <20260206181953.18683-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770402033979154100 In order to use the %vaddr type in s390_cpu_get_phys_page_debug() in the next commit, rename the argument @vaddr -> @v_addr. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- target/s390x/helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/helper.c b/target/s390x/helper.c index a6c89ed0af3..d0c36d4a537 100644 --- a/target/s390x/helper.c +++ b/target/s390x/helper.c @@ -68,14 +68,14 @@ hwaddr s390_cpu_get_phys_page_debug(CPUState *cs, vaddr= vaddr) return raddr; } =20 -hwaddr s390_cpu_get_phys_addr_debug(CPUState *cs, vaddr vaddr) +hwaddr s390_cpu_get_phys_addr_debug(CPUState *cs, vaddr v_addr) { hwaddr phys_addr; target_ulong page; =20 - page =3D vaddr & TARGET_PAGE_MASK; + page =3D v_addr & TARGET_PAGE_MASK; phys_addr =3D cpu_get_phys_page_debug(cs, page); - phys_addr +=3D (vaddr & ~TARGET_PAGE_MASK); + phys_addr +=3D (v_addr & ~TARGET_PAGE_MASK); =20 return phys_addr; } --=20 2.52.0 From nobody Mon Feb 9 07:42:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770402067; cv=none; d=zohomail.com; s=zohoarc; b=Py94xSPkAXBAOnE2TD5vCmlysMix0EiCWd2/PFFSSLPTZC2tiKiqyzRiFI6LacUNFwG2MuJTTPdgN75vLocRg/N0Cf4lvlAtUo4ITVGeigj+LvXfCfnUZUjHTqivLWwLwcIzO3KwyXRXfYR0/rgvj7lpPCHrXO9EhwfluZekQcg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770402067; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rrcCkInJZLGHoUCMjS3h9A+VC+3ccU1K0/TSYxS+ucA=; b=ko9uPpHe1g/hExlTKh2XFmguhyFN/wyqStJx7+JXAVzHPfoNOngFu3VuVdq62P598Id93oXUQczVRp2S4URHFm6sX/Yzb5PDeJe3c2nTzTg2XHDXjPH7UCBtuNRLHkpCaE6fCP11z1alcjjGHX36JSN4GvGgvntgMDEMxTmmO4g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770402067227334.3114593746719; Fri, 6 Feb 2026 10:21:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1voQRN-0007TL-15; Fri, 06 Feb 2026 13:20:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1voQRM-0007Sm-2g for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:24 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1voQRK-0004vP-KE for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:23 -0500 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-48069a48629so22177345e9.0 for ; Fri, 06 Feb 2026 10:20:22 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483209c1a64sm23611385e9.12.2026.02.06.10.20.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Feb 2026 10:20:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770402020; x=1771006820; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rrcCkInJZLGHoUCMjS3h9A+VC+3ccU1K0/TSYxS+ucA=; b=x30mEBdOBMqbmkrHP35i63U1hd8ckNXO1UdrWRSx1Abp82BfotajZHmQfcPaHWuGJ+ zv24IVxZuKfM3InlZkQTWls+PsDSAzjC1NI2vVV4tQiKcOmUs2ZebA/UbdvlbXa0jysB XbDEgrgT97sq1Ldw2toPdAihy7SRf8jRpMs0t6QsPYbhHBpTyfAROwXqp6X0TneI9L1G yK7bzlxHKYCrQPzcXPkRhC+7/f+xkNRbIpqvob2gNk9JeLKsu8tgSqXReS3rEMtuv/LC wAq3dCz01mTxlTkMVXslzPKhz4IAKTuWJnSrxcw6w2LiQtm/PFanKvWOi5EA2njZqjYz 4R0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770402020; x=1771006820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rrcCkInJZLGHoUCMjS3h9A+VC+3ccU1K0/TSYxS+ucA=; b=tqDPQL+TGvPZJyh8hzyAOU7Xsd79msqVisFs8A7IDLztMQznwc6bUpC5XD9muawJ9e 5kMV9eXiE0HwOGSSALeOyrLsv6Hf3CA2PMavRWqji/Ch64EqivdcEmjPphD+hhJ9lxeh +6q0Nx4v5SgzpphngZlEu6ojn0Tfbf2pjha1xIF0cy34RsAZhkdK2naSBdwSD+4hGa5A mTYnKgvCAy6Bv+TorpyghrIUJ4wlxK93y2wVZUgkoF32AEUIcubIUFZzqm8KDwT6Cpd9 I/gLJHFPxdCzdjhIqzhnZYMZBkZ3eW9Og+zQVww700kKEdrg7cdsgkCti3esXCb+wocQ TjrA== X-Gm-Message-State: AOJu0YwejHnyOZ5fzzAw69J7f41Lp5MqsMSZQVcrKqR7pyC0fSjvfUu9 PqeNeUjnga+Um0tklQ5krvfWH1vGzVsqHlXckNb1CNj+BP7KAuCzD+iC2999yqbfTl43xIvYv5P TxqtBdTg= X-Gm-Gg: AZuq6aKFmVbxQTiwG2TxMssJJibXAySHHi8HEfQXegEx4D1NdlTE0MM1IC/nxHdTQRr GAz+gSuSmKLYHLWfjIhhEmt8fQsdxB08I/4KUKrUlUab1SIVpNrv5J1/y5AXV/lW5A1xzWx5l/Y mHjAwVqSREgtIzMFMYtNUfLbyhSoq2rWXZza4AA1Af5h40VnNVsuzoQm0gsXxkFNz0mKiDxMoux m+nd0OqsqBC37SY/pghbKzEQyLxlIBNYd4LOC9HFr65K02F1gG0HCWmviboQRiFyYCGEYxvUEv9 3JUt2cAkR990pDXqTycHUuNmvwY+SEM7Kh5/wapAxUXrgX3LaurRbv1bmJRqJsYE6pnnpQIXn7t AVFxF6Jqav89XqejeFOUM9EFz+zWmlfg+UFmqXIvacTHYxiLHk8UvY+Py33rq4D7TTI+k2CTFqq qS/oXOT1NvMB3x9KzWBh3ay6MkfbDal7ZrnF3vXa1BfzWk92tovLvZvftPJJ02 X-Received: by 2002:a05:600c:3d96:b0:47e:e20e:bbbe with SMTP id 5b1f17b1804b1-4832021eaa9mr56311165e9.25.1770402019725; Fri, 06 Feb 2026 10:20:19 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Matthew Rosato , Thomas Huth , qemu-s390x@nongnu.org, Ilya Leoshkevich , Halil Pasic , Richard Henderson , Christian Borntraeger , Eric Farman , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 03/10] target/s390x: Replace %target_ulong -> %vaddr where appropriate Date: Fri, 6 Feb 2026 19:19:46 +0100 Message-ID: <20260206181953.18683-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206181953.18683-1-philmd@linaro.org> References: <20260206181953.18683-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770402067905158501 Use the %vaddr type for virtual addresses. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- target/s390x/s390x-internal.h | 3 ++- target/s390x/helper.c | 2 +- target/s390x/mmu_helper.c | 4 ++-- target/s390x/tcg/excp_helper.c | 3 ++- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/target/s390x/s390x-internal.h b/target/s390x/s390x-internal.h index a4b54dc441c..31e164c9b5a 100644 --- a/target/s390x/s390x-internal.h +++ b/target/s390x/s390x-internal.h @@ -10,6 +10,7 @@ #ifndef S390X_INTERNAL_H #define S390X_INTERNAL_H =20 +#include "exec/vaddr.h" #include "cpu.h" #include "fpu/softfloat.h" =20 @@ -376,7 +377,7 @@ void probe_write_access(CPUS390XState *env, uint64_t ad= dr, uint64_t len, bool mmu_absolute_addr_valid(target_ulong addr, bool is_write); /* Special access mode only valid for mmu_translate() */ #define MMU_S390_LRA -1 -int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t= asc, +int mmu_translate(CPUS390XState *env, vaddr vaddr, int rw, uint64_t asc, target_ulong *raddr, int *flags, uint64_t *tec); int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw, target_ulong *addr, int *flags, uint64_t *tec); diff --git a/target/s390x/helper.c b/target/s390x/helper.c index d0c36d4a537..5002eebd4c8 100644 --- a/target/s390x/helper.c +++ b/target/s390x/helper.c @@ -71,7 +71,7 @@ hwaddr s390_cpu_get_phys_page_debug(CPUState *cs, vaddr v= addr) hwaddr s390_cpu_get_phys_addr_debug(CPUState *cs, vaddr v_addr) { hwaddr phys_addr; - target_ulong page; + vaddr page; =20 page =3D v_addr & TARGET_PAGE_MASK; phys_addr =3D cpu_get_phys_page_debug(cs, page); diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 30f09ec3de4..39ff42da3a3 100644 --- a/target/s390x/mmu_helper.c +++ b/target/s390x/mmu_helper.c @@ -122,7 +122,7 @@ static inline bool read_table_entry(CPUS390XState *env,= hwaddr gaddr, return ret =3D=3D MEMTX_OK; } =20 -static int mmu_translate_asce(CPUS390XState *env, target_ulong vaddr, +static int mmu_translate_asce(CPUS390XState *env, vaddr vaddr, uint64_t asc, uint64_t asce, target_ulong *r= addr, int *flags) { @@ -381,7 +381,7 @@ static void mmu_handle_skey(target_ulong addr, int rw, = int *flags) * there is an exception to raise * @return 0 =3D success, !=3D 0, the exception to raise */ -int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t= asc, +int mmu_translate(CPUS390XState *env, vaddr vaddr, int rw, uint64_t asc, target_ulong *raddr, int *flags, uint64_t *tec) { uint64_t asce; diff --git a/target/s390x/tcg/excp_helper.c b/target/s390x/tcg/excp_helper.c index 019eb4fba1f..292d130d03e 100644 --- a/target/s390x/tcg/excp_helper.c +++ b/target/s390x/tcg/excp_helper.c @@ -147,7 +147,8 @@ bool s390_cpu_tlb_fill(CPUState *cs, vaddr address, int= size, bool probe, uintptr_t retaddr) { CPUS390XState *env =3D cpu_env(cs); - target_ulong vaddr, raddr; + vaddr vaddr; + target_ulong raddr; uint64_t asc, tec; int prot, excp; =20 --=20 2.52.0 From nobody Mon Feb 9 07:42:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770402059; cv=none; d=zohomail.com; s=zohoarc; b=EsOWIErcdEnJmz/KuWbrsI+WvebHTbOn7TMutQCROCvyoylgcm29uesfhZ5k5RAzzFQ0eaUdmCdiVE+02qcQwguv+ORf0XZFSGrlGT0IWPPRWHrHeL8tgrOCpS5MxcLvwnDqweWnquKL73xhk9aIpxLcAuQu/4Inke2/Z55MNcE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770402059; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hm5LupeYW8woLNSFE3LFbKwgMdrgARqYR+v21ecrNOY=; b=alTgH+wxeEE/uUaO3EmDdCYro5tZm6OhnGTEGcR0Wvqz0goBHjh3ydkkQIyKKe/8SJBhvM2/6To3rnd8aBNpS7hdtJYju9dDCbNTr7r/76ZOIHfOzAJNpG/wX9xLbyssn4oyl9ZhkHKxxbIFYovoOBh8m08QPqIqQyXoHDr2QaQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770402059062287.4905319991693; Fri, 6 Feb 2026 10:20:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1voQRU-0007Zg-VA; Fri, 06 Feb 2026 13:20:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1voQRU-0007VJ-26 for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:32 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1voQRS-0004wR-11 for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:31 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-436317c80f7so143440f8f.1 for ; Fri, 06 Feb 2026 10:20:29 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4362972fb16sm7612199f8f.25.2026.02.06.10.20.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Feb 2026 10:20:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770402028; x=1771006828; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hm5LupeYW8woLNSFE3LFbKwgMdrgARqYR+v21ecrNOY=; b=S5E/0nfXezOXj1qQLQj5lIkNbhCLRZHeFwxsi/4Qqo6sRBvxngmZrb728YBI53SXtY li0qPNlmDRas/7AF5wGf+0LNaoCAGGXRkWyTrWjoiPb+45O/X8v/EHDzfK3+QxvBpJOn O8gsD3LFM+JVlikOwHRVPvXsowvlMDNhcepO8uggMiT2nhqLGWCtB4j2SjSdI0kFPwIh pxr2oV++iq9IZPXdG7Ey5ezyq1rvuBtOSmID/IVBcnLTz+jq1aIo3iMK+Ior5U51uRAJ cfGymdPUDsrWqFNv5aOXcw/FpvmuI1XbAp6FTlfk/7PKp02Yq3/H4p/WIvwAqTb6RZub IQwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770402028; x=1771006828; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hm5LupeYW8woLNSFE3LFbKwgMdrgARqYR+v21ecrNOY=; b=qGKrmIDKkv0AZwqIj9iJtzr+9SZiB76/rewnyeaxgKgWCTB5SZqvGb4bteeUrVfDmz 1YQSSAGPlfL7GPtQykypMiABqO4vQMGlqNEkL4pwf5GE+enxYse4dCLeXm8Dn0t8Vchb p10VLVVb7a0l/U37yFUrN0oko0xjBtQi74JlNBmR97KKnMJHvW+vcAwYkAuFqHpfQ/7z /n56UjMdS08eOPwRtOCrpz/DiYS2ZaMo5X4ePby4rXJ6TO0KGdRX6uGusL5oryj/HZww VGrLnJVe0Ym6b5RdDj0MEB3RyCM7LYN6+9of8f3Z/2scpy11eD04jNl/UEdMu0uMphYK mK9w== X-Gm-Message-State: AOJu0YwF3WNoImh4Cox6lHCb4XUguSafhFG10qzhWhmyImhB/INkJ85V j2N0Thok317pqx6asMHR0tQ9lMJtTOL9AWq4uyTPTG0k8BsYDEbi9oJ8qjee+TdGmkawFtf47pX 5N+EfGtQ= X-Gm-Gg: AZuq6aLe3IYmL+t0+5uz+o+JbM67hxIIAMDY9pmAUDJf7scxQMdsshOJLxgZY8A6SJM rDCo9FsUtQ47HLCNfjFcpQx4b1MTcGTrDm0cIEl/Sz6K9hoKnE5vX/GPSRuAiogRZyw27WJgANB muykvQGE9Ulb8/w1HVDVreph8wzhomAZn9Bo22PP1sb1PYsdZzHGlTr0mb5fO+2rf36b9lePgF6 GDyCLxQYRzz2A+eL3ok8JEvkVEsn4BG0wZzAcRTPKvw0bLun6Gr9KRLHeocNElQVDNozDBmstxd DIE6NZEQcWQhPGgqI4eYNsfCtMx5qvKoPqMXVhHCOA8xM6ULBCAUGSffIOS0Cc+RyfDbRI1VzQF 0da5uh0C1FBY0VhDiz/qbJk8X8qV28txzYo1z6CtOo0mi6doHnmj3XPMmVS3zTsyz0zZg+sTNAm 0vsrd92qF9uv0sNmy55S+aRUXKtKdf/gPL7mobjPyRndtxn2LYTfUWHMTJM/IC X-Received: by 2002:a05:6000:4284:b0:435:9538:939b with SMTP id ffacd0b85a97d-4362903c2acmr5623925f8f.8.1770402027672; Fri, 06 Feb 2026 10:20:27 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Matthew Rosato , Thomas Huth , qemu-s390x@nongnu.org, Ilya Leoshkevich , Halil Pasic , Richard Henderson , Christian Borntraeger , Eric Farman , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 04/10] target/s390x: Replace %target_ulong -> %hwaddr where appropriate Date: Fri, 6 Feb 2026 19:19:47 +0100 Message-ID: <20260206181953.18683-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206181953.18683-1-philmd@linaro.org> References: <20260206181953.18683-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770402059924158500 Use the %hwaddr type for physical addresses. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- target/s390x/s390x-internal.h | 11 ++++++----- target/s390x/helper.c | 2 +- target/s390x/mmu_helper.c | 18 +++++++++--------- target/s390x/tcg/excp_helper.c | 2 +- 4 files changed, 17 insertions(+), 16 deletions(-) diff --git a/target/s390x/s390x-internal.h b/target/s390x/s390x-internal.h index 31e164c9b5a..40850bcdc45 100644 --- a/target/s390x/s390x-internal.h +++ b/target/s390x/s390x-internal.h @@ -10,6 +10,7 @@ #ifndef S390X_INTERNAL_H #define S390X_INTERNAL_H =20 +#include "exec/hwaddr.h" #include "exec/vaddr.h" #include "cpu.h" #include "fpu/softfloat.h" @@ -368,19 +369,19 @@ void ioinst_handle_sal(S390CPU *cpu, uint64_t reg1, u= intptr_t ra); =20 =20 /* mem_helper.c */ -target_ulong mmu_real2abs(CPUS390XState *env, target_ulong raddr); void probe_write_access(CPUS390XState *env, uint64_t addr, uint64_t len, uintptr_t ra); =20 =20 /* mmu_helper.c */ -bool mmu_absolute_addr_valid(target_ulong addr, bool is_write); +hwaddr mmu_real2abs(CPUS390XState *env, hwaddr raddr); +bool mmu_absolute_addr_valid(hwaddr addr, bool is_write); /* Special access mode only valid for mmu_translate() */ #define MMU_S390_LRA -1 int mmu_translate(CPUS390XState *env, vaddr vaddr, int rw, uint64_t asc, - target_ulong *raddr, int *flags, uint64_t *tec); -int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw, - target_ulong *addr, int *flags, uint64_t *tec); + hwaddr *raddr, int *flags, uint64_t *tec); +int mmu_translate_real(CPUS390XState *env, hwaddr raddr, int rw, + hwaddr *addr, int *flags, uint64_t *tec); =20 =20 /* misc_helper.c */ diff --git a/target/s390x/helper.c b/target/s390x/helper.c index 5002eebd4c8..667d4a0da75 100644 --- a/target/s390x/helper.c +++ b/target/s390x/helper.c @@ -43,7 +43,7 @@ hwaddr s390_cpu_get_phys_page_debug(CPUState *cs, vaddr v= addr) { S390CPU *cpu =3D S390_CPU(cs); CPUS390XState *env =3D &cpu->env; - target_ulong raddr; + hwaddr raddr; int prot; uint64_t asc =3D env->psw.mask & PSW_MASK_ASC; uint64_t tec; diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 39ff42da3a3..246573ff642 100644 --- a/target/s390x/mmu_helper.c +++ b/target/s390x/mmu_helper.c @@ -86,7 +86,7 @@ static bool lowprot_enabled(const CPUS390XState *env, uin= t64_t asc) * Translate real address to absolute (=3D physical) * address by taking care of the prefix mapping. */ -target_ulong mmu_real2abs(CPUS390XState *env, target_ulong raddr) +hwaddr mmu_real2abs(CPUS390XState *env, hwaddr raddr) { if (raddr < 0x2000) { return raddr + env->psa; /* Map the lowcore. */ @@ -96,7 +96,7 @@ target_ulong mmu_real2abs(CPUS390XState *env, target_ulon= g raddr) return raddr; } =20 -bool mmu_absolute_addr_valid(target_ulong addr, bool is_write) +bool mmu_absolute_addr_valid(hwaddr addr, bool is_write) { return address_space_access_valid(&address_space_memory, addr & TARGET_PAGE_MASK, @@ -123,7 +123,7 @@ static inline bool read_table_entry(CPUS390XState *env,= hwaddr gaddr, } =20 static int mmu_translate_asce(CPUS390XState *env, vaddr vaddr, - uint64_t asc, uint64_t asce, target_ulong *r= addr, + uint64_t asc, uint64_t asce, hwaddr *raddr, int *flags) { const bool edat1 =3D (env->cregs[0] & CR0_EDAT) && @@ -296,7 +296,7 @@ static int mmu_translate_asce(CPUS390XState *env, vaddr= vaddr, return 0; } =20 -static void mmu_handle_skey(target_ulong addr, int rw, int *flags) +static void mmu_handle_skey(hwaddr addr, int rw, int *flags) { static S390SKeysClass *skeyclass; static S390SKeysState *ss; @@ -382,7 +382,7 @@ static void mmu_handle_skey(target_ulong addr, int rw, = int *flags) * @return 0 =3D success, !=3D 0, the exception to raise */ int mmu_translate(CPUS390XState *env, vaddr vaddr, int rw, uint64_t asc, - target_ulong *raddr, int *flags, uint64_t *tec) + hwaddr *raddr, int *flags, uint64_t *tec) { uint64_t asce; int r; @@ -472,7 +472,7 @@ nodat: * the MEMOP interface. */ static int translate_pages(S390CPU *cpu, vaddr addr, int nr_pages, - target_ulong *pages, bool is_write, uint64_t *t= ec) + hwaddr *pages, bool is_write, uint64_t *tec) { uint64_t asc =3D cpu->env.psw.mask & PSW_MASK_ASC; CPUS390XState *env =3D &cpu->env; @@ -523,7 +523,7 @@ int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uin= t8_t ar, void *hostbuf, { const MemTxAttrs attrs =3D MEMTXATTRS_UNSPECIFIED; int currlen, nr_pages, i; - target_ulong *pages; + hwaddr *pages; uint64_t tec; int ret; =20 @@ -584,8 +584,8 @@ void s390_cpu_virt_mem_handle_exc(S390CPU *cpu, uintptr= _t ra) * @param flags the PAGE_READ/WRITE/EXEC flags are stored to this pointer * @return 0 =3D success, !=3D 0, the exception to raise */ -int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw, - target_ulong *addr, int *flags, uint64_t *tec) +int mmu_translate_real(CPUS390XState *env, hwaddr raddr, int rw, + hwaddr *addr, int *flags, uint64_t *tec) { const bool lowprot_enabled =3D env->cregs[0] & CR0_LOWPROT; =20 diff --git a/target/s390x/tcg/excp_helper.c b/target/s390x/tcg/excp_helper.c index 292d130d03e..41b0017d767 100644 --- a/target/s390x/tcg/excp_helper.c +++ b/target/s390x/tcg/excp_helper.c @@ -148,7 +148,7 @@ bool s390_cpu_tlb_fill(CPUState *cs, vaddr address, int= size, { CPUS390XState *env =3D cpu_env(cs); vaddr vaddr; - target_ulong raddr; + hwaddr raddr; uint64_t asc, tec; int prot, excp; =20 --=20 2.52.0 From nobody Mon Feb 9 07:42:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770402066; cv=none; d=zohomail.com; s=zohoarc; b=m7jb9tGZ9cBnXYaY1dQ29i2ZwT/BHXHUI9yb70DX6jF2+ArcG0Y92v/UPbI0xWtp+ugp5o6Kk3TKzCjyrNKwG0Wh6prGkfklWBkjWE3hdxzDqY1Qmb/K7y0cTDa/KCdDcUi+UJsCOHQIUXjCu8YAlF4cU4wjxqTTdGYk4L6BvX4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770402066; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2LK8trtLyNSo6IVxA5K1xN9ZysZ5E29etqSmlwZuT3o=; b=K4Foxc8XvbASC1VNsIaqSmAwO5W5K9oisRpHn6JHjGNN915xqf1BSI1NZDcJN7y4uyik8+lzbjpDBk8ROdqzEglPJw7QQdmdRCrbMLD7jW/g3K+EH0G89512zBbUmohuuJz42cgkvdI7TIwXS+XYWcDlSOkWTkEuk34p0OHPedw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770402066903197.1015977160481; Fri, 6 Feb 2026 10:21:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1voQRd-0007fS-6Y; Fri, 06 Feb 2026 13:20:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1voQRb-0007eY-2W for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:39 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1voQRZ-00051j-IL for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:38 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4807068eacbso22901565e9.2 for ; Fri, 06 Feb 2026 10:20:37 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483207286bcsm63253465e9.12.2026.02.06.10.20.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Feb 2026 10:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770402035; x=1771006835; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2LK8trtLyNSo6IVxA5K1xN9ZysZ5E29etqSmlwZuT3o=; b=IejTbvmOCvoeR42qu/4/nqy1biOabP4LhpoM6o7VgdF8DrsJfnj6tXF2HmUIzzHhDQ bjViroWWDF2TwcO8yhoeWH1rMKt+V/2/ApXeFFhYEgli+Bj5S8o7a2WcSymw4+/aFw36 no/RyBazh9d9uCUmQ6abmaF/sMdCx2wSmiiljX/Gn54WqUSKWltP5PWTtsPSkzH7naVh yY8uJNHDQHGrgc9oFb1018ohBX1jKIdVQrzt0NvwPHaWBf+l5PverVBazp0cml7gk4fR bvr6f7cs01ZH7UpIUucTr+Euol9LXVyNrKVXI9hKr5Tt/7nwJqEbDao0814G/UFF40no 3zTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770402035; x=1771006835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2LK8trtLyNSo6IVxA5K1xN9ZysZ5E29etqSmlwZuT3o=; b=n1xWBGuRR7yqO3sLy4A0EOBsMkTwthhSZm/5lT0K9wWZoqR0ZEDiegT9juvJL7yB9f /yY+lkottFGpKtg9nkCFjWoI5+l0TTBUCpWlfHHAsBE+JqRyv4XJt7D5Gjo57Q9NYhcK r9MLFzM5UtB4vff3hoEyWhlHCdpfxiZ3ylNYEnSLZUuuUBS5/r+CSnerpZJPNQYZ47Ym ET5yFyMskCVe018sIMmyXgq98zf9yJ6QTQ8YmjyLjOG4FaJOSKNgRcQi5hd/fOJT6aeF ext0XaSxhgNU0yhPhCPq2b6LsK7WGPsNICxeIWmyzeFcG2cp80eIgLW7PkfjjfEWd4px d/og== X-Gm-Message-State: AOJu0YwQWOMTlEbhCTJaUUFfXVAuzA21ykF8cTq94fCPXMOyh3iK/kfz j2FF440EOES9EbSXCNRaB1Yo+j0r+tYwo0JT2Qf5/i8u9tI3qEJHw7oadcibHHUFzTseI6Hu+J1 GiiywIRY= X-Gm-Gg: AZuq6aKPseaMjZ6zKNoA8Y6Q8dI99vpsSKngKmEXPC7k9bAHjFPvfJgwkOv//x2RbB0 NdD4/ecqWEqTE452iknSRVR0pRuw1vM7Us4bWewGO+tUpzpkR4PL5RrgdACofJx4sKutgfLo+QN vmklKle7sGzH5tQ9K1y/THtpzFmGky7lTvdg38CgnwSK8+UVX+97JS93hJroYbNffbLEI6mhuOQ IYnuScApVvqqnTisFBHP6RzRfxBsDPyLsnJRK4Cmg1tkIGPbN+GdYhlEunnRlxQyBuLxtpg37FU spMfRZ6tI5owWICG9iMDggei8uIFNTt4rOTzv0FZMFfiZcunBuU3QH5lgmjuPczipL/qUrD+JUM Td1lVHgJED4oQX6Nz/C64JdqEOLjKKGZSXKJErsyvkUfdlZXp0UXvYjVLIqqhd0uSTRKUQwDczs Fa+ZQwD3ikPY4DqH2BRBIjI53I9OfzQiwxhTcaSeK/njoHr/TKH3rO00cpZcld X-Received: by 2002:a05:600c:34d1:b0:47e:e952:86ca with SMTP id 5b1f17b1804b1-483201db075mr47622395e9.2.1770402035115; Fri, 06 Feb 2026 10:20:35 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Matthew Rosato , Thomas Huth , qemu-s390x@nongnu.org, Ilya Leoshkevich , Halil Pasic , Richard Henderson , Christian Borntraeger , Eric Farman , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 05/10] target/s390x: Un-inline KVM Protected Virtualization stubs Date: Fri, 6 Feb 2026 19:19:48 +0100 Message-ID: <20260206181953.18683-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206181953.18683-1-philmd@linaro.org> References: <20260206181953.18683-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770402067858158500 By removing the target-specific 'CONFIG_KVM' definition this header can be used by files in meson common_ss[]. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Reviewed-by: Eric Farman --- target/s390x/kvm/pv.h | 27 ------------ target/s390x/kvm/stubs.c | 94 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 94 insertions(+), 27 deletions(-) diff --git a/target/s390x/kvm/pv.h b/target/s390x/kvm/pv.h index e266fc3d545..ea4b4ec3403 100644 --- a/target/s390x/kvm/pv.h +++ b/target/s390x/kvm/pv.h @@ -20,7 +20,6 @@ struct S390PVResponse { uint16_t rc; }; =20 -#ifdef CONFIG_KVM bool s390_is_pv(void); int s390_pv_query_info(void); int s390_pv_vm_enable(void); @@ -43,31 +42,5 @@ int kvm_s390_dump_init(void); int kvm_s390_dump_cpu(S390CPU *cpu, void *buff); int kvm_s390_dump_mem_state(uint64_t addr, size_t len, void *dest); int kvm_s390_dump_completion_data(void *buff); -#else /* CONFIG_KVM */ -static inline bool s390_is_pv(void) { return false; } -static inline int s390_pv_query_info(void) { return 0; } -static inline int s390_pv_vm_enable(void) { return 0; } -static inline void s390_pv_vm_disable(void) {} -static inline bool s390_pv_vm_try_disable_async(S390CcwMachineState *ms) {= return false; } -static inline int s390_pv_set_sec_parms(uint64_t origin, uint64_t length, - struct S390PVResponse *pv_resp, - Error **errp) { return 0; } -static inline int s390_pv_unpack(uint64_t addr, uint64_t size, uint64_t tw= eak, - struct S390PVResponse *pv_resp) { return = 0; } -static inline void s390_pv_prep_reset(void) {} -static inline int s390_pv_verify(struct S390PVResponse *pv_resp) { return = 0; } -static inline void s390_pv_unshare(void) {} -static inline void s390_pv_inject_reset_error(CPUState *cs, - struct S390PVResponse pv_res= p) {}; -static inline uint64_t kvm_s390_pv_dmp_get_size_cpu(void) { return 0; } -static inline uint64_t kvm_s390_pv_dmp_get_size_mem_state(void) { return 0= ; } -static inline uint64_t kvm_s390_pv_dmp_get_size_completion_data(void) { re= turn 0; } -static inline bool kvm_s390_pv_info_basic_valid(void) { return false; } -static inline int kvm_s390_dump_init(void) { return 0; } -static inline int kvm_s390_dump_cpu(S390CPU *cpu, void *buff) { return 0; } -static inline int kvm_s390_dump_mem_state(uint64_t addr, size_t len, - void *dest) { return 0; } -static inline int kvm_s390_dump_completion_data(void *buff) { return 0; } -#endif /* CONFIG_KVM */ =20 #endif /* HW_S390_PV_H */ diff --git a/target/s390x/kvm/stubs.c b/target/s390x/kvm/stubs.c index 5fd63b9a7e3..046e1f922b7 100644 --- a/target/s390x/kvm/stubs.c +++ b/target/s390x/kvm/stubs.c @@ -5,8 +5,102 @@ #include "qemu/osdep.h" =20 #include "kvm_s390x.h" +#include "target/s390x/kvm/pv.h" =20 int kvm_s390_get_protected_dump(void) { return false; } + +bool s390_is_pv(void) +{ + return false; +} + +int s390_pv_query_info(void) +{ + return 0; +} + +int s390_pv_vm_enable(void) +{ + return 0; +} + +void s390_pv_vm_disable(void) +{ +} + +bool s390_pv_vm_try_disable_async(S390CcwMachineState *ms) +{ + return false; +} + +int s390_pv_set_sec_parms(uint64_t origin, uint64_t length, + struct S390PVResponse *pv_resp, Error **errp) +{ + return 0; +} + +int s390_pv_unpack(uint64_t addr, uint64_t size, uint64_t tweak, + struct S390PVResponse *pv_resp) +{ + return 0; +} + +void s390_pv_prep_reset(void) +{ +} + +int s390_pv_verify(struct S390PVResponse *pv_resp) +{ + return 0; +} + +void s390_pv_unshare(void) +{ +} + +void s390_pv_inject_reset_error(CPUState *cs, struct S390PVResponse pv_res= p) +{ +} + +uint64_t kvm_s390_pv_dmp_get_size_cpu(void) +{ + return 0; +} + +uint64_t kvm_s390_pv_dmp_get_size_mem_state(void) +{ + return 0; +} + +uint64_t kvm_s390_pv_dmp_get_size_completion_data(void) +{ + return 0; +} + +bool kvm_s390_pv_info_basic_valid(void) +{ + return false; +} + +int kvm_s390_dump_init(void) +{ + return 0; +} + +int kvm_s390_dump_cpu(S390CPU *cpu, void *buff) +{ + return 0; +} + +int kvm_s390_dump_mem_state(uint64_t addr, size_t len, void *dest) +{ + return 0; +} + +int kvm_s390_dump_completion_data(void *buff) +{ + return 0; +} --=20 2.52.0 From nobody Mon Feb 9 07:42:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770402059; cv=none; d=zohomail.com; s=zohoarc; b=aGWTZ7Wq+bs0b1vru6qckTJhhWEgYcM/+LbZHoo6yHvw61YsGqYq6pBRy0nVs0b3mXk3PtylqeVEv5SQUQWK2R9pRUGZXy8JTdA9qouqdcou/dCsX+1XzwRuKyrJ8R4WeHXyxmuGM2gMT2UG5AbDwLxMBx9NjibLSbSvuKhxFqE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770402059; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DOzC//luueUoLOzpB6BmpxSYIFKhPzwuSOFEodMkyfQ=; b=nuOPCw8D8I+SWdwYVYScPll1d7oMc4YLMEaORmMGfPNazOXhjg9cTJEe/FSTAihgfMUYLxbvdqgAK0wZN/YJo2Mg8BH+9NWGTy7ILm6rr9NHqi3XeZaH6hpoWbQT1NPZ697e6WR0U0fn52KaquQF8dI5x6PBFbh38tcfC4ESv2U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770402059254451.54904523260495; Fri, 6 Feb 2026 10:20:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1voQRm-0007jn-Uq; Fri, 06 Feb 2026 13:20:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1voQRj-0007iA-E0 for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:48 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1voQRh-00054W-2k for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:47 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4806f9e61f9so14821335e9.1 for ; Fri, 06 Feb 2026 10:20:44 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d835f0sm141357485e9.14.2026.02.06.10.20.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Feb 2026 10:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770402043; x=1771006843; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DOzC//luueUoLOzpB6BmpxSYIFKhPzwuSOFEodMkyfQ=; b=Cxfy+/v/soHDMkBW/QM4G+hswstDoj+ek+PWzWBqm+oTQUQQ6lEa5r1sp1Of/poCP2 L0LKWPE5NJxxYzsEEu7EBiJxVd6g7Un5j64H4+YcU1powuYjDh97evK4WY0/J2oL4lSP Usq0VOciq1yCrxa4dN/ZJjzAVVeecrKhNLUokVy0C5ZQ75/pfUJkhYFdGAuXprA3L+TG /tFPFY69PAi7qHLaF9GcXRuEKwZtWM6StC76EzkxZJMjufug9YgKRrE0U0vvYvvjI58A JM7Qxlpw+mFNQi0GlMLv/YkNvMS3URUajlW1+tR+P38bLNCxwk3Zr+cM4tcTQrArZ3aB fdeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770402043; x=1771006843; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DOzC//luueUoLOzpB6BmpxSYIFKhPzwuSOFEodMkyfQ=; b=up24LvzqDKvjDixDB2vRkNh5w7gROfmsX5fduM4qGG5nhTd6kyGqR2SBH8gGoQHJWe BC4SCWbs/BrF/APLN42xwbp2Cou82CQMfX9tMMJOf1b0Mx6jkGfpnWvTO6Wim/8WZY2s aWlGC8WWAoKNIlFJ41zHk0UCAFFkNrRF0PX9sWyghZ8VMZgkkUUlJkx1Wk8R3etZihTh SbeoWY1vySNaUF8RJSqYChCf94iaIncL/ktLNyM9HMZN8Z5NrUqa1oG7sAIZmg1sbqZw deeVLieu+NMHmWW7hd28FEyPoak8AZlV/jUETCkEn9ZKIf4TCYxcMppRB0PhMH2+p1Zp 1mPQ== X-Gm-Message-State: AOJu0Yw1jN6nKZT/49pvAHu67ZuDJ8N3hjk5i/smhhfHf4tofgoEH9wY /Ntt4UBx/FTKHQlpmImJfzkkS428nb7Gl/8QrMWEVQiLhW82GOZT3sETLF9pMSJHxyVI00aVcbv 95flw/dg= X-Gm-Gg: AZuq6aIBsuioW1Vpu/14jqpjkLTlB0OSxBGeowuh13Q0MSmfRQ9389JiQQO7HEVN6SJ ri4Hq4pyzQyHRH1QFm5ydURi6ijGI8J5UDzm+Qys56TahpruWX/P5j8iyIyUTljNkmmVhuz/ohw +Npp7wrbg5/D5aT2UDeDNcRHm3YLMFAkQ0tlbhXhEjaCF/xs/XjepzduHy0fQBkJ4J9SBnEpUM7 N77JmvR0d16INLFR8EVLitRERH18iDYTYytV8E2FF7nMliSY4yDmvyCuKOcBN0Bc6ETilfxR207 n+NQ5KeKj80pKJhwHc53Tl+KwYT3PG9rXKd5Dp3b/JSlDymGVaOE7qPVDfjydcEI0D9KPWOcSWi WXB8QjAml4zlzeNE469IKnQe9aelzJJvaSU1sSGrnHlnAyWLhfmpXLkJCL+HdMat9Xoufymrz02 Y4k2zibyJB+3HdB2Pa9v9VDWQVfoPcS4TOS7YYbrDdL9T+rf97hEejHgFggNT0SsGDtOPzDpM= X-Received: by 2002:a05:600c:8489:b0:47e:e61d:b8d2 with SMTP id 5b1f17b1804b1-4832021ebd6mr53818175e9.27.1770402042634; Fri, 06 Feb 2026 10:20:42 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Matthew Rosato , Thomas Huth , qemu-s390x@nongnu.org, Ilya Leoshkevich , Halil Pasic , Richard Henderson , Christian Borntraeger , Eric Farman , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 06/10] target/s390x: Add more unreachable KVM stubs Date: Fri, 6 Feb 2026 19:19:49 +0100 Message-ID: <20260206181953.18683-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206181953.18683-1-philmd@linaro.org> References: <20260206181953.18683-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770402059874158500 Next patch will move s390x system objects from the target specific source set to the common one. Unfortunately the kvm_enabled() macro won't be evaluable at built-time anymore. Add stubs for KVM symbols unreachable at runtime. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Thomas Huth Reviewed-by: Eric Farman --- target/s390x/kvm/stubs.c | 76 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 75 insertions(+), 1 deletion(-) diff --git a/target/s390x/kvm/stubs.c b/target/s390x/kvm/stubs.c index 046e1f922b7..196127baa51 100644 --- a/target/s390x/kvm/stubs.c +++ b/target/s390x/kvm/stubs.c @@ -4,8 +4,9 @@ =20 #include "qemu/osdep.h" =20 -#include "kvm_s390x.h" +#include "target/s390x/kvm/kvm_s390x.h" #include "target/s390x/kvm/pv.h" +#include "target/s390x/cpu_models.h" =20 int kvm_s390_get_protected_dump(void) { @@ -104,3 +105,76 @@ int kvm_s390_dump_completion_data(void *buff) { return 0; } + +bool kvm_s390_apply_cpu_model(const S390CPUModel *model, Error **errp) +{ + g_assert_not_reached(); +} + +void kvm_s390_access_exception(S390CPU *cpu, uint16_t code, uint64_t te_co= de) +{ + g_assert_not_reached(); +} + +int kvm_s390_mem_op(S390CPU *cpu, vaddr addr, uint8_t ar, void *hostbuf, + int len, bool is_write) +{ + g_assert_not_reached(); +} + +int kvm_s390_mem_op_pv(S390CPU *cpu, vaddr addr, void *hostbuf, int len, + bool is_write) +{ + g_assert_not_reached(); +} + +int kvm_s390_set_cpu_state(S390CPU *cpu, uint8_t cpu_state) +{ + g_assert_not_reached(); +} + +void kvm_s390_vcpu_interrupt_pre_save(S390CPU *cpu) +{ + g_assert_not_reached(); +} + +int kvm_s390_vcpu_interrupt_post_load(S390CPU *cpu) +{ + g_assert_not_reached(); +} + +int kvm_s390_get_hpage_1m(void) +{ + g_assert_not_reached(); +} + +void kvm_s390_enable_css_support(S390CPU *cpu) +{ + g_assert_not_reached(); +} + +int kvm_s390_assign_subch_ioeventfd(EventNotifier *notifier, uint32_t sch, + int vq, bool assign) +{ + g_assert_not_reached(); +} + +void kvm_s390_cmma_reset(void) +{ + g_assert_not_reached(); +} + +void kvm_s390_crypto_reset(void) +{ + g_assert_not_reached(); +} + +void kvm_s390_set_diag318(CPUState *cs, uint64_t diag318_info) +{ + g_assert_not_reached(); +} + +int kvm_s390_topology_set_mtcr(uint64_t attr) +{ + g_assert_not_reached(); +} --=20 2.52.0 From nobody Mon Feb 9 07:42:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770402070; cv=none; d=zohomail.com; s=zohoarc; b=k3LlrXGuYi6XHvOva77UKevlTQrr6r3NapANKQBUJoxvz7VGhTiIgtqcL9WwG6KqTfWPcuVlh7GbQ/VUu0qka3n1YiX47UOWdOKa3HzPb9xZNMFpyYkKNolVz3Kb38doPd9V6dMhycwCWq7qgbWA7lxU4cBNMzsTjTDK+2uTINU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770402070; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ApZj1/uOnPVUnEhnGSPBwrshtRIOJ8WxMqGa4plL9Zs=; b=nBnlmduM9r0saPyAMBlrawAcm96mQT1Qwn3Ih5STAaWYc7W6oMVIjGfmTsuE5EsDf7gNNZptjDJ0HXjCHKtRW5EkmPIIYZJ9zRTt7GWHHELpzScexUXL2LwVCXVs8RsHYCeCWCbR0J3xJ6NjhQGHMx3aTWfXDS3KOdD1VplHjHE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770402070768131.46173516208216; Fri, 6 Feb 2026 10:21:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1voQRx-0007o2-6x; Fri, 06 Feb 2026 13:21:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1voQRq-0007mU-CW for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:55 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1voQRo-00055O-Tn for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:20:54 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4801d7c72a5so8871475e9.0 for ; Fri, 06 Feb 2026 10:20:52 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48320719bd2sm64294185e9.11.2026.02.06.10.20.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Feb 2026 10:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770402050; x=1771006850; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ApZj1/uOnPVUnEhnGSPBwrshtRIOJ8WxMqGa4plL9Zs=; b=L3RyOIpeu4T3IAGixkepsWIJ688gW5WofNn9SscTxLhbQw10bMWAP0/Bhh5CJbJ0rQ 3WlwM1eMG8FWs8+VEmM0Fyg96vwythJN0bqSSdoKyTxBt69ZbbufgPJVxKmOBnF+b/nn bw84v18/3YzlFzFjb6dcis14gUMBS6sftprFY6JaMe5ERA7Bj9c5Lc0CTvsb2mTrD2gO HukOc4Zl7YpH3BG+ZscAvPaR8ugBJqLEXyvvHhGRJuYjT+sRgDMxIFPDvnGTV85+BljO WbLw387rbz8JKn/4uLnZn3doWUwBtoaDWNzMNGYPi/QVByZialBdxRIstsyLG+dk0nYM Fz6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770402050; x=1771006850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ApZj1/uOnPVUnEhnGSPBwrshtRIOJ8WxMqGa4plL9Zs=; b=CGSdv2HSqasX2cSStdAr3NSLZZkAgv4wI1AV0Q1nS4zF3c1KftrpxzBuYxUaUg+FlW quyKW83Zof0mJafYRbiANC0hI7JMWLoX0n4HkvJgvHE7nRStwulE0QpfJL3Bg2i5QS8D KgRAwgGHdBLDisxrumutyF252+F95VWPNwwQuuBKdh5B5UFY3P6PjdNxqygaXdwuw1xB iPXamlG0egcU1OT9Bmuu6e8GYMlNg4RAF93IZeT4PxSnNCA0DpJHJKaE0yJ/IHJWLH4y /IVPDL615KyHPyTpYxPF2nWIVxP0AUZ3P5fSecS1GQOlvO9xcDatj4sf7REFnYzPG/Z/ cCtQ== X-Gm-Message-State: AOJu0YyML9RrWuRsqzpFThSrHjwk2Cc8SopvoMtD7a1aWwH9ht02wCUf sj2Du5mzGaDpd5T1cN5tyZqVdFPYU/vAT58BvxKdLdxkPE8Pwg2hlQv4o23jjQ6DRbCA88a1E7x s9zDd8UY= X-Gm-Gg: AZuq6aIz2dR1I17V24m6tvsg39ofRR8QawRH0u27pROCXDMfH4mOHbx7g6Qkxpzk1XA GwXfsdXhrxUEPZjt4a6QnD7RGwWbCEO2C+pAvXCFOEce1sXyL5uuVX2bD4YQwcfsgTKA0BsRLqJ 1Fs5ZPQAHzV7KF9y8Vvku9qxO1Xf/1jGjrFOr8uhaeE57j84PXWpogi7+iUmMl7maLmHV0x3JqM n+3Te/LXJ+niXpJ1vJl/SkgqVM+CRZanyvgYuspQ+lzpKNeEX3uv1BbjiImHW6xp2njrHEHEEP3 T3tizNqgxbudlgjm3IzjlknzyENdiXKLtvDTsaH6tiJsj6IZsHQ0TjeeP0c0HlSsuAj2svsYPJj Y2Qdmmle0jA3AtKzHteQ2deAFsA8v3Hmc8obhwuJaxzI12HM1u7I8Akb0RPp0YhzTRfUIWy05HB t2JoSZcnXQ7EjlGPIlK4t+YhGRL7OD43oG4UVRSxPYWrEF1FD++m4djwLYNAgH X-Received: by 2002:a05:600c:1f16:b0:47a:814c:eea1 with SMTP id 5b1f17b1804b1-48320227d98mr56790005e9.35.1770402050316; Fri, 06 Feb 2026 10:20:50 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Matthew Rosato , Thomas Huth , qemu-s390x@nongnu.org, Ilya Leoshkevich , Halil Pasic , Richard Henderson , Christian Borntraeger , Eric Farman , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 07/10] target/s390x: Build system units in common source set Date: Fri, 6 Feb 2026 19:19:50 +0100 Message-ID: <20260206181953.18683-8-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206181953.18683-1-philmd@linaro.org> References: <20260206181953.18683-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770402072482154100 Except the ioinst.c file which uses the TARGET_PAGE_SIZE definition in the ioinst_handle_chsc() method, all other files in meson's s390x_system_ss[] source set don't use any target-specific code. Moving them in the other s390x_common_system_ss[] set to build as common objects ensures these files won't use any target-specific API such target_ulong / TARGET_PAGE_SIZE, thus forcing to use the appropriate types instead (such vaddr, hwaddr, uint64_t, ...). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- target/s390x/meson.build | 8 +++++++- target/s390x/tcg/meson.build | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/target/s390x/meson.build b/target/s390x/meson.build index 3b34ae034cb..096b7dcc42e 100644 --- a/target/s390x/meson.build +++ b/target/s390x/meson.build @@ -20,10 +20,15 @@ s390x_ss.add(gen_features_h) =20 s390x_system_ss =3D ss.source_set() s390x_system_ss.add(files( + 'ioinst.c', +)) + +s390x_common_system_ss =3D ss.source_set() +s390x_common_system_ss.add(gen_features_h) +s390x_common_system_ss.add(files( 'helper.c', 'arch_dump.c', 'diag.c', - 'ioinst.c', 'machine.c', 'mmu_helper.c', 'sigp.c', @@ -41,4 +46,5 @@ subdir('kvm') =20 target_arch +=3D {'s390x': s390x_ss} target_system_arch +=3D {'s390x': s390x_system_ss} +target_common_system_arch +=3D {'s390x': s390x_common_system_ss} target_user_arch +=3D {'s390x': s390x_user_ss} diff --git a/target/s390x/tcg/meson.build b/target/s390x/tcg/meson.build index 515cb8b473d..17c9374d09e 100644 --- a/target/s390x/tcg/meson.build +++ b/target/s390x/tcg/meson.build @@ -12,6 +12,6 @@ s390x_ss.add(when: 'CONFIG_TCG', if_true: files( 'vec_int_helper.c', 'vec_string_helper.c', )) -s390x_system_ss.add(when: 'CONFIG_TCG', if_true: files( +s390x_common_system_ss.add(when: 'CONFIG_TCG', if_true: files( 'debug.c', )) --=20 2.52.0 From nobody Mon Feb 9 07:42:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770402107; cv=none; d=zohomail.com; s=zohoarc; b=UTCuhPUTcY8dj3G2B2YTyxK40jbaKdq6VgU0AJhWKcnjljaFf9l9kqN5s/ztvD3rVu/eArqwWgVzyy8TYy76toyTdqwZyKZ1v/Tb4gEVlSauGNMKlBwltWJVS5ybpFJQogJ5x7I24eCAY6NKhzTRzl+mvay3glraNquJ7jHJVO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770402107; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=udl4u3wK1/as/9f00LKjlolu36IdtPxffb3xiDh4tWc=; b=JEPaLNSlJbRr0YeYnBEg6WbLALPE5EINwhXUAtL8w/sQ/tQIQj1lg3bMLM7itlEn74aAIsRVdjPAdWrmsqHa9OsKFflGEHWB6wZEw5mqr3jDT/x42YOZCoShymAeUT793ez+C3+hMsXjmlTC4ySXDzjy+rGy5g48CAZlmclT+Tw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177040210696579.52931367532051; Fri, 6 Feb 2026 10:21:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1voQS1-0007vB-PB; Fri, 06 Feb 2026 13:21:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1voQRy-0007rj-Iw for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:21:03 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1voQRx-0005AN-5Z for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:21:02 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-48069a48629so22183745e9.0 for ; Fri, 06 Feb 2026 10:21:00 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d3e245sm145169305e9.8.2026.02.06.10.20.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Feb 2026 10:20:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770402058; x=1771006858; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=udl4u3wK1/as/9f00LKjlolu36IdtPxffb3xiDh4tWc=; b=iKOkkyQBZ01BdNRJeyAmh31OV2GG6mFANV9HPFteN29cQGIE332MH8427oL46oX9ab PHZBzoUyyzbWrKANorFlTYUsYnOz7kGfSQ62NoAjT6/x1cdXDNEN9MMfL/caYGvUheHF b3JJTkOQZQ6oMSZM7JV0VQKaU5ex8RoIN7Nlsdp1dSzpC6wBoHWDELsqJV5QhSpPGlo0 cuhpl0+2MCowxHtU+GGnzsj9lP2Decebh18lVOM0p9Y0T+M6E4ZW/ZaES12wBnGnhi5z ffa9Lzcsg0Q4NxrTKaWAUiNm8Be2qZ2ODw+xlbR8t/T91EfNA3r+7vn8ERn0tFl1IaGm zpIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770402058; x=1771006858; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=udl4u3wK1/as/9f00LKjlolu36IdtPxffb3xiDh4tWc=; b=KmWnAwH43rdZDgB0x8/19WK7wSeT1e5wYTqY6bvlrqiFY8CAkVM2FVdIAgb9cM7u+D TpKBqLHtRt87WCu9z79TQSC149XM29gUpCdrJE/bBHU3Ki6ho1RHZsk8SME2X0+S4bMT CU/Ve+v2kyYK+kLPWpxJ/PgrDasGDh8A8/AwUcDx6lREgdE/etYr5nCP2YkHmNy50au7 uo2Z1j6j1yTwRd55s0G/Qqt0hXBnAR1HdXuK6CUAP38r9xvc698Qr3P1fcb7jBTnWkQA Z657bhZR4lSGf5Buwr3li09Mg37NDG3npEeRvRXIMix7Nz19UNTKdcjD0jCb9SEGN7Q7 bXoQ== X-Gm-Message-State: AOJu0YwLbTLCWfKaDzhnFc9sYQ5dNqoH3rGzsKGOo661CuFiFMY77k0K ax1x5yfilTRFQ75eX4sx4lNqyvrIvHzynLBGXtTDQ4bSwuGAZhjUoKXkZBJ3RxnsTxYCe68DAaF FGKub62E= X-Gm-Gg: AZuq6aJIpgr3fNYyL8F1IeMXU58Ta4U7KStxrbMfrG4yu2PlJQbJGQjQ/RskxEd95rc E47kR++baiaU0Vq5C+2AsTPVVkw53+RhAWqOFh5xoe8D4HWu+e4QHCoN3no9/GHPkyylYqWc1Jz cxh6Qh6IdgdlP8K4C0ilROXQkx+1Jd2tXm5Xv9iFzNAratiyUg4SUh2T8Q+Ga3KQaXUNbP6IfvZ zdBA+YLzmf9izukhawyQPH35yFLS+GuyxifM2nCZDg0rA0ZgDRUusskLpo4Lm8rTYe4cn3LwsuJ GIQtjKDZE9l5dYZMZnRr8VI0uUqd4LvMNSwvpUliEfn83EedC2oBWvfcaxffxWD5PP28pVbpMOv tK/IqrofsSWor2nmth4A2bhk6V34Pc0oz3WsF0ilCz3wRYDPMUk9RU4vK/fZmNB6Z01aSlrWCad ZchqOymcpfsJMqPL4vde77n8dfN+DLcAB6oDrfh9oOqImwM2qWw7hGqUu5mQrU X-Received: by 2002:a05:600c:8489:b0:477:c478:46d7 with SMTP id 5b1f17b1804b1-48320216cb8mr54156125e9.22.1770402057964; Fri, 06 Feb 2026 10:20:57 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Matthew Rosato , Thomas Huth , qemu-s390x@nongnu.org, Ilya Leoshkevich , Halil Pasic , Richard Henderson , Christian Borntraeger , Eric Farman , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 08/10] target/s390x: Expand TCGv type as 64-bit target Date: Fri, 6 Feb 2026 19:19:51 +0100 Message-ID: <20260206181953.18683-9-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206181953.18683-1-philmd@linaro.org> References: <20260206181953.18683-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770402108124158500 The s390x target is a 64-bit one, so TCGv expands to TCGv_i64. Use the latter which is already used about a hundred times in this file, and is also more explicit. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- target/s390x/tcg/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 540c5a569c0..437f5a4aeb7 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -3142,7 +3142,7 @@ static DisasJumpType op_mov2(DisasContext *s, DisasOp= s *o) static DisasJumpType op_mov2e(DisasContext *s, DisasOps *o) { int b2 =3D get_field(s, b2); - TCGv ar1 =3D tcg_temp_new_i64(); + TCGv_i64 ar1 =3D tcg_temp_new_i64(); int r1 =3D get_field(s, r1); =20 o->out =3D o->in2; @@ -5743,9 +5743,9 @@ static void in2_a2(DisasContext *s, DisasOps *o) } #define SPEC_in2_a2 0 =20 -static TCGv gen_ri2(DisasContext *s) +static TCGv_i64 gen_ri2(DisasContext *s) { - TCGv ri2 =3D NULL; + TCGv_i64 ri2 =3D NULL; bool is_imm; int imm; =20 --=20 2.52.0 From nobody Mon Feb 9 07:42:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770402111; cv=none; d=zohomail.com; s=zohoarc; b=Ga72c2RwDqSkdEroYtpySt0fEzA3M0WnDEeuLWL6/y8pGALYmr7wOzJivoDRaSj+bm1fiezzzMc3jq9oc7SE6lcc77RFRiawjz7PI+sm6oMaooFhNy0Zy8/nM4P2wMMmJBEfTy97wsRSd3IMjox6Z70DN6M85z3LtGP68wH+2Bk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770402111; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wzES1qng8rWM3+acoSyUBkVai5xaMJnvu2yQlPPQ03I=; b=dznnS56gRNgUHJuDUO5ypLtpvnhYeEST22puhC+BJnjt4ymZfc9abaHaowlO8X1UVdYeRYrUO8ekjvOf0FV7xW32mOPhbBYOVuhpvQnGS8+oJg8disgPTzSl9Zgxigy9S9jwSfMFUKH9CM+Kju1rRPt7suKLdMknX3XWK4jQ8Ps= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770402111478789.7049736998547; Fri, 6 Feb 2026 10:21:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1voQS7-00089Q-J7; Fri, 06 Feb 2026 13:21:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1voQS5-00082q-T9 for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:21:09 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1voQS4-0005Av-0g for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:21:09 -0500 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-482f454be5bso28823195e9.0 for ; Fri, 06 Feb 2026 10:21:07 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436296bd1bcsm6372721f8f.12.2026.02.06.10.21.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Feb 2026 10:21:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770402065; x=1771006865; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wzES1qng8rWM3+acoSyUBkVai5xaMJnvu2yQlPPQ03I=; b=uI4jHFXIxSCp20HFnl59aShDpoIewDYJQlCY/S+khBDNFxwXd54TfzPXUr94rAmAPo 9FFzNp/ihrAbPeuibSMEGU72FuzkO4QrL0jEsQNRFJLb6eu2/Y7SMd38fCiwg5DSYssW 0Ki/PIFeAV4RmxTwKruQP5lokUfq8GbCBMf809DsA2bSCbaB7Dy0AmauoujJ+XoRR2gj lhdzrenCHZFVUpVpilmbchVg6rWkhxnika9RdMVkhkyOwDVFPjb18Aod8yPzxkaBs94e P5tWFUXxE06io14tSdtNxNtN9+BqCxbImsGWh0eQbW1QgxEAqmgAOhpgD40h7zvrgumz 9jTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770402065; x=1771006865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wzES1qng8rWM3+acoSyUBkVai5xaMJnvu2yQlPPQ03I=; b=ksC8+XfbB1z5eXbxTTqyBBsGoz42blbS5CrOjShYTQhiXCWeH3maQWGYr5/gR/bMt1 hKeKCi3/nCfN2pP4KRitJz85Bw93UJpdh3xSW/7/U/8Atu8JhbAF5T0kC1Rw63KR2BGE TCtMI9KnSA9iMXL403SlAc8dbN3HWDwJKnbWy61Jb/VpNc2NTmhuo10DSCKSipSGaL2B Z8K/3km1UjXZrbiANALS5kwyDR4JoliAEav+HtbVBC5C6Hg6dzS6/24F4MMwgGYwo/Sc TckqjERzfOJWpicXlaI7tegT7CXtNfUBf5V51+Of7pXvXZ8suMxwx6kAKBi3JgBhw3cg m/0w== X-Gm-Message-State: AOJu0YzlH4hw7BgCfziqYfz4zGe143SlsywBy12qQSbYFw7YhfOJNprS dqd0OxR5diI+gZLiA6tYp/1YaD0IspCv8hNxsuu9qmsrxnVz6450QXXoChSrcL2dOLRGj+Mj8wO saF5fFAU= X-Gm-Gg: AZuq6aKt4rbKpgyuEsLpNgvYaQAYKG3f3/cfSJjpBHnYjT/flitF+RN5JINECm1QggV 1wFlLqwIBvbDMQaWCaMkixRLiGByKqPBughl5l4DcW3R1KeMBFSuidcDFGz1hnq/kWiod15f+gT u45GUaPXNeQLlgO6hZ5qToCyS1CgV9iOPmLFNV8K/gEaLQwl2igd9adw4NFR/yTAK1s34ZkWb5c m4fnbsZHL640zWcFDYvHSHmtIYDQUNHi2Ag8eS07/vuvwkAtBkQFqclMhoQvz1iUdcfclzG3AO1 DohuMNV7hRnxrGiiiIdfpRVVP4Rwme2bsI/M0nWdbRbO0rd4b30to9JRsY0pOAUQpMwhwkWeYMC y1vZ2LSy8p5xoJbhYZ0mAWX3g+3zONAyTJnBRehOkFdumNYUSWE6CSFQNvoss4Y21cK+f0Nbvxc HFEohMGqeq2u3/nGzM0BnjWsjkQfvp4P57WQcHvdMuRf26kX3pX358ikkw0GH8OjTuRz2dXqQ= X-Received: by 2002:a05:6000:2210:b0:435:92c6:d556 with SMTP id ffacd0b85a97d-4362933ec62mr6116926f8f.16.1770402065436; Fri, 06 Feb 2026 10:21:05 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Matthew Rosato , Thomas Huth , qemu-s390x@nongnu.org, Ilya Leoshkevich , Halil Pasic , Richard Henderson , Christian Borntraeger , Eric Farman , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 09/10] target/s390x: Expand tcg_gen_qemu_ld/st_tl() as 64-bit target Date: Fri, 6 Feb 2026 19:19:52 +0100 Message-ID: <20260206181953.18683-10-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206181953.18683-1-philmd@linaro.org> References: <20260206181953.18683-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770402136714158500 The s390x target is a 64-bit one, so we have these expansions in the "tcg/tcg-op.h" header: . tcg_gen_qemu_ld_tl() -> tcg_gen_qemu_ld_i64() . tcg_gen_qemu_st_tl() -> tcg_gen_qemu_st_i64() Use the expanded form which is more explicit when a target isn't built for different words size. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- target/s390x/tcg/translate.c | 54 ++++++++++++++++++------------------ 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 437f5a4aeb7..4dabd49840f 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -1259,7 +1259,7 @@ static DisasJumpType op_asi(DisasContext *s, DisasOps= *o) =20 o->in1 =3D tcg_temp_new_i64(); if (non_atomic) { - tcg_gen_qemu_ld_tl(o->in1, o->addr1, get_mem_index(s), s->insn->da= ta); + tcg_gen_qemu_ld_i64(o->in1, o->addr1, get_mem_index(s), s->insn->d= ata); } else { /* Perform the atomic addition in memory. */ tcg_gen_atomic_fetch_add_i64(o->in1, o->addr1, o->in2, get_mem_ind= ex(s), @@ -1270,7 +1270,7 @@ static DisasJumpType op_asi(DisasContext *s, DisasOps= *o) tcg_gen_add_i64(o->out, o->in1, o->in2); =20 if (non_atomic) { - tcg_gen_qemu_st_tl(o->out, o->addr1, get_mem_index(s), s->insn->da= ta); + tcg_gen_qemu_st_i64(o->out, o->addr1, get_mem_index(s), s->insn->d= ata); } return DISAS_NEXT; } @@ -1281,7 +1281,7 @@ static DisasJumpType op_asiu64(DisasContext *s, Disas= Ops *o) =20 o->in1 =3D tcg_temp_new_i64(); if (non_atomic) { - tcg_gen_qemu_ld_tl(o->in1, o->addr1, get_mem_index(s), s->insn->da= ta); + tcg_gen_qemu_ld_i64(o->in1, o->addr1, get_mem_index(s), s->insn->d= ata); } else { /* Perform the atomic addition in memory. */ tcg_gen_atomic_fetch_add_i64(o->in1, o->addr1, o->in2, get_mem_ind= ex(s), @@ -1293,7 +1293,7 @@ static DisasJumpType op_asiu64(DisasContext *s, Disas= Ops *o) tcg_gen_add2_i64(o->out, cc_src, o->in1, cc_src, o->in2, cc_src); =20 if (non_atomic) { - tcg_gen_qemu_st_tl(o->out, o->addr1, get_mem_index(s), s->insn->da= ta); + tcg_gen_qemu_st_i64(o->out, o->addr1, get_mem_index(s), s->insn->d= ata); } return DISAS_NEXT; } @@ -1374,7 +1374,7 @@ static DisasJumpType op_ni(DisasContext *s, DisasOps = *o) o->in1 =3D tcg_temp_new_i64(); =20 if (!s390_has_feat(S390_FEAT_INTERLOCKED_ACCESS_2)) { - tcg_gen_qemu_ld_tl(o->in1, o->addr1, get_mem_index(s), s->insn->da= ta); + tcg_gen_qemu_ld_i64(o->in1, o->addr1, get_mem_index(s), s->insn->d= ata); } else { /* Perform the atomic operation in memory. */ tcg_gen_atomic_fetch_and_i64(o->in1, o->addr1, o->in2, get_mem_ind= ex(s), @@ -1385,7 +1385,7 @@ static DisasJumpType op_ni(DisasContext *s, DisasOps = *o) tcg_gen_and_i64(o->out, o->in1, o->in2); =20 if (!s390_has_feat(S390_FEAT_INTERLOCKED_ACCESS_2)) { - tcg_gen_qemu_st_tl(o->out, o->addr1, get_mem_index(s), s->insn->da= ta); + tcg_gen_qemu_st_i64(o->out, o->addr1, get_mem_index(s), s->insn->d= ata); } return DISAS_NEXT; } @@ -1917,8 +1917,8 @@ static DisasJumpType op_clc(DisasContext *s, DisasOps= *o) mop =3D ctz32(l + 1) | MO_BE; /* Do not update cc_src yet: loading cc_dst may cause an exception= . */ src =3D tcg_temp_new_i64(); - tcg_gen_qemu_ld_tl(src, o->addr1, get_mem_index(s), mop); - tcg_gen_qemu_ld_tl(cc_dst, o->in2, get_mem_index(s), mop); + tcg_gen_qemu_ld_i64(src, o->addr1, get_mem_index(s), mop); + tcg_gen_qemu_ld_i64(cc_dst, o->in2, get_mem_index(s), mop); gen_op_update2_cc_i64(s, CC_OP_LTUGTU_64, src, cc_dst); return DISAS_NEXT; default: @@ -2747,15 +2747,15 @@ static DisasJumpType op_ld16u(DisasContext *s, Disa= sOps *o) =20 static DisasJumpType op_ld32s(DisasContext *s, DisasOps *o) { - tcg_gen_qemu_ld_tl(o->out, o->in2, get_mem_index(s), - MO_BESL | s->insn->data); + tcg_gen_qemu_ld_i64(o->out, o->in2, get_mem_index(s), + MO_BESL | s->insn->data); return DISAS_NEXT; } =20 static DisasJumpType op_ld32u(DisasContext *s, DisasOps *o) { - tcg_gen_qemu_ld_tl(o->out, o->in2, get_mem_index(s), - MO_BEUL | s->insn->data); + tcg_gen_qemu_ld_i64(o->out, o->in2, get_mem_index(s), + MO_BEUL | s->insn->data); return DISAS_NEXT; } =20 @@ -3087,7 +3087,7 @@ static DisasJumpType op_lpq(DisasContext *s, DisasOps= *o) #ifndef CONFIG_USER_ONLY static DisasJumpType op_lura(DisasContext *s, DisasOps *o) { - tcg_gen_qemu_ld_tl(o->out, o->in2, MMU_REAL_IDX, s->insn->data); + tcg_gen_qemu_ld_i64(o->out, o->in2, MMU_REAL_IDX, s->insn->data); return DISAS_NEXT; } #endif @@ -3506,7 +3506,7 @@ static DisasJumpType op_oi(DisasContext *s, DisasOps = *o) o->in1 =3D tcg_temp_new_i64(); =20 if (!s390_has_feat(S390_FEAT_INTERLOCKED_ACCESS_2)) { - tcg_gen_qemu_ld_tl(o->in1, o->addr1, get_mem_index(s), s->insn->da= ta); + tcg_gen_qemu_ld_i64(o->in1, o->addr1, get_mem_index(s), s->insn->d= ata); } else { /* Perform the atomic operation in memory. */ tcg_gen_atomic_fetch_or_i64(o->in1, o->addr1, o->in2, get_mem_inde= x(s), @@ -3517,7 +3517,7 @@ static DisasJumpType op_oi(DisasContext *s, DisasOps = *o) tcg_gen_or_i64(o->out, o->in1, o->in2); =20 if (!s390_has_feat(S390_FEAT_INTERLOCKED_ACCESS_2)) { - tcg_gen_qemu_st_tl(o->out, o->addr1, get_mem_index(s), s->insn->da= ta); + tcg_gen_qemu_st_i64(o->out, o->addr1, get_mem_index(s), s->insn->d= ata); } return DISAS_NEXT; } @@ -4334,7 +4334,7 @@ static DisasJumpType op_stnosm(DisasContext *s, Disas= Ops *o) =20 static DisasJumpType op_stura(DisasContext *s, DisasOps *o) { - tcg_gen_qemu_st_tl(o->in1, o->in2, MMU_REAL_IDX, s->insn->data); + tcg_gen_qemu_st_i64(o->in1, o->in2, MMU_REAL_IDX, s->insn->data); =20 if (s->base.tb->flags & FLAG_MASK_PER_STORE_REAL) { update_cc_op(s); @@ -4367,8 +4367,8 @@ static DisasJumpType op_st16(DisasContext *s, DisasOp= s *o) =20 static DisasJumpType op_st32(DisasContext *s, DisasOps *o) { - tcg_gen_qemu_st_tl(o->in1, o->in2, get_mem_index(s), - MO_BEUL | s->insn->data); + tcg_gen_qemu_st_i64(o->in1, o->in2, get_mem_index(s), + MO_BEUL | s->insn->data); return DISAS_NEXT; } =20 @@ -4836,7 +4836,7 @@ static DisasJumpType op_xi(DisasContext *s, DisasOps = *o) o->in1 =3D tcg_temp_new_i64(); =20 if (!s390_has_feat(S390_FEAT_INTERLOCKED_ACCESS_2)) { - tcg_gen_qemu_ld_tl(o->in1, o->addr1, get_mem_index(s), s->insn->da= ta); + tcg_gen_qemu_ld_i64(o->in1, o->addr1, get_mem_index(s), s->insn->d= ata); } else { /* Perform the atomic operation in memory. */ tcg_gen_atomic_fetch_xor_i64(o->in1, o->addr1, o->in2, get_mem_ind= ex(s), @@ -4847,7 +4847,7 @@ static DisasJumpType op_xi(DisasContext *s, DisasOps = *o) tcg_gen_xor_i64(o->out, o->in1, o->in2); =20 if (!s390_has_feat(S390_FEAT_INTERLOCKED_ACCESS_2)) { - tcg_gen_qemu_st_tl(o->out, o->addr1, get_mem_index(s), s->insn->da= ta); + tcg_gen_qemu_st_i64(o->out, o->addr1, get_mem_index(s), s->insn->d= ata); } return DISAS_NEXT; } @@ -5291,7 +5291,7 @@ static void wout_m1_16(DisasContext *s, DisasOps *o) #ifndef CONFIG_USER_ONLY static void wout_m1_16a(DisasContext *s, DisasOps *o) { - tcg_gen_qemu_st_tl(o->out, o->addr1, get_mem_index(s), MO_BEUW | MO_AL= IGN); + tcg_gen_qemu_st_i64(o->out, o->addr1, get_mem_index(s), MO_BEUW | MO_A= LIGN); } #define SPEC_wout_m1_16a 0 #endif @@ -5305,7 +5305,7 @@ static void wout_m1_32(DisasContext *s, DisasOps *o) #ifndef CONFIG_USER_ONLY static void wout_m1_32a(DisasContext *s, DisasOps *o) { - tcg_gen_qemu_st_tl(o->out, o->addr1, get_mem_index(s), MO_BEUL | MO_AL= IGN); + tcg_gen_qemu_st_i64(o->out, o->addr1, get_mem_index(s), MO_BEUL | MO_A= LIGN); } #define SPEC_wout_m1_32a 0 #endif @@ -5816,7 +5816,7 @@ static void in2_m2_32u(DisasContext *s, DisasOps *o) static void in2_m2_32ua(DisasContext *s, DisasOps *o) { in2_a2(s, o); - tcg_gen_qemu_ld_tl(o->in2, o->in2, get_mem_index(s), MO_BEUL | MO_ALIG= N); + tcg_gen_qemu_ld_i64(o->in2, o->in2, get_mem_index(s), MO_BEUL | MO_ALI= GN); } #define SPEC_in2_m2_32ua 0 #endif @@ -5862,16 +5862,16 @@ static void in2_mri2_16u(DisasContext *s, DisasOps = *o) static void in2_mri2_32s(DisasContext *s, DisasOps *o) { o->in2 =3D tcg_temp_new_i64(); - tcg_gen_qemu_ld_tl(o->in2, gen_ri2(s), get_mem_index(s), - MO_BESL | MO_ALIGN); + tcg_gen_qemu_ld_i64(o->in2, gen_ri2(s), get_mem_index(s), + MO_BESL | MO_ALIGN); } #define SPEC_in2_mri2_32s 0 =20 static void in2_mri2_32u(DisasContext *s, DisasOps *o) { o->in2 =3D tcg_temp_new_i64(); - tcg_gen_qemu_ld_tl(o->in2, gen_ri2(s), get_mem_index(s), - MO_BEUL | MO_ALIGN); + tcg_gen_qemu_ld_i64(o->in2, gen_ri2(s), get_mem_index(s), + MO_BEUL | MO_ALIGN); } #define SPEC_in2_mri2_32u 0 =20 --=20 2.52.0 From nobody Mon Feb 9 07:42:59 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770402109; cv=none; d=zohomail.com; s=zohoarc; b=gVoAtvr3zjdYMQ4S8Am7ZpBUFOBQMuJoZT9dK/lKN4mmx9aqDvNAWouHUFXtXmq1Hm2AQStT7Fk42RZbnyKOcaM6YhFaLkrIGxyz+qvFv1Hmi+362EKFRbq3uUeIg91DNvjouXK2emQTLs3LYvP9nqjEgIsgUctF+on1gRF6Pho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770402109; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cs362kMbV2ODMlw0HAxMKgT3XjEZKtDm9LphEc59vjc=; b=bDDochQ49HwYVoNzyQypApkMQcf97Oeq7QSDgjYM2jf1ltkQNn6xzXBgYHTeQmUup6kUbplvcTjHKuRRBOl9ydRUEP/VGEQ5Nyup4GdDstK0KTuaA2/epdENQ6ptpkKvCwf1d+krnftHq5T/V0QqMwA2kQxFyA5hgrPe5xnb7vQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17704021089671020.5846375616183; Fri, 6 Feb 2026 10:21:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1voQSH-0000HO-9L; Fri, 06 Feb 2026 13:21:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1voQSD-0008Q3-9K for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:21:18 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1voQSB-0005Bj-Jx for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:21:16 -0500 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-4359249bbacso2131993f8f.0 for ; Fri, 06 Feb 2026 10:21:15 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4362972fb16sm7616411f8f.25.2026.02.06.10.21.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Feb 2026 10:21:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770402073; x=1771006873; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cs362kMbV2ODMlw0HAxMKgT3XjEZKtDm9LphEc59vjc=; b=NMoIAXblz1SKQq5sOTA3zSEwKDpBOowhc3FAPRsen13ODmdvVboddeH5qvxiZ8tC9L Axu5dA9wM/T1T1B0SkBgeFWotvUjrQjZLW+gu3TUzlnUES4KNml9QU/5ImxRkg/tE1rm WYqK+gW7haRg5T4ygpNpXLe2ViEcmK6IlMWpy1f5/quO1cjxEtEsDV+2PYyMwMz7Pyvk VJi9QAj3uBI1mJMjp7ku7vN2poLzNYWaJmarrT7LJK7qje7gcSSfpujFUHeR4OvBcUCG FjW88glTpnigY93ve6lsYklhK7ml5aioU+PaMWTjpbyFGYPih9VAlhpQzlhqD4OGX/0j yZ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770402073; x=1771006873; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cs362kMbV2ODMlw0HAxMKgT3XjEZKtDm9LphEc59vjc=; b=wHbhzJDMDK7rvjlSCYkVNES5g/bS9/GWnwu2hfjMBh1oCnKjgxVQ5uNylF9NQgJT/G O9rTWZUD/OrGGmSK3MJ4fJx4kpIRPmmSJs+GN6MTv/KbS3kCaHY1QLgGt6Ut9bBgOSc4 ecNK56YM8e1oJUW16HveaeXIxbJmZTvIexkqJYg/o+V6NgYOUMkbjmmqHTVUXGMaTsMo EmYhDUvYOu1jxAAHMKD1UvXgqlJARHpbhbmBvHDPfZoZH1Kr11dvjilaYxqtMpM5KBfr Yz/zlVdX6O3EAGzsOYwoc4QYtMXPS5kdpYUa/Swk/BTQfwBkZeugJlU0xnEXBqasOE4/ RHXA== X-Gm-Message-State: AOJu0Yyid2nBVEdb1J8lpfWm8cI3PPXjmZ42PpwODuxT/da08pS2ckAM b8jEh+npIyVHzEQE9CGlnpQkGpwCu63RfZFhKW+bZ+576G89yMYlmRZJvjRErJI5kAkH1xwJiQ6 IedjCL4Y= X-Gm-Gg: AZuq6aICPOpQF8gHwiWencn6OnXsU0TybNksGY8Eyy8zwMeWsg+NsDbKfDbxpFIIaGm hafYY3GfLGYVahuM/wBvVi+weOAWUQOygrU1wIZDDw1BhBBOCTcR7br2MNGoNEjK9EaN18F7swO bdhU6rPvjpck75fhJsHQZ9XTe4Jl5NCiBD9Rr+zhQC7QvNEiyCHSadCkvHSGYiYNZ3pl3ReLebU pxchgcSZPYO8qyvjY8ljmtRPGBvnvctiipjeu8CZBcVKO6LqPclToh25/Y9JC2GZslo7XkN7aFN ssaAUErqIJ0gzUNtr1SJfxo0zVXGTtK+Ysk+VHq+1Iinzrs2Ju6gDbCyd7Hkc+zU1xTkYjSV6Cr K4aDcjQK+r62XcRM9kaQ1cdqfDoKjaU6PFqQhT+KZcFhz3NQozRPYSpQviyc6KNDhlM8Jl0sg9+ aUwpD8F84f9ZTEpJXj25zvkTdcTsB3LPzb5AJHmiMpahXJjsrDubYVMnZ3pgxS X-Received: by 2002:a05:6000:2406:b0:430:f2ee:b21f with SMTP id ffacd0b85a97d-436293448eamr5865504f8f.22.1770402073077; Fri, 06 Feb 2026 10:21:13 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Matthew Rosato , Thomas Huth , qemu-s390x@nongnu.org, Ilya Leoshkevich , Halil Pasic , Richard Henderson , Christian Borntraeger , Eric Farman , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 10/10] target/s390x: Expand tcg_global_mem_new() -> tcg_global_mem_new_i64() Date: Fri, 6 Feb 2026 19:19:53 +0100 Message-ID: <20260206181953.18683-11-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260206181953.18683-1-philmd@linaro.org> References: <20260206181953.18683-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770402110173158500 The s390x target is a 64-bit one, so tcg_global_mem_new() expands to tcg_global_mem_new_i64(). Use the latter which is more explicit. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- target/s390x/tcg/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 4dabd49840f..203afe265bc 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -217,9 +217,9 @@ void s390x_translate_init(void) =20 for (i =3D 0; i < 16; i++) { snprintf(cpu_reg_names[i], sizeof(cpu_reg_names[0]), "r%d", i); - regs[i] =3D tcg_global_mem_new(tcg_env, - offsetof(CPUS390XState, regs[i]), - cpu_reg_names[i]); + regs[i] =3D tcg_global_mem_new_i64(tcg_env, + offsetof(CPUS390XState, regs[i]), + cpu_reg_names[i]); } } =20 --=20 2.52.0