From nobody Tue Feb 10 09:10:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770373670; cv=none; d=zohomail.com; s=zohoarc; b=MSo2K72qEbiG0x5iGQUKk9vIb5Likv9WV5+ywdMuLukjsx/rDAW1QrxtPgwIt/+YPd3sBNBrSjULIh7BUjlSAt5V4EG0sQBwFwlmAniierSWjqGX5tTmaKZ5GORTETSkc4/0yeZN4s7AQiZMCj31vW/4jrBxshG2Dc1RFUlMEzI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770373670; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tiiSvKf90gSVLdk8ZbuglWutyjV/XckwzYPcdDLKSsA=; b=OMMVvzfTNdwnjUhqGSCm9xeaZwHAtofFEjx/+NDa5nSZpJZt3IKqxENUB+IoGyLJKwAECn9VY/UNlfjjFGob7wZu1uKGbQLdCBjWYBGakOK6jn1Q5C54sdkyiHwlKfRmWnMdrLSzKfp+P08/dmvuueP+EFb78gMteNGMWdlqI08= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770373670559689.3816444595344; Fri, 6 Feb 2026 02:27:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1voJ3e-0001TF-0m; Fri, 06 Feb 2026 05:27:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1voJ3T-0001SJ-10 for qemu-devel@nongnu.org; Fri, 06 Feb 2026 05:27:15 -0500 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1voJ3R-0007TU-8G for qemu-devel@nongnu.org; Fri, 06 Feb 2026 05:27:14 -0500 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-34c868b197eso1461725a91.2 for ; Fri, 06 Feb 2026 02:27:12 -0800 (PST) Received: from stoup.. (bg30dhzpdc341w7g29yn.ip6.superloop.au. [2401:d002:dc0f:2100:1ced:e57b:71bf:567a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-354b1f49191sm2113723a91.7.2026.02.06.02.27.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 02:27:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770373632; x=1770978432; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tiiSvKf90gSVLdk8ZbuglWutyjV/XckwzYPcdDLKSsA=; b=et3eyf4TwYT2CqPMcY/0lsSlUDvAZSofU9Usiq1+g1bqbK2Pi5LaM0C2z+BYYLkGLC /2PrP+Tt9yJn7O3N2ADJ6E/gyEsDUkw9H47eYSX6mQl7EdZ2kqFrz6mPLcjLhdSQjAnY usA6LZ5S6XrgNBsLd7QtQb5ZGtqGjBygALwAQxuzsIfqgjzi2wnS34IIxOO6SRGi+M05 lQz5ZKtTI0An40sEu2AigoRVfpJHEs20ptPMVjDFR8Gvcs0pF6hTDvTmdf1okFu6A17l bgKrn6hpha9KUt+KZB0oPNI5RSliAgxtcRXQMTAb1K38wYqSaDxHrYlmoc1vEBibHXBy n4DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770373632; x=1770978432; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tiiSvKf90gSVLdk8ZbuglWutyjV/XckwzYPcdDLKSsA=; b=iPACBjLFQsDEIkrgLbJ6wirjnh3yT5vezeGASvZD6RRRYVQJN3wF1yOMtEmYdjPvfi Dik8j8i9l6p6CBF9A5m70j9Jzqq42b4lShy9jpui8Gd3zcphSG/CVoSQczBY8ZoLEesP ZX3zFLw3bYnRfZaYmT8+4nxa0fvp0k37cI62mMDu2Q/v5X2uTE0/wGSs5ylQMJdTlzcO SJMsV6R6PZ9TxiwyD9IQ+Nb15w4VITFq1QmQefsPLZwW7lxGr9cPswJiXUtzE+29LPts zOZH983J+YQnMOaIkyhQG9hMbis9aklcRJNexTAJICnHXWGmjNkih1yutBwMjPwenx3Q pwTA== X-Gm-Message-State: AOJu0YxpjOcUVvgdKGzUPSSd4A4V1vJEwMy4/gbHk++vye48pBOf6EZd RconfNXBahGVMmNPefq+FtUTo6mD4VDOhwVhZ+qjHMoE2smsHMdsNHUZaV034OhDFkD5BEq/Efi GBnDDZnNOpA== X-Gm-Gg: AZuq6aKdSRawxE3WKD2jEE+dKFS+ZYrsZkbiXt+b/Gx56VOBKWW7y5ND5+CUpcK7j3D F1KHqL9ezXscaTkqfMcIEzWsJVNSEKZB3FPv/Qme2RiAbjyGmW5tznfqhuLI51x34qqd19f5rbX VZhmjCHP+xVlInfhx1PecuZS62yI68ts+0G0TZceIbdJCBpbXB2zWIux6YopSiKwNSKcWMCEfdF +iQzcBEfADgnFr7y5DdkC8gf3fhrMXiQg0uCNPWYbbu5ZISPBL0uL1lW1ohcoZK8pYCSJbZNoPr ZIOI2xoGDOt2DvXDm/lBFXpzKFBYNNvgTq4FQYYyikayeIFcgODTjMhrD1bIFAOV/kgh++VPxAV HsUe05gPHd9Mf5oyylHDPIvW6Is4RoxKn1rS32Ax/OCQXcUNX1Ae64D/I65C7Z8RpyWAIUGyLfO Ns32HP5bCfnJyxIzT/H88AUXcb4j3xHL63AdOcNAZqrKSDsMBef+Ay5LEY8R92DlU= X-Received: by 2002:a17:90b:2d8b:b0:340:ff7d:c26 with SMTP id 98e67ed59e1d1-354b3be0b36mr1976306a91.16.1770373631516; Fri, 06 Feb 2026 02:27:11 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Jim Shu , Gustavo Romero , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 5/5] accel/tcg: Remove a redundant argument attrs in io_prepare() Date: Fri, 6 Feb 2026 20:26:52 +1000 Message-ID: <20260206102652.164018-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260206102652.164018-1-richard.henderson@linaro.org> References: <20260206102652.164018-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770373672849158500 From: Jim Shu attrs is already in CPUTLBEntryFull, so this argument is redundant. Just remove it. Clean up commit 94c6e9cf04409e38563080348d6136879f91ffee Signed-off-by: Jim Shu Reviewed-by: Gustavo Romero Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20260203142737.2164763-1-jim.shu@sifive.com> --- accel/tcg/cputlb.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 3d75abbe68..d6115bbb0a 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1271,7 +1271,7 @@ static inline void cpu_unaligned_access(CPUState *cpu= , vaddr addr, =20 static MemoryRegionSection * io_prepare(hwaddr *out_offset, CPUState *cpu, CPUTLBEntryFull *full, - MemTxAttrs attrs, vaddr addr, uintptr_t retaddr) + vaddr addr, uintptr_t retaddr) { MemoryRegionSection *section; hwaddr mr_offset; @@ -1974,12 +1974,10 @@ static uint64_t do_ld_mmio_beN(CPUState *cpu, CPUTL= BEntryFull *full, MemoryRegionSection *section; MemoryRegion *mr; hwaddr mr_offset; - MemTxAttrs attrs; =20 tcg_debug_assert(size > 0 && size <=3D 8); =20 - attrs =3D full->attrs; - section =3D io_prepare(&mr_offset, cpu, full, attrs, addr, ra); + section =3D io_prepare(&mr_offset, cpu, full, addr, ra); mr =3D section->mr; =20 BQL_LOCK_GUARD(); @@ -1994,13 +1992,11 @@ static Int128 do_ld16_mmio_beN(CPUState *cpu, CPUTL= BEntryFull *full, MemoryRegionSection *section; MemoryRegion *mr; hwaddr mr_offset; - MemTxAttrs attrs; uint64_t a, b; =20 tcg_debug_assert(size > 8 && size <=3D 16); =20 - attrs =3D full->attrs; - section =3D io_prepare(&mr_offset, cpu, full, attrs, addr, ra); + section =3D io_prepare(&mr_offset, cpu, full, addr, ra); mr =3D section->mr; =20 BQL_LOCK_GUARD(); @@ -2492,12 +2488,10 @@ static uint64_t do_st_mmio_leN(CPUState *cpu, CPUTL= BEntryFull *full, MemoryRegionSection *section; hwaddr mr_offset; MemoryRegion *mr; - MemTxAttrs attrs; =20 tcg_debug_assert(size > 0 && size <=3D 8); =20 - attrs =3D full->attrs; - section =3D io_prepare(&mr_offset, cpu, full, attrs, addr, ra); + section =3D io_prepare(&mr_offset, cpu, full, addr, ra); mr =3D section->mr; =20 BQL_LOCK_GUARD(); @@ -2512,12 +2506,10 @@ static uint64_t do_st16_mmio_leN(CPUState *cpu, CPU= TLBEntryFull *full, MemoryRegionSection *section; MemoryRegion *mr; hwaddr mr_offset; - MemTxAttrs attrs; =20 tcg_debug_assert(size > 8 && size <=3D 16); =20 - attrs =3D full->attrs; - section =3D io_prepare(&mr_offset, cpu, full, attrs, addr, ra); + section =3D io_prepare(&mr_offset, cpu, full, addr, ra); mr =3D section->mr; =20 BQL_LOCK_GUARD(); --=20 2.43.0