From nobody Mon Feb 9 12:43:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=unpredictable.fr ARC-Seal: i=1; a=rsa-sha256; t=1770301864; cv=none; d=zohomail.com; s=zohoarc; b=Y5Ht1UiuZ4kJ2AlXUkwbiljqvvBRMEeJgrqYzYuZB0JbxMuR4Bf/3nGLNDocZGBuRICRzxtp9Q14nA8O2hKqR5llXdLI8+3FM0UL9XW2ppyq1H/KxxjxVPb4/tXwvRGO8bm6yg8DlucJ5TruGDiYHUtNDlNbuQW4PoI5GomsXk4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770301864; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=C1DYbSEFYo2ZgjBenQ83qKhjOaZ2uyIVgfAe3esAA4k=; b=cZ9BI/hrhOWMwA/XfJieQRqEQ0F6IN8QHvdlU4iYkST6oFAVg6zNd3D/pfVLppul2NiH8gaEP4ScQDnHM+FErLFVywAJWjOXcIIPyRdqn1rRdp6BeTiKoNLv5xR5IEBifVgxGNqxAW/wVau1MMvCGSNuZi19DnOLeS/ms2tBxGQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770301863565637.4751425930046; Thu, 5 Feb 2026 06:31:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vo0JR-00011N-9H; Thu, 05 Feb 2026 09:26:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vo0JO-00010N-Rx for qemu-devel@nongnu.org; Thu, 05 Feb 2026 09:26:26 -0500 Received: from qs-2003e-snip4-11.eps.apple.com ([57.103.86.53] helo=outbound.qs.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vo0JM-0007xX-Uh for qemu-devel@nongnu.org; Thu, 05 Feb 2026 09:26:26 -0500 Received: from outbound.qs.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-east-2d-100-percent-2 (Postfix) with ESMTPS id 37A9D1800D99; Thu, 5 Feb 2026 14:26:17 +0000 (UTC) Received: from localhost.localdomain (unknown [17.57.155.37]) by p00-icloudmta-asmtp-us-east-2d-100-percent-2 (Postfix) with ESMTPSA id 775F2180027A; Thu, 5 Feb 2026 14:26:11 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; t=1770301583; x=1772893583; bh=C1DYbSEFYo2ZgjBenQ83qKhjOaZ2uyIVgfAe3esAA4k=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:x-icloud-hme; b=CLx3BuuSLQDUoNn5rdemxYO1XzMGT/HIpfEnNnjkSUQiKOvnGP67SuvlmHZN2cRG++ZuTv/Yn0hYYCxu7bWGDf+TJVeKAM/xNfmuzGKQP7C+dr04i6XmxoLFvCAbYbLHWoIZK7cv/YY2BCkVmVB6qMcTsnIRggy9MDVN3Ht8yRJQvFUMNDnn3CJ3MhJlMMhUxYAfp0dG2/jgn1KxaKUDlIY665MnnB2Fl5T0Z2KrKfvNVoopxoB6wvArzH/SnYWw1CDcFYJxU9XKwu0aH8b2RwmKhNXRn+8yXemm9tm+YQA70rK50El1PwzjU53YlJfCk9nQw+2Z6fUgTuRDNF8S5A== mail-alias-created-date: 1752046281608 From: Mohamed Mediouni To: qemu-devel@nongnu.org, mohamed@unpredictable.fr Cc: Zhao Liu , Paolo Bonzini , Akihiko Odaki , Cameron Esfahani , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Shannon Zhao , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Phil Dennis-Jordan , "Michael S. Tsirkin" , Richard Henderson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Alexander Graf , Pedro Barbuda , Yanan Wang , Ani Sinha , Igor Mammedov , Marcel Apfelbaum , Peter Maydell , Eduardo Habkost , Roman Bolshakov , Pierrick Bouvier Subject: [PATCH v21 09/22] whpx: Move around files before introducing AArch64 support Date: Thu, 5 Feb 2026 15:25:27 +0100 Message-ID: <20260205142543.64818-10-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260205142543.64818-1-mohamed@unpredictable.fr> References: <20260205142543.64818-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDEwOCBTYWx0ZWRfX+2pFtDEqcdsq /ajutdF+KodxDb01/yRK9X1UOjlkEgGq042Vrba/4+o0Ka0z5dVnwE0CvPtm8r3Dzn8tbtWW61L cqbWxiR5QLC+H3mxdbtCrwVDFjr0LOfKyCOaPKmUCVGACKjqZfR11rgbfPJ9u6lHuT3w6OM0g9l 5iPGWYY12RIPSceBjv6mKmnUSG1vu/wvZAjwF/RmE2nyXAWQjE1IkNVY02w5v/V81v72SstmzqC LwBzfqeYvPzGhCXXnMBK0LhnKIP7aOszFYxe7rKwU1uXHqJV85VRSLCzqNazMhWobW3tfo6XXQY lXEaV/OuDdvoBKibE7T6Od3y8ZjvmPU5wKrPGavZ8PfPtLd638T/JC9ox89kIQ= X-Authority-Info-Out: v=2.4 cv=G7MR0tk5 c=1 sm=1 tr=0 ts=6984a88e cx=c_apl:c_apl_out:c_pps a=bsP7O+dXZ5uKcj+dsLqiMw==:117 a=bsP7O+dXZ5uKcj+dsLqiMw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=yMhMjlubAAAA:8 a=5-iGLm-LtT_B5TT3xKgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: w_qlr_yM9IWLv9Nyrj7TZTiw__qhomQ1 X-Proofpoint-ORIG-GUID: w_qlr_yM9IWLv9Nyrj7TZTiw__qhomQ1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_03,2026-02-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 clxscore=1030 bulkscore=0 phishscore=0 adultscore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602050108 X-JNJ: AAAAAAABlSPzBGmD01DJa+s1gvjZLIvDP7x+wTkKQq3RJRZJ5PR1ZS7leDTS9Wlgj5m6ujlimZpWL6SIK0Tj/wNylv6hwqo3njcjCZlsNTXUygxBRWWcYsxZuZHrMmeP9bqQcUpw1wIXlFdujEf98xp32zICNEv4B5JY5AEF+9/wA70+vqWQJLUZJx8o4EWXplydCJTv6CosX9W/mC47vhaF+5pR+mHfPXxpwm17e9RM/YIZO6ZI7Oy8XPN/5wXgLE5AjNi8uZL9uPQYExUfKwHlULUX8g2fvmEjqONlSLD14379aqQX6/ra5+5YfMo8WOMLOV952yKRjWtzDJykWSC0RTrqbqXbMDz2ESpd5QhDJaigpgim642rIdOYmd/qiMZEs38WOgnbjR3+ixRwAupqB4rXNwKclyGSq/03iQLE6t0LT9j8iEk7dWQMNLwWxyEsUG9YboLSJbsdgmED2cDEJ6V140IzPcwevqHSJQ9y5HoxpGRhdlp9PvRpUswnPUMLDEW5PQSot2ecWpjdOEihWAiE6/FqeZLoBpmbDrUlOvDznjX27r6DLryefRzraz/JznvuMAM0Bitq9vDXIStYiuQ9CpuhLs8A4sQKRN75jHYqxlMnaBxTS0YwqysRz0/n7mn9gq7v04/SbDKSIBEFv/8MDdiyr+sxESJ58apKnkwfD0dUgRIjPnFn0D5vkqGBZwyM+EjsWgVEH57zXTnNqp8OiaDfnaOWXQYKeWc75930jn0iE7Y6tI23gXa9me9Y3UlJKxrpvYIy6ukq5T+CcZNiT2Rfd/eUaCrO4Z5r8lWn+m13zR7Y/Wp2NxloJwXk/UhsNWqwbCQV0DF5u75W8KiFEZMbarq4CdYHWRsSDbu/colbYFh6cvHy0VwjQK2swDkygPok+NXNJe8H7hEpcKWL8lUqhnTO5jQ0loCe/BD4Jj2OcyrSNuN6P0heUEK0fcpo2BjjwSAvqtA= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=57.103.86.53; envelope-from=mohamed@unpredictable.fr; helo=outbound.qs.icloud.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @unpredictable.fr) X-ZM-MESSAGEID: 1770301865756158500 Switch to a design where we can share whpx code between x86 and AArch64 whe= n it makes sense to do so. Signed-off-by: Mohamed Mediouni Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Pierrick Bouvier Reviewed-by: Akihiko Odaki --- MAINTAINERS | 2 ++ accel/meson.build | 1 + accel/whpx/meson.build | 6 ++++++ {target/i386 =3D> accel}/whpx/whpx-accel-ops.c | 4 ++-- {target/i386/whpx =3D> include/system}/whpx-accel-ops.h | 4 ++-- {target/i386/whpx =3D> include/system}/whpx-internal.h | 6 ++++-- target/i386/whpx/meson.build | 1 - target/i386/whpx/whpx-all.c | 4 ++-- target/i386/whpx/whpx-apic.c | 2 +- 9 files changed, 20 insertions(+), 10 deletions(-) create mode 100644 accel/whpx/meson.build rename {target/i386 =3D> accel}/whpx/whpx-accel-ops.c (97%) rename {target/i386/whpx =3D> include/system}/whpx-accel-ops.h (92%) rename {target/i386/whpx =3D> include/system}/whpx-internal.h (97%) diff --git a/MAINTAINERS b/MAINTAINERS index 4c35249a18..69a7a3567d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -564,9 +564,11 @@ WHPX CPUs M: Pedro Barbuda M: Mohamed Mediouni S: Supported +F: accel/whpx/ F: target/i386/whpx/ F: accel/stubs/whpx-stub.c F: include/system/whpx.h +F: include/system/whpx-accel-ops.h =20 MSHV M: Magnus Kulke diff --git a/accel/meson.build b/accel/meson.build index 983dfd0bd5..289b7420ff 100644 --- a/accel/meson.build +++ b/accel/meson.build @@ -6,6 +6,7 @@ user_ss.add(files('accel-user.c')) subdir('tcg') if have_system subdir('hvf') + subdir('whpx') subdir('qtest') subdir('kvm') subdir('xen') diff --git a/accel/whpx/meson.build b/accel/whpx/meson.build new file mode 100644 index 0000000000..7b3d6f1c1c --- /dev/null +++ b/accel/whpx/meson.build @@ -0,0 +1,6 @@ +whpx_ss =3D ss.source_set() +whpx_ss.add(files( + 'whpx-accel-ops.c', +)) + +specific_ss.add_all(when: 'CONFIG_WHPX', if_true: whpx_ss) diff --git a/target/i386/whpx/whpx-accel-ops.c b/accel/whpx/whpx-accel-ops.c similarity index 97% rename from target/i386/whpx/whpx-accel-ops.c rename to accel/whpx/whpx-accel-ops.c index f75886128d..c84a25c273 100644 --- a/target/i386/whpx/whpx-accel-ops.c +++ b/accel/whpx/whpx-accel-ops.c @@ -16,8 +16,8 @@ #include "qemu/guest-random.h" =20 #include "system/whpx.h" -#include "whpx-internal.h" -#include "whpx-accel-ops.h" +#include "system/whpx-internal.h" +#include "system/whpx-accel-ops.h" =20 static void *whpx_cpu_thread_fn(void *arg) { diff --git a/target/i386/whpx/whpx-accel-ops.h b/include/system/whpx-accel-= ops.h similarity index 92% rename from target/i386/whpx/whpx-accel-ops.h rename to include/system/whpx-accel-ops.h index 54cfc25a14..ed9d4c49f4 100644 --- a/target/i386/whpx/whpx-accel-ops.h +++ b/include/system/whpx-accel-ops.h @@ -7,8 +7,8 @@ * See the COPYING file in the top-level directory. */ =20 -#ifndef TARGET_I386_WHPX_ACCEL_OPS_H -#define TARGET_I386_WHPX_ACCEL_OPS_H +#ifndef SYSTEM_WHPX_ACCEL_OPS_H +#define SYSTEM_WHPX_ACCEL_OPS_H =20 #include "system/cpus.h" =20 diff --git a/target/i386/whpx/whpx-internal.h b/include/system/whpx-interna= l.h similarity index 97% rename from target/i386/whpx/whpx-internal.h rename to include/system/whpx-internal.h index 2dcad1f565..041fa958b4 100644 --- a/target/i386/whpx/whpx-internal.h +++ b/include/system/whpx-internal.h @@ -1,11 +1,13 @@ -#ifndef TARGET_I386_WHPX_INTERNAL_H -#define TARGET_I386_WHPX_INTERNAL_H +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef SYSTEM_WHPX_INTERNAL_H +#define SYSTEM_WHPX_INTERNAL_H =20 #include #include #include =20 #include "hw/i386/apic.h" +#include "exec/vaddr.h" =20 typedef enum WhpxBreakpointState { WHPX_BP_CLEARED =3D 0, diff --git a/target/i386/whpx/meson.build b/target/i386/whpx/meson.build index 9c54aaad39..c3aaaff9fd 100644 --- a/target/i386/whpx/meson.build +++ b/target/i386/whpx/meson.build @@ -1,5 +1,4 @@ i386_system_ss.add(when: 'CONFIG_WHPX', if_true: files( 'whpx-all.c', 'whpx-apic.c', - 'whpx-accel-ops.c', )) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index db184e1b0d..cef31fc1a8 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -31,8 +31,8 @@ #include "accel/accel-cpu-target.h" #include =20 -#include "whpx-internal.h" -#include "whpx-accel-ops.h" +#include "system/whpx-internal.h" +#include "system/whpx-accel-ops.h" =20 #include #include diff --git a/target/i386/whpx/whpx-apic.c b/target/i386/whpx/whpx-apic.c index afcb25843b..b934fdcbe1 100644 --- a/target/i386/whpx/whpx-apic.c +++ b/target/i386/whpx/whpx-apic.c @@ -18,7 +18,7 @@ #include "hw/pci/msi.h" #include "system/hw_accel.h" #include "system/whpx.h" -#include "whpx-internal.h" +#include "system/whpx-internal.h" =20 struct whpx_lapic_state { struct { --=20 2.50.1 (Apple Git-155)