From nobody Mon Feb 9 18:19:29 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=unpredictable.fr ARC-Seal: i=1; a=rsa-sha256; t=1770297302; cv=none; d=zohomail.com; s=zohoarc; b=hf+TGBY5DPpSGLDsOAFEAxHn30uWBsIbNQkNrrxr0SEjMdFGZ5gz9AINyOroSm+5KCKdkNH66vR3X1PoCOK7j3DxlDDc3Fx7J/M22BYxpl7LzOVVFnUNQB69JYiaVF2TPl5M5B1B9Y3l47lPecPxl2v7xZJu5fGPhVnRdnuGtVM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770297302; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dXlBjrYQLV1qCj1RHDhCy7H3jFtP7Evi4SFhHqHKNZU=; b=mFJsrt3m5UDIgDiHo0qMg7NTUu4xBYD6W6f3i/sIgrv5epXeKwTwKACTy4dx2of8MZ5yueBM+cr4xWwB/M43dQ7VvLgicFYdi7bw+P87j70UC+woxqQR+k4v+CpeaRdIBmmYdofix7OU8xODfORkjSHHzw4F28wepbVlwUqk4I0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770297302332389.3995509820654; Thu, 5 Feb 2026 05:15:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnzB2-0000zv-9G; Thu, 05 Feb 2026 08:13:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnzB0-0000mB-3i for qemu-devel@nongnu.org; Thu, 05 Feb 2026 08:13:42 -0500 Received: from p-west2-cluster3-host5-snip4-10.eps.apple.com ([57.103.69.93] helo=outbound.mr.icloud.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnzAu-0001k7-Lv for qemu-devel@nongnu.org; Thu, 05 Feb 2026 08:13:39 -0500 Received: from outbound.mr.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-west-2a-100-percent-8 (Postfix) with ESMTPS id 58FDE18013BC; Thu, 5 Feb 2026 13:13:34 +0000 (UTC) Received: from localhost.localdomain (unknown [17.57.152.38]) by p00-icloudmta-asmtp-us-west-2a-100-percent-8 (Postfix) with ESMTPSA id D983918013AD; Thu, 5 Feb 2026 13:13:29 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unpredictable.fr; s=sig1; t=1770297215; x=1772889215; bh=dXlBjrYQLV1qCj1RHDhCy7H3jFtP7Evi4SFhHqHKNZU=; h=From:To:Subject:Date:Message-ID:MIME-Version:x-icloud-hme; b=JeWRtP4YfiCvuyBd5n5UM+KJYM/J8ugUfBULeWDoRTB0CFrcD/dnxDysNiyXBJmwkA87GWw35g37eADFIrhd7kjb99TRTORClkfMFzxm6lTRXlaFkmM8qgidcSDWHIyloWW4LDMAVr6NI73ulgvAF4S7Ph99P/5wXUz29n9Eoat7PQI/eKlMizTXmCaY/ZTd8GRN6n4ZSDqcETb+UO7xyUZWG1BgDsZz92GeYuD/F3jRPFWT4bAu/p3HXdrgVSnICcIQAIZbTas99Zi5RPqS8R7wxrd+50aKivqHXpAn1xRbMKM6sih1LPuavPGCL8erJpzgqr7cHk2hGN8eNdkm6Q== mail-alias-created-date: 1752046281608 From: Mohamed Mediouni To: qemu-devel@nongnu.org, mohamed@unpredictable.fr Cc: Akihiko Odaki , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Marcel Apfelbaum , Richard Henderson , Peter Maydell , qemu-arm@nongnu.org, Zhao Liu , Roman Bolshakov , Igor Mammedov , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Cameron Esfahani , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Ani Sinha , Yanan Wang , Eduardo Habkost , Paolo Bonzini , Pierrick Bouvier , Shannon Zhao , Alexander Graf , Phil Dennis-Jordan , Pedro Barbuda Subject: [PATCH v20 20/22] target/arm: whpx: instantiate GIC early Date: Thu, 5 Feb 2026 14:11:49 +0100 Message-ID: <20260205131155.22780-21-mohamed@unpredictable.fr> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260205131155.22780-1-mohamed@unpredictable.fr> References: <20260205131155.22780-1-mohamed@unpredictable.fr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Info-Out: v=2.4 cv=Pf3yRyhd c=1 sm=1 tr=0 ts=6984977f cx=c_apl:c_apl_out:c_pps a=9OgfyREA4BUYbbCgc0Y0oA==:117 a=9OgfyREA4BUYbbCgc0Y0oA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EYz79TNVRTG0waESW9UA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: kzb3O3P6X8-GeIISz3weWsSzonM6C9Ny X-Proofpoint-GUID: kzb3O3P6X8-GeIISz3weWsSzonM6C9Ny X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA5OCBTYWx0ZWRfX3dvba7s3Xmhk Vn4MTY4wjv49cLmU2o4P5yVP8y35wHLL3ws3mXh8GlT2EVcPeMDdcLAo3nS9TumkmjUndMa6Tuk BaoJd1PPkmlERzdrAo9KmaJjJpYNm5544zO0yIj2cNS1HTxHJJ8UrgVp+dhMD9ct59bdUhkZ01/ 8FnYo64iOh+FmxpqwCRWY2tLOTUfDfLPJYmnjGQU1n/+Po6N2BmwwjfgnLR7AJsezJ1qUoA+nxC LC19dueK+zBjlWv1fo6cBQwoh9gyF8BuXz6qmzzyIESKml3qFOcGaqmwHJChhF/Z1WG5IbclMxd vGJCn3aZM0ZbdS4P/seNWeVTWrhezaOBQX2ZE1Akcv5HRbsA6oA+gVGddrL8DQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_02,2026-02-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=994 bulkscore=0 adultscore=0 clxscore=1030 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam authscore=0 adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602050098 X-JNJ: AAAAAAAB8k5TJGMgXs5ErlxVMXwc06YWmLHs2Zbd7c0GRu6QtM3PJYPXXg7bUdC3YjWah+Ob/lAvA8FILYf8naDJidNgn5ILMLP37pflBkd91OE+y7qj6GZigkjD+t8JKUfNx8awTXAu5EKa6I16lW0S/BC4rSwrj+FCgbfhoBYkuyZgKwJHHd97t5vxXpGXVmpnMABFfKZTTy/qAac+6KbUUgz6bBCponJPqmKVVKnVcD2/SJKNRb1/y6GP8LNZb/nzf3HevLNf7wBYFV68zayX3o0CA03f5JBs7VzFZrGawWcBmmtObXNGcQquAbtcisQ1DFW93K6ozh/vl/FJiQD3p5waY2DIa5/tmW0+iUR6ejnFKoRNxPMCxde8ne6ow7B+D1btBzv72R0I2isNlbsT7JCaQb+JtebsqdUDgSRX9fS5UKc9pBj0Pn7+mGLMsup+hrHVi4V1UpaXBrYf538jXJsDY7GbmKn3WTaWcGlXDUJrC0vPv2hXlIrlr2JBpXSJc459Rvjr91TLIc3lslp1oFZ5mlQg4DHZ0t0iZSLWZV6bR7vMaHxqATmaeDH++hnbuBCsatNFEHDVT8Tm9uuuriBxm8ssipqRaGtCXcZFk6ReDB9SzJu3K6UjQX1OvN5CIE/gwrbNBVRbIXthV4xJJm76880/3nhr0GEnOIMl52jgOojcGpbTheyxg8UAKkx1mvP4Cv6wn4KXbzXyPQZHYt2dzGncBGVIDikgIW4/IRvMEvvjRAhboRryW7vh9VmHeIzCc4k2puW0HddmmlO1vRVbu8p1r+7+3ZhJW2Awd5FCMjaIR+DPi2Bu7SdQ3leF0uUOJhB0Q3MBJwVT2aUFez1dmeWkVc5FBm/LDBmlxQamhxrAGYZehx/hW4RvHMGyKP8QAbePMSIABHcMbamPsRtUE/XekqO70fn+icSMP4cfwv4gBK4ER4o= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=57.103.69.93; envelope-from=mohamed@unpredictable.fr; helo=outbound.mr.icloud.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @unpredictable.fr) X-ZM-MESSAGEID: 1770297304072158500 Content-Type: text/plain; charset="utf-8" While figuring out a better spot for it, put it in whpx_accel_init. Needs to be done before WHvSetupPartition. Signed-off-by: Mohamed Mediouni Reviewed-by: Pierrick Bouvier Reviewed-by: Akihiko Odaki --- target/arm/whpx/whpx-all.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index c88c67a9e2..44ef42307b 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -939,6 +939,38 @@ int whpx_accel_init(AccelState *as, MachineState *ms) =20 memset(&prop, 0, sizeof(prop)); =20 + /* + * The only currently supported configuration for the interrupt + * controller is kernel-irqchip=3Don,gic-version=3D3, with the `virt` + * machine. + * + * Initialising the vGIC here because it needs to be done prior to + * WHvSetupPartition. + */ + + WHV_ARM64_IC_PARAMETERS ic_params =3D { + .EmulationMode =3D WHvArm64IcEmulationModeGicV3, + .GicV3Parameters =3D { + .GicdBaseAddress =3D 0x08000000, + .GitsTranslaterBaseAddress =3D 0x08080000, + .GicLpiIntIdBits =3D 0, + .GicPpiPerformanceMonitorsInterrupt =3D VIRTUAL_PMU_IRQ, + .GicPpiOverflowInterruptFromCntv =3D ARCH_TIMER_VIRT_IRQ + } + }; + prop.Arm64IcParameters =3D ic_params; + + hr =3D whp_dispatch.WHvSetPartitionProperty( + whpx->partition, + WHvPartitionPropertyCodeArm64IcParameters, + &prop, + sizeof(prop)); + if (FAILED(hr)) { + error_report("WHPX: Failed to enable GICv3 interrupt controller, h= r=3D%08lx", hr); + ret =3D -EINVAL; + goto error; + } + hr =3D whp_dispatch.WHvSetupPartition(whpx->partition); if (FAILED(hr)) { error_report("WHPX: Failed to setup partition, hr=3D%08lx", hr); --=20 2.50.1 (Apple Git-155)