From nobody Mon Feb 9 19:30:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770237690; cv=none; d=zohomail.com; s=zohoarc; b=As4zK6A2JspkY7oJIMUPmU3cX15PTwQ98W9sIG/Fx3CIXWfuezsJnCdtFzX+Wx2I1U7sA27RyAURf87t7M+2YUxyqj1CQdR35geR6Pet3HpX+TBlMUGITvo944jDm/HKr51VTQaPLYorieeHlrMT+OxWcx9tMnRfgVS1qnXntCI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770237690; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OBZUhK4NBIfVwwKndj7XLGMI5lFYBXqizdp8CnNTnt0=; b=TJCw9zr3hRCbhlnqMQ0aHPNoRj1tPSvjAc7QjAJxxwwFQuSx74zvemTkm59Gs+loXrjPB1CaTNAJYJRYhRx2vleNfZIP+PD/BDZB/YsfNR5x3st3RcPVV6BUTOrEkzxlKyoRraKHA6Q6wtlw6rOAmIsmxK/qmlZbyOrYtgKIPls= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770237690875652.380503691199; Wed, 4 Feb 2026 12:41:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnjgc-0006R3-3G; Wed, 04 Feb 2026 15:41:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnjga-0006Qg-2v for qemu-devel@nongnu.org; Wed, 04 Feb 2026 15:41:16 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnjgY-000378-9z for qemu-devel@nongnu.org; Wed, 04 Feb 2026 15:41:15 -0500 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-4359a316d89so228852f8f.0 for ; Wed, 04 Feb 2026 12:41:13 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4361805f8c1sm7300776f8f.37.2026.02.04.12.41.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 04 Feb 2026 12:41:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770237672; x=1770842472; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OBZUhK4NBIfVwwKndj7XLGMI5lFYBXqizdp8CnNTnt0=; b=BFt4gSwJ/324hOx7XNcOnuyst7bWkZScLiY49x5iBD/NP0R8cTt+C/cOkzISFd8ydg /KGKWjNlAzI7jhW61AXz6aWwOvd7IxIggaFzXSK8RsYGKo6Cl1W7J4E+xRwpYqJgE9Dk VVNOtJV48U0asO6Xim7XFwzDo9FtaUBS4KpdOKtLBjkvM5rekSrDCU/IVxKud2b+wWnV EV/F8DnegFWWdFqbwsUR4Kw/V5s2ynTKgQGib5w8AMyKKwZ/wIUp8v7P8JsomC72uM5K +ro2EbwZJNFhnmZErN3rToW6ACEBk02aSUsupZFZPAMCTD6FFpwj/UVzDpl+ml6YfgJC omZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770237672; x=1770842472; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OBZUhK4NBIfVwwKndj7XLGMI5lFYBXqizdp8CnNTnt0=; b=r/SZJnQIvePqlkBc+Qg0Ca4z+VAg46+6C3JRbcmTW5lclPqly2TUToHy7oxYlnFVXG CBV8OJyJs1kK+uS4Dae3Bpl4Je/cMsZBFV9NDo7D6rrAUsFG5ssj8sUyeCU1TGbUIokH t0waxijyPtAEB2M26WedO7JazPBuLOdT3iZG8PZWECH/QWwVIIsYp3QUZVDLIQT+Gc/s 8OTQF5YXP3fIfekpKBnCP0pjKAzdsSdROW7KR5szguwu6mOWVDVSJxIRNdqfTRrWMLro /rV0TXJU774BIMhcEFwAXipdAp2yvwFJ4FmoKIh6xjBQJ2YuIV0nUg7BgeOrv1cLTmSO 0QwA== X-Gm-Message-State: AOJu0YxkSRNVetckgtExSPJkyuGBmB5WaM8KKlShGeY+MhavLyO1bjaT qO9EUzpClAy/IR+sDoOI/Rjt+X5xunji1oNvEQxRM0T+lAFgoH/wU7XMz9s5QdQ3plw7pDRCMYX 0pVlIO2c= X-Gm-Gg: AZuq6aIXTwqAh5cWr7mPRrqsxc3EYylvn++EnDb2NgDA2TUjrbZix4oJMGHE8z5Tyj4 f1VpPCqDQrE7F28zBP+LTJSEduBvIfaOsvfHQEhYQyvwO4DTzPS6dH0J2uYMBIoBEm8aTgnzpab dCupxIYgr+nfJhQaD7qOCvZMS18R3PtVDI9UOhIyN8nvn3S5fGe99rk7CdhKARPf+FZLT3Gtqtf WmDEWlksx18RqNCApWLJSRSpdsvxph3Ix89puES3Gz0ohmZgID4zGYN6Ps2Xc8K7ppDpEjyNezt ca1/cDBTSyCCgNhqoaLbfjnjNLkB9rHbXWLx3dtAMXzaNKTlNlc4B7fXw06TN4ttOHpI8TkBhbH oB+2vBFYBZoX4p6p8wEXODYD+GpnZsr2+v5UAjZi7JVKPrwnMAWM8uMAMb2jfqpQzZY051Zafga DbQLenalDUPkCsDDEso+EWixpp6+b+OyigiBNb7XiPngYwVQBlsGvOK/lvJKMf X-Received: by 2002:a05:6000:2207:b0:431:3a5:d9c1 with SMTP id ffacd0b85a97d-4361805500amr5849739f8f.30.1770237672332; Wed, 04 Feb 2026 12:41:12 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Eduardo Habkost , "Michael S. Tsirkin" , Zhao Liu , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/4] target/i386: Use explicit little-endian LD/ST API Date: Wed, 4 Feb 2026 21:41:00 +0100 Message-ID: <20260204204103.46343-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260204204103.46343-1-philmd@linaro.org> References: <20260204204103.46343-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770237693122154100 The x86 architecture uses little endianness. Directly use the little-endian LD/ST API. Mechanical change running: $ for a in uw w l q; do \ sed -i -e "s/ld${a}_p(/ld${a}_le_p(/" \ $(git grep -wlE '(ld|st)u?[wlq]_p' target/i386/); done Coding style adapted manually. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/helper.c | 12 ++++++------ target/i386/tcg/system/misc_helper.c | 16 ++++++++-------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/target/i386/helper.c b/target/i386/helper.c index f9f9488eb4d..c397a6fde5a 100644 --- a/target/i386/helper.c +++ b/target/i386/helper.c @@ -669,7 +669,7 @@ uint32_t x86_lduw_phys(CPUState *cs, hwaddr addr) MemTxAttrs attrs =3D cpu_get_mem_attrs(env); AddressSpace *as =3D cpu_addressspace(cs, attrs); =20 - return address_space_lduw(as, addr, attrs, NULL); + return address_space_lduw_le(as, addr, attrs, NULL); } =20 uint32_t x86_ldl_phys(CPUState *cs, hwaddr addr) @@ -679,7 +679,7 @@ uint32_t x86_ldl_phys(CPUState *cs, hwaddr addr) MemTxAttrs attrs =3D cpu_get_mem_attrs(env); AddressSpace *as =3D cpu_addressspace(cs, attrs); =20 - return address_space_ldl(as, addr, attrs, NULL); + return address_space_ldl_le(as, addr, attrs, NULL); } =20 uint64_t x86_ldq_phys(CPUState *cs, hwaddr addr) @@ -689,7 +689,7 @@ uint64_t x86_ldq_phys(CPUState *cs, hwaddr addr) MemTxAttrs attrs =3D cpu_get_mem_attrs(env); AddressSpace *as =3D cpu_addressspace(cs, attrs); =20 - return address_space_ldq(as, addr, attrs, NULL); + return address_space_ldq_le(as, addr, attrs, NULL); } =20 void x86_stb_phys(CPUState *cs, hwaddr addr, uint8_t val) @@ -709,7 +709,7 @@ void x86_stw_phys(CPUState *cs, hwaddr addr, uint32_t v= al) MemTxAttrs attrs =3D cpu_get_mem_attrs(env); AddressSpace *as =3D cpu_addressspace(cs, attrs); =20 - address_space_stw(as, addr, val, attrs, NULL); + address_space_stw_le(as, addr, val, attrs, NULL); } =20 void x86_stl_phys(CPUState *cs, hwaddr addr, uint32_t val) @@ -719,7 +719,7 @@ void x86_stl_phys(CPUState *cs, hwaddr addr, uint32_t v= al) MemTxAttrs attrs =3D cpu_get_mem_attrs(env); AddressSpace *as =3D cpu_addressspace(cs, attrs); =20 - address_space_stl(as, addr, val, attrs, NULL); + address_space_stl_le(as, addr, val, attrs, NULL); } =20 void x86_stq_phys(CPUState *cs, hwaddr addr, uint64_t val) @@ -729,6 +729,6 @@ void x86_stq_phys(CPUState *cs, hwaddr addr, uint64_t v= al) MemTxAttrs attrs =3D cpu_get_mem_attrs(env); AddressSpace *as =3D cpu_addressspace(cs, attrs); =20 - address_space_stq(as, addr, val, attrs, NULL); + address_space_stq_le(as, addr, val, attrs, NULL); } #endif diff --git a/target/i386/tcg/system/misc_helper.c b/target/i386/tcg/system/= misc_helper.c index 0c32424d36a..bb79d4e470e 100644 --- a/target/i386/tcg/system/misc_helper.c +++ b/target/i386/tcg/system/misc_helper.c @@ -42,26 +42,26 @@ target_ulong helper_inb(CPUX86State *env, uint32_t port) =20 void helper_outw(CPUX86State *env, uint32_t port, uint32_t data) { - address_space_stw(&address_space_io, port, data, - cpu_get_mem_attrs(env), NULL); + address_space_stw_le(&address_space_io, port, data, + cpu_get_mem_attrs(env), NULL); } =20 target_ulong helper_inw(CPUX86State *env, uint32_t port) { - return address_space_lduw(&address_space_io, port, - cpu_get_mem_attrs(env), NULL); + return address_space_lduw_le(&address_space_io, port, + cpu_get_mem_attrs(env), NULL); } =20 void helper_outl(CPUX86State *env, uint32_t port, uint32_t data) { - address_space_stl(&address_space_io, port, data, - cpu_get_mem_attrs(env), NULL); + address_space_stl_le(&address_space_io, port, data, + cpu_get_mem_attrs(env), NULL); } =20 target_ulong helper_inl(CPUX86State *env, uint32_t port) { - return address_space_ldl(&address_space_io, port, - cpu_get_mem_attrs(env), NULL); + return address_space_ldl_le(&address_space_io, port, + cpu_get_mem_attrs(env), NULL); } =20 target_ulong helper_read_cr8(CPUX86State *env) --=20 2.52.0