From nobody Mon Feb 9 16:49:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=jablonski.xyz ARC-Seal: i=1; a=rsa-sha256; t=1770223615; cv=none; d=zohomail.com; s=zohoarc; b=C3NtFezvpy23Li1teOih2femf+ARdVsnMqTC5UYjVRUS15ny255zzE0YvygDsjkMjleco6FohetPwstq5EJKvhHMOSfRIWUlfF+MKSD3Iv+TwNQPwbV6m8uB8s081Qti5rIzYbkQTRGYc0XxxlJGVFTL/tv5F4RsYKpL5spDL7A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770223615; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BGK+qrVIcAnLNRs4fCH6awA6ce+4NWjLrrbX14e0/JI=; b=JwWQDxGpvnMdOAJiIAdtlqiNtPoEKsFYkDwzGrLpWbEx7EAHYnl4VM3Y3DnyMI6RsCnWC7XLYbymPpxj+GzLsTrIykshjvY1Efar+6/2B6x7TQRvC5BqLj9V8xLs/dIHe+fkZkobwoDz0i6nB65GnYWcwB0GyIRwEEAbanzUsoQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770223615852942.3773164242036; Wed, 4 Feb 2026 08:46:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vng1N-00074D-51; Wed, 04 Feb 2026 11:46:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vng1E-00071p-14 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 11:46:22 -0500 Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vng19-0004Xp-DX for qemu-devel@nongnu.org; Wed, 04 Feb 2026 11:46:19 -0500 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id 9CC307A0075; Wed, 4 Feb 2026 11:46:14 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Wed, 04 Feb 2026 11:46:14 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 Feb 2026 11:46:14 -0500 (EST) Received: from localhost (chomposaur [local]) by chomposaur (OpenSMTPD) with ESMTPA id d4629aea; Wed, 4 Feb 2026 16:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jablonski.xyz; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1770223574; x= 1770309974; bh=BGK+qrVIcAnLNRs4fCH6awA6ce+4NWjLrrbX14e0/JI=; b=m qB2F9DF9vRoEs7jtMsu4ZBDC6aQTU1i3+NGy59fSlyqM5Grr7GL2Wr5f3JDdvSct kSCJ5FpaKtq+URa+AMPQsIWkZHJGwmEbRL/i8UQDBphwF/Y02Ep9zusWwB8wyT/+ Ng9aW6/MrCLCWYFq6k5IbhqYOuYuRpTd6IsYOsFEzmCdpqDKVvXgYwHd3+Mi9/eo DWaGYYkRFxyP1xyKif7sbGjqtrGpEtxljXzvy3iSKOvITpkcfPnxGIoEcA13Wdwd zp3J1X4shmq4s4fVKoATQdIY3b2A2XnJcYde2z+h1dkow4Kcmk2VptrgoXZezij9 ldKviEpjBdlO0X6WaXpHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1770223574; x=1770309974; bh=B GK+qrVIcAnLNRs4fCH6awA6ce+4NWjLrrbX14e0/JI=; b=jpusHqDx6FtmfZHwt FSypEwp6tLtWIfStZPpG+3jpRBHT0/ZcjCpc4zsU7Nx1ob6sgMdOAZkQMcwm+iM6 60lXct5E43lJNmjhgavHOdSj0/JIDbK6TKiGeuLNFCrWzX5+2em28oxZFIFUzmF+ WVRtZYkOROwxmcLhplXNF4KIZ126rU053JDAQCOqwsKo2mElhrF30m3bxPSE3C12 yzgCndcF3iw8j5XtMof7eQP2zUoqi1XftWtq8V94qleGjsPGH2VI/yCyHmyC9Rzs D/y9ry7SmX7y8oFE3NbbPM3bQr1/MqRxaw/QhomIsqPkGmUxcRmhNWEh9MMbIIB1 RCUzQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddukedvleeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpefhvfevuf ffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeevhhgrugculfgrsghlohhnshhk ihcuoegthhgrugesjhgrsghlohhnshhkihdrgiihiieqnecuggftrfgrthhtvghrnhepgf eiteejhfelheefieetjefgleejfffhueffvdduieejgfeuueeuvddvkeejhfelnecuvehl uhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomheptghhrggusehjrg gslhhonhhskhhirdighiiipdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopegthhgrugesjhgrsghlohhnshhkihdrgiihiidprhgtphhtthhope gsrghlrghtohhnsegvihhkrdgsmhgvrdhhuhdprhgtphhtthhopehqvghmuhdquggvvhgv lhesnhhonhhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib26944c1:Fastmail From: Chad Jablonski To: qemu-devel@nongnu.org Cc: balaton@eik.bme.hu, Chad Jablonski Subject: [PATCH v8 14/18] ati-vga: Remove ATIVGAState param from ati_2d_do_blt Date: Wed, 4 Feb 2026 11:46:02 -0500 Message-ID: <20260204164606.3425246-15-chad@jablonski.xyz> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260204164606.3425246-1-chad@jablonski.xyz> References: <20260204164606.3425246-1-chad@jablonski.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=202.12.124.156; envelope-from=chad@jablonski.xyz; helo=fhigh-b5-smtp.messagingengine.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, PDS_OTHER_BAD_TLD=1.999, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @jablonski.xyz) X-ZM-MESSAGEID: 1770223617644158500 Content-Type: text/plain; charset="utf-8" This completes the decoupling from the ATIVGAState struct. Signed-off-by: Chad Jablonski Reviewed-by: BALATON Zoltan --- hw/display/ati_2d.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/ati_2d.c b/hw/display/ati_2d.c index 063928c442..8a820bc91f 100644 --- a/hw/display/ati_2d.c +++ b/hw/display/ati_2d.c @@ -123,12 +123,12 @@ static void setup_2d_blt_ctx(const ATIVGAState *s, AT= I2DCtx *ctx) (ctx->top_to_bottom ? 'v' : '^')); } =20 -static void ati_2d_do_blt(ATIVGAState *s, ATI2DCtx *ctx) +static void ati_2d_do_blt(ATI2DCtx *ctx, uint8_t use_pixman) { /* FIXME it is probably more complex than this and may need to be */ /* rewritten but for now as a start just to get some output: */ - bool use_pixman_fill =3D s->use_pixman & BIT(0); - bool use_pixman_blt =3D s->use_pixman & BIT(1); + bool use_pixman_fill =3D use_pixman & BIT(0); + bool use_pixman_blt =3D use_pixman & BIT(1); if (!ctx->bpp) { qemu_log_mask(LOG_GUEST_ERROR, "Invalid bpp\n"); return; @@ -267,6 +267,6 @@ void ati_2d_blt(ATIVGAState *s) { ATI2DCtx ctx; setup_2d_blt_ctx(s, &ctx); - ati_2d_do_blt(s, &ctx); + ati_2d_do_blt(&ctx, s->use_pixman); ati_set_dirty(&s->vga, &ctx); } --=20 2.52.0