From nobody Mon Feb 9 19:56:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=jablonski.xyz ARC-Seal: i=1; a=rsa-sha256; t=1770223645; cv=none; d=zohomail.com; s=zohoarc; b=EiPgVOEbfepCOX9mxf5Ob1wPNOF2oPLOia9VbU5D6N0Ofl8EDQLilC9d+ZQPl5oJD/avVZSfPBEL/9bsX5zSoue6XJsarHhlCIhBLgzAyR6iqW2NhSpO+MehPma9BdtMidID1ulEF4wyI7Nd3MIfFs7oGg2llIAUG3UhLBUu6IQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770223645; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8KLDTX8XBd2F/OTfKN2mr45UqgSUUoPBem6fdHsn5mg=; b=i4O1K3xI4qnVieaX+aI/40BIz9pIYN6tM/el6E4iUQdjN2KjLjDivG6qSBDDCvvLvVjKzr+fysq+GEdxgSHcJgNr11/urjmqFqoadQEVlvjvetC5BQUgk9K0rQAtEOatVhsarzSFMaIERtdYs8lFvXpzGvKUGhyEv51FU2iSp1A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770223645390211.59614399201735; Wed, 4 Feb 2026 08:47:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vng1S-0007BC-JT; Wed, 04 Feb 2026 11:46:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vng1D-00071m-Uq for qemu-devel@nongnu.org; Wed, 04 Feb 2026 11:46:22 -0500 Received: from fout-b7-smtp.messagingengine.com ([202.12.124.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vng1A-0004Y6-1l for qemu-devel@nongnu.org; Wed, 04 Feb 2026 11:46:19 -0500 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id 650CF1D00159; Wed, 4 Feb 2026 11:46:14 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Wed, 04 Feb 2026 11:46:14 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 Feb 2026 11:46:13 -0500 (EST) Received: from localhost (chomposaur [local]) by chomposaur (OpenSMTPD) with ESMTPA id c38fbacc; Wed, 4 Feb 2026 16:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jablonski.xyz; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1770223574; x= 1770309974; bh=8KLDTX8XBd2F/OTfKN2mr45UqgSUUoPBem6fdHsn5mg=; b=D FZ14ItKpbKg81UDnT+dHnKsWWX/rtFrvl0wzJR1T5G1GeV81vHWkGqWiN90FK1A4 f9cDFyFEflfna3P2W4WckJ/mTk3NRCutz816f+XAcLs0oOMY/djrWRjpGy6o8aBr WAr+pNBV69VPTbnk3iXt0WP16q2r6aUh6cd0BKo23YsyAVYyzOI50OjGMJCjqaTj TlIaGFdxHxAF+AapSP10S0HaKxOtP455QjqJobnYEghmzkErtQZfZRtxjz5g0ti0 qSGVOqujvkSQdBkKNbVSORCYqoI4yQSE9a+mytnb3jTrlLLto30ZGtWBiopKdUuK sMeGvZFPlpPjRTZf43/4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1770223574; x=1770309974; bh=8 KLDTX8XBd2F/OTfKN2mr45UqgSUUoPBem6fdHsn5mg=; b=rD8DNZszl97ZCoLuH OuUOf8vbhE9/XLZsg6Ks37ImfkB116QrBvYMj86yVEl5z7HRl2mUdCH8mvVKkfHZ FCK3Q1hXIuqOsLk9ZDyVvUD9J440lX8VPh27YZn0gSUYfkrIaDUnwln6xV6FEVw8 ZBURHeSGrAOAKnPgFarqz1N7FABombOe9ZJd8+rk10HMFt0sEbK9kv4wDS5dQgWs C3mGu/F4P6ng6t8AcyT0LgjzZW//7JzJ1u1+Nb/DvIownCZHlFyoQMxR8tdULm8P pyAelgirQvcNui/4U+BWvsAi3Z7uFglm3bWNFb3x1Y80zd5u8A02L0EyhZCHtDTF cWIFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddukedvleehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpefhvfevuf ffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeevhhgrugculfgrsghlohhnshhk ihcuoegthhgrugesjhgrsghlohhnshhkihdrgiihiieqnecuggftrfgrthhtvghrnhepgf eiteejhfelheefieetjefgleejfffhueffvdduieejgfeuueeuvddvkeejhfelnecuvehl uhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomheptghhrggusehjrg gslhhonhhskhhirdighiiipdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopegthhgrugesjhgrsghlohhnshhkihdrgiihiidprhgtphhtthhope gsrghlrghtohhnsegvihhkrdgsmhgvrdhhuhdprhgtphhtthhopehqvghmuhdquggvvhgv lhesnhhonhhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib26944c1:Fastmail From: Chad Jablonski To: qemu-devel@nongnu.org Cc: balaton@eik.bme.hu, Chad Jablonski Subject: [PATCH v8 13/18] ati-vga: Split ati_2d_do_blt from ati_2d_blt Date: Wed, 4 Feb 2026 11:46:01 -0500 Message-ID: <20260204164606.3425246-14-chad@jablonski.xyz> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260204164606.3425246-1-chad@jablonski.xyz> References: <20260204164606.3425246-1-chad@jablonski.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=202.12.124.150; envelope-from=chad@jablonski.xyz; helo=fout-b7-smtp.messagingengine.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, PDS_OTHER_BAD_TLD=1.999, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @jablonski.xyz) X-ZM-MESSAGEID: 1770223647230154100 Content-Type: text/plain; charset="utf-8" ati_2d_blt remains the public interface to the blitter but the bulk of the implementation is moved down into ati_2d_do_blt which is passed an ATI2DCtx. Signed-off-by: Chad Jablonski Reviewed-by: BALATON Zoltan --- hw/display/ati_2d.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/display/ati_2d.c b/hw/display/ati_2d.c index cf80296a25..063928c442 100644 --- a/hw/display/ati_2d.c +++ b/hw/display/ati_2d.c @@ -123,15 +123,12 @@ static void setup_2d_blt_ctx(const ATIVGAState *s, AT= I2DCtx *ctx) (ctx->top_to_bottom ? 'v' : '^')); } =20 -void ati_2d_blt(ATIVGAState *s) +static void ati_2d_do_blt(ATIVGAState *s, ATI2DCtx *ctx) { /* FIXME it is probably more complex than this and may need to be */ /* rewritten but for now as a start just to get some output: */ bool use_pixman_fill =3D s->use_pixman & BIT(0); bool use_pixman_blt =3D s->use_pixman & BIT(1); - ATI2DCtx ctx_; - ATI2DCtx *ctx =3D &ctx_; - setup_2d_blt_ctx(s, ctx); if (!ctx->bpp) { qemu_log_mask(LOG_GUEST_ERROR, "Invalid bpp\n"); return; @@ -263,8 +260,13 @@ void ati_2d_blt(ATIVGAState *s) default: qemu_log_mask(LOG_UNIMP, "Unimplemented ati_2d blt op %x\n", ctx->rop3 >> 16); - return; } +} =20 - ati_set_dirty(&s->vga, ctx); +void ati_2d_blt(ATIVGAState *s) +{ + ATI2DCtx ctx; + setup_2d_blt_ctx(s, &ctx); + ati_2d_do_blt(s, &ctx); + ati_set_dirty(&s->vga, &ctx); } --=20 2.52.0