From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201338; cv=none; d=zohomail.com; s=zohoarc; b=l6mYoN5vHhCvSX9Px6JTqbJytzqJ06HUG0zdqpNI2wXy/tMj/4ZMbHLne1Rgd1nBa9FIQWataMWM8N9eiyoPLT8hexVp3AlYLcegKer8TuFkCihkulcQY1afTgYGtj2PlMHSmvt5K8u5qVvivrwdfanIG17QTq/yWyZCt3oCtTs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201338; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lJKfGyDowF0GDPWbmFZ/c8FoE/RkZBRFybZy0CTtjYU=; b=bcfJ/QVB8zHmB/BA8iVL/vlL69IwhJ7GGMUA8yEuigk7dLhc7yGbNcf32ukY6mbVTjDvsuJCCJycq1M7Yg6K0uEcW96D8lwgb3ctFdaECZl4Xmg62XPKfb824JLJmre75Xlo0GT5PwB2ayUW9FDSDlnU7V/GLI7YrRSuVWmXrmU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201338580226.06398279270923; Wed, 4 Feb 2026 02:35:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaAr-0000LA-6X; Wed, 04 Feb 2026 05:31:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAp-0000KD-TY for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:31:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAm-0003vP-6h for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:31:51 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-0BVictwdNHGK5B6UNAr6Ww-1; Wed, 04 Feb 2026 05:31:44 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DFF7A195605A; Wed, 4 Feb 2026 10:31:42 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0CBC218004AD; Wed, 4 Feb 2026 10:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lJKfGyDowF0GDPWbmFZ/c8FoE/RkZBRFybZy0CTtjYU=; b=e6VooL4+QLqqyE3KDtYKXU7Wig4hKQdNVPz3mlS/fH6uB/K06J2fGOaTtJcdEATPVLTRXL D8pXZ8s2qtQlDqEeSylJqgbT4882ymWrJNf95aUT4ZLuJzvNmvOZVZhcy38kaN0YxGeXWD pDIDNogNiW8Wh9IA/DqlJHyc/+4kaTY= X-MC-Unique: 0BVictwdNHGK5B6UNAr6Ww-1 X-Mimecast-MFC-AGG-ID: 0BVictwdNHGK5B6UNAr6Ww_1770201103 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , Nabih Estefan Subject: [PULL 01/45] pc-bios: Update vbootrom image to commit 1c8e9510b22c Date: Wed, 4 Feb 2026 11:30:52 +0100 Message-ID: <20260204103136.1795455-2-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_FUZZY_SPRM=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201340508158500 Content-Type: text/plain; charset="utf-8" From: Jamin Lin Full changelog since last update (183c9ff8056b) : Joe Komlodi (1): npcm8xx: Fix u-boot copy size Jamin Lin (3): ast27x0: refactor FIT boot loader into fmc_image.c for future Caliptra = Manifest support ast27x0: Add Caliptra Manifest boot support and MCU runtime loader fram= ework ast27x0: Fix compilation issues on Ubuntu 22.04 Compiled with gcc version 13.3.0 Signed-off-by: Jamin Lin Reviewed-by: Nabih Estefan --- pc-bios/ast27x0_bootrom.bin | Bin 16408 -> 28564 bytes pc-bios/npcm7xx_bootrom.bin | Bin 672 -> 736 bytes pc-bios/npcm8xx_bootrom.bin | Bin 672 -> 672 bytes roms/vbootrom | 2 +- 4 files changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/ast27x0_bootrom.bin b/pc-bios/ast27x0_bootrom.bin index a4c94d64da55ade9b4beb2a409132f315fb51347..626499b117c72ea59d906c60655= 780d91229616e 100644 GIT binary patch literal 28564 zcmdVDeSB2qnK%AD=3DS(IciI|rmK|pf?*u@bAA%Q^ca+t)oq7}omSZg;Kl3*}ENG2#s zRu1U?);8VGlOu!U3rfItE2G`zk+lo#ATf21opa^6%$^H9$?{m(~ zBw}};KcCZ2nVI|by07=3D^x~~%hfG->H?x zzB*ldYe zCt^TwWsR}_{{!Op6~Ovjh|(GjH#cSUdtugQ_TK9`Vw-0PIo+*QJVigb^$O}CKC|!M8-P^+(59}V+V4Yf~ z>@LoS^{J-B!e{Pz;PiLY-SdF%x4&_jby`F0Y=3DgFY;?FnNzWeMi+V3oawL>jEk)t4Z zRP)6Kv))5aP#AP9QMK$7OnAmbqMR1E+e0V@Bj+yA|zcw2Yem>1l1(j^y zg1&yaM$b&^Rgc|&YT4r5r@s@}eYT-`_wdH&pCr5-o6t&P&v_6zrIp5x2vIt`@t3<% z|IhvP5AFJdXL(4%kkbvo>dHc-9Oy28@^VYApFhv)^&m18=3DnhPrXUV=3DR=3Dh=3DO$=3DUG4T zIO7jEZGV|(J?TM2&h^Z*e&j(U(Eux?5=3DK-e&Nq_78xJ|K!7sBY4GnyLPr51M)*Ef5NmNOc9Mwww1KPw`Li5G`%Zmu{_>PMB zSX_cQ(qVmp50KLxo(hZb{YpdRjE2|*n6;$m(NnMnj=3D{P~L*!Ep{(1!!A-20`udlLh z^&rB%5}MD?y|)rdd)_h>5zx)O_wc*u)neG%f}6|e?|MDSxFN;Twk zH|XbCS&iMbSwH(lJ9%nAgI`t5+UYR1-iNH*&7Q?y4|veFS%_e0gT5agSY_~hd~ier zd8RDnbpJ>{&+@?R*I*XyfN~-P1QXgcKl|0@#;W@~umaG&9++Z0uxrDL{ndK)*Uw0r z{bKhqO^K18j%%u)@^MN-jPfCAT(E$=3Dv!{H|6zg;`lBYG*e^e`uT`2KC!9Sq+VhOD{ z_Ad_p0kigWF?r=3DV$t%Mff02?q@&wo2E<{w(%-YaBJ0C@JXup_+_`hk09M^oYV_LD_ z-A~fpfKBs<7Fgh(dto_y`WuCa67Ss8-S4;%rNF0?9u?#P^l*0EEtY&kFSC$tH%skw;sDA*_QP_xkKD~`Rd*|P7-txI>}?Z3GH zA|t-30BxIrAYjCi(|5~hAxbytXgdf5l^o*|J*V%M#W{Vq=3Dq6%+6{6JMx7fz{{)N^H z8X|v^=3Djh#C-u(UA&AGeV;lYjWdFG<8zg}G`d6#mOZ1L>=3D{8A(n_i8^$-0S&CVwU-} z6{-=3DhgVIu-g$i%iq^uY3*=3D+*Q+zEr$$7yN5j6;nlEClQYjMhS`71h=3D^VQ_`(6h+N9z{=3Dra){EFpF2>zpg+?Z48h zKwrP9A@ZRRr323?*0;$ELX@7;Cd5dqWnM%K6_vZZMqJM6{hCF69mwgsrCmd$3h17=3D zX^~~?i{e-~m*;{%fx&rl{PsmwvnF+-Z(qQ$ej`LF`MMJ5-uKxeYf-kX2O{?PJ@{0$ zJ{6*rJT{>D{2aS9higuVQIC8*OXAJn15~i@N@xB_XWg5Hh>{--o4@v;fP7sNyCwra zr7-)8Mntp%@KF}nuLFC~3F~V%9sI}kDi+tD3hW6ShqZp3gfnIWy+>O~f3!Uf1m(Oz zdk^weDT)v8IyAK_wPuZC&Cn3xoMT#PdanbDHC01|IKE^=3DMD2dW&St`My=3Dq+`=3DbCX_ zHcMmQ%aU~7gZEUcNJHdos~JD5PIyXBil9q_B8LX1lBPknef~Y@$g(^cxR?mD|F^>; zN?(oVT?lmF^7$g`tH7R(e}eUn7m?E%{2cd|Iyi4|SoBiA*H8WK0t1-$PaZ_VQ!ljY zy@vcvTSqt~Uat3Ae^zb#kFu1soDMcrPO7wN?m5tdV-|&TiKjHDMp+1TiQwm z6{N*cZ8H4?Ii_eFB1z4rMWU5H0@|)u99rC}Nj-L0l{_QI?{&`b8hPAV<2NHBN`BI_ z(QEU7ltsw{2UOCfB=3D+2}h)SLLv}SQE?P1J=3D2=3D|li2Q+J9@q>@B{fC4VsH6;W?s<+6 zQ4X_K(Jx#e$G@pr9Q*K?v0u#`JN?214ub^_dg5HEy8vFjRh#u8SrEI0v9n!3gDkAR-Q7Y;9 zyhq~nDXBMqY1^GVBx!f%tBBk+ETWs{p{-s;aE3x1h1e!P+WJ%kH_bsCJP4l3OZz#S z7TPvfK~8shUzYW`)cZL$u4Z4jfI8jn`;W}N85b^~PN&~76=3DtnE^TGxCP|X|a)cg9? zn|FOOps6vv2Kx;U;yVAIgE)1WdeZL4Q2iT=3DfjIl$lV|x^%7&8PXv?VosrO$V7STIt z2Q{TvKGJ-w zF2C|?)?AoH=3Dc$O$R_>g$I6mM-MbCpqQZdTAN`^(0y357u2e$ti;r{xNsN4(td*A1x zlK7o4<3ekv*I2Mq!94ZjG=3D3M=3DV1Jzl@kRW94&saQ5iiH2*B5nro2)^7j4%b%s9_VD2Vi_Mm*sKZN?s8y!8hKk%P9) z*+V^2-r4!aW);b|6h!v9e7P>idR=3Dk!Vf{GkH}3bDxt4p*M7C$QTyuM_mADj1-GG&t zg`{lD&$AM9k#t3`m9pQqQJ-*XJ5Z(sau&&3*-DZ7yYdypik!dMR&P zUi;^M#un_;Jn&`8pzX8UJ|y{G#t?xEWgOQt-bnUjVP6Syy5IbyQp&#R@T%@X<-vPy zi1+ROUajeWvV9TIqIeM8Jbv*d(%yHDx3&}+@!s)B-mW0Bxy11saK5#Yzi+w5_9Hf& zZ>>lgwBCVP`x_v_*vnMR+PePMXyeV3EvxH^d`D4Mnu)(RN$ zqhc0qTbyT8kaJRpH>u09IZ8g_0|jQSl7l$o zaT_;|jaa7a_95rwX7AO>%?f&pr=3DW;_7jqOn3gu_f+w7y>qWqm?K4RmcC!vboo z_-O9#Kh+^wuNn*J3){Ne&f(ZTjqUH3MbNgm1VP3OWqoL?*AS%rRP7wmg0ekI+fI+u zzej27bNW3nYo|G5^kGp^_Nvm>mxbW{8iHK2rx?MqZl$efJc2zQv-YP#Lt;l@T0`%b~WeSQGO-I{|ArTBfn@m{9iyS+hwi9M8b06HF^esy$ZOX6+ zCgvK+fsID|c@HW!XARC*u7p*7@*f`jU3}{WgLR=3Dnzfb?(eZ$f z^EiK}GJ0MqjHCjy|Ew3US9xG1Zr@Nve?6iqd4y}X5T#Rf6dv6O8H3Io5y8ZKBZ#oYj=3Dr3bW+VKpzUHHdj{3yccn*X|cNL`1qp{5j=3Da3v9;&+ zJFAFqzYtO3#TCp4{%8!IR}ZCeL|&jx{G$-15ibg-2oZglafu@R>yuMGS0{G?`>3;Y zk2mSctqxmnj+Hm5&t~RYiR^6ps@>98t#*9XYox!~Eq&D`j<0&7)3!a&mec1Hi?(0p zVtzc)V$Ny-(7m85-%2dA{a5BZ=3D)Zm*&f1+=3D?yi|{CBB2?Kpm33x6p4bj(uxH#1085nMmFm?SEd+A51y=3DTOd#HP9Pt-4v$hF{Uz~3w>rKtt zG#l}09wQkTs(GUUS$P-xjAZ$ABl#nE^Y}XiB~LLX>{m?R{$q=3DZ=3DY*gvQTlxQHTd=3D` zxUW_*eEU5{(SFq|+ONPYQu_E=3Dyg$SohgrPe<#T2Fef^4z?~FJ+m_xhg_D#+C8)q~p zS>GLd#+m6eCKO{{dA^bK7-nr_AL5PABmTT*);0q1PzB;V*NPm(30o*1@lXNcge^2N zy}vT^%VA?4YFhJ(ss^C4ta)k`ZLQWkwJP9&^_jd=3DF#GGEofrUUCk|`Sx~OaFpvX3k zpWfV1HC>1bPxG{@1`lK|b5nD974;5%)AA`OQeiBhPNeU(1*lvEv;jLF;e6gf(4XTt z@)mio8pZ?_N1C=3D~)f<9t%LsfZmLlvONxyQ6DX=3D6xN z`eDa3#Qvx$u@5yhW&rzm_Zfn*;Gl-e2ZB4B8>)6nKABdP$e6D< zbSJI1DCiB)E=3DpQ7R$biOSXBql3DTYSMw^h;Vh9neN0!7XaY?^ggK~Hi)Dv42Nwe3< zljOr)LhK{%NGF%SNFUlOmp@4hm#&L}6i>S2IgY$Fc8m)*d55%|$~$bRT^vhXH~NgK z9S+YDwh-;S6OW|$w7H(LQ^9*;cW?4D_jK=3DT2tRSmIiwHs^GPA1bvec-1M+?Y{wI#? zsC`2Dc{_FNCqhKaptXb)1dXMz{>tAT+YT7@u>O<3YtVKb^S_E&ln?l-r<%3ZBR^{A zyv>}~4J$$ZQc#h&vuqCIp#;n#z1y7R(%n$aBKjdv%p&5T4`va4K<+h8L6EkGacP-> zw#^>1A6aHU%*|3}P0fy(;4vlsc|I(K#q%+~;U3IemgN|q?98!syL{K+AJp<|NeEaUr7QS)%|Jd6o8YhoPT% zNnso?INvZ}^#~E=3Dxwq)X-Mn|-WT4H^VSNMyAI|7|nRyPFMZ7!ODnxV#&_X!$ZsYE1 zAtWyUMTlqvaOt5D5nKeV<=3DznyG-kv4=3DP~1-8x}#sgtgfj9~idBbA8O-F$(wO3m5mK zqkZrF>~8X+BjV~dU(2Az920>(o_km{C77}+?qAh1w1UF4V+si{D_#Ct)n{td#>W4(|E3;8JAoZ*rmkyL6 zz8Qn_>Serd*ESs06n~w^_=3DI}nXc$(EYkJT&!1$%ii1U1I?(=3D^#{}Im5|Kj}ra`;7* zA^sOljqSwX{NGc@mmz*agCFYP{1atHoG>J`^I`*9o}YY6`8Fxv)6u4@2og5d0sH{y zH5KW{6q*X+2`$g>#?7w|i{8zO!8rY<%?jd+hs8XueO8E4ejdi)yiMh}A~Yg`I~07} zQn=3D$5-c#nmETTSe&r4Vc?`uLt`!G0vpv+)?oj$=3DW?q1AEP(N|bU!6137v#C@vy6}R zIkK-SgY$_~-c$V=3D_E{vJH6;Z*eI(k7%sPUKPGf82(6qx5FJ5OJzz1I!bBN3x-qC4n z-K6?XP=3D0v7?Br!*b{@g5NjNI+rg(2$99ujhqV+&!{q1*D^^AxL#;!d33UzRPrj2!c z2LHwp5jB*-`DOvE^&`~zSuNMf`XI&@o)~?Eg(D(L8|li3;pA!fNuB+rHpZ}RjMQVR zrz~p%E?q&pPyp+cqf_oP@OtRA@-72P*AC<26VP`&;_gE|V>tbHV$fQ<~zp>n4i* z%=3Dt1lB2Us^IyK9Plb00gS`}@EVitv;F(2qvl zdQZE4M2)dtq_Wf4T0z~T49*LZM^(fnU5X9ndq&Zvek!cE5Ye81-W68S_34OU{x|+7 z`ZX%z^qn&K;8X6AQP<(){WN1i@8JBNIkt@{MoC^Bid(+tMX(0NOL*tu+Oo%mhz3x+ zgnDkVhTt7pgY$c8VLe1SGi-a>vjtW}i0B6@T2^=3Dv)KId7e(H+u`zGxT%E=3DSkgTB>zd~ry%nKZrtng1$8HRnzn}W!a6_NL05lYOL_wP{s^-up?Onw10Ewu zJ6SJ8?~5K3+V>%89?GOGZR%VhqVqb9t-J>$4IdsB(RwWnf7ghJCe*?CZv^Ic?Ny7r zNXKvytc!`$D^aogtgY&P6lIM2CZW`s}2wEob)q zjdQQz;8%^E(KLC-aaL3Ot?qr4GC2Q~R_cHE9%HLmf_P#HbJoTFa%FHH^U;6 zEGmx5I=3DKlkCC99tL)-!TgsQaBE^^JIGKcDmeS5^d>wWhNJVZUB#^}e{bzqAB`$Lqs z;u!T6>lJL7_N8Qczg#1IPe{E`KH}I8C-36k^}R77O5N|a?>&0nv@eo*|;u=3D zy*%R7CTi$q?)_+3u?~&c{wr%J{y=3D?CI@B3)p(-sqB^@TkSnIHRh`JAz4=3DLDZ)7Qq2 zn>QNX_@X?oyBGa%-q{puh*KuEDrOP$pnFxse<$&o;cG61wT8O~GUIFydCpGLm zMk?P=3D`@q;JIzs)Kz6ara<}uv)jm~`Yob$c0ESUXI{w=3DzjCUyd&7(mh7Jj{Wra zfFSDy$w#a`b#+wvY&+NB-nZKFs`%49p~cQlM)Itt#*S)Q><03hf?o3La{A1q`CP@i zDud?#AoUG+N4al3b;ylIocCq4!LE)xJ2`#d+E)upb5&xS>*{X1QoIrK0Z9P&FZ50bxfP!XRRk~&SJ(jyxU%6#F<)>Ul=3DDis(D79BvF;lzlN zuVihlT_c`Z(|*dqC+l-C5m0id}koJ&U7xEM%S5DXkkQSga4lkO=3Dmv#scnBFGO&cT5{OlrzF

{BfF@%bCnk|p%lxz}`C z5BrT_G4HoRl=3D806u8~dOGdlimjPifue z9XqG^2Q|$v>x08tyO(^PvUl^#vh8}rWhtIW`yS~#jbBOo6!+qF)|(LLlVR3=3DmSxt8 z7Q`7d)bCn;_p8kDw6KnNvY+qQY`(|XN|`A4;Pq)Op{h*>>{_~r7dHhwxTy?k%ZU*Y zR4}=3Dv{IwmEHfl;<878-c=3D;!Qp{hX56M%Mkc8gb^3>9d^DRR3E-l->$o-VSYI%YX6? z`A|jI#%vTuvQZf5G`9ZdXCnIZSFWtuq?WcUrp;(!j5)dGl|d2Q;YC~GogI@RDwgm( z&%RPobx`ITiv35QuxlbG4%s+*nKj#9T*3ESHWlHDfiohwOfidC*A<3Yv{&Lj(+5s@{q-|@y?PAJ_bG$(sP8g$S*D$!y=3DOcjZiLhcde1lSre0tT#P?MM7Zum=3DSO(e9MN*Agz;JZTXow6MPXTR?B03fcb3kO;CSp7x6}H1N6Yw=3Dmz#Gq84& zu{!Ux>9-#X!#d1dwqh31FV%a@NsRMRuz8XjMlPMZ?^Bu_d-r<9=3DkqBQ~YN&Ew;nK9i&W6lyXe_u>T%o>%Td?e2TtXM*Wq2 zhj07N$L6vom$j&N?0Xq~HR{|OsdFc^&~DK;9?(i-fB%_?_6>^)cP#hW=3DImkXnRI;O z`oPSoEXv0fIU0i0Jz)pl1P14GKJyohx$kw>;XS48Cy%ZbbN8G`KL8V25+k->&NY~i z*bB3WHDqISzQb>hqxRj0S(?9_B+zT5h*(NG;!2vfnje{-ZRed}imH zSKMQ4Wn4wx^M59yJtLx5!GyzMFK!B}%905lnbT(7ODYD;v>h&7e1}5%+r>!s4~u95 z*!SroBW|C0^m{U=3D7nyO|%n6v#MZH3M!CdW5wfHb?j_)%OrQHo5(!1El+9KX#GY9vk zVixi4J=3D3Ri{UOqv_sq`>+qE^H-e@>+U1p7kQwJw;R}x#E6w%W+n(2XiCY+#8SB6r_PpqjY{IR6WTUHR}Q`*GXUmUn?zcp;XSq=3D5fc4*)}^9hs4pnK(JTlT5W!DVLq4?QN@G8fklXi z4wZK;!h{pw1A@U}(c7n(Mda@Xfyz&Zgv`p zvUM|a3BW%3P?zmef9(j69&hp&3M9tr@ddf0~ zUjD%9Da(H2eU1@x{byeQnPDqXa_^ld(8{2)Y>wL*zuQMuEL z!cwiYE1^w_eJ*P`kjK2ZITi6CZL;6iGj`nZtw9kLw^vqG!mRDg8k|qs{&hq|Lxj1- zh;tt;ABE)_k_{af6*bIe4X?fLV@`glUPZ+>d9SOL#15R5dLzcY-=3Dja`!A-1Jc+1&; ztS>Xx7cbY0BUe?|Cn5GO3p^ScLe`i7^pDSkVDkhV3ncQ&1r81G9MD-tiv z;jzw`^7AjB*>NND5WUQEXz=3D@9tLS1)Wz@3 zvuzhy1IhS`_m8iS$oJigxc_MVlIeT8c_7z+LM-9rKy?k3cFvXW_m#$OrX8X$!8>df zz2PF#xg>V&SrOF=3DP`Kibi;5@*5hwv%I8vMi(?;=3D$0R*`{u%t9jd)^~k)#bv zIQInf&A3PTun2zGpjgK>pMNY|CrQ^Y__SI650AmgpLk-&wPOD-?03T@4)?O&rp!pv zUnP!Pi9>mpG}^b!#NVe5?wD($USghaP}3ydlA7Xgbm-lqq4L-=3D#tVG^@dBCKec>|^ z<$E}!xv8P|=3DyD@oIvduv;mezLJ_-Z*q$%a0MAALbaZyo^%RdrF7x+J*f8<3xvD}Q4 z_VWEl60#c_H%bNXWo-ZX+ZZ68syQldzEmtXfFb&CZ z)Nx)^+IcYfj-ZtBpCm=3DJ&ui!UHfJHo9J?DwzI@icgJ=3D6-ot=3DLt9}Z{}{fEwqDDrU=3D z??^5YBB*RKw)PgGkavlZJ1#1sFFoJTyY5m;yCPFjcue#8?ROAu{Z(n_?klGi!-C#Z zTYvlf{kw`_1wOs!0orWFLlw_ebR9WEzm9hTC9(c9A_}9Y);v_UKcP*Od9-uMkLlEh z@Ld7kwP)%(+wUEHpE6JG@#Xg^KbC8x^F!3-q-pQ4tnHArBwkK~@7=3D-A`#t7ih>HN< z5jFI#0DMcns4ovad1{#NphKP|p{c3+_ssZ;FtZMd_JeT&WohOx-%nK?UG0nQJ!9L0 z`mDkEw1J-uiYQ|$vliCbwNsYq!}i_kB^rX}1F)trM!XU6Kiu~&-w~&VTs?v?_R|Dp76nJ1er%+tZ(N( ze6e}trRiv6eaEpIjd=3DBtm^aEk$-lv2$AW%i4n;bz)cO(7Z0zm@&?(hFQdW+|!c2Udl1=3D%;dYeA^C2r zeQ!tl`N>~D-(1`G>@V7xbLP2z!#hha;?Q^X14lop4=3D97Qb!Iy(zVGxR`!7QL*Q|?I z%%a0%_)XgVVk9pawrx8!+nzo!XvZt-x4@z=3D81SI*XG4xn*CxbzhwL2caShVfCw!H} z@f=3Dt`k$v`kY>f9@K;91>I7jPbH@BIok39ZQHLuKx+p$De>>rbIU#WYhDd^p-7U!`R zjIp(?+a|>7jk#T)oVH_?u{y}DuNcjM`!W99M!)IgY%p_FTZ;)!g>$V z>cca3jLLVFQ)|fg@ECL1cJ0rukE#sL539ZHK1k;?@v7%e$&Q zfhkkuT@`C6`S%p)SFi@&;Jej;PmXuqx#In%oO821hxvGpXPsweP5Nm6AWQnhwDHts z89b8m5x5TTiHRfIH<%D(d|&SwoWIG7wvY$GflbCUWtwv05(U9GlrcHpF}9uc&*hkS zcoBRjo){6qiFtju3@$_bShZq>?zv|x?b%M|!Z#Vu>`>Jc_YaF;B)9LDj^^_HjVki! z2i(_j(K5Gw<9X-4jPHDG%C+O(y^2}H_b(@&-}n2$OOd2c!1}SpLIfk@`+nciTs}x1 zb^fxF{JTou3awt%sMiDo`pVYzYa8`Yhdz75#j7{W)EipYt!ir2J6i3ATwGlfth-_H zHP=3DiR5wmR?t$KbD zT>it!{Oqig^JY0c_D=3DF=3DXPrGIHy0O&F?+$nISUq6%*EG3YxOHC^*OWW%tK)Ps@08p zO{k+uU#MRk)-Mj{;>)=3D;CqGPG)SQ=3D>lP;>Jt39ao#FH-ni`&qE7z}WS=3D)N& z+P?>3#dj_ae^=3D-Db?vR|n%X<=3D($}_j*s_tE?sSD|b<^70I+}SheZ^fJP2rh((}s0T z4INF5dWGKFu2)@>i>sx;+H!XF4b}P`7dJY{afMi)5ngq7(?UwxhD$J0U)!{yL%;gE zpdM}twKp{DhAV?9dF47bf^Df?wN`Hrt-Yh_a$WFmKw+Qe zk_-)z9{+!{<17hen1DN9^|h^yO)fsylT&Q0Hiy_{^Gm3)vAroAE_V{2%qZz!x)d4G4hr-QcI4pym z&N*&0XW=3D{TP2r~YJDM85yHNi|tNzW)0%^UH8hWmUF3%k`_nTp!rm<;dX#MIA-Ca~) z)3m0w{VsiV=3D&siF9hc`~mfLfg-7_m3Ugv!MVqeGK>a#I@*-97Fp)byFUDwgnbXh}d zd(#*DR;_EejC+ThL+zPZpb}mY3fqce^#)x}X^qtza-vuJTyWH?u-nmS&!E1>x=3D=3DWbJDS=3DT>KAXANpjvs#l2ys z9&T-@bJ}yUCbV|ts-|#V#@2Ry-TDO}W%jn-xwdI+XKhock&EeTLTgv8 zYzlW!vMvtmGo%{K#q~5D7l&;g8q=3D3H5A9sVUBPi|F3-gc&YDh(z9w|rss??{s_>dn zM?Nk;koY_2*vvu1@8!8R7D6jlxS)^5L3L=3DYG(W4>x;Ep^RUOUx$~)^;Nym(5 z_@-^YND7HYtZ7(Zw{lGb8XMay>Q=3D33T4R4}OnsZvn9)3^G1XIMv?9%)VmI+=3D|M1^Q#twRx~s=3DtsDiY)bJ$STD_yWNpEbrV^u?w-qGGf!Cb#K zynfxf)^@5QYUjF!rq!#-S&gIn$lIBH?M=3D7QinKS~mbT0(B|z7NJsqvBdbqi@o!+iw zCEK02Bv;yY*Ba;)p2pUu@Y=3DuY&?P_U%a$$uf?|+THA=3DyLabECC=3DdD`1e#6Xl&7rl8 ztD7(@w0c!2+!V&Fy1MXPYgV+b4%gM8p>@r=3DP{*njtD7**F;tgHY+xEs?|ct;w6@nt z*CZ6~kYAeG>&W$}%V^+$I?2STzsD*c89V?`?yiMr!$r#E{4&`#5y0x05d7p*0bnM8 zbul5HXT#$0#$!2;X9u=3D=3DBUv@uJP&F$QS~9EKKK12@4Wlg+i$!%9*gq;OaagcU??U; zk3CO+%=3D5U$fgCa$za0{gl|89#8X1#bB+Vss{r18N(la8 z)lu+ObDi4U_m89jo{Tm=3D z#PxOsIQg^?FWKu!eAf`)JkIh_#{uDeRRQk*i4av;^89_uV-p`Qy=3DrSoWWv?kd=3DC~! ziykU`xZsiVA04m0o%{ZgKm6|Z8I&UY`6^&OBLwk?#WtM+Th$wK-#_vOX;lSawhGMH zD@3;{$8;-?6+K=3DU*jf-dzh>L`2hWS|5%L9C7ke^hbbDx8sKx%yw=3D8f?P^T>GtP6=3D>M4Oa*}tgak0)BZ!!S8Bla{b?TL zLmCG)pnJa%hHSChnl<3Sej%1-v~_C0;C>;f_4wj;vfg z9!K7HWNN<#Tp1UFc*SCS+*QsvuJf)2)ciN=3Dkmm3J8{$GpTsZ4|-C2j-JkN9w@PoJz za=3Dg=3D4*lK9Q>jy~!10LSA(T&u}5*!&tGzgCl9 zuO`FZIEI-hFTEb%(*w@gork!7)dP5bA;d(RH#63|iR%TpUNt4)nn%ZPKW`0X;Jr*C zpsp&&0^a?lBXc!2Uaz65a?U+F3oxG*f@AscvnC6;|5+hSHjJ4=3DcpI~Tk22=3D)AznMP zfWJID8n4}1z~Hl^bo+x zgt%TpV#{WZ7uen>#CEn_Z=3DZXq#JOg!kU z@67v#!&8K*!wb|Lba>9e#r%Hp* zUOG7X+<)-`?;cFctE6Ez@Y+Ekp5{ac)`kpN^=3D#nQLqbr;@R8@w209Npw$YhW=3DZCXSC)asS2--h)ow^J>ZqEi1&j~Tp)=3Dg3u-0HwaI1Xe3 ze|g@)nImtm4q*R#*+BjaU*12I4a|H&h&}fH(k|bUvHp}C;J^#c*`4*T%jmx{2YBs; z(eiHd%;G%q#;rL3UOb0Ayqb!fE2Zr*@%Dopz<6=3DA?przK#e?AQ~U5)QI;lU%!C9Pr+YLJ)L5~a4O-I|7ac^nRZXbmQ?iU#cocvW92IBI` zalr9kodcKE#O1P4YmoNujsvE@{C-p4I09>t1%?$i!34HuX9OO~mK@xxf!zPT3*Ji-E1`HLmaB z`UV`^n+rVjKNw4!mdFKu_;L#F`p5Dg&kH>4c|@z(nj0CnE$6}P>ZtdjEQ)-lDUkd) zB@ejvm6ZHQ`CH=3Df)Zz?zugL@IUrC+uoZ|@h>O7$Hm6TpgMG(a!^Z@HfVA@0#;~?Y};UZnZMhGQtB&S8lwI?%_mQkeJ=3D-;USfia8`s(EW^8nv(Q!(2Y<(2?u z;Dx%wHy-%mZykH;=3D>4xd{7yPoj0bvuo8os@RwL4JwE1F`pVv4Zcn88)C5~i2N1KVFaM+_wakdvHA9d0mJNHcXOV zoY;ywC$%FcBAteP=3DGO7&ekO7#&(H=3Dhr@`Fcvf%JpTeEa4$Dj+TY{&j*72 zqvf)CtA`7xWZ~)afzJNXIzifz>TPP!ftmK>&GUi2{OuGoIslRu=3D-#zn$VaSKmcQKN?TTbb+*<;2u4N zK+ZcUe21~v2mB)BfvcZw5Qb%d%hSmQ=3DhLZ0`%XdczDzvE)Ub+c&G?y z{GAZYyDuK!vQu=3DMvS-IT_0hQC3)4i*8cf1mQFT>gtlSIX95 zHLh(V?Pe4MPyb$s12#NqI$T91K=3DA0F@lCyxk`KbA)%A49;3?XlNs&o6*W!+*0^IQR4a E14Sx{n*aa+ delta 4114 zcmZ`*4Qx}_75?5&UK~4w5IeCOGH}ArQkOvpAx#J^FD7kS>42sgbU?vQOhntX&;puN zXl-b;Rs~hLy$_Nypk7Kh;$;$ou*U6LqAr^dZKuplX&?zWKNJd4yN%3laKwXaXT7G z%5m;ep!r1{GXq_lnhS{q=3D+aIWlA)_0gOVjMAZ0niQfA;pGBm${V*t9)R~Xls1Kk2$ zqO6>ui?X?8Y1K4M>*276IDF z86ZrwTwW-niWku>>KGBs0C`D(W`Y-%O-_|~MO@DP534FdM~DY@i_88w1^$p;g`P)9 zwE*q9WC`4OQ$2Dc*?;A@n02{DMimbv8vG${n}?1o03tXfkmX}ls4pXC_(DHptZ@op z@r!D3GHfqy7g4oC%=3D~h|D`f_J=3Dm@2Bge@oKbqY?r>plxsiCm>#F z1*&vEyI0nO@S|dZ`OD@n@^;<@t&_=3DlK;uqBu@e{zHY}5Kad~*FdgQo>%hycqBW^@>i(-+(hChB+yoYL`y$ zn2g?Gjn^auT*+wDo6gV7Sl53IXuJu0ay$=3DIg-z}wd}8oXDFBh&ZiVpe@WA?dSRpqv zw7pzEjwcPw<>!hw=3DH2)x%!RK~@S{|>zoigvD<;@_x$)sd8VU0wWdz+GmVe_28CdJ@}BI&-}Sf0@}h`RrSbZDMmSq#3|Rb zcTlng?gpNkObP+5k57M2vyo)I%zw~94Gp5C;Y7+^UA!_%5gcrnR zBPMcnp+IidNG`P$x_N^ag^jV?uvP6ncr4G5l6KsGr+&Sl|Wxp!C< zKLOWQIa_YNShKJtIz^4%-g@#7-}RtALM;IazEHOe&97Gm5$qbLSN;-XR=3D1)?#Z>jd zuw>I`aE+m3WgZZnVnC25&~t}14l`zzrq+j~XPd87Lk;H1YB6n?Xz_Xr5Uln|WSUJ4 zPBEy#=3D_P8g21%xA`D!qCksAC6iixk?5KQH2W_!8M(mu4nTe3MmylkP&+c(RhZjd@KvflGneVD6sFdPglC(t*rC$NITId}X533` zP*96y)mQ21K+w~PV5j7(^Z-GQn`=3D{p?ji(T1_U|2D-}UkI)WVEb@Zd07c%6-&h|8F zo;5>0?DVG{T{tUWkPqkfq#fN*Fv8z%r5#;cII75podx6Rs?r0bGF#^NC%Sz}_0hoM zKEX1(bl#lV^JW*|$t`vE!cu!-LE&7w_ZQh&C39*@YisfN3j6YPuWovN!^`%0_Gz2w zz>-}wfANl^FD+dmrWedEoKrNn_~DXLcXf?tT`hg5vWcGf<%9IW<+(KPnS9!_d=3D_1? z;wMIam$CsE`I?Hqn(kErECNvf55|fV0M4`yVZZHwwSs18nUC$Z>@hcHG);Iveed|+ zrb!us@oazZ=3D`-K;e0%Df?lhE}_&tzsV;6wU-Hh22u7-X9zHY{N4F2%YZ2(%k8C%8$ zeE-D$>h5@byRyx4p?o*MuQ&s6{p zCm8aF19S>N+v)rF+amxSrx~kA03G2I@ASP5abJjle1@^933e6{u$-BHe@6Ktkn=3Dx=3D z^F?6B8OEN9JM&5{69LZ|`tozrm2D!>eTMFRE?e0r0^u|CljpL%e-VMyUdDJS`NOm5 z5`lu=3Dd)?u(VG&r}d;hLRMPU8^$WkR>b1!2B33zr1Xz0CvS49%w?`2Q0)VLw9_aX^s z>Se5z%gWQz_lpOF8spi1PA8tkdI^}?$5>H<&o&9D=3D%ahrWGnk5V16I{WKEv8lS}&< zt4}~$%Ygtr(y#;^>St_5j5T_s)$vF?6Ilk@&c;hno@U=3DKACMkP&`*_t?*Fg%qCy6) zon`EBECC&0WdeXl2I|knw-OKV^8|gp3^bj)dm42AWpO<}EeB=3Db#5u+`#_$XFD+iLC zRMw=3D&cZ+)jdS-2g(k%mqFuk%iFZ-4Z%n!5sik+UsZ>DsnD_bc@0@jD=3D5?9{LXOn<~ zVa5y`H_nH;B%mol#);)i0(OPz0oQb;H3>KorYBvF?7k$Rec+xq&oq(*v<}cTw?nZj zz{mi7)Sa!U3XncX*SH5l|u?pGDQFG&QrP+plXQz=3D$@|JQUDi!%`l@bF`aGox&nXY&Yz_RmnM~x#zGXVR}Gv=3DdicP2eqli}zz z03+w`wq>mBi;ZXdzu_$92lt`@uzgPzPo9#V0&M)A&h*SwDpG)o3-qifThC^F3Q(ml zsox_jyHWtp1sd?oR60@sjcX<;!zsYQ3shY9XiB~j=3D)1^Rr=3DGHVomp9J1nPdEudT~g zwi$tKKhVAF94W0vpy3C`+9+{9WaOP1HUg=3Das8~B)NjCwWOLS(fLs3n@SC{CT+UZK2 z39wzJ@6^sz{3c-EW%_xoL+LUBIV1GP+DR$bOhCm5V|Da*F0--fZ2z}>!VeqB)06%S DBJm?y diff --git a/pc-bios/npcm7xx_bootrom.bin b/pc-bios/npcm7xx_bootrom.bin index 92282892b70dbcd6828c5054dff33ffe3385c485..60e5517eedfd6b35095bfb8d181= 81f561bafe556 100644 GIT binary patch delta 287 zcmYL?Jxjw-7=3D=3D%6(kd}S3J#75I4WN752V_mTZS0_?aAm0esw{^f5v9YsNW0&JQLUcu~NRzv5ilfCr!`Q^> z6VSCD;J4yFiH)>;Wv)b^%1{m8*Pv;^?$Y7YtzbUrbaoyEGaM*{b@d4Wb>9~4AjW^b E0jKYKB>(^b delta 209 zcmaFBx`1^<2V*@C1H*5F|N0Ma{r~@pf#L6e28RFt8<_t8S77`L#tg~@TdznQlVZ?W z_?nrO;ZDI`oeUOhlY}qNxt0AtR67Z5ot*Cffx$&7L(F@Y6Y~X0j|!Ln-zU6J$`A(g z#lZZI_X6J1)!rNZKQK7?f2el6^n*i@D}l#rwj<-@RR0eQju(G8Fgk3!_`^k!=3D_^Cg z|L;fsGkj$z5ZKG=3D@#i_i{s8vSRU!WVP7I6;4GaPe9~hVz8nPG|7z!B}7$)~Hc}%{* GBme+2%vQGm diff --git a/pc-bios/npcm8xx_bootrom.bin b/pc-bios/npcm8xx_bootrom.bin index 45fb40fb5987ab681cc902659d85e76a7385cb53..4b6f82f38d61750c49f2eba61fb= 3f77dbcb179f4 100644 GIT binary patch delta 99 zcmV-p0G$7z1)v46-~mCw0RU7a07AK+00V1b0RU9}d%vmu0|1dF_(8cM{6V?k0|hEV z00un00^0Y{U8 F0v|xlB4+>q delta 98 zcmV-o0Gun00 (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201168504884.214449501614; Wed, 4 Feb 2026 02:32:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaAq-0000KN-Bp; Wed, 04 Feb 2026 05:31:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAn-0000Je-Lk for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:31:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAm-0003vO-7O for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:31:49 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-rGGV7Y7PMAa1RpM-2if9DA-1; Wed, 04 Feb 2026 05:31:46 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CE6C01800259; Wed, 4 Feb 2026 10:31:44 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5D92418004AD; Wed, 4 Feb 2026 10:31:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=93/8CmowdpxRszw5AU0EO8rYkNgSes0F9Lw0nNh6/e8=; b=CKNHC6P4Mn/onwIUlh+08qMHfVBcWAX1MSoylr99OLFXKyVPEZYxZxgvegR07EwtIDy14c vtzH0xHUYTBQD9Yx6jq93UPOFUjguwxuuK1K4Yv0sRKa8Tda1zc8klrQTDBB7oN2e0m2Hm 2sYpHeSmyDlJ3XDHOyGE3XwFgFZOI8w= X-MC-Unique: rGGV7Y7PMAa1RpM-2if9DA-1 X-Mimecast-MFC-AGG-ID: rGGV7Y7PMAa1RpM-2if9DA_1770201105 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Jamin Lin Subject: [PULL 02/45] tests/functional/arm/aspeed: Update buildroot images to 2025.11 Date: Wed, 4 Feb 2026 11:30:53 +0100 Message-ID: <20260204103136.1795455-3-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201171665154100 The main changes compared to upstream 2025.11 buildroot are - Linux v6.18 - latest OpenBMC U-Boot - extra packages (ssh, etc.) See https://github.com/legoater/buildroot/commits/aspeed-2025.11 Acked-by: Jamin Lin Link: https://lore.kernel.org/qemu-devel/20260105160358.771511-1-clg@redhat= .com Signed-off-by: C=C3=A9dric Le Goater --- tests/functional/arm/test_aspeed_ast2500.py | 8 ++++---- tests/functional/arm/test_aspeed_ast2600_buildroot.py | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/functional/arm/test_aspeed_ast2500.py b/tests/functional= /arm/test_aspeed_ast2500.py index 5efd104c2b95..ac33c62a9f85 100755 --- a/tests/functional/arm/test_aspeed_ast2500.py +++ b/tests/functional/arm/test_aspeed_ast2500.py @@ -10,15 +10,15 @@ =20 class AST2500Machine(AspeedTest): =20 - ASSET_BR2_202411_AST2500_FLASH =3D Asset( + ASSET_BR2_202511_AST2500_FLASH =3D Asset( ('https://github.com/legoater/qemu-aspeed-boot/raw/master/' - 'images/ast2500-evb/buildroot-2024.11/flash.img'), - '641e6906c18c0f19a2aeb48099d66d4771929c361001d554d0d45c667413e13a') + 'images/ast2500-evb/buildroot-2025.11/flash.img'), + '31e5a8e280b982fb0e7c07eb71c94851002f99ac604dfe620e71a5d47cc87e78') =20 def test_arm_ast2500_evb_buildroot(self): self.set_machine('ast2500-evb') =20 - image_path =3D self.ASSET_BR2_202411_AST2500_FLASH.fetch() + image_path =3D self.ASSET_BR2_202511_AST2500_FLASH.fetch() =20 self.vm.add_args('-device', 'tmp105,bus=3Daspeed.i2c.bus.3,address=3D0x4d,id= =3Dtmp-test') diff --git a/tests/functional/arm/test_aspeed_ast2600_buildroot.py b/tests/= functional/arm/test_aspeed_ast2600_buildroot.py index 575a5f64143f..3d130b9fd189 100755 --- a/tests/functional/arm/test_aspeed_ast2600_buildroot.py +++ b/tests/functional/arm/test_aspeed_ast2600_buildroot.py @@ -16,15 +16,15 @@ =20 class AST2600Machine(AspeedTest): =20 - ASSET_BR2_202411_AST2600_FLASH =3D Asset( + ASSET_BR2_202511_AST2600_FLASH =3D Asset( ('https://github.com/legoater/qemu-aspeed-boot/raw/master/' - 'images/ast2600-evb/buildroot-2024.11/flash.img'), - '4bb2f3dfdea31199b51d66b42f686dc5374c144a7346fdc650194a5578b73609') + 'images/ast2600-evb/buildroot-2025.11/flash.img'), + 'c64a0755501393d570ca318e326e1e9f8372edc5a6452cdccc3649bc9fd2c138') =20 def test_arm_ast2600_evb_buildroot(self): self.set_machine('ast2600-evb') =20 - image_path =3D self.ASSET_BR2_202411_AST2600_FLASH.fetch() + image_path =3D self.ASSET_BR2_202511_AST2600_FLASH.fetch() =20 self.vm.add_args('-device', 'tmp105,bus=3Daspeed.i2c.bus.3,address=3D0x4d,id= =3Dtmp-test') --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201534; cv=none; d=zohomail.com; s=zohoarc; b=EajVyHutjaxtl/66OlXmoU/7iVGaqboZFxcsFMOW/SroxDYt/BrKmgqoMGiMmn59X/KSC2ZZXD7PKjF6ePErk/oJ6VR2Z1ba5n+/fs+OcPG27IJ3vIPJlTURdEiENKOcXMIHv2q2zY5NRhVpjAT9w8/TM28jpbvKQpzvGz7Ap1o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201534; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uESqxG/T40ZyyeVaSEFM+Nz5YM8i+GpPCgUSainMP+s=; b=NKtsqX8xeMhXHkswQiEq29GC38HHLdyH4aIif/J/OoL+5iD/TiDjIbtnhvgXFZU6/sK4R2toYm47qoYqIfi9TeYaqHP1xf56F5Sr0xYZ7s7PRv2xH0qJfBytDeBUTbmIwJoM2Qd6vG4V4luXklOPvxRqw4EFr7DmfcogXechMy8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201534269233.75658494062407; Wed, 4 Feb 2026 02:38:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaAt-0000Mm-MU; Wed, 04 Feb 2026 05:31:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAr-0000LW-Vz for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:31:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAq-0003wH-6E for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:31:53 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-164-epEBqW4nMcG9qGM-9B1hIA-1; Wed, 04 Feb 2026 05:31:48 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 051821956096; Wed, 4 Feb 2026 10:31:47 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4CDE118004AD; Wed, 4 Feb 2026 10:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uESqxG/T40ZyyeVaSEFM+Nz5YM8i+GpPCgUSainMP+s=; b=hAnnabTKV1AcsuQYYTsu06Z8Tr4xMI4oYIC0OylWkYJ1R1MIHJz4q6GPtWLKzLFJeUwMPa R9F0IwT+qoh2XPKDk3Adgg0xYoa4YtVY+PamN7UdTj+jHDDq7vpit+nq1nHiTuC+DqDTLD X2JJCnidx4ggvohVx9FA9EUjJNHRpMY= X-MC-Unique: epEBqW4nMcG9qGM-9B1hIA-1 X-Mimecast-MFC-AGG-ID: epEBqW4nMcG9qGM-9B1hIA_1770201107 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane-Chen-AS , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 03/45] hw/i2c/aspeed: Introduce 'bus-label' to customize bus naming Date: Wed, 4 Feb 2026 11:30:54 +0100 Message-ID: <20260204103136.1795455-4-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201535415158500 From: Kane-Chen-AS On some Aspeed-based machines, multiple I2C controllers may exist across different components, such as the primary SoC and an external IO expander or co-processor (e.g., AST1700). Using the current static naming convention results in object name conflicts when multiple controllers attempt to instantiate buses with the same ID. This patch introduces a 'bus-label' property for the Aspeed I2C controller. This allows higher-level layers, such as the SoC realize function, to provide a unique identifier for the buses. The I2C bus object name is then constructed using this label (e.g., "ioexp0.0" instead of the default "aspeed.i2c.bus.0"). This enhancement ensures unique bus identifiers across the system and resolves naming conflicts in multi-controller configurations. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Tested-by: Nabih Estefan Reviewed-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260112083054.4151945-2-kane_chen= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/i2c/aspeed_i2c.h | 2 ++ hw/i2c/aspeed_i2c.c | 27 +++++++++++++++++++++------ 2 files changed, 23 insertions(+), 6 deletions(-) diff --git a/include/hw/i2c/aspeed_i2c.h b/include/hw/i2c/aspeed_i2c.h index ffcff2580f05..68bd13802601 100644 --- a/include/hw/i2c/aspeed_i2c.h +++ b/include/hw/i2c/aspeed_i2c.h @@ -252,6 +252,7 @@ struct AspeedI2CBus { MemoryRegion mr_pool; =20 I2CBus *bus; + char *name; uint8_t id; qemu_irq irq; =20 @@ -269,6 +270,7 @@ struct AspeedI2CState { uint32_t intr_status; uint32_t ctrl_global; uint32_t new_clk_divider; + char *bus_label; MemoryRegion pool_iomem; uint8_t share_pool[ASPEED_I2C_SHARE_POOL_SIZE]; =20 diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index 1b8ac561c33b..7cf92423c740 100644 --- a/hw/i2c/aspeed_i2c.c +++ b/hw/i2c/aspeed_i2c.c @@ -1215,9 +1215,16 @@ static void aspeed_i2c_realize(DeviceState *dev, Err= or **errp) "aspeed.i2c", aic->mem_size); sysbus_init_mmio(sbd, &s->iomem); =20 + /* default value */ + if (!s->bus_label) { + s->bus_label =3D g_strdup(TYPE_ASPEED_I2C_BUS); + } + for (i =3D 0; i < aic->num_busses; i++) { Object *bus =3D OBJECT(&s->busses[i]); int offset =3D i < aic->gap ? 1 : 5; + g_autofree char *name =3D g_strdup_printf("%s.%d", + s->bus_label, i); =20 if (!object_property_set_link(bus, "controller", OBJECT(s), errp))= { return; @@ -1227,6 +1234,10 @@ static void aspeed_i2c_realize(DeviceState *dev, Err= or **errp) return; } =20 + if (!object_property_set_str(bus, "bus-name", name, errp)) { + return; + } + if (!sysbus_realize(SYS_BUS_DEVICE(bus), errp)) { return; } @@ -1263,6 +1274,7 @@ static void aspeed_i2c_realize(DeviceState *dev, Erro= r **errp) static const Property aspeed_i2c_properties[] =3D { DEFINE_PROP_LINK("dram", AspeedI2CState, dram_mr, TYPE_MEMORY_REGION, MemoryRegion *), + DEFINE_PROP_STRING("bus-label", AspeedI2CState, bus_label), }; =20 static void aspeed_i2c_class_init(ObjectClass *klass, const void *data) @@ -1423,24 +1435,26 @@ static void aspeed_i2c_bus_realize(DeviceState *dev= , Error **errp) { AspeedI2CBus *s =3D ASPEED_I2C_BUS(dev); AspeedI2CClass *aic; - g_autofree char *name =3D g_strdup_printf(TYPE_ASPEED_I2C_BUS ".%d", s= ->id); - g_autofree char *pool_name =3D g_strdup_printf("%s.pool", name); + g_autofree char *pool_name =3D NULL; =20 - if (!s->controller) { - error_setg(errp, TYPE_ASPEED_I2C_BUS ": 'controller' link not set"= ); + if (!s->controller || !s->name) { + error_setg(errp, TYPE_ASPEED_I2C_BUS + ": 'controller' or 'bus-name' not set"); return; } =20 + pool_name =3D g_strdup_printf("%s.pool", s->name); + aic =3D ASPEED_I2C_GET_CLASS(s->controller); =20 sysbus_init_irq(SYS_BUS_DEVICE(dev), &s->irq); =20 - s->bus =3D i2c_init_bus(dev, name); + s->bus =3D i2c_init_bus(dev, s->name); s->slave =3D i2c_slave_create_simple(s->bus, TYPE_ASPEED_I2C_BUS_SLAVE, 0xff); =20 memory_region_init_io(&s->mr, OBJECT(s), &aspeed_i2c_bus_ops, - s, name, aic->reg_size); + s, s->name, aic->reg_size); sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->mr); =20 memory_region_init_io(&s->mr_pool, OBJECT(s), &aspeed_i2c_bus_pool_ops, @@ -1452,6 +1466,7 @@ static const Property aspeed_i2c_bus_properties[] =3D= { DEFINE_PROP_UINT8("bus-id", AspeedI2CBus, id, 0), DEFINE_PROP_LINK("controller", AspeedI2CBus, controller, TYPE_ASPEED_I= 2C, AspeedI2CState *), + DEFINE_PROP_STRING("bus-name", AspeedI2CBus, name), }; =20 static void aspeed_i2c_bus_class_init(ObjectClass *klass, const void *data) --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201340; cv=none; d=zohomail.com; s=zohoarc; b=JFttw/Vg8uVCizANCMzq46nKX1oriaZI8tT10icjG97Liw4GpKV6/qhGiU3GSshdfYY8+48wl4t+D+YxjXCPd0izOwOzSQwVKo1AHOOmDoTgAVMUW0ACPSnS4prUMOjfbYnl8lS+ixC60KNhDbNQ4DESwZX5UmToV0AOHCiTHBI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201340; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=g1CWCaFYBXWIAYKEo/MBW7FQkHz1y46KIc9qEqIwLXs=; b=DCnx45G2TkcDvv3zjAKkOPrIpr4DtH3KTrt1H4Di6e745YjyV/SiHLTgnXxItPiee0MKqOr+bWTQGik8ah5NoYRB8ikevGRyRJIInn1sC0okab5iRB/G4XyrG9OD9kn/xrf/CvN0NZz9kcTU1kgYTlxI4h90Dard1hsy952U9ls= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201340580737.975223866949; Wed, 4 Feb 2026 02:35:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaAu-0000NH-RU; Wed, 04 Feb 2026 05:31:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAt-0000ME-7m for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:31:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAr-0003wt-Q6 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:31:55 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-90FowRsiOjyOfYMDsZhDDA-1; Wed, 04 Feb 2026 05:31:49 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F15E4195609D; Wed, 4 Feb 2026 10:31:48 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 75D4518003F6; Wed, 4 Feb 2026 10:31:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g1CWCaFYBXWIAYKEo/MBW7FQkHz1y46KIc9qEqIwLXs=; b=B03TahPrONDdHj5I4JIbV57hZ+8+uxy3DTihN4ujJxZ227va9CljPlsQkTlgPVW/3MEOiE +eDqZHliQb/vJXEC8D9K1f8Jbu161yMUq9wnUXpP1vqcBs57x1xsoaNXAt7wyP5CS5AlrS jZPeo70r3BW/d0WnfMQURGKwwtpA5no= X-MC-Unique: 90FowRsiOjyOfYMDsZhDDA-1 X-Mimecast-MFC-AGG-ID: 90FowRsiOjyOfYMDsZhDDA_1770201109 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 04/45] MAINTAINERS: Update ASPEED entry Date: Wed, 4 Feb 2026 11:30:55 +0100 Message-ID: <20260204103136.1795455-5-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201342503158500 From: Jamin Lin Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260116082431.3689035-2-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b7ed4fccb1d..4c35249a1826 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1249,11 +1249,13 @@ F: hw/net/ftgmac100.c F: include/hw/net/ftgmac100.h F: docs/system/arm/aspeed.rst F: docs/system/arm/fby35.rst +F: docs/specs/aspeed* F: tests/functional/*/*aspeed* F: tests/*/*aspeed* F: tests/*/*ast2700* F: hw/arm/fby35.c F: pc-bios/ast27x0_bootrom.bin +F: roms/vbootrom =20 NRF51 M: Joel Stanley --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201141; cv=none; d=zohomail.com; s=zohoarc; b=PNnPtYdwMgG6Myepp0u/flfkFMPgRfV+njSyXtnagOXz+JZveMPJgDXBBQ1voFKT7nz9WYsT9mtC5VMXlnR5vgFVpIjNEZaJLUiOodFx8umEzq69R0qU81HIbRh3PFhUSTKoctXN6/e3mMJmlkSblg/aIhz/rfY+y90OkPBCd5A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201141; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OT1XKSoPik+3M0u9qpDYFVlNNzRUVS0jnl/dGb1r0WY=; b=ev+17wKHKi+gASJHHO9mW2cyCmOiPjEFaqPV4zZAUsxeIc26zHVo2j/MgRXmriarhYYPf+IUUe5rBl05x9wJVV9TZVYi7nnjmK/uXAhjGShwNACSMqtDE24JYYqInJFS3OQtIsc6C7Mzz9CJRx/nTMmWJUFhkaT5Mc3lTq5Czqk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201141255614.6948174797129; Wed, 4 Feb 2026 02:32:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaAy-0000Pl-Jd; Wed, 04 Feb 2026 05:32:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAv-0000Nc-Gi for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:31:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAt-0003xK-Rh for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:31:57 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-41-8wvYRxtkNwunLfu8NfR7TQ-1; Wed, 04 Feb 2026 05:31:51 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E1413195609D; Wed, 4 Feb 2026 10:31:50 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6EC2218004AD; Wed, 4 Feb 2026 10:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OT1XKSoPik+3M0u9qpDYFVlNNzRUVS0jnl/dGb1r0WY=; b=ETnYqR00/DEwYnxeHVeeK6hMqzZNX26sjNeKt5J7kyQgMoRUl84ggHgSEkhUdxIUsoNrZO 8SoiK3+LvPf/ZkwR5oHID0PTHO77hGSIa+QGe5uZ6LTniFogl8vLCq2FgWqla9UxVQ5dZ2 ZQ5cKLd8oCM1z/OXVsPTR/KgilkHBQM= X-MC-Unique: 8wvYRxtkNwunLfu8NfR7TQ-1 X-Mimecast-MFC-AGG-ID: 8wvYRxtkNwunLfu8NfR7TQ_1770201111 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Nabih Estefan , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 05/45] hw/i2c/aspeed_i2c.c: Add a check for dma_read Date: Wed, 4 Feb 2026 11:30:56 +0100 Message-ID: <20260204103136.1795455-6-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201144693158500 From: Nabih Estefan If aspeed_i2c_dma_read fails in aspeed_i2c_bus_send currently, we get stuck in an infinite retry loop. Add a check for the return value of aspeed_i2c_dma_read that will break us out of said loop. Signed-off-by: Nabih Estefan Reviewed-by: C=C3=A9dric Le Goater Fixes: 545d6bef7097 ("aspeed/i2c: Add support for DMA transfers") Link: https://lore.kernel.org/qemu-devel/20260120211116.1367476-1-nabiheste= fan@google.com Signed-off-by: C=C3=A9dric Le Goater --- hw/i2c/aspeed_i2c.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index 7cf92423c740..1ee73a8f5e78 100644 --- a/hw/i2c/aspeed_i2c.c +++ b/hw/i2c/aspeed_i2c.c @@ -272,7 +272,11 @@ static int aspeed_i2c_bus_send(AspeedI2CBus *bus) } while (bus->regs[reg_dma_len]) { uint8_t data; - aspeed_i2c_dma_read(bus, &data); + ret =3D aspeed_i2c_dma_read(bus, &data); + /* Check that we were able to read the DMA */ + if (ret) { + break; + } trace_aspeed_i2c_bus_send("DMA", bus->regs[reg_dma_len], bus->regs[reg_dma_len], data); ret =3D i2c_send(bus->bus, data); --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201167; cv=none; d=zohomail.com; s=zohoarc; b=R7lAFVeNA/gpnYiExvN7IB4yZ7NACQ09uGJYUET9VYh4eVL+5IQXiUUtTn3Jx1gOR2YfWKXq28g0e3rNmxV82D1OXjYw9ERmn3s6dNeVJy3q+/3BGaBV8HhmMviPAuba+8APUtx9E0lcrGDg2ODTVeGBMQ5lOOopsb0gYUHLpyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201167; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IOoJB/7nq9dc4eOGZ7pJSfBnOc+mf5g+fTVM6Zr8/KI=; b=MDgdf25cTOKv29l6rbKpqMdbff55Qu8+EIiRD3uOfBNEhd+ryhwPTzTZ7JXgJSXEqAEXDUjHkUqUjc+iBLnyHvJq0mWBSGKKO+v+ohdssC6jsVVSsyefPg1xFG1CBVDVeOqd1p2U39urjdvZKR0W1hkp8ThOut7qf3BzzWx/nmo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201167437463.92036418427017; Wed, 4 Feb 2026 02:32:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaB9-0000U5-Fr; Wed, 04 Feb 2026 05:32:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAx-0000Pm-JX for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAv-0003xd-Kf for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:31:59 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-79-6qt7CW7PMpuLrrCTGWvnPA-1; Wed, 04 Feb 2026 05:31:55 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C85B41955DDB; Wed, 4 Feb 2026 10:31:53 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5E6A718003F6; Wed, 4 Feb 2026 10:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IOoJB/7nq9dc4eOGZ7pJSfBnOc+mf5g+fTVM6Zr8/KI=; b=bPFRM2c/SCof7IA4UMfE7O2BNRano3XXe8FJWFaV2lYQqlsadfufOh0AZZYRWquXiiJIUO cyAx7V/Nz/MO4oIJJyIYF2/kXk42VhNBrGpW/KmaY4CcqUZN1ppLBa15dwyNZ4h0STlk2e HKF9SMB6D2n068djOvWJC97uRrcCuYQ= X-MC-Unique: 6qt7CW7PMpuLrrCTGWvnPA-1 X-Mimecast-MFC-AGG-ID: 6qt7CW7PMpuLrrCTGWvnPA_1770201114 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Patrick Williams , Glenn Miles , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 06/45] hw/gpio/pca9552: add pca9535 support Date: Wed, 4 Feb 2026 11:30:57 +0100 Message-ID: <20260204103136.1795455-7-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201169485154100 From: Patrick Williams Extend the 16-bit PCA9552 model to support non-LED devices such as the PCA9535[1]. [1]: https://www.ti.com/lit/ds/symlink/pca9535.pdf Signed-off-by: Patrick Williams Reviewed-by: Glenn Miles Link: https://lore.kernel.org/qemu-devel/20260121-pca9535-v1-1-164640e622ff= @stwcx.xyz Signed-off-by: C=C3=A9dric Le Goater --- include/hw/gpio/pca9552.h | 1 + include/hw/gpio/pca9552_regs.h | 10 ++ hw/gpio/pca9552.c | 176 +++++++++++++++++++++++---------- 3 files changed, 133 insertions(+), 54 deletions(-) diff --git a/include/hw/gpio/pca9552.h b/include/hw/gpio/pca9552.h index c36525f0c3f6..43b175235d2f 100644 --- a/include/hw/gpio/pca9552.h +++ b/include/hw/gpio/pca9552.h @@ -14,6 +14,7 @@ =20 #define TYPE_PCA9552 "pca9552" #define TYPE_PCA955X "pca955x" +#define TYPE_PCA9535 "pca9535" typedef struct PCA955xState PCA955xState; DECLARE_INSTANCE_CHECKER(PCA955xState, PCA955X, TYPE_PCA955X) diff --git a/include/hw/gpio/pca9552_regs.h b/include/hw/gpio/pca9552_regs.h index d8051cfbd69b..5a6bb03396fb 100644 --- a/include/hw/gpio/pca9552_regs.h +++ b/include/hw/gpio/pca9552_regs.h @@ -29,4 +29,14 @@ */ #define PCA9552_AUTOINC (1 << 4) =20 +/* PCA9535 Registers (same addresses, different semantics) */ +#define PCA9535_INPUT0 0 /* read only input register 0 */ +#define PCA9535_INPUT1 1 /* read only input register 1 */ +#define PCA9535_OUTPUT0 2 /* read/write output register 0 */ +#define PCA9535_OUTPUT1 3 /* read/write output register 1 */ +#define PCA9535_POLARITY0 4 /* read/write polarity inversion register 0 = */ +#define PCA9535_POLARITY1 5 /* read/write polarity inversion register 1 = */ +#define PCA9535_CONFIG0 6 /* read/write configuration register 0 */ +#define PCA9535_CONFIG1 7 /* read/write configuration register 1 */ + #endif diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c index dd3c795e49aa..dd3f1536b65e 100644 --- a/hw/gpio/pca9552.c +++ b/hw/gpio/pca9552.c @@ -31,6 +31,7 @@ struct PCA955xClass { =20 uint8_t pin_count; uint8_t max_reg; + bool has_led_support; }; typedef struct PCA955xClass PCA955xClass; =20 @@ -113,32 +114,59 @@ static void pca955x_update_pin_input(PCA955xState *s) for (i =3D 0; i < k->pin_count; i++) { uint8_t input_reg =3D PCA9552_INPUT0 + (i / 8); uint8_t bit_mask =3D 1 << (i % 8); - uint8_t config =3D pca955x_pin_get_config(s, i); uint8_t old_value =3D s->regs[input_reg] & bit_mask; uint8_t new_value; =20 - switch (config) { - case PCA9552_LED_ON: - /* Pin is set to 0V to turn on LED */ - s->regs[input_reg] &=3D ~bit_mask; - break; - case PCA9552_LED_OFF: - /* - * Pin is set to Hi-Z to turn off LED and - * pullup sets it to a logical 1 unless - * external device drives it low. - */ - if (s->ext_state[i] =3D=3D PCA9552_PIN_LOW) { + if (k->has_led_support) { + /* PCA9552: LED control behavior */ + uint8_t config =3D pca955x_pin_get_config(s, i); + + switch (config) { + case PCA9552_LED_ON: + /* Pin is set to 0V to turn on LED */ s->regs[input_reg] &=3D ~bit_mask; + break; + case PCA9552_LED_OFF: + /* + * Pin is set to Hi-Z to turn off LED and + * pullup sets it to a logical 1 unless + * external device drives it low. + */ + if (s->ext_state[i] =3D=3D PCA9552_PIN_LOW) { + s->regs[input_reg] &=3D ~bit_mask; + } else { + s->regs[input_reg] |=3D bit_mask; + } + break; + case PCA9552_LED_PWM0: + case PCA9552_LED_PWM1: + /* TODO */ + default: + break; + } + } else { + /* PCA9535: Simple GPIO behavior */ + uint8_t config_reg =3D PCA9535_CONFIG0 + (i / 8); + uint8_t output_reg =3D PCA9535_OUTPUT0 + (i / 8); + uint8_t polarity_reg =3D PCA9535_POLARITY0 + (i / 8); + + /* Check if pin is configured as input */ + if (s->regs[config_reg] & bit_mask) { + /* Input mode - reflect external state */ + if (s->ext_state[i] =3D=3D PCA9552_PIN_LOW) { + s->regs[input_reg] &=3D ~bit_mask; + } else { + s->regs[input_reg] |=3D bit_mask; + } } else { - s->regs[input_reg] |=3D bit_mask; + /* Output mode - reflect output register value */ + uint8_t output_bit =3D s->regs[output_reg] & bit_mask; + uint8_t polarity_bit =3D s->regs[polarity_reg] & bit_mask; + + /* Apply polarity inversion if set */ + s->regs[input_reg] =3D (s->regs[input_reg] & ~bit_mask) | + ((output_bit ^ polarity_bit) & bit_mas= k); } - break; - case PCA9552_LED_PWM0: - case PCA9552_LED_PWM1: - /* TODO */ - default: - break; } =20 /* update irq state only if pin state changed */ @@ -151,52 +179,52 @@ static void pca955x_update_pin_input(PCA955xState *s) =20 static uint8_t pca955x_read(PCA955xState *s, uint8_t reg) { - switch (reg) { - case PCA9552_INPUT0: - case PCA9552_INPUT1: - case PCA9552_PSC0: - case PCA9552_PWM0: - case PCA9552_PSC1: - case PCA9552_PWM1: - case PCA9552_LS0: - case PCA9552_LS1: - case PCA9552_LS2: - case PCA9552_LS3: - return s->regs[reg]; - default: + PCA955xClass *k =3D PCA955X_GET_CLASS(s); + + if (reg > k->max_reg) { qemu_log_mask(LOG_GUEST_ERROR, "%s: unexpected read to register %d= \n", __func__, reg); return 0xFF; } + + return s->regs[reg]; } =20 static void pca955x_write(PCA955xState *s, uint8_t reg, uint8_t data) { + PCA955xClass *k =3D PCA955X_GET_CLASS(s); uint16_t pins_status; =20 - switch (reg) { - case PCA9552_PSC0: - case PCA9552_PWM0: - case PCA9552_PSC1: - case PCA9552_PWM1: - s->regs[reg] =3D data; - break; - - case PCA9552_LS0: - case PCA9552_LS1: - case PCA9552_LS2: - case PCA9552_LS3: - pins_status =3D pca955x_pins_get_status(s); - s->regs[reg] =3D data; - pca955x_update_pin_input(s); - pca955x_display_pins_status(s, pins_status); - break; - - case PCA9552_INPUT0: - case PCA9552_INPUT1: - default: + if (reg > k->max_reg) { qemu_log_mask(LOG_GUEST_ERROR, "%s: unexpected write to register %= d\n", __func__, reg); + return; + } + + /* Handle read-only registers */ + if (reg =3D=3D PCA9552_INPUT0 || reg =3D=3D PCA9552_INPUT1) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: unexpected write to read-only register %d\n", + __func__, reg); + return; + } + + pins_status =3D pca955x_pins_get_status(s); + s->regs[reg] =3D data; + + /* Update GPIO state if this register affects outputs */ + if (k->has_led_support) { + /* PCA9552: Update on LED selector register writes */ + if (reg >=3D PCA9552_LS0 && reg <=3D PCA9552_LS3) { + pca955x_update_pin_input(s); + pca955x_display_pins_status(s, pins_status); + } + } else { + /* PCA9535: Update on OUTPUT, POLARITY, or CONFIG register writes = */ + if (reg >=3D PCA9535_OUTPUT0 && reg <=3D PCA9535_CONFIG1) { + pca955x_update_pin_input(s); + pca955x_display_pins_status(s, pins_status); + } } } =20 @@ -379,6 +407,26 @@ static void pca9552_reset(DeviceState *dev) s->len =3D 0; } =20 +static void pca9535_reset(DeviceState *dev) +{ + PCA955xState *s =3D PCA955X(dev); + + s->regs[PCA9535_INPUT0] =3D 0xFF; /* All inputs high (pull-ups) */ + s->regs[PCA9535_INPUT1] =3D 0xFF; /* All inputs high (pull-ups) */ + s->regs[PCA9535_OUTPUT0] =3D 0xFF; /* All outputs high */ + s->regs[PCA9535_OUTPUT1] =3D 0xFF; /* All outputs high */ + s->regs[PCA9535_POLARITY0] =3D 0x00; /* No polarity inversion */ + s->regs[PCA9535_POLARITY1] =3D 0x00; /* No polarity inversion */ + s->regs[PCA9535_CONFIG0] =3D 0xFF; /* All pins as inputs */ + s->regs[PCA9535_CONFIG1] =3D 0xFF; /* All pins as inputs */ + + memset(s->ext_state, PCA9552_PIN_HIZ, PCA955X_PIN_COUNT_MAX); + pca955x_update_pin_input(s); + + s->pointer =3D 0xFF; + s->len =3D 0; +} + static void pca955x_initfn(Object *obj) { PCA955xClass *k =3D PCA955X_GET_CLASS(obj); @@ -463,6 +511,19 @@ static void pca9552_class_init(ObjectClass *oc, const = void *data) dc->vmsd =3D &pca9552_vmstate; pc->max_reg =3D PCA9552_LS3; pc->pin_count =3D 16; + pc->has_led_support =3D true; +} + +static void pca9535_class_init(ObjectClass *oc, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(oc); + PCA955xClass *pc =3D PCA955X_CLASS(oc); + + device_class_set_legacy_reset(dc, pca9535_reset); + dc->vmsd =3D &pca9552_vmstate; + pc->max_reg =3D PCA9535_CONFIG1; + pc->pin_count =3D 16; + pc->has_led_support =3D false; } =20 static const TypeInfo pca9552_info =3D { @@ -471,10 +532,17 @@ static const TypeInfo pca9552_info =3D { .class_init =3D pca9552_class_init, }; =20 +static const TypeInfo pca9535_info =3D { + .name =3D TYPE_PCA9535, + .parent =3D TYPE_PCA955X, + .class_init =3D pca9535_class_init, +}; + static void pca955x_register_types(void) { type_register_static(&pca955x_info); type_register_static(&pca9552_info); + type_register_static(&pca9535_info); } =20 type_init(pca955x_register_types) --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201429; cv=none; d=zohomail.com; s=zohoarc; b=EKFLgEyTCML91NGk6AJfX8Hlx9yvLERcx9eVDGJHWxSAZsrG99pwEpGnEVhQqZbYumAr/2IAFIEVNtbmRv544VGxwP056IRTMvhJwC2Fv1zOINqwZPQnUl+HT5M4loUqcIUI2/gPSC4+Bt2WturdS4lC3XIq4xOelHtxn0tY2/M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201429; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=o6kkGdiMInY4jNEsOYYm3r+vDmyuak5bnYi3QmZSEto=; b=AJo/v5oK9B5XORuGGlJEsMQjXduK3Ps4S3KaWNo959p2/l/uyLkKAZfN5GHVZFaArDqXa0L/MnknIg4M5y0FNnRzch3W5amg/y4QrenmMzqmx5qke8XkmAOhSWvVbi5Ga/VpNi2yQDbohw19xlZQi6wPn/jFIvHaqxy8ZaY3zLc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201429776688.5851925588917; Wed, 4 Feb 2026 02:37:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBT-0000hH-Ei; Wed, 04 Feb 2026 05:32:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaB0-0000Qq-7s for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaAy-0003y9-MD for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:02 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28-Y1hTJvcWO7es8VYE1EjBKw-1; Wed, 04 Feb 2026 05:31:57 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B71451954B14; Wed, 4 Feb 2026 10:31:55 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4142C180066A; Wed, 4 Feb 2026 10:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o6kkGdiMInY4jNEsOYYm3r+vDmyuak5bnYi3QmZSEto=; b=JdvP0gkGbGS3Mvfs64WCCIxrDrlBukQl/ksOwUTosP4IHnaCmCKxidokjU4YMgwZ0F9cHc HbAQtKjqI8VX5yymz7AqBhhYVieZta8pkgrL98YvusQbICziaGD/zQP+KbnOecBqFeHTnj g6p8MZ/I+IgN8wPT6cKPjdS6SvQpqe0= X-MC-Unique: Y1hTJvcWO7es8VYE1EjBKw-1 X-Mimecast-MFC-AGG-ID: Y1hTJvcWO7es8VYE1EjBKw_1770201117 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Patrick Williams , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 07/45] hw/arm/aspeed: catalina: use pca9535 Date: Wed, 4 Feb 2026 11:30:58 +0100 Message-ID: <20260204103136.1795455-8-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201430963158500 From: Patrick Williams A few entries in the catalina model were using the PCA9552 chip because it was "close enough" in function. Since there is a PCA9535 model now, switch to use it. Signed-off-by: Patrick Williams Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260121-pca9535-v1-2-164640e622ff= @stwcx.xyz Signed-off-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast2600_catalina.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/aspeed_ast2600_catalina.c b/hw/arm/aspeed_ast2600_catal= ina.c index 4edb30bb16b8..65495a524ea5 100644 --- a/hw/arm/aspeed_ast2600_catalina.c +++ b/hw/arm/aspeed_ast2600_catalina.c @@ -480,7 +480,7 @@ static void catalina_bmc_i2c_init(AspeedMachineState *b= mc) /* i2c0mux1ch1 */ /* io_expander7 - pca9535@20 */ i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 1), - TYPE_PCA9552, 0x20); + TYPE_PCA9535, 0x20); /* eeprom@50 */ at24c_eeprom_init_rom(pca954x_i2c_get_bus(i2c_mux, 1), 0x50, 8 * KiB, gb200io_eeprom, gb200io_eeprom_len); @@ -497,7 +497,7 @@ static void catalina_bmc_i2c_init(AspeedMachineState *b= mc) /* i2c0mux4ch1 */ /* io_expander8 - pca9535@21 */ i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 1), - TYPE_PCA9552, 0x21); + TYPE_PCA9535, 0x21); /* eeprom@50 */ at24c_eeprom_init_rom(pca954x_i2c_get_bus(i2c_mux, 1), 0x50, 8 * KiB, gb200io_eeprom, gb200io_eeprom_len); --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201450; cv=none; d=zohomail.com; s=zohoarc; b=ZAY9Z85e5WB3L6QfVVK7dSrt7nlr84kcA0xjJuSDymy5lQjezuR0uLGLIrp8HxNqvaSrAGRFNbrNUbk8U9Yqu2tlS3mbnQ71y0av4SxrL+W1kOycFMZC02pmz934ygwY19CpF9w0Zrrct5p+vKr+FEx6n/lx49d6e4NU+pgHS4A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201450; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8GoPy3jKgTWdpyHPRiMnRFnTMsp4NxwY5YOERW/tJV8=; b=mpYMtvecR5nmDIPTsJqBM32aNbfA54juONuZTx2/+z+YypYQjszBtPFX3bLEWGl/LKzn+UGNTTOP3bJRlKXvVKW5afjcdH8F6P6at4Oyia20tDH/bhRyBj51nekHrap/ldcUeebN72hhwyaj5INtq/0DX2XyRjolVyih/Xf4+/8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201450511272.66323560054116; Wed, 4 Feb 2026 02:37:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBL-0000WE-Mu; Wed, 04 Feb 2026 05:32:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaB2-0000ST-Uo for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaB1-0003yW-Gc for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:04 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-J8mHMFX-NcaPcnAt3svAgA-1; Wed, 04 Feb 2026 05:31:59 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 48A2E1800613; Wed, 4 Feb 2026 10:31:58 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 321301800669; Wed, 4 Feb 2026 10:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8GoPy3jKgTWdpyHPRiMnRFnTMsp4NxwY5YOERW/tJV8=; b=I1b84uNnxI8uNBO7io053YJ5Ry6mN2CF0qF9hHoE4ca49YMKIGE5CSPI7CqAtqbVm8mYGW 8fOGM2w7YS5KcJJdKhDHrV1CrtgPIYPKJTy213IDLHj7eF713HK1baoNBftTSd1dBCgSWn Quq3IOJ9xyC+7rz2PujbNBXiRy703ak= X-MC-Unique: J8mHMFX-NcaPcnAt3svAgA-1 X-Mimecast-MFC-AGG-ID: J8mHMFX-NcaPcnAt3svAgA_1770201118 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Elhrj Saad , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 08/45] hw/adc: Fix out-of-bounds write in Aspeed ADC model Date: Wed, 4 Feb 2026 11:30:59 +0100 Message-ID: <20260204103136.1795455-9-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201451511154100 The 'regs' array has ASPEED_ADC_NR_REGS (52) elements, while the memory region covers offsets 0x00-0xFC. The aspeed_adc_engine_write() function has an out-of-bounds write vulnerability when accessing unimplemented registers. Fix this by using 'return' instead of 'break' in the default case, which prevents execution from reaching the s->regs[reg] assignment for unimplemented registers. Reported-by: Elhrj Saad Fixes: 5857974d5d11 ("hw/adc: Add basic Aspeed ADC model") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Link: https://lore.kernel.org/qemu-devel/20260126141820.719492-1-clg@redhat= .com Signed-off-by: C=C3=A9dric Le Goater --- hw/adc/aspeed_adc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/adc/aspeed_adc.c b/hw/adc/aspeed_adc.c index fd3af308296e..3cc75bbcd6e2 100644 --- a/hw/adc/aspeed_adc.c +++ b/hw/adc/aspeed_adc.c @@ -228,7 +228,8 @@ static void aspeed_adc_engine_write(void *opaque, hwadd= r addr, uint64_t value, qemu_log_mask(LOG_UNIMP, "%s: engine[%u]: " "0x%" HWADDR_PRIx " 0x%" PRIx64 "\n", __func__, s->engine_id, addr, value); - break; + /* Do not update the regs[] array */ + return; } =20 s->regs[reg] =3D value; --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201331; cv=none; d=zohomail.com; s=zohoarc; b=EpSgZKYAYR3UxdQtYdBhpDGv63AVBFiYmTbZgIKPPQYEQhi9mRq5m1awp5zDBj1Ee3IYHcex5JNOhqaIIVXTpVbwNbVkw3k7HXETAAl6GM6a2UiSsyfhdW3eVdJw7ZGkJZdtGW9bpNj65eSqXWaTiHoVUeLDGC/wJhAFFz6xPwA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201331; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kVYqvwYnieU/MufqUKWfecoFgGqXHMqugvWnaZa1UfU=; b=XTkfkJd1p4PH6hVvJpfjzvftpcHFUzCPy74MLOBoJ50Ihz+kXIJ42Wpm7tR7I+Aduiz57GLza3QDmnMwmC24FzYQLJwL36I+7B2EsZTAjrEDxVF2wPkZep1W4IG9aC/A31v31rwKtZWH/8tl02OWH8+3VVD482rja1hB4CgZUkE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201331341329.7534456940002; Wed, 4 Feb 2026 02:35:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBW-0000kb-7Q; Wed, 04 Feb 2026 05:32:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaB5-0000Tn-WC for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaB3-0003zF-HC for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:06 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-67-NGjX-NzyPsqvs5vvgALWhg-1; Wed, 04 Feb 2026 05:32:01 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 64C6018001E6; Wed, 4 Feb 2026 10:32:00 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BB942180035A; Wed, 4 Feb 2026 10:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kVYqvwYnieU/MufqUKWfecoFgGqXHMqugvWnaZa1UfU=; b=IyncjeB4oNAGgNQu8QIW4SlG/LZ58OFRG95qmwURzhvZjpGEp5EtJAG8cYONCAPKUj+SPL 6FfW6i/2LMONINt5GAKMv/zDSLSsR1UtG1uCi6XZjFHl+Ue3AU66++7Pq/8D8b67kewtTP I1j0tzcwAB42O2WOyMmaAtYBpoQEVyg= X-MC-Unique: NGjX-NzyPsqvs5vvgALWhg-1 X-Mimecast-MFC-AGG-ID: NGjX-NzyPsqvs5vvgALWhg_1770201120 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 09/45] tests/functional/arm/test_aspeed_ast2500: Update test ASPEED SDK v10.00 Date: Wed, 4 Feb 2026 11:31:00 +0100 Message-ID: <20260204103136.1795455-10-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, TVD_SPACE_RATIO=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201332484158500 From: Jamin Lin Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260127032348.2238527-2-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- tests/functional/arm/test_aspeed_ast2500.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/functional/arm/test_aspeed_ast2500.py b/tests/functional= /arm/test_aspeed_ast2500.py index ac33c62a9f85..5d75e20184d6 100755 --- a/tests/functional/arm/test_aspeed_ast2500.py +++ b/tests/functional/arm/test_aspeed_ast2500.py @@ -37,14 +37,14 @@ def test_arm_ast2500_evb_buildroot(self): =20 self.do_test_arm_aspeed_buildroot_poweroff() =20 - ASSET_SDK_V908_AST2500 =3D Asset( - 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.0= 8/ast2500-default-obmc.tar.gz', - 'c0a2ba169efd19be5eb77c50ec2a6afd9d826e196a0be3432f969fc72d4b7c0e') + ASSET_SDK_V1000_AST2500 =3D Asset( + 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v10.0= 0/ast2500-default-obmc.tar.gz', + '7d71a3f71d5f4d9f3451f59a73bf9baf8fd9f6a24107eb504a3216151a8b2b5b') =20 def test_arm_ast2500_evb_sdk(self): self.set_machine('ast2500-evb') =20 - self.archive_extract(self.ASSET_SDK_V908_AST2500) + self.archive_extract(self.ASSET_SDK_V1000_AST2500) =20 self.do_test_arm_aspeed_sdk_start( self.scratch_file("ast2500-default", "image-bmc")) --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201501; cv=none; d=zohomail.com; s=zohoarc; b=m3kakL5LxAbW3drrPQr5URh4u7Sd2jxqUDz0vEax4gctVhI4DhwinRxyl80e+enrMsqU7PzcR8qL1lgbLaKNlb/7WWaDpAHcAItRe7NWfYcJ7ZeeM1wr6OdsA7WGRiOYufwEN9JM3JZyUHUeqT3fMBUQ9zReKVcen3HOVRoZjIM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201501; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2pxvTcQsOrMAvMcG0AWNrtfMa1MPkCDpkyj2qay+hYw=; b=VO3f79e1viP+kETfyN4/Zbq10UsztnrXwjiGgMS4HXGeqLw8+lDZFXFTmjoZRZhAwDTSDDORYkG5xqiO2JTiL2NgfwS+MJZnlQFmzlJw10IWTHZrXq62JDsHoWCCRRtEhkAyN394NoDCk15FcnT7RBvOPdfUCQRPlgbZszxvRiU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201501455583.9466624255318; Wed, 4 Feb 2026 02:38:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBY-0000sf-2M; Wed, 04 Feb 2026 05:32:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaB7-0000U3-N6 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaB5-0003zV-PM for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:09 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-PyapBYJ9NHOjmEBa8TaMIg-1; Wed, 04 Feb 2026 05:32:03 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A9AD81956064; Wed, 4 Feb 2026 10:32:02 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D4F4E180066D; Wed, 4 Feb 2026 10:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2pxvTcQsOrMAvMcG0AWNrtfMa1MPkCDpkyj2qay+hYw=; b=bobjjy8IfkZ0bQf7s7FpFgrHnI3xyqUtGozjiSxGxTU9cWAdqczpRICa8XoW6rI7Pt1DgP CcygXduMJ/IA/LGJnY3zS2NpelQFg4OmDnxa5i0k7UZHSD/n5ch3e2rE95SAtTAX35w74Q DtWXITRr0vZPZwrI1Un6VgRdSFMfyOg= X-MC-Unique: PyapBYJ9NHOjmEBa8TaMIg-1 X-Mimecast-MFC-AGG-ID: PyapBYJ9NHOjmEBa8TaMIg_1770201122 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 10/45] hw/pci-host/aspeed_pcie: Drop AST2600 PCIe root device Date: Wed, 4 Feb 2026 11:31:01 +0100 Message-ID: <20260204103136.1795455-11-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201504240154100 From: Jamin Lin AST2600 PCIe previously exposed a root bus at 0x80 with both a root device at 80:00.0 and a root port at 80:08.0. Recent ASPEED SDK PCIe driver updates decided to remove the root device and keep only a single root port. This behavior has already been accepted by the upstream Linux kernel. Update the QEMU PCIe model accordingly by dropping the root device implementation and related properties. AST2600 now matches the AST2700 PCIe topology and no longer supports the legacy RC_L layout. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260127032348.2238527-3-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/pci-host/aspeed_pcie.h | 9 ----- hw/pci-host/aspeed_pcie.c | 57 ------------------------------- 2 files changed, 66 deletions(-) diff --git a/include/hw/pci-host/aspeed_pcie.h b/include/hw/pci-host/aspeed= _pcie.h index e660119a455e..fde5816ea30c 100644 --- a/include/hw/pci-host/aspeed_pcie.h +++ b/include/hw/pci-host/aspeed_pcie.h @@ -50,13 +50,6 @@ typedef struct AspeedPCIERootPortState { PCIESlot parent_obj; } AspeedPCIERootPortState; =20 -#define TYPE_ASPEED_PCIE_ROOT_DEVICE "aspeed.pcie-root-device" -OBJECT_DECLARE_SIMPLE_TYPE(AspeedPCIERootDeviceState, ASPEED_PCIE_ROOT_DEV= ICE); - -struct AspeedPCIERootDeviceState { - PCIBridge parent_obj; -}; - #define TYPE_ASPEED_PCIE_RC "aspeed.pcie-rc" OBJECT_DECLARE_SIMPLE_TYPE(AspeedPCIERcState, ASPEED_PCIE_RC); =20 @@ -78,10 +71,8 @@ struct AspeedPCIERcState { uint32_t rp_addr; uint32_t bus_nr; char name[16]; - bool has_rd; qemu_irq irq; =20 - AspeedPCIERootDeviceState root_device; AspeedPCIERootPortState root_port; }; =20 diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c index 83a1c7075c39..4fdda959396f 100644 --- a/hw/pci-host/aspeed_pcie.c +++ b/hw/pci-host/aspeed_pcie.c @@ -26,44 +26,6 @@ #include "hw/pci/msi.h" #include "trace.h" =20 -/* - * PCIe Root Device - * This device exists only on AST2600. - */ - -static void aspeed_pcie_root_device_class_init(ObjectClass *klass, - const void *data) -{ - PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); - DeviceClass *dc =3D DEVICE_CLASS(klass); - - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); - dc->desc =3D "ASPEED PCIe Root Device"; - k->vendor_id =3D PCI_VENDOR_ID_ASPEED; - k->device_id =3D 0x2600; - k->class_id =3D PCI_CLASS_BRIDGE_HOST; - k->subsystem_vendor_id =3D k->vendor_id; - k->subsystem_id =3D k->device_id; - k->revision =3D 0; - - /* - * PCI-facing part of the host bridge, - * not usable without the host-facing part - */ - dc->user_creatable =3D false; -} - -static const TypeInfo aspeed_pcie_root_device_info =3D { - .name =3D TYPE_ASPEED_PCIE_ROOT_DEVICE, - .parent =3D TYPE_PCI_DEVICE, - .instance_size =3D sizeof(AspeedPCIERootDeviceState), - .class_init =3D aspeed_pcie_root_device_class_init, - .interfaces =3D (const InterfaceInfo[]) { - { INTERFACE_CONVENTIONAL_PCI_DEVICE }, - { }, - }, -}; - /* * PCIe Root Port */ @@ -291,18 +253,6 @@ static void aspeed_pcie_rc_realize(DeviceState *dev, E= rror **errp) &rc->dram_alias); pci_setup_iommu(pci->bus, &aspeed_pcie_rc_iommu_ops, rc); =20 - /* setup root device */ - if (rc->has_rd) { - object_initialize_child(OBJECT(rc), "root_device", &rc->root_devic= e, - TYPE_ASPEED_PCIE_ROOT_DEVICE); - qdev_prop_set_int32(DEVICE(&rc->root_device), "addr", - PCI_DEVFN(0, 0)); - qdev_prop_set_bit(DEVICE(&rc->root_device), "multifunction", false= ); - if (!qdev_realize(DEVICE(&rc->root_device), BUS(pci->bus), errp)) { - return; - } - } - /* setup root port */ qdev_prop_set_int32(DEVICE(&rc->root_port), "addr", rc->rp_addr); qdev_prop_set_uint16(DEVICE(&rc->root_port), "chassis", cfg->id); @@ -334,7 +284,6 @@ static void aspeed_pcie_rc_instance_init(Object *obj) =20 static const Property aspeed_pcie_rc_props[] =3D { DEFINE_PROP_UINT32("bus-nr", AspeedPCIERcState, bus_nr, 0), - DEFINE_PROP_BOOL("has-rd", AspeedPCIERcState, has_rd, 0), DEFINE_PROP_UINT32("rp-addr", AspeedPCIERcState, rp_addr, 0), DEFINE_PROP_UINT32("msi-addr", AspeedPCIERcState, msi_addr, 0), DEFINE_PROP_UINT64("dram-base", AspeedPCIERcState, dram_base, 0), @@ -704,9 +653,6 @@ static void aspeed_pcie_cfg_realize(DeviceState *dev, E= rror **errp) object_property_set_int(OBJECT(&s->rc), "bus-nr", apc->rc_bus_nr, &error_abort); - object_property_set_bool(OBJECT(&s->rc), "has-rd", - apc->rc_has_rd, - &error_abort); object_property_set_int(OBJECT(&s->rc), "rp-addr", apc->rc_rp_addr, &error_abort); @@ -746,7 +692,6 @@ static void aspeed_pcie_cfg_class_init(ObjectClass *kla= ss, const void *data) apc->nr_regs =3D 0x100 >> 2; apc->rc_msi_addr =3D 0x1e77005C; apc->rc_bus_nr =3D 0x80; - apc->rc_has_rd =3D true; apc->rc_rp_addr =3D PCI_DEVFN(8, 0); } =20 @@ -867,7 +812,6 @@ static void aspeed_2700_pcie_cfg_class_init(ObjectClass= *klass, apc->nr_regs =3D 0x100 >> 2; apc->rc_msi_addr =3D 0x000000F0; apc->rc_bus_nr =3D 0; - apc->rc_has_rd =3D false; apc->rc_rp_addr =3D PCI_DEVFN(0, 0); } =20 @@ -1041,7 +985,6 @@ static const TypeInfo aspeed_2700_pcie_phy_info =3D { static void aspeed_pcie_register_types(void) { type_register_static(&aspeed_pcie_rc_info); - type_register_static(&aspeed_pcie_root_device_info); type_register_static(&aspeed_pcie_root_port_info); type_register_static(&aspeed_pcie_cfg_info); type_register_static(&aspeed_2700_pcie_cfg_info); --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201479; cv=none; d=zohomail.com; s=zohoarc; b=BjbyWbvhZO+EwKzJ9eEfaeULJi2kBiveENXHiaJYk+5EJ5YCG4rAhVgvtOypX7rzblVlOy0QwE2xqmFm5yzniKver240UITPCaqBPAsVqEe5Q9XrADsQWP0q/apkX3YSulC3+2GI6a+TSvvtZH7Ga7SEwAL9YJ7sshnZgM3A3qU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201479; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MquVSRVZfbbDT3uJLAMkLNQfrRxztkav4yYJm+5pL+o=; b=Tm2PvclvyDQeny+U2QqJULcQjzqg+im8tmL0SoEjlhn/brwwGqHbQ2kRQ+LfbDwX+Y85+vdTPJW9dbp2qH3E1g8asnCZYbsjksjy0aqdmdeZNJzUm2SmItG8WXHvu7ES0j0KuBd/hja6KGtQH5vPwPICdk345OuVq9FUUf72RiY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201479400455.4497953273391; Wed, 4 Feb 2026 02:37:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBX-0000nc-1S; Wed, 04 Feb 2026 05:32:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaB9-0000VK-3X for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaB7-0003zn-9A for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:10 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-5x8X_4t8MUSIsVrHiGKG7A-1; Wed, 04 Feb 2026 05:32:05 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9901C18001E3; Wed, 4 Feb 2026 10:32:04 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2644A18004BB; Wed, 4 Feb 2026 10:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MquVSRVZfbbDT3uJLAMkLNQfrRxztkav4yYJm+5pL+o=; b=BwjFt10+wOJSDe+AXZnn4nPek985rCvDyzY2ttP1wVnULVv5LWaSfuBNXX9E0NTvMhLkNO mEpX6Fx3s7RC5JsOBGFBbPhgAAZuSSnZ4smcrNaY8y0fZgZgXEnTEF+rgVreEF+OkjGwzj b/J2ksm/T349DQH5v4SSAj3KfAWbvNM= X-MC-Unique: 5x8X_4t8MUSIsVrHiGKG7A-1 X-Mimecast-MFC-AGG-ID: 5x8X_4t8MUSIsVrHiGKG7A_1770201124 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 11/45] hw/pci-host/aspeed_pcie: Drop AST2600 RC_H root-bus remap and bus-nr property Date: Wed, 4 Feb 2026 11:31:02 +0100 Message-ID: <20260204103136.1795455-12-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201481171158500 From: Jamin Lin The original AST2600 PCIe design supported both RC_L and RC_H, using root b= us number 0 for RC_L and 0x80 for RC_H. In that model, the root port appeared = as 80:08.0 and QEMU carried a "bus-nr" property plus a config-space bus remap = to translate bus 0x80 to bus 0x00 for PCI enumeration. Linux mainline has since dropped RC_L support and updated the RC_H root bus number to start at 0. The root port is now enumerated as 00:08.0, matching = the default QEMU PCIe subsystem root bus numbering. Remove the bus number setting and the AST2600 bus remap logic, and drop the corresponding "bus-nr"/rc_bus_nr fields and property plumbing. QEMU now rel= ies on the default root bus 0 behavior. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260127032348.2238527-4-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/pci-host/aspeed_pcie.h | 2 -- hw/pci-host/aspeed_pcie.c | 19 +------------------ 2 files changed, 1 insertion(+), 20 deletions(-) diff --git a/include/hw/pci-host/aspeed_pcie.h b/include/hw/pci-host/aspeed= _pcie.h index fde5816ea30c..143b3565917a 100644 --- a/include/hw/pci-host/aspeed_pcie.h +++ b/include/hw/pci-host/aspeed_pcie.h @@ -69,7 +69,6 @@ struct AspeedPCIERcState { uint64_t dram_base; uint32_t msi_addr; uint32_t rp_addr; - uint32_t bus_nr; char name[16]; qemu_irq irq; =20 @@ -102,7 +101,6 @@ struct AspeedPCIECfgClass { =20 uint32_t rc_msi_addr; uint32_t rc_rp_addr; - uint64_t rc_bus_nr; uint64_t nr_regs; bool rc_has_rd; }; diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c index 4fdda959396f..4f896f855cb4 100644 --- a/hw/pci-host/aspeed_pcie.c +++ b/hw/pci-host/aspeed_pcie.c @@ -268,7 +268,7 @@ static const char *aspeed_pcie_rc_root_bus_path(PCIHost= State *host_bridge, AspeedPCIECfgState *cfg =3D container_of(rc, AspeedPCIECfgState, rc); =20 - snprintf(rc->name, sizeof(rc->name), "%04x:%02x", cfg->id, rc->bus_nr); + snprintf(rc->name, sizeof(rc->name), "%04x:00", cfg->id); =20 return rc->name; } @@ -283,7 +283,6 @@ static void aspeed_pcie_rc_instance_init(Object *obj) } =20 static const Property aspeed_pcie_rc_props[] =3D { - DEFINE_PROP_UINT32("bus-nr", AspeedPCIERcState, bus_nr, 0), DEFINE_PROP_UINT32("rp-addr", AspeedPCIERcState, rp_addr, 0), DEFINE_PROP_UINT32("msi-addr", AspeedPCIERcState, msi_addr, 0), DEFINE_PROP_UINT64("dram-base", AspeedPCIERcState, dram_base, 0), @@ -490,17 +489,6 @@ static void aspeed_pcie_cfg_readwrite(AspeedPCIECfgSta= te *s, offset =3D cfg_addr & 0xffc; =20 pci =3D PCI_HOST_BRIDGE(rc); - - /* - * On the AST2600, the RC_H bus number range from 0x80 to 0xFF, with t= he - * root device and root port assigned to bus 0x80 instead of the stand= ard - * 0x00. To allow the PCI subsystem to correctly discover devices on t= he - * root bus, bus 0x80 is remapped to 0x00. - */ - if (bus =3D=3D rc->bus_nr) { - bus =3D 0; - } - pdev =3D pci_find_device(pci->bus, bus, devfn); if (!pdev) { s->regs[desc->rdata_reg] =3D ~0; @@ -650,9 +638,6 @@ static void aspeed_pcie_cfg_realize(DeviceState *dev, E= rror **errp) apc->nr_regs << 2); sysbus_init_mmio(sbd, &s->mmio); =20 - object_property_set_int(OBJECT(&s->rc), "bus-nr", - apc->rc_bus_nr, - &error_abort); object_property_set_int(OBJECT(&s->rc), "rp-addr", apc->rc_rp_addr, &error_abort); @@ -691,7 +676,6 @@ static void aspeed_pcie_cfg_class_init(ObjectClass *kla= ss, const void *data) apc->reg_map =3D &aspeed_regmap; apc->nr_regs =3D 0x100 >> 2; apc->rc_msi_addr =3D 0x1e77005C; - apc->rc_bus_nr =3D 0x80; apc->rc_rp_addr =3D PCI_DEVFN(8, 0); } =20 @@ -811,7 +795,6 @@ static void aspeed_2700_pcie_cfg_class_init(ObjectClass= *klass, apc->reg_map =3D &aspeed_2700_regmap; apc->nr_regs =3D 0x100 >> 2; apc->rc_msi_addr =3D 0x000000F0; - apc->rc_bus_nr =3D 0; apc->rc_rp_addr =3D PCI_DEVFN(0, 0); } =20 --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201530; cv=none; d=zohomail.com; s=zohoarc; b=UApYa0bWXiLx3TgFnWBIkiUSfWxckab4F6hChlfWHxraitU/JQ61R1uO90HseG3gkAA0qX9C08WK8WSoGaJ6v153Je8vGs4I1Obr0u12/0/aBYo5wqIxJ7bcKCvcADZ4ybufuni4Sbp8QVFZLWvkkaDhsEU/20xHi+RCq/eWIlY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201530; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=A7Atyj11676Wf8rX59hlQrA0WLzWIVMmtBR8jsGIaSM=; b=SLH8MAxrwQksbBIixU0t3bcLiGxpQxvhsiDJyU0Qxi9afhKnd3BkKDDGhfXdBzTaFpjYTsoIx/BjAhkhEQ9OCuhK8TiMJR4Il7BuOv3VfsIfdwMlZX7WF5pBGbOCWU69fgl8WxdimDOllZEQklcC217FMCGkHNrHft70ld8LqcM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201530159180.86374942194448; Wed, 4 Feb 2026 02:38:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBZ-0000zH-7H; Wed, 04 Feb 2026 05:32:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBB-0000W5-0R for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaB9-00040I-FT for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:12 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-308-w38JhJYaNEO7I8g-Fxsc9Q-1; Wed, 04 Feb 2026 05:32:07 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8620C1956060; Wed, 4 Feb 2026 10:32:06 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 15A2E18003F6; Wed, 4 Feb 2026 10:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A7Atyj11676Wf8rX59hlQrA0WLzWIVMmtBR8jsGIaSM=; b=JjEWuxSSOvtr6reUohtrScTCDs9T7mPxAp6xo4iIYuVs0u6J+fPHVB/ghRBXJxkfcKQ601 6y8GAy4y2urH85d89l4RbCa8Krf5dngEv/KPo9oarKwcwXp9LzEmFXK5AZlBVo38KC7+Lh 6We40JZZLf2HiCxOaD7simbTTjom0XY= X-MC-Unique: w38JhJYaNEO7I8g-Fxsc9Q-1 X-Mimecast-MFC-AGG-ID: w38JhJYaNEO7I8g-Fxsc9Q_1770201126 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 12/45] hw/arm/aspeed_ast2600: Expand RC_H PCIe MMIO window to 0x60000000 - 0x80000000 Date: Wed, 4 Feb 2026 11:31:03 +0100 Message-ID: <20260204103136.1795455-13-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201532639154100 From: Jamin Lin Historically, the ASPEED PCIe driver supported both RC_L and RC_H, with RC_L using MMIO window 0x60000000 - 0x70000000 and RC_H using 0x70000000 - 0x800= 00000. Mainline Linux has dropped RC_L support and now supports RC_H only, updating RC_H to use a single combined MMIO window 0x60000000 - 0x80000000. Update the AST2600 QEMU model accordingly by moving PCIE_MMIO1 base to 0x60000000 and increasing the aliased MMIO size to 0x20000000. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260127032348.2238527-5-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast2600.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c index 4c5a42ea1742..efb1d8c0637c 100644 --- a/hw/arm/aspeed_ast2600.c +++ b/hw/arm/aspeed_ast2600.c @@ -81,7 +81,7 @@ static const hwaddr aspeed_soc_ast2600_memmap[] =3D { [ASPEED_DEV_FSI1] =3D 0x1E79B000, [ASPEED_DEV_FSI2] =3D 0x1E79B100, [ASPEED_DEV_I3C] =3D 0x1E7A0000, - [ASPEED_DEV_PCIE_MMIO1] =3D 0x70000000, + [ASPEED_DEV_PCIE_MMIO1] =3D 0x60000000, [ASPEED_DEV_SDRAM] =3D 0x80000000, }; =20 @@ -303,14 +303,14 @@ static uint64_t aspeed_calc_affinity(int cpu) * * Model scope / limitations: * - Firmware supports RC_H only; this QEMU model does not support RC_L. - * - RC_H uses PHY1 and the MMIO window [0x70000000, 0x80000000] + * - RC_H uses PHY1 and the MMIO window [0x60000000, 0x80000000] * (aka MMIO1). * * Indexing convention (this model): * - Expose a single logical instance at index 0. * - pcie[0] -> hardware RC_H (PCIe1) * - phy[0] -> hardware PHY1 - * - mmio.0 -> guest address range MMIO1: 0x70000000-0x80000000 + * - mmio.0 -> guest address range MMIO1: 0x60000000-0x80000000 * - RC_L / PCIe0 is not created and mapped. */ static bool aspeed_soc_ast2600_pcie_realize(DeviceState *dev, Error **errp) @@ -346,7 +346,7 @@ static bool aspeed_soc_ast2600_pcie_realize(DeviceState= *dev, Error **errp) memory_region_init_alias(&s->pcie_mmio_alias[0], OBJECT(&s->pcie[0].rc= ), "aspeed.pcie-mmio", mmio_mr, sc->memmap[ASPEED_DEV_PCIE_MMIO1], - 0x10000000); + 0x20000000); memory_region_add_subregion(s->memory, sc->memmap[ASPEED_DEV_PCIE_MMIO1], &s->pcie_mmio_alias[0]); --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201516; cv=none; d=zohomail.com; s=zohoarc; b=f84jJYSOHuTLcw6xlQ0dsWW85O4TaeM4LXcle4AGbVJiVGIgAkHpUGCyAW1gTQ/+KcM+8Xirx8GiGhIkspfvD1wKgDKI90Z9e8gl7fCeD6ZBaHDz46JTA5oQ5Yb70lmMtLGubUk51LhDUHnt52GyyUF5j85trsj769myDgreZkg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201516; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GCxFtvJ6jJfs1ugWZU+Jvw6fkVqrd1ysoKs7Po4iVjo=; b=cZjGsYniNizqVxawOlbG2MpFkOvf7bQa1hlPTvpbogW8Awz1e7CxyfbQqEvTQDlwAWL468c5TTmj+rVQfe0Wu5Xp4l4/NGzOErfAHvHOamk/qnOqCR59PlmR4DAPrHaB9wsm8bEjK5A9KJ50rUp1a1s6HRVPjgfwrBNEcxHsSTk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201516494995.538522619666; Wed, 4 Feb 2026 02:38:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBa-00017g-QL; Wed, 04 Feb 2026 05:32:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBE-0000Wk-5r for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBB-00040h-WA for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:15 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-4q0BWkldMUmzcSeAegY3AQ-1; Wed, 04 Feb 2026 05:32:10 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 041F318003F5; Wed, 4 Feb 2026 10:32:09 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0342718004AD; Wed, 4 Feb 2026 10:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GCxFtvJ6jJfs1ugWZU+Jvw6fkVqrd1ysoKs7Po4iVjo=; b=Q/BtAY8atzuOv/U541TIp5f63YzWuB9eGYRvovrZ1e/b/uCJLO4iMIjSnakgra+harOXmn pzNTmppXJB/CWvNR6QoijDeWELLow/zVv9+fDjSf9eRS7CK/qQYkra0C0QdU/q/gdfFRXV q9AnCr177v2f+ZhLyuMBOkIsTakirrI= X-MC-Unique: 4q0BWkldMUmzcSeAegY3AQ-1 X-Mimecast-MFC-AGG-ID: 4q0BWkldMUmzcSeAegY3AQ_1770201129 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 13/45] tests/functional/arm/test_aspeed_ast2600_sdk: Update test ASPEED SDK v11.00 Date: Wed, 4 Feb 2026 11:31:04 +0100 Message-ID: <20260204103136.1795455-14-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201518430154100 From: Jamin Lin Drop root device and set root bus number to 0. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260127032348.2238527-6-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- .../functional/arm/test_aspeed_ast2600_sdk.py | 22 ++++++++----------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tests/functional/arm/test_aspeed_ast2600_sdk.py b/tests/functi= onal/arm/test_aspeed_ast2600_sdk.py index e3d4ed09e2ee..6236aeb11cd2 100755 --- a/tests/functional/arm/test_aspeed_ast2600_sdk.py +++ b/tests/functional/arm/test_aspeed_ast2600_sdk.py @@ -14,22 +14,18 @@ =20 class AST2600Machine(AspeedTest): =20 - ASSET_SDK_V908_AST2600 =3D Asset( - 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v09.0= 8/ast2600-default-obmc.tar.gz', - 'a0414f14ad696550efe083c2156dbeda855c08cc9ae7f40fe1b41bf292295f82') + ASSET_SDK_V1100_AST2600 =3D Asset( + 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v11.0= 0/ast2600-default-obmc.tar.gz', + '64d8926a7d01b649168be96c986603b5690f06391286c438a3a772c8c7039e93') =20 def do_ast2600_pcie_test(self): exec_command_and_wait_for_pattern(self, - 'lspci -s 80:00.0', - '80:00.0 Host bridge: ' - 'ASPEED Technology, Inc. Device 2600') - exec_command_and_wait_for_pattern(self, - 'lspci -s 80:08.0', - '80:08.0 PCI bridge: ' + 'lspci -s 00:08.0', + '00:08.0 PCI bridge: ' 'ASPEED Technology, Inc. AST1150 PCI-to-PCI Bridge') exec_command_and_wait_for_pattern(self, - 'lspci -s 81:00.0', - '81:00.0 Ethernet controller: ' + 'lspci -s 01:00.0', + '01:00.0 Ethernet controller: ' 'Intel Corporation 82574L Gigabit Network Connection') exec_command_and_wait_for_pattern(self, 'ip addr show dev eth4', @@ -39,7 +35,7 @@ def test_arm_ast2600_evb_sdk(self): self.set_machine('ast2600-evb') self.require_netdev('user') =20 - self.archive_extract(self.ASSET_SDK_V908_AST2600) + self.archive_extract(self.ASSET_SDK_V1100_AST2600) =20 self.vm.add_args('-device', 'tmp105,bus=3Daspeed.i2c.bus.5,address=3D0x4d,id=3Dtmp-test') @@ -77,7 +73,7 @@ def test_arm_ast2600_evb_sdk(self): def test_arm_ast2600_otp_blockdev_device(self): self.vm.set_machine("ast2600-evb") =20 - image_path =3D self.archive_extract(self.ASSET_SDK_V908_AST2600) + image_path =3D self.archive_extract(self.ASSET_SDK_V1100_AST2600) otp_img =3D self.generate_otpmem_image() =20 self.vm.set_console() --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201358; cv=none; d=zohomail.com; s=zohoarc; b=bdwU2BEDIHwPDgmtb54+2A1jUVgK7u2CTzABYHq6SIe40puwCKshp/yAMq7tLhvIS/Aqe2w7XGxA5MvRp2BmTct5VRI1Lp3Rifcs7IHUpsjPllZf0SvMlTak4DWp6/pq+KQNFgqdAeWr/YB1IQGrf+stb5/gpJHKAfnRXvLrOZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201358; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+tJJ4Gdav/bQecXsilsxeWeIbf+cYAYSrCPgNukvVfY=; b=QHwHdt4EixCg5eL1dm3YwzFK/XRxStzukEWA1akP63Mu5YZglUx2+imswi7MCE5cdDVL1R3v+1c5Ma/yqBbQZoGDmboyk676UO1LusDQZhUgEtzX7ltIMNDgbYqua4ysfwpG877HCC/naC15Pk/bg2wFFivRX8o7Ryyw358fwpk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201358635628.7596234022246; Wed, 4 Feb 2026 02:35:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBU-0000hM-6X; Wed, 04 Feb 2026 05:32:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBE-0000Wl-9c for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBC-00040k-6F for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:16 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-tY4WTL1kMoiSZcGs40OAXQ-1; Wed, 04 Feb 2026 05:32:11 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E63F21956053; Wed, 4 Feb 2026 10:32:10 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 74DBE18004AD; Wed, 4 Feb 2026 10:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+tJJ4Gdav/bQecXsilsxeWeIbf+cYAYSrCPgNukvVfY=; b=hKae0xwnN7QBNS/IgtJUPAyRS0CLzo4ibeZbXAtLdyxeA+U0okXQBsfshqdb145jIFFwVT mXuTlgwm2PpXdB9U+rTNhhYgWTFKjgnzPhgBc5gpn3APuk6MqkkvViPK+VmMoXrcSqwaRY 0QvKOxMpIksvICiB5qRo3FFeYzq7Oho= X-MC-Unique: tY4WTL1kMoiSZcGs40OAXQ-1 X-Mimecast-MFC-AGG-ID: tY4WTL1kMoiSZcGs40OAXQ_1770201131 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 14/45] tests/functional/arm/test_aspeed_ast1060: Update test aspeed-zephyr-project v03.04 Date: Wed, 4 Feb 2026 11:31:05 +0100 Message-ID: <20260204103136.1795455-15-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201360281154100 From: Jamin Lin Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260127032348.2238527-7-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- tests/functional/arm/test_aspeed_ast1060.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/functional/arm/test_aspeed_ast1060.py b/tests/functional= /arm/test_aspeed_ast1060.py index 034efa534262..eccb4252d86a 100644 --- a/tests/functional/arm/test_aspeed_ast1060.py +++ b/tests/functional/arm/test_aspeed_ast1060.py @@ -11,18 +11,18 @@ =20 =20 class AST1060Machine(AspeedTest): - ASSET_ASPEED_AST1060_PROT_3_02 =3D Asset( + ASSET_ASPEED_AST1060_PROT_3_04 =3D Asset( ('https://github.com/AspeedTech-BMC' - '/aspeed-zephyr-project/releases/download/v03.02' - '/ast1060_prot_v03.02.tgz'), - 'dd5f1adc935316ddd1906506a02e15567bd7290657b52320f1a225564cc175bd= ') + '/aspeed-zephyr-project/releases/download/v03.04' + '/ast1060_prot_v03.04.tgz'), + 'c0319df55f5b7a547efefc5a6ba374b881223d5fe1a776bfdd36f97fd1f31d50= ') =20 - def test_arm_ast1060_prot_3_02(self): + def test_arm_ast1060_prot_3_04(self): self.set_machine('ast1060-evb') =20 kernel_name =3D "ast1060_prot/zephyr.bin" kernel_file =3D self.archive_extract( - self.ASSET_ASPEED_AST1060_PROT_3_02, member=3Dkernel_name) + self.ASSET_ASPEED_AST1060_PROT_3_04, member=3Dkernel_name) =20 self.vm.set_console() self.vm.add_args('-kernel', kernel_file, '-nographic') @@ -35,7 +35,7 @@ def test_arm_ast1060_otp_blockdev_device(self): self.vm.set_machine("ast1060-evb") =20 kernel_name =3D "ast1060_prot/zephyr.bin" - kernel_file =3D self.archive_extract(self.ASSET_ASPEED_AST1060_PRO= T_3_02, + kernel_file =3D self.archive_extract(self.ASSET_ASPEED_AST1060_PRO= T_3_04, member=3Dkernel_name) otp_img =3D self.generate_otpmem_image() =20 --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201465; cv=none; d=zohomail.com; s=zohoarc; b=Cgqli+wBXOz4hb969yM3vLYSvSkZp07nUbCSXYnPCBkdHXYTkhaBGnDUU20LFUaB9nrUqQMxDSknYt+OJmS3Rvl1D5HnYwSCmAG/YA6g4pIiaccuvK9f34+vrX3QV2W1XPpF0JlxiXFQGLJAG0Zkb4e2zq+bgaCMQ8is0CEQNEo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201465; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jspOalxDiHJBD00cvxzPJ6LHxGM6dr6+SEae2qJ57r4=; b=Z1XdTK8PXzk6qX27UUVcNb+f2W0JfRuc0wTOpY8AZKMRh656MHL7OYVAh3EGNdW+VbS/IuJ3LMPpM4cLgnKk3nJpm4zOYf0FdpVs8wDIz0CcLNuUtrPw47s4YQ82bmz8jMaXdwDzPKLptgXKR2hO7ONWINxoRxbiUNCYCGOGHhI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201465173255.78387606642752; Wed, 4 Feb 2026 02:37:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBY-0000x2-Pt; Wed, 04 Feb 2026 05:32:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBJ-0000bQ-3j for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBG-00041e-UU for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:20 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-49-mKbz-2BhNLueCVRPPtJQ9g-1; Wed, 04 Feb 2026 05:32:13 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ECF241800473; Wed, 4 Feb 2026 10:32:12 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 634F518003F6; Wed, 4 Feb 2026 10:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jspOalxDiHJBD00cvxzPJ6LHxGM6dr6+SEae2qJ57r4=; b=QoREvIBT2CaKGBcBnhTosX6uJWQo83PAxfyzPwKCPPnnEKrGEUJaE4wiTag6A79yMKWcZY 6ibrAkjANmG71PE2bECPU18IhjGPVUSVICMTKzXsTPvkr6ruVbu947ZqTgAvlTLxeu0ss4 h359oO2ti9exv2GfPu1T+/TfAsrmpkE= X-MC-Unique: mKbz-2BhNLueCVRPPtJQ9g-1 X-Mimecast-MFC-AGG-ID: mKbz-2BhNLueCVRPPtJQ9g_1770201133 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 15/45] tests/functional/arm/test_aspeed_ast1030: Update test ASPEED Zephyr SDK v03.05 Date: Wed, 4 Feb 2026 11:31:06 +0100 Message-ID: <20260204103136.1795455-16-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201467622154100 From: Jamin Lin Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260127032348.2238527-8-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- tests/functional/arm/test_aspeed_ast1030.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/functional/arm/test_aspeed_ast1030.py b/tests/functional= /arm/test_aspeed_ast1030.py index d1822edd8f10..0defa7c38e25 100755 --- a/tests/functional/arm/test_aspeed_ast1030.py +++ b/tests/functional/arm/test_aspeed_ast1030.py @@ -12,17 +12,17 @@ =20 class AST1030Machine(AspeedTest): =20 - ASSET_ZEPHYR_3_03 =3D Asset( + ASSET_ZEPHYR_3_05 =3D Asset( ('https://github.com/AspeedTech-BMC' - '/zephyr/releases/download/v00.03.03/ast1030-evb-demo.zip'), - '27cd73cdee6374bceb4ee58b3ace87989fa3f0684f4e612510804b588b24d4e0= ') + '/zephyr/releases/download/v00.03.05/ast1030-evb-demo.zip'), + '057528d343490b1fbb5a721e91084b4f04fec60dc114bd65e724554f9c217f4b= ') =20 - def test_arm_ast1030_zephyros_3_03(self): + def test_arm_ast1030_zephyros_3_05(self): self.set_machine('ast1030-evb') =20 kernel_name =3D "ast1030-evb-demo/zephyr.elf" kernel_file =3D self.archive_extract( - self.ASSET_ZEPHYR_3_03, member=3Dkernel_name) + self.ASSET_ZEPHYR_3_05, member=3Dkernel_name) =20 self.vm.set_console() self.vm.add_args('-kernel', kernel_file, '-nographic') @@ -72,7 +72,7 @@ def test_arm_ast1030_otp_blockdev_device(self): self.vm.set_machine("ast1030-evb") =20 kernel_name =3D "ast1030-evb-demo/zephyr.elf" - kernel_file =3D self.archive_extract(self.ASSET_ZEPHYR_3_03, + kernel_file =3D self.archive_extract(self.ASSET_ZEPHYR_3_05, member=3Dkernel_name) otp_img =3D self.generate_otpmem_image() =20 --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201543; cv=none; d=zohomail.com; s=zohoarc; b=EFtJ/ZTxuXsOjpVvCRSdLjCksGRvL1UEBYGaiJWAHtlDbcEeDHOuBdkz95fK4G07ni8HX7wA1VFLWfiOFBZae853ksmXr5VEJexY8GIjIPT641O4kgPf5Z+EhBTuMmYuwHSNo/gw7cb0GmTmrJ/ewhlJbyV+c+4thNVplmA9nbU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201543; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MmDTHq9GqQg3NC8nEsDrj9ODo/57KLqu2rbOXLXX4eE=; b=Z83JWQtS6UnzH/v3edLeaN03/HTj1zxJ6gkV2thVQQgOERJRSHXG7yCjdbATuL9e80eOATuspAf8+tvh/a6+zUaLVdVN43Pe4AnktdhZYYI8aPuN2+iMuum8dZrANzDnryUAzrIwl4bM1DCDqU6KMpX4kheg9GePWoa0aoLFCMw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201543564133.30675093329103; Wed, 4 Feb 2026 02:39:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBZ-00010f-Jk; Wed, 04 Feb 2026 05:32:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBM-0000co-L7 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBI-00041u-Pt for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:23 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-_EzSBn6BPDuUj7YpV18LAw-1; Wed, 04 Feb 2026 05:32:16 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F364D195605F; Wed, 4 Feb 2026 10:32:14 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6A52F1800666; Wed, 4 Feb 2026 10:32:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MmDTHq9GqQg3NC8nEsDrj9ODo/57KLqu2rbOXLXX4eE=; b=OLPRD+nwI+fuOG11Y8SItiV3ykD5r2O8rytqFdr+mv5QwmilM4M9mbvGWS7lCsfuAjOvuX XlctlKf8Ss2oQVVfiw0rall6JFXMQPIGfOfEQ2OEqevfD2bYl6j9dM+FwbDB/QqA82QxqF PRaiR5F77ZrtDZBt1POLrvp0Y1+8BgY= X-MC-Unique: _EzSBn6BPDuUj7YpV18LAw-1 X-Mimecast-MFC-AGG-ID: _EzSBn6BPDuUj7YpV18LAw_1770201135 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 16/45] hw/arm/aspeed_ast27x0: Fix EHCI3/4 IRQ routing to GIC Date: Wed, 4 Feb 2026 11:31:07 +0100 Message-ID: <20260204103136.1795455-17-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201545391158500 From: Jamin Lin EHCI3 and EHCI4 were missing entries in aspeed_soc_ast2700a1_irqmap, so their source IRQs were never routed through the INTC OR-gates. As a result, EHCI3/4 interrupts were not propagated to the GIC, causing incorrect interrupt behavior for these controllers. Add EHCI3 and EHCI4 to the IRQ map and route them to the same INTC group as other shared peripherals, ensuring their interrupts are properly connected to the GIC. Signed-off-by: Jamin Lin Fixes: ba27ba302a264117c8b8427f944ced1bed17c438 ("hw/arm: ast27x0: Wire up = EHCI controllers") Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260203020855.1642884-2-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast27x0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index d17f44666112..e16183c3b329 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -149,6 +149,8 @@ static const int aspeed_soc_ast2700a1_irqmap[] =3D { [ASPEED_DEV_ETH1] =3D 196, [ASPEED_DEV_ETH2] =3D 196, [ASPEED_DEV_ETH3] =3D 196, + [ASPEED_DEV_EHCI3] =3D 196, + [ASPEED_DEV_EHCI4] =3D 196, [ASPEED_DEV_PECI] =3D 197, [ASPEED_DEV_SDHCI] =3D 197, }; --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201487; cv=none; d=zohomail.com; s=zohoarc; b=T3lL06BR95gyK6B2uHqVmo1zXir6XN00ePxCooA7HWBu0xonInUznLUp4o6vqB1eJFcYnEPtiFJrmdDXINQKD5QXwGt3QlloubVcIQXD15CI2Rn7/vSzYxWq2Mga/6r80wQo9SWy2pw2iqqlQMORuiYfr+OBkwxZRou94Gmmcz4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201487; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1aIFsJq4fxjK2zsLjP9AZqyBXPKDlgKw+hKT0M8eZDA=; b=EgRYekzjE5nDVvSjm37h5hlso5nwp+SucJgYEfms6BJMozxgC9feWWLgJOxnNpIvCu2s3fDMuM7My3YfmJ7qewXtGAr0/M6G92yVr/PcXWhWivtkya1y27Kx8kJzQg8h7gQA9qZf9M6G28u/Y8VAlXBQ0U6POVt/Co48kjgHR6s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201487297290.4321049335217; Wed, 4 Feb 2026 02:38:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBa-00014Z-9G; Wed, 04 Feb 2026 05:32:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBO-0000dQ-NL for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBK-00042P-Nr for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:24 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-313-xb4JpSqiNRaSCCl60rFiyw-1; Wed, 04 Feb 2026 05:32:17 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E1CF51800266; Wed, 4 Feb 2026 10:32:16 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6FC0A18003F6; Wed, 4 Feb 2026 10:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1aIFsJq4fxjK2zsLjP9AZqyBXPKDlgKw+hKT0M8eZDA=; b=aCWYu/qmUIJaIIoaxoQebYobpp+8/W9Y7dgn/2hfVMQVnMZO4GqDRempCqZVnJcHiR+Imh iheu+OJqpYOI5QNmBr7VHfIqVhE+sQyxk+RJUVORmwfp9HaTq4n+fWJq64Vm0VbHVtZNv4 iu/NHF5ZBzF8oCxOTB2eFS/fwaApCV4= X-MC-Unique: xb4JpSqiNRaSCCl60rFiyw-1 X-Mimecast-MFC-AGG-ID: xb4JpSqiNRaSCCl60rFiyw_1770201137 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 17/45] hw/arm/aspeed_ast27x0: Sort SSP and TSP memmap tables by address Date: Wed, 4 Feb 2026 11:31:08 +0100 Message-ID: <20260204103136.1795455-18-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201490008154100 From: Jamin Lin Sort the SSP and TSP memmap tables to improve readability and make the definitions easier to maintain. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260203020855.1642884-3-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast27x0-ssp.c | 10 +++++----- hw/arm/aspeed_ast27x0-tsp.c | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/arm/aspeed_ast27x0-ssp.c b/hw/arm/aspeed_ast27x0-ssp.c index cee937b37e9b..e4bcf0fa2ae9 100644 --- a/hw/arm/aspeed_ast27x0-ssp.c +++ b/hw/arm/aspeed_ast27x0-ssp.c @@ -23,15 +23,15 @@ static const hwaddr aspeed_soc_ast27x0ssp_memmap[] =3D { [ASPEED_DEV_SRAM] =3D 0x70000000, [ASPEED_DEV_INTC] =3D 0x72100000, [ASPEED_DEV_SCU] =3D 0x72C02000, + [ASPEED_DEV_TIMER1] =3D 0x72C10000, + [ASPEED_DEV_UART4] =3D 0x72C1A000, + [ASPEED_DEV_IPC0] =3D 0x72C1C000, [ASPEED_DEV_SCUIO] =3D 0x74C02000, + [ASPEED_DEV_INTCIO] =3D 0x74C18000, [ASPEED_DEV_UART0] =3D 0x74C33000, [ASPEED_DEV_UART1] =3D 0x74C33100, [ASPEED_DEV_UART2] =3D 0x74C33200, [ASPEED_DEV_UART3] =3D 0x74C33300, - [ASPEED_DEV_UART4] =3D 0x72C1A000, - [ASPEED_DEV_INTCIO] =3D 0x74C18000, - [ASPEED_DEV_IPC0] =3D 0x72C1C000, - [ASPEED_DEV_IPC1] =3D 0x74C39000, [ASPEED_DEV_UART5] =3D 0x74C33400, [ASPEED_DEV_UART6] =3D 0x74C33500, [ASPEED_DEV_UART7] =3D 0x74C33600, @@ -40,7 +40,7 @@ static const hwaddr aspeed_soc_ast27x0ssp_memmap[] =3D { [ASPEED_DEV_UART10] =3D 0x74C33900, [ASPEED_DEV_UART11] =3D 0x74C33A00, [ASPEED_DEV_UART12] =3D 0x74C33B00, - [ASPEED_DEV_TIMER1] =3D 0x72C10000, + [ASPEED_DEV_IPC1] =3D 0x74C39000, }; =20 static const int aspeed_soc_ast27x0ssp_irqmap[] =3D { diff --git a/hw/arm/aspeed_ast27x0-tsp.c b/hw/arm/aspeed_ast27x0-tsp.c index 9c11c016ca4b..68683a15d8b6 100644 --- a/hw/arm/aspeed_ast27x0-tsp.c +++ b/hw/arm/aspeed_ast27x0-tsp.c @@ -23,15 +23,15 @@ static const hwaddr aspeed_soc_ast27x0tsp_memmap[] =3D { [ASPEED_DEV_SRAM] =3D 0x70000000, [ASPEED_DEV_INTC] =3D 0x72100000, [ASPEED_DEV_SCU] =3D 0x72C02000, + [ASPEED_DEV_TIMER1] =3D 0x72C10000, + [ASPEED_DEV_UART4] =3D 0x72C1A000, + [ASPEED_DEV_IPC0] =3D 0x72C1C000, [ASPEED_DEV_SCUIO] =3D 0x74C02000, + [ASPEED_DEV_INTCIO] =3D 0x74C18000, [ASPEED_DEV_UART0] =3D 0x74C33000, [ASPEED_DEV_UART1] =3D 0x74C33100, [ASPEED_DEV_UART2] =3D 0x74C33200, [ASPEED_DEV_UART3] =3D 0x74C33300, - [ASPEED_DEV_UART4] =3D 0x72C1A000, - [ASPEED_DEV_INTCIO] =3D 0x74C18000, - [ASPEED_DEV_IPC0] =3D 0x72C1C000, - [ASPEED_DEV_IPC1] =3D 0x74C39000, [ASPEED_DEV_UART5] =3D 0x74C33400, [ASPEED_DEV_UART6] =3D 0x74C33500, [ASPEED_DEV_UART7] =3D 0x74C33600, @@ -40,7 +40,7 @@ static const hwaddr aspeed_soc_ast27x0tsp_memmap[] =3D { [ASPEED_DEV_UART10] =3D 0x74C33900, [ASPEED_DEV_UART11] =3D 0x74C33A00, [ASPEED_DEV_UART12] =3D 0x74C33B00, - [ASPEED_DEV_TIMER1] =3D 0x72C10000, + [ASPEED_DEV_IPC1] =3D 0x74C39000, }; =20 static const int aspeed_soc_ast27x0tsp_irqmap[] =3D { --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201362; cv=none; d=zohomail.com; s=zohoarc; b=jUL53kZ6mYTvsKqHMjqMIG9DnhctTMVkbLQdoETx3dApaafZj3Bcnj7flbcq0ReX+IOlzOhUkuEKTYpbV06b2cltxaioPJKatacx/DlxZktA41xqXdeXRoO6XXeGvOwuk0Cni6v9vuGqEdpYE1b++Cmm9CY/P+5moq9c3MgNb5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201362; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Qmyp4iT0pCOzkBsWA4evBMPFT15MiEOiU8XJuxzxPl0=; b=LZBFMqYSvN6Ka/D6EegKnPdybsYH6qsCaoPv+SbGzlZUN5b193wZ+tNCB1uLWMo+ofIuozADS6Ke3jdV9gJgqkZSpG2mwAVRSrLlNhx6Eh+sy6a3zEcnrqZOiP1RPIZUwrGR5L+3rN3KrYQBn6GXboBiy9Wrw7kcaM88/jZPEf8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201362746451.11660137000865; Wed, 4 Feb 2026 02:36:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBd-0001Ir-3q; Wed, 04 Feb 2026 05:32:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBO-0000dN-LD for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBM-00042X-DY for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:25 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-314-Ezs0JVvmPzazwBcQVu843A-1; Wed, 04 Feb 2026 05:32:19 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D0B6C18005AD; Wed, 4 Feb 2026 10:32:18 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5F5F518003F6; Wed, 4 Feb 2026 10:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qmyp4iT0pCOzkBsWA4evBMPFT15MiEOiU8XJuxzxPl0=; b=P/vObjjJBWvCtXfRt/Lpve0h4uP4ru8Ay2BrLd3lxSUcB+UHKhn2lQusEfTY7dyMKXS/8z S2tY0N8KJJSFngNPS8QmeqbPiA22vGBpkneoYhSa0X6bPLFkgVxBqvaA9VkmIRIR/jFJYF 2/gc5e1bqv23D+w5xqt+n8GCWwum/sg= X-MC-Unique: Ezs0JVvmPzazwBcQVu843A-1 X-Mimecast-MFC-AGG-ID: Ezs0JVvmPzazwBcQVu843A_1770201138 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 18/45] hw/arm/aspeed_ast27x0: Sort SSP and TSP IRQ maps Date: Wed, 4 Feb 2026 11:31:09 +0100 Message-ID: <20260204103136.1795455-19-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201364639158500 From: Jamin Lin Sort the SSP and TSP IRQ map tables to improve readability and make the definitions easier to maintain. No functional change. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260203020855.1642884-4-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast27x0-ssp.c | 4 ++-- hw/arm/aspeed_ast27x0-tsp.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/arm/aspeed_ast27x0-ssp.c b/hw/arm/aspeed_ast27x0-ssp.c index e4bcf0fa2ae9..9b12ba67430f 100644 --- a/hw/arm/aspeed_ast27x0-ssp.c +++ b/hw/arm/aspeed_ast27x0-ssp.c @@ -44,12 +44,13 @@ static const hwaddr aspeed_soc_ast27x0ssp_memmap[] =3D { }; =20 static const int aspeed_soc_ast27x0ssp_irqmap[] =3D { + [ASPEED_DEV_UART4] =3D 8, [ASPEED_DEV_SCU] =3D 12, + [ASPEED_DEV_TIMER1] =3D 16, [ASPEED_DEV_UART0] =3D 164, [ASPEED_DEV_UART1] =3D 164, [ASPEED_DEV_UART2] =3D 164, [ASPEED_DEV_UART3] =3D 164, - [ASPEED_DEV_UART4] =3D 8, [ASPEED_DEV_UART5] =3D 164, [ASPEED_DEV_UART6] =3D 164, [ASPEED_DEV_UART7] =3D 164, @@ -58,7 +59,6 @@ static const int aspeed_soc_ast27x0ssp_irqmap[] =3D { [ASPEED_DEV_UART10] =3D 164, [ASPEED_DEV_UART11] =3D 164, [ASPEED_DEV_UART12] =3D 164, - [ASPEED_DEV_TIMER1] =3D 16, }; =20 /* SSPINT 164 */ diff --git a/hw/arm/aspeed_ast27x0-tsp.c b/hw/arm/aspeed_ast27x0-tsp.c index 68683a15d8b6..e39d1dc17125 100644 --- a/hw/arm/aspeed_ast27x0-tsp.c +++ b/hw/arm/aspeed_ast27x0-tsp.c @@ -44,12 +44,13 @@ static const hwaddr aspeed_soc_ast27x0tsp_memmap[] =3D { }; =20 static const int aspeed_soc_ast27x0tsp_irqmap[] =3D { + [ASPEED_DEV_UART4] =3D 8, [ASPEED_DEV_SCU] =3D 12, + [ASPEED_DEV_TIMER1] =3D 16, [ASPEED_DEV_UART0] =3D 164, [ASPEED_DEV_UART1] =3D 164, [ASPEED_DEV_UART2] =3D 164, [ASPEED_DEV_UART3] =3D 164, - [ASPEED_DEV_UART4] =3D 8, [ASPEED_DEV_UART5] =3D 164, [ASPEED_DEV_UART6] =3D 164, [ASPEED_DEV_UART7] =3D 164, @@ -58,7 +59,6 @@ static const int aspeed_soc_ast27x0tsp_irqmap[] =3D { [ASPEED_DEV_UART10] =3D 164, [ASPEED_DEV_UART11] =3D 164, [ASPEED_DEV_UART12] =3D 164, - [ASPEED_DEV_TIMER1] =3D 16, }; =20 /* TSPINT 164 */ --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201187; cv=none; d=zohomail.com; s=zohoarc; b=fSOj82bkixH+COWU5HHCwQGFeqdF9dlHsPKoixBOJOMseFzEkcR6TtJw1M2oxHYwvB4FHQvK2qOOlbP2JTeqLJobJio8xZ5jjxKQS1LjzFT+aJm/D/zTZVyHnx2CqlJcv20Perz+lmwYFQtQc2bREg2Z39kGPKE1JX9rzZWgVM8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201187; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=T8BstmiXHQbQlavVtyxSpLEYyJ21WBOokbrFV3V6bRI=; b=HqEdWn4QslBA3KySRtyA3ZXMH3pSdcDHUyBcPQPSIlhhtRSkvYl02PIRQbSj8Fnn+6PcM+yukL8RWNQ7a0ne0LLGrXtfhLwiXy3ozeTUyEB9G8MTHn3geYVDZ9Bm2gQ6h2WdmRwCWChQ5G/WnFj5XPJsL3bGxdXGZzF/0DGkUf8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201187585777.1897561811811; Wed, 4 Feb 2026 02:33:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBb-0001An-6q; Wed, 04 Feb 2026 05:32:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBP-0000du-W7 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBM-00042b-Ft for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:26 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-523-RJB5i6dmOraIYa_45ZDfVg-1; Wed, 04 Feb 2026 05:32:21 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C1C4A195608D; Wed, 4 Feb 2026 10:32:20 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4F68918004AD; Wed, 4 Feb 2026 10:32:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T8BstmiXHQbQlavVtyxSpLEYyJ21WBOokbrFV3V6bRI=; b=JvWj+yDbz8Zax7tVUla8a4OZ3HJcTqlC5RBOuDXrXo1V1LQgq1/pO0hDTKnrbx7Uh5+bDg 77DUrWx8flnOtXLN3QNPj+1BTqXg54dl4zbqIv7nXfR++Gh5Cu+6VievW35GPbkTo8qqjR Kc5X+88ek4L+EJk8a/Fcp6nV5KdVJDY= X-MC-Unique: RJB5i6dmOraIYa_45ZDfVg-1 X-Mimecast-MFC-AGG-ID: RJB5i6dmOraIYa_45ZDfVg_1770201140 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 19/45] hw/i2c/aspeed_i2c: Fix DMA moving data into incorrect address Date: Wed, 4 Feb 2026 11:31:10 +0100 Message-ID: <20260204103136.1795455-20-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201189807154100 From: Jamin Lin In the previous design, the I2C model updated dma_dram_offset only when firmware programmed the RX/TX DMA buffer address registers. The firmware used to rewrite these registers before issuing each DMA command. The firmware driver behavior has changed to program the DMA address registers only once during I2C initialization. As a result, the I2C model no longer refreshes dma_dram_offset, causing DMA to move data into an incorrect DRAM address. Fix this by introducing helper functions to update dma_dram_offset from the DMA address registers, and invoke them right before handling TX/RX DMA operations. This guarantees DMA always uses the correct buffer address even if the registers are programmed only once. Signed-off-by: Jamin Lin Fixes: c400c38854017eeccda63115814eba4c3ef2b51f ("hw/i2c/aspeed: Introduce = a new dma_dram_offset attribute in AspeedI2Cbus") Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260203020855.1642884-5-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- hw/i2c/aspeed_i2c.c | 87 +++++++++++++++++++++++++++++++-------------- 1 file changed, 61 insertions(+), 26 deletions(-) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index 1ee73a8f5e78..fb3d6a560018 100644 --- a/hw/i2c/aspeed_i2c.c +++ b/hw/i2c/aspeed_i2c.c @@ -116,8 +116,6 @@ static uint64_t aspeed_i2c_bus_old_read(AspeedI2CBus *b= us, hwaddr offset, value =3D -1; break; } - - value =3D extract64(bus->dma_dram_offset, 0, 32); break; case A_I2CD_DMA_LEN: if (!aic->has_dma) { @@ -221,6 +219,64 @@ static uint8_t aspeed_i2c_get_state(AspeedI2CBus *bus) return SHARED_ARRAY_FIELD_EX32(bus->regs, R_I2CD_CMD, TX_STATE); } =20 +/* + * The AST2700 support the maximum DRAM size is 8 GB. + * The DRAM offset range is from 0x0_0000_0000 to + * 0x1_FFFF_FFFF and it is enough to use bits [33:0] + * saving the dram offset. + * Therefore, save the high part physical address bit[1:0] + * of Tx/Rx buffer address as dma_dram_offset bit[33:32]. + */ +static void aspeed_i2c_set_tx_dma_dram_offset(AspeedI2CBus *bus) +{ + AspeedI2CClass *aic =3D ASPEED_I2C_GET_CLASS(bus->controller); + uint32_t value; + + assert(aic->has_dma); + + if (aspeed_i2c_is_new_mode(bus->controller)) { + value =3D bus->regs[R_I2CM_DMA_TX_ADDR]; + bus->dma_dram_offset =3D + deposit64(bus->dma_dram_offset, 0, 32, + FIELD_EX32(value, I2CM_DMA_TX_ADDR, ADDR)); + if (!aic->has_dma64) { + value =3D bus->regs[R_I2CM_DMA_TX_ADDR_HI]; + bus->dma_dram_offset =3D + deposit64(bus->dma_dram_offset, 32, 32, + extract32(value, 0, 2)); + } + } else { + value =3D bus->regs[R_I2CD_DMA_ADDR]; + bus->dma_dram_offset =3D deposit64(bus->dma_dram_offset, 0, 32, + value & 0x3ffffffc); + } +} + +static void aspeed_i2c_set_rx_dma_dram_offset(AspeedI2CBus *bus) +{ + AspeedI2CClass *aic =3D ASPEED_I2C_GET_CLASS(bus->controller); + uint32_t value; + + assert(aic->has_dma); + + if (aspeed_i2c_is_new_mode(bus->controller)) { + value =3D bus->regs[R_I2CM_DMA_RX_ADDR]; + bus->dma_dram_offset =3D + deposit64(bus->dma_dram_offset, 0, 32, + FIELD_EX32(value, I2CM_DMA_RX_ADDR, ADDR)); + if (!aic->has_dma64) { + value =3D bus->regs[R_I2CM_DMA_RX_ADDR_HI]; + bus->dma_dram_offset =3D + deposit64(bus->dma_dram_offset, 32, 32, + extract32(value, 0, 2)); + } + } else { + value =3D bus->regs[R_I2CD_DMA_ADDR]; + bus->dma_dram_offset =3D deposit64(bus->dma_dram_offset, 0, 32, + value & 0x3ffffffc); + } +} + static int aspeed_i2c_dma_read(AspeedI2CBus *bus, uint8_t *data) { MemTxResult result; @@ -270,6 +326,7 @@ static int aspeed_i2c_bus_send(AspeedI2CBus *bus) if (aspeed_i2c_is_new_mode(bus->controller)) { ARRAY_FIELD_DP32(bus->regs, I2CM_DMA_LEN_STS, TX_LEN, 0); } + aspeed_i2c_set_tx_dma_dram_offset(bus); while (bus->regs[reg_dma_len]) { uint8_t data; ret =3D aspeed_i2c_dma_read(bus, &data); @@ -335,6 +392,7 @@ static void aspeed_i2c_bus_recv(AspeedI2CBus *bus) ARRAY_FIELD_DP32(bus->regs, I2CM_DMA_LEN_STS, RX_LEN, 0); } =20 + aspeed_i2c_set_rx_dma_dram_offset(bus); while (bus->regs[reg_dma_len]) { MemTxResult result; =20 @@ -401,6 +459,7 @@ static uint8_t aspeed_i2c_get_addr(AspeedI2CBus *bus) } else if (SHARED_ARRAY_FIELD_EX32(bus->regs, reg_cmd, TX_DMA_EN)) { uint8_t data; =20 + aspeed_i2c_set_tx_dma_dram_offset(bus); aspeed_i2c_dma_read(bus, &data); return data; } else { @@ -657,16 +716,10 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bu= s, hwaddr offset, case A_I2CM_DMA_TX_ADDR: bus->regs[R_I2CM_DMA_TX_ADDR] =3D FIELD_EX32(value, I2CM_DMA_TX_AD= DR, ADDR); - bus->dma_dram_offset =3D - deposit64(bus->dma_dram_offset, 0, 32, - FIELD_EX32(value, I2CM_DMA_TX_ADDR, ADDR)); break; case A_I2CM_DMA_RX_ADDR: bus->regs[R_I2CM_DMA_RX_ADDR] =3D FIELD_EX32(value, I2CM_DMA_RX_AD= DR, ADDR); - bus->dma_dram_offset =3D - deposit64(bus->dma_dram_offset, 0, 32, - FIELD_EX32(value, I2CM_DMA_RX_ADDR, ADDR)); break; case A_I2CM_DMA_LEN: w1t =3D FIELD_EX32(value, I2CM_DMA_LEN, RX_BUF_LEN_W1T) || @@ -748,15 +801,6 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus= , hwaddr offset, qemu_log_mask(LOG_UNIMP, "%s: Slave mode DMA TX is not implemented= \n", __func__); break; - - /* - * The AST2700 support the maximum DRAM size is 8 GB. - * The DRAM offset range is from 0x0_0000_0000 to - * 0x1_FFFF_FFFF and it is enough to use bits [33:0] - * saving the dram offset. - * Therefore, save the high part physical address bit[1:0] - * of Tx/Rx buffer address as dma_dram_offset bit[33:32]. - */ case A_I2CM_DMA_TX_ADDR_HI: if (!aic->has_dma64) { qemu_log_mask(LOG_GUEST_ERROR, "%s: No DMA 64 bits support\n", @@ -766,8 +810,6 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus,= hwaddr offset, bus->regs[R_I2CM_DMA_TX_ADDR_HI] =3D FIELD_EX32(value, I2CM_DMA_TX_ADDR_HI, ADDR_HI); - bus->dma_dram_offset =3D deposit64(bus->dma_dram_offset, 32, 32, - extract32(value, 0, 2)); break; case A_I2CM_DMA_RX_ADDR_HI: if (!aic->has_dma64) { @@ -778,8 +820,6 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus,= hwaddr offset, bus->regs[R_I2CM_DMA_RX_ADDR_HI] =3D FIELD_EX32(value, I2CM_DMA_RX_ADDR_HI, ADDR_HI); - bus->dma_dram_offset =3D deposit64(bus->dma_dram_offset, 32, 32, - extract32(value, 0, 2)); break; case A_I2CS_DMA_TX_ADDR_HI: qemu_log_mask(LOG_UNIMP, @@ -795,8 +835,6 @@ static void aspeed_i2c_bus_new_write(AspeedI2CBus *bus,= hwaddr offset, bus->regs[R_I2CS_DMA_RX_ADDR_HI] =3D FIELD_EX32(value, I2CS_DMA_RX_ADDR_HI, ADDR_HI); - bus->dma_dram_offset =3D deposit64(bus->dma_dram_offset, 32, 32, - extract32(value, 0, 2)); break; default: qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad offset 0x%" HWADDR_PRIx "\= n", @@ -887,9 +925,6 @@ static void aspeed_i2c_bus_old_write(AspeedI2CBus *bus,= hwaddr offset, qemu_log_mask(LOG_GUEST_ERROR, "%s: No DMA support\n", __func= __); break; } - - bus->dma_dram_offset =3D deposit64(bus->dma_dram_offset, 0, 32, - value & 0x3ffffffc); break; =20 case A_I2CD_DMA_LEN: --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201469; cv=none; d=zohomail.com; s=zohoarc; b=HuxiDwNXTaT9qZMVJ9UI1dsd91NV17cXTzuRv01/pQD2Plr6GaZV0kJHzaRI3qW13l8mkWvhZ0IyhM7bwRlj/hRsFKLQLFQ4NQvupdZv+hVjcTBIv1ZcfcrkAsyTDvVD1PpWf8VYvlFG7dBpC0ExKrLQPO5dbfXqDtuUxBBi51w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201469; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=f+v+b3II5Y8nhsN1LqDSRrfyCnxXbW3wCaEj5O6zlLc=; b=Fb26f//NJOwrMC9qCQYT06FSWuC67JtGYbJvKWbKd19z8SHkWKunYU7kU1WxwoHbtcd3QILg+3HaP1jsHqrtGxpTMcfZdUdv2ee4zdlXkmVZiEF8mENGmvT30Ejlb9uyy5FgbTxGvvUz8DcYBpPUHXPwbJwihJXg6ctq4MFlhvc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201469769497.53129269552903; Wed, 4 Feb 2026 02:37:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBY-0000tT-3r; Wed, 04 Feb 2026 05:32:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBR-0000fM-UO for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBP-00043S-Pw for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:29 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-2sq3Jd8yOAmhU4HfJiO87Q-1; Wed, 04 Feb 2026 05:32:23 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B130118005AD; Wed, 4 Feb 2026 10:32:22 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3F3C918004AD; Wed, 4 Feb 2026 10:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f+v+b3II5Y8nhsN1LqDSRrfyCnxXbW3wCaEj5O6zlLc=; b=O7SwbsICj2Q4NnlUhpNx9/yjCxzZ1ec6Smyj3WAapl/Pk11z7fdDqbudas18RFYeGTItWl vPOSz3pof4mfxKU76WM6YmKYDzscZgjvnB9uOx3X0glJA99V7QkzOU8s5QMCaFjOIjNhAb 8eoWjxKJiyrS+x2Uqvjw7R9Ir9T55pw= X-MC-Unique: 2sq3Jd8yOAmhU4HfJiO87Q-1 X-Mimecast-MFC-AGG-ID: 2sq3Jd8yOAmhU4HfJiO87Q_1770201142 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 20/45] tests/functional/aarch64/test_aspeed_ast2700: Enable PCIe2 DTS status for AST2700 tests Date: Wed, 4 Feb 2026 11:31:11 +0100 Message-ID: <20260204103136.1795455-21-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201471722154100 From: Jamin Lin PCIe2 is disabled by default starting from SDK v10.00. Add a helper function to stop U-Boot autoboot and update the device tree at runtime, setting the PCIe2 node status to "okay" before booting Linux. This allows the AST2700 functional test to verify the PCIe2 root complex behavior correctly. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260203020855.1642884-6-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- .../functional/aarch64/test_aspeed_ast2700.py | 18 ++++++++++++++++-- .../aarch64/test_aspeed_ast2700fc.py | 18 ++++++++++++++++-- 2 files changed, 32 insertions(+), 4 deletions(-) diff --git a/tests/functional/aarch64/test_aspeed_ast2700.py b/tests/functi= onal/aarch64/test_aspeed_ast2700.py index 0ced1a25021d..1f1b5749f4a0 100755 --- a/tests/functional/aarch64/test_aspeed_ast2700.py +++ b/tests/functional/aarch64/test_aspeed_ast2700.py @@ -9,7 +9,7 @@ import os =20 from qemu_test import QemuSystemTest, Asset -from qemu_test import wait_for_console_pattern +from qemu_test import wait_for_console_pattern, exec_command from qemu_test import exec_command_and_wait_for_pattern =20 =20 @@ -37,9 +37,23 @@ def verify_vbootrom_firmware_flow(self): wait_for_console_pattern(self, 'done') wait_for_console_pattern(self, 'Jumping to BL31 (Trusted Firmware-= A)') =20 + def enable_ast2700_pcie2(self): + wait_for_console_pattern(self, 'Hit any key to stop autoboot') + exec_command_and_wait_for_pattern(self, '\012', '=3D>') + exec_command_and_wait_for_pattern(self, + 'cp 100420000 403000000 900000', '=3D>') + exec_command_and_wait_for_pattern(self, + 'bootm start 403000000', '=3D>') + exec_command_and_wait_for_pattern(self, 'bootm loados', '=3D>') + exec_command_and_wait_for_pattern(self, 'bootm ramdisk', '=3D>') + exec_command_and_wait_for_pattern(self, 'bootm prep', '=3D>') + exec_command_and_wait_for_pattern(self, + 'fdt set /soc@14000000/pcie@140d0000 status "okay"', '=3D>') + exec_command(self, 'bootm go') + def verify_openbmc_boot_start(self): wait_for_console_pattern(self, 'U-Boot 2023.10') - wait_for_console_pattern(self, '## Loading kernel from FIT Image') + self.enable_ast2700_pcie2() wait_for_console_pattern(self, 'Linux version ') =20 def verify_openbmc_boot_and_login(self, name): diff --git a/tests/functional/aarch64/test_aspeed_ast2700fc.py b/tests/func= tional/aarch64/test_aspeed_ast2700fc.py index 8dbc8f234f9c..a1d8046f58e6 100755 --- a/tests/functional/aarch64/test_aspeed_ast2700fc.py +++ b/tests/functional/aarch64/test_aspeed_ast2700fc.py @@ -9,7 +9,7 @@ import os =20 from qemu_test import QemuSystemTest, Asset -from qemu_test import wait_for_console_pattern +from qemu_test import wait_for_console_pattern, exec_command from qemu_test import exec_command_and_wait_for_pattern =20 =20 @@ -27,9 +27,23 @@ def do_test_aarch64_aspeed_sdk_start(self, image): =20 self.vm.launch() =20 + def enable_ast2700_pcie2(self): + wait_for_console_pattern(self, 'Hit any key to stop autoboot') + exec_command_and_wait_for_pattern(self, '\012', '=3D>') + exec_command_and_wait_for_pattern(self, + 'cp 100420000 403000000 900000', '=3D>') + exec_command_and_wait_for_pattern(self, + 'bootm start 403000000', '=3D>') + exec_command_and_wait_for_pattern(self, 'bootm loados', '=3D>') + exec_command_and_wait_for_pattern(self, 'bootm ramdisk', '=3D>') + exec_command_and_wait_for_pattern(self, 'bootm prep', '=3D>') + exec_command_and_wait_for_pattern(self, + 'fdt set /soc@14000000/pcie@140d0000 status "okay"', '=3D>') + exec_command(self, 'bootm go') + def verify_openbmc_boot_and_login(self, name): wait_for_console_pattern(self, 'U-Boot 2023.10') - wait_for_console_pattern(self, '## Loading kernel from FIT Image') + self.enable_ast2700_pcie2() wait_for_console_pattern(self, 'Starting kernel ...') =20 wait_for_console_pattern(self, f'{name} login:') --=20 2.52.0 From nobody Sat Feb 7 05:49:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201188; cv=none; d=zohomail.com; s=zohoarc; b=KvkDlKEMk11ol62vF0xYwI9OsJWRypRE9WLTohUMhIhl+Yz/tPDhIG0q/V8nQdIwUqpewj5+whH2XyHiEehwIxVNLTI5kESpbkeKvGDKr+alXpiuho+wuksKd9nFIv2BjRzHzAHu5tLMkYOwhRr41XoBgx4iiFUFUHOu+LNnYHA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201188; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vbeGJUD/FPOPHW2asDqxfTZ8BJkrGhDFAcGbiy6EOg8=; b=LDNg8fJwu2z7sBjNT+6HfNYtyE/bXi/+E5MU6xHyHaELsIpHp5ejmbMsxq0f0DI/niWg+duVZr9HU6v6oUWB35vTwAbuDjATZiZqMW70m6hGXJSrmgTIN/57UIqsad4jwtWpjInOlZ/jAONwNNsCrUxrzvsKve7Hg4KSMdLNiDI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201188368409.7902991151283; Wed, 4 Feb 2026 02:33:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBe-0001Ln-8r; Wed, 04 Feb 2026 05:32:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBS-0000fg-JG for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBP-00043W-Q0 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:29 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-SPYolAm_M7ueRQagmTmNCA-1; Wed, 04 Feb 2026 05:32:25 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A02B7195605A; Wed, 4 Feb 2026 10:32:24 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2E68018004BB; Wed, 4 Feb 2026 10:32:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vbeGJUD/FPOPHW2asDqxfTZ8BJkrGhDFAcGbiy6EOg8=; b=h4/VDcQl0jLrm82hfkkijb0HyPXLnZ5wggo+0V6nk5lygIw9rHf8NNDtFSngG0fz86wEcS xn3DrwvNBQ8d1Bpp4etnLBP39EPKSR2STqS/oJMDJAb/qNw0Wu9Ae6dY+l8tU0FvYLztWR JHIluueycGPALiA31xpdyk7TumEcTK0= X-MC-Unique: SPYolAm_M7ueRQagmTmNCA-1 X-Mimecast-MFC-AGG-ID: SPYolAm_M7ueRQagmTmNCA_1770201144 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 21/45] tests/functional/aarch64/test_aspeed_ast2700: Update test ASPEED SDK v11.00 for A1 Date: Wed, 4 Feb 2026 11:31:12 +0100 Message-ID: <20260204103136.1795455-22-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201189920158500 From: Jamin Lin Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260203020855.1642884-7-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- .../functional/aarch64/test_aspeed_ast2700.py | 60 +++++++++---------- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/tests/functional/aarch64/test_aspeed_ast2700.py b/tests/functi= onal/aarch64/test_aspeed_ast2700.py index 1f1b5749f4a0..828ea1ca53df 100755 --- a/tests/functional/aarch64/test_aspeed_ast2700.py +++ b/tests/functional/aarch64/test_aspeed_ast2700.py @@ -26,15 +26,23 @@ def do_test_aarch64_aspeed_sdk_start(self, image): self.vm.launch() =20 def verify_vbootrom_firmware_flow(self): - wait_for_console_pattern(self, 'Found valid FIT image') - wait_for_console_pattern(self, '[uboot] loading') - wait_for_console_pattern(self, 'done') - wait_for_console_pattern(self, '[fdt] loading') - wait_for_console_pattern(self, 'done') - wait_for_console_pattern(self, '[tee] loading') - wait_for_console_pattern(self, 'done') - wait_for_console_pattern(self, '[atf] loading') - wait_for_console_pattern(self, 'done') + wait_for_console_pattern(self, 'Found valid caliptra flash image') + wait_for_console_pattern(self, 'Check flash image checksum') + wait_for_console_pattern(self, 'pass') + wait_for_console_pattern(self, 'Read abb header') + wait_for_console_pattern(self, 'pass') + wait_for_console_pattern(self, 'Read soc manifest') + wait_for_console_pattern(self, 'pass') + wait_for_console_pattern(self, 'Load atf image') + wait_for_console_pattern(self, 'pass') + wait_for_console_pattern(self, 'Load optee image') + wait_for_console_pattern(self, 'pass') + wait_for_console_pattern(self, 'Load uboot image') + wait_for_console_pattern(self, 'pass') + wait_for_console_pattern(self, 'Load ssp image') + wait_for_console_pattern(self, 'pass') + wait_for_console_pattern(self, 'Load tsp image') + wait_for_console_pattern(self, 'pass') wait_for_console_pattern(self, 'Jumping to BL31 (Trusted Firmware-= A)') =20 def enable_ast2700_pcie2(self): @@ -63,9 +71,9 @@ def verify_openbmc_boot_and_login(self, name): exec_command_and_wait_for_pattern(self, 'root', 'Password:') exec_command_and_wait_for_pattern(self, '0penBmc', f'root@{name}:~= #') =20 - ASSET_SDK_V908_AST2700A1 =3D Asset( - 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v= 09.08/ast2700-default-obmc.tar.gz', - 'eac3dc409b7ea3cd4b03d4792d3cebd469792ad893cb51e1d15f0fc20bd1e= 2cd') + ASSET_SDK_V1100_AST2700A1 =3D Asset( + 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v= 11.00/ast2700-a1-obmc.tar.gz', + 'd5ceed511cd0dfefbb102fff2d731159e0472948a28066dc0d90bcd54be76= 525') =20 def do_ast2700_i2c_test(self): exec_command_and_wait_for_pattern(self, @@ -93,19 +101,10 @@ def do_ast2700_pcie_test(self): =20 def start_ast2700_test(self, name): num_cpu =3D 4 - uboot_size =3D os.path.getsize(self.scratch_file(name, - 'u-boot-nodtb.bin')) - uboot_dtb_load_addr =3D hex(0x400000000 + uboot_size) - load_images_list =3D [ { 'addr': '0x400000000', - 'file': self.scratch_file(name, - 'u-boot-nodtb.bin') - }, - { - 'addr': str(uboot_dtb_load_addr), - 'file': self.scratch_file(name, 'u-boot.dtb') + 'file': self.scratch_file(name, 'u-boot.bin') }, { 'addr': '0x430000000', @@ -113,8 +112,7 @@ def start_ast2700_test(self, name): }, { 'addr': '0x430080000', - 'file': self.scratch_file(name, 'optee', - 'tee-raw.bin') + 'file': self.scratch_file(name, 'optee', 'tee-raw.bin') } ] =20 @@ -137,26 +135,26 @@ def start_ast2700_test_vbootrom(self, name): self.do_test_aarch64_aspeed_sdk_start( self.scratch_file(name, 'image-bmc')) =20 - def test_aarch64_ast2700a1_evb_sdk_v09_08(self): + def test_aarch64_ast2700a1_evb_sdk_v11_00(self): self.set_machine('ast2700a1-evb') self.require_netdev('user') =20 - self.archive_extract(self.ASSET_SDK_V908_AST2700A1) + self.archive_extract(self.ASSET_SDK_V1100_AST2700A1) self.vm.add_args('-device', 'e1000e,netdev=3Dnet1,bus=3Dpcie.2') self.vm.add_args('-netdev', 'user,id=3Dnet1') - self.start_ast2700_test('ast2700-default') - self.verify_openbmc_boot_and_login('ast2700-default') + self.start_ast2700_test('ast2700-a1') + self.verify_openbmc_boot_and_login('ast2700-a1') self.do_ast2700_i2c_test() self.do_ast2700_pcie_test() =20 - def test_aarch64_ast2700a1_evb_sdk_vbootrom_v09_08(self): + def test_aarch64_ast2700a1_evb_sdk_vbootrom_v11_00(self): self.set_machine('ast2700a1-evb') self.require_netdev('user') =20 - self.archive_extract(self.ASSET_SDK_V908_AST2700A1) + self.archive_extract(self.ASSET_SDK_V1100_AST2700A1) self.vm.add_args('-device', 'e1000e,netdev=3Dnet1,bus=3Dpcie.2') self.vm.add_args('-netdev', 'user,id=3Dnet1') - self.start_ast2700_test_vbootrom('ast2700-default') + self.start_ast2700_test_vbootrom('ast2700-a1') self.verify_vbootrom_firmware_flow() self.verify_openbmc_boot_start() =20 --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201357; cv=none; d=zohomail.com; s=zohoarc; b=jdiV2AowC+ZLwiu5tnB4wMCD8aJDyjislyDbNnatEDnZ6q/rIIwRRNOb1xW/A5FCrJUlrek5NjWYgGZJq2UFtYi71hgEJq93Pt/Th77+L8suByPE/xKHwJ93aIxHSzu0u/Hc/i7plWZo/Dj9/tRTfFRc95X3lSY/bZKb74ZQf0M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201357; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=APl5obzIM65XG4dJG4xhzOqCAx+fYtuuzxyfsimqC9c=; b=jKi4dy5ZwTwuQ09dPcseRS8Q1PE7wkS6DwgGDGYU6g5VqtfsUwV1DdRhnzcaWsvKFmoebzTMq/w0RI12Rsi6WneMz2ZoCIPLQhouZtL8ILKb2BFx98GGcqdG6O/k9d5QTJ7alPGYruWC4PAV7BGHsjJd5hJigtzJEvvkqbisSoM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201357331946.4227463961058; Wed, 4 Feb 2026 02:35:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBf-0001Tv-Hw; Wed, 04 Feb 2026 05:32:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBY-0000ux-7Z for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBW-00045H-J7 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:35 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-248-GkyOuYA7P5aBpqYqaWYknQ-1; Wed, 04 Feb 2026 05:32:27 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8FDEE195606B; Wed, 4 Feb 2026 10:32:26 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1D7C318004AD; Wed, 4 Feb 2026 10:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=APl5obzIM65XG4dJG4xhzOqCAx+fYtuuzxyfsimqC9c=; b=MrMY/LG9MW9k4+fJGSoDbD9zzDUbM5TW1p0Y1Pdnda+TWyuOWtkCAFmaIsilGW0VMIuA6E oXPXmDdyMa2Cvb5oBEBA+Iur2By7SGU5p+XTEPLDUUEBd+LX1bx69rxbnOOlGSkgncbf0g Blk7nGytA4HrpRn/egaDYiTCj3TJUBM= X-MC-Unique: GkyOuYA7P5aBpqYqaWYknQ-1 X-Mimecast-MFC-AGG-ID: GkyOuYA7P5aBpqYqaWYknQ_1770201146 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 22/45] tests/functional/aarch64/test_aspeed_ast2700fc: Update test ASPEED SDK v11.00 for A1 Date: Wed, 4 Feb 2026 11:31:13 +0100 Message-ID: <20260204103136.1795455-23-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201360298154100 From: Jamin Lin Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260203020855.1642884-8-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- .../aarch64/test_aspeed_ast2700fc.py | 36 +++++++------------ 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/tests/functional/aarch64/test_aspeed_ast2700fc.py b/tests/func= tional/aarch64/test_aspeed_ast2700fc.py index a1d8046f58e6..47e56dcfc50c 100755 --- a/tests/functional/aarch64/test_aspeed_ast2700fc.py +++ b/tests/functional/aarch64/test_aspeed_ast2700fc.py @@ -61,9 +61,9 @@ def load_ast2700fc_coprocessor(self, name): self.vm.add_args('-device', f'loader,file=3D{file},cpu-num=3D{cpu_num}') =20 - ASSET_SDK_V908_AST2700 =3D Asset( - 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v= 09.08/ast2700-default-obmc.tar.gz', - 'eac3dc409b7ea3cd4b03d4792d3cebd469792ad893cb51e1d15f0fc20bd1e= 2cd') + ASSET_SDK_V1100_AST2700 =3D Asset( + 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v= 11.00/ast2700-a1-obmc.tar.gz', + 'd5ceed511cd0dfefbb102fff2d731159e0472948a28066dc0d90bcd54be76= 525') =20 def do_ast2700_i2c_test(self): exec_command_and_wait_for_pattern(self, @@ -113,19 +113,10 @@ def do_ast2700fc_tsp_test(self): =20 def start_ast2700fc_test(self, name): ca35_core =3D 4 - uboot_size =3D os.path.getsize(self.scratch_file(name, - 'u-boot-nodtb.bin')) - uboot_dtb_load_addr =3D hex(0x400000000 + uboot_size) - load_images_list =3D [ { 'addr': '0x400000000', - 'file': self.scratch_file(name, - 'u-boot-nodtb.bin') - }, - { - 'addr': str(uboot_dtb_load_addr), - 'file': self.scratch_file(name, 'u-boot.dtb') + 'file': self.scratch_file(name, 'u-boot.bin') }, { 'addr': '0x430000000', @@ -133,8 +124,7 @@ def start_ast2700fc_test(self, name): }, { 'addr': '0x430080000', - 'file': self.scratch_file(name, 'optee', - 'tee-raw.bin') + 'file': self.scratch_file(name, 'optee', 'tee-raw.bin') } ] =20 @@ -158,24 +148,24 @@ def start_ast2700fc_test_vbootrom(self, name): self.do_test_aarch64_aspeed_sdk_start( self.scratch_file(name, 'image-bmc')) =20 - def test_aarch64_ast2700fc_sdk_v09_08(self): + def test_aarch64_ast2700fc_sdk_v11_00(self): self.set_machine('ast2700fc') self.require_netdev('user') =20 - self.archive_extract(self.ASSET_SDK_V908_AST2700) - self.start_ast2700fc_test('ast2700-default') - self.verify_openbmc_boot_and_login('ast2700-default') + self.archive_extract(self.ASSET_SDK_V1100_AST2700) + self.start_ast2700fc_test('ast2700-a1') + self.verify_openbmc_boot_and_login('ast2700-a1') self.do_ast2700_i2c_test() self.do_ast2700_pcie_test() self.do_ast2700fc_ssp_test() self.do_ast2700fc_tsp_test() =20 - def test_aarch64_ast2700fc_sdk_vbootrom_v09_08(self): + def test_aarch64_ast2700fc_sdk_vbootrom_v11_00(self): self.set_machine('ast2700fc') =20 - self.archive_extract(self.ASSET_SDK_V908_AST2700) - self.start_ast2700fc_test_vbootrom('ast2700-default') - self.verify_openbmc_boot_and_login('ast2700-default') + self.archive_extract(self.ASSET_SDK_V1100_AST2700) + self.start_ast2700fc_test_vbootrom('ast2700-a1') + self.verify_openbmc_boot_and_login('ast2700-a1') self.do_ast2700fc_ssp_test() self.do_ast2700fc_tsp_test() =20 --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201448; cv=none; d=zohomail.com; s=zohoarc; b=kUT1R1gkqGF9ogbrbEBpgrwyGfX9RS1Pd2waNT15I6B3IX5qCQOWJEPFDqHcVQhi36al2o14a6+B/gF9f86U9hRiw6rIQ2wsEIu6fIBzubyf1t4v71PVc6VPchQcme+JFljanexILQ934Fu2Za67wYZpLVhr/7/LFKY7bi/V3x8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201448; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=69RKBa6O0jc+vw18PPmUNrPxdE3iOm75pBiuL3uwTeo=; b=QmPJBUffPQ4CD92hBcz1GjErQReI0+l+kgF0gbM8uzZH4/I5IKJyfVzKzdYPtDJjK8tfV9Ps/eEzVJHhOvS1AW2pzCkVwXkNR9EqMFjo03G9C/bfAtppJIMUM3aYFbCW/ih3MF9tPhlbRIdvfPSwnkEv+Nwpo2bP1VfwK+akI/4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201448566493.6984670755263; Wed, 4 Feb 2026 02:37:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBa-00014U-7S; Wed, 04 Feb 2026 05:32:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBX-0000nj-85 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBV-000452-De for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:35 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-Z3Rt2kgKNmiH47atod62rA-1; Wed, 04 Feb 2026 05:32:29 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7C06E1800464; Wed, 4 Feb 2026 10:32:28 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0BBDD18003F6; Wed, 4 Feb 2026 10:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=69RKBa6O0jc+vw18PPmUNrPxdE3iOm75pBiuL3uwTeo=; b=L8cS7wj/lgWb9x4mADg+zIZFG+XZGRBQfWPWvnDRTcmvsGWUewf47cci8vNk4ADfwZ0Vtp DcqzqxIor3l9O4++S3LyqoWTzmTnmizKw3O/S/2th2tXVisVg5CvRCYoP1yEZtZXCTZ/E8 NwlwVBRCkR8jKyqurSTFHUewqomdXoI= X-MC-Unique: Z3Rt2kgKNmiH47atod62rA-1 X-Mimecast-MFC-AGG-ID: Z3Rt2kgKNmiH47atod62rA_1770201148 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Jamin Lin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 23/45] docs/system/arm/aspeed: Load raw U-Boot image in AST2700 boot example Date: Wed, 4 Feb 2026 11:31:14 +0100 Message-ID: <20260204103136.1795455-24-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201449428154100 From: Jamin Lin Recent SDK versions no longer provide a U-Boot FIT image, and U-Boot is now built as a single raw binary. Update the documentation to load the raw u-boot.bin image directly. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260203020855.1642884-9-jamin_lin= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- docs/system/arm/aspeed.rst | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/docs/system/arm/aspeed.rst b/docs/system/arm/aspeed.rst index 97e14b7d338f..d0054a7dbb88 100644 --- a/docs/system/arm/aspeed.rst +++ b/docs/system/arm/aspeed.rst @@ -350,11 +350,9 @@ corresponds to the BL31 image load address. .. code-block:: bash =20 IMGDIR=3Dast2700-default - UBOOT_SIZE=3D$(stat --format=3D%s -L ${IMGDIR}/u-boot-nodtb.bin) =20 $ qemu-system-aarch64 -M ast2700-evb \ - -device loader,force-raw=3Don,addr=3D0x400000000,file=3D${IMGDIR}/u= -boot-nodtb.bin \ - -device loader,force-raw=3Don,addr=3D$((0x400000000 + ${UBOOT_SIZE}= )),file=3D${IMGDIR}/u-boot.dtb \ + -device loader,force-raw=3Don,addr=3D0x400000000,file=3D${IMGDIR}/u= -boot.bin \ -device loader,force-raw=3Don,addr=3D0x430000000,file=3D${IMGDIR}/b= l31.bin \ -device loader,force-raw=3Don,addr=3D0x430080000,file=3D${IMGDIR}/o= ptee/tee-raw.bin \ -device loader,cpu-num=3D0,addr=3D0x430000000 \ @@ -409,11 +407,9 @@ Steps to boot the AST2700fc machine: .. code-block:: bash =20 IMGDIR=3Dast2700-default - UBOOT_SIZE=3D$(stat --format=3D%s -L ${IMGDIR}/u-boot-nodtb.bin) =20 $ qemu-system-aarch64 -M ast2700fc \ - -device loader,force-raw=3Don,addr=3D0x400000000,file=3D${IMGDIR}/u= -boot-nodtb.bin \ - -device loader,force-raw=3Don,addr=3D$((0x400000000 + ${UBOOT_SIZE}= )),file=3D${IMGDIR}/u-boot.dtb \ + -device loader,force-raw=3Don,addr=3D0x400000000,file=3D${IMGDIR}/u= -boot.bin \ -device loader,force-raw=3Don,addr=3D0x430000000,file=3D${IMGDIR}/b= l31.bin \ -device loader,force-raw=3Don,addr=3D0x430080000,file=3D${IMGDIR}/o= ptee/tee-raw.bin \ -device loader,cpu-num=3D0,addr=3D0x430000000 \ --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201535; cv=none; d=zohomail.com; s=zohoarc; b=chJRusZ/iR0zOiAbM49dHiMH5Ne4YIpx5XNTOc6cUpeWXMnhHGJdUfKArdVE8AXOH0UtjiV230Tswmt9b3XiqkFAjVaXgKktNY+s6YZWhgizebx0cnjGRA4Ue6BB2U2B6AZDGHK2XmxZdzzlaJ20Wc6i8DZwMpLf9NjlNFiGYt4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201535; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=h1nByeQJG390FPZelYiFPIApZxR6CBGG4X3l2yt9zDY=; b=MXZBBDDN2En6Aw2VsKRf/oTv+h+bmAEGMN1BNoOfqZRtNu/WiMK+M9x24y1ZSiFavaQsed773yBsiY+33e4HYX+skcUOSlTM1++Tv7NDcQ4/5cxMuwb56To3hLL3Fhx7Fs8a32472q5bqSfg0JGOqOiTZUjqbnQD3ngOuiCMINc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201535710190.10680339210785; Wed, 4 Feb 2026 02:38:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBt-00023Q-M3; Wed, 04 Feb 2026 05:32:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBh-0001aq-0D for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBc-00046W-VN for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:42 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-XmdmiKKvOPCP_xhDicUu0Q-1; Wed, 04 Feb 2026 05:32:31 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C716419560A5; Wed, 4 Feb 2026 10:32:30 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EF60418003F6; Wed, 4 Feb 2026 10:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h1nByeQJG390FPZelYiFPIApZxR6CBGG4X3l2yt9zDY=; b=RZK0TFH7CSzKUAgRH5oSjTKDSIJyNwXlL3njz4G3Gj/9vI2xiCKgEPepghiuCd5oPoQXYN ZlaW1xhmXx5PoZRbXIgMQMtEoseiSHry/8P5WVHG6uO9ZOnPtc5FzIqzv1WG2s9t3EHfoQ NuFbqgaMwZiuSUyPEbl13mMCzBAdHXA= X-MC-Unique: XmdmiKKvOPCP_xhDicUu0Q-1 X-Mimecast-MFC-AGG-ID: XmdmiKKvOPCP_xhDicUu0Q_1770201150 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 24/45] hw/misc: Add LTPI controller Date: Wed, 4 Feb 2026 11:31:15 +0100 Message-ID: <20260204103136.1795455-25-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201537490158500 From: Kane Chen LTPI (LVDS Tunneling Protocol & Interface) is defined in the OCP DC-SCM 2.0 specification: https://www.opencompute.org/documents/ocp-dc-scm-2-0-ltpi-ver-1-0-pdf LTPI is a protocol and physical interface for tunneling various low-speed signals between the HPM and SCM. As shown in Figure 2, the AST27x0 (left) integrates two LTPI controllers, allowing it to connect to up to two extended boards. This commit introduces a simple device model for the ASPEED LTPI controller in QEMU. The model includes basic MMIO read/write operations and sets default register values during reset to emulate a link-up state. Implements register space with read/write callbacks. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-2-kane_chen= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/misc/aspeed_ltpi.h | 33 ++++++ hw/misc/aspeed_ltpi.c | 193 ++++++++++++++++++++++++++++++++++ hw/misc/meson.build | 1 + 3 files changed, 227 insertions(+) create mode 100644 include/hw/misc/aspeed_ltpi.h create mode 100644 hw/misc/aspeed_ltpi.c diff --git a/include/hw/misc/aspeed_ltpi.h b/include/hw/misc/aspeed_ltpi.h new file mode 100644 index 000000000000..3330a49b0564 --- /dev/null +++ b/include/hw/misc/aspeed_ltpi.h @@ -0,0 +1,33 @@ +/* + * ASPEED LTPI Controller + * + * Copyright (C) 2025 ASPEED Technology Inc. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ +#ifndef ASPEED_LTPI_H +#define ASPEED_LTPI_H + +#include "hw/core/sysbus.h" + +#define TYPE_ASPEED_LTPI "aspeed.ltpi-ctrl" +OBJECT_DECLARE_SIMPLE_TYPE(AspeedLTPIState, ASPEED_LTPI) + +#define ASPEED_LTPI_TOTAL_SIZE 0x900 +#define ASPEED_LTPI_CTRL_SIZE 0x200 +#define ASPEED_LTPI_PHY_SIZE 0x100 +#define ASPEED_LTPI_TOP_SIZE 0x100 + +struct AspeedLTPIState { + SysBusDevice parent; + MemoryRegion mmio; + MemoryRegion mmio_ctrl; + MemoryRegion mmio_phy; + MemoryRegion mmio_top; + + uint32_t ctrl_regs[ASPEED_LTPI_CTRL_SIZE >> 2]; + uint32_t phy_regs[ASPEED_LTPI_PHY_SIZE >> 2]; + uint32_t top_regs[ASPEED_LTPI_TOP_SIZE >> 2]; +}; + +#endif /* ASPEED_LTPI_H */ diff --git a/hw/misc/aspeed_ltpi.c b/hw/misc/aspeed_ltpi.c new file mode 100644 index 000000000000..131cea9c6b8b --- /dev/null +++ b/hw/misc/aspeed_ltpi.c @@ -0,0 +1,193 @@ +/* + * ASPEED LTPI Controller + * + * Copyright (C) 2025 ASPEED Technology Inc. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "migration/vmstate.h" +#include "hw/misc/aspeed_ltpi.h" + +#define ASPEED_LTPI_CTRL_BASE 0x000 +#define ASPEED_LTPI_PHY_BASE 0x200 +#define ASPEED_LTPI_TOP_BASE 0x800 + +#define LTPI_CTRL_LINK_MNG 0x42 +#define LTPI_PHY_MODE 0x0 + +static uint64_t aspeed_ltpi_top_read(void *opaque, hwaddr offset, unsigned= size) +{ + AspeedLTPIState *s =3D opaque; + uint32_t idx =3D offset >> 2; + + return s->top_regs[idx]; +} + +static void aspeed_ltpi_top_write(void *opaque, hwaddr offset, + uint64_t val, unsigned size) +{ + AspeedLTPIState *s =3D opaque; + uint32_t idx =3D offset >> 2; + + switch (offset) { + default: + s->top_regs[idx] =3D (uint32_t)val; + break; + } +} + +static const MemoryRegionOps aspeed_ltpi_top_ops =3D { + .read =3D aspeed_ltpi_top_read, + .write =3D aspeed_ltpi_top_write, + .endianness =3D DEVICE_LITTLE_ENDIAN, + .valid =3D { + .min_access_size =3D 1, + .max_access_size =3D 4, + }, +}; + +static uint64_t aspeed_ltpi_phy_read(void *opaque, hwaddr offset, unsigned= size) +{ + AspeedLTPIState *s =3D opaque; + uint32_t idx =3D offset >> 2; + + return s->phy_regs[idx]; +} + +static void aspeed_ltpi_phy_write(void *opaque, hwaddr offset, + uint64_t val, unsigned size) +{ + AspeedLTPIState *s =3D opaque; + uint32_t idx =3D offset >> 2; + + switch (offset) { + default: + s->phy_regs[idx] =3D (uint32_t)val; + break; + } +} + +static const MemoryRegionOps aspeed_ltpi_phy_ops =3D { + .read =3D aspeed_ltpi_phy_read, + .write =3D aspeed_ltpi_phy_write, + .endianness =3D DEVICE_LITTLE_ENDIAN, + .valid =3D { + .min_access_size =3D 1, + .max_access_size =3D 4, + }, +}; + +static uint64_t aspeed_ltpi_ctrl_read(void *opaque, + hwaddr offset, unsigned size) +{ + AspeedLTPIState *s =3D opaque; + uint32_t idx =3D offset >> 2; + + return s->ctrl_regs[idx]; +} + +static void aspeed_ltpi_ctrl_write(void *opaque, hwaddr offset, + uint64_t val, unsigned size) +{ + AspeedLTPIState *s =3D opaque; + uint32_t idx =3D offset >> 2; + + switch (offset) { + default: + s->ctrl_regs[idx] =3D (uint32_t)val; + break; + } +} + +static const MemoryRegionOps aspeed_ltpi_ctrl_ops =3D { + .read =3D aspeed_ltpi_ctrl_read, + .write =3D aspeed_ltpi_ctrl_write, + .endianness =3D DEVICE_LITTLE_ENDIAN, + .valid =3D { + .min_access_size =3D 1, + .max_access_size =3D 4, + }, +}; + +static void aspeed_ltpi_reset(DeviceState *dev) +{ + AspeedLTPIState *s =3D ASPEED_LTPI(dev); + + memset(s->ctrl_regs, 0, sizeof(s->ctrl_regs)); + memset(s->phy_regs, 0, sizeof(s->phy_regs)); + memset(s->top_regs, 0, sizeof(s->top_regs)); + /* set default values */ + s->ctrl_regs[LTPI_CTRL_LINK_MNG] =3D 0x11900007; + s->phy_regs[LTPI_PHY_MODE] =3D 0x2; +} + + +static const VMStateDescription vmstate_aspeed_ltpi =3D { + .name =3D TYPE_ASPEED_LTPI, + .version_id =3D 1, + .minimum_version_id =3D 1, + .fields =3D (VMStateField[]) { + VMSTATE_UINT32_ARRAY(ctrl_regs, AspeedLTPIState, + ASPEED_LTPI_CTRL_SIZE >> 2), + VMSTATE_UINT32_ARRAY(phy_regs, AspeedLTPIState, + ASPEED_LTPI_PHY_SIZE >> 2), + VMSTATE_UINT32_ARRAY(top_regs, AspeedLTPIState, + ASPEED_LTPI_TOP_SIZE >> 2), + + VMSTATE_END_OF_LIST() + } +}; + +static void aspeed_ltpi_realize(DeviceState *dev, Error **errp) +{ + AspeedLTPIState *s =3D ASPEED_LTPI(dev); + + memory_region_init(&s->mmio, OBJECT(s), TYPE_ASPEED_LTPI, + ASPEED_LTPI_TOTAL_SIZE); + + memory_region_init_io(&s->mmio_ctrl, OBJECT(s), + &aspeed_ltpi_ctrl_ops, s, + "aspeed-ltpi-ctrl", ASPEED_LTPI_CTRL_SIZE); + + memory_region_init_io(&s->mmio_phy, OBJECT(s), + &aspeed_ltpi_phy_ops, s, + "aspeed-ltpi-phy", ASPEED_LTPI_PHY_SIZE); + + memory_region_init_io(&s->mmio_top, OBJECT(s), + &aspeed_ltpi_top_ops, s, + "aspeed-ltpi-top", ASPEED_LTPI_TOP_SIZE); + + memory_region_add_subregion(&s->mmio, + ASPEED_LTPI_CTRL_BASE, &s->mmio_ctrl); + memory_region_add_subregion(&s->mmio, + ASPEED_LTPI_PHY_BASE, &s->mmio_phy); + memory_region_add_subregion(&s->mmio, + ASPEED_LTPI_TOP_BASE, &s->mmio_top); + + sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->mmio); +} + +static void aspeed_ltpi_class_init(ObjectClass *klass, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + dc->realize =3D aspeed_ltpi_realize; + dc->vmsd =3D &vmstate_aspeed_ltpi; + device_class_set_legacy_reset(dc, aspeed_ltpi_reset); +} + +static const TypeInfo aspeed_ltpi_info =3D { + .name =3D TYPE_ASPEED_LTPI, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(AspeedLTPIState), + .class_init =3D aspeed_ltpi_class_init, +}; + +static void aspeed_ltpi_register_types(void) +{ + type_register_static(&aspeed_ltpi_info); +} + +type_init(aspeed_ltpi_register_types); diff --git a/hw/misc/meson.build b/hw/misc/meson.build index c444e030ecda..f7f1b0da75c5 100644 --- a/hw/misc/meson.build +++ b/hw/misc/meson.build @@ -137,6 +137,7 @@ system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( 'aspeed_hace.c', 'aspeed_i3c.c', 'aspeed_lpc.c', + 'aspeed_ltpi.c', 'aspeed_scu.c', 'aspeed_sbc.c', 'aspeed_sdmc.c', --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201493; cv=none; d=zohomail.com; s=zohoarc; b=YR1mgXBdbMFBlPIjJ070Juh5TfMRuWu/biREqI3z8An19TCvP7oLXmF3x+k6ZWG9o75t34aqiAALCiACHgT1jB4M9u2d2Z9esORvXGlFOZLJQrWx7Dm6Im9q92c0AezIgplVsDd/C2tx/o1QTk/wHcklEY4o8HdQU0J19BPAN4w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201493; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=h8xXLjWIcSwTmFSPSfPwua3qcUc1vaUITMCGP+3yTPI=; b=DznQuU8rNdsEHtDPkUDFYNzQH0t88HU2aQaAqDTlcau5AzQc6aMu27QW5UGURm9PiwmdesdUPgo6B7iigF5G0uLT0ZNfsYVJNBmctI+7TptRr8BuM34cwbfBjLaZNc9k7EeMgcmu5N9XvO7ABeAGue4XmbLXX8Ok9WQguDrrnJo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201493147713.5773942860752; Wed, 4 Feb 2026 02:38:13 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBm-0001kg-6y; Wed, 04 Feb 2026 05:32:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBd-0001L5-8b for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBa-00045s-K9 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:40 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-maCaRkqIO-qd4hp9H_aKAA-1; Wed, 04 Feb 2026 05:32:34 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 134A419560B2; Wed, 4 Feb 2026 10:32:33 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 436E818003F6; Wed, 4 Feb 2026 10:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h8xXLjWIcSwTmFSPSfPwua3qcUc1vaUITMCGP+3yTPI=; b=KcSuwIdZLqL+jAivwlgWx0INI+I0lhPVcUVEShUdv4vujbQ2DIGtzKduHxY3fq+YPhjFSq 8y8wauP74Q+8vT9MEFwckvX4VPUWAo+Z3e3zuY++FhKUhRDgHF2I6z7pH/k+pwzMjPpJjC GFonqcrHkO8HcxRHcQNcdHZLnJ/3KMU= X-MC-Unique: maCaRkqIO-qd4hp9H_aKAA-1 X-Mimecast-MFC-AGG-ID: maCaRkqIO-qd4hp9H_aKAA_1770201153 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 25/45] hw/arm/aspeed: Attach LTPI controller to AST27X0 platform Date: Wed, 4 Feb 2026 11:31:16 +0100 Message-ID: <20260204103136.1795455-26-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201494113154100 From: Kane Chen Connect the LTPI controller device (representing the AST1700 I/O expander) to the AST27X0 SoC model. This patch sets up the memory mapping and device registration according to the AST2700 SoC design, where the LTPI controller is exposed at fixed MMIO regions. This change only handles device instantiation and integration, without implementing the controller's internal logic. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-3-kane_chen= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_soc.h | 5 +++++ hw/arm/aspeed_ast27x0.c | 21 +++++++++++++++++++++ 2 files changed, 26 insertions(+) diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index 18ff961a3850..bca10c387b08 100644 --- a/include/hw/arm/aspeed_soc.h +++ b/include/hw/arm/aspeed_soc.h @@ -43,6 +43,7 @@ #include "hw/fsi/aspeed_apb2opb.h" #include "hw/char/serial-mm.h" #include "hw/intc/arm_gicv3.h" +#include "hw/misc/aspeed_ltpi.h" =20 #define VBOOTROM_FILE_NAME "ast27x0_bootrom.bin" =20 @@ -55,6 +56,7 @@ #define ASPEED_UARTS_NUM 13 #define ASPEED_JTAG_NUM 2 #define ASPEED_PCIE_NUM 3 +#define ASPEED_IOEXP_NUM 2 =20 struct AspeedSoCState { DeviceState parent; @@ -112,6 +114,7 @@ struct AspeedSoCState { UnimplementedDeviceState ltpi; UnimplementedDeviceState jtag[ASPEED_JTAG_NUM]; AspeedAPB2OPBState fsi[2]; + AspeedLTPIState ltpi_ctrl[ASPEED_IOEXP_NUM]; }; =20 #define TYPE_ASPEED_SOC "aspeed-soc" @@ -279,6 +282,8 @@ enum { ASPEED_GIC_REDIST, ASPEED_DEV_IPC0, ASPEED_DEV_IPC1, + ASPEED_DEV_LTPI_CTRL1, + ASPEED_DEV_LTPI_CTRL2, }; =20 const char *aspeed_soc_cpu_type(const char * const *valid_cpu_types); diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index e16183c3b329..bbcb6e012709 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -88,6 +88,8 @@ static const hwaddr aspeed_soc_ast2700_memmap[] =3D { [ASPEED_DEV_UART10] =3D 0x14C33900, [ASPEED_DEV_UART11] =3D 0x14C33A00, [ASPEED_DEV_UART12] =3D 0x14C33B00, + [ASPEED_DEV_LTPI_CTRL1] =3D 0x14C34000, + [ASPEED_DEV_LTPI_CTRL2] =3D 0x14C35000, [ASPEED_DEV_WDT] =3D 0x14C37000, [ASPEED_DEV_LTPI] =3D 0x30000000, [ASPEED_DEV_PCIE_MMIO0] =3D 0x60000000, @@ -491,6 +493,11 @@ static void aspeed_soc_ast2700_init(Object *obj) object_property_set_int(OBJECT(&s->pcie[i]), "id", i, &error_abort= ); } =20 + for (i =3D 0; i < ASPEED_IOEXP_NUM; i++) { + object_initialize_child(obj, "ltpi-ctrl[*]", + &s->ltpi_ctrl[i], TYPE_ASPEED_LTPI); + } + object_initialize_child(obj, "dpmcu", &s->dpmcu, TYPE_UNIMPLEMENTED_DEVICE); object_initialize_child(obj, "ltpi", &s->ltpi, @@ -974,6 +981,20 @@ static void aspeed_soc_ast2700_realize(DeviceState *de= v, Error **errp) return; } =20 + /* LTPI controller */ + for (i =3D 0; i < ASPEED_IOEXP_NUM; i++) { + AspeedLTPIState *ltpi_ctrl; + hwaddr ltpi_base; + + ltpi_ctrl =3D ASPEED_LTPI(&s->ltpi_ctrl[i]); + ltpi_base =3D sc->memmap[ASPEED_DEV_LTPI_CTRL1 + i]; + + if (!sysbus_realize(SYS_BUS_DEVICE(ltpi_ctrl), errp)) { + return; + } + aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(ltpi_ctrl), 0, ltpi_base= ); + } + aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->dpmcu), "aspeed.dpmcu", sc->memmap[ASPEED_DEV_DPMCU], --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201460; cv=none; d=zohomail.com; s=zohoarc; b=YFLVf01CEX9bFJ3XqiyYDZCSxLJhyVXT5Bt89IE5hd/xk4QRtiN1zaPBUxI93xKP8bIuGlpKcSC/vhDJ/i82xCQBw6FifCzueONlOzqHCnXwc68MBs4ZxEGcaJTwGgUw3zVVOfUFXUpqa2d9aT2r7vXzMQZ84GOXh5/TzGagh8M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201460; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yJFfhx1yxnbOJdrUjWgaDSrpidesWJDQQThgvrEVOp8=; b=H33RGcpkE7pYIjSDu8k+2ZGJpwWKUkoLDKfullYb7rb4R2rrNKEkjFaMFFZeJmKzmdnU8JW/ucX2N/kRJsAYcfvP7w1FXssPtHhEQWk7d/XmXfgdSrKVEkZHoqaxZIIhSSkpjKE19224pLnfTu839q6Nd5qI7Z7aCLKmR433h0E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201460473775.6880849206094; Wed, 4 Feb 2026 02:37:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBm-0001ks-8p; Wed, 04 Feb 2026 05:32:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBh-0001aw-0d for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBa-00045v-Op for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:41 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-372-nESxsoh6PvKL-w_kGp52kA-1; Wed, 04 Feb 2026 05:32:36 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 56458180025A; Wed, 4 Feb 2026 10:32:35 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 85094180035A; Wed, 4 Feb 2026 10:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yJFfhx1yxnbOJdrUjWgaDSrpidesWJDQQThgvrEVOp8=; b=dvEbub2aOfO03RiJHARQXK1v3lwtPnd29ZoW2WvKtpCnesCmxJG84x7CG5i7Fjq3bG3Iuo ZJgZqWAYr3F/XvcwP4+fBCicZq/4CVBMlAbCKqVaxeftO7KAx/f0TrG3NirdptKhaBFui+ mjiQ3Hrf5h3422QH6UaxaTz7OC6bKOo= X-MC-Unique: nESxsoh6PvKL-w_kGp52kA-1 X-Mimecast-MFC-AGG-ID: nESxsoh6PvKL-w_kGp52kA_1770201155 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 26/45] hw/misc: Add basic Aspeed PWM model Date: Wed, 4 Feb 2026 11:31:17 +0100 Message-ID: <20260204103136.1795455-27-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201461266158500 From: Kane Chen Add an initial PWM model for Aspeed SoCs, including device state, register definitions, and basic initialization as a sysbus device. Signed-off-by: C=C3=A9dric Le Goater Signed-off-by: Kane-Chen-AS Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-4-kane_chen= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_soc.h | 3 +- include/hw/misc/aspeed_pwm.h | 30 +++++++++ hw/misc/aspeed_pwm.c | 120 +++++++++++++++++++++++++++++++++++ hw/misc/meson.build | 1 + hw/misc/trace-events | 4 ++ 5 files changed, 157 insertions(+), 1 deletion(-) create mode 100644 include/hw/misc/aspeed_pwm.h create mode 100644 hw/misc/aspeed_pwm.c diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index bca10c387b08..7b08cca908b3 100644 --- a/include/hw/arm/aspeed_soc.h +++ b/include/hw/arm/aspeed_soc.h @@ -28,6 +28,7 @@ #include "hw/misc/aspeed_hace.h" #include "hw/misc/aspeed_sbc.h" #include "hw/misc/aspeed_sli.h" +#include "hw/misc/aspeed_pwm.h" #include "hw/watchdog/wdt_aspeed.h" #include "hw/net/ftgmac100.h" #include "target/arm/cpu.h" @@ -88,6 +89,7 @@ struct AspeedSoCState { MemoryRegion secsram; UnimplementedDeviceState sbc_unimplemented; AspeedSDMCState sdmc; + AspeedPWMState pwm; AspeedWDTState wdt[ASPEED_WDTS_NUM]; FTGMAC100State ftgmac100[ASPEED_MACS_NUM]; AspeedMiiState mii[ASPEED_MACS_NUM]; @@ -108,7 +110,6 @@ struct AspeedSoCState { UnimplementedDeviceState video; UnimplementedDeviceState emmc_boot_controller; UnimplementedDeviceState dpmcu; - UnimplementedDeviceState pwm; UnimplementedDeviceState espi; UnimplementedDeviceState udc; UnimplementedDeviceState ltpi; diff --git a/include/hw/misc/aspeed_pwm.h b/include/hw/misc/aspeed_pwm.h new file mode 100644 index 000000000000..f4104ada2224 --- /dev/null +++ b/include/hw/misc/aspeed_pwm.h @@ -0,0 +1,30 @@ +/* + * ASPEED PWM Controller + * + * Copyright (C) 2017-2021 IBM Corp. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef ASPEED_PWM_H +#define ASPEED_PWM_H + +#include "hw/core/sysbus.h" + +#define TYPE_ASPEED_PWM "aspeed.pwm" +#define ASPEED_PWM(obj) OBJECT_CHECK(AspeedPWMState, (obj), TYPE_ASPEED_PW= M) + +#define ASPEED_PWM_NR_REGS (0x10C >> 2) + +typedef struct AspeedPWMState { + /* */ + SysBusDevice parent; + + /*< public >*/ + MemoryRegion iomem; + qemu_irq irq; + + uint32_t regs[ASPEED_PWM_NR_REGS]; +} AspeedPWMState; + +#endif /* _ASPEED_PWM_H_ */ diff --git a/hw/misc/aspeed_pwm.c b/hw/misc/aspeed_pwm.c new file mode 100644 index 000000000000..ee3d5884be22 --- /dev/null +++ b/hw/misc/aspeed_pwm.c @@ -0,0 +1,120 @@ +/* + * ASPEED PWM Controller + * + * Copyright (C) 2017-2021 IBM Corp. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "qemu/error-report.h" +#include "hw/misc/aspeed_pwm.h" +#include "qapi/error.h" +#include "migration/vmstate.h" + +#include "trace.h" + +static uint64_t aspeed_pwm_read(void *opaque, hwaddr addr, + unsigned int size) +{ + AspeedPWMState *s =3D ASPEED_PWM(opaque); + uint64_t val =3D 0; + + addr >>=3D 2; + + if (addr >=3D ASPEED_PWM_NR_REGS) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Out-of-bounds read at offset 0x%" HWADDR_PRIx "= \n", + __func__, addr << 2); + } else { + val =3D s->regs[addr]; + } + + trace_aspeed_pwm_read(addr << 2, val); + + return val; +} + +static void aspeed_pwm_write(void *opaque, hwaddr addr, uint64_t data, + unsigned int size) +{ + AspeedPWMState *s =3D ASPEED_PWM(opaque); + + trace_aspeed_pwm_write(addr, data); + + addr >>=3D 2; + + if (addr >=3D ASPEED_PWM_NR_REGS) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Out-of-bounds write at offset 0x%" HWADDR_PRIx = "\n", + __func__, addr << 2); + return; + } + + s->regs[addr] =3D data; +} + +static const MemoryRegionOps aspeed_pwm_ops =3D { + .read =3D aspeed_pwm_read, + .write =3D aspeed_pwm_write, + .endianness =3D DEVICE_LITTLE_ENDIAN, + .valid =3D { + .min_access_size =3D 1, + .max_access_size =3D 4, + }, +}; + +static void aspeed_pwm_reset(DeviceState *dev) +{ + struct AspeedPWMState *s =3D ASPEED_PWM(dev); + + memset(s->regs, 0, sizeof(s->regs)); +} + +static void aspeed_pwm_realize(DeviceState *dev, Error **errp) +{ + AspeedPWMState *s =3D ASPEED_PWM(dev); + SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); + + sysbus_init_irq(sbd, &s->irq); + + memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_pwm_ops, s, + TYPE_ASPEED_PWM, 0x1000); + + sysbus_init_mmio(sbd, &s->iomem); +} + +static const VMStateDescription vmstate_aspeed_pwm =3D { + .name =3D TYPE_ASPEED_PWM, + .version_id =3D 1, + .minimum_version_id =3D 1, + .fields =3D (VMStateField[]) { + VMSTATE_UINT32_ARRAY(regs, AspeedPWMState, ASPEED_PWM_NR_REGS), + VMSTATE_END_OF_LIST(), + } +}; + +static void aspeed_pwm_class_init(ObjectClass *klass, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + + dc->realize =3D aspeed_pwm_realize; + device_class_set_legacy_reset(dc, aspeed_pwm_reset); + dc->desc =3D "Aspeed PWM Controller"; + dc->vmsd =3D &vmstate_aspeed_pwm; +} + +static const TypeInfo aspeed_pwm_info =3D { + .name =3D TYPE_ASPEED_PWM, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(AspeedPWMState), + .class_init =3D aspeed_pwm_class_init, +}; + +static void aspeed_pwm_register_types(void) +{ + type_register_static(&aspeed_pwm_info); +} + +type_init(aspeed_pwm_register_types); diff --git a/hw/misc/meson.build b/hw/misc/meson.build index f7f1b0da75c5..d304a984984a 100644 --- a/hw/misc/meson.build +++ b/hw/misc/meson.build @@ -138,6 +138,7 @@ system_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( 'aspeed_i3c.c', 'aspeed_lpc.c', 'aspeed_ltpi.c', + 'aspeed_pwm.c', 'aspeed_scu.c', 'aspeed_sbc.c', 'aspeed_sdmc.c', diff --git a/hw/misc/trace-events b/hw/misc/trace-events index 4cee8a2b4541..d6af2fcf8527 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -299,6 +299,10 @@ aspeed_i3c_write(uint64_t offset, uint64_t data) "I3C = write: offset 0x%" PRIx64 aspeed_i3c_device_read(uint32_t deviceid, uint64_t offset, uint64_t data) = "I3C Dev[%u] read: offset 0x%" PRIx64 " data 0x%" PRIx64 aspeed_i3c_device_write(uint32_t deviceid, uint64_t offset, uint64_t data)= "I3C Dev[%u] write: offset 0x%" PRIx64 " data 0x%" PRIx64 =20 +# aspeed_pwm.c +aspeed_pwm_read(uint64_t offset, uint64_t data) "read: offset 0x%" PRIx64 = " data 0x%" PRIx64 +aspeed_pwm_write(uint64_t offset, uint64_t data) "write: offset 0x%" PRIx6= 4 " data 0x%" PRIx64 + # aspeed_sdmc.c aspeed_sdmc_write(uint64_t reg, uint64_t data) "reg @0x%" PRIx64 " data: 0= x%" PRIx64 aspeed_sdmc_read(uint64_t reg, uint64_t data) "reg @0x%" PRIx64 " data: 0x= %" PRIx64 --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201523; cv=none; d=zohomail.com; s=zohoarc; b=R0RFJW56tFbFJKLhxtYVggxWedaQOSGe24r095lsmI7C7MTVb1WVkLHx8tt30xl2viPeCOzZykzvPD1wO1WcB/SvbPuOzuX+R4GzZpY4gUGWmAgPSt1x6QiqMgTsUvXCr3MItLb/Zbb2z0EhPQhSrbs6+1wU493al3U46X+kFt8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201523; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HL55vYoNa94ka4HEiZ/wtz9mVM+3qKLm4cgwbFBku2Y=; b=IhlS1fYGKiaCZh8illYuUIeA9S8ckEWK6vEpvJtHZvwY4uzO6YmtO9WeF8BLnsj8Su75Y9c4HvMDWSDG0UH3vKrwWb8TpDaCFFWBV2/7F5fGI/1sGlf3r3HIuFqPXm0JMSVh8zRa2g8+W/BPwkQz1PpN1oxmxyPG6BSOPCnal9o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201523265506.365050844277; Wed, 4 Feb 2026 02:38:43 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBo-0001rJ-4N; Wed, 04 Feb 2026 05:32:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBg-0001aa-WA for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBc-00046O-V7 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:42 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-bT6NNkzeNJKpS26DKn4sag-1; Wed, 04 Feb 2026 05:32:38 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7F38C18003F5; Wed, 4 Feb 2026 10:32:37 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C860818004AD; Wed, 4 Feb 2026 10:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HL55vYoNa94ka4HEiZ/wtz9mVM+3qKLm4cgwbFBku2Y=; b=AR2ZXfRLi/GWKm7lhexObcupI5zNfxeer0dwkWAUkRneo9bBDclzBSvGgwAjxHKBdsmI7I j3zbwn0C24cuL/MljGOINcLZfvrgLgPcjXzCXgINg1JqYnlk+Waa4jaWwHMsz70U/eGhXF pLSbQG7D7IyHWTKYfg04G9cqxAhyDjg= X-MC-Unique: bT6NNkzeNJKpS26DKn4sag-1 X-Mimecast-MFC-AGG-ID: bT6NNkzeNJKpS26DKn4sag_1770201157 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 27/45] hw/arm/aspeed: Add AST1700 LTPI expander device model Date: Wed, 4 Feb 2026 11:31:18 +0100 Message-ID: <20260204103136.1795455-28-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201525360158500 From: Kane Chen Introduce a minimal QEMU device model for the ASPEED AST1700, an MCU-less I/O expander used in the LTPI topology defined by the DC-SCM 2.0 specification (see figure 2): https://www.opencompute.org/documents/ocp-dc-scm-2-0-ltpi-ver-1-0-pdf This initial implementation includes: * Definition of aspeed.ast1700 as a SysBusDevice * Setup of a basic memory region to reserve I/O space for future peripheral modeling This stub establishes the foundation for LTPI-related device emulation, without implementing any functional peripherals at this stage. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-5-kane_chen= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 23 +++++++++++++++++ hw/arm/aspeed_ast1700.c | 46 +++++++++++++++++++++++++++++++++ hw/arm/meson.build | 1 + 3 files changed, 70 insertions(+) create mode 100644 include/hw/arm/aspeed_ast1700.h create mode 100644 hw/arm/aspeed_ast1700.c diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h new file mode 100644 index 000000000000..378dcb437a78 --- /dev/null +++ b/include/hw/arm/aspeed_ast1700.h @@ -0,0 +1,23 @@ +/* + * ASPEED AST1700 IO Expander + * + * Copyright (C) 2025 ASPEED Technology Inc. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ +#ifndef ASPEED_AST1700_H +#define ASPEED_AST1700_H + +#include "hw/core/sysbus.h" + +#define TYPE_ASPEED_AST1700 "aspeed.ast1700" + +OBJECT_DECLARE_SIMPLE_TYPE(AspeedAST1700SoCState, ASPEED_AST1700) + +struct AspeedAST1700SoCState { + SysBusDevice parent_obj; + + MemoryRegion iomem; +}; + +#endif /* ASPEED_AST1700_H */ diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c new file mode 100644 index 000000000000..dd38b819b864 --- /dev/null +++ b/hw/arm/aspeed_ast1700.c @@ -0,0 +1,46 @@ +/* + * ASPEED AST1700 IO Expander + * + * Copyright (C) 2025 ASPEED Technology Inc. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "hw/core/boards.h" +#include "qom/object.h" +#include "hw/arm/aspeed_ast1700.h" + +#define AST2700_SOC_LTPI_SIZE 0x01000000 + +static void aspeed_ast1700_realize(DeviceState *dev, Error **errp) +{ + AspeedAST1700SoCState *s =3D ASPEED_AST1700(dev); + SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); + + /* Occupy memory space for all controllers in AST1700 */ + memory_region_init(&s->iomem, OBJECT(s), TYPE_ASPEED_AST1700, + AST2700_SOC_LTPI_SIZE); + sysbus_init_mmio(sbd, &s->iomem); +} + +static void aspeed_ast1700_class_init(ObjectClass *klass, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + + dc->realize =3D aspeed_ast1700_realize; +} + +static const TypeInfo aspeed_ast1700_info =3D { + .name =3D TYPE_ASPEED_AST1700, + .parent =3D TYPE_SYS_BUS_DEVICE, + .instance_size =3D sizeof(AspeedAST1700SoCState), + .class_init =3D aspeed_ast1700_class_init, +}; + +static void aspeed_ast1700_register_types(void) +{ + type_register_static(&aspeed_ast1700_info); +} + +type_init(aspeed_ast1700_register_types); diff --git a/hw/arm/meson.build b/hw/arm/meson.build index c250487e6486..47cdc51d135a 100644 --- a/hw/arm/meson.build +++ b/hw/arm/meson.build @@ -70,6 +70,7 @@ arm_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( 'aspeed_ast10x0_evb.c', 'fby35.c')) arm_common_ss.add(when: ['CONFIG_ASPEED_SOC', 'TARGET_AARCH64'], if_true: = files( + 'aspeed_ast1700.c', 'aspeed_ast27x0.c', 'aspeed_ast27x0_evb.c', 'aspeed_ast27x0-fc.c', --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201448; cv=none; d=zohomail.com; s=zohoarc; b=RBgwQlj4jnHaDWH23QIVWxHXpGmUsgefoHrjbtZRFfA8jGTMjW5I+sGo1MvO+olkanGAeZRrDe9POxDN3bmnJ7Yuh2dekPwfNLaY6uokqqqqhVYr5hdqvsADeYCq7dti1UlSP0bJ3rKbKw1l4qlFxaEUop6PpygsDTdj0/u9QNI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201448; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=r+JbK5VKCKH/PwVOPnkgAGtpmZUz83KKfSRWDMt9nmI=; b=bw1SDTcaWa0CEF6E3hgM+sJw9r36Wb/05naygLq8oREVXFetxABAGIebvlt5UCWj1ex4ZxfNVJTO4NV0VezL49VFK4Cv+SJDlXweuTHOp1Hn35C7EbsMUir3dB8xEU9xSNmClUJDjuQtKs2N6t8SxfpZBPt7LbJSlWI01A3fIAI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201448396708.1119621945068; Wed, 4 Feb 2026 02:37:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBs-0001yh-Rv; Wed, 04 Feb 2026 05:32:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBi-0001dT-Si for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBg-00046x-PR for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:46 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-297-6bYzcxJ2MHGdhKHeeEKyWw-1; Wed, 04 Feb 2026 05:32:40 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A8BDE1956051; Wed, 4 Feb 2026 10:32:39 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F117B18003F6; Wed, 4 Feb 2026 10:32:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r+JbK5VKCKH/PwVOPnkgAGtpmZUz83KKfSRWDMt9nmI=; b=S1JAu6aXN/BR+fSYtxWCcG1KsYsT7nMBl3+Ym139crc/1WU5orVTa836bwwekbgI/9qIdE VZM+Ryl3bXKTIIVA+/dUS4/O913U7hRt+0dge/jyZCr1iDb0FJs1UCaBvhITF0zJSM2mHc 3BmF9RUCgHHuvSnGup/RjH/t9LRr66w= X-MC-Unique: 6bYzcxJ2MHGdhKHeeEKyWw-1 X-Mimecast-MFC-AGG-ID: 6bYzcxJ2MHGdhKHeeEKyWw_1770201159 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 28/45] hw/arm/aspeed: Integrate AST1700 device into AST27X0 Date: Wed, 4 Feb 2026 11:31:19 +0100 Message-ID: <20260204103136.1795455-29-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201449468154100 From: Kane Chen Connect the AST1700 device as a child of the AST27X0 model to reflect its role in DC-SCM 2.0 LTPI-based architectures. This patch wires the AST1700 device into the platform without introducing functional peripherals. This forms the base for LTPI expander emulation in QEMU using AST27X0 as the host controller. Note: ioexp_num is set to 0 at this stage. Once all related devices and interrupts are fully implemented, ioexp_num will be updated to its expected value. This ensures the machine remains functional at every commit and avoids potential compiler or build issues. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-6-kane_chen= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_soc.h | 7 +++++-- hw/arm/aspeed_ast27x0.c | 26 ++++++++++++++++++-------- 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index 7b08cca908b3..f19bab3457ea 100644 --- a/include/hw/arm/aspeed_soc.h +++ b/include/hw/arm/aspeed_soc.h @@ -45,6 +45,7 @@ #include "hw/char/serial-mm.h" #include "hw/intc/arm_gicv3.h" #include "hw/misc/aspeed_ltpi.h" +#include "hw/arm/aspeed_ast1700.h" =20 #define VBOOTROM_FILE_NAME "ast27x0_bootrom.bin" =20 @@ -112,10 +113,10 @@ struct AspeedSoCState { UnimplementedDeviceState dpmcu; UnimplementedDeviceState espi; UnimplementedDeviceState udc; - UnimplementedDeviceState ltpi; UnimplementedDeviceState jtag[ASPEED_JTAG_NUM]; AspeedAPB2OPBState fsi[2]; AspeedLTPIState ltpi_ctrl[ASPEED_IOEXP_NUM]; + AspeedAST1700SoCState ioexp[ASPEED_IOEXP_NUM]; }; =20 #define TYPE_ASPEED_SOC "aspeed-soc" @@ -178,6 +179,7 @@ struct AspeedSoCClass { int macs_num; int uarts_num; int uarts_base; + int ioexp_num; const int *irqmap; const hwaddr *memmap; uint32_t num_cpus; @@ -190,7 +192,6 @@ enum { ASPEED_DEV_IOMEM, ASPEED_DEV_IOMEM0, ASPEED_DEV_IOMEM1, - ASPEED_DEV_LTPI, ASPEED_DEV_UART0, ASPEED_DEV_UART1, ASPEED_DEV_UART2, @@ -285,6 +286,8 @@ enum { ASPEED_DEV_IPC1, ASPEED_DEV_LTPI_CTRL1, ASPEED_DEV_LTPI_CTRL2, + ASPEED_DEV_LTPI_IO0, + ASPEED_DEV_LTPI_IO1, }; =20 const char *aspeed_soc_cpu_type(const char * const *valid_cpu_types); diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index bbcb6e012709..a05112e2b040 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -26,7 +26,6 @@ #define AST2700_SOC_IO_SIZE 0x00FE0000 #define AST2700_SOC_IOMEM_SIZE 0x01000000 #define AST2700_SOC_DPMCU_SIZE 0x00040000 -#define AST2700_SOC_LTPI_SIZE 0x01000000 =20 static const hwaddr aspeed_soc_ast2700_memmap[] =3D { [ASPEED_DEV_VBOOTROM] =3D 0x00000000, @@ -91,7 +90,8 @@ static const hwaddr aspeed_soc_ast2700_memmap[] =3D { [ASPEED_DEV_LTPI_CTRL1] =3D 0x14C34000, [ASPEED_DEV_LTPI_CTRL2] =3D 0x14C35000, [ASPEED_DEV_WDT] =3D 0x14C37000, - [ASPEED_DEV_LTPI] =3D 0x30000000, + [ASPEED_DEV_LTPI_IO0] =3D 0x30000000, + [ASPEED_DEV_LTPI_IO1] =3D 0x50000000, [ASPEED_DEV_PCIE_MMIO0] =3D 0x60000000, [ASPEED_DEV_PCIE_MMIO1] =3D 0x80000000, [ASPEED_DEV_PCIE_MMIO2] =3D 0xA0000000, @@ -498,10 +498,14 @@ static void aspeed_soc_ast2700_init(Object *obj) &s->ltpi_ctrl[i], TYPE_ASPEED_LTPI); } =20 + for (i =3D 0; i < sc->ioexp_num; i++) { + /* AST1700 IOEXP */ + object_initialize_child(obj, "ioexp[*]", &s->ioexp[i], + TYPE_ASPEED_AST1700); + } + object_initialize_child(obj, "dpmcu", &s->dpmcu, TYPE_UNIMPLEMENTED_DEVICE); - object_initialize_child(obj, "ltpi", &s->ltpi, - TYPE_UNIMPLEMENTED_DEVICE); object_initialize_child(obj, "iomem", &s->iomem, TYPE_UNIMPLEMENTED_DEVICE); object_initialize_child(obj, "iomem0", &s->iomem0, @@ -995,14 +999,19 @@ static void aspeed_soc_ast2700_realize(DeviceState *d= ev, Error **errp) aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(ltpi_ctrl), 0, ltpi_base= ); } =20 + /* IO Expander */ + for (i =3D 0; i < sc->ioexp_num; i++) { + if (!sysbus_realize(SYS_BUS_DEVICE(&s->ioexp[i]), errp)) { + return; + } + sysbus_mmio_map(SYS_BUS_DEVICE(&s->ioexp[i]), 0, + sc->memmap[ASPEED_DEV_LTPI_IO0 + i]); + } + aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->dpmcu), "aspeed.dpmcu", sc->memmap[ASPEED_DEV_DPMCU], AST2700_SOC_DPMCU_SIZE); - aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->ltpi), - "aspeed.ltpi", - sc->memmap[ASPEED_DEV_LTPI], - AST2700_SOC_LTPI_SIZE); aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->iomem), "aspeed.io", sc->memmap[ASPEED_DEV_IOMEM], @@ -1041,6 +1050,7 @@ static void aspeed_soc_ast2700a1_class_init(ObjectCla= ss *oc, const void *data) sc->macs_num =3D 3; sc->uarts_num =3D 13; sc->num_cpus =3D 4; + sc->ioexp_num =3D 0; sc->uarts_base =3D ASPEED_DEV_UART0; sc->irqmap =3D aspeed_soc_ast2700a1_irqmap; sc->memmap =3D aspeed_soc_ast2700_memmap; --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201527; cv=none; d=zohomail.com; s=zohoarc; b=c130tIGbRDtXJM0qEXpjcjYjzFJ2JzMfOBZ0WxAi6iaUd+82nAg5wvy377JrTStx/TJf9eXP3C2HHGLLtEtzugJblSzUSG8x8hYVnwOMVMNIvlFf4ef8LFVtYaB1L7D3oCWgPPShPSH7zsVFVtOy0so0SEhUuvoXY8N1guUT8wg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201527; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tvXSaU2PnAYagmnR84k/5v2USDAte/uH+f3lq1Gh+ek=; b=NaKT7K8SiR1ea1XngMvM09hx7iaZVc8Q3O9FhovV5I/iBV9vemTK6O+S6IPBFaV8Sfz61p3TGfcBLhjcD01FLyF2t3I8GNp0NEMHX74YWOOxfK+Hn0vQQ+/gJdwVLaCX0pBKyQ6Cp85d1LZdwmUnrkC7GeHK/LVZY46q1PrlHZw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201527563974.1183720163374; Wed, 4 Feb 2026 02:38:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBt-000225-EV; Wed, 04 Feb 2026 05:32:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBk-0001jx-Uk for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBi-00047t-ME for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:48 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-PZdsQoP5P3iQvIME8R8MRQ-1; Wed, 04 Feb 2026 05:32:42 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 974711800D8E; Wed, 4 Feb 2026 10:32:41 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 262C818003F6; Wed, 4 Feb 2026 10:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tvXSaU2PnAYagmnR84k/5v2USDAte/uH+f3lq1Gh+ek=; b=aOQ7rPr35/35ZuW5ImOlg8J43s6fszvCxNIMk++X0Qva9vXIlnZwL60px25I/qaugd7Bw9 l6vDLNrsnYJHnfW6zawQwZQzdsPUBBrA9d+wzn642THgwQVlUP7MT4GQyjwoBS4hnBprXp b422Zn6whIJEwXpA4w2yL8kyUnmB3uw= X-MC-Unique: PZdsQoP5P3iQvIME8R8MRQ-1 X-Mimecast-MFC-AGG-ID: PZdsQoP5P3iQvIME8R8MRQ_1770201161 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 29/45] hw/arm/aspeed: Integrate interrupt controller for AST1700 Date: Wed, 4 Feb 2026 11:31:20 +0100 Message-ID: <20260204103136.1795455-30-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201530713154100 From: Kane Chen Connect the AST1700 interrupt lines to the GIC in AST27X0, enabling the propagation of AST1700-originated interrupts to the host SoC. This patch does not implement interrupt sources in AST1700 itself, only the wiring into AST27X0. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-7-kane_chen= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_soc.h | 6 +++- include/hw/intc/aspeed_intc.h | 2 ++ hw/arm/aspeed_ast27x0.c | 37 +++++++++++++++++++++ hw/intc/aspeed_intc.c | 60 +++++++++++++++++++++++++++++++++++ 4 files changed, 104 insertions(+), 1 deletion(-) diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index f19bab3457ea..b051d0eb3a0a 100644 --- a/include/hw/arm/aspeed_soc.h +++ b/include/hw/arm/aspeed_soc.h @@ -58,6 +58,7 @@ #define ASPEED_UARTS_NUM 13 #define ASPEED_JTAG_NUM 2 #define ASPEED_PCIE_NUM 3 +#define ASPEED_INTC_NUM 2 #define ASPEED_IOEXP_NUM 2 =20 struct AspeedSoCState { @@ -146,7 +147,8 @@ struct Aspeed27x0SoCState { AspeedSoCState parent; =20 ARMCPU cpu[ASPEED_CPUS_NUM]; - AspeedINTCState intc[2]; + AspeedINTCState intc[ASPEED_INTC_NUM]; + AspeedINTCState intcioexp[ASPEED_IOEXP_NUM]; GICv3State gic; MemoryRegion dram_empty; }; @@ -288,6 +290,8 @@ enum { ASPEED_DEV_LTPI_CTRL2, ASPEED_DEV_LTPI_IO0, ASPEED_DEV_LTPI_IO1, + ASPEED_DEV_IOEXP0_INTCIO, + ASPEED_DEV_IOEXP1_INTCIO, }; =20 const char *aspeed_soc_cpu_type(const char * const *valid_cpu_types); diff --git a/include/hw/intc/aspeed_intc.h b/include/hw/intc/aspeed_intc.h index 5d10268fff32..b25ef4a464e5 100644 --- a/include/hw/intc/aspeed_intc.h +++ b/include/hw/intc/aspeed_intc.h @@ -15,6 +15,8 @@ #define TYPE_ASPEED_INTC "aspeed.intc" #define TYPE_ASPEED_2700_INTC TYPE_ASPEED_INTC "-ast2700" #define TYPE_ASPEED_2700_INTCIO TYPE_ASPEED_INTC "io-ast2700" +#define TYPE_ASPEED_2700_INTCIOEXP1 TYPE_ASPEED_INTC "-ast2700-ioexp1" +#define TYPE_ASPEED_2700_INTCIOEXP2 TYPE_ASPEED_INTC "-ast2700-ioexp2" #define TYPE_ASPEED_2700SSP_INTC TYPE_ASPEED_INTC "-ast2700ssp" #define TYPE_ASPEED_2700SSP_INTCIO TYPE_ASPEED_INTC "io-ast2700ssp" #define TYPE_ASPEED_2700TSP_INTC TYPE_ASPEED_INTC "-ast2700tsp" diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index a05112e2b040..d9866c2c3b23 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -91,7 +91,9 @@ static const hwaddr aspeed_soc_ast2700_memmap[] =3D { [ASPEED_DEV_LTPI_CTRL2] =3D 0x14C35000, [ASPEED_DEV_WDT] =3D 0x14C37000, [ASPEED_DEV_LTPI_IO0] =3D 0x30000000, + [ASPEED_DEV_IOEXP0_INTCIO] =3D 0x30C18000, [ASPEED_DEV_LTPI_IO1] =3D 0x50000000, + [ASPEED_DEV_IOEXP1_INTCIO] =3D 0x50C18000, [ASPEED_DEV_PCIE_MMIO0] =3D 0x60000000, [ASPEED_DEV_PCIE_MMIO1] =3D 0x80000000, [ASPEED_DEV_PCIE_MMIO2] =3D 0xA0000000, @@ -446,6 +448,10 @@ static void aspeed_soc_ast2700_init(Object *obj) object_initialize_child(obj, "intc", &a->intc[0], TYPE_ASPEED_2700_INT= C); object_initialize_child(obj, "intcio", &a->intc[1], TYPE_ASPEED_2700_INTCIO); + object_initialize_child(obj, "intc-ioexp0", &a->intcioexp[0], + TYPE_ASPEED_2700_INTCIOEXP1); + object_initialize_child(obj, "intc-ioexp1", &a->intcioexp[1], + TYPE_ASPEED_2700_INTCIOEXP2); =20 snprintf(typename, sizeof(typename), "aspeed.adc-%s", socname); object_initialize_child(obj, "adc", &s->adc, typename); @@ -690,6 +696,22 @@ static void aspeed_soc_ast2700_realize(DeviceState *de= v, Error **errp) aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(&a->intc[1]), 0, sc->memmap[ASPEED_DEV_INTCIO]); =20 + /* INTCIOEXP0 */ + if (!sysbus_realize(SYS_BUS_DEVICE(&a->intcioexp[0]), errp)) { + return; + } + + aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(&a->intcioexp[0]), 0, + sc->memmap[ASPEED_DEV_IOEXP0_INTCIO]); + + /* INTCIOEXP1 */ + if (!sysbus_realize(SYS_BUS_DEVICE(&a->intcioexp[1]), errp)) { + return; + } + + aspeed_mmio_map(s->memory, SYS_BUS_DEVICE(&a->intcioexp[1]), 0, + sc->memmap[ASPEED_DEV_IOEXP1_INTCIO]); + /* irq sources -> orgates -> INTC */ for (i =3D 0; i < ic->num_inpins; i++) { qdev_connect_gpio_out(DEVICE(&a->intc[0].orgates[i]), 0, @@ -1006,6 +1028,21 @@ static void aspeed_soc_ast2700_realize(DeviceState *= dev, Error **errp) } sysbus_mmio_map(SYS_BUS_DEVICE(&s->ioexp[i]), 0, sc->memmap[ASPEED_DEV_LTPI_IO0 + i]); + + icio =3D ASPEED_INTC_GET_CLASS(&a->intcioexp[i]); + /* INTC_IOEXP internal: orgate[i] -> input[i] */ + for (int j =3D 0; j < icio->num_inpins; j++) { + irq =3D qdev_get_gpio_in(DEVICE(&a->intcioexp[i]), j); + qdev_connect_gpio_out(DEVICE(&a->intcioexp[i].orgates[j]), 0, + irq); + } + + /* INTC_IOEXP output[i] -> INTC0.orgate[0].input[i] */ + for (int j =3D 0; j < icio->num_outpins; j++) { + irq =3D qdev_get_gpio_in(DEVICE(&a->intc[0].orgates[0]), j); + sysbus_connect_irq(SYS_BUS_DEVICE(&a->intcioexp[i]), j, + irq); + } } =20 aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->dpmcu), diff --git a/hw/intc/aspeed_intc.c b/hw/intc/aspeed_intc.c index 77fae3920584..52f2f946d59e 100644 --- a/hw/intc/aspeed_intc.c +++ b/hw/intc/aspeed_intc.c @@ -793,6 +793,64 @@ static const TypeInfo aspeed_2700_intc_info =3D { .class_init =3D aspeed_2700_intc_class_init, }; =20 +static AspeedINTCIRQ aspeed_2700_intcioexp2_irqs[ASPEED_INTC_MAX_INPINS] = =3D { + {0, 8, 1, R_GICINT192_EN, R_GICINT192_STATUS}, + {1, 9, 1, R_GICINT193_EN, R_GICINT193_STATUS}, +}; + +static void aspeed_2700_intcioexp2_class_init(ObjectClass *klass, + const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + AspeedINTCClass *aic =3D ASPEED_INTC_CLASS(klass); + + dc->desc =3D "ASPEED 2700 IOEXP2 INTC Controller"; + aic->num_lines =3D 32; + aic->num_inpins =3D 2; + aic->num_outpins =3D 10; + aic->mem_size =3D 0x400; + aic->nr_regs =3D 0x58 >> 2; + aic->reg_offset =3D 0x100; + aic->reg_ops =3D &aspeed_intcio_ops; + aic->irq_table =3D aspeed_2700_intcioexp2_irqs; + aic->irq_table_count =3D ARRAY_SIZE(aspeed_2700_intcioexp2_irqs); +} + +static const TypeInfo aspeed_2700_intcioexp2_info =3D { + .name =3D TYPE_ASPEED_2700_INTCIOEXP2, + .parent =3D TYPE_ASPEED_INTC, + .class_init =3D aspeed_2700_intcioexp2_class_init, +}; + +static AspeedINTCIRQ aspeed_2700_intcioexp1_irqs[ASPEED_INTC_MAX_INPINS] = =3D { + {0, 6, 1, R_GICINT192_EN, R_GICINT192_STATUS}, + {1, 7, 1, R_GICINT193_EN, R_GICINT193_STATUS}, +}; + +static void aspeed_2700_intcioexp1_class_init(ObjectClass *klass, + const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + AspeedINTCClass *aic =3D ASPEED_INTC_CLASS(klass); + + dc->desc =3D "ASPEED 2700 IOEXP1 INTC Controller"; + aic->num_lines =3D 32; + aic->num_inpins =3D 2; + aic->num_outpins =3D 10; + aic->mem_size =3D 0x400; + aic->nr_regs =3D 0x58 >> 2; + aic->reg_offset =3D 0x100; + aic->reg_ops =3D &aspeed_intcio_ops; + aic->irq_table =3D aspeed_2700_intcioexp1_irqs; + aic->irq_table_count =3D ARRAY_SIZE(aspeed_2700_intcioexp1_irqs); +} + +static const TypeInfo aspeed_2700_intcioexp1_info =3D { + .name =3D TYPE_ASPEED_2700_INTCIOEXP1, + .parent =3D TYPE_ASPEED_INTC, + .class_init =3D aspeed_2700_intcioexp1_class_init, +}; + static AspeedINTCIRQ aspeed_2700_intcio_irqs[ASPEED_INTC_MAX_INPINS] =3D { {0, 0, 1, R_GICINT192_EN, R_GICINT192_STATUS}, {1, 1, 1, R_GICINT193_EN, R_GICINT193_STATUS}, @@ -950,6 +1008,8 @@ static void aspeed_intc_register_types(void) type_register_static(&aspeed_intc_info); type_register_static(&aspeed_2700_intc_info); type_register_static(&aspeed_2700_intcio_info); + type_register_static(&aspeed_2700_intcioexp1_info); + type_register_static(&aspeed_2700_intcioexp2_info); type_register_static(&aspeed_2700ssp_intc_info); type_register_static(&aspeed_2700ssp_intcio_info); type_register_static(&aspeed_2700tsp_intc_info); --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201428; cv=none; d=zohomail.com; s=zohoarc; b=fQkTzflofkgRuVvvQZrBYAbnv5Pa3QsNAWCL69N7j4Bu7I0naxwmkFGROUQc620gq+enkVL347EAe4DkA4w+8O+QJRCDEihMDZGqQHGiA0mHUoB4SYZS5TpEH4m7sdbTCIHZt6bEsBOq19ah9QvVosIuQwnoBp1mbKr+nmRTY1I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201428; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Z6yRu03I1DUYDKWOh3MdB/nob0tCghHS4PP2N7JelkQ=; b=AEaEMIPLvemdmJL7b1SLyuusfO/QjBKh1swmr5Diotjl8UtMWUEm1hIsR1RwL6zS22E8PYuT2X5Xy3DiwBiLvIbcRK5Vs5v2g894o1yNAH5ak0JWHegS4RRGnI3ZhIuquZmjwj8N9DT634Zr5kuF4OOPvwqBk7e+SAYnGrGFUto= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201428680957.0080658482945; Wed, 4 Feb 2026 02:37:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBu-00025Q-Ar; Wed, 04 Feb 2026 05:32:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBm-0001oT-NL for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBk-00048N-MW for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:50 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-45-i0WMt3LjNi-1FMaDlcDYcw-1; Wed, 04 Feb 2026 05:32:44 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C11751800465; Wed, 4 Feb 2026 10:32:43 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 13935180066A; Wed, 4 Feb 2026 10:32:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z6yRu03I1DUYDKWOh3MdB/nob0tCghHS4PP2N7JelkQ=; b=IE9FhciGyKQQzsnlx3gZ2R28yJ26dLawkVlIUatjD5KVEwYyyDR/OhuEF3S620Yns8wF4G Xtty8e0x052mqhJjjYsPWnvNyFCQ6uritZJKYwn4Lr8dtUysrB5WC8lzaHkixBbymoHOnu 2A+PyPXvDtzakLNwE07hPUrU+hAyvqA= X-MC-Unique: i0WMt3LjNi-1FMaDlcDYcw-1 X-Mimecast-MFC-AGG-ID: i0WMt3LjNi-1FMaDlcDYcw_1770201163 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 30/45] hw/arm/aspeed: Attach LTPI controller to AST1700 model Date: Wed, 4 Feb 2026 11:31:21 +0100 Message-ID: <20260204103136.1795455-31-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201429160154100 From: Kane Chen Connect the LTPI controller to the AST1700 model by mapping its MMIO region. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-8-kane_chen= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 3 +++ hw/arm/aspeed_ast1700.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index 378dcb437a78..addea3ab1ff9 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -9,6 +9,7 @@ #define ASPEED_AST1700_H =20 #include "hw/core/sysbus.h" +#include "hw/misc/aspeed_ltpi.h" =20 #define TYPE_ASPEED_AST1700 "aspeed.ast1700" =20 @@ -18,6 +19,8 @@ struct AspeedAST1700SoCState { SysBusDevice parent_obj; =20 MemoryRegion iomem; + + AspeedLTPIState ltpi; }; =20 #endif /* ASPEED_AST1700_H */ diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index dd38b819b864..e4c8565d3f11 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -13,6 +13,14 @@ =20 #define AST2700_SOC_LTPI_SIZE 0x01000000 =20 +enum { + ASPEED_AST1700_DEV_LTPI_CTRL, +}; + +static const hwaddr aspeed_ast1700_io_memmap[] =3D { + [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, +}; + static void aspeed_ast1700_realize(DeviceState *dev, Error **errp) { AspeedAST1700SoCState *s =3D ASPEED_AST1700(dev); @@ -22,6 +30,25 @@ static void aspeed_ast1700_realize(DeviceState *dev, Err= or **errp) memory_region_init(&s->iomem, OBJECT(s), TYPE_ASPEED_AST1700, AST2700_SOC_LTPI_SIZE); sysbus_init_mmio(sbd, &s->iomem); + + /* LTPI controller */ + if (!sysbus_realize(SYS_BUS_DEVICE(&s->ltpi), errp)) { + return; + } + memory_region_add_subregion(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_LTPI_C= TRL], + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->ltpi), 0= )); +} + +static void aspeed_ast1700_instance_init(Object *obj) +{ + AspeedAST1700SoCState *s =3D ASPEED_AST1700(obj); + + /* LTPI controller */ + object_initialize_child(obj, "ltpi-ctrl", + &s->ltpi, TYPE_ASPEED_LTPI); + + return; } =20 static void aspeed_ast1700_class_init(ObjectClass *klass, const void *data) @@ -36,6 +63,7 @@ static const TypeInfo aspeed_ast1700_info =3D { .parent =3D TYPE_SYS_BUS_DEVICE, .instance_size =3D sizeof(AspeedAST1700SoCState), .class_init =3D aspeed_ast1700_class_init, + .instance_init =3D aspeed_ast1700_instance_init, }; =20 static void aspeed_ast1700_register_types(void) --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201321; cv=none; d=zohomail.com; s=zohoarc; b=C1W8a4SE0e9GhkUS43fo68nTwrJcyk4fOvUaF4yneuV6tpPxJ8IMGnt8kCYL8jwGuNmSV9+VSGm2KNFkTTHHPbpouoknGAMFlEfgW7YedXMq4a4JO5RbBE0eVeoE0I4MD38XyQfQMjiRtpiMwtzVRdGyD9nBkzz6tsAThcL1Noo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201321; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O7LbpKKJnFc6Yx5KDY/zCDsJtdLAHmcK6IzCMG61NPg=; b=cBmIoBplgdn2b75zhlJHNhk/sTBogRSTEcOR3JXMtz+/Yc7J5pRwt7leNCuGgTLdT2JZdMQeDnQ4r/qBTy4aPSPE5nlwtSLtrDDnGNTHZAmuWtg54nTxdmUDsP//jdFISWmwRwhemTjcASkFCNlbAIhWLYjMT6xSeBq2AsDkiCk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201321759836.1730992392561; Wed, 4 Feb 2026 02:35:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBu-00027p-UQ; Wed, 04 Feb 2026 05:32:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBm-0001oz-SH for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBk-00048S-W1 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:50 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-wMK64BwdPc28bVbr8pWcDg-1; Wed, 04 Feb 2026 05:32:47 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EB58319560B8; Wed, 4 Feb 2026 10:32:45 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3EEFC18004AD; Wed, 4 Feb 2026 10:32:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O7LbpKKJnFc6Yx5KDY/zCDsJtdLAHmcK6IzCMG61NPg=; b=X5iGtI/ZyDWkD5S623P+l0WOygPwAev3HYV7qDA2ClxmmW/Dv1fbRi4DBMOB5mZ3ENgdp8 0+hgxP37AULmDOCzzFSv/n9t+sVAtjiccSwnrZ82E5MPmPtKrXJoih2BpCaZlth87vJpx5 A6vdzHQppxOWmuLAoyX62xYd+/8vPKI= X-MC-Unique: wMK64BwdPc28bVbr8pWcDg-1 X-Mimecast-MFC-AGG-ID: wMK64BwdPc28bVbr8pWcDg_1770201166 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 31/45] hw/arm/aspeed: Attach UART device to AST1700 model Date: Wed, 4 Feb 2026 11:31:22 +0100 Message-ID: <20260204103136.1795455-32-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201322493158500 From: Kane Chen Connect the UART controller to the AST1700 model by mapping its MMIO region. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-9-kane_chen= @aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 2 ++ hw/arm/aspeed_ast1700.c | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index addea3ab1ff9..b15b13aedd3f 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -10,6 +10,7 @@ =20 #include "hw/core/sysbus.h" #include "hw/misc/aspeed_ltpi.h" +#include "hw/char/serial-mm.h" =20 #define TYPE_ASPEED_AST1700 "aspeed.ast1700" =20 @@ -21,6 +22,7 @@ struct AspeedAST1700SoCState { MemoryRegion iomem; =20 AspeedLTPIState ltpi; + SerialMM uart; }; =20 #endif /* ASPEED_AST1700_H */ diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index e4c8565d3f11..f610f259326c 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -9,15 +9,18 @@ #include "qemu/osdep.h" #include "hw/core/boards.h" #include "qom/object.h" +#include "hw/core/qdev-properties.h" #include "hw/arm/aspeed_ast1700.h" =20 #define AST2700_SOC_LTPI_SIZE 0x01000000 =20 enum { + ASPEED_AST1700_DEV_UART12, ASPEED_AST1700_DEV_LTPI_CTRL, }; =20 static const hwaddr aspeed_ast1700_io_memmap[] =3D { + [ASPEED_AST1700_DEV_UART12] =3D 0x00C33B00, [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, }; =20 @@ -31,6 +34,17 @@ static void aspeed_ast1700_realize(DeviceState *dev, Err= or **errp) AST2700_SOC_LTPI_SIZE); sysbus_init_mmio(sbd, &s->iomem); =20 + /* UART */ + qdev_prop_set_uint8(DEVICE(&s->uart), "regshift", 2); + qdev_prop_set_uint32(DEVICE(&s->uart), "baudbase", 38400); + qdev_prop_set_uint8(DEVICE(&s->uart), "endianness", DEVICE_LITTLE_ENDI= AN); + if (!sysbus_realize(SYS_BUS_DEVICE(&s->uart), errp)) { + return; + } + memory_region_add_subregion(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_UART12= ], + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->uart), 0= )); + /* LTPI controller */ if (!sysbus_realize(SYS_BUS_DEVICE(&s->ltpi), errp)) { return; @@ -44,6 +58,10 @@ static void aspeed_ast1700_instance_init(Object *obj) { AspeedAST1700SoCState *s =3D ASPEED_AST1700(obj); =20 + /* UART */ + object_initialize_child(obj, "uart", &s->uart, + TYPE_SERIAL_MM); + /* LTPI controller */ object_initialize_child(obj, "ltpi-ctrl", &s->ltpi, TYPE_ASPEED_LTPI); --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201337; cv=none; d=zohomail.com; s=zohoarc; b=g5iOcxnBWF+QUZSMNCU61h2ITeQnrvq5h3QAndEyzM+vz6fdmcIGvGWReolGvMnfp/RWbYp6V41198+owojZLU05/xhhQbDSZnaBYH33D5rdk5ViOgMU51oiO4qWJu8/4QnPUSg0NqN/YUW0cixd8/U9yvShdKX/fxQxD4/6lWg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201337; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wMZ8qmEUe8A2TekbLyV0QRh/wIEbtQpzG/Y38x9W5g8=; b=LiQzDjHokc7bcJqEGAioGlPao/MMgxU+0pwj+2hfiPx6qW4xeWOh6qYg6aiHIvGzwT6E3dauYEczt7+HDcwIiAxqNEBWUFB2fOca3Cbhw/SkeH3PVUBMu6OQ9E+k+TsMI9Xe27FN+fiEFFsDzJmCbBHvGM/f96tVbNJItn6jqfs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201337147753.2534434914725; Wed, 4 Feb 2026 02:35:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaBv-0002Ao-ND; Wed, 04 Feb 2026 05:32:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBt-00020X-1g for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBr-0004AE-7j for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:56 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-578-DaNuJ0WrOASMppgqcpxFCA-1; Wed, 04 Feb 2026 05:32:49 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3634018004BB; Wed, 4 Feb 2026 10:32:48 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6858D18003F6; Wed, 4 Feb 2026 10:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wMZ8qmEUe8A2TekbLyV0QRh/wIEbtQpzG/Y38x9W5g8=; b=esXCqfeTkxZK/Mp0+/XDJPGlEh7TO9J1XEUNmmjOmFKJqag92iOIzuOlDV5yIxkzBP663u X77hQxAS9+aNAzJ9JKF0xIJAaHDUODTDGU6rwTqMFjnKaMK8qJKLNnjCMEV7shcDw/uDkR hbAjSbPT63bLVkHhpHUFGHxfsYmg/tg= X-MC-Unique: DaNuJ0WrOASMppgqcpxFCA-1 X-Mimecast-MFC-AGG-ID: DaNuJ0WrOASMppgqcpxFCA_1770201168 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 32/45] hw/arm/aspeed: Attach SRAM device to AST1700 model Date: Wed, 4 Feb 2026 11:31:23 +0100 Message-ID: <20260204103136.1795455-33-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201339936154100 From: Kane Chen Map the SRAM device to AST1700 model Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-10-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 2 ++ hw/arm/aspeed_ast1700.c | 17 +++++++++++++++++ hw/arm/aspeed_ast27x0.c | 1 + 3 files changed, 20 insertions(+) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index b15b13aedd3f..a981bff3b268 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -20,9 +20,11 @@ struct AspeedAST1700SoCState { SysBusDevice parent_obj; =20 MemoryRegion iomem; + uint8_t board_idx; =20 AspeedLTPIState ltpi; SerialMM uart; + MemoryRegion sram; }; =20 #endif /* ASPEED_AST1700_H */ diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index f610f259326c..fd5db3268e75 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -13,13 +13,16 @@ #include "hw/arm/aspeed_ast1700.h" =20 #define AST2700_SOC_LTPI_SIZE 0x01000000 +#define AST1700_SOC_SRAM_SIZE 0x00040000 =20 enum { + ASPEED_AST1700_DEV_SRAM, ASPEED_AST1700_DEV_UART12, ASPEED_AST1700_DEV_LTPI_CTRL, }; =20 static const hwaddr aspeed_ast1700_io_memmap[] =3D { + [ASPEED_AST1700_DEV_SRAM] =3D 0x00BC0000, [ASPEED_AST1700_DEV_UART12] =3D 0x00C33B00, [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, }; @@ -28,12 +31,21 @@ static void aspeed_ast1700_realize(DeviceState *dev, Er= ror **errp) { AspeedAST1700SoCState *s =3D ASPEED_AST1700(dev); SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); + char dev_name[32]; =20 /* Occupy memory space for all controllers in AST1700 */ memory_region_init(&s->iomem, OBJECT(s), TYPE_ASPEED_AST1700, AST2700_SOC_LTPI_SIZE); sysbus_init_mmio(sbd, &s->iomem); =20 + /* SRAM */ + snprintf(dev_name, sizeof(dev_name), "aspeed.ioexp-sram.%d", s->board_= idx); + memory_region_init_ram(&s->sram, OBJECT(s), dev_name, + AST1700_SOC_SRAM_SIZE, errp); + memory_region_add_subregion(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SR= AM], + &s->sram); + /* UART */ qdev_prop_set_uint8(DEVICE(&s->uart), "regshift", 2); qdev_prop_set_uint32(DEVICE(&s->uart), "baudbase", 38400); @@ -69,11 +81,16 @@ static void aspeed_ast1700_instance_init(Object *obj) return; } =20 +static const Property aspeed_ast1700_props[] =3D { + DEFINE_PROP_UINT8("board-idx", AspeedAST1700SoCState, board_idx, 0), +}; + static void aspeed_ast1700_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D aspeed_ast1700_realize; + device_class_set_props(dc, aspeed_ast1700_props); } =20 static const TypeInfo aspeed_ast1700_info =3D { diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index d9866c2c3b23..6a144742ead6 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -1023,6 +1023,7 @@ static void aspeed_soc_ast2700_realize(DeviceState *d= ev, Error **errp) =20 /* IO Expander */ for (i =3D 0; i < sc->ioexp_num; i++) { + qdev_prop_set_uint8(DEVICE(&s->ioexp[i]), "board-idx", i); if (!sysbus_realize(SYS_BUS_DEVICE(&s->ioexp[i]), errp)) { return; } --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201252; cv=none; d=zohomail.com; s=zohoarc; b=PAHy7oxRDnPsQWpYRHVkSXcdxFcO2nc5ox9C2tWPUo88ez6hUvxQOGLwFLLx3R7aa8fH7p4pqxhVkBzJ0Me5OgcaCq6ODWqK4RoCXopmfWT1rdA9T7XK8EZBEsGXvc/iZgRFDNwFaGo294PtWi+mm5qJyHS8FdSyhjkHnDtqWYQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201252; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mDcF54dbpi1uatfvjlM36mQUh0PyyenaadXDPuNJYVo=; b=Jcc62l/uaTODrjAWttzTD1gVUwF92X64o795DuKNNnqhRG19Aa4jvGhyoHQpKO0n91lLLghpBIRz8AW6rg7hzH7eIbSFnjEMCb3yW5hwjV0UppTRawvCivFq7eBVXdi/xIGmoTMzsTZLLnpimlPoqBD/98pvdpM78YpoRkj4L14= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201252964785.2396221744148; Wed, 4 Feb 2026 02:34:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaC3-0002K5-Hv; Wed, 04 Feb 2026 05:33:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBu-00027H-Of for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBr-0004A7-7v for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:58 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-5b7tRKfVMn-KHL5WlkQ_kw-1; Wed, 04 Feb 2026 05:32:51 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3E5DF180025B; Wed, 4 Feb 2026 10:32:50 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A8F7318003F6; Wed, 4 Feb 2026 10:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mDcF54dbpi1uatfvjlM36mQUh0PyyenaadXDPuNJYVo=; b=G4UY7IbsJOj15WBMxmmpZDXOZ6ZZ2I/PIbbpM7rV4pVET+LX4GjsCD2DWd6gBo5HNhrK+4 OKUpS2TnAePTPr3MWar/CtGtT2b9jIYUgC73rh0BvomXcHY44PjMqAB5y9ncrjFOQnCaXs K2Q/7ot2FHsKJbn9d8K/ZBphpUUHD5Q= X-MC-Unique: 5b7tRKfVMn-KHL5WlkQ_kw-1 X-Mimecast-MFC-AGG-ID: 5b7tRKfVMn-KHL5WlkQ_kw_1770201170 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 33/45] hw/arm/aspeed: Attach SPI device to AST1700 model Date: Wed, 4 Feb 2026 11:31:24 +0100 Message-ID: <20260204103136.1795455-34-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201254212158500 From: Kane Chen Connect the SPI device to AST1700 model. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-11-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 3 +++ hw/arm/aspeed_ast1700.c | 30 ++++++++++++++++++++++++++++++ hw/arm/aspeed_ast27x0.c | 2 ++ 3 files changed, 35 insertions(+) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index a981bff3b268..89562eb64f60 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -10,6 +10,7 @@ =20 #include "hw/core/sysbus.h" #include "hw/misc/aspeed_ltpi.h" +#include "hw/ssi/aspeed_smc.h" #include "hw/char/serial-mm.h" =20 #define TYPE_ASPEED_AST1700 "aspeed.ast1700" @@ -20,11 +21,13 @@ struct AspeedAST1700SoCState { SysBusDevice parent_obj; =20 MemoryRegion iomem; + MemoryRegion *dram_mr; uint8_t board_idx; =20 AspeedLTPIState ltpi; SerialMM uart; MemoryRegion sram; + AspeedSMCState spi; }; =20 #endif /* ASPEED_AST1700_H */ diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index fd5db3268e75..97990688f8d3 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -9,6 +9,7 @@ #include "qemu/osdep.h" #include "hw/core/boards.h" #include "qom/object.h" +#include "qapi/error.h" #include "hw/core/qdev-properties.h" #include "hw/arm/aspeed_ast1700.h" =20 @@ -16,15 +17,19 @@ #define AST1700_SOC_SRAM_SIZE 0x00040000 =20 enum { + ASPEED_AST1700_DEV_SPI0, ASPEED_AST1700_DEV_SRAM, ASPEED_AST1700_DEV_UART12, ASPEED_AST1700_DEV_LTPI_CTRL, + ASPEED_AST1700_DEV_SPI0_MEM, }; =20 static const hwaddr aspeed_ast1700_io_memmap[] =3D { + [ASPEED_AST1700_DEV_SPI0] =3D 0x00030000, [ASPEED_AST1700_DEV_SRAM] =3D 0x00BC0000, [ASPEED_AST1700_DEV_UART12] =3D 0x00C33B00, [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, + [ASPEED_AST1700_DEV_SPI0_MEM] =3D 0x04000000, }; =20 static void aspeed_ast1700_realize(DeviceState *dev, Error **errp) @@ -33,6 +38,11 @@ static void aspeed_ast1700_realize(DeviceState *dev, Err= or **errp) SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); char dev_name[32]; =20 + if (!s->dram_mr) { + error_setg(errp, TYPE_ASPEED_AST1700 ": 'dram' link not set"); + return; + } + /* Occupy memory space for all controllers in AST1700 */ memory_region_init(&s->iomem, OBJECT(s), TYPE_ASPEED_AST1700, AST2700_SOC_LTPI_SIZE); @@ -57,6 +67,20 @@ static void aspeed_ast1700_realize(DeviceState *dev, Err= or **errp) aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_UART12= ], sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->uart), 0= )); =20 + /* SPI */ + object_property_set_link(OBJECT(&s->spi), "dram", + OBJECT(s->dram_mr), errp); + if (!sysbus_realize(SYS_BUS_DEVICE(&s->spi), errp)) { + return; + } + memory_region_add_subregion(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SPI0], + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->spi), 0)= ); + + memory_region_add_subregion(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SPI0_M= EM], + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->spi), 1)= ); + /* LTPI controller */ if (!sysbus_realize(SYS_BUS_DEVICE(&s->ltpi), errp)) { return; @@ -74,6 +98,10 @@ static void aspeed_ast1700_instance_init(Object *obj) object_initialize_child(obj, "uart", &s->uart, TYPE_SERIAL_MM); =20 + /* SPI */ + object_initialize_child(obj, "ioexp-spi", &s->spi, + "aspeed.spi0-ast2700"); + /* LTPI controller */ object_initialize_child(obj, "ltpi-ctrl", &s->ltpi, TYPE_ASPEED_LTPI); @@ -83,6 +111,8 @@ static void aspeed_ast1700_instance_init(Object *obj) =20 static const Property aspeed_ast1700_props[] =3D { DEFINE_PROP_UINT8("board-idx", AspeedAST1700SoCState, board_idx, 0), + DEFINE_PROP_LINK("dram", AspeedAST1700SoCState, dram_mr, + TYPE_MEMORY_REGION, MemoryRegion *), }; =20 static void aspeed_ast1700_class_init(ObjectClass *klass, const void *data) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 6a144742ead6..2fc50af8b420 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -1024,6 +1024,8 @@ static void aspeed_soc_ast2700_realize(DeviceState *d= ev, Error **errp) /* IO Expander */ for (i =3D 0; i < sc->ioexp_num; i++) { qdev_prop_set_uint8(DEVICE(&s->ioexp[i]), "board-idx", i); + object_property_set_link(OBJECT(&s->ioexp[i]), "dram", + OBJECT(s->dram_mr), &error_abort); if (!sysbus_realize(SYS_BUS_DEVICE(&s->ioexp[i]), errp)) { return; } --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201212; cv=none; d=zohomail.com; s=zohoarc; b=WAdxu85QnF1Ia0EpVGhkLXbv4LaQdmJJiBntDyEUQb7N8rCK+FCiPF1u+6Pwki3FYzX/UizalCijjU3PlpQIQ/K6OwtXHo1lOZYvSMG423zeLnh94WH2hc8SiBe8N0/Uw/7CkvEev6zi3CO8Y29ploqZ4tbIV0Rq8Rq/MajF6u0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201212; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XIHPbyKpMNe8QiAYNZh2zNhYLeE5l5gjEoBwihMrgx0=; b=j5hOxdZZxvk8OdggW8j9SMOK1/rIMT/ryPjyeq0wfMTg0nbSIlskBJk73jcqrh8/q3hUQ+VEitLfcfdhpzpJtqm+0v2ZARzctPGE0l25KGADo8+n2SohtaUl5rK4kUF3AhgBaUHSx1mK+qfVrf878dCqKELN8QZoBHi8mJP4SWY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201212949100.8904018503755; Wed, 4 Feb 2026 02:33:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCC-0002iC-Pj; Wed, 04 Feb 2026 05:33:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBu-000282-R9 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBr-0004AM-AY for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:32:58 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-bksriybdOJS5p7mQjK2SeQ-1; Wed, 04 Feb 2026 05:32:53 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 67F3019560B7; Wed, 4 Feb 2026 10:32:52 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B013118003F6; Wed, 4 Feb 2026 10:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XIHPbyKpMNe8QiAYNZh2zNhYLeE5l5gjEoBwihMrgx0=; b=gFdElQ1LyvYqbfNWSJE71b3yjppOtHOAE4z7JtG+LZwD9ZxXkTvOs6PGE3BM9i13MrXMwb z0mAlM9fTvzvwEU4fSTbQWXFSmu2AKvsAX+I3fe24T9dOfne9zcgakn1xYYtLSn949hnai /JuZC/RiVqBpmBcOhsERpKvRaetNRT0= X-MC-Unique: bksriybdOJS5p7mQjK2SeQ-1 X-Mimecast-MFC-AGG-ID: bksriybdOJS5p7mQjK2SeQ_1770201172 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 34/45] hw/arm/aspeed: Attach ADC device to AST1700 model Date: Wed, 4 Feb 2026 11:31:25 +0100 Message-ID: <20260204103136.1795455-35-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201214141158500 From: Kane Chen Connect the ADC device to AST1700 model. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-12-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 2 ++ hw/arm/aspeed_ast1700.c | 14 ++++++++++++++ hw/arm/aspeed_ast27x0.c | 5 +++++ 3 files changed, 21 insertions(+) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index 89562eb64f60..441655cee7f4 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -9,6 +9,7 @@ #define ASPEED_AST1700_H =20 #include "hw/core/sysbus.h" +#include "hw/adc/aspeed_adc.h" #include "hw/misc/aspeed_ltpi.h" #include "hw/ssi/aspeed_smc.h" #include "hw/char/serial-mm.h" @@ -28,6 +29,7 @@ struct AspeedAST1700SoCState { SerialMM uart; MemoryRegion sram; AspeedSMCState spi; + AspeedADCState adc; }; =20 #endif /* ASPEED_AST1700_H */ diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index 97990688f8d3..17577ebb5abb 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -19,6 +19,7 @@ enum { ASPEED_AST1700_DEV_SPI0, ASPEED_AST1700_DEV_SRAM, + ASPEED_AST1700_DEV_ADC, ASPEED_AST1700_DEV_UART12, ASPEED_AST1700_DEV_LTPI_CTRL, ASPEED_AST1700_DEV_SPI0_MEM, @@ -27,6 +28,7 @@ enum { static const hwaddr aspeed_ast1700_io_memmap[] =3D { [ASPEED_AST1700_DEV_SPI0] =3D 0x00030000, [ASPEED_AST1700_DEV_SRAM] =3D 0x00BC0000, + [ASPEED_AST1700_DEV_ADC] =3D 0x00C00000, [ASPEED_AST1700_DEV_UART12] =3D 0x00C33B00, [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, [ASPEED_AST1700_DEV_SPI0_MEM] =3D 0x04000000, @@ -81,6 +83,14 @@ static void aspeed_ast1700_realize(DeviceState *dev, Err= or **errp) aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SPI0_M= EM], sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->spi), 1)= ); =20 + /* ADC */ + if (!sysbus_realize(SYS_BUS_DEVICE(&s->adc), errp)) { + return; + } + memory_region_add_subregion(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_ADC], + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->adc), 0)= ); + /* LTPI controller */ if (!sysbus_realize(SYS_BUS_DEVICE(&s->ltpi), errp)) { return; @@ -102,6 +112,10 @@ static void aspeed_ast1700_instance_init(Object *obj) object_initialize_child(obj, "ioexp-spi", &s->spi, "aspeed.spi0-ast2700"); =20 + /* ADC */ + object_initialize_child(obj, "ioexp-adc", &s->adc, + "aspeed.adc-ast2700"); + /* LTPI controller */ object_initialize_child(obj, "ltpi-ctrl", &s->ltpi, TYPE_ASPEED_LTPI); diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 2fc50af8b420..5086d4c51e78 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -1046,6 +1046,11 @@ static void aspeed_soc_ast2700_realize(DeviceState *= dev, Error **errp) sysbus_connect_irq(SYS_BUS_DEVICE(&a->intcioexp[i]), j, irq); } + + /* ADC */ + sysbus_connect_irq(SYS_BUS_DEVICE(&s->ioexp[i].adc), 0, + aspeed_soc_ast2700_get_irq(s, ASPEED_DEV_ADC)); + } =20 aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->dpmcu), --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201212; cv=none; d=zohomail.com; s=zohoarc; b=FZtBRzPfmdsO/v6xa/m1vPLWRplxEwwH+4/2tvcGXUwiJ989wZRfY1pt5olzIEoDPzQnpcJyWKt7ubPvHHB+gg344ocXbF3cDFO+wmKASMRMQl6WSeJ01UdKmuoSePTgBIpBybDkIMggLVPZxbE5MSG4oIfEHTPi00wdzyUtIMM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201212; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=s5Zt4kq1Rbo65KukWUB+qJa4ama9kUOaYpuUA/RI8I0=; b=XHiU5zBWIAbYYOrqOQuT6iF2k6604Y868uh2oGJwpAL++nLvhnKwIlPIKA0goKrFFA+vgMRPv+v6zpwy/BexaGr74dP3bl7SGi/xo5J32G723ntXupx48ty5l+KX+tJD2MiRnppGfE85dPOelbGiw53nl+32/Xi2jNjWV0VHvZM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177020121234856.66975606447261; Wed, 4 Feb 2026 02:33:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCB-0002ha-Gc; Wed, 04 Feb 2026 05:33:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaC0-0002J6-QW for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBv-0004BA-FQ for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:04 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-435-L5ApvZNeP7-o-VTFmYGDnw-1; Wed, 04 Feb 2026 05:32:55 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9074A19560BA; Wed, 4 Feb 2026 10:32:54 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D8AFF18003F6; Wed, 4 Feb 2026 10:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s5Zt4kq1Rbo65KukWUB+qJa4ama9kUOaYpuUA/RI8I0=; b=UUbpEO5/pMtOhN2y70CIqW1tcqe4sh1GWhZrZzNhymNHglI4bMuCvaByZjacISMEAU3uJk ogd7Tzz2fjNrovDJC+162kmCNhvely5mRcF5Ue0QIc07qrbamqrkajVVPk4WtFZs0IHaZq /AUyS8Tkl6kqA9qLlB/1TSo5B/zjEJM= X-MC-Unique: L5ApvZNeP7-o-VTFmYGDnw-1 X-Mimecast-MFC-AGG-ID: L5ApvZNeP7-o-VTFmYGDnw_1770201174 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 35/45] hw/arm/aspeed: Attach SCU device to AST1700 model Date: Wed, 4 Feb 2026 11:31:26 +0100 Message-ID: <20260204103136.1795455-36-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201213959154100 From: Kane Chen Connect the SCU device to AST1700 model. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-13-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 3 +++ hw/arm/aspeed_ast1700.c | 17 +++++++++++++++++ hw/arm/aspeed_ast27x0.c | 2 ++ 3 files changed, 22 insertions(+) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index 441655cee7f4..65f1497a2ddc 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -9,6 +9,7 @@ #define ASPEED_AST1700_H =20 #include "hw/core/sysbus.h" +#include "hw/misc/aspeed_scu.h" #include "hw/adc/aspeed_adc.h" #include "hw/misc/aspeed_ltpi.h" #include "hw/ssi/aspeed_smc.h" @@ -24,12 +25,14 @@ struct AspeedAST1700SoCState { MemoryRegion iomem; MemoryRegion *dram_mr; uint8_t board_idx; + uint32_t silicon_rev; =20 AspeedLTPIState ltpi; SerialMM uart; MemoryRegion sram; AspeedSMCState spi; AspeedADCState adc; + AspeedSCUState scu; }; =20 #endif /* ASPEED_AST1700_H */ diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index 17577ebb5abb..49a242f3dec6 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -20,6 +20,7 @@ enum { ASPEED_AST1700_DEV_SPI0, ASPEED_AST1700_DEV_SRAM, ASPEED_AST1700_DEV_ADC, + ASPEED_AST1700_DEV_SCU, ASPEED_AST1700_DEV_UART12, ASPEED_AST1700_DEV_LTPI_CTRL, ASPEED_AST1700_DEV_SPI0_MEM, @@ -29,6 +30,7 @@ static const hwaddr aspeed_ast1700_io_memmap[] =3D { [ASPEED_AST1700_DEV_SPI0] =3D 0x00030000, [ASPEED_AST1700_DEV_SRAM] =3D 0x00BC0000, [ASPEED_AST1700_DEV_ADC] =3D 0x00C00000, + [ASPEED_AST1700_DEV_SCU] =3D 0x00C02000, [ASPEED_AST1700_DEV_UART12] =3D 0x00C33B00, [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, [ASPEED_AST1700_DEV_SPI0_MEM] =3D 0x04000000, @@ -91,6 +93,16 @@ static void aspeed_ast1700_realize(DeviceState *dev, Err= or **errp) aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_ADC], sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->adc), 0)= ); =20 + /* SCU */ + qdev_prop_set_uint32(DEVICE(&s->scu), "silicon-rev", + s->silicon_rev); + if (!sysbus_realize(SYS_BUS_DEVICE(&s->scu), errp)) { + return; + } + memory_region_add_subregion(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SCU], + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->scu), 0)= ); + /* LTPI controller */ if (!sysbus_realize(SYS_BUS_DEVICE(&s->ltpi), errp)) { return; @@ -116,6 +128,10 @@ static void aspeed_ast1700_instance_init(Object *obj) object_initialize_child(obj, "ioexp-adc", &s->adc, "aspeed.adc-ast2700"); =20 + /* SCU */ + object_initialize_child(obj, "ioexp-scu", &s->scu, + TYPE_ASPEED_2700_SCU); + /* LTPI controller */ object_initialize_child(obj, "ltpi-ctrl", &s->ltpi, TYPE_ASPEED_LTPI); @@ -125,6 +141,7 @@ static void aspeed_ast1700_instance_init(Object *obj) =20 static const Property aspeed_ast1700_props[] =3D { DEFINE_PROP_UINT8("board-idx", AspeedAST1700SoCState, board_idx, 0), + DEFINE_PROP_UINT32("silicon-rev", AspeedAST1700SoCState, silicon_rev, = 0), DEFINE_PROP_LINK("dram", AspeedAST1700SoCState, dram_mr, TYPE_MEMORY_REGION, MemoryRegion *), }; diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 5086d4c51e78..cda841e1031d 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -508,6 +508,8 @@ static void aspeed_soc_ast2700_init(Object *obj) /* AST1700 IOEXP */ object_initialize_child(obj, "ioexp[*]", &s->ioexp[i], TYPE_ASPEED_AST1700); + qdev_prop_set_uint32(DEVICE(&s->ioexp[i]), "silicon-rev", + sc->silicon_rev); } =20 object_initialize_child(obj, "dpmcu", &s->dpmcu, --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201500; cv=none; d=zohomail.com; s=zohoarc; b=c3+f1H0MkbgeOXAJGfh+Q3IJwUehbCGDhPP6JzMDtELq77O33FJVYboYzdLxWg8OcHBSNsjIgm0x1J4rp4qfVhfKpyM1Zzo1wCWzqu3SFQMD2WNrL6qirnV/ZMqWgP7X95guaKfT60kYmtR6GTdpXLrWlEGCVgyfbpDmj0pBqCE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201500; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wXOexuxGpnBN0gmCdkkT3Sk5Nl/k822TWJfteQ52foQ=; b=WHLxM79xNYwafBeZz6/Ly74f22tcnQS+LQsd0c1bUPJYgzWAqIgCj38/fq8TIKonqUDFyC2ORQMQYTh5o6uCVCLrlchgt6AumE/0IS9X65aQN8z3ymV3zdm9UntfgDrgLX7U6t028JvQ9a073WUDkwZ+6Rdt7Scs+MqcBrRn5Wk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17702015006681012.6390300152293; Wed, 4 Feb 2026 02:38:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCa-0003Vd-3z; Wed, 04 Feb 2026 05:33:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaC1-0002J7-7f for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBz-0004Bx-N5 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:04 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-501-0rQGgFkWO-eXqzyQiiKJ_w-1; Wed, 04 Feb 2026 05:32:57 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BB51D1800259; Wed, 4 Feb 2026 10:32:56 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0E85218003F6; Wed, 4 Feb 2026 10:32:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wXOexuxGpnBN0gmCdkkT3Sk5Nl/k822TWJfteQ52foQ=; b=QOG+fBWgMyfTIm6AaopO3RDqSluZMFGductYAhdAFl6xR2ch64AuuF4q5vges/ScVb6tW6 V/9c1bM02qDuIm5r2ewTXjm8CHpKTD4WyvQ5zzR+9OSxzm7dMcb/NfZekOIILYCf5GbTKH xtn3T/yj4fV6kcXua+1ragrcwmttz0Y= X-MC-Unique: 0rQGgFkWO-eXqzyQiiKJ_w-1 X-Mimecast-MFC-AGG-ID: 0rQGgFkWO-eXqzyQiiKJ_w_1770201176 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 36/45] hw/arm/aspeed: Attach GPIO device to AST1700 model Date: Wed, 4 Feb 2026 11:31:27 +0100 Message-ID: <20260204103136.1795455-37-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201509353158501 From: Kane Chen Connect the GPIO controller to the AST1700 model by mapping its MMIO region and wiring its interrupt line. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-14-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 2 ++ hw/arm/aspeed_ast1700.c | 14 ++++++++++++++ hw/arm/aspeed_ast27x0.c | 4 ++++ 3 files changed, 20 insertions(+) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index 65f1497a2ddc..63cfcb4c245a 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -11,6 +11,7 @@ #include "hw/core/sysbus.h" #include "hw/misc/aspeed_scu.h" #include "hw/adc/aspeed_adc.h" +#include "hw/gpio/aspeed_gpio.h" #include "hw/misc/aspeed_ltpi.h" #include "hw/ssi/aspeed_smc.h" #include "hw/char/serial-mm.h" @@ -33,6 +34,7 @@ struct AspeedAST1700SoCState { AspeedSMCState spi; AspeedADCState adc; AspeedSCUState scu; + AspeedGPIOState gpio; }; =20 #endif /* ASPEED_AST1700_H */ diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index 49a242f3dec6..7efce450f60f 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -21,6 +21,7 @@ enum { ASPEED_AST1700_DEV_SRAM, ASPEED_AST1700_DEV_ADC, ASPEED_AST1700_DEV_SCU, + ASPEED_AST1700_DEV_GPIO, ASPEED_AST1700_DEV_UART12, ASPEED_AST1700_DEV_LTPI_CTRL, ASPEED_AST1700_DEV_SPI0_MEM, @@ -31,6 +32,7 @@ static const hwaddr aspeed_ast1700_io_memmap[] =3D { [ASPEED_AST1700_DEV_SRAM] =3D 0x00BC0000, [ASPEED_AST1700_DEV_ADC] =3D 0x00C00000, [ASPEED_AST1700_DEV_SCU] =3D 0x00C02000, + [ASPEED_AST1700_DEV_GPIO] =3D 0x00C0B000, [ASPEED_AST1700_DEV_UART12] =3D 0x00C33B00, [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, [ASPEED_AST1700_DEV_SPI0_MEM] =3D 0x04000000, @@ -103,6 +105,14 @@ static void aspeed_ast1700_realize(DeviceState *dev, E= rror **errp) aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SCU], sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->scu), 0)= ); =20 + /* GPIO */ + if (!sysbus_realize(SYS_BUS_DEVICE(&s->gpio), errp)) { + return; + } + memory_region_add_subregion(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_GPIO], + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->gpio), 0= )); + /* LTPI controller */ if (!sysbus_realize(SYS_BUS_DEVICE(&s->ltpi), errp)) { return; @@ -132,6 +142,10 @@ static void aspeed_ast1700_instance_init(Object *obj) object_initialize_child(obj, "ioexp-scu", &s->scu, TYPE_ASPEED_2700_SCU); =20 + /* GPIO */ + object_initialize_child(obj, "ioexp-gpio", &s->gpio, + "aspeed.gpio-ast2700"); + /* LTPI controller */ object_initialize_child(obj, "ltpi-ctrl", &s->ltpi, TYPE_ASPEED_LTPI); diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index cda841e1031d..cd4028fcd4c7 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -1053,6 +1053,10 @@ static void aspeed_soc_ast2700_realize(DeviceState *= dev, Error **errp) sysbus_connect_irq(SYS_BUS_DEVICE(&s->ioexp[i].adc), 0, aspeed_soc_ast2700_get_irq(s, ASPEED_DEV_ADC)); =20 + /* GPIO */ + sysbus_connect_irq(SYS_BUS_DEVICE(&s->ioexp[i].gpio), 0, + aspeed_soc_ast2700_get_irq(s, ASPEED_DEV_GPIO)); + } =20 aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->dpmcu), --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201432; cv=none; d=zohomail.com; s=zohoarc; b=AMCNauHIGa6EmL3EI9Vjq9NRf+jVEpGNVKHEVviPipfqHfCZwDdJccFNYgk3j7hKVMk/qYpPd8WqFSWhVq/R1b1DH+YFh0ZfvhkLmqPOWkWqXcxlX0yvED+8YdogEOWaqk24Yn9rRaCYBPAb7d7nOV2nOzbReUreYo0EWcx3RGM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201432; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=x0rFcvwj4yKk1qff0VXoGxN4bPKszZ5E/TLKHC096Hs=; b=TrLszV4hysQofD7803OKGbaoYjnQdnt5RT4/O4/z5RvCj8fm51z5Dj1VE6aA50g/O+19T0iTXYHpxHg35lCA4wAinNW0D8hsFGzhAApGbTkzh9Loklo9/neINjy8D1Y+L83xdS6RtjXrRI+RSKn6/emlxzpzZ3N6FGROgW1liuE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201432906208.64504551167613; Wed, 4 Feb 2026 02:37:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCU-0003JN-3s; Wed, 04 Feb 2026 05:33:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBz-0002J1-IV for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaBx-0004Bg-K5 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:03 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-zRiSc9CsMFODM1aTFPE50g-1; Wed, 04 Feb 2026 05:32:59 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AC90719560A7; Wed, 4 Feb 2026 10:32:58 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 38A1618003F6; Wed, 4 Feb 2026 10:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x0rFcvwj4yKk1qff0VXoGxN4bPKszZ5E/TLKHC096Hs=; b=Q5B9du0IDLQ5aQbGPbbU5xJk7eiMmTggYCo3QibVYjnC2hPAO0JIwIA6hD6AoKIdj2Vioz V03Nzx4rFm/E6+g5Mdzi9+HPuJDAETOhVrJgJpBJga4LuayRSkeoUBmDhE2f22/PlFXAIQ 7CvOdvJbEYKqn6fuhq6mUS6/bHnQUAY= X-MC-Unique: zRiSc9CsMFODM1aTFPE50g-1 X-Mimecast-MFC-AGG-ID: zRiSc9CsMFODM1aTFPE50g_1770201178 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 37/45] hw/arm/aspeed: attach I2C device to AST1700 model Date: Wed, 4 Feb 2026 11:31:28 +0100 Message-ID: <20260204103136.1795455-38-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201435250154100 From: Kane Chen Connect the I2C controller to the AST1700 model by mapping its MMIO region and wiring its interrupt line. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-15-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 2 ++ include/hw/arm/aspeed_soc.h | 2 ++ hw/arm/aspeed_ast1700.c | 19 ++++++++++++ hw/arm/aspeed_ast27x0.c | 51 +++++++++++++++++++++++++++++++-- 4 files changed, 71 insertions(+), 3 deletions(-) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index 63cfcb4c245a..1005ce63645f 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -12,6 +12,7 @@ #include "hw/misc/aspeed_scu.h" #include "hw/adc/aspeed_adc.h" #include "hw/gpio/aspeed_gpio.h" +#include "hw/i2c/aspeed_i2c.h" #include "hw/misc/aspeed_ltpi.h" #include "hw/ssi/aspeed_smc.h" #include "hw/char/serial-mm.h" @@ -35,6 +36,7 @@ struct AspeedAST1700SoCState { AspeedADCState adc; AspeedSCUState scu; AspeedGPIOState gpio; + AspeedI2CState i2c; }; =20 #endif /* ASPEED_AST1700_H */ diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index b051d0eb3a0a..4ea252104137 100644 --- a/include/hw/arm/aspeed_soc.h +++ b/include/hw/arm/aspeed_soc.h @@ -290,6 +290,8 @@ enum { ASPEED_DEV_LTPI_CTRL2, ASPEED_DEV_LTPI_IO0, ASPEED_DEV_LTPI_IO1, + ASPEED_DEV_IOEXP0_I2C, + ASPEED_DEV_IOEXP1_I2C, ASPEED_DEV_IOEXP0_INTCIO, ASPEED_DEV_IOEXP1_INTCIO, }; diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index 7efce450f60f..e264b2200bc3 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -22,6 +22,7 @@ enum { ASPEED_AST1700_DEV_ADC, ASPEED_AST1700_DEV_SCU, ASPEED_AST1700_DEV_GPIO, + ASPEED_AST1700_DEV_I2C, ASPEED_AST1700_DEV_UART12, ASPEED_AST1700_DEV_LTPI_CTRL, ASPEED_AST1700_DEV_SPI0_MEM, @@ -33,6 +34,7 @@ static const hwaddr aspeed_ast1700_io_memmap[] =3D { [ASPEED_AST1700_DEV_ADC] =3D 0x00C00000, [ASPEED_AST1700_DEV_SCU] =3D 0x00C02000, [ASPEED_AST1700_DEV_GPIO] =3D 0x00C0B000, + [ASPEED_AST1700_DEV_I2C] =3D 0x00C0F000, [ASPEED_AST1700_DEV_UART12] =3D 0x00C33B00, [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, [ASPEED_AST1700_DEV_SPI0_MEM] =3D 0x04000000, @@ -113,6 +115,19 @@ static void aspeed_ast1700_realize(DeviceState *dev, E= rror **errp) aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_GPIO], sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->gpio), 0= )); =20 + /* I2C */ + snprintf(dev_name, sizeof(dev_name), "ioexp%d", s->board_idx); + qdev_prop_set_string(DEVICE(&s->i2c), "bus-label", dev_name); + + object_property_set_link(OBJECT(&s->i2c), "dram", + OBJECT(s->dram_mr), errp); + if (!sysbus_realize(SYS_BUS_DEVICE(&s->i2c), errp)) { + return; + } + memory_region_add_subregion(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_I2C], + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->i2c), 0)= ); + /* LTPI controller */ if (!sysbus_realize(SYS_BUS_DEVICE(&s->ltpi), errp)) { return; @@ -146,6 +161,10 @@ static void aspeed_ast1700_instance_init(Object *obj) object_initialize_child(obj, "ioexp-gpio", &s->gpio, "aspeed.gpio-ast2700"); =20 + /* I2C */ + object_initialize_child(obj, "ioexp-i2c", &s->i2c, + "aspeed.i2c-ast2700"); + /* LTPI controller */ object_initialize_child(obj, "ltpi-ctrl", &s->ltpi, TYPE_ASPEED_LTPI); diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index cd4028fcd4c7..8242258df442 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -157,6 +157,8 @@ static const int aspeed_soc_ast2700a1_irqmap[] =3D { [ASPEED_DEV_EHCI4] =3D 196, [ASPEED_DEV_PECI] =3D 197, [ASPEED_DEV_SDHCI] =3D 197, + [ASPEED_DEV_IOEXP0_I2C] =3D 198, + [ASPEED_DEV_IOEXP1_I2C] =3D 200, }; =20 /* GICINT 192 */ @@ -213,6 +215,18 @@ static const int ast2700_gic197_intcmap[] =3D { [ASPEED_DEV_PECI] =3D 4, }; =20 +/* Primary AST1700 Interrupts */ +/* A1: GICINT 198 */ +static const int ast2700_gic198_intcmap[] =3D { + [ASPEED_DEV_IOEXP0_I2C] =3D 0, /* 0 - 15 */ +}; + +/* Secondary AST1700 Interrupts */ +/* A1: GINTC 200 */ +static const int ast2700_gic200_intcmap[] =3D { + [ASPEED_DEV_IOEXP1_I2C] =3D 0, /* 0 - 15 */ +}; + /* GICINT 192 ~ 201 */ struct gic_intc_irq_info { int irq; @@ -228,9 +242,9 @@ static const struct gic_intc_irq_info ast2700_gic_intcm= ap[] =3D { {195, 1, 3, ast2700_gic195_intcmap}, {196, 1, 4, ast2700_gic196_intcmap}, {197, 1, 5, ast2700_gic197_intcmap}, - {198, 1, 6, NULL}, + {198, 2, 0, ast2700_gic198_intcmap}, {199, 1, 7, NULL}, - {200, 1, 8, NULL}, + {200, 3, 0, ast2700_gic200_intcmap}, {201, 1, 9, NULL}, }; =20 @@ -263,14 +277,23 @@ static qemu_irq aspeed_soc_ast2700_get_irq_index(Aspe= edSoCState *s, int dev, int or_idx; int idx; int i; + OrIRQState *porgates; =20 for (i =3D 0; i < ARRAY_SIZE(ast2700_gic_intcmap); i++) { if (sc->irqmap[dev] =3D=3D ast2700_gic_intcmap[i].irq) { assert(ast2700_gic_intcmap[i].ptr); or_idx =3D ast2700_gic_intcmap[i].orgate_idx; idx =3D ast2700_gic_intcmap[i].intc_idx; - return qdev_get_gpio_in(DEVICE(&a->intc[idx].orgates[or_idx]), + if (idx < ASPEED_INTC_NUM) { + porgates =3D &a->intc[idx].orgates[or_idx]; + return qdev_get_gpio_in(DEVICE(porgates), + ast2700_gic_intcmap[i].ptr[dev] + inde= x); + } else { + idx -=3D ASPEED_INTC_NUM; + porgates =3D &a->intcioexp[idx].orgates[or_idx]; + return qdev_get_gpio_in(DEVICE(porgates), ast2700_gic_intcmap[i].ptr[dev] + inde= x); + } } } =20 @@ -1025,6 +1048,8 @@ static void aspeed_soc_ast2700_realize(DeviceState *d= ev, Error **errp) =20 /* IO Expander */ for (i =3D 0; i < sc->ioexp_num; i++) { + AspeedI2CClass *i2c_ctl; + qdev_prop_set_uint8(DEVICE(&s->ioexp[i]), "board-idx", i); object_property_set_link(OBJECT(&s->ioexp[i]), "dram", OBJECT(s->dram_mr), &error_abort); @@ -1057,6 +1082,26 @@ static void aspeed_soc_ast2700_realize(DeviceState *= dev, Error **errp) sysbus_connect_irq(SYS_BUS_DEVICE(&s->ioexp[i].gpio), 0, aspeed_soc_ast2700_get_irq(s, ASPEED_DEV_GPIO)); =20 + /* I2C */ + i2c_ctl =3D ASPEED_I2C_GET_CLASS(&s->ioexp[i].i2c); + for (int j =3D 0; j < i2c_ctl->num_busses; j++) { + /* + * For I2C on AST1700: + * I2C bus interrupts are connected to the OR gate from bit 0 = to bit + * 15, and the OR gate output pin is connected to the input pi= n of + * GICINT192 of IO expander Interrupt controller (INTC2/3). Th= en, + * the output pin is connected to the INTC (CPU Die) input pin= , and + * its output pin is connected to the GIC. + * + * I2C bus 0 is connected to the OR gate at bit 0. + * I2C bus 15 is connected to the OR gate at bit 15. + */ + irq =3D aspeed_soc_ast2700_get_irq_index(s, + ASPEED_DEV_IOEXP0_I2C += i, + j); + sysbus_connect_irq(SYS_BUS_DEVICE(&s->ioexp[i].i2c.busses[j]), + 0, irq); + } } =20 aspeed_mmio_map_unimplemented(s->memory, SYS_BUS_DEVICE(&s->dpmcu), --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201237; cv=none; d=zohomail.com; s=zohoarc; b=BFnCUqo8+tZlfmmu72D8WeOFmpPm49J9senhGHPh8JmtetOL8ytSPKZLuJyW5TyNomkzkD+mV+/69WrpCC7BPMLjRwH3AzpyAb0wN5e86MGl4qdxQtRg4EsGxgUvgQw0ET5E97c2crqVkFUEsiJW/1OVJI22ONGdr/ysZKk89no= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201237; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=s6+IOP/ZYsZUujXSs6pRXKxziTQlt+0qFcMqUzWJnyI=; b=njG3W70yEcTHQ5LLvcRydYACHaA4vBfA5RKTZoVfg8EPf48tNVMsS+S9TSmYa5BuVy7f1GU5DK4IlaGZztgc3m59XZ/hj7EsruRcLkbJqosLd/bn+h402I+NQMuySXkHOL+RtQ696nhEyckIILe5RLuC7RE+308Y9DVlRUA0AHM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201237115233.58602166694652; Wed, 4 Feb 2026 02:33:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCh-0003g4-Fr; Wed, 04 Feb 2026 05:33:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaC3-0002TY-6B for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaC1-0004CQ-Jh for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:06 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-lUK8ctKPMw23blPtiWhnAA-1; Wed, 04 Feb 2026 05:33:02 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F0DAE1800259; Wed, 4 Feb 2026 10:33:00 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2A6A918004AD; Wed, 4 Feb 2026 10:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s6+IOP/ZYsZUujXSs6pRXKxziTQlt+0qFcMqUzWJnyI=; b=EXzMEDVoo8TIziF09LeTMtRaC0jKbX5WorXat092w8QySLSt1sWB95+grvo5e3tzQVXlUc hO1QOfU+mkylIfPLvbxphMYHn3W3qL7pBaOgh86l7LXdoW9ewO/XKJXeKWhg/rAND/BaDU HoVy2rK8yZBNxo65wM5ioxpeyeMp0yw= X-MC-Unique: lUK8ctKPMw23blPtiWhnAA-1 X-Mimecast-MFC-AGG-ID: lUK8ctKPMw23blPtiWhnAA_1770201181 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 38/45] hw/arm/aspeed: Attach WDT device to AST1700 model Date: Wed, 4 Feb 2026 11:31:29 +0100 Message-ID: <20260204103136.1795455-39-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201238720158500 From: Kane Chen Connect the WDT device to AST1700 model. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-16-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 4 ++++ hw/arm/aspeed_ast1700.c | 24 ++++++++++++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index 1005ce63645f..ee0c47d173e0 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -15,8 +15,11 @@ #include "hw/i2c/aspeed_i2c.h" #include "hw/misc/aspeed_ltpi.h" #include "hw/ssi/aspeed_smc.h" +#include "hw/watchdog/wdt_aspeed.h" #include "hw/char/serial-mm.h" =20 +#define AST1700_WDT_NUM 9 + #define TYPE_ASPEED_AST1700 "aspeed.ast1700" =20 OBJECT_DECLARE_SIMPLE_TYPE(AspeedAST1700SoCState, ASPEED_AST1700) @@ -37,6 +40,7 @@ struct AspeedAST1700SoCState { AspeedSCUState scu; AspeedGPIOState gpio; AspeedI2CState i2c; + AspeedWDTState wdt[AST1700_WDT_NUM]; }; =20 #endif /* ASPEED_AST1700_H */ diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index e264b2200bc3..59954eca99aa 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -25,6 +25,7 @@ enum { ASPEED_AST1700_DEV_I2C, ASPEED_AST1700_DEV_UART12, ASPEED_AST1700_DEV_LTPI_CTRL, + ASPEED_AST1700_DEV_WDT, ASPEED_AST1700_DEV_SPI0_MEM, }; =20 @@ -37,6 +38,7 @@ static const hwaddr aspeed_ast1700_io_memmap[] =3D { [ASPEED_AST1700_DEV_I2C] =3D 0x00C0F000, [ASPEED_AST1700_DEV_UART12] =3D 0x00C33B00, [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, + [ASPEED_AST1700_DEV_WDT] =3D 0x00C37000, [ASPEED_AST1700_DEV_SPI0_MEM] =3D 0x04000000, }; =20 @@ -135,6 +137,22 @@ static void aspeed_ast1700_realize(DeviceState *dev, E= rror **errp) memory_region_add_subregion(&s->iomem, aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_LTPI_C= TRL], sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->ltpi), 0= )); + /* WDT */ + for (int i =3D 0; i < AST1700_WDT_NUM; i++) { + AspeedWDTClass *awc =3D ASPEED_WDT_GET_CLASS(&s->wdt[i]); + hwaddr wdt_offset =3D aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_= WDT] + + i * awc->iosize; + + object_property_set_link(OBJECT(&s->wdt[i]), "scu", OBJECT(&s->scu= ), + errp); + if (!sysbus_realize(SYS_BUS_DEVICE(&s->wdt[i]), errp)) { + return; + } + memory_region_add_subregion(&s->iomem, + wdt_offset, + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->wdt[i]),= 0)); + } + } =20 static void aspeed_ast1700_instance_init(Object *obj) @@ -169,6 +187,12 @@ static void aspeed_ast1700_instance_init(Object *obj) object_initialize_child(obj, "ltpi-ctrl", &s->ltpi, TYPE_ASPEED_LTPI); =20 + /* WDT */ + for (int i =3D 0; i < AST1700_WDT_NUM; i++) { + object_initialize_child(obj, "ioexp-wdt[*]", + &s->wdt[i], "aspeed.wdt-ast2700"); + } + return; } =20 --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201428; cv=none; d=zohomail.com; s=zohoarc; b=l26meKeUcnNLOUAxPp8X+vSyu/VUQScn2Nkpi5CbVjn0IXMU1mSOasKJmxTPcM9ut6F4SO+8wDr9T3dqfTSCZd5mFGxPIO6+zbWWdyYuHE3UJtJoPV0uCDxoXSs0pct/eGaMeMOnlpK9O6WJ19noqG9WYG2q4j891RHRG0Ad7oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201428; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=v3170o4i4IkBxFxx85GDgUrbJtB3DYQpaySLDh+Jn8I=; b=PmF/j8DB37Ar0v543rWPIPd0kE3nK6F+ERwJl2XNj6psz9yZg9dlER75XkivqgPiReRnT1XhgCEWtnjFgRlHLcUiGLKKTM1nT32lIbe2CwwmYOBzR9z6zJcqyQrdiHI27m8BreyrP2iNV18U+rVhiu3KkKexDEIdwYWRQxnE9ZA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201428939331.4223760680394; Wed, 4 Feb 2026 02:37:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCL-0002vq-7q; Wed, 04 Feb 2026 05:33:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaC5-0002c7-TS for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaC4-0004DA-E5 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:09 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-mniRdrnSNzywv8U6lHUTfw-1; Wed, 04 Feb 2026 05:33:04 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0FB13195608E; Wed, 4 Feb 2026 10:33:03 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5787A18003F6; Wed, 4 Feb 2026 10:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v3170o4i4IkBxFxx85GDgUrbJtB3DYQpaySLDh+Jn8I=; b=AP2p9q2gXWAwqiGoFBPk0L01iuLxuCX/JDDCCi999DM5IbLmOzF4AKFji7Mr9AlrhSwg+2 +RyOyvezHP3J/Gn+SAkDfSf4fFDKfaCrCH9k14csgeLCRJ0Zjlb6aFRkSNvI749l6KV3XD IA5WjYgyKxVYroLx0CuU6U9ENMTWiW4= X-MC-Unique: mniRdrnSNzywv8U6lHUTfw-1 X-Mimecast-MFC-AGG-ID: mniRdrnSNzywv8U6lHUTfw_1770201183 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 39/45] hw/arm/aspeed: Attach PWM device to AST1700 model Date: Wed, 4 Feb 2026 11:31:30 +0100 Message-ID: <20260204103136.1795455-40-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201431126154100 From: Kane Chen Connect the PWM device to AST1700 model. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-17-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 2 ++ hw/arm/aspeed_ast1700.c | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index ee0c47d173e0..8db513a38c2b 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -14,6 +14,7 @@ #include "hw/gpio/aspeed_gpio.h" #include "hw/i2c/aspeed_i2c.h" #include "hw/misc/aspeed_ltpi.h" +#include "hw/misc/aspeed_pwm.h" #include "hw/ssi/aspeed_smc.h" #include "hw/watchdog/wdt_aspeed.h" #include "hw/char/serial-mm.h" @@ -40,6 +41,7 @@ struct AspeedAST1700SoCState { AspeedSCUState scu; AspeedGPIOState gpio; AspeedI2CState i2c; + AspeedPWMState pwm; AspeedWDTState wdt[AST1700_WDT_NUM]; }; =20 diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index 59954eca99aa..c0b288a0fc6e 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -18,6 +18,7 @@ =20 enum { ASPEED_AST1700_DEV_SPI0, + ASPEED_AST1700_DEV_PWM, ASPEED_AST1700_DEV_SRAM, ASPEED_AST1700_DEV_ADC, ASPEED_AST1700_DEV_SCU, @@ -31,6 +32,7 @@ enum { =20 static const hwaddr aspeed_ast1700_io_memmap[] =3D { [ASPEED_AST1700_DEV_SPI0] =3D 0x00030000, + [ASPEED_AST1700_DEV_PWM] =3D 0x000C0000, [ASPEED_AST1700_DEV_SRAM] =3D 0x00BC0000, [ASPEED_AST1700_DEV_ADC] =3D 0x00C00000, [ASPEED_AST1700_DEV_SCU] =3D 0x00C02000, @@ -130,6 +132,14 @@ static void aspeed_ast1700_realize(DeviceState *dev, E= rror **errp) aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_I2C], sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->i2c), 0)= ); =20 + /* PWM */ + if (!sysbus_realize(SYS_BUS_DEVICE(&s->pwm), errp)) { + return; + } + memory_region_add_subregion(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_PWM], + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->pwm), 0)= ); + /* LTPI controller */ if (!sysbus_realize(SYS_BUS_DEVICE(&s->ltpi), errp)) { return; @@ -183,6 +193,9 @@ static void aspeed_ast1700_instance_init(Object *obj) object_initialize_child(obj, "ioexp-i2c", &s->i2c, "aspeed.i2c-ast2700"); =20 + /* PWM */ + object_initialize_child(obj, "pwm", &s->pwm, TYPE_ASPEED_PWM); + /* LTPI controller */ object_initialize_child(obj, "ltpi-ctrl", &s->ltpi, TYPE_ASPEED_LTPI); --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201237; cv=none; d=zohomail.com; s=zohoarc; b=NLvO537+hspxccuULhfbWR87eSnsZb5vt0oTjoMuFkNuZez4/L72bSMX78BWwEBLluG1IYUQE2Ox7hQSlPsQGq8l+HYAPBo+auxj+FUZs0ysAbyqbnOqWCo9E/DIzvkUhoAYUrn4Efpa3HQiNfrzNmv9OF0IAWuPdidVH3E7E84= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201237; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/X4N7XWl2wOwaPaHMCldIY02m7ZG7f5HeX4FZqzGRF0=; b=KIK0K6tdMFNwKdwWls8nPALUGuXtoOZxPgD9ed0O3MxWO7X8vov58Eq/ucqMHFGV84FnYqh06hTGODT1UcvRwH2ECC3hA+gPYH+CUWoQ8iV4Au+MLxQ0kRabNMEiUZyLTbp7sHoutog2BAn4Soa5Xiu8PgpKBkQCJ+6/pntjd1k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201237384829.7817944406747; Wed, 4 Feb 2026 02:33:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCC-0002hs-Ow; Wed, 04 Feb 2026 05:33:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaC6-0002cC-3f for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaC4-0004DC-E8 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:09 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-38-bZainriZNqeBYftPPkmOCQ-1; Wed, 04 Feb 2026 05:33:06 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 50A4719560A7; Wed, 4 Feb 2026 10:33:05 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 812E218003F6; Wed, 4 Feb 2026 10:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/X4N7XWl2wOwaPaHMCldIY02m7ZG7f5HeX4FZqzGRF0=; b=NkT+diHVzky5xYl3y4y95aPN11ivg3KNQrRlPiSky+1giacUHDEl8ue8Wcec5WA63lFR8q 4BhGJKLvOZO26DmLeS6+xe+JqDDFgyT56e8FvxSyx1tjOKo7GMJ/TLyr+Qmcm/IWAsBlHu DbHGBm+pgGSdsU5dtdJ3+PeLjszP8aQ= X-MC-Unique: bZainriZNqeBYftPPkmOCQ-1 X-Mimecast-MFC-AGG-ID: bZainriZNqeBYftPPkmOCQ_1770201185 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 40/45] hw/arm/aspeed: Attach SGPIOM device to AST1700 model Date: Wed, 4 Feb 2026 11:31:31 +0100 Message-ID: <20260204103136.1795455-41-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201238471154100 From: Kane Chen Connect the SGPIOM device to AST1700 model. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-18-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 3 +++ hw/arm/aspeed_ast1700.c | 21 +++++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index 8db513a38c2b..b5cb0a901086 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -12,6 +12,7 @@ #include "hw/misc/aspeed_scu.h" #include "hw/adc/aspeed_adc.h" #include "hw/gpio/aspeed_gpio.h" +#include "hw/gpio/aspeed_sgpio.h" #include "hw/i2c/aspeed_i2c.h" #include "hw/misc/aspeed_ltpi.h" #include "hw/misc/aspeed_pwm.h" @@ -19,6 +20,7 @@ #include "hw/watchdog/wdt_aspeed.h" #include "hw/char/serial-mm.h" =20 +#define AST1700_SGPIO_NUM 2 #define AST1700_WDT_NUM 9 =20 #define TYPE_ASPEED_AST1700 "aspeed.ast1700" @@ -40,6 +42,7 @@ struct AspeedAST1700SoCState { AspeedADCState adc; AspeedSCUState scu; AspeedGPIOState gpio; + AspeedSGPIOState sgpiom[AST1700_SGPIO_NUM]; AspeedI2CState i2c; AspeedPWMState pwm; AspeedWDTState wdt[AST1700_WDT_NUM]; diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index c0b288a0fc6e..174186964eb6 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -23,6 +23,8 @@ enum { ASPEED_AST1700_DEV_ADC, ASPEED_AST1700_DEV_SCU, ASPEED_AST1700_DEV_GPIO, + ASPEED_AST1700_DEV_SGPIOM0, + ASPEED_AST1700_DEV_SGPIOM1, ASPEED_AST1700_DEV_I2C, ASPEED_AST1700_DEV_UART12, ASPEED_AST1700_DEV_LTPI_CTRL, @@ -37,6 +39,8 @@ static const hwaddr aspeed_ast1700_io_memmap[] =3D { [ASPEED_AST1700_DEV_ADC] =3D 0x00C00000, [ASPEED_AST1700_DEV_SCU] =3D 0x00C02000, [ASPEED_AST1700_DEV_GPIO] =3D 0x00C0B000, + [ASPEED_AST1700_DEV_SGPIOM0] =3D 0x00C0C000, + [ASPEED_AST1700_DEV_SGPIOM1] =3D 0x00C0D000, [ASPEED_AST1700_DEV_I2C] =3D 0x00C0F000, [ASPEED_AST1700_DEV_UART12] =3D 0x00C33B00, [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, @@ -147,6 +151,17 @@ static void aspeed_ast1700_realize(DeviceState *dev, E= rror **errp) memory_region_add_subregion(&s->iomem, aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_LTPI_C= TRL], sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->ltpi), 0= )); + + /* SGPIOM */ + for (int i =3D 0; i < AST1700_SGPIO_NUM; i++) { + if (!sysbus_realize(SYS_BUS_DEVICE(&s->sgpiom[i]), errp)) { + return; + } + memory_region_add_subregion(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_SGPIOM0 + = i], + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->sgpiom[i]), = 0)); + } + /* WDT */ for (int i =3D 0; i < AST1700_WDT_NUM; i++) { AspeedWDTClass *awc =3D ASPEED_WDT_GET_CLASS(&s->wdt[i]); @@ -200,6 +215,12 @@ static void aspeed_ast1700_instance_init(Object *obj) object_initialize_child(obj, "ltpi-ctrl", &s->ltpi, TYPE_ASPEED_LTPI); =20 + /* SGPIOM */ + for (int i =3D 0; i < AST1700_SGPIO_NUM; i++) { + object_initialize_child(obj, "ioexp-sgpiom[*]", &s->sgpiom[i], + "aspeed.sgpio-ast2700"); + } + /* WDT */ for (int i =3D 0; i < AST1700_WDT_NUM; i++) { object_initialize_child(obj, "ioexp-wdt[*]", --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201302; cv=none; d=zohomail.com; s=zohoarc; b=fCKfMDg9Vf1pSdClDsR/3NjgbGYm8b2jAtYX1EtrMNzm9AlP2DWAWpimw3agX+GILCrtmoBOxrooO02tUwk4O6Qjq8ytwUKuKo0BnvmiiB2i/JhTEraUDPk3jDRnPyzPf0325jz+CCZKjzgqM+vI4YwMfpksVA/mSdQ7ZCziajU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201302; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0eFcpqgjedIMkoHQ51JuwO3iS8I5PR9YBXqb5Ny/aGI=; b=d8Ki4+b0QC9MdgDHTgbSteB5GnGWQmwDlRoPe/cR0acM4OMyj7GmuwJBPgQxPWxtRuYpjLzjMZAMKfqrDMezhonVOXkzmK2vEEKYszKTnHhssUoXVMibIQvYlMZqFt3U4+6iuezmTbD1zfFSP0bOBpJeuqxLnVhsex5cT4NWIKc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201302831518.3168715982079; Wed, 4 Feb 2026 02:35:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCr-0003yE-4D; Wed, 04 Feb 2026 05:33:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaCA-0002iP-MF for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaC8-0004E7-FF for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:13 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-a0XDDQ4NNqu5hnwAB9v-Iw-1; Wed, 04 Feb 2026 05:33:08 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 92CA51800473; Wed, 4 Feb 2026 10:33:07 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C2D3D18003F6; Wed, 4 Feb 2026 10:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0eFcpqgjedIMkoHQ51JuwO3iS8I5PR9YBXqb5Ny/aGI=; b=cd2H5Bxz+or6pafbX+2UC91Q0Zh7MQsQRvnIOjyY8sbs5hWJYFAS/1Cqv04ZlvAmrR2KnP ucmSs2Gy1GPiXzbMAbyW6e84O6iPNATDbK/LxfBn0WPYXnmF3+ojXsBWYJpC/7eQeskgb8 pMA5GgaAz2ley/WubFy0znbDFyPmAmk= X-MC-Unique: a0XDDQ4NNqu5hnwAB9v-Iw-1 X-Mimecast-MFC-AGG-ID: a0XDDQ4NNqu5hnwAB9v-Iw_1770201187 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 41/45] hw/arm/aspeed: Model AST1700 I3C block as unimplemented device Date: Wed, 4 Feb 2026 11:31:32 +0100 Message-ID: <20260204103136.1795455-42-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201304435158500 From: Kane Chen AST1700 exposes more I3C buses than the current dummy I3C model provides. When Linux probes the I3C devices on AST1700 this mismatch can trigger a kernel panic. Model the I3C block as an unimplemented device to make the missing functionality explicit and avoid unexpected side effects. This wires up the I3C interrupt lines for the IO expanders and adds the corresponding device entries for the AST1700 model. No functional I3C emulation is provided yet; this only prevents crashes and documents the missing piece. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-19-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- include/hw/arm/aspeed_ast1700.h | 3 +++ include/hw/arm/aspeed_soc.h | 2 ++ hw/arm/aspeed_ast1700.c | 15 +++++++++++++++ hw/arm/aspeed_ast27x0.c | 18 ++++++++++++++++-- 4 files changed, 36 insertions(+), 2 deletions(-) diff --git a/include/hw/arm/aspeed_ast1700.h b/include/hw/arm/aspeed_ast170= 0.h index b5cb0a901086..f7bd4e8650ba 100644 --- a/include/hw/arm/aspeed_ast1700.h +++ b/include/hw/arm/aspeed_ast1700.h @@ -19,6 +19,7 @@ #include "hw/ssi/aspeed_smc.h" #include "hw/watchdog/wdt_aspeed.h" #include "hw/char/serial-mm.h" +#include "hw/misc/unimp.h" =20 #define AST1700_SGPIO_NUM 2 #define AST1700_WDT_NUM 9 @@ -46,6 +47,8 @@ struct AspeedAST1700SoCState { AspeedI2CState i2c; AspeedPWMState pwm; AspeedWDTState wdt[AST1700_WDT_NUM]; + + UnimplementedDeviceState i3c; }; =20 #endif /* ASPEED_AST1700_H */ diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index 4ea252104137..b185b0418678 100644 --- a/include/hw/arm/aspeed_soc.h +++ b/include/hw/arm/aspeed_soc.h @@ -294,6 +294,8 @@ enum { ASPEED_DEV_IOEXP1_I2C, ASPEED_DEV_IOEXP0_INTCIO, ASPEED_DEV_IOEXP1_INTCIO, + ASPEED_DEV_IOEXP0_I3C, + ASPEED_DEV_IOEXP1_I3C, }; =20 const char *aspeed_soc_cpu_type(const char * const *valid_cpu_types); diff --git a/hw/arm/aspeed_ast1700.c b/hw/arm/aspeed_ast1700.c index 174186964eb6..e90302c11bcd 100644 --- a/hw/arm/aspeed_ast1700.c +++ b/hw/arm/aspeed_ast1700.c @@ -15,6 +15,7 @@ =20 #define AST2700_SOC_LTPI_SIZE 0x01000000 #define AST1700_SOC_SRAM_SIZE 0x00040000 +#define AST1700_SOC_I3C_SIZE 0x00010000 =20 enum { ASPEED_AST1700_DEV_SPI0, @@ -26,6 +27,7 @@ enum { ASPEED_AST1700_DEV_SGPIOM0, ASPEED_AST1700_DEV_SGPIOM1, ASPEED_AST1700_DEV_I2C, + ASPEED_AST1700_DEV_I3C, ASPEED_AST1700_DEV_UART12, ASPEED_AST1700_DEV_LTPI_CTRL, ASPEED_AST1700_DEV_WDT, @@ -42,6 +44,7 @@ static const hwaddr aspeed_ast1700_io_memmap[] =3D { [ASPEED_AST1700_DEV_SGPIOM0] =3D 0x00C0C000, [ASPEED_AST1700_DEV_SGPIOM1] =3D 0x00C0D000, [ASPEED_AST1700_DEV_I2C] =3D 0x00C0F000, + [ASPEED_AST1700_DEV_I3C] =3D 0x00C20000, [ASPEED_AST1700_DEV_UART12] =3D 0x00C33B00, [ASPEED_AST1700_DEV_LTPI_CTRL] =3D 0x00C34000, [ASPEED_AST1700_DEV_WDT] =3D 0x00C37000, @@ -178,6 +181,14 @@ static void aspeed_ast1700_realize(DeviceState *dev, E= rror **errp) sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->wdt[i]),= 0)); } =20 + /* I3C */ + qdev_prop_set_string(DEVICE(&s->i3c), "name", "ioexp-i3c"); + qdev_prop_set_uint64(DEVICE(&s->i3c), "size", AST1700_SOC_I3C_SIZE); + sysbus_realize(SYS_BUS_DEVICE(&s->i3c), errp); + memory_region_add_subregion_overlap(&s->iomem, + aspeed_ast1700_io_memmap[ASPEED_AST1700_DEV_I3C], + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->i3c), 0), + -1000); } =20 static void aspeed_ast1700_instance_init(Object *obj) @@ -227,6 +238,10 @@ static void aspeed_ast1700_instance_init(Object *obj) &s->wdt[i], "aspeed.wdt-ast2700"); } =20 + /* I3C */ + object_initialize_child(obj, "ioexp-i3c", &s->i3c, + TYPE_UNIMPLEMENTED_DEVICE); + return; } =20 diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 8242258df442..d3b305fa7a1a 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -158,7 +158,9 @@ static const int aspeed_soc_ast2700a1_irqmap[] =3D { [ASPEED_DEV_PECI] =3D 197, [ASPEED_DEV_SDHCI] =3D 197, [ASPEED_DEV_IOEXP0_I2C] =3D 198, + [ASPEED_DEV_IOEXP0_I3C] =3D 199, [ASPEED_DEV_IOEXP1_I2C] =3D 200, + [ASPEED_DEV_IOEXP1_I3C] =3D 201, }; =20 /* GICINT 192 */ @@ -221,12 +223,24 @@ static const int ast2700_gic198_intcmap[] =3D { [ASPEED_DEV_IOEXP0_I2C] =3D 0, /* 0 - 15 */ }; =20 +/* Primary AST1700 Interrupts */ +/* A1: GINTC 199 */ +static const int ast2700_gic199_intcmap[] =3D { + [ASPEED_DEV_IOEXP0_I3C] =3D 0, /* 0 - 15 */ +}; + /* Secondary AST1700 Interrupts */ /* A1: GINTC 200 */ static const int ast2700_gic200_intcmap[] =3D { [ASPEED_DEV_IOEXP1_I2C] =3D 0, /* 0 - 15 */ }; =20 +/* Secondary AST1700 Interrupts */ +/* A1: GINTC 201 */ +static const int ast2700_gic201_intcmap[] =3D { + [ASPEED_DEV_IOEXP1_I3C] =3D 0, /* 0 - 15 */ +}; + /* GICINT 192 ~ 201 */ struct gic_intc_irq_info { int irq; @@ -243,9 +257,9 @@ static const struct gic_intc_irq_info ast2700_gic_intcm= ap[] =3D { {196, 1, 4, ast2700_gic196_intcmap}, {197, 1, 5, ast2700_gic197_intcmap}, {198, 2, 0, ast2700_gic198_intcmap}, - {199, 1, 7, NULL}, + {199, 2, 1, ast2700_gic199_intcmap}, {200, 3, 0, ast2700_gic200_intcmap}, - {201, 1, 9, NULL}, + {201, 3, 1, ast2700_gic201_intcmap}, }; =20 static qemu_irq aspeed_soc_ast2700_get_irq(AspeedSoCState *s, int dev) --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201241; cv=none; d=zohomail.com; s=zohoarc; b=YdBS2RUiP6BzCMov0vdtgf1D0d7Ly5nHxi0dlYBMEl3YUOYKObbnr6n9RxvbSJtxLZj59em/xsivuqxgyrYn21m/Fadnvs2XttW5EJaKyoHMGthOq/48jO/PZ4CxdtKSEnbufsLO5yJdfe449HuaVx7w8GkP1WCHfA+gfhkxjtE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201241; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TsdpYmVJZN/HUBxm8A547HdmKT2k4rajun973HI7zak=; b=LKlgW6bq9uLrlL7JPYv93mdZMmsWvnEt0cjyQraxZxIfDhKAab8J3wgvX0jW6vEEQ2OqB5xRzqL4clVTnEq28JS9CLIZ1oNZR71+3DlZrv+7oFO/1wxS0BIodqsL97BkDUL7aGGMZZCGCaDysBpnjEI1JbXAKtPLienBcqflt3E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201241145485.09005439206567; Wed, 4 Feb 2026 02:34:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCT-00038K-0B; Wed, 04 Feb 2026 05:33:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaCE-0002lh-4n for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaCC-0004Ex-OP for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:17 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-Pn_OQkhQPLyskrm3hdbaxg-1; Wed, 04 Feb 2026 05:33:10 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C5D681800367; Wed, 4 Feb 2026 10:33:09 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0F22818004AD; Wed, 4 Feb 2026 10:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TsdpYmVJZN/HUBxm8A547HdmKT2k4rajun973HI7zak=; b=ir2tP00ATWnBI0SnHv2Mz/Bhq/oNK2IA+DJXilz9iWl5/snCj7aj0lRiX8NBrtXAlztyRF Po3ApxDrFAN2pMIm4iaLMYUxDEza3WgQjK1K9IUO69sh6UMIrwXRl8ihDyjb243W1HUsxI E6bjQvDhWcbs/NhGjBsn8KSj6I0rtk0= X-MC-Unique: Pn_OQkhQPLyskrm3hdbaxg-1 X-Mimecast-MFC-AGG-ID: Pn_OQkhQPLyskrm3hdbaxg_1770201189 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Nabih Estefan Subject: [PULL 42/45] hw/arm/aspeed: Enable AST1700 IO expander support Date: Wed, 4 Feb 2026 11:31:33 +0100 Message-ID: <20260204103136.1795455-43-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201242215158500 From: Kane Chen Set ioexp_num to 2 to enable AST1700 IO expander support. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Nabih Estefan Tested-by: Nabih Estefan Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-20-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_ast27x0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index d3b305fa7a1a..61790ea1cc2b 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -1160,7 +1160,7 @@ static void aspeed_soc_ast2700a1_class_init(ObjectCla= ss *oc, const void *data) sc->macs_num =3D 3; sc->uarts_num =3D 13; sc->num_cpus =3D 4; - sc->ioexp_num =3D 0; + sc->ioexp_num =3D 2; sc->uarts_base =3D ASPEED_DEV_UART0; sc->irqmap =3D aspeed_soc_ast2700a1_irqmap; sc->memmap =3D aspeed_soc_ast2700_memmap; --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201456; cv=none; d=zohomail.com; s=zohoarc; b=DnLlHkkvXKhHDwWguDPZC3yDXlHhkNtTmH5SLHyi5Bl7He0a5geT+PveP3UKfhCfsOTtau7n4p768BG8R1SoJIfuCjVWHSZVUBeRmnQlYDsC0Kv6crEJMOpxYLcD5KQDAJtf6D0rvCE80ateEW0MGVmHZj3V2Bkj+PlKzUvXW/E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201456; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=H81VUSnjG5NUhsNhELoIUfLN6VVQFs4TBpBGHdAwLj4=; b=U6AL7J5MNwjSI6/uLiygoJKGsB2XkYnYYyAi0e8+hR3A5lMpQUt9froEhr0T/drTqKNWriZMvzU3vd85LD8pgvpqwm0evI+cxNd/vrVZaCKA0uJ2K1ANQ17D0bX60KcwGI1u4sxNf3UkNtgNOXRZRZA6/ZPpjTW1tJtoC8z3jQE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177020145603278.56914740147454; Wed, 4 Feb 2026 02:37:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCv-00048h-8I; Wed, 04 Feb 2026 05:34:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaCC-0002kO-VR for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaCA-0004EW-Sn for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:16 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-ZCojK-NRNhWDhQtjqEFMlw-1; Wed, 04 Feb 2026 05:33:12 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CB5B01956050; Wed, 4 Feb 2026 10:33:11 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4374418004AD; Wed, 4 Feb 2026 10:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H81VUSnjG5NUhsNhELoIUfLN6VVQFs4TBpBGHdAwLj4=; b=WZP+JxNWwGSy0baWG4liSwKD3EGj/A3yGwT9yWzpXCC6jySCapXu9fxzcSLC/3nwHoNoTn Z+wUhXvG9nNQGG8tFDWwNqO/aUPuHITMlcLv0EtxZPG9o8dQhWt2HwIz/3+yo3vTho2FpR kbHjNXI9JX34MNLkeU1f21IAJw5IHzM= X-MC-Unique: ZCojK-NRNhWDhQtjqEFMlw-1 X-Mimecast-MFC-AGG-ID: ZCojK-NRNhWDhQtjqEFMlw_1770201191 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 43/45] tests/functional/aarch64: Parameterize I2C bus ID in AST2700 test Date: Wed, 4 Feb 2026 11:31:34 +0100 Message-ID: <20260204103136.1795455-44-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201457139158500 From: Kane Chen The current Aspeed AST2700 functional test case strictly uses I2C bus 1 for its sensor tests. This hard-coded approach prevents the test logic from being reused for other machine types or configurations where I2C bus 1 might be disabled or where a different bus needs to be verified (e.g., I2C expanders). This refactoring allows the same I2C verification logic to be shared across different test scenarios by simply passing the target bus number. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-21-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- .../functional/aarch64/test_aspeed_ast2700.py | 39 +++++++++++-------- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/tests/functional/aarch64/test_aspeed_ast2700.py b/tests/functi= onal/aarch64/test_aspeed_ast2700.py index 828ea1ca53df..d7eeab9c23fd 100755 --- a/tests/functional/aarch64/test_aspeed_ast2700.py +++ b/tests/functional/aarch64/test_aspeed_ast2700.py @@ -15,11 +15,17 @@ =20 class AST2x00MachineSDK(QemuSystemTest): =20 - def do_test_aarch64_aspeed_sdk_start(self, image): + def do_test_aarch64_aspeed_sdk_start(self, image, bus_id): + bus_str =3D str(bus_id) self.require_netdev('user') self.vm.set_console() - self.vm.add_args('-device', - 'tmp105,bus=3Daspeed.i2c.bus.1,address=3D0x4d,id= =3Dtmp-test') + self.vm.add_args( + '-device', + f'tmp105,' + f'bus=3Daspeed.i2c.bus.{bus_str},' + f'address=3D0x4d,' + f'id=3Dtmp-test-{bus_str}' + ) self.vm.add_args('-drive', 'file=3D' + image + ',if=3Dmtd,format= =3Draw', '-net', 'nic', '-net', 'user', '-snapshot') =20 @@ -75,16 +81,17 @@ def verify_openbmc_boot_and_login(self, name): 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v= 11.00/ast2700-a1-obmc.tar.gz', 'd5ceed511cd0dfefbb102fff2d731159e0472948a28066dc0d90bcd54be76= 525') =20 - def do_ast2700_i2c_test(self): + def do_ast2700_i2c_test(self, bus_id): + bus_str =3D str(bus_id) exec_command_and_wait_for_pattern(self, - 'echo lm75 0x4d > /sys/class/i2c-dev/i2c-1/device/new_device ', - 'i2c i2c-1: new_device: Instantiated device lm75 at 0x4d') + f'echo lm75 0x4d > /sys/class/i2c-dev/i2c-{bus_str}/device/new= _device ', + f'i2c i2c-{bus_str}: new_device: Instantiated device lm75 at 0= x4d') exec_command_and_wait_for_pattern(self, - 'cat /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input', '0= ') - self.vm.cmd('qom-set', path=3D'/machine/peripheral/tmp-test', + f'cat /sys/bus/i2c/devices/{bus_str}-004d/hwmon/hwmon*/temp1_i= nput', '0') + self.vm.cmd('qom-set', path=3Df'/machine/peripheral/tmp-test-{bus_= str}', property=3D'temperature', value=3D18000) exec_command_and_wait_for_pattern(self, - 'cat /sys/bus/i2c/devices/1-004d/hwmon/hwmon*/temp1_input', '1= 8000') + f'cat /sys/bus/i2c/devices/{bus_str}-004d/hwmon/hwmon*/temp1_i= nput', '18000') =20 def do_ast2700_pcie_test(self): exec_command_and_wait_for_pattern(self, @@ -99,7 +106,7 @@ def do_ast2700_pcie_test(self): 'ip addr show dev eth2', 'inet 10.0.2.15/24') =20 - def start_ast2700_test(self, name): + def start_ast2700_test(self, name, bus_id): num_cpu =3D 4 load_images_list =3D [ { @@ -128,12 +135,12 @@ def start_ast2700_test(self, name): =20 self.vm.add_args('-smp', str(num_cpu)) self.do_test_aarch64_aspeed_sdk_start( - self.scratch_file(name, 'image-bmc')) + self.scratch_file(name, 'image-bmc'), bus_id) =20 - def start_ast2700_test_vbootrom(self, name): + def start_ast2700_test_vbootrom(self, name, bus_id): self.vm.add_args('-bios', 'ast27x0_bootrom.bin') self.do_test_aarch64_aspeed_sdk_start( - self.scratch_file(name, 'image-bmc')) + self.scratch_file(name, 'image-bmc'), bus_id) =20 def test_aarch64_ast2700a1_evb_sdk_v11_00(self): self.set_machine('ast2700a1-evb') @@ -142,9 +149,9 @@ def test_aarch64_ast2700a1_evb_sdk_v11_00(self): self.archive_extract(self.ASSET_SDK_V1100_AST2700A1) self.vm.add_args('-device', 'e1000e,netdev=3Dnet1,bus=3Dpcie.2') self.vm.add_args('-netdev', 'user,id=3Dnet1') - self.start_ast2700_test('ast2700-a1') + self.start_ast2700_test('ast2700-a1', 1) self.verify_openbmc_boot_and_login('ast2700-a1') - self.do_ast2700_i2c_test() + self.do_ast2700_i2c_test(1) self.do_ast2700_pcie_test() =20 def test_aarch64_ast2700a1_evb_sdk_vbootrom_v11_00(self): @@ -154,7 +161,7 @@ def test_aarch64_ast2700a1_evb_sdk_vbootrom_v11_00(self= ): self.archive_extract(self.ASSET_SDK_V1100_AST2700A1) self.vm.add_args('-device', 'e1000e,netdev=3Dnet1,bus=3Dpcie.2') self.vm.add_args('-netdev', 'user,id=3Dnet1') - self.start_ast2700_test_vbootrom('ast2700-a1') + self.start_ast2700_test_vbootrom('ast2700-a1', 1) self.verify_vbootrom_firmware_flow() self.verify_openbmc_boot_start() =20 --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201413; cv=none; d=zohomail.com; s=zohoarc; b=XspAfepw0usXN8cSPnR7BAwFUoNHKWdQriA2+kiuem8nEfoOWNUdlvUps1iflE/IGI1TWyjIV1faNdNhtTcj7gifzTFzEX89rSTVqKXBPrxsrBd1JHlRrdOPMokuChdvqF2HPSXaUezOfc+Nt0jA6YP0jh/UR8j7drdDVW1UINE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201413; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UNo2vv9aQLCkD776mwCo37Nfsvyu+C7/DmNPeMHG+Mc=; b=MposejockHFYCLWU87jgnrnXYZlMpyBhwAqQ8VUqCrXLw4imbhQT5scxgkXZBEeQ2h6t8Hb3Oe/j0KLkqje6keAgEVClcywleEpnc9C3w7HMLpt7F1SJES81sUJ2LqAUByWBbNCPdLmF/GH10B1NtEEApusiJXF1di2A56Zu41g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201413945489.5804277141805; Wed, 4 Feb 2026 02:36:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCw-0004Bf-DI; Wed, 04 Feb 2026 05:34:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaCF-0002mA-Ga for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaCC-0004F2-Q5 for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:19 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-568-d-N_1qqGPGGaBkwZkiilzQ-1; Wed, 04 Feb 2026 05:33:14 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A42C318003F6; Wed, 4 Feb 2026 10:33:13 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 32FB218003F6; Wed, 4 Feb 2026 10:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UNo2vv9aQLCkD776mwCo37Nfsvyu+C7/DmNPeMHG+Mc=; b=YkGNtAtmRgXv/j3OriqljOpGvoo4Acrlq2jHgCxPJOuIS4kHsb7DMUEvDFw3GbQXH3cvHe QwIRmV19L4bjQ4wXPIH2f2LPY9e8JaHt0e3mqqLLYcu3LPk4IGia30SlN/j2x0WfLeAxOt DihZLX/FSLIL8Cy1lJBeRhDk8gv9L/4= X-MC-Unique: d-N_1qqGPGGaBkwZkiilzQ-1 X-Mimecast-MFC-AGG-ID: d-N_1qqGPGGaBkwZkiilzQ_1770201193 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 44/45] tests/functional/aarch64: Parameterize PCIe2 initialization in AST2700 Date: Wed, 4 Feb 2026 11:31:35 +0100 Message-ID: <20260204103136.1795455-45-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201416892158500 From: Kane Chen The current AST2700 functional test forces PCIe2 enablement by manually manipulating U-Boot env and FDT via the console. This sequence interferes with test cases that rely on the default boot flow of the image. Introduce a 'enable_pcie' parameter (defaulting to True) to both 'verify_openbmc_boot_start' and 'verify_openbmc_boot_and_login' methods. This allow test cases to toggle the PCIe2 initialization sequence based on their specific requirements without breaking standard boot tests. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-22-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- tests/functional/aarch64/test_aspeed_ast2700.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/functional/aarch64/test_aspeed_ast2700.py b/tests/functi= onal/aarch64/test_aspeed_ast2700.py index d7eeab9c23fd..cb1aafeb99fa 100755 --- a/tests/functional/aarch64/test_aspeed_ast2700.py +++ b/tests/functional/aarch64/test_aspeed_ast2700.py @@ -65,13 +65,14 @@ def enable_ast2700_pcie2(self): 'fdt set /soc@14000000/pcie@140d0000 status "okay"', '=3D>') exec_command(self, 'bootm go') =20 - def verify_openbmc_boot_start(self): + def verify_openbmc_boot_start(self, enable_pcie=3DTrue): wait_for_console_pattern(self, 'U-Boot 2023.10') - self.enable_ast2700_pcie2() + if enable_pcie: + self.enable_ast2700_pcie2() wait_for_console_pattern(self, 'Linux version ') =20 - def verify_openbmc_boot_and_login(self, name): - self.verify_openbmc_boot_start() + def verify_openbmc_boot_and_login(self, name, enable_pcie=3DTrue): + self.verify_openbmc_boot_start(enable_pcie) =20 wait_for_console_pattern(self, f'{name} login:') exec_command_and_wait_for_pattern(self, 'root', 'Password:') --=20 2.52.0 From nobody Sat Feb 7 05:49:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770201262; cv=none; d=zohomail.com; s=zohoarc; b=n8By90/y0JRpGIgijDlSKSnxjLzWMFqkKSIxIGYL8v23oTwEoPxJ1cyzmXX7uVvB6H8l9N6PM5kpeQOgY/jVwvScuHB9XeLcv5AdTAfRG4j+GZVqiRgfIyiivPM/dRaQVxPsYsATHUOEpjXAWAkl9HkRfXv1dbVMMlAkXJaG+Vw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770201262; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=v1LTFJ4ptpgdBtJ8ntjVnD3x8VlwLo2MxbWgXR9gVGg=; b=fWwWWzRboDR4t6xTan53VNcgGNljL4QjA3xDww6Xk4NnDHPYKps0ukNjNVkx4RzFIdYQlF7hf7e1OSlr0mKAG3K/8vzhsBMmEdLgaaE0wWQjUF+EfvpLy9RkUHue+nmVy+4BVtXgML2T1EI+s2cp4X9S3oc+HcMH/ubmnzeHTis= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770201262117749.5470282120494; Wed, 4 Feb 2026 02:34:22 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnaCl-0003nF-5K; Wed, 04 Feb 2026 05:33:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaCI-0002rx-2y for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnaCG-0004Ft-8l for qemu-devel@nongnu.org; Wed, 04 Feb 2026 05:33:21 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-363-oCeU6LptPF-wVUHnQHm-sA-1; Wed, 04 Feb 2026 05:33:16 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 93E6E19560AD; Wed, 4 Feb 2026 10:33:15 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.224.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2229F18003F6; Wed, 4 Feb 2026 10:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770201199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v1LTFJ4ptpgdBtJ8ntjVnD3x8VlwLo2MxbWgXR9gVGg=; b=bJ4RQa14RK64pz92jqRjFMQJn94B+ES98D0vgDJbUK/75sIi89F3DwNUfmz5dXsjYsTkzz MmR5s+Yduo7YCaH2xtberbvWubwKzu4zpIcZ4/yrQbT3WjzZl9A6lyTwhROaDOTIBkpWR/ zG4EIvLVqBZA18w3g+p8YmKRg0SVL5M= X-MC-Unique: oCeU6LptPF-wVUHnQHm-sA-1 X-Mimecast-MFC-AGG-ID: oCeU6LptPF-wVUHnQHm-sA_1770201195 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Kane Chen , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 45/45] tests/functional/aarch64: Add I2C test for AST1700 IO expanders Date: Wed, 4 Feb 2026 11:31:36 +0100 Message-ID: <20260204103136.1795455-46-clg@redhat.com> In-Reply-To: <20260204103136.1795455-1-clg@redhat.com> References: <20260204103136.1795455-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770201262625154100 From: Kane Chen Extend the AST2700 test suite to verify I2C connectivity on AST1700 IO expanders using the DCSCM image. This validates the new bus-label naming scheme by testing communication on both primary and expander-attached I2C buses. Signed-off-by: Kane-Chen-AS Reviewed-by: C=C3=A9dric Le Goater Link: https://lore.kernel.org/qemu-devel/20260204082113.3955407-23-kane_che= n@aspeedtech.com Signed-off-by: C=C3=A9dric Le Goater --- tests/functional/aarch64/test_aspeed_ast2700.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/tests/functional/aarch64/test_aspeed_ast2700.py b/tests/functi= onal/aarch64/test_aspeed_ast2700.py index cb1aafeb99fa..61373ffe5bd4 100755 --- a/tests/functional/aarch64/test_aspeed_ast2700.py +++ b/tests/functional/aarch64/test_aspeed_ast2700.py @@ -82,6 +82,10 @@ def verify_openbmc_boot_and_login(self, name, enable_pci= e=3DTrue): 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v= 11.00/ast2700-a1-obmc.tar.gz', 'd5ceed511cd0dfefbb102fff2d731159e0472948a28066dc0d90bcd54be76= 525') =20 + ASSET_SDK_V1100_AST2700A1_DCSCM =3D Asset( + 'https://github.com/AspeedTech-BMC/openbmc/releases/download/v= 11.00/ast2700-a1-dcscm-obmc.tar.gz', + '4f8778be176ece1b57d33c4aee13bb989be114c3e4703150eaeb6f996bd55= 87f') + def do_ast2700_i2c_test(self, bus_id): bus_str =3D str(bus_id) exec_command_and_wait_for_pattern(self, @@ -166,5 +170,18 @@ def test_aarch64_ast2700a1_evb_sdk_vbootrom_v11_00(sel= f): self.verify_vbootrom_firmware_flow() self.verify_openbmc_boot_start() =20 + def test_aarch64_ast2700a1_evb_ioexp_v11_00(self): + self.set_machine('ast2700a1-evb') + self.require_netdev('user') + + self.archive_extract(self.ASSET_SDK_V1100_AST2700A1_DCSCM) + self.vm.set_machine('ast2700a1-evb,fmc-model=3Dw25q512jv') + self.vm.add_args('-device', + 'tmp105,bus=3Dioexp0.0,address=3D0x4d,id=3Dtmp-te= st-16') + self.start_ast2700_test('ast2700-a1-dcscm', 8) + self.verify_openbmc_boot_and_login('ast2700-a1-dcscm', False) + self.do_ast2700_i2c_test(8) + self.do_ast2700_i2c_test(16) + if __name__ =3D=3D '__main__': QemuSystemTest.main() --=20 2.52.0