From nobody Tue Feb 10 02:28:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.com ARC-Seal: i=1; a=rsa-sha256; t=1770191994; cv=none; d=zohomail.com; s=zohoarc; b=Uwo4mXSnZeU3Iw4l8Lmxt8j9ItJ4O82zWVRpQzJPxawvYfYAui6IqdYSlt+el/7CI+bo48T59OxRcRFgDuw0EBbRScVVExCp+pNzOIQmF6QilE5X02WzyTqK0Ar9MGq7LuG7x/F3kMOzJ3p5ImDS6v4Y/A2/QFEAiVuRxJhFGIY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770191994; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O7UmaUaZH2MwuV93uGlmz+EHInB8iHY0nDVJhhkIj6A=; b=PhxxL2aepzluxjnzAqPUcuwl2i8PK4sdfaO4B/ls90GcLfFLQWdfuksokJTNlm24O7nlLFNNtb0UjNxujVtC0RfcwgnpzI6e/lwAXZeFw+rQG5ybVpzwAcaM7dQFotBGUaRjJmIgplu7nhlL//AZHiu3gEuEfUh/UJJa88kX/WM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770191994288109.273912588327; Tue, 3 Feb 2026 23:59:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnXnD-0001Eb-6Q; Wed, 04 Feb 2026 02:59:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnXnB-0001Cc-3M; Wed, 04 Feb 2026 02:59:17 -0500 Received: from forwardcorp1d.mail.yandex.net ([2a02:6b8:c41:1300:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnXn9-0006eL-Fx; Wed, 04 Feb 2026 02:59:16 -0500 Received: from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:1593:0:640:6beb:0]) by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 1DC98807FD; Wed, 04 Feb 2026 10:59:13 +0300 (MSK) Received: from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:b69::1:1a]) by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id lwj54n0AFCg0-fuuTrWh3; Wed, 04 Feb 2026 10:59:12 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com; s=default; t=1770191952; bh=O7UmaUaZH2MwuV93uGlmz+EHInB8iHY0nDVJhhkIj6A=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=HAQ8i6YWbmyfgk7JI2M/2y0KlOutCPPA43iGnxvStz9PkLLGbOkWV1tru3dzqOFMf kkNqlryTA0u68cUi0IG6hBAFKssIdwwj5zlKT7+OYS4KnFFTdD2acx1e8P9INcwd8m nH7IJbLf7Q60soX5XLJZN3k5b5xTE4bWo+L4xL7Q= Authentication-Results: mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.com From: Sergei Heifetz To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Sergei Heifetz Subject: [PATCH 2/4] dump/dump.c: reorder usage and assertion of block Date: Wed, 4 Feb 2026 12:57:52 +0500 Message-Id: <20260204075754.21078-3-heifetz@yandex-team.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260204075754.21078-1-heifetz@yandex-team.com> References: <20260204075754.21078-1-heifetz@yandex-team.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c41:1300:1:45:d181:df01; envelope-from=heifetz@yandex-team.com; helo=forwardcorp1d.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.com) X-ZM-MESSAGEID: 1770191996806158500 Content-Type: text/plain; charset="utf-8" Reorder the code so the assertion of block occurs before it is used in the subsequent lines. Signed-off-by: Sergei Heifetz Reviewed-by: Laurent Vivier --- dump/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dump/dump.c b/dump/dump.c index f7a99a7af2..80ed6c8d21 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -1288,6 +1288,7 @@ static bool get_next_page(GuestPhysBlock **blockptr, = uint64_t *pfnptr, /* block =3D=3D NULL means the start of the iteration */ if (!block) { block =3D QTAILQ_FIRST(&s->guest_phys_blocks.head); + assert(block); *blockptr =3D block; addr =3D block->target_start; *pfnptr =3D dump_paddr_to_pfn(s, addr); @@ -1295,7 +1296,6 @@ static bool get_next_page(GuestPhysBlock **blockptr, = uint64_t *pfnptr, *pfnptr +=3D 1; addr =3D dump_pfn_to_paddr(s, *pfnptr); } - assert(block !=3D NULL); =20 while (1) { if (addr >=3D block->target_start && addr < block->target_end) { --=20 2.34.1