From nobody Sat Feb 7 05:57:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.com ARC-Seal: i=1; a=rsa-sha256; t=1770191972; cv=none; d=zohomail.com; s=zohoarc; b=CiV/BxnaC9FVOou8nyV5JJHz9P7OavmZcwmJWvbQsnwEFsKkJFKX/XBh47VgHEL5snZjs+p04qc/yg64RaR7BmmNVihZh6lp7CcNgv1MDE9ublURxhXpsGwMfBSJn1oX8jmmgs0/ittyjdkyTeHAJ+ppVrVxBsM9iRt1hM7Jg0U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770191972; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=x2BACitWrsPLZRV91SG2I0BF2s7UC2JexW9F7xC6lbQ=; b=Y9jnly96yVnBDEpkUjOJ60lw56Jvt0F7vZE+lZhJ9zqeYVKzYJAD9gD9nh9QuY3oAJo+Cczw2iS/WvzdrUWTDIsjmTFOHX9gBUvjkMNv5IP8q0Q9wZFaho9iO5cA68LTXGC1cY5OuSvCuG9/fFkHY36nYdie9qsmEvOsvLzjQ30= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770191972389917.3118609690831; Tue, 3 Feb 2026 23:59:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnXn8-00017T-Fv; Wed, 04 Feb 2026 02:59:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnXn5-00014q-6a; Wed, 04 Feb 2026 02:59:11 -0500 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnXn1-0006dm-Gt; Wed, 04 Feb 2026 02:59:08 -0500 Received: from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:1593:0:640:6beb:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 8AF9880830; Wed, 04 Feb 2026 10:59:03 +0300 (MSK) Received: from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:b69::1:1a]) by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id lwj54n0AFCg0-u4HaURiD; Wed, 04 Feb 2026 10:59:02 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com; s=default; t=1770191943; bh=x2BACitWrsPLZRV91SG2I0BF2s7UC2JexW9F7xC6lbQ=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=bgwi40WTPlhpQPPu3yJwCIjMq6SidAZO1av0ujkEttISLh9rC1VOXZPNRUEKiOcoT /Zf6TFcvxvG23dXVAUVYNzNgSDfZf1pupiN3IZZrFP0Nf6Mdhz1Tqjycqzbf+dmxUw Je2rt+O1a1ISR748AwCQIcPgOl73/A3F8GPVcZMw= Authentication-Results: mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.com From: Sergei Heifetz To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Sergei Heifetz Subject: [PATCH 1/4] migration/savevm.c: reorder usage and assertion of mis->from_src_file Date: Wed, 4 Feb 2026 12:57:51 +0500 Message-Id: <20260204075754.21078-2-heifetz@yandex-team.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260204075754.21078-1-heifetz@yandex-team.com> References: <20260204075754.21078-1-heifetz@yandex-team.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=heifetz@yandex-team.com; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.com) X-ZM-MESSAGEID: 1770191976360154100 Content-Type: text/plain; charset="utf-8" Reorder the code so the assertion of mis->from_src_file occurs before the call to migration_ioc_unregister_yank_from_file, which dereferences it in qemu_file_get_ioc. Fixes: 39675ffffb3394 ("migration: Move the yank unregister of channel_clos= e out") Signed-off-by: Sergei Heifetz Reviewed-by: Laurent Vivier --- migration/savevm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/savevm.c b/migration/savevm.c index 3dc812a7bb..930a3391e3 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2885,13 +2885,14 @@ static bool postcopy_pause_incoming(MigrationIncomi= ngState *mis) =20 assert(migrate_postcopy_ram()); =20 + assert(mis->from_src_file); + /* * Unregister yank with either from/to src would work, since ioc behin= d it * is the same */ migration_ioc_unregister_yank_from_file(mis->from_src_file); =20 - assert(mis->from_src_file); qemu_file_shutdown(mis->from_src_file); qemu_fclose(mis->from_src_file); mis->from_src_file =3D NULL; --=20 2.34.1 From nobody Sat Feb 7 05:57:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.com ARC-Seal: i=1; a=rsa-sha256; t=1770191994; cv=none; d=zohomail.com; s=zohoarc; b=Uwo4mXSnZeU3Iw4l8Lmxt8j9ItJ4O82zWVRpQzJPxawvYfYAui6IqdYSlt+el/7CI+bo48T59OxRcRFgDuw0EBbRScVVExCp+pNzOIQmF6QilE5X02WzyTqK0Ar9MGq7LuG7x/F3kMOzJ3p5ImDS6v4Y/A2/QFEAiVuRxJhFGIY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770191994; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O7UmaUaZH2MwuV93uGlmz+EHInB8iHY0nDVJhhkIj6A=; b=PhxxL2aepzluxjnzAqPUcuwl2i8PK4sdfaO4B/ls90GcLfFLQWdfuksokJTNlm24O7nlLFNNtb0UjNxujVtC0RfcwgnpzI6e/lwAXZeFw+rQG5ybVpzwAcaM7dQFotBGUaRjJmIgplu7nhlL//AZHiu3gEuEfUh/UJJa88kX/WM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770191994288109.273912588327; Tue, 3 Feb 2026 23:59:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnXnD-0001Eb-6Q; Wed, 04 Feb 2026 02:59:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnXnB-0001Cc-3M; Wed, 04 Feb 2026 02:59:17 -0500 Received: from forwardcorp1d.mail.yandex.net ([2a02:6b8:c41:1300:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnXn9-0006eL-Fx; Wed, 04 Feb 2026 02:59:16 -0500 Received: from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:1593:0:640:6beb:0]) by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 1DC98807FD; Wed, 04 Feb 2026 10:59:13 +0300 (MSK) Received: from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:b69::1:1a]) by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id lwj54n0AFCg0-fuuTrWh3; Wed, 04 Feb 2026 10:59:12 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com; s=default; t=1770191952; bh=O7UmaUaZH2MwuV93uGlmz+EHInB8iHY0nDVJhhkIj6A=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=HAQ8i6YWbmyfgk7JI2M/2y0KlOutCPPA43iGnxvStz9PkLLGbOkWV1tru3dzqOFMf kkNqlryTA0u68cUi0IG6hBAFKssIdwwj5zlKT7+OYS4KnFFTdD2acx1e8P9INcwd8m nH7IJbLf7Q60soX5XLJZN3k5b5xTE4bWo+L4xL7Q= Authentication-Results: mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.com From: Sergei Heifetz To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Sergei Heifetz Subject: [PATCH 2/4] dump/dump.c: reorder usage and assertion of block Date: Wed, 4 Feb 2026 12:57:52 +0500 Message-Id: <20260204075754.21078-3-heifetz@yandex-team.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260204075754.21078-1-heifetz@yandex-team.com> References: <20260204075754.21078-1-heifetz@yandex-team.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c41:1300:1:45:d181:df01; envelope-from=heifetz@yandex-team.com; helo=forwardcorp1d.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.com) X-ZM-MESSAGEID: 1770191996806158500 Content-Type: text/plain; charset="utf-8" Reorder the code so the assertion of block occurs before it is used in the subsequent lines. Signed-off-by: Sergei Heifetz Reviewed-by: Laurent Vivier --- dump/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dump/dump.c b/dump/dump.c index f7a99a7af2..80ed6c8d21 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -1288,6 +1288,7 @@ static bool get_next_page(GuestPhysBlock **blockptr, = uint64_t *pfnptr, /* block =3D=3D NULL means the start of the iteration */ if (!block) { block =3D QTAILQ_FIRST(&s->guest_phys_blocks.head); + assert(block); *blockptr =3D block; addr =3D block->target_start; *pfnptr =3D dump_paddr_to_pfn(s, addr); @@ -1295,7 +1296,6 @@ static bool get_next_page(GuestPhysBlock **blockptr, = uint64_t *pfnptr, *pfnptr +=3D 1; addr =3D dump_pfn_to_paddr(s, *pfnptr); } - assert(block !=3D NULL); =20 while (1) { if (addr >=3D block->target_start && addr < block->target_end) { --=20 2.34.1 From nobody Sat Feb 7 05:57:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.com ARC-Seal: i=1; a=rsa-sha256; t=1770191976; cv=none; d=zohomail.com; s=zohoarc; b=C3CLkfy5qm60ddplbbzYmtSeKU8XTUyToHYrZey6q98yGFmwVSC4k5waXdyul/TEa6D9NIYedI8jiRb0CZID3sFibFQOFRvgYTJOTulyxt0UnD5mS5BzCpvqJT5sb4b2fuJYXO/thxz/uj/uyQ4jOVy04LR+mJ58kdb2vcQ10xI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770191976; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UHU9Dy999JbdfZUCbL2Sk0go2qkJy0vkTJ6o0pzdJUw=; b=LhnmNlaBpgUAXJxsYawh2ekYBrz9DZZV2x4qZLnM+rAykqzwwGLO7wroUT9/4EJz1MG2Ln8JdCkdaZdkLBKdkR3eveLjxQWfK5y4zE3PQMulcKvD2u8jTmMOz2H8A+LPAkdeEJoKn7nm3CXbxE+6G8VmlEyvOVWIv7vtOKpg4rw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770191975445971.0758185390595; Tue, 3 Feb 2026 23:59:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnXnM-0001GF-E5; Wed, 04 Feb 2026 02:59:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnXnF-0001FS-Pp; Wed, 04 Feb 2026 02:59:22 -0500 Received: from forwardcorp1b.mail.yandex.net ([178.154.239.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnXnE-0006et-Bk; Wed, 04 Feb 2026 02:59:21 -0500 Received: from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:1593:0:640:6beb:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 53AEC8079A; Wed, 04 Feb 2026 10:59:18 +0300 (MSK) Received: from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:b69::1:1a]) by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id lwj54n0AFCg0-TTdKlju7; Wed, 04 Feb 2026 10:59:17 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com; s=default; t=1770191957; bh=UHU9Dy999JbdfZUCbL2Sk0go2qkJy0vkTJ6o0pzdJUw=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=Zk07wVo7chUtktDb+YsuOxIbXy1AafhB5CEw9Fnb4fjghFFudth2TpJBwYilZAHEJ b7itWisz8Oa51cFMfiIVq5wiINMK92dS6gfHBZghZUqTIYxzDrLj+7C5ZQ9Mrucq7M DTdY24nk/jnuiyPiFFlFSPkdHTHuHY0aQIAwI8ZQ= Authentication-Results: mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.com From: Sergei Heifetz To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Sergei Heifetz Subject: [PATCH 3/4] system/physmem.c: reorder usage and assertion of block Date: Wed, 4 Feb 2026 12:57:53 +0500 Message-Id: <20260204075754.21078-4-heifetz@yandex-team.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260204075754.21078-1-heifetz@yandex-team.com> References: <20260204075754.21078-1-heifetz@yandex-team.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.136; envelope-from=heifetz@yandex-team.com; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.com) X-ZM-MESSAGEID: 1770191979069158500 Content-Type: text/plain; charset="utf-8" Reorder the code so the assertion of block occurs before it is used in the subsequent lines. Signed-off-by: Sergei Heifetz --- system/physmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/physmem.c b/system/physmem.c index b0311f4531..4308e02940 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -2054,11 +2054,11 @@ static int memory_try_enable_merging(void *addr, si= ze_t len) */ int qemu_ram_resize(RAMBlock *block, ram_addr_t newsize, Error **errp) { + assert(block); + const ram_addr_t oldsize =3D block->used_length; const ram_addr_t unaligned_size =3D newsize; =20 - assert(block); - newsize =3D TARGET_PAGE_ALIGN(newsize); newsize =3D REAL_HOST_PAGE_ALIGN(newsize); =20 --=20 2.34.1 From nobody Sat Feb 7 05:57:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.com ARC-Seal: i=1; a=rsa-sha256; t=1770191996; cv=none; d=zohomail.com; s=zohoarc; b=bSk5/aL+sCWFmZnB1ixfxwUiIIyjXwq0znGFlmq1kUrHUsdHlsHAnPML8HYLv9LXhyUoKtGK7RVUtT7/Lo3yp23Hk+YEy0MuyPGOUA+7ZHqBORf7Yk1J+63XubThgzsoP2NYsSMlQ6goPvnWNt+uhUODih8YHqil3JRdqIcNP3U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770191996; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Qsul4O4z95xq9yphmhSiylpmeGjeIrFHxIxrbO2rFYY=; b=QjRmt7fPG4qnmEftZwpGIl3isSRn61yJ2AgYhMQIQb2c7xZuzMbfrMS/V/gkmCfgK9UcCM0y07TZnVK7aQmI0kpE/GyTSiZ5T1hFp18k65w42tgLhC9JK/6ry2VRIWx5sLTdNlaugpY7708iu3i6g/ZEMmn5r+QH1R831HIIsOc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177019199673323.07660199365705; Tue, 3 Feb 2026 23:59:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnXnO-0001RO-FR; Wed, 04 Feb 2026 02:59:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnXnL-0001Jk-8C; Wed, 04 Feb 2026 02:59:28 -0500 Received: from forwardcorp1b.mail.yandex.net ([178.154.239.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnXnJ-0006fH-SY; Wed, 04 Feb 2026 02:59:27 -0500 Received: from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:1593:0:640:6beb:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id D4BF58083B; Wed, 04 Feb 2026 10:59:23 +0300 (MSK) Received: from heifetz-lin.yandex-team.ru (unknown [2a02:6bf:8080:b69::1:1a]) by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id lwj54n0AFCg0-mJihOebZ; Wed, 04 Feb 2026 10:59:23 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com; s=default; t=1770191963; bh=Qsul4O4z95xq9yphmhSiylpmeGjeIrFHxIxrbO2rFYY=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=cQD0cs39i5F+N5cTn8DwI3051eRMMeK2ybrrsIZfj5ezMf2HHWpJJUM7J5HYZNuIn x9/aEX7FNDFsPXfoSoQ9V1OjTSiisFrjVIXURHO15AUXPP6KzlmmaglN9hQ7mGgKco UaolJJlULQbfhjpDGzk8wcOOO7C/Smg8vBglCI30= Authentication-Results: mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.com From: Sergei Heifetz To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Sergei Heifetz Subject: [PATCH 4/4] hw/usb/core.c: reorder usage and assertion of p->ep Date: Wed, 4 Feb 2026 12:57:54 +0500 Message-Id: <20260204075754.21078-5-heifetz@yandex-team.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260204075754.21078-1-heifetz@yandex-team.com> References: <20260204075754.21078-1-heifetz@yandex-team.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.136; envelope-from=heifetz@yandex-team.com; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.com) X-ZM-MESSAGEID: 1770191999762154100 Content-Type: text/plain; charset="utf-8" Reorder the code so the assertion of p->ep occurs before it is used in the subsequent lines. Signed-off-by: Sergei Heifetz Reviewed-by: Laurent Vivier --- hw/usb/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/core.c b/hw/usb/core.c index b3f811c513..9572a870cc 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -423,10 +423,10 @@ void usb_handle_packet(USBDevice *dev, USBPacket *p) p->status =3D USB_RET_NODEV; return; } + assert(p->ep); assert(dev =3D=3D p->ep->dev); assert(dev->state =3D=3D USB_STATE_DEFAULT); usb_packet_check_state(p, USB_PACKET_SETUP); - assert(p->ep !=3D NULL); =20 /* Submitting a new packet clears halt */ if (p->ep->halted) { --=20 2.34.1