From nobody Sat Feb 7 05:53:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770159684; cv=none; d=zohomail.com; s=zohoarc; b=hOxZDmHX6RMQVCtdBun3c0FTMaHj9730aoqQgp7FMbJPBGXprBG0X1xQE/+rbdSY0NWGqE13OaB/a0Iknc5xffR+6NM7ukp2qRqpbQ83JaHBMaPEuoOfkn3ANEQeM+NG8dBK24Sw/l+Y+icR7W+qIdv/VUvavt7M/XivWB20ntM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770159684; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gyCOlYHu5QJOiJNJo/S/cqdZ5Xq9v1xJdHYg0hHKNtQ=; b=T1f4Lsn/ICOrl+Ox9zNZY17m9gIcWpZzuTf7OiF9I2BrX1Byr8gKLwy5kfR5xA5UYKgVZUWnFnfgSz6w57jqZPSRaRDHEKUvDSHYH3DqYGPQomU8ZTgVvUsv8wSiqdZtepUb+gIr0spsdeVTFSRADV7B6S0walSQAukdjEOSQzI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770159684324725.6881246837363; Tue, 3 Feb 2026 15:01:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnPOO-0005xm-UM; Tue, 03 Feb 2026 18:01:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnPON-0005xU-Is for qemu-devel@nongnu.org; Tue, 03 Feb 2026 18:01:07 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnPOL-0006A9-Tp for qemu-devel@nongnu.org; Tue, 03 Feb 2026 18:01:07 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-43596062728so179968f8f.1 for ; Tue, 03 Feb 2026 15:01:05 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436180659b8sm1673406f8f.43.2026.02.03.15.01.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 15:01:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770159664; x=1770764464; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gyCOlYHu5QJOiJNJo/S/cqdZ5Xq9v1xJdHYg0hHKNtQ=; b=ZJF5pKQqgZDizet3LkA5X/CGx+jEEXYmfL0nZWZPFTF0SXFSipreRJNhVjyChHxRIw Pw7T12Q0LvGY4azfD1lnQvaq/xH1N9iFInDP/8tRF3mlEdxDWGqC0vVxbfPJipFQOZdC Z6UXsl4hh+UVdgEbl+/GLWUgbuIpwb1OX166c5W13+O2eQjPl5V1h3X1UxsqFRWj1YDC xr5AlnK4O7KBoTNChZxVG4uTVNFvjolE75IOJvsXeWq9Y5XehEIUHenOzO855n6Gkh/s E5KXtVvhA8XHc1QKJMw02Yy3dTU6egCIXFeyVz61L9n+BIr/BdPstzMkZ0j5PCzhFZdt gBpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770159664; x=1770764464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gyCOlYHu5QJOiJNJo/S/cqdZ5Xq9v1xJdHYg0hHKNtQ=; b=PBBKj4SFrnYZCrtKqtArCryyiu1UggCISaGsZmDm35lakho6kNvHUpBg/SxcdmS7cb IJTQKNZFWqDhi0yuZF0U1HTbsAFC0m3RyDaDeEKaMycQzxK9K1zH+bI95pMugHYd8bqP j/6W7CvumbV6xbqovRJdsexiBJ4JYNb57GjxGN9n4pUALNTu4KdfEU/g3M1RMbXDmOvx k0ULAoAAbpk/bB6yZksdfhpB9Bv7FNUWbQ7ugy9IflPhQlqIhiFxgeEfQiOH8quq+xkO 8btr5zPTVZO29E1+e8EoqiEe67o7ibX9rQP34wBE/XIV+NOZ+gGqYKGLlIDBZWJkkl0n wwPg== X-Gm-Message-State: AOJu0Ywl1Nz5lIY66L1W64+a9M0uzOH+6gSWsba4YkCRTcDyVVqwOiFy ESPLTN10Q0bFOayjC2R7pDM3N6pcKKn7X47Mg1Eio3nm9xnEjPSpWmdIpCTwnLcd8khVOD/UAv6 pu3tUcSY= X-Gm-Gg: AZuq6aJWQ9h0wx9r+HZ5fPvEDTVkABbP1Tnv1zzJalCPy9Z/1vbQTieVdESIDpvhT6I X1So5uNegbv6T9xt0Vv4K+hIb/kzQU+9/kR601u/Uwy5WUaYfUTGhvoRQzNcOvoaUYrHI902wsd oLqIv3CNCLQeknVCr/XizwjGPsiF+FKiyRdjHI55lOrcTFO2A2z7UNKrZ7LNa9Zx7BO9I7tR2Q7 sojOsT0o5MWGH9d5zI2Ffys1dPQ287spdCEc0AqXBLzoTCFHq0CPMxHI85zHZ7/6o4fBk6l752t N9WECWtAT6NgVGX1RwZprJP10YKlMxIX0gQoLc5c8dZVCQbkfaT8Unpgm+zIpQvDGovpDLnf+Qz vDXLb+F8fYOKzGaIPVBFCg6YdpL9vXrBZdexLzw0m8vIXACxFEbltjN8n0TcmcFoKP7HwrM1qlg t7fm6DV87varF/zBJ9KSTYi5ZG1Nabzad2lSaV3tW2BDcjPbOrAe6dMTBrg67f X-Received: by 2002:a05:6000:18a7:b0:435:db9b:5881 with SMTP id ffacd0b85a97d-43617c8d34emr1479454f8f.25.1770159663611; Tue, 03 Feb 2026 15:01:03 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Paolo Bonzini , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v4 1/5] qemu/int128: Add int128_signextend() Date: Wed, 4 Feb 2026 00:00:50 +0100 Message-ID: <20260203230054.23667-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203230054.23667-1-philmd@linaro.org> References: <20260203230054.23667-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770159687061158500 Add a method to sign-extend a Int128, along with unit tests. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/qemu/int128.h | 10 ++++++++++ tests/unit/test-int128.c | 22 ++++++++++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/include/qemu/int128.h b/include/qemu/int128.h index 7b3b071c512..c2d6c183393 100644 --- a/include/qemu/int128.h +++ b/include/qemu/int128.h @@ -62,6 +62,11 @@ static inline Int128 int128_exts64(int64_t a) return a; } =20 +static inline Int128 int128_signextend(Int128 a) +{ + return int128_gethi(a) ? a : int128_exts64(int128_getlo(a)); +} + static inline Int128 int128_not(Int128 a) { return ~a; @@ -295,6 +300,11 @@ static inline Int128 int128_exts64(int64_t a) return int128_make128(a, (a < 0) ? -1 : 0); } =20 +static inline Int128 int128_signextend(Int128 a) +{ + return a.hi ? a : int128_exts64(a.lo); +} + static inline Int128 int128_not(Int128 a) { return int128_make128(~a.lo, ~a.hi); diff --git a/tests/unit/test-int128.c b/tests/unit/test-int128.c index 25db2455e80..526abd02e03 100644 --- a/tests/unit/test-int128.c +++ b/tests/unit/test-int128.c @@ -255,6 +255,27 @@ static void test_urshift(void) 0x8000000000000000ULL); } =20 +static void __attribute__((__noinline__)) ATTRIBUTE_NOCLONE +test_signextend_one(uint64_t ah, uint64_t al, uint64_t rh, uint64_t rl) +{ + Int128 r =3D int128_make128(rl, rh); + Int128 s =3D int128_signextend(int128_make128(al, ah)); + g_assert_cmphex(int128_getlo(r), =3D=3D, int128_getlo(s)); + g_assert_cmphex(int128_gethi(r), =3D=3D, int128_gethi(s)); +} + +static void test_signextend(void) +{ + test_signextend_one(0x0000000000000000ULL, 0x0000000000000001ULL, + 0x0000000000000000ULL, 0x0000000000000001ULL); + test_signextend_one(0x0000000000000000ULL, 0x7FFFFFFFFFFFFFFEULL, + 0x0000000000000000ULL, 0x7FFFFFFFFFFFFFFEULL); + test_signextend_one(0x0000000000000000ULL, 0x8000000000000001ULL, + 0xFFFFFFFFFFFFFFFFULL, 0x8000000000000001ULL); + test_signextend_one(0xFFFFFFFFFFFFFFFFULL, 0xFFFFFFFFFFFFFFFEULL, + 0xFFFFFFFFFFFFFFFFULL, 0xFFFFFFFFFFFFFFFEULL); +} + int main(int argc, char **argv) { g_test_init(&argc, &argv, NULL); @@ -269,5 +290,6 @@ int main(int argc, char **argv) g_test_add_func("/int128/int128_gt", test_gt); g_test_add_func("/int128/int128_rshift", test_rshift); g_test_add_func("/int128/int128_urshift", test_urshift); + g_test_add_func("/int128/int128_signextend", test_signextend); return g_test_run(); } --=20 2.52.0 From nobody Sat Feb 7 05:53:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770159697; cv=none; d=zohomail.com; s=zohoarc; b=kyVZqhf1XZDgtDPpykKiUfidDWeUfcDwwksme9K6JNYc4PSHzIcq0mqmlBYCJkWRhKIKPKTZ2JFmWOXyltgVWZFssYXizrRRoJtkjXQ9fLptYbLZjV0xgijnOXr+5oG/xrwJSRoxHMjnQJBiQaWhphzV6Td9my3l/IBrLVUVxPU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770159697; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Fki7Z7lvkxs4LTNUjYTuJYA3h2xrMJ2tqxVaedVRuZM=; b=bCekslgYfUWnLlOGikycGq9K26wthcVQNKeaTRggZXKnJ09oXQ+FN+BrcthaUZAJWhL4AwT9kqOZlYX6EadqpMl8BEsffE2g+Fr/ba6i8bsN4wWiaNxxN01KSVaYAzn5q/Vpt4YDONbyKEnEw+YYrhsq+QeO3Txb418M8E9PDqc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770159697287969.7608648307138; Tue, 3 Feb 2026 15:01:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnPOZ-0005yO-Hc; Tue, 03 Feb 2026 18:01:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnPOV-0005y9-3M for qemu-devel@nongnu.org; Tue, 03 Feb 2026 18:01:15 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnPOS-0006Av-Fu for qemu-devel@nongnu.org; Tue, 03 Feb 2026 18:01:13 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-483100e97d8so526325e9.2 for ; Tue, 03 Feb 2026 15:01:12 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48310928f1fsm1291235e9.14.2026.02.03.15.01.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 15:01:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770159670; x=1770764470; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fki7Z7lvkxs4LTNUjYTuJYA3h2xrMJ2tqxVaedVRuZM=; b=C/nLyhfB1B9yjff440lEqhFQnsfW/zj/x+PkPCEBvGzgc6nM0oGXGyk+FsaNrsOtuc Jj1unOTfJOFJE86TYR42LAPKQRD0OdDv4JtQcpm85baGyQvVTqyc/qT0a1OBomnuoVex pclwr6Z6v8pTQZY2pF/y8lvv/dD0vcQZ5vPOkgXcfUzvW22RpORaHoMy73jnCCaHEjU0 wgdnpZbT3a2xiY8+IIPoxU/aqvRo9XYMg/Th6GCi5VJuJbW7p6DzifEiNHpcF2gqMD5z 7FHAOQ7Wl++G1XyqpZtNnkGs3kLY5Wcw2oqfgIUh1iykWmA15Sgg5w59CZD4HZKCIxk9 BPEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770159670; x=1770764470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Fki7Z7lvkxs4LTNUjYTuJYA3h2xrMJ2tqxVaedVRuZM=; b=K8nYtMSpcmEzl8PCIZ8jTXzNyGB9ci4zvREUalPuD/ZkUbMP7bgpCRYGnoBHF2zSjh a2TydlCjFWaCFCy0uf8jUMwnp5DYI9rBT5Ac7WasSxSeq/RPLXO36GWhqcll1HRtFLCw hPcnXVZq+ugRh/WdSzlHFjmFBa2YgSsi6YCyjxM6OYIiWdhO8VN/mqmrpOdGMkp6FU/K JdOCVkU4Eu83iaOacoN6BRIJhDa5DEBt+FfywGs6ND9AvpCTD7LaxNkkNDl+oc/DNjaZ 1SJfs7U7YDLrPN73NPbk20RCFM9jJvP/c3zx17nn40EEuYI8zaQrRAnZ4SU9SZ/ILBq5 If+Q== X-Gm-Message-State: AOJu0YzmRddhJL2VgbB4P59TQrDRuPKufkj5iWO2R4326/5wySj7sRNe UmyASwhr0xnZvL1NPW+VjMpYqsoEhc6AYR/39LXmuaTtSsikvaJjQpmvem1n9+MHuMHL4QFW3Ff 8FVdDOME= X-Gm-Gg: AZuq6aJfvjM2H1PJp6pKw0VITTRsz5pQs7xst2gimLTm91/pHh5QbBu9E7dk6PuMpwv HocyK6OulYnRfBoVCwLQmQ/GpgHAgJQjqgM4gbzNWqjshOUBjzLywBb8LXcS6YmCcHb1LM0ijrl rpB72WEjW+07p5iA+88LAbAE7bA4tnpuo+9wYzPJJCrWYqS/5vJtTpuzgTZt1tIXeH/yhaggTCZ mN/dZX6BYHfGaUk31CWW8GdsrlBW7VVvz4CG90uItSblONVO7heavLoBX+BTvcqH6LFpOTi+b3O rgliHoSUQ3OLIZkuWjuK0drbFN3X4mKLQkqh4n0lB42uW/g5MFX26CWMjQWFp0kI/5+p8Pncval nrUfp44IRbGHjoQm0L/5EjQYz8fAg3+RgVRVi/wVanx/rORvJd7EMWvQ0E7ralxhl4HxYaqA+YV oGN1twkutxZnR4fLQ8CHjmtw1IXshDYV8PqxubW49Eh03+zkMLNuKOfdVZrbZI X-Received: by 2002:a05:600c:c4ab:b0:475:dd9a:f791 with SMTP id 5b1f17b1804b1-4830e9795d3mr14357965e9.28.1770159670552; Tue, 03 Feb 2026 15:01:10 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Paolo Bonzini , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v4 2/5] accel/tcg: Have cpu_ld*_mmu() methods consider the MO_SIGN flag Date: Wed, 4 Feb 2026 00:00:51 +0100 Message-ID: <20260203230054.23667-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203230054.23667-1-philmd@linaro.org> References: <20260203230054.23667-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770159699016158500 Sign-extend the result when the MO_SIGN flag is requested in TCG common CPU TLB handling. Remote the SPARC specific handling. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/cputlb.c | 37 +++++++++++++++++++++++++++++++------ target/sparc/ldst_helper.c | 9 --------- 2 files changed, 31 insertions(+), 15 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 76546c66515..97782997881 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -2296,12 +2296,18 @@ static uint8_t do_ld1_mmu(CPUState *cpu, vaddr addr= , MemOpIdx oi, { MMULookupLocals l; bool crosspage; + uint8_t ret; =20 cpu_req_mo(cpu, TCG_MO_LD_LD | TCG_MO_ST_LD); crosspage =3D mmu_lookup(cpu, addr, oi, ra, access_type, &l); tcg_debug_assert(!crosspage); =20 - return do_ld_1(cpu, &l.page[0], l.mmu_idx, access_type, ra); + ret =3D do_ld_1(cpu, &l.page[0], l.mmu_idx, access_type, ra); + + if (l.memop & MO_SIGN) { + ret =3D (int8_t)ret; + } + return ret; } =20 static uint16_t do_ld2_mmu(CPUState *cpu, vaddr addr, MemOpIdx oi, @@ -2315,7 +2321,8 @@ static uint16_t do_ld2_mmu(CPUState *cpu, vaddr addr,= MemOpIdx oi, cpu_req_mo(cpu, TCG_MO_LD_LD | TCG_MO_ST_LD); crosspage =3D mmu_lookup(cpu, addr, oi, ra, access_type, &l); if (likely(!crosspage)) { - return do_ld_2(cpu, &l.page[0], l.mmu_idx, access_type, l.memop, r= a); + ret =3D do_ld_2(cpu, &l.page[0], l.mmu_idx, access_type, l.memop, = ra); + goto return_signextended; } =20 a =3D do_ld_1(cpu, &l.page[0], l.mmu_idx, access_type, ra); @@ -2326,6 +2333,10 @@ static uint16_t do_ld2_mmu(CPUState *cpu, vaddr addr= , MemOpIdx oi, } else { ret =3D b | (a << 8); } +return_signextended: + if (l.memop & MO_SIGN) { + ret =3D (int16_t)ret; + } return ret; } =20 @@ -2339,7 +2350,8 @@ static uint32_t do_ld4_mmu(CPUState *cpu, vaddr addr,= MemOpIdx oi, cpu_req_mo(cpu, TCG_MO_LD_LD | TCG_MO_ST_LD); crosspage =3D mmu_lookup(cpu, addr, oi, ra, access_type, &l); if (likely(!crosspage)) { - return do_ld_4(cpu, &l.page[0], l.mmu_idx, access_type, l.memop, r= a); + ret =3D do_ld_4(cpu, &l.page[0], l.mmu_idx, access_type, l.memop, = ra); + goto return_signextended; } =20 ret =3D do_ld_beN(cpu, &l.page[0], 0, l.mmu_idx, access_type, l.memop,= ra); @@ -2347,6 +2359,10 @@ static uint32_t do_ld4_mmu(CPUState *cpu, vaddr addr= , MemOpIdx oi, if ((l.memop & MO_BSWAP) =3D=3D MO_LE) { ret =3D bswap32(ret); } +return_signextended: + if (l.memop & MO_SIGN) { + ret =3D (int32_t)ret; + } return ret; } =20 @@ -2360,7 +2376,8 @@ static uint64_t do_ld8_mmu(CPUState *cpu, vaddr addr,= MemOpIdx oi, cpu_req_mo(cpu, TCG_MO_LD_LD | TCG_MO_ST_LD); crosspage =3D mmu_lookup(cpu, addr, oi, ra, access_type, &l); if (likely(!crosspage)) { - return do_ld_8(cpu, &l.page[0], l.mmu_idx, access_type, l.memop, r= a); + ret =3D do_ld_8(cpu, &l.page[0], l.mmu_idx, access_type, l.memop, = ra); + goto return_signextended; } =20 ret =3D do_ld_beN(cpu, &l.page[0], 0, l.mmu_idx, access_type, l.memop,= ra); @@ -2368,6 +2385,10 @@ static uint64_t do_ld8_mmu(CPUState *cpu, vaddr addr= , MemOpIdx oi, if ((l.memop & MO_BSWAP) =3D=3D MO_LE) { ret =3D bswap64(ret); } +return_signextended: + if (l.memop & MO_SIGN) { + ret =3D (int64_t)ret; + } return ret; } =20 @@ -2396,7 +2417,7 @@ static Int128 do_ld16_mmu(CPUState *cpu, vaddr addr, ret =3D bswap128(ret); } } - return ret; + goto return_signextended; } =20 first =3D l.page[0].size; @@ -2410,7 +2431,7 @@ static Int128 do_ld16_mmu(CPUState *cpu, vaddr addr, } else { ret =3D int128_make128(b, a); } - return ret; + goto return_signextended; } =20 if (first < 8) { @@ -2429,6 +2450,10 @@ static Int128 do_ld16_mmu(CPUState *cpu, vaddr addr, if ((l.memop & MO_BSWAP) =3D=3D MO_LE) { ret =3D bswap128(ret); } +return_signextended: + if (l.memop & MO_SIGN) { + ret =3D int128_signextend(ret); + } return ret; } =20 diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 3bc6a6827a4..e1178e53d51 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -1163,27 +1163,18 @@ uint64_t helper_ld_code(CPUSPARCState *env, target_= ulong addr, uint32_t oi) switch (mop & MO_SIZE) { case MO_8: ret =3D cpu_ldb_code_mmu(env, addr, oi, ra); - if (mop & MO_SIGN) { - ret =3D (int8_t)ret; - } break; case MO_16: ret =3D cpu_ldw_code_mmu(env, addr, oi, ra); if ((mop & MO_BSWAP) !=3D MO_TE) { ret =3D bswap16(ret); } - if (mop & MO_SIGN) { - ret =3D (int16_t)ret; - } break; case MO_32: ret =3D cpu_ldl_code_mmu(env, addr, oi, ra); if ((mop & MO_BSWAP) !=3D MO_TE) { ret =3D bswap32(ret); } - if (mop & MO_SIGN) { - ret =3D (int32_t)ret; - } break; case MO_64: ret =3D cpu_ldq_code_mmu(env, addr, oi, ra); --=20 2.52.0 From nobody Sat Feb 7 05:53:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770159694; cv=none; d=zohomail.com; s=zohoarc; b=ckj32/xlYRcM1Rq+3gi6MmBuegk3Y62TtqRA+H0kqGzDG/zxZeDIyO5fPWcZas0On7ItxEqu0kXu6xsv/l5nidRIA0lNH2IOEbnrA8a7wkoDldbfnmLcnqlc6IUun8E+giXhGDTnD1y56BuaQlKDxJ8IYBj1/A2Q/QlGm0bTtjI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770159694; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cMPkVyK650njXsWAImuRdeZzNFIoTsC8s5V4QtgoJgg=; b=EeL6srylMOsVSE2uX0/u9vAqL6WLj47HBuu2p0FbaEv1REXA6GCVKh7NEtI6japprF2hBu7JtqXcbxSuLVntGlTN2r26Mv+EEE+oDBAgjhafQBFlNwDa1TYQYdQbpH0q4+kXtVAbIsq44TLjeFwCra+VvlOOtv/Bgg0dNsyzR5I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770159694952291.7798697100336; Tue, 3 Feb 2026 15:01:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnPOe-00061Z-9I; Tue, 03 Feb 2026 18:01:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnPOa-0005yi-WC for qemu-devel@nongnu.org; Tue, 03 Feb 2026 18:01:21 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnPOZ-0006B7-Fe for qemu-devel@nongnu.org; Tue, 03 Feb 2026 18:01:20 -0500 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-4358fb60802so146953f8f.1 for ; Tue, 03 Feb 2026 15:01:19 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4361805faf7sm1903528f8f.30.2026.02.03.15.01.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 15:01:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770159677; x=1770764477; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cMPkVyK650njXsWAImuRdeZzNFIoTsC8s5V4QtgoJgg=; b=O6t9F3m27MxJNc5iNKfyYAaq2bW/gBlTEkvMlIsr9LeztT4RmqVtIGUmQoDNym50MJ i99JKsTMdnIqIC8K+0cv627sUHSuNy0i3Nsl1jdyt9TRL3P2FuLDNEYFIJvjQTIqnK+W gBNtYXXPvOG+/MjsfUMbuMzTBuLMp6pCYzQ7I06FDozUXn9DbHTDAd/Q0RueN5D+q8nx YrZMInBV8ncMG2iDxtwsC02aGjlU69TlGuv5yCmQhE8O4ooYpZwpu7FXKq6HRyOJoD76 NabTkMLvXGdYMORX6LQF4aChUnOt/JqFCK06Zop1Cl/OWslbonAqOOkPZr4+x5TFYqyM qbyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770159677; x=1770764477; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cMPkVyK650njXsWAImuRdeZzNFIoTsC8s5V4QtgoJgg=; b=stsfzOkaadbEJ8quZV2UaycGjVd+uWqeWKPaocZjgu6ecubvKFD90+QAia4g6bUGRT 4RiUAf8s56mx3SnQCrkhhIkQwi3rYLDi29cDa7B1e/nEV8mPEDmf120ejMv1aNwq2Qfq Tu158v6ztidHStA7mitrUNNUW9svSCoMGwygncVtt7YeDn8wEHukinlltsb9/mSEj16z q8Rc1Ts32/P8WWepWNqlu61nqDVr8+dZu320SbUVHHJhA1m8FmDo5DeWTwfO4lSH55MG kMC0OO+93ra36gx/x69aM2CB3X94/W33Y/adwlKwBG2QfEG3/WB32s/EGvlFx7B+95h6 1+sA== X-Gm-Message-State: AOJu0YxYyXYqdfo5KeADWAt72/wYsXHaUs9/GbP7/286fJS5EqJ0dBim Sa9MLYxtNiz5hYxsNFALdEJnhkF0Q5IEPLCfKW59eDx/yDhdSPB+8V2DN3qYHMobBPpX9jyEng5 79dFiEho= X-Gm-Gg: AZuq6aJJCOIwgUKjBI5WTStM5pXCd4GccR/zVZbpampBplSkrhcGoiXGeTPkG/pe654 cbq9/l4Fq3TComSbMg6q1APUD7QYP+DX7mFychs3a8GvXgWcPWWEKirvAT052fQhj4vLCaoIHM2 V3/t1ZcIekVKyfX8XbdeTg+KE0AnX7jklc2RKH6cdkGGPyBt0Tmb0irkwPI15T8Rw7WUph6/5Uw Zsu7jJUQP8Z1/u/Nx0rqwcFzg1I1sWR7Sf1RNaKhg/YKVv48d3fACG9f1F9PoThD0V9BxCiBBYf Wq3kwzF3Bu7RyuaaXDZhXib4gYaH1KB5tWr8wG8Qk6gVWMZ8ZEgzMpO6rmI07gMg29VVXXm4taf ImzC9U7T4y4li1B1ERzAw0HxhASiitqycDGy/ERNoylxWfJqRzvoU/Xq+uYWHbfSJ7p8t/lrLjN MqbvIx3oasJCzL9Q6sxXpGX5s60swTTLC1n6VNwNvexR91stO0vCA/AwIF4NxD X-Received: by 2002:a05:6000:40cf:b0:435:9538:939b with SMTP id ffacd0b85a97d-43617c3933emr1432912f8f.8.1770159677419; Tue, 03 Feb 2026 15:01:17 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Paolo Bonzini , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 3/5] target/sparc: Remove dubious swapping in LD_code() helper Date: Wed, 4 Feb 2026 00:00:52 +0100 Message-ID: <20260203230054.23667-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203230054.23667-1-philmd@linaro.org> References: <20260203230054.23667-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770159697256154100 Since the endianness is contained in %oi, cpu_ld*_code_mmu() has already honored it. Swapping again makes no sense. Remove the bswap() calls. Fixes: 2786a3f8d3a ("Use GET_ASI_CODE for ASI_KERNELTXT / ASI_USERTXT") Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/sparc/ldst_helper.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index e1178e53d51..10746b3c0f1 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -1166,21 +1166,12 @@ uint64_t helper_ld_code(CPUSPARCState *env, target_= ulong addr, uint32_t oi) break; case MO_16: ret =3D cpu_ldw_code_mmu(env, addr, oi, ra); - if ((mop & MO_BSWAP) !=3D MO_TE) { - ret =3D bswap16(ret); - } break; case MO_32: ret =3D cpu_ldl_code_mmu(env, addr, oi, ra); - if ((mop & MO_BSWAP) !=3D MO_TE) { - ret =3D bswap32(ret); - } break; case MO_64: ret =3D cpu_ldq_code_mmu(env, addr, oi, ra); - if ((mop & MO_BSWAP) !=3D MO_TE) { - ret =3D bswap64(ret); - } break; default: g_assert_not_reached(); --=20 2.52.0 From nobody Sat Feb 7 05:53:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770159697; cv=none; d=zohomail.com; s=zohoarc; b=mcQpNlLVAcIum17ZLUSWEKmWk8jzAFrg0A9aVq2bR+9fN9n3IBluEGAImgwPRnazxRiEzr6NKU/f9sxZVsqAbdqgOz4i8GvS7E6yT3tlZYw/IV/+dBUy2zaxsFAXDVr5kob5Ahd4Kfc/rpjYhYBJAAtFaUknYodVJVwlk4eCZm0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770159697; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pKaFN3q0wPWXS4ZXIhJmL9LeiOuDpU5p0P8W5pL1SLk=; b=goyXJD4L+I8zUiqoQjmmEr9NPfBHxvaS31tiDzluijm8guWtXj51Wp23VRElL2xP4eit2bi0TgBXNYwVSlRMYH/bp2lxMavXI6U6qBcoXg7Jz6FBrq0dClZvA45NGwlefycZaCXhjDURc+o3JuqlHzKa7bbjZa6ETccpi/On03I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770159697248992.1534172085608; Tue, 3 Feb 2026 15:01:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnPOo-0006DX-4x; Tue, 03 Feb 2026 18:01:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnPOj-0006B1-PP for qemu-devel@nongnu.org; Tue, 03 Feb 2026 18:01:29 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnPOg-0006Bn-Dd for qemu-devel@nongnu.org; Tue, 03 Feb 2026 18:01:28 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-482f454be5bso2467785e9.0 for ; Tue, 03 Feb 2026 15:01:26 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43617e38fbbsm2307042f8f.13.2026.02.03.15.01.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 15:01:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770159685; x=1770764485; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pKaFN3q0wPWXS4ZXIhJmL9LeiOuDpU5p0P8W5pL1SLk=; b=JNHmAMmsuFlxJbG6G6obsDD1Xi/JcwINor5oONqZDDe3X0/TAoKI5/pNy+aacpl+/o wpoY1duoBoWMwFUNxJmcrmmAFMGr7hazISfSIOXu56NQz4Jim9OD0UTnwNgZluEdksij 0dGEl0nUHtm5M3T9TjQEI7erwG0n5KaCK3JzfZIeHhp1Mcw8FR6bwZ0QClEZqmBc1Zdr 7sNg4i3hnQwJllX5xF455WDYe9JnpLIsydY1Eu4wMhz69uBHVdvMiwzIZV+ylUEexJkf booLO2FvqSknirU6q5Kp2ro5bMof8YJTRRrZwVkdNTS84Hiu4Y8NLGOtyBGEVs+mhrr/ oxZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770159685; x=1770764485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pKaFN3q0wPWXS4ZXIhJmL9LeiOuDpU5p0P8W5pL1SLk=; b=SfWEK88ldRmF2Uxjim8gvIbnJ/JYTW05sNFmpmKRNVZWG5mYm5gHCqShWJTE7K+hSQ 9VAR7OeDT+CHHlC5R6PPaia6CE6/cG4NvdShoS3BuR5JLvR/tZDR2I9rpGqpTU/KzFfi cN5orSeG0/F2aMxpDEbHsh+2JAgqKxyoy70muEPtMSMGlwaAND7M4afnhOsbBWVFS6ll bYH6l0iBiVM73OLGPNE419yg+bQOaYgFNKMtXjR+Qk57gtW6mQWNFa4m3lLk/e5zvusE El+UwQk2ePixCKF/dO02qmthKBza+NxazLc3aeEB1CwfBoEyb+88/bpy1GE5Y9a/rV0i E8cg== X-Gm-Message-State: AOJu0YzsGqd9XQqTzRh5uEi3HbX8wQqwx5v1vqtbahcMNxeFJu5HfzS+ UL3dI7Y5U8oOzhdfrqhzmOC9Bkt7NcfBzQGyNM65blYNX6GBlnZhQKnePwgFEQhNjFNTLmTisyK N/n9JQwg= X-Gm-Gg: AZuq6aKeThAUGXxra22vm963YT7B4eKRhh2IEYC9Ik8Ja6P+9H7QGlEyRoQ4MjHlBxo aBE/sHPFmOVQr1oIS7ovoqa+cwgx7OuSVli7Bk29VUd53ffvMNXZCfa4wdu7Nf4L6PfRTBOPAz5 jGRmVJTBHrc6aFUiPR0Ijm/Chpw+bXKIDgQyA0EW8/whIh6geGgKjgxjpDB+XCMn/cMl8MYzGPe b6N9cNby+E33Hlz/UkLBV/6ESBao9vFJgm45hMeViNpL7y3pgATuJK0F2YvZiJwioYGKj6pLWNe 7t1xHwQImq/ZAHxhSm1/HGTnBvWrEFpSppM0NTPaLU1VxGdA0pCyc3x4OUXJWiQ96RhEkpa/V8B F2mtSCuARblNchF1mfs9vksMogHxo1S41ziIrIa2hEDHZ2R1epHVM6FOIelC+PYKPJ93wZkTdyy dJoFcEc9qC59FBRHV6U4O5fV0XL3e66sSSpxCgWRPyf7JLwD2gaWRP7XfRWDc9 X-Received: by 2002:a05:600c:458c:b0:46e:59bd:f7e2 with SMTP id 5b1f17b1804b1-4830eb58934mr14967755e9.11.1770159684569; Tue, 03 Feb 2026 15:01:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Paolo Bonzini , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Manos Pitsidianakis Subject: [PATCH v4 4/5] target/sparc: Replace MO_TE -> MO_BE Date: Wed, 4 Feb 2026 00:00:53 +0100 Message-ID: <20260203230054.23667-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203230054.23667-1-philmd@linaro.org> References: <20260203230054.23667-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770159698958154101 We only build the SPARC targets using big endianness order, therefore the MO_TE definitions expand to the big endian one. Use the latter which is more explicit. Mechanical change running: $ sed -i -e s/MO_TE/MO_BE/ \ $(git grep -wl MO_TE target/sparc/) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- target/sparc/translate.c | 58 ++++++++++++++++++++-------------------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 1a7e5cc3d73..57b50ff8b9a 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -1764,7 +1764,7 @@ static DisasASI resolve_asi(DisasContext *dc, int asi= , MemOp memop) case ASI_FL16_SL: case ASI_FL16_P: case ASI_FL16_PL: - memop =3D MO_TEUW; + memop =3D MO_BEUW; type =3D GET_ASI_SHORT; break; } @@ -2215,7 +2215,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) * byte swapped. We perform one 128-bit LE load, so must swap * the order of the writebacks. */ - if ((mop & MO_BSWAP) =3D=3D MO_TE) { + if ((mop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i128_i64(lo, hi, t); } else { tcg_gen_extr_i128_i64(hi, lo, t); @@ -2235,7 +2235,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) /* Note that LE ldda acts as if each 32-bit register result is byte swapped. Having just performed one 64-bit bswap, we need now to swap the writebacks. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i64_tl(lo, hi, tmp); } else { tcg_gen_extr_i64_tl(hi, lo, tmp); @@ -2252,7 +2252,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) gen_helper_ld_code(tmp, tcg_env, addr, tcg_constant_i32(oi)); =20 /* See above. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i64_tl(lo, hi, tmp); } else { tcg_gen_extr_i64_tl(hi, lo, tmp); @@ -2277,7 +2277,7 @@ static void gen_ldda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) gen_helper_ld_asi(tmp, tcg_env, addr, r_asi, r_mop); =20 /* See above. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_extr_i64_tl(lo, hi, tmp); } else { tcg_gen_extr_i64_tl(hi, lo, tmp); @@ -2310,7 +2310,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) * byte swapped. We perform one 128-bit LE store, so must swap * the order of the construction. */ - if ((mop & MO_BSWAP) =3D=3D MO_TE) { + if ((mop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_concat_i64_i128(t, lo, hi); } else { tcg_gen_concat_i64_i128(t, hi, lo); @@ -2329,7 +2329,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) /* Note that LE stda acts as if each 32-bit register result is byte swapped. We will perform one 64-bit LE store, so now we must swap the order of the construction. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_concat_tl_i64(t64, lo, hi); } else { tcg_gen_concat_tl_i64(t64, hi, lo); @@ -2345,7 +2345,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) * See comments for GET_ASI_COPY above. */ { - MemOp mop =3D MO_TE | MO_128 | MO_ATOM_IFALIGN_PAIR; + MemOp mop =3D MO_BE | MO_128 | MO_ATOM_IFALIGN_PAIR; TCGv_i64 t8 =3D tcg_temp_new_i64(); TCGv_i128 t16 =3D tcg_temp_new_i128(); TCGv daddr =3D tcg_temp_new(); @@ -2368,7 +2368,7 @@ static void gen_stda_asi(DisasContext *dc, DisasASI *= da, TCGv addr, int rd) TCGv_i64 t64 =3D tcg_temp_new_i64(); =20 /* See above. */ - if ((da->memop & MO_BSWAP) =3D=3D MO_TE) { + if ((da->memop & MO_BSWAP) =3D=3D MO_BE) { tcg_gen_concat_tl_i64(t64, lo, hi); } else { tcg_gen_concat_tl_i64(t64, hi, lo); @@ -4428,13 +4428,13 @@ static bool do_ld_gpr(DisasContext *dc, arg_r_r_ri_= asi *a, MemOp mop) return advance_pc(dc); } =20 -TRANS(LDUW, ALL, do_ld_gpr, a, MO_TEUL) +TRANS(LDUW, ALL, do_ld_gpr, a, MO_BEUL) TRANS(LDUB, ALL, do_ld_gpr, a, MO_UB) -TRANS(LDUH, ALL, do_ld_gpr, a, MO_TEUW) +TRANS(LDUH, ALL, do_ld_gpr, a, MO_BEUW) TRANS(LDSB, ALL, do_ld_gpr, a, MO_SB) -TRANS(LDSH, ALL, do_ld_gpr, a, MO_TESW) -TRANS(LDSW, 64, do_ld_gpr, a, MO_TESL) -TRANS(LDX, 64, do_ld_gpr, a, MO_TEUQ) +TRANS(LDSH, ALL, do_ld_gpr, a, MO_BESW) +TRANS(LDSW, 64, do_ld_gpr, a, MO_BESL) +TRANS(LDX, 64, do_ld_gpr, a, MO_BEUQ) =20 static bool do_st_gpr(DisasContext *dc, arg_r_r_ri_asi *a, MemOp mop) { @@ -4451,10 +4451,10 @@ static bool do_st_gpr(DisasContext *dc, arg_r_r_ri_= asi *a, MemOp mop) return advance_pc(dc); } =20 -TRANS(STW, ALL, do_st_gpr, a, MO_TEUL) +TRANS(STW, ALL, do_st_gpr, a, MO_BEUL) TRANS(STB, ALL, do_st_gpr, a, MO_UB) -TRANS(STH, ALL, do_st_gpr, a, MO_TEUW) -TRANS(STX, 64, do_st_gpr, a, MO_TEUQ) +TRANS(STH, ALL, do_st_gpr, a, MO_BEUW) +TRANS(STX, 64, do_st_gpr, a, MO_BEUQ) =20 static bool trans_LDD(DisasContext *dc, arg_r_r_ri_asi *a) { @@ -4468,7 +4468,7 @@ static bool trans_LDD(DisasContext *dc, arg_r_r_ri_as= i *a) if (addr =3D=3D NULL) { return false; } - da =3D resolve_asi(dc, a->asi, MO_TEUQ); + da =3D resolve_asi(dc, a->asi, MO_BEUQ); gen_ldda_asi(dc, &da, addr, a->rd); return advance_pc(dc); } @@ -4485,7 +4485,7 @@ static bool trans_STD(DisasContext *dc, arg_r_r_ri_as= i *a) if (addr =3D=3D NULL) { return false; } - da =3D resolve_asi(dc, a->asi, MO_TEUQ); + da =3D resolve_asi(dc, a->asi, MO_BEUQ); gen_stda_asi(dc, &da, addr, a->rd); return advance_pc(dc); } @@ -4516,7 +4516,7 @@ static bool trans_SWAP(DisasContext *dc, arg_r_r_ri_a= si *a) if (addr =3D=3D NULL) { return false; } - da =3D resolve_asi(dc, a->asi, MO_TEUL); + da =3D resolve_asi(dc, a->asi, MO_BEUL); =20 dst =3D gen_dest_gpr(dc, a->rd); src =3D gen_load_gpr(dc, a->rd); @@ -4544,8 +4544,8 @@ static bool do_casa(DisasContext *dc, arg_r_r_ri_asi = *a, MemOp mop) return advance_pc(dc); } =20 -TRANS(CASA, CASA, do_casa, a, MO_TEUL) -TRANS(CASXA, 64, do_casa, a, MO_TEUQ) +TRANS(CASA, CASA, do_casa, a, MO_BEUL) +TRANS(CASXA, 64, do_casa, a, MO_BEUQ) =20 static bool do_ld_fpr(DisasContext *dc, arg_r_r_ri_asi *a, MemOp sz) { @@ -4561,7 +4561,7 @@ static bool do_ld_fpr(DisasContext *dc, arg_r_r_ri_as= i *a, MemOp sz) if (sz =3D=3D MO_128 && gen_trap_float128(dc)) { return true; } - da =3D resolve_asi(dc, a->asi, MO_TE | sz); + da =3D resolve_asi(dc, a->asi, MO_BE | sz); gen_ldf_asi(dc, &da, sz, addr, a->rd); gen_update_fprs_dirty(dc, a->rd); return advance_pc(dc); @@ -4590,7 +4590,7 @@ static bool do_st_fpr(DisasContext *dc, arg_r_r_ri_as= i *a, MemOp sz) if (sz =3D=3D MO_128 && gen_trap_float128(dc)) { return true; } - da =3D resolve_asi(dc, a->asi, MO_TE | sz); + da =3D resolve_asi(dc, a->asi, MO_BE | sz); gen_stf_asi(dc, &da, sz, addr, a->rd); return advance_pc(dc); } @@ -4629,7 +4629,7 @@ static bool trans_STDFQ(DisasContext *dc, arg_STDFQ *= a) /* Store the single element from the queue. */ TCGv_i64 fq =3D tcg_temp_new_i64(); tcg_gen_ld_i64(fq, tcg_env, offsetof(CPUSPARCState, fq.d)); - tcg_gen_qemu_st_i64(fq, addr, dc->mem_idx, MO_TEUQ | MO_ALIGN_4); + tcg_gen_qemu_st_i64(fq, addr, dc->mem_idx, MO_BEUQ | MO_ALIGN_4); =20 /* Mark the queue empty, transitioning to fp_execute state. */ tcg_gen_st_i32(tcg_constant_i32(0), tcg_env, @@ -4655,7 +4655,7 @@ static bool trans_LDFSR(DisasContext *dc, arg_r_r_ri = *a) } =20 tmp =3D tcg_temp_new_i32(); - tcg_gen_qemu_ld_i32(tmp, addr, dc->mem_idx, MO_TEUL | MO_ALIGN); + tcg_gen_qemu_ld_i32(tmp, addr, dc->mem_idx, MO_BEUL | MO_ALIGN); =20 tcg_gen_extract_i32(cpu_fcc[0], tmp, FSR_FCC0_SHIFT, 2); /* LDFSR does not change FCC[1-3]. */ @@ -4679,7 +4679,7 @@ static bool do_ldxfsr(DisasContext *dc, arg_r_r_ri *a= , bool entire) } =20 t64 =3D tcg_temp_new_i64(); - tcg_gen_qemu_ld_i64(t64, addr, dc->mem_idx, MO_TEUQ | MO_ALIGN); + tcg_gen_qemu_ld_i64(t64, addr, dc->mem_idx, MO_BEUQ | MO_ALIGN); =20 lo =3D tcg_temp_new_i32(); hi =3D cpu_fcc[3]; @@ -4722,8 +4722,8 @@ static bool do_stfsr(DisasContext *dc, arg_r_r_ri *a,= MemOp mop) return advance_pc(dc); } =20 -TRANS(STFSR, ALL, do_stfsr, a, MO_TEUL) -TRANS(STXFSR, 64, do_stfsr, a, MO_TEUQ) +TRANS(STFSR, ALL, do_stfsr, a, MO_BEUL) +TRANS(STXFSR, 64, do_stfsr, a, MO_BEUQ) =20 static bool do_fc(DisasContext *dc, int rd, int32_t c) { --=20 2.52.0 From nobody Sat Feb 7 05:53:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770159713; cv=none; d=zohomail.com; s=zohoarc; b=VQLxz2XSHl7THoJ/KsYdWX13uPq+nBnEK4H5SMImxZxA3V/Bf9Efwy6ZMvKNZloz+ZSMSZQBVc2Z9GYpbcA56T3KJEt9EKm6A/WrOuufJ0GpAA5JCqn1j6ggITgkA/NA94rNnHASg/WeCGb4IyRMsEMfKow7UyYtrF6Nl4NYKv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770159713; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5lVf2Ne20e/kD4Ls0zcv2d2Eydg6wNhvuHPWCgbwKjk=; b=mnL4rjouXOM/qU3ec5yTwoDh7vBs6xD4XYJVX8FlVJ//35Kl7H0jqfGF0sXJRKhBavMatYcki/DSu3Kb6rs6/iCZLjLlA/NetfCocET6m6yJ7Nrvdn0fJ1lQuYy6rXG0gVtg2445UISx8BAVSZ8eUjo1WGyEdIcVQRQ3pN2P/U8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770159713353659.5766359056802; Tue, 3 Feb 2026 15:01:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnPOw-0006QY-C8; Tue, 03 Feb 2026 18:01:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnPOt-0006Mt-Dp for qemu-devel@nongnu.org; Tue, 03 Feb 2026 18:01:39 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnPOq-0006CN-6H for qemu-devel@nongnu.org; Tue, 03 Feb 2026 18:01:37 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-47ee2715254so33879025e9.3 for ; Tue, 03 Feb 2026 15:01:35 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4831089f212sm1904875e9.15.2026.02.03.15.01.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 15:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770159694; x=1770764494; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5lVf2Ne20e/kD4Ls0zcv2d2Eydg6wNhvuHPWCgbwKjk=; b=ZNU9M+UzzJpE3i0YLSxeEveu1DTHK2WvcHrmyBFz1jsVaI9e4Ygdy1T/NN25Pq5O+v mWK+QZuaMKd29EcWHb9WdewbscJski4AXZ/TBL8XyZdpVZ5sgH5r+icwy+6Dt+yaiPxq 9jKpEtvvKwjlXOsbNCgF5FPSnIUyOgLFgQs75kaWcJ/aCccSOUSHvjWo7ha5P/2dl9Yy KeS0VPcxvtezj8z3qupNiBihB/w+j/4oilFGCvtBzwp8Hmty7tycGtu478MGBoJr+r6C ux/PNJB1V0ydPlU6Uz491ALsKqIt0xfhIh70EzhZxqSO7sUFA+Eq1kiUiuQvAisuTgWm NWTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770159694; x=1770764494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5lVf2Ne20e/kD4Ls0zcv2d2Eydg6wNhvuHPWCgbwKjk=; b=gOnkRhJ1+sv96udQKOWCcYUNHEQ9JzhjwlxRdsIjHnT8o5pyRMQt++1P9AjJYiid6X pgKQLAfVZdlPrtQYopUZ3HcH78SqgEOzK8Ox9KM0ryJUH7XZmhexo3gYvR0ZCkdArDu4 WhWcCYTTfCjmUjV3S1XfjCXx0Qhip/4rT8INI/PW0kYUTweIutziji4EJ+lwE7KDyCsb ADuayH4PDm3K9VBw/MPJHEBCAjWQgRQqDYE8ewW/s3hEvXfipUBepv3/6p2u9nwHRptQ 3+wEyRS6ZLXeB61iXIGbZpESy1RO5mxJpbyX+S3jM+N0mkuxQhiAV3uCkDvZI3XcmMU5 sacg== X-Gm-Message-State: AOJu0Yz2rUNph306ssfnq5dUFDCTAHtxxZzXt1pMHOI3bwHrYLjS/HSC +Q+nlUCSoPZT40Q5Sj4rlO5xysG0YldJGDVmU9EcUnjhdW36ngaeZnWdzLK0VPs701bJxZVRvyx lbCHvk6M= X-Gm-Gg: AZuq6aI8J+j3QCzUxfvjIzVJBuacJ0klDMjeNIW17ntioi/WDtMbsWAswKsRaIfgq1i Us0/7TKQxnocxIkW5KRsCjDODWMsMaJCZQIXm0E/72dS3z8nJH7mk76OGnWKnQ3A4/hvGzOMa2P NCUNOVGB9v6UhMh8zaRDCUQOhDlhAcDR+81zjWebrrAc0P10gTYD8lxtqPycUfSXoUclduy3Rqr gYiWSTXEEI+q7Qv6wWE+4MMOhBx38sSNFLXodQYEMcZHMNRkrx6pFYulBECaQvhJcODvi5f4S2k w5K1jWUZMzn6/wbf3miXUlOTlDam8J9qtwmi7gziN9RCEMzME5w/jDXdsqAZmsySIFeNsxLtIVU 9KqweRWId90DTE4genih9WVz8Ui2MBf4HvPdQ1E1Nkkfws8nsno5JtQptBvhKddJGdAh/BHnMqm LbtgzyzTO7ACXgUWASToURcDwPKzm3H+aKBZvzyHM312P5uc9nakiG8Ny8dPEy X-Received: by 2002:a05:600c:a011:b0:477:9eb8:97d2 with SMTP id 5b1f17b1804b1-4830e93ea9bmr15551755e9.8.1770159691462; Tue, 03 Feb 2026 15:01:31 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Mark Cave-Ayland , Pierrick Bouvier , Artyom Tarasenko , Paolo Bonzini , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Manos Pitsidianakis Subject: [PATCH v4 5/5] configs/targets: Forbid SPARC to use legacy native endianness APIs Date: Wed, 4 Feb 2026 00:00:54 +0100 Message-ID: <20260203230054.23667-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203230054.23667-1-philmd@linaro.org> References: <20260203230054.23667-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770159715154158500 All SPARC-related binaries are buildable without a single use of the legacy "native endian" API. Set the transitional TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API definition to forbid further uses of the legacy API. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Reviewed-by: Richard Henderson --- configs/targets/sparc-linux-user.mak | 1 + configs/targets/sparc-softmmu.mak | 1 + configs/targets/sparc32plus-linux-user.mak | 1 + configs/targets/sparc64-linux-user.mak | 1 + configs/targets/sparc64-softmmu.mak | 1 + 5 files changed, 5 insertions(+) diff --git a/configs/targets/sparc-linux-user.mak b/configs/targets/sparc-l= inux-user.mak index 4ff4b7287d2..d3f0716ca2d 100644 --- a/configs/targets/sparc-linux-user.mak +++ b/configs/targets/sparc-linux-user.mak @@ -3,3 +3,4 @@ TARGET_SYSTBL_ABI=3Dcommon,32 TARGET_SYSTBL=3Dsyscall.tbl TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc-softmmu.mak b/configs/targets/sparc-soft= mmu.mak index 57801faf1fc..272fd46f6db 100644 --- a/configs/targets/sparc-softmmu.mak +++ b/configs/targets/sparc-softmmu.mak @@ -1,3 +1,4 @@ TARGET_ARCH=3Dsparc TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D32 +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc32plus-linux-user.mak b/configs/targets/s= parc32plus-linux-user.mak index 7a16934fd17..3e6c72e793e 100644 --- a/configs/targets/sparc32plus-linux-user.mak +++ b/configs/targets/sparc32plus-linux-user.mak @@ -6,3 +6,4 @@ TARGET_SYSTBL_ABI=3Dcommon,32 TARGET_SYSTBL=3Dsyscall.tbl TARGET_BIG_ENDIAN=3Dy TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc64-linux-user.mak b/configs/targets/sparc= 64-linux-user.mak index 7c2ecb7be06..3bbd8495210 100644 --- a/configs/targets/sparc64-linux-user.mak +++ b/configs/targets/sparc64-linux-user.mak @@ -6,3 +6,4 @@ TARGET_SYSTBL=3Dsyscall.tbl TARGET_BIG_ENDIAN=3Dy TARGET_XML_FILES=3Dgdb-xml/sparc64-core.xml TARGET_LONG_BITS=3D64 +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy diff --git a/configs/targets/sparc64-softmmu.mak b/configs/targets/sparc64-= softmmu.mak index 8ee6d057682..8a0290c2093 100644 --- a/configs/targets/sparc64-softmmu.mak +++ b/configs/targets/sparc64-softmmu.mak @@ -4,3 +4,4 @@ TARGET_BIG_ENDIAN=3Dy TARGET_XML_FILES=3Dgdb-xml/sparc64-core.xml TARGET_LONG_BITS=3D64 TARGET_NOT_USING_LEGACY_LDST_PHYS_API=3Dy +TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=3Dy --=20 2.52.0