From nobody Sat Feb 7 07:11:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1770150986; cv=none; d=zohomail.com; s=zohoarc; b=k6ys9Nso512G+KVVoeoNTH8aDMJsfHfGanA11MBZg7CxR4H25lQw2KlVOgjJ/ibc6ZtpoWtZrSqlASmYlN0QPUrdPLIKWsSNedPyxPnA9gc1x0sq7hA64ku8LcjF0qar0MQIkODwi9YET9gSoL4YxcUDPytF9tDvEPKvgGNQeFQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770150986; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SaEfClcDmb4nFGfC08rt5310gxP6p4JFNvWZoOFsCJo=; b=cFwhiFDBrSB/oFxu6BUWhlQNNM/zgpVkSsnSAT7kWv0riW89zjVkyt/gGWr7pKxJyr5l6bLPN/TH6yKFBsdnL45dm9c9w50hd++nUOSqWXRqTlguCBNZKL8ykQxZCB8ebzht2dwjmu5P2FmXu++RQ0CqMlE8AsNGXMOoLvjo2XU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770150986042820.6011280210628; Tue, 3 Feb 2026 12:36:26 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnN89-0003n7-50; Tue, 03 Feb 2026 15:36:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnN87-0003mJ-KF for qemu-devel@nongnu.org; Tue, 03 Feb 2026 15:36:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnN86-0000xA-4x for qemu-devel@nongnu.org; Tue, 03 Feb 2026 15:36:11 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-dGajYpgsNwyUzkBXQ39Ddg-1; Tue, 03 Feb 2026 15:36:05 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CA4AF18005AD; Tue, 3 Feb 2026 20:36:03 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.88.43]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B6D62180009E; Tue, 3 Feb 2026 20:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770150969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SaEfClcDmb4nFGfC08rt5310gxP6p4JFNvWZoOFsCJo=; b=jNu7LczqOWhh8lY90aFN6itdIchJvzCOl9slMbUNalWCkZ5CDUKn+0eELvPO5voefG7ul2 +2Jg4yYlWIZewUj5XcuSonu84ipOy+M1RCrozvtCL9QbO2srYPNpSr2fshm82tv4W/0TZe jYoPWbM8pV2QYg9lA28a7EZkWUXflMA= X-MC-Unique: dGajYpgsNwyUzkBXQ39Ddg-1 X-Mimecast-MFC-AGG-ID: dGajYpgsNwyUzkBXQ39Ddg_1770150963 From: John Snow To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Thomas Huth , Maksim Davydov , Markus Armbruster , Peter Xu , Ed Maste , Li-Wen Hsu , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Hanna Reitz , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , John Snow , Vladimir Sementsov-Ogievskiy , Paolo Bonzini , Michael Roth , Yonggang Luo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mauro Carvalho Chehab , Kevin Wolf , Cleber Rosa , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Fabiano Rosas Subject: [PATCH v5 12/16] configure: unconditionally install "tooling" group Date: Tue, 3 Feb 2026 15:35:07 -0500 Message-ID: <20260203203512.672552-13-jsnow@redhat.com> In-Reply-To: <20260203203512.672552-1-jsnow@redhat.com> References: <20260203203512.672552-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1770150987676158500 Alongside meson, always ensure our in-tree tooling group and its out-of-tree dependency, qemu.qmp, is always installed. As a result, several "check-venv" invocations can be removed from various testing scripts. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrang=C3=A9 --- configure | 2 +- .gitlab-ci.d/buildtest.yml | 2 -- scripts/device-crash-test | 3 +-- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 4b61fd3bbf8..c4837eba2b1 100755 --- a/configure +++ b/configure @@ -966,7 +966,7 @@ mkvenv=3D"$python ${source_path}/python/scripts/mkvenv.= py" # Finish preparing the virtual environment using vendored .whl files =20 $mkvenv ensuregroup --dir "${source_path}/python/wheels" \ - ${source_path}/pythondeps.toml meson || exit 1 + ${source_path}/pythondeps.toml meson tooling || exit 1 =20 # At this point, we expect Meson to be installed and available. # We expect mkvenv or pip to have created pyvenv/bin/meson for us. diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index b2db70ff904..1b656b9eb08 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -101,7 +101,6 @@ crash-test-debian: IMAGE: debian script: - cd build - - make NINJA=3D":" check-venv - ./run scripts/device-crash-test -q --tcg-only ./qemu-system-i386 =20 build-system-fedora: @@ -158,7 +157,6 @@ crash-test-fedora: IMAGE: fedora script: - cd build - - make NINJA=3D":" check-venv - ./run scripts/device-crash-test -q ./qemu-system-ppc - ./run scripts/device-crash-test -q ./qemu-system-riscv32 =20 diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 8a91dcaee31..fc86babdf43 100755 --- a/scripts/device-crash-test +++ b/scripts/device-crash-test @@ -40,8 +40,7 @@ try: except ModuleNotFoundError as exc: path =3D Path(__file__).resolve() print(f"Module '{exc.name}' not found.") - print(" Try 'make check-venv' from your build directory,") - print(" and then one way to run this script is like so:") + print(" Try running this script like so:") print(f' > $builddir/run "{path}"') sys.exit(1) =20 --=20 2.52.0