From nobody Tue Feb 10 06:07:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1770134364; cv=none; d=zohomail.com; s=zohoarc; b=jhi3V00gzMq0Np+gTOktd9xd7+n794/CF0b9HI7H4mhsEzbyKOG6O49ii8/2xLmuaSw04YH2S2RSIsHZbzXYZnY/nwSbg44yPjZ9CWtOGiBEECw095IH9nWl6v1sOej4BnxAOmqo/355kvHQiDEUIR81Z5EAUyUcKQWisaaBG9U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770134364; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/UJ8m9Ew0D6MLbppD6QdkaILWxRhFrRTDH9wNktnxac=; b=WGwS4QxRuhPKByzHaTgHYaJb3YtoLh/+XmKS74Q9xK9m5Wn6Wa7c3hlsJk/EWw4CRguIdKWaR67a1B9ch6LcqQJbtSao/EBIGqqXjXwp4L6EC5clSl/rZs68iJDIOAkOPvE/R5Bq3LyIsY8K6V5sF9ARZpcy9ceOllqchHM1CNM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770134364540380.3336009997555; Tue, 3 Feb 2026 07:59:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnInl-0003LH-Ng; Tue, 03 Feb 2026 10:58:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnInk-0003K4-0X for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:58:52 -0500 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnInh-0006s8-FB for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:58:51 -0500 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c24:fa2:0:640:41ee:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 1981480830; Tue, 03 Feb 2026 18:58:47 +0300 (MSK) Received: from vsementsov-lin (unknown [2a02:6bf:8080:52d::1:1f]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id iwqMTU0A5Cg0-mHl8tzMm; Tue, 03 Feb 2026 18:58:46 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1770134326; bh=/UJ8m9Ew0D6MLbppD6QdkaILWxRhFrRTDH9wNktnxac=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=qTrlEwGgOYUOttjUKmP4XwM7QQ8VUm7i8LpWa213FX1E4MhTDaSDGG1Zdk22dd+Mv UHKC9Vb58Xvpm89gslqzv+iUE/M8XHhbG/b3oHqI09Sn39hzQJvOLJVJlU/EPgVzYn e8XcG6YaqU82LWYTKGgpym8Mpg7vC6klbORYAbOc= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: stefanb@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, armbru@redhat.com, peterx@redhat.com, vsementsov@yandex-team.ru, Stefan Berger Subject: [PATCH v3 1/3] tpm_emulator: print error on error-ignore path Date: Tue, 3 Feb 2026 18:58:41 +0300 Message-ID: <20260203155843.79043-2-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203155843.79043-1-vsementsov@yandex-team.ru> References: <20260203155843.79043-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1770134366721154100 Content-Type: text/plain; charset="utf-8" Commit 3469a56fa3dc985 introduced errp passthrough for many errors in the file. But in this specific case in tpm_emulator_get_buffer_size(), it simply used errp=3DNULL, so we lose printed error. Let's bring it back Note also, that 3469a56fa3dc985 was fixing another commit, 42e556fa3f7a "backends/tpm: Propagate vTPM error on migration failure" and didn't mention it. Fixes: 3469a56fa3dc985 "tmp_emulator: improve and fix use of errp" Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Berger Reviewed-by: Markus Armbruster --- backends/tpm/tpm_emulator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c index f52cb4d435..6d8529da3b 100644 --- a/backends/tpm/tpm_emulator.c +++ b/backends/tpm/tpm_emulator.c @@ -557,8 +557,10 @@ static TPMVersion tpm_emulator_get_tpm_version(TPMBack= end *tb) static size_t tpm_emulator_get_buffer_size(TPMBackend *tb) { size_t actual_size; + Error *local_err =3D NULL; =20 - if (tpm_emulator_set_buffer_size(tb, 0, &actual_size, NULL) < 0) { + if (tpm_emulator_set_buffer_size(tb, 0, &actual_size, &local_err) < 0)= { + error_report_err(local_err); return 4096; } =20 --=20 2.52.0