From nobody Sat Feb 7 05:56:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1770134364; cv=none; d=zohomail.com; s=zohoarc; b=jhi3V00gzMq0Np+gTOktd9xd7+n794/CF0b9HI7H4mhsEzbyKOG6O49ii8/2xLmuaSw04YH2S2RSIsHZbzXYZnY/nwSbg44yPjZ9CWtOGiBEECw095IH9nWl6v1sOej4BnxAOmqo/355kvHQiDEUIR81Z5EAUyUcKQWisaaBG9U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770134364; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/UJ8m9Ew0D6MLbppD6QdkaILWxRhFrRTDH9wNktnxac=; b=WGwS4QxRuhPKByzHaTgHYaJb3YtoLh/+XmKS74Q9xK9m5Wn6Wa7c3hlsJk/EWw4CRguIdKWaR67a1B9ch6LcqQJbtSao/EBIGqqXjXwp4L6EC5clSl/rZs68iJDIOAkOPvE/R5Bq3LyIsY8K6V5sF9ARZpcy9ceOllqchHM1CNM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770134364540380.3336009997555; Tue, 3 Feb 2026 07:59:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnInl-0003LH-Ng; Tue, 03 Feb 2026 10:58:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnInk-0003K4-0X for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:58:52 -0500 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnInh-0006s8-FB for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:58:51 -0500 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c24:fa2:0:640:41ee:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 1981480830; Tue, 03 Feb 2026 18:58:47 +0300 (MSK) Received: from vsementsov-lin (unknown [2a02:6bf:8080:52d::1:1f]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id iwqMTU0A5Cg0-mHl8tzMm; Tue, 03 Feb 2026 18:58:46 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1770134326; bh=/UJ8m9Ew0D6MLbppD6QdkaILWxRhFrRTDH9wNktnxac=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=qTrlEwGgOYUOttjUKmP4XwM7QQ8VUm7i8LpWa213FX1E4MhTDaSDGG1Zdk22dd+Mv UHKC9Vb58Xvpm89gslqzv+iUE/M8XHhbG/b3oHqI09Sn39hzQJvOLJVJlU/EPgVzYn e8XcG6YaqU82LWYTKGgpym8Mpg7vC6klbORYAbOc= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: stefanb@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, armbru@redhat.com, peterx@redhat.com, vsementsov@yandex-team.ru, Stefan Berger Subject: [PATCH v3 1/3] tpm_emulator: print error on error-ignore path Date: Tue, 3 Feb 2026 18:58:41 +0300 Message-ID: <20260203155843.79043-2-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203155843.79043-1-vsementsov@yandex-team.ru> References: <20260203155843.79043-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1770134366721154100 Content-Type: text/plain; charset="utf-8" Commit 3469a56fa3dc985 introduced errp passthrough for many errors in the file. But in this specific case in tpm_emulator_get_buffer_size(), it simply used errp=3DNULL, so we lose printed error. Let's bring it back Note also, that 3469a56fa3dc985 was fixing another commit, 42e556fa3f7a "backends/tpm: Propagate vTPM error on migration failure" and didn't mention it. Fixes: 3469a56fa3dc985 "tmp_emulator: improve and fix use of errp" Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Berger Reviewed-by: Markus Armbruster --- backends/tpm/tpm_emulator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c index f52cb4d435..6d8529da3b 100644 --- a/backends/tpm/tpm_emulator.c +++ b/backends/tpm/tpm_emulator.c @@ -557,8 +557,10 @@ static TPMVersion tpm_emulator_get_tpm_version(TPMBack= end *tb) static size_t tpm_emulator_get_buffer_size(TPMBackend *tb) { size_t actual_size; + Error *local_err =3D NULL; =20 - if (tpm_emulator_set_buffer_size(tb, 0, &actual_size, NULL) < 0) { + if (tpm_emulator_set_buffer_size(tb, 0, &actual_size, &local_err) < 0)= { + error_report_err(local_err); return 4096; } =20 --=20 2.52.0 From nobody Sat Feb 7 05:56:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1770134369; cv=none; d=zohomail.com; s=zohoarc; b=axDGYuwbxXBRLhTliq4C7p5yq/TfgyDUhIx0+RGomKjbJHaCXxYyQeM/G3okMLARtJrH6kV6TD54t85y0e60rXDjW+gFkOXB05stwsioKEo/z4DeU0MQJx5DCJJrPxltvJGhdyRYBuScKRxyX5aqpjMu/w6tOlFwDQufX8DkSWU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770134369; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rn2PK65cx04StmgHrZuRL9Mr6t+S0RBWXgmNjhxDO4s=; b=JG0RWNhd0jObZwzEDxd4tMmJLYuIEwrVE4bGPMzA7+zcy4f+BCeWEZhysZsBVqPvu1cx4tXWkk5ebSVSGUfwgl0EFdcOpuQRa7Jb5Komf3i2cJu4h9C/uI0NMnZ8YAeRuUS9mO++b5QDMhCZKT1cFfrZGR+SCBNAzISwgJ4em80= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770134368270996.0183486869347; Tue, 3 Feb 2026 07:59:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnInk-0003KK-9w; Tue, 03 Feb 2026 10:58:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnInj-0003Jk-6d for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:58:51 -0500 Received: from forwardcorp1b.mail.yandex.net ([178.154.239.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnInh-0006sT-9H for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:58:50 -0500 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c24:fa2:0:640:41ee:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id F2F9E8084A; Tue, 03 Feb 2026 18:58:47 +0300 (MSK) Received: from vsementsov-lin (unknown [2a02:6bf:8080:52d::1:1f]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id iwqMTU0A5Cg0-I7gtx00y; Tue, 03 Feb 2026 18:58:47 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1770134327; bh=rn2PK65cx04StmgHrZuRL9Mr6t+S0RBWXgmNjhxDO4s=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=RNzwzKk7wTnupL4oUoGpIf2tcDUJNiyKEkJkQiu7CgmKIDVkaPtXYj9M3+BNWg6YC WN4zVsssxH7Y1pkwg4AJz3o6cD4QuR0KiuUr7EwNw2x2dqnSPBX8p1fhrDc88mtlQN RRBhvPpeW194+ZTZIoR7LK8J3kH53aMwkUK7jwE8= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: stefanb@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, armbru@redhat.com, peterx@redhat.com, vsementsov@yandex-team.ru, Stefan Berger Subject: [PATCH v3 2/3] tpm_emulator: drop direct use of errno variable Date: Tue, 3 Feb 2026 18:58:42 +0300 Message-ID: <20260203155843.79043-3-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203155843.79043-1-vsementsov@yandex-team.ru> References: <20260203155843.79043-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.136; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1770134371796158500 Content-Type: text/plain; charset="utf-8" The code tends to include errno into error messages after tpm_util_test_tpmdev() and tpm_emulator_ctrlcmd() calls. Both has error paths, where errno is not set, examples: tpm_emulator_ctrlcmd() qemu_chr_fe_write_all() qemu_chr_write() replay_char_write_event_load() ... *res =3D replay_get_dword(); ... tpm_util_test_tpmdev() tpm_util_test() tpm_util_request() ... if (n !=3D requestlen) { return -EFAULT; } ... Both doesn't document that they set errno. Let's drop these explicit usage of errno. If we need this information, it should be added to errp deeper in the stack. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Berger Reviewed-by: Markus Armbruster --- backends/tpm/tpm_emulator.c | 41 +++++++++++++++---------------------- 1 file changed, 16 insertions(+), 25 deletions(-) diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c index 6d8529da3b..dc84380b13 100644 --- a/backends/tpm/tpm_emulator.c +++ b/backends/tpm/tpm_emulator.c @@ -225,7 +225,7 @@ static int tpm_emulator_set_locality(TPMEmulator *tpm_e= mu, uint8_t locty_number, if (tpm_emulator_ctrlcmd(tpm_emu, CMD_SET_LOCALITY, &loc, sizeof(loc), sizeof(loc.u.resp.tpm_result), sizeof(loc)) < 0) { - error_setg_errno(errp, errno, "tpm-emulator: could not set localit= y"); + error_setg(errp, "tpm-emulator: could not set locality"); return -1; } =20 @@ -263,7 +263,7 @@ static int tpm_emulator_probe_caps(TPMEmulator *tpm_emu) if (tpm_emulator_ctrlcmd(tpm_emu, CMD_GET_CAPABILITY, &cap_n, 0, sizeof(cap_n.u.resp.tpm_result), sizeof(cap_n)) < 0) { - error_report("tpm-emulator: probing failed : %s", strerror(errno)); + error_report("tpm-emulator: probing failed"); return -1; } =20 @@ -314,7 +314,7 @@ static int tpm_emulator_stop_tpm(TPMBackend *tb, Error = **errp) =20 if (tpm_emulator_ctrlcmd(tpm_emu, CMD_STOP, &res, 0, sizeof(ptm_res), sizeof(res)) < 0) { - error_setg_errno(errp, errno, "tpm-emulator: Could not stop TPM"); + error_setg(errp, "tpm-emulator: Could not stop TPM"); return -1; } =20 @@ -342,8 +342,7 @@ static int tpm_emulator_lock_storage(TPMEmulator *tpm_e= mu) if (tpm_emulator_ctrlcmd(tpm_emu, CMD_LOCK_STORAGE, &pls, sizeof(pls.u= .req), sizeof(pls.u.resp.tpm_result), sizeof(pls.u.resp)) < 0) { - error_report("tpm-emulator: Could not lock storage within 3 second= s: " - "%s", strerror(errno)); + error_report("tpm-emulator: Could not lock storage within 3 second= s"); return -1; } =20 @@ -375,8 +374,7 @@ static int tpm_emulator_set_buffer_size(TPMBackend *tb, if (tpm_emulator_ctrlcmd(tpm_emu, CMD_SET_BUFFERSIZE, &psbs, sizeof(psbs.u.req), sizeof(psbs.u.resp.tpm_re= sult), sizeof(psbs.u.resp)) < 0) { - error_setg_errno(errp, errno, - "tpm-emulator: Could not set buffer size"); + error_setg(errp, "tpm-emulator: Could not set buffer size"); return -1; } =20 @@ -424,7 +422,7 @@ static int tpm_emulator_startup_tpm_resume(TPMBackend *= tb, size_t buffersize, if (tpm_emulator_ctrlcmd(tpm_emu, CMD_INIT, &init, sizeof(init), sizeof(init.u.resp.tpm_result), sizeof(init)) < 0) { - error_setg_errno(errp, errno, "tpm-emulator: could not send INIT"); + error_setg(errp, "tpm-emulator: could not send INIT"); goto err_exit; } =20 @@ -479,8 +477,7 @@ static bool tpm_emulator_get_tpm_established_flag(TPMBa= ckend *tb) if (tpm_emulator_ctrlcmd(tpm_emu, CMD_GET_TPMESTABLISHED, &est, 0, sizeof(est) /* always returns resp.bit */, sizeof(est)) < 0) { - error_report("tpm-emulator: Could not get the TPM established flag= : %s", - strerror(errno)); + error_report("tpm-emulator: Could not get the TPM established flag= "); return false; } trace_tpm_emulator_get_tpm_established_flag(est.u.resp.bit); @@ -508,8 +505,7 @@ static int tpm_emulator_reset_tpm_established_flag(TPMB= ackend *tb, &reset_est, sizeof(reset_est), sizeof(reset_est.u.resp.tpm_result), sizeof(reset_est)) < 0) { - error_report("tpm-emulator: Could not reset the establishment bit:= %s", - strerror(errno)); + error_report("tpm-emulator: Could not reset the establishment bit"= ); return -1; } =20 @@ -539,8 +535,7 @@ static void tpm_emulator_cancel_cmd(TPMBackend *tb) /* FIXME: make the function non-blocking, or it may block a VCPU */ if (tpm_emulator_ctrlcmd(tpm_emu, CMD_CANCEL_TPM_CMD, &res, 0, sizeof(ptm_res), sizeof(res)) < 0) { - error_report("tpm-emulator: Could not cancel command: %s", - strerror(errno)); + error_report("tpm-emulator: Could not cancel command"); } else if (res !=3D 0) { error_report("tpm-emulator: Failed to cancel TPM: 0x%x", be32_to_cpu(res)); @@ -601,8 +596,7 @@ static int tpm_emulator_prepare_data_fd(TPMEmulator *tp= m_emu) =20 if (tpm_emulator_ctrlcmd(tpm_emu, CMD_SET_DATAFD, &res, 0, sizeof(ptm_res), sizeof(res)) < 0 || res !=3D= 0) { - error_report("tpm-emulator: Failed to send CMD_SET_DATAFD: %s", - strerror(errno)); + error_report("tpm-emulator: Failed to send CMD_SET_DATAFD"); goto err_exit; } =20 @@ -659,8 +653,8 @@ static int tpm_emulator_handle_device_opts(TPMEmulator = *tpm_emu, QemuOpts *opts) */ if (tpm_util_test_tpmdev(QIO_CHANNEL_SOCKET(tpm_emu->data_ioc)->fd, &tpm_emu->tpm_version)) { - error_report("'%s' is not emulating TPM device. Error: %s", - tpm_emu->options->chardev, strerror(errno)); + error_report("'%s' is not emulating TPM device.", + tpm_emu->options->chardev); goto err; } =20 @@ -750,8 +744,7 @@ static int tpm_emulator_get_state_blob(TPMEmulator *tpm= _emu, /* always returns up to resp.data */ offsetof(ptm_getstate, u.resp.data), offsetof(ptm_getstate, u.resp.data)) < 0) { - error_report("tpm-emulator: could not get state blob type %d : %s", - type, strerror(errno)); + error_report("tpm-emulator: could not get state blob type %d", typ= e); return -1; } =20 @@ -853,9 +846,8 @@ static int tpm_emulator_set_state_blob(TPMEmulator *tpm= _emu, /* write the header only */ if (tpm_emulator_ctrlcmd(tpm_emu, CMD_SET_STATEBLOB, &pss, offsetof(ptm_setstate, u.req.data), 0, 0) < 0= ) { - error_setg_errno(errp, errno, - "tpm-emulator: could not set state blob type %d", - type); + error_setg(errp, "tpm-emulator: could not set state blob type %d", + type); return -1; } =20 @@ -1037,8 +1029,7 @@ static void tpm_emulator_shutdown(TPMEmulator *tpm_em= u) =20 if (tpm_emulator_ctrlcmd(tpm_emu, CMD_SHUTDOWN, &res, 0, sizeof(ptm_res), sizeof(res)) < 0) { - error_report("tpm-emulator: Could not cleanly shutdown the TPM: %s= ", - strerror(errno)); + error_report("tpm-emulator: Could not cleanly shutdown the TPM"); } else if (res !=3D 0) { error_report("tpm-emulator: TPM result for shutdown: 0x%x %s", be32_to_cpu(res), tpm_emulator_strerror(be32_to_cpu(r= es))); --=20 2.52.0 From nobody Sat Feb 7 05:56:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1770134377; cv=none; d=zohomail.com; s=zohoarc; b=LD8YZA7cQKU2uZzR8o8ZGZjcz6jfPUI2pGhBONRR3ko18pLRgjGlK8XVseZKUdxzah6px8nzzHjYItTgLMBoIXPxClugF7/EF3TFwXaK5Ud4RsqZ8rb+57kvyeafVt7q4CpOREO2km+qU3PN1ysGQz77WsoeIDtGoEWfjBJ8T2w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770134377; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oyscKXue77dlYjFZ7MkRvv10904lg+vrKE/CFtiyvHY=; b=myLs94Wil9LcedznjUHFrBuM6FXajBYuRPsD8E+c+cmN4JDkRypC5oUcM1Nu6JBTAzKzkEh2oOWp5xqeA0RZQQBPcyAsRvvd2n9G2fZx6iqmXueNkUT8FnK9aYqyEu9qYBZVvBG+imzIjttxxkEdNah7Cn7yXjJAgQjrcLqYS4Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770134376916331.0544919525646; Tue, 3 Feb 2026 07:59:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnInl-0003LL-SE; Tue, 03 Feb 2026 10:58:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnInk-0003K9-59 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:58:52 -0500 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnIni-0006sa-7d for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:58:51 -0500 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c24:fa2:0:640:41ee:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id C87D580854; Tue, 03 Feb 2026 18:58:48 +0300 (MSK) Received: from vsementsov-lin (unknown [2a02:6bf:8080:52d::1:1f]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id iwqMTU0A5Cg0-U1dV6X8W; Tue, 03 Feb 2026 18:58:48 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1770134328; bh=oyscKXue77dlYjFZ7MkRvv10904lg+vrKE/CFtiyvHY=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=o3Mzyx+H+GSLeM9RdaLCTk2zEbH92nVzN6YmANqCHkXBlp/+sBIrpsjiht+JG/dxB X076ELTGPTBCO1MZ2NgjGbRpYTaCYTiFazrN4y3JRDzua31qp8NyYd2YX6A9i7GOD5 LyZAh6WfnRpalwXia3fM2oOY9uf8b85N2qx80QOI= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: stefanb@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, armbru@redhat.com, peterx@redhat.com, vsementsov@yandex-team.ru, Stefan Berger Subject: [PATCH v3 3/3] tpm_emulator: tpm_emulator_set_state_blobs(): move to boolean return Date: Tue, 3 Feb 2026 18:58:43 +0300 Message-ID: <20260203155843.79043-4-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203155843.79043-1-vsementsov@yandex-team.ru> References: <20260203155843.79043-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1770134381038158500 Content-Type: text/plain; charset="utf-8" The returned error is only used to check for success, so no reason to use specific errno values. Also, this is the only function with -errno contract in the file, so converting it simplifies the whole file from three types of contract (0/-1, 0/-errno, true/false) to only two (0/-1, true/false). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Berger Reviewed-by: Markus Armbruster --- backends/tpm/tpm_emulator.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c index dc84380b13..75c33d290e 100644 --- a/backends/tpm/tpm_emulator.c +++ b/backends/tpm/tpm_emulator.c @@ -885,10 +885,8 @@ static int tpm_emulator_set_state_blob(TPMEmulator *tp= m_emu, =20 /* * Set all the TPM state blobs. - * - * Returns a negative errno code in case of error. */ -static int tpm_emulator_set_state_blobs(TPMBackend *tb, Error **errp) +static bool tpm_emulator_set_state_blobs(TPMBackend *tb, Error **errp) { TPMEmulator *tpm_emu =3D TPM_EMULATOR(tb); TPMBlobBuffers *state_blobs =3D &tpm_emu->state_blobs; @@ -897,7 +895,7 @@ static int tpm_emulator_set_state_blobs(TPMBackend *tb,= Error **errp) =20 if (tpm_emulator_stop_tpm(tb, errp) < 0) { trace_tpm_emulator_set_state_blobs_error("Could not stop TPM"); - return -EIO; + return false; } =20 if (tpm_emulator_set_state_blob(tpm_emu, PTM_BLOB_TYPE_PERMANENT, @@ -909,12 +907,12 @@ static int tpm_emulator_set_state_blobs(TPMBackend *t= b, Error **errp) tpm_emulator_set_state_blob(tpm_emu, PTM_BLOB_TYPE_SAVESTATE, &state_blobs->savestate, state_blobs->savestate_flags, errp) < = 0) { - return -EIO; + return false; } =20 trace_tpm_emulator_set_state_blobs_done(); =20 - return 0; + return true; } =20 static int tpm_emulator_pre_save(void *opaque) @@ -957,10 +955,8 @@ static void tpm_emulator_vm_state_change(void *opaque,= bool running, static bool tpm_emulator_post_load(void *opaque, int version_id, Error **e= rrp) { TPMBackend *tb =3D opaque; - int ret; =20 - ret =3D tpm_emulator_set_state_blobs(tb, errp); - if (ret < 0) { + if (!tpm_emulator_set_state_blobs(tb, errp)) { return false; } =20 --=20 2.52.0