From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131113; cv=none; d=zohomail.com; s=zohoarc; b=ibHduEV0g1GtsIlK0xsRL5fCrXwMSEHLW5ebhaQBEeDZUYiGSS74pKSvcfkb5gqQ58PVXBPsw44qtWFP5HQsqttYggUphhK2Fig286/WVZWhskm7kQq7Jei/haayE1AZpJMkva0JzOm+zkwbXSHhf3Naaw+rfQL9e/vyvlm9MNk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131113; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=tuRjC9GWhykhArGXENtPPp74AE8CygRAtcP+2Ych30U=; b=jZ1tuaYqSUTiAv3dgE70PDBYiDQT+ywKc22UwEFEvz8QKcr0v9IhNS/we5M/ERPJKGG2wuFzs0gE/E/HMAxPlqkMbYOf/xevRC+cX9bgCujGhIiISysIag/AfMWAjOQ7f2ENdCiF8F4aZijbdsPJWlbi58xMF1y5ww3fMHDZrzY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131113033301.80497753023394; Tue, 3 Feb 2026 07:05:13 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHxR-0000OP-Tc; Tue, 03 Feb 2026 10:04:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHxQ-0000Nq-DR for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:04:48 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHxO-0001Lg-TO for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:04:48 -0500 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-43590777e22so3592428f8f.3 for ; Tue, 03 Feb 2026 07:04:46 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edfe7sm51537171f8f.14.2026.02.03.07.04.43 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:04:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131085; x=1770735885; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=tuRjC9GWhykhArGXENtPPp74AE8CygRAtcP+2Ych30U=; b=HwF6LNekjO/PddeXSIO5gMern5VCQ7e2iETSoos5NPuHHpit9sVeNfxcIej10qOEbV abwnerD11nnc4umsmLs5eAUGJeiPaJy6New13Tvh56wBsrKzQr6/PRe6g6IZ95q9IJ6c 4I8O3isusPYJybrRDIZTTnnzekEsOriUi2wS9GCVSpWjfZM+p85L4d1YrVprbNWposKD UqyMLt+bZ5gmDH+wqGIniIVNUcx1ivwiVylog/tery+FCPDHfdVFbdi1Us3Cpt8Wcia0 g5Da7CE/Kk7Dgf6Rsd2Xaa2wfoZYjf4dWzOp5ussn687eS4PuyxCq+oh8YOkTS2WKACs Xx1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131085; x=1770735885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tuRjC9GWhykhArGXENtPPp74AE8CygRAtcP+2Ych30U=; b=lF/4HlcQ8WB0oiP0v4FeyfbLbE0CIbVljaxk/7m8oryrPXsoMjBLfhRusv0/Z9sbmO xb1Q8COyAhPHze4JQo/ai6u/dOszungEpHpasZuO1xwPQfc+uEYExfqEEurfmLAfAZjg Nq45wrL+5RdqE4UyoMxjwWtGlYM+ymUPmFJMO+ctTJwu7p+81DPUfTvsjWXy7zvQpX3g weMNgF+t/xtd9VQg7vypGkNMSKmD2QAGofreXmYcYYxrOrZm8qevPE+TIQzPROkllZx/ gmJhSC5FUCt3K76lMQIgb1QndkgxBnVvCTW3wfigmmJR1vkOyx9H7CoAB/Ungi1tkbei vy8w== X-Gm-Message-State: AOJu0Ywl/26CPwjYNBDJEHO9pcf9VUOq/vaIPy1c7DGJ8DUsKMn4CdpV LqUd1j55wN0tMNzjS0bDLLU1hK3ODppEXgnJVyYUSkOxF2U5YTx9MNUKtwGIDg0Yss8j0Zv8xGV fC8mUIZw= X-Gm-Gg: AZuq6aLc62WH9EA5PkAqnN0Y6Gyy6LNBWpY8t3cMHCsPezGLJOu6fAvJoNkPsyY9gqi 0W5p3TM+NIcUhM99/+Rz8h/jLfphSTiqIiUauFMwkYeZRtyK+eM1Yf2yo3cNgWjQvAxRQqAy2Qf EBYxRQCcqW0uz5LY3v0dU2YKVU2ZpYRNVObCajLO+Njc6t1mJojREuDnYjW3O7cj8VsnvX6mCuV xhp/RbV6P+0FFEJBmtjtOfuShqBcNn6SYGGapKnxqR36/C8tQzrqrTqwv62MYem5wcjNi44k8XA b/fLMW5Uuzulmi9c3g6H9wY1rbcXOwAWdfRnGMym9c5rFTusvUn+JUiLOhn2cj6ZGbjqf3++CaZ 0PVhvqy4BXxhWwQlG7gdru0pwdA1MWrv7apbk1dKi6SYPhfCWKV0sWETxe4UsUSoloyUsiSwP8t SyvGqlN6pv99g/TAXP5mbsAB9/LU1Yt3HrtR77WZCEuotxvagEweS2Z3TN5EkV X-Received: by 2002:a05:6000:1a87:b0:435:9882:2342 with SMTP id ffacd0b85a97d-435f3aa91b8mr22989031f8f.33.1770131084759; Tue, 03 Feb 2026 07:04:44 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 01/30] target-info: add target_base_ppc, target_ppc and target_ppc64 Date: Tue, 3 Feb 2026 16:04:06 +0100 Message-ID: <20260203150436.71907-2-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131114634158500 From: Pierrick Bouvier Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20260131020100.1115203-2-pierrick.bouvier@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/qemu/target-info.h | 21 +++++++++++++++++++++ target-info.c | 21 +++++++++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/include/qemu/target-info.h b/include/qemu/target-info.h index 62359622232..e3287334304 100644 --- a/include/qemu/target-info.h +++ b/include/qemu/target-info.h @@ -71,4 +71,25 @@ bool target_arm(void); */ bool target_aarch64(void); =20 +/** + * target_base_ppc: + * + * Returns whether the target architecture is PowerPC 32-bit or 64-bit. + */ +bool target_base_ppc(void); + +/** + * target_ppc: + * + * Returns whether the target architecture is PowerPC 32-bit. + */ +bool target_ppc(void); + +/** + * target_ppc64: + * + * Returns whether the target architecture is PowerPC 64-bit. + */ +bool target_ppc64(void); + #endif diff --git a/target-info.c b/target-info.c index 24696ff4111..5a6d7282524 100644 --- a/target-info.c +++ b/target-info.c @@ -73,3 +73,24 @@ bool target_aarch64(void) { return target_arch() =3D=3D SYS_EMU_TARGET_AARCH64; } + +bool target_base_ppc(void) +{ + switch (target_arch()) { + case SYS_EMU_TARGET_PPC: + case SYS_EMU_TARGET_PPC64: + return true; + default: + return false; + } +} + +bool target_ppc(void) +{ + return target_arch() =3D=3D SYS_EMU_TARGET_PPC; +} + +bool target_ppc64(void) +{ + return target_arch() =3D=3D SYS_EMU_TARGET_PPC64; +} --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131130; cv=none; d=zohomail.com; s=zohoarc; b=O4tXFa2X3xliXZrFtcwvNKdnJroROWP1taIcsf4/MBBbS+nKehLYE9iuqtRqN+yEfhd9ZSlNGjrDk261U9m2IWYivKOn5fTapb/WvWaPZFxfKqwJSs46OhVhFc/zFapGhSGz/PZx9FqVyT3Hduk3cVylnqGIASC44KnAVyQ33Kw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131130; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=zthk00SxucuQ1CzIK19t8pUtXPzN0T7bbc2k/4jU/C0=; b=KPQ2OLSiQODiJOUdyQ/h94i9WR+v4uqZQepU1xmAJwfphUMFDxEIsJCdiCKJAQm2XRug6orqhWYAW/xZzA2JJBjYZCnzHC3iWpRCTl4rDVNzmAvPFhnyEK0WnnU9JQOFgCSlr1/tnbrI2gDYOdqWktyTeS1ZuLEA2imcfZj8RCk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131130905574.5251761069188; Tue, 3 Feb 2026 07:05:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHxe-0000RX-Sr; Tue, 03 Feb 2026 10:05:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHxY-0000R6-Qg for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:04:57 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHxV-0001MN-Vz for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:04:55 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-47fedb7c68dso58683825e9.2 for ; Tue, 03 Feb 2026 07:04:53 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482e2e3bf18sm126494805e9.19.2026.02.03.07.04.50 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:04:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131092; x=1770735892; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=zthk00SxucuQ1CzIK19t8pUtXPzN0T7bbc2k/4jU/C0=; b=WvWYquT412iKlpcnICLD+y468G0ODouK2X/pRADNWxG/dE1dxCNhB9M9L7SW57ySib t3qAdgSJeE2QFooVtj+X570dKXtvCf/MqaSet0JQ80uDWxcEM6bRO5ikpuDvy5G2H/fg DWoCIt6X8rrOXVT/g5l8184zRLkJGZfkzfkXXIN7xs469LBn5S9avxGUgoCPG8kcKIYI 5aDVHbXyqKotrojfQtlRJy6/hVlGiMs+b6SLi0jC7vZD0KNIyanxdVMSVgoL99RJbpiA TIArwcYMlHPA7V+uRRLaPU6+56Ox6IVjEP8r1UwQIJTBtKOk/AUPx3Rlg5jSqJn0UdJV SF+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131092; x=1770735892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zthk00SxucuQ1CzIK19t8pUtXPzN0T7bbc2k/4jU/C0=; b=r9TXCvZ2LDu6WDuGrZ/YrpkJRsHBo8ZmNhVoXFWco74WUKOPUBwKmqDPn20MBUH32g ntL4xnZ5nE0JDMzBtRdyKDSzOez5VC0bQBLon33hXAspHhTlPMyNfMrZEGsvgPfqOJZf 7pmiawqE8DhgYJFEJEhMXPCznPCUbBigVTSeEQbAuihk8jyQKaqCqYdKr7HGSLZ9IH2d liHDmQNHCv0bLcPYRJcdEoTOrMSo2xmnEqTqPacqhRTKlGoyeVXxwEF0/GLDSOV88mFU EM2m5pHMoVeCKzUJZlv4lQCUnrqTafYULXw8APAR+q9a25bv3FxWkzWkX1V9wlwF6p/l 0jlg== X-Gm-Message-State: AOJu0Yzf7yGthm1h3Bt694mwE58O3UYrTNTX5Doo51665a6lLdq42m1n gOcbYbJMHZ88uBdUAolC4Cy/sm5gw07dc4sRDLnXp22ySjLrBISq0+e5gEnI2Z/vCqYxoKjktmL iI6Ze0wg= X-Gm-Gg: AZuq6aLsq4nLrrRYEfqrcfWB29bjPSNR3jeB+JDf0na/FjgGO+SrcGeu9u8gJ9esow9 J3JZx1VQbdB4EysmRyZKIMviwwGzD1RmyLbb/LZPZo5jRVRT521LIOi3N5APzTUitxhadYZ3wi6 6/zuTqEQGruylQjEgAQtSjClnaWAqa/SqQnG3ofv5u8UV4Sua78sr3GzkA6RO18WbP/rQv3n/4t +tLDcKh+vjoVph6bwQ7rztPQvjEp52kstfww/69E9hucUW/vgaKXke5F34EthtePEuZi4dNKDRU UuitXDpjrjILGQSAzoCNIaa5hiN20h+vaM7QK12Tp2KjL3wTzmAVbPX11RJMnIZYf4MN4PCWrEp bjW3AyvNDYhTzKN8bjChvDtxQRVTOfcySOdyscbmhFzazSrVQ2IQpoKxcsa6cSoUuiivW3m+V/q fKF5zW1iPU02waFGqwkZIc86B4f3TP4WMnEA/OgXWYyChgWEC54QU81cXOz0gr X-Received: by 2002:a05:600c:628d:b0:480:1c75:407c with SMTP id 5b1f17b1804b1-482db4577f3mr190304705e9.2.1770131091829; Tue, 03 Feb 2026 07:04:51 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 02/30] target/ppc: Inline cpu_ldl_data_ra() calls in ICBI helpers Date: Tue, 3 Feb 2026 16:04:07 +0100 Message-ID: <20260203150436.71907-3-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131132673158500 Inline the cpu_ldl_data_ra() call in preparation of removing it. Since the returned value is discarded, don't bother to set the access endianness. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Message-Id: <20260202210106.93257-2-philmd@linaro.org> --- target/ppc/mem_helper.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index 7318b02c46a..636ad769a93 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -320,22 +320,27 @@ void helper_dcbzl(CPUPPCState *env, target_ulong addr) =20 void helper_icbi(CPUPPCState *env, target_ulong addr) { + unsigned mmu_idx =3D cpu_mmu_index(env_cpu(env), false); + MemOpIdx oi =3D make_memop_idx(MO_UL | MO_UNALN, mmu_idx); + addr &=3D ~(env->dcache_line_size - 1); /* * Invalidate one cache line : * PowerPC specification says this is to be treated like a load * (not a fetch) by the MMU. To be sure it will be so, - * do the load "by hand". + * do the load "by hand". As the returned data is not consumed, + * endianness is irrelevant. */ - cpu_ldl_data_ra(env, addr, GETPC()); + cpu_ldl_mmu(env, addr, oi, GETPC()); } =20 void helper_icbiep(CPUPPCState *env, target_ulong addr) { #if !defined(CONFIG_USER_ONLY) + MemOpIdx oi =3D make_memop_idx(MO_UL | MO_UNALN, PPC_TLB_EPID_LOAD); /* See comments above */ addr &=3D ~(env->dcache_line_size - 1); - cpu_ldl_mmuidx_ra(env, addr, PPC_TLB_EPID_LOAD, GETPC()); + cpu_ldl_mmu(env, addr, oi, GETPC()); #endif } =20 --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131120; cv=none; d=zohomail.com; s=zohoarc; b=RYZFtuwxUQq5WTn1jmY2aTxknh9vB5IwLueJ7xxW0V1tR3710NDMOjg5ZDLtWVcfzbHK7i4/f2C/il7tDXqK0LViiBj1EDPEQLYIKUYXoyZ4ZdiJFMkOOG0kjvMAQSHuOJRqXCGHYPE9P2O3eS28Ld3WXPtT0qLDFfTGetjKLJs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131120; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=xUztfZTO9Bj5kI5u2im5cSP6/lokB3CDs+dbm5suLgc=; b=fMOpG9oErPunBS0YQ4h1+ZbRamncsDT/+R2x9CxtXdzccn1geBkb2YVj7HSpRaPDw6+O200/I7A96QXF/UZmsVr5RDxX1BWmNtUB3/KRf8i3SDDeIdCQzvXpHcVWTJSUIQ91Hr7K+XSBfOtH+8TNCA9Xrdbq94keN/HLY5BxcKs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131119973969.0252214878453; Tue, 3 Feb 2026 07:05:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHxk-0000Z4-A9; Tue, 03 Feb 2026 10:05:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHxg-0000Vv-Rw for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:05 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHxe-0001OH-Jx for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:04 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-43596062728so598412f8f.1 for ; Tue, 03 Feb 2026 07:05:00 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e1322f40sm50752759f8f.34.2026.02.03.07.04.57 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:04:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131099; x=1770735899; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=xUztfZTO9Bj5kI5u2im5cSP6/lokB3CDs+dbm5suLgc=; b=jiH/rR70Lk7RsbcC4zEEflP7BoD2fxl1Ts5Fq4/WfW7n6eYvgzRJRQbyxS2CH8iVad gGUCeabmjCXsVKKJkZKavm60bYqECs55ilWirtCdJ+zPPVZ67wpZ0if36+/NmAwtjflR gR//x5Z+0z3ZpvIsaiEg9zMkvDPWIh+bqF3K5mZFbRZf5YgsEQoK8emTg18guPuxkLI0 u7jLtOzag6QLCiFKWFgzVMT90+9UbPXZfhsjjIhmk5GnUb7+6LmYuC8VVUPa0k3NW4+8 c/8vaxBynK4nlRw1s3+WdU99Bf923tmPMiDj301wC/NvDZ3IWY/y0vwjdw1DhiE8cSCO QTFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131099; x=1770735899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xUztfZTO9Bj5kI5u2im5cSP6/lokB3CDs+dbm5suLgc=; b=GjRmoeGCqXAEDug8H0ZdPwNUBLQPQcOEudaYx0yf6K5wjgI4LmWxTT2iwom4emkrmn XK5T+Wivh4igllkK739Cos06aScf/YoS3wGNOUi9ojD1OTl9WP1KR5+gQngd6fym08E3 AADrxRwsNJF+JNBfcWnKsN+6YQSiQbQQUxd34jufjPmK1ORxYmKOF/W3TQqGie/tUQaw Q8rlCNf1h8xTDec/Nr151ppKyUn1dmAnQh2fO/5xqIN5nIsHjVEpNlN1oVIAElbcZSj+ 1IKt1zh4Bqx9BJQe2iTJxmliaK22FbtbJzRjs26EjQ0/TvGTjH2tDEMlV06W46tqYSFO tRLQ== X-Gm-Message-State: AOJu0YyphRiLGx/aPbF2wcnRNZp5rLwmXoo6xf82EyOtwYiihsEflTGq Y14RoK/MnMxye/RYpYOFnwFcMB6MjkiOtwkk1U/s8/p+UIXBJPv/LDdO/J32gRPt/kGjNXJAMMe j3obxt0A= X-Gm-Gg: AZuq6aKqA2XOHXh277FVzvuoZi7XBAvaoZu7iCRCe4dXy3FCQvW47rGFFhXZSTHlicy QrONqWgdARgYpzJgzjAFzMQ7+kozodjalTzK+YsPWoME+/197HN7iAjrBSOSPdQto+bmy9TJMyj GsPCrqDq21bUDrezmh0GQLH++VcWif8/UNLAr8HvCS+wgRjW+xeaNhoSnC6zsLb4e95GhZpJgiQ rN4vonQPKiQKa5mDX9BcTyjGW7j2+J4FEjKYrv28GSWeAxvTY+NtnKa47j5A4hEbpixWGmrMUkd b0dL7jUghSqmVUSCT8gbliEJb7ShD4fjZv88n75QCXod1Vs2EQTBPEc93xEvqCux/OVgDry5g/6 PTuw25q8H0vQhObASh8fKm5h7OdqwJAu+tsmrTbgFVlYULam6xyIH7V7MS3Rao9shUzhg1VPZGf 26BXllKy5raux9NfjyhMok1ihEwQ4VbbGYGkyx7fwSKMuTIUXgi/3leSPZBzej X-Received: by 2002:a05:6000:22c8:b0:42f:b555:5274 with SMTP id ffacd0b85a97d-43611447d87mr4981834f8f.20.1770131098830; Tue, 03 Feb 2026 07:04:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 03/30] target/ppc: Inline cpu_ld/st_mmuidx_ra() calls in memory helpers Date: Tue, 3 Feb 2026 16:04:08 +0100 Message-ID: <20260203150436.71907-4-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131122583158500 In preparation of removing the cpu_ld*_mmuidx_ra() and cpu_st*_mmuidx_ra() calls, inline them. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Message-Id: <20260202210106.93257-3-philmd@linaro.org> --- target/ppc/mem_helper.c | 41 ++++++++++++++++++++++++++++++++--------- 1 file changed, 32 insertions(+), 9 deletions(-) diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index 636ad769a93..90546967593 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -88,8 +88,11 @@ void helper_lmw(CPUPPCState *env, target_ulong addr, uin= t32_t reg) } } else { /* Slow path -- at least some of the operation requires i/o. */ + MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + for (; reg < 32; reg++) { - env->gpr[reg] =3D cpu_ldl_mmuidx_ra(env, addr, mmu_idx, raddr); + env->gpr[reg] =3D cpu_ldl_mmu(env, addr, oi, raddr); addr =3D addr_add(env, addr, 4); } } @@ -111,7 +114,10 @@ void helper_stmw(CPUPPCState *env, target_ulong addr, = uint32_t reg) } else { /* Slow path -- at least some of the operation requires i/o. */ for (; reg < 32; reg++) { - cpu_stl_mmuidx_ra(env, addr, env->gpr[reg], mmu_idx, raddr); + MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + + cpu_stl_mmu(env, addr, env->gpr[reg], oi, raddr); addr =3D addr_add(env, addr, 4); } } @@ -152,9 +158,12 @@ static void do_lsw(CPUPPCState *env, target_ulong addr= , uint32_t nb, break; } } else { + MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + /* Slow path -- at least some of the operation requires i/o. */ for (; nb > 3; nb -=3D 4) { - env->gpr[reg] =3D cpu_ldl_mmuidx_ra(env, addr, mmu_idx, raddr); + env->gpr[reg] =3D cpu_ldl_mmu(env, addr, oi, raddr); reg =3D (reg + 1) % 32; addr =3D addr_add(env, addr, 4); } @@ -165,10 +174,14 @@ static void do_lsw(CPUPPCState *env, target_ulong add= r, uint32_t nb, val =3D cpu_ldub_mmuidx_ra(env, addr, mmu_idx, raddr) << 24; break; case 2: - val =3D cpu_lduw_mmuidx_ra(env, addr, mmu_idx, raddr) << 16; + op =3D MO_TE | MO_UW | MO_UNALN; + oi =3D make_memop_idx(op, mmu_idx); + val =3D cpu_ldw_mmu(env, addr, oi, raddr) << 16; break; case 3: - val =3D cpu_lduw_mmuidx_ra(env, addr, mmu_idx, raddr) << 16; + op =3D MO_TE | MO_UW | MO_UNALN; + oi =3D make_memop_idx(op, mmu_idx); + val =3D cpu_ldw_mmu(env, addr, oi, raddr) << 16; addr =3D addr_add(env, addr, 2); val |=3D cpu_ldub_mmuidx_ra(env, addr, mmu_idx, raddr) << 8; break; @@ -241,8 +254,11 @@ void helper_stsw(CPUPPCState *env, target_ulong addr, = uint32_t nb, break; } } else { + MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + for (; nb > 3; nb -=3D 4) { - cpu_stl_mmuidx_ra(env, addr, env->gpr[reg], mmu_idx, raddr); + cpu_stl_mmu(env, addr, env->gpr[reg], oi, raddr); reg =3D (reg + 1) % 32; addr =3D addr_add(env, addr, 4); } @@ -252,10 +268,14 @@ void helper_stsw(CPUPPCState *env, target_ulong addr,= uint32_t nb, cpu_stb_mmuidx_ra(env, addr, val >> 24, mmu_idx, raddr); break; case 2: - cpu_stw_mmuidx_ra(env, addr, val >> 16, mmu_idx, raddr); + op =3D MO_TE | MO_UW | MO_UNALN; + oi =3D make_memop_idx(op, mmu_idx); + cpu_stw_mmu(env, addr, val >> 16, oi, raddr); break; case 3: - cpu_stw_mmuidx_ra(env, addr, val >> 16, mmu_idx, raddr); + op =3D MO_TE | MO_UW | MO_UNALN; + oi =3D make_memop_idx(op, mmu_idx); + cpu_stw_mmu(env, addr, val >> 16, oi, raddr); addr =3D addr_add(env, addr, 2); cpu_stb_mmuidx_ra(env, addr, val >> 8, mmu_idx, raddr); break; @@ -284,8 +304,11 @@ static void dcbz_common(CPUPPCState *env, target_ulong= addr, haddr =3D probe_write(env, addr, dcbz_size, mmu_idx, retaddr); if (unlikely(!haddr)) { /* Slow path */ + MemOp op =3D MO_TE | MO_UQ | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + for (int i =3D 0; i < dcbz_size; i +=3D 8) { - cpu_stq_mmuidx_ra(env, addr + i, 0, mmu_idx, retaddr); + cpu_stq_mmu(env, addr + i, 0, oi, retaddr); } return; } --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131140; cv=none; d=zohomail.com; s=zohoarc; b=fLAlVzimEJJ+U+gPPf5JRCVkO6FSWgKFIpVcW43KZ0/c2ozkkBvMhoYQD6eE/uzNibao52D3c7UiFtfAXnI/ySno5qSPy0p3sE9CFGUHJXKfjr8kE9h/R7CVpQbB1sHWRhCzyLnQNoOauV625Kk7Y0gR4KKOz8qftlQBaa9gyc0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131140; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=LULTJik1sZBRZnMOo9iwpBT/7GjbTofs8Yu1+pD+MBc=; b=ZJqkIDaX7bEnGS9Z+ENGpwRmbUH/KqI3yLXs8WoTDXzbVurcn/bpnnCyszsQtQ64J0K5gGK31ZWjyrfytdrIgIVkUYdqHhplkbS8wcwPRpYojabXNJpsyi2DfsqfAZO6SwJmb3xmOwtpWyWmsAZhrZh3Tf0N+t7G/PfowSarOJs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131140441639.5538457024477; Tue, 3 Feb 2026 07:05:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHxn-0000fT-IU; Tue, 03 Feb 2026 10:05:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHxl-0000ay-2r for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:09 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHxj-0001Zq-G2 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:08 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-43601e96f72so1767715f8f.2 for ; Tue, 03 Feb 2026 07:05:07 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ed952sm54513890f8f.10.2026.02.03.07.05.04 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:05:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131106; x=1770735906; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=LULTJik1sZBRZnMOo9iwpBT/7GjbTofs8Yu1+pD+MBc=; b=RSFhJ793/5kSh37DXNaajo9sSmXw4oA3l9ci3eIFzjLHfu9YdUR6V46BsTjaFEKZDz g9kK9h9zhjtaNbD5pIRjPWNwGn4onQ8W/Pl2LEW20qXmpqjJRHZppkTbxiWPuYZ5dg9s YG1aaAk+G4Lb7SuMd0OaOmnzr8rXl80g5IspCPyIvcKLEqSo+OvtSYAw9M8EojNjZRcx dPVBe6+1+q1vMizAq+5wjwbbPCphxIutLM4+ZnUsuRrDQ1nJUJxCkesREE0RCCTPfVqv 6gomG21He3F9TQWtniUH9OAVm+BcaioBqiFyyfDTp9ft+M9NegUT/fLZUkGp1XiBBSjX ve4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131106; x=1770735906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LULTJik1sZBRZnMOo9iwpBT/7GjbTofs8Yu1+pD+MBc=; b=Kl1suWjr16fyUpo4oZ19f4KCLHyErcXvZctRtvnY9x1u2bF/+m6lAajggP/eDg3L7U Ywv8tmFk+iI/39DQ0j+oHbHjVNYk4jmkHs6yywCrbP2dqJ4VlpPXitKLv1HfSHLn9KeX OHbvvOcoUrTBJebUZ2/qhDW7GUiCismRUfYymWMJ4OaZjNsONXLHnuF/gwbJcRvxgJSS 6cXtF0ruO2l34TlizFwxQGnzLaIEHxQxEDH9uSYahcN3jU/1FnaAprQMKyZcI7xe7psf XQVcW9EdVMUZukhXhOueJPziLRVj9UamaKPE9CAifSnFMt5ytPoSUnv0p1wE2y493JMA Psgg== X-Gm-Message-State: AOJu0YyJlrLMRBwKEdpy0bfwBrrsrjde3wAqdVhkTsC4/sU4NkpsR/Jg GL+89CchNujxabg9ZWZjIVv0mWvIRUzjXysNaPmNlI9awdkGczXN3AYU2WvfIrdTwxNBMrXbqT7 181JeHE0= X-Gm-Gg: AZuq6aIGfOo4PmFSl8GjGJN3fh4qiq4tpeyb71kDQku0jg/Psz/BQW5zcj87BQgAt9b shLVSY8KbFn6vRvoEuAzXjororchdC2A9E8rfvWrXk4PAgFO1o1RunMDZ3kXaGetXPdN8RT6WOG PvBg38K/pCJ2xHUWfrssbOu9l1TgVYCYj4/BesHRa9UAH3zD9MoP+0eWhXbz5+H+WRY8MK4Lb2+ NbY9/dxsvTohZkY6z6rS2AiuVmLg3nwwYp1RQcv1bGK2Temx3pWLpNuNtlkHr2eGiMVEFyKApKL pCtERh3+nvF5pNm8RhfcKbl6amTPXOWmZ2do+jGDOH6xw5shyF3LkHbCeBrfpZrTDEHCxE46Bnh 3LOrO+8UFUukrSKVZ+4ru/DW2TFbVVJi0NB5ARoVwN00p3S/ll3iuUfEyhz6VvruoA4Rzny8FEa M7UDSn6FLVvuR3na6fNjIVa8ekAR1f70NoKu0L1uTjwymjTLPmrJQCRoKlUygf X-Received: by 2002:a05:6000:2088:b0:435:b7ca:7521 with SMTP id ffacd0b85a97d-435f3a763dbmr23756188f8f.15.1770131105630; Tue, 03 Feb 2026 07:05:05 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 04/30] target/ppc: Inline cpu_ld/st_data_ra() calls in do_hash() Date: Tue, 3 Feb 2026 16:04:09 +0100 Message-ID: <20260203150436.71907-5-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131142683158500 In preparation of removing the cpu_ld*_data_ra() and cpu_st*_data_ra() calls, inline them. No logical change intended. We note the page translation hash address is expected to be aligned, so the MO_UNALN flag is misleading. Next commit will remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Message-Id: <20260202210106.93257-4-philmd@linaro.org> --- target/ppc/tcg-excp_helper.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c index edecfb85725..6f5d82af636 100644 --- a/target/ppc/tcg-excp_helper.c +++ b/target/ppc/tcg-excp_helper.c @@ -160,14 +160,18 @@ static void do_hash(CPUPPCState *env, target_ulong ea= , target_ulong ra, target_ulong rb, uint64_t key, bool store) { uint64_t calculated_hash =3D hash_digest(ra, rb, key), loaded_hash; + unsigned mmu_idx =3D cpu_mmu_index(env_cpu(env), false); + MemOp op =3D MO_TE | MO_UQ | MO_UNALN; + MemOpIdx oi =3D make_memop_idx(op, mmu_idx); + uintptr_t retaddr =3D GETPC(); =20 if (store) { - cpu_stq_data_ra(env, ea, calculated_hash, GETPC()); + cpu_stq_mmu(env, ea, calculated_hash, oi, retaddr); } else { - loaded_hash =3D cpu_ldq_data_ra(env, ea, GETPC()); + loaded_hash =3D cpu_ldq_mmu(env, ea, oi, retaddr); if (loaded_hash !=3D calculated_hash) { raise_exception_err_ra(env, POWERPC_EXCP_PROGRAM, - POWERPC_EXCP_TRAP, GETPC()); + POWERPC_EXCP_TRAP, retaddr); } } } --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131151; cv=none; d=zohomail.com; s=zohoarc; b=mGa8TIwM/ithqBDoE1KXhK0oSm1x3x+c2IeaGC+u/MiAhGCEPFJ+RsohL721UYd3awOE1sYnTWlTcJ8ml20g9/0/uXmclUPzFapONmP9Kji5q8GqtBBgNl4Q+uVIhimZIoSYbE7ML13uOb3E5IOPilewz99Y/qv/QVqELGg//Lg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131151; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=dUDGMevwxhmocOvRkyNjiWD7VSBUKTSpnU8hxAPu28Y=; b=MIIBPIpXok7qRXybn6BZvuO78ihDMQ6gRwfbAbchzHTphK6OkcGSKpJ1ZD0gcr6pVFFLJYXLS/1H9nEi7flG/SbxU2Rti3fQq7g+3Ah4uT7Gd3eAxmOZP5NRSYB5P28vqbwJIKxIbT7uZINd56Adh1XdLpIta9rZF5MFY0s8k00= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131151589668.2862173366847; Tue, 3 Feb 2026 07:05:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHyD-0000zB-CI; Tue, 03 Feb 2026 10:05:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHxs-0000nR-C9 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:17 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHxq-0001am-Si for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:16 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-480142406b3so42773065e9.1 for ; Tue, 03 Feb 2026 07:05:14 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830513730esm71313835e9.14.2026.02.03.07.05.11 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:05:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131113; x=1770735913; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dUDGMevwxhmocOvRkyNjiWD7VSBUKTSpnU8hxAPu28Y=; b=IeyK8X09IOIEu5gw5HoiMhnVa2B/EEU/wHp4GhsOj5zUVym7HS5vpjmuat5AW1fzZF SHc2wM+OUBco3qLDOI9HtOyOE94vFpmmNYJFCNpQhUlrVMBtAws8gypKJlm1EzkIzvbk MtKZBkDD2mjsCmNSpUbSOpoqLwgjSGXNnrFr5HCEatc19RqN1iraXvIGPhQs1RbPpDGY 9VghEK4b+XgYNxZpZhmdqicJz0cGC/5UonRhhdh9+sZIoitPn2beOqkarunm1xRcry5F MJXpbbA0kuFUNRfQjiECV6GmhhOuUosQht/1IVmYnbhktq8cFaDLNF8eUQf35N6WF/Sv PvYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131113; x=1770735913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dUDGMevwxhmocOvRkyNjiWD7VSBUKTSpnU8hxAPu28Y=; b=DUwWaUdnfXokBbc938w9rvovChRPDCAvihxy4e1dblQpiIzozC9MdRh4SNDCPP4y6d z+D9FuXwAJ7iX9amv336p6LIgDR8JM8Y/6k2dEQHSjILaeAOtzmnz/3yLWWB8yzNezWQ 1tYx+/PvXQ/+Ljcy+v+hfnBvho2LBtQ0GargQHj8jQwgyMB59Q+vqRshur3HaBxvJdA+ u6F8GdSsFTaTNVia4GFxJvbSEnSfqFwxlkziIincB5nxjZ3vHvRs/pPEP8o/j0j81TYa X808wsSSn1uftncR8rYlLmrAwKWg8wbYmZCsmqi8kZ5lXRR4aEhEgmqeAkIpDhj2SKUC 48OA== X-Gm-Message-State: AOJu0Yz8req73dzwTMs7tohr3BkxGJQyBcV6GqPunYksHNQYeDsAwyQx eFQi1QQ7NCnlIK+oVzTAhX4fzcvCPZlWW5lgW+zDTP2fEz6F+Pcm/Srk56glKeDhnTDhCT0Ol3K 5NxjMZso= X-Gm-Gg: AZuq6aKeRErrFHt1jy6WnJb2Kl2kM4yhb0sndYY/idRb2KbkNe/efYVBTK7UQ3ey9qX T3HrSN5C6+1XAwlkyc41vo0OKb7jiUlXgzxaWY7nZIuPSOGoVOM9jQWZWE20RH+vaJG0rIvL71f F5LcTxWIwtCSJcWnaAkbUFvpRkm1LEqFHto+PIJmxbkKHb9ZzLEymjijei90lP5StwiWJy01kNU SMuiRHHZFipB4s1ayFjq4repo/Bnj3BNalMgTZSpwFGdUckMo9CiAxkN9g4PPdT5QBArTjjy0/q eFKdPMoOV0tKRSU0q+flSNDRxi6w+fsA520RauqNILCKfeaVHXvvMqhDbm+EaqCGVJYyewG1AAc Fk+m8v+mACuDCVtJ6NVJYAcMCd63ou0JfPP/61VYIrN55n5UMESMhNZJ6ER0UzqbbGajqeFUdpN Egeo4Hz9AKneqVsHLdTcNYdI1vRDHmFQsIJTVoXyxOilCLyCrYUvjL/nLWJW4r X-Received: by 2002:a05:600c:8115:b0:47e:e2b0:15b8 with SMTP id 5b1f17b1804b1-482db447c40mr241427215e9.4.1770131112751; Tue, 03 Feb 2026 07:05:12 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 05/30] target/ppc: Expect page translation hash addresses to be aligned Date: Tue, 3 Feb 2026 16:04:10 +0100 Message-ID: <20260203150436.71907-6-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131152653154100 The page translation hash addresses are aligned: remove the misleading MO_UNALN flag. Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Message-Id: <20260202210106.93257-5-philmd@linaro.org> --- target/ppc/tcg-excp_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c index 6f5d82af636..a8c67364669 100644 --- a/target/ppc/tcg-excp_helper.c +++ b/target/ppc/tcg-excp_helper.c @@ -161,7 +161,7 @@ static void do_hash(CPUPPCState *env, target_ulong ea, = target_ulong ra, { uint64_t calculated_hash =3D hash_digest(ra, rb, key), loaded_hash; unsigned mmu_idx =3D cpu_mmu_index(env_cpu(env), false); - MemOp op =3D MO_TE | MO_UQ | MO_UNALN; + MemOp op =3D MO_TE | MO_UQ; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); uintptr_t retaddr =3D GETPC(); =20 --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131194; cv=none; d=zohomail.com; s=zohoarc; b=hc0RxPTdzMUXHDLmviTJf3e7VYCNzv3ZXG0RwcdjCO/DmdPDFga1EzNvx02Foo8JkjAxArCuSale8HOUB5YjGkGSlnESxraE4PLG8j1t7pRi5oW1mKDEmFTugub9bFpWc67SnLBSvFRnz5LY09yytL/9N5bvzribSoRJxBomyNw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131194; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=vBekIowfhSKm+z/HpzDtmhdFhXQphEU9snM01OdgKlA=; b=ez/RZramHFNXlIbGG4PiJ6U5mCcibNZr3vUEfa4I/3Eqv/UUN2OePLs/JAn7vZiw24jkzWOi46UBUOAMh4xw6/Hm+iWY/6eaCIdowjCFzegfFynue3Hg1qvWgsr44PqFrseMRGCjXgz+uEzxquihytev4x9W7ZB4jKJ6qo3UN5Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131194104750.5411710289701; Tue, 3 Feb 2026 07:06:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHyX-0001QM-BK; Tue, 03 Feb 2026 10:05:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHy0-0000xh-4F for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:27 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHxx-0001ed-J8 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:23 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-47ee0291921so55036665e9.3 for ; Tue, 03 Feb 2026 07:05:21 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830512d634sm107921295e9.8.2026.02.03.07.05.18 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:05:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131120; x=1770735920; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vBekIowfhSKm+z/HpzDtmhdFhXQphEU9snM01OdgKlA=; b=A5mSVJNoQB4Uq+sx0/h/xMgcaY3OLYmrBkXPLgol+p89j5SJFWSelbBIGuKY7d8pUf 0u/GjnkIGILV5++hS+Ik0HKwv/wigKKeKpw2O7BEnumoYNwiM70HncuDEastYOahLGqk IWh2oibNRgwui1jj6XXrheKxJ+guL3OHYucDGBsHwBbFWtp3Bl2xcZ58NRHZDd2Sq75u IN+iZAgIyJMOqtq342qXa70MgKtKS+gwHTdEC6rhlhraelK88lV6I2h7pfmC8CImCgpf B56AvO7+J4FkDT9pwEsuNP3T+AszMI05vJGmzoTHjMcbhMSZP5Vs6Agzpkz0UstY4+Tv Vk3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131120; x=1770735920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vBekIowfhSKm+z/HpzDtmhdFhXQphEU9snM01OdgKlA=; b=O/dmLG7vk+3xVmTa/Znbtxs/ImUrr1wY15FsYC6+Qp+XjU7PoHb1fpcV/V7puxSYwP EmlhU3NRqhhWDIGVgL3KYIr7q21OTupGdHnhwa1QQFeqQX5fQLNt9uUAeAUwdGvEa5My aYV0q+cje7Rrkt1uCyYsY+b6RwrKLJtRqiljLbRltf0UbVohrKJMsdj18cE7LHaz9QIW iFrzzZvdxkXUQRxAXLxBZIOHgXBDciE7iqE0WLDoans37huGhtaHI4etsc0v0P5q4+5X cDG+EEJggSIMPUS97rG7UwYIi7gqFfKsrBiG1JHqZ+S0SLeJglj4bKMdvRTg0J8ruglD Y7wg== X-Gm-Message-State: AOJu0YwU8B6qhpmL2f3rzJVwRtZJL06TjpJIT9u1ckNHSSPFQjWFJB7y uDrvTrbWRhwV3D/Hfb6vomG6W0TLOio7td7odUN/Xq8dIqlZXJalZPCF/H76c2fsJMSrTfMYxTJ 9QRfPYmk= X-Gm-Gg: AZuq6aKKXQnHtyJixdIyvK306oNEkU+oISQ+LFwYoVpxToIeKxRjMcSkr64bCS8eKQx R5M9MW5N9rfUOB+tDjdEcDuSV5sedFgzYVmh+wOID6I19/v8+tmxlX2EyFdj44O0+Umx9X5xR+h v16+iDInI+8d7zS15Fy3Op7+kIhqgip0AvEHjK5Sk2R4Dtt+OBB3rbX9ioKqnX2LQPj3lsToQZs f0hLWXss7jki2+K/3kiNQoUiE223+wLkxypGHJy9+qLyxVR5Kmh2ivC4nqzcf0V9RN0IDrISLEA hZ3BLju9+dwqBNyAudJ1hU5HYoE3eQErreZYu/gBU023nUoU3xj0PwkXKu2hlbnq+ZesTUnqoFi iECSO/HZ+QeCbhu/2VHGGp/YuhuYbt+5lhXfhTi9rKDbaRc6VScuGGp2krZGWFY0oR1QqVRztDH DZg7dDywCDQL2y8utyK4pS3MbAY8+ezsV860oqr0vup/9o46QnEVlqyKOpykWD X-Received: by 2002:a05:600c:1da8:b0:477:7b16:5f77 with SMTP id 5b1f17b1804b1-482db493ff1mr221261405e9.3.1770131119549; Tue, 03 Feb 2026 07:05:19 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 06/30] target/ppc: Introduce ppc_data_endian_env() helper Date: Tue, 3 Feb 2026 16:04:11 +0100 Message-ID: <20260203150436.71907-7-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131195387154100 Introduce ppc_data_endian_env() which returns the endian MemOp of the data path from the vCPU env pointer. Keep it hardcoded as MO_TE, the target built-time endianness. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Message-ID: <20260202210106.93257-6-philmd@linaro.org> --- target/ppc/internal.h | 12 ++++++++++++ target/ppc/mem_helper.c | 18 +++++++++--------- target/ppc/tcg-excp_helper.c | 2 +- 3 files changed, 22 insertions(+), 10 deletions(-) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index 58f315ffcf5..c3d3590cc89 100644 --- a/target/ppc/internal.h +++ b/target/ppc/internal.h @@ -19,10 +19,22 @@ #define PPC_INTERNAL_H =20 #include "exec/breakpoint.h" +#include "exec/memop.h" #include "hw/core/registerfields.h" #include "exec/page-protection.h" #include "accel/tcg/tb-cpu-state.h" =20 +/** + * ppc_data_endian_env: + * @env: the cpu context + * + * Return the MemOp endianness of the DATA path. + */ +static inline MemOp ppc_data_endian_env(const CPUPPCState *env) +{ + return MO_TE; +} + /* PM instructions */ typedef enum { PPC_PM_DOZE, diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index 90546967593..ca84131d1a9 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -88,7 +88,7 @@ void helper_lmw(CPUPPCState *env, target_ulong addr, uint= 32_t reg) } } else { /* Slow path -- at least some of the operation requires i/o. */ - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D ppc_data_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 for (; reg < 32; reg++) { @@ -114,7 +114,7 @@ void helper_stmw(CPUPPCState *env, target_ulong addr, u= int32_t reg) } else { /* Slow path -- at least some of the operation requires i/o. */ for (; reg < 32; reg++) { - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D ppc_data_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 cpu_stl_mmu(env, addr, env->gpr[reg], oi, raddr); @@ -158,7 +158,7 @@ static void do_lsw(CPUPPCState *env, target_ulong addr,= uint32_t nb, break; } } else { - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D ppc_data_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 /* Slow path -- at least some of the operation requires i/o. */ @@ -174,12 +174,12 @@ static void do_lsw(CPUPPCState *env, target_ulong add= r, uint32_t nb, val =3D cpu_ldub_mmuidx_ra(env, addr, mmu_idx, raddr) << 24; break; case 2: - op =3D MO_TE | MO_UW | MO_UNALN; + op =3D ppc_data_endian_env(env) | MO_UW | MO_UNALN; oi =3D make_memop_idx(op, mmu_idx); val =3D cpu_ldw_mmu(env, addr, oi, raddr) << 16; break; case 3: - op =3D MO_TE | MO_UW | MO_UNALN; + op =3D ppc_data_endian_env(env) | MO_UW | MO_UNALN; oi =3D make_memop_idx(op, mmu_idx); val =3D cpu_ldw_mmu(env, addr, oi, raddr) << 16; addr =3D addr_add(env, addr, 2); @@ -254,7 +254,7 @@ void helper_stsw(CPUPPCState *env, target_ulong addr, u= int32_t nb, break; } } else { - MemOp op =3D MO_TE | MO_UL | MO_UNALN; + MemOp op =3D ppc_data_endian_env(env) | MO_UL | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 for (; nb > 3; nb -=3D 4) { @@ -268,12 +268,12 @@ void helper_stsw(CPUPPCState *env, target_ulong addr,= uint32_t nb, cpu_stb_mmuidx_ra(env, addr, val >> 24, mmu_idx, raddr); break; case 2: - op =3D MO_TE | MO_UW | MO_UNALN; + op =3D ppc_data_endian_env(env) | MO_UW | MO_UNALN; oi =3D make_memop_idx(op, mmu_idx); cpu_stw_mmu(env, addr, val >> 16, oi, raddr); break; case 3: - op =3D MO_TE | MO_UW | MO_UNALN; + op =3D ppc_data_endian_env(env) | MO_UW | MO_UNALN; oi =3D make_memop_idx(op, mmu_idx); cpu_stw_mmu(env, addr, val >> 16, oi, raddr); addr =3D addr_add(env, addr, 2); @@ -304,7 +304,7 @@ static void dcbz_common(CPUPPCState *env, target_ulong = addr, haddr =3D probe_write(env, addr, dcbz_size, mmu_idx, retaddr); if (unlikely(!haddr)) { /* Slow path */ - MemOp op =3D MO_TE | MO_UQ | MO_UNALN; + MemOp op =3D ppc_data_endian_env(env) | MO_UQ | MO_UNALN; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); =20 for (int i =3D 0; i < dcbz_size; i +=3D 8) { diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c index a8c67364669..3f9eb3d924e 100644 --- a/target/ppc/tcg-excp_helper.c +++ b/target/ppc/tcg-excp_helper.c @@ -161,7 +161,7 @@ static void do_hash(CPUPPCState *env, target_ulong ea, = target_ulong ra, { uint64_t calculated_hash =3D hash_digest(ra, rb, key), loaded_hash; unsigned mmu_idx =3D cpu_mmu_index(env_cpu(env), false); - MemOp op =3D MO_TE | MO_UQ; + MemOp op =3D ppc_data_endian_env(env) | MO_UQ; MemOpIdx oi =3D make_memop_idx(op, mmu_idx); uintptr_t retaddr =3D GETPC(); =20 --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131169; cv=none; d=zohomail.com; s=zohoarc; b=BZN+VLXIc2fT/WmIOV2dVDgnHcKuwsSuacMYVGw/zAgEB8l5XfZhXyYqNaiDRlWua62QjcXRk81CBU8/qd9LjxUoFDvrHFcKMv0t5ZlqAwxzhvZjDOccuz+rvhMnWR4SvahziFUakS1oqlxfkMwIUXriOKqjo65BJV05luxN35s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131169; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=+uQCwvBnaPsyq5wIkzAZIdRNBbumuPIrG5riVXAybmE=; b=QRFcB5MlhIlPA73P5lpGQ/nowVuIbMgKMStSlckk+6LYPYxzLiAyJN6t+4a8tkoulInxp/g70IY0sTsVlhFhRyHrJyCbVZ5R3QnnLOzh5ylsX6R8H+geh2RZGaY9MK4lHx71eoafkt3+cOFLJJWZgiPjQm/5S4EuNg+d+sMo9wo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131169026540.8245379110185; Tue, 3 Feb 2026 07:06:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHyb-00023M-Ql; Tue, 03 Feb 2026 10:06:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHyA-00013v-7t for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:37 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHy4-0001il-LC for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:31 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-47edd6111b4so61116835e9.1 for ; Tue, 03 Feb 2026 07:05:28 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edfe7sm51540887f8f.14.2026.02.03.07.05.25 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:05:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131126; x=1770735926; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+uQCwvBnaPsyq5wIkzAZIdRNBbumuPIrG5riVXAybmE=; b=lWSJdsERidgfguFV6sOoIejUsMZnsEU6NgOQ5BQeebLlgLbDVTBrWvxZ9oeo1LbpQ9 a1Rsh+gQe2lgHdMcv9PYsKpkJiAbQ2dJZWUPPKqcFbaXl6GqrvXiUGdbCcsM8Q56z6Ak LpEHPHc5ZB2jdG9l64Mrr76GU2S6DRrij80AwgyzaOpXfybcpsx04o/yILzOSMG/6+Lm p3dMZZDWGkDLAOsBx+MjJS20YL7GP82YDiLhsMLfZammcRtbJRxZqIsSXdVAbh/f+OvV fmQMHHoEuy/53MdZ3HUY58EXpy+GJD8LSR6xsElHI6MYq8o2+pXFQweMxmEtvpneHc46 dU9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131126; x=1770735926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+uQCwvBnaPsyq5wIkzAZIdRNBbumuPIrG5riVXAybmE=; b=BTyCQuK790ZaZmg1dWKPuaalJfUGoA+L5FATCGakQCXqhy5vnx/djDenIdE8KbqxPr ivdQvd2WKh4CV+9lVb6SUT8WnxIw72Ut7pdWJc5yz0jFqv6aWBZOe6AOgxAGjHUQ5GEV AzElaTtiUgFNhA1dMvKKNl8qYdCsonOwUJGSWeJ34wmnaHUJpTPNln2g3rGVZW4Jjcc/ 45CFylu2zgg+n2pzOJnKCdHPWJsjpe3Z6gIoaBZ3tF6hEnzNNV4rwaHMEMaScrrU3B8Q xh9NBMV/YRT2zDCxpJSVQJXPaESVOlPKbTqYeDG9fkxntGPnmMqSxSHRErXTO5GmaFnp Cydw== X-Gm-Message-State: AOJu0YzbuL9m22s2DvIlO958Ol0ReLV1yWXIUiOvbS6CZT6JZJtpUy56 pRVxrxisWtLb57PHd8GU5ZbBRZy03fTea8kBEWgCjfTBl8DR4VYCI7W+SxwJQxH8Iz7lAIZ+ruY htSLlszo= X-Gm-Gg: AZuq6aI3H0AHMn0mqohvkTnqnApPVREe2SxpCrzGR7OmHj5+d7ncXE+IkmNQLo70y90 Ea5tG5cDI6bQlEV3bxkMn+pmQF2ndvtMFKILKvw8JVu6ZViqqUcsLclTuNkzdwvPf9QodZ7XYBv FEpIIwUabXYhVnhPlDJevL/UupKxAg8kadbNACpiLWYj0rlYlsqOk2bk+i3lLDFYZGlf4Gr4tyz jRKZZxzxJ62xA+xRrnPhKr2inzN38NGjJf4+40PraQJ0jwqycgHyVx7i677aJPtXsdO9CP6Dyq1 HkJo/P9BAru5IiuQXbRzzex+IN5svGHV0O0NxZuZ/zyvGbeourP6F/Gq/kHWKSnq3Kyf2lhns5E 8lgVo1YawFX8309cxyR2YJsjD7WnmFZWb+6Ej+scOi9Q9y6k6XABmw+o16xz24MYo6wxFbZsgIw ktln0X25ijamHt9qu94Quz7CkSeh35ScH0v3d9gWMrYKngtaz0QYm8GcItiQzK X-Received: by 2002:a5d:64e9:0:b0:435:afa5:c27 with SMTP id ffacd0b85a97d-435f3aafcbfmr24769051f8f.52.1770131126152; Tue, 03 Feb 2026 07:05:26 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 07/30] target/ppc: Introduce ppc_code_endian_dc() helper Date: Tue, 3 Feb 2026 16:04:12 +0100 Message-ID: <20260203150436.71907-8-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131171026154100 Introduce the ppc_code_endian_dc() helper which returns the MemOp endianness for the CODE path. Use it in need_byteswap(), removing one TARGET_BIG_ENDIAN. Note, the target MemOp endianness can be evaluated as (see commit 5c43a750b67 "accel/tcg: Implement translator_ld*_end"): MO_TE ^ (do_swap * MO_BSWAP) For PPC we use the DisasContext::le_mode field to swap the default (big-endian) order, so to get the PPC MemOp endianness we can directly use: MO_BE ^ (ctx->le_mode * MO_BSWAP) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Message-ID: <20260202210106.93257-7-philmd@linaro.org> --- target/ppc/translate.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 17e6d07c8c2..e1753ce19ce 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -214,14 +214,21 @@ static inline bool is_ppe(const DisasContext *ctx) return !!(ctx->flags & POWERPC_FLAG_PPE42); } =20 +/** + * ppc_code_endian_dc: + * @dc: the disassembly context + * + * Return the MemOp endianness of the CODE path. + */ +static inline MemOp ppc_code_endian_dc(const DisasContext *ctx) +{ + return MO_BE ^ (ctx->le_mode * MO_BSWAP); +} + /* Return true iff byteswap is needed in a scalar memop */ static inline bool need_byteswap(const DisasContext *ctx) { -#if TARGET_BIG_ENDIAN - return ctx->le_mode; -#else - return !ctx->le_mode; -#endif + return ppc_code_endian_dc(ctx) !=3D MO_TE; } =20 /* True when active word size < size of target_long. */ --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131180; cv=none; d=zohomail.com; s=zohoarc; b=YU1E9xVsKbGPLUHoIRAImZapQuBZh8Tnf0REzv9po+1jhdcqgFd62KMi+Y6ym8p/L+QMj+cYOBnVggBMXC7PbOMLxQp78B4ubR8yEXlVcwHmFOvCMCZZrguWzSJ1ve55Vdg0hohR+WlFJmO77ttwxbU+sKLtnJ3xx1/7Y/vUjcc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131180; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=3JkkiWNW/vPY7qYcJZ62kWywsjWOtipez8oarLaZo6g=; b=BB9cqQ0Hh5I1GiRQ3rwb759/NWmtjjlj0reKzMWEAb9iDVvm1b8ndVU0BubwNxkauO2oMSU0TTmY1UjaXE/+kPy1C+QStuAL7Us6dZRvGU1/TxUS+19u5WR21S/UKLWGpDvrZx1+Phq/Lm6ggJPMG24Zw1C3/YiYZ/F7tU0WfBI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17701311806741001.7495986615597; Tue, 3 Feb 2026 07:06:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHyX-0001Ph-7u; Tue, 03 Feb 2026 10:05:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHyD-00014k-FC for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:39 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHyB-0001lJ-18 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:36 -0500 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-47fedb7c68dso58692885e9.2 for ; Tue, 03 Feb 2026 07:05:34 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48305133689sm67848505e9.12.2026.02.03.07.05.32 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131133; x=1770735933; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=3JkkiWNW/vPY7qYcJZ62kWywsjWOtipez8oarLaZo6g=; b=sYTphMSKAXoIcE3xYxHZxdiPrUdSLCCqvD3QwCMelz79TX8XNkTw1KsccD/UVxX+Jh Et6mrSlZXvk4TShgbP1atPCKWzuFWDhvZTvgX16nHnn/b9P1V3acz3TyERl4qKMIJjJj 3x350lyTxiauLrskWdHEIG4vg4HxUuoY5URet0RUSLAQlczVCmUk2jo8NB+0o1cAcg4a of1zD5E2ru8pAWMd9Iy3rC8FgsEy66LBWHetO9ZQMheo424iqRYghpGXDbRTtNk6G1ku 65o9a3tQEZJXJJJZ9y91hpwnsn7EDzDJmvNIx80fade0Wgp3a/fCFg2W+qYGeoYPylYN XSQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131133; x=1770735933; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3JkkiWNW/vPY7qYcJZ62kWywsjWOtipez8oarLaZo6g=; b=pS6lYE1hkpT2JtaXRxlqXoBHmhDwIsUSYk0XRgTFsVSXYdRPAx7GUugPbp2Cw3vmCJ KXHclTtP9GEkQShtHLCKaXX76e1LijZTRLmaOBzZABSqvWEeYbDZX9iAVe5tjiTsvlCP ycBc06CizEAd1yFkRj+YMKvSrFGHb3VfP8Iu+kUlegWEg6vCUPvjPXQeamgmTvRwWR86 iJXlovCUu0Av4QjAHJULIRv49nUGl7VNjwViuKd0h1T2xWIojWGytW0Im3f0JBftfMh9 M7YYB1m9s6aER3pS+R4Bfcoj1Swkshwnll4ZB03VilAsbDCdqoL13dQjOAEVyVr94tOv axJw== X-Gm-Message-State: AOJu0YzjLbRl6awyH2mCuyQAcKwATBaG7iFZzSFzrYD0beLys7t6Iqj6 CECoyclcSH7vlUOGxxmR8d4zjPTENEQfe3/T5Q0NmwAhUuFQ4kbgC/tgf3RqW4wyz/6t6/7in9X /hSvjQyY= X-Gm-Gg: AZuq6aKY8d9gTgzD22Xq2k2aRTX58SOhPJIyOb8Mn7iRoIMRkwsfRF3S2l//Vrxonbk v+woafVhUGXFRpOcvB09PjIwTcQBOAPcubWL5nz8KUL7o+ZDTGH3CBpIARG3YKx56HXrjlscp54 4npcVU39QSpotCQgkCnyb0zoFh2/DjzcGbsywajEgw4sLcLSRKJ6Po1Sv2It7GPhbOh5Wu3igG9 ql9cvY+E64Fa7BZZkBwIx9sOZKKtY9iAdAmwP0lgFnDsW48KhL47O66lWUb3PxdFdznpmWzkPHO 8q2qaXfsdhl+l/84jpBAnud83DKBU99fPV6phm4JejlnU1rr+ooBEufjyEraCI5L0h4nSd5XuhD 4P8UXBQuNq96ck/e7J2lTmIEPZtJTRh9pmT7+U2v9LazrizxSmTYhpTVfo8XzVTFJ6ELq7hprEW MR4MT2i4/Umnc31VQ0/ssIWf77zwveBgkyUKASJbWpniuhXckXkGlgxgvO7MAKbv9ToCgAEkA= X-Received: by 2002:a05:600c:1d03:b0:477:7f4a:44b4 with SMTP id 5b1f17b1804b1-482db4567d6mr231897235e9.1.1770131133034; Tue, 03 Feb 2026 07:05:33 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 08/30] target/ppc: Inline need_byteswap() and replace translator_ldl_swap() Date: Tue, 3 Feb 2026 16:04:13 +0100 Message-ID: <20260203150436.71907-9-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131183078154100 Rather than using a boolean with translator_ldl_swap(), get the MemOp endianness with ppc_code_endian() and pass it to translator_ldl_end(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Message-Id: <20260202210106.93257-8-philmd@linaro.org> --- target/ppc/translate.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index e1753ce19ce..e9acfa239ec 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -225,12 +225,6 @@ static inline MemOp ppc_code_endian_dc(const DisasCont= ext *ctx) return MO_BE ^ (ctx->le_mode * MO_BSWAP); } =20 -/* Return true iff byteswap is needed in a scalar memop */ -static inline bool need_byteswap(const DisasContext *ctx) -{ - return ppc_code_endian_dc(ctx) !=3D MO_TE; -} - /* True when active word size < size of target_long. */ #ifdef TARGET_PPC64 # define NARROW_MODE(C) (!(C)->sf_mode) @@ -6595,6 +6589,7 @@ static void ppc_tr_translate_insn(DisasContextBase *d= cbase, CPUState *cs) DisasContext *ctx =3D container_of(dcbase, DisasContext, base); PowerPCCPU *cpu =3D POWERPC_CPU(cs); CPUPPCState *env =3D cpu_env(cs); + MemOp mo_endian =3D ppc_code_endian_dc(ctx); target_ulong pc; uint32_t insn; bool ok; @@ -6604,7 +6599,7 @@ static void ppc_tr_translate_insn(DisasContextBase *d= cbase, CPUState *cs) ctx->base.pc_next, ctx->mem_idx, (int)msr_ir); =20 ctx->cia =3D pc =3D ctx->base.pc_next; - insn =3D translator_ldl_swap(env, dcbase, pc, need_byteswap(ctx)); + insn =3D translator_ldl_end(env, dcbase, pc, mo_endian); ctx->base.pc_next =3D pc +=3D 4; =20 if (!is_prefix_insn(ctx, insn)) { @@ -6620,8 +6615,7 @@ static void ppc_tr_translate_insn(DisasContextBase *d= cbase, CPUState *cs) gen_exception_err(ctx, POWERPC_EXCP_ALIGN, POWERPC_EXCP_ALIGN_INSN= ); ok =3D true; } else { - uint32_t insn2 =3D translator_ldl_swap(env, dcbase, pc, - need_byteswap(ctx)); + uint32_t insn2 =3D translator_ldl_end(env, dcbase, pc, mo_endian); ctx->base.pc_next =3D pc +=3D 4; ok =3D decode_insn64(ctx, deposit64(insn2, 32, 32, insn)); } --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131165; cv=none; d=zohomail.com; s=zohoarc; b=jtYnqC84zE0zgJssq7hGSiCshtNDD64tztS/KoEG9zI1VA6fP6NnmbRUHem4cSXkSolFTGDbhbIUcBwbisLnUh8nb2RTGnQSjm6Q7T1Q0LAkEE5Fz42KyFte8/kQvbzoJiyqBEWIjNHiZfq8wpnRO5LOCCbOFRSbFHGeuwwDD9c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131165; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=US/2W/gseXtlseolfQna95tnYoLscjZYMx+/tGqLvqU=; b=X3od8lzmdWPpy6h7kdAmFPFkass+mF3tEd9k/5cT0J2TPiMzQW0AbVdRscC0rSokw/MsQg6qcZl5z+KhrR8uhVwBAFwb9Tb/tkWUB9Ugg5k7eIVfk8ksma0KyY1pjWi8nwhkYb5gFkQvRZqRoMGvjR2kI7RHBg7wEZCniywBtRE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131165172437.4196994725611; Tue, 3 Feb 2026 07:06:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHyY-0001eZ-Sg; Tue, 03 Feb 2026 10:05:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHyL-0001Ds-2r for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:48 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHyI-0001uq-4Y for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:43 -0500 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-47ee3a63300so63125195e9.2 for ; Tue, 03 Feb 2026 07:05:41 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e131cefdsm53711959f8f.23.2026.02.03.07.05.38 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131140; x=1770735940; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=US/2W/gseXtlseolfQna95tnYoLscjZYMx+/tGqLvqU=; b=leOmfx0myEan0rvJRfkjtc8sJTUiDgqeS7kSH6JRSZ8+X3ogOeAyR6IJ7FlcsQRxz7 UH5R94HNGfbgWcVejprZKzKFDbXkr8CCmxIDhjxQ4EppoIiu1hCcDaWC6wmgUH6zPu9y L0DtgFcXpEX/Tiuo+InKT8tW9HA/3Ls7B+o+aFMMoCwafEt+ysP/fRuwQ3EnKHQfD3iG 6aV7qTy3fFpSMxA65CEY6KqXBugDzDmGm2zEy6uACNmm2DzhOx5PqSMDAWeX14Mq0rNw yTS2Vt9ftFJkMFP/jOiEmlorZ3gMNtA/h4FYZIdRShrPZ4IvIrdJ2vMx7zuyD7xoXFZE pLLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131140; x=1770735940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=US/2W/gseXtlseolfQna95tnYoLscjZYMx+/tGqLvqU=; b=swV5vhD93BPo6qwL/UAbPS6ai/A5ikADIPBImNn5DIIuUfIt4EsdoMTEBxLEehZbRJ wpYrR9z5yAOicjaS/8dU2v/HvZyAoWVaOvzC584MtuYcxqP91hrde4gYXQ1bFRE3u4jF rpotgOyXrzMEqdwyX/X0uHPczW0h+IjrMZqbtFnowkZ7iegrJauvMWnI51xhfeN3+iT5 06qqGh2g1Py7/UYqYnmmSyCSQheYsAMNIcI8MC1tSPTDyb/UrN3RaLrud5EPhBkHlW8C v7L4snaub9IhyG1M9IN3JrRWshv2Mo3iRa1akO6Jd+oT0VxSGj1hHaTV+Grs76v1XWP2 R+PQ== X-Gm-Message-State: AOJu0Yy8SpcLaduFXpMstF7L3QGf5/081SNF99+Zb42rq/5Ob4tHdmdV BwTXNHppLYDYGBnEXklMc+sM022sWERVmXR4koXpC13bznlceH+I0qb7Vupt/84tbtToLdC5zxt PzWTSNTaXmQ== X-Gm-Gg: AZuq6aKT+mM8QO/yc1OHPDC3y8LiX65EpINbyaXmo/pmqswYriZ7wxGAon/DE7iD8C8 WQ21AHIQwxijkWbZQ7Mk69S1FHc6TyzK/WaWDMoqsrTZnmhjlvbNFjtO0r+dntRl1OVQD0AXIYJ AgPGHarOuQ1mVJD8HZE7Bdh+KDMe7plrOGwusFbj0pDje/82REEfUFIQSYcz7hFsEqaa8MZOD1U 5WesxIG+1+OhoR7cMr2C3GRp788s8pnS8EII7Sh6aaHPXYAtX0WZun+2lz1OX+fEQ24XQklBgGX jGuRK41sVvWh4kvUnobdioZEHKGEOOReXjerz9ztRJ+P6QiHZa1X+sxIQvy6EeWk07npCzsexGx 6M5DNS9wiPlIcEHh3w+odg0pIkBLsCttS6Qk0VWCa8qCLv5+5KlIWxOEH7ICtF4usjkf9shLi5d 8pIy4gcpKvTwyNKWqXOkR+vvj46JNXQCKWqiJ9QD6N7mT76sRKA/0Hqc58IX/s X-Received: by 2002:a05:600c:8207:b0:47f:b737:5ce0 with SMTP id 5b1f17b1804b1-482db49239emr173929545e9.23.1770131139929; Tue, 03 Feb 2026 07:05:39 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 09/30] target/ppc: Check endianness via env in ppc_disas_set_info() Date: Tue, 3 Feb 2026 16:04:14 +0100 Message-ID: <20260203150436.71907-10-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philmd@linaro.org; helo=mail-wm1-x342.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131167043154100 disas_set_info() shouldn't bother with env->hflags, access env->msr directly. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Message-Id: <20260202210106.93257-9-philmd@linaro.org> --- target/ppc/cpu_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index 58816c51a74..0808284b722 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -7456,7 +7456,7 @@ static void ppc_disas_set_info(CPUState *cs, disassem= ble_info *info) { CPUPPCState *env =3D cpu_env(cs); =20 - if ((env->hflags >> MSR_LE) & 1) { + if ((env->msr >> MSR_LE) & 1) { info->endian =3D BFD_ENDIAN_LITTLE; } else { info->endian =3D BFD_ENDIAN_BIG; --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131175; cv=none; d=zohomail.com; s=zohoarc; b=TMs6zWRvNcFRyAhwzVtYm/WmjEqXKOnl8GvV/KDH9PQk8hWU2tlhao11beEizse5PEb7lNZM4SVuzBAwmZeNIPMFji6KHZhYi2fyVjhK0Otn5m91k30T/mRR6YrZIyvoNG4J98AuwMuxzjhSLEoUddClPyoj7mXFs+kBfmuNbt8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131175; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Jm6avVJZdcczFIoFxsC4aKZsgBH8BQs4lBtZL6M+lOM=; b=N/EeKbpYTz2qtBpUyNpTnNlyutqLIHRvTrk98WwYAeYUgToNDvOL+UVvVtRTzgjINPIwigpOIvvxC8ivJLZONLJ/oSlB9CQr7BKZzc34hE0IpFi5Np8Tj/0VjyrDfhwi7Bxqa8vlnHE0+Ibl17PnXzGay/pA6wJqWlimefzNaNI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131175859364.91133521069526; Tue, 3 Feb 2026 07:06:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHya-0001tr-Iv; Tue, 03 Feb 2026 10:06:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHyS-0001Jg-FN for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:54 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHyP-00021f-3f for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:51 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-43601e96f72so1768366f8f.2 for ; Tue, 03 Feb 2026 07:05:48 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436142de842sm4194533f8f.30.2026.02.03.07.05.45 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131147; x=1770735947; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Jm6avVJZdcczFIoFxsC4aKZsgBH8BQs4lBtZL6M+lOM=; b=MhQR4QTwImV9u8IT9zp6Baml3a+65fiWFkXpGwF1dpFsB79DHZVRQDdJ2CxVezU56g cpdHlsHql4j0PiZiIRHcKuW5pH+YOxg8zUVm+qRspTaxjXE0TlJUOLZJpV3YCV+vDjgC ceyxdxRZKHlp++ECQb33gY7x9wEnAfQbF14UHgYs6kghbmCoAq+i5M8/trBBGCUegNPi m69kRDL6tJpLZ+neqF5jgRazAjSCWd9VaJ+7vm44iL/rbP54W0CcOI6T086bpr6hMviT S3BHEYO6WWRr//q0LZ8ljc/+JNbD3FbQ7MhsXl491aA7f2OO+xYd/k5qEdYHiSF7K1V5 khUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131147; x=1770735947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Jm6avVJZdcczFIoFxsC4aKZsgBH8BQs4lBtZL6M+lOM=; b=Ojri3l4UVzQESq31wQEllHvwZ4iQoNZHcp4b5N5Ju6LI6ibQvGUhvA4uBrrzXQT0uZ k/urR3YIO6/zViEQPPmiNXSMhlVBNJOONhK/EKji2m89KzaeQBR5tAcRJkkp4dDVNRkP LYFYT5pzcc8qYezhEdnFn7uM0WJZy6Obj2nsv9ubz6kU4l5YScWBC0or5FHqKzg3orvH BgguEDwmXf0eLa8Q2DyYbHGL9Iy3R39CXWijPpOK/8fGtPY+SY6xX7bevatYLLT4WIaf tQ/ljSYONGqthxbDF7sAzDS42pW61gR/AWesGLFejoUtKhrtV8qk3GvEaldokZ7TZe8V p3+g== X-Gm-Message-State: AOJu0YwzW0x1iCoTfk0WJ913g2ee26eu2KZHLTv9K1SKVnCo8xrHRxRV 56vMGVvx0UNDcpGR7gGLWSjypOn2Fs5jgNBkfTAFj6G9UHACb4Wi40R7H4zO7f5ipiB3/yp4z8I 310FVCOg= X-Gm-Gg: AZuq6aJttw2E8qQZlqhlkWVRdHODEpEo+mhUOZeBsnPwOR1oijAULzaUAzswpyJ1GEb 3SAosF+EuAopG/uGXC/v/FFEm1h+Rev6D/x9Pg7Dk+6xb9j4sl9mrs9ZXaevAl9z+YkMQZPb1sr BIYb/Wq2qJJwzqLzpnvaf96Eo3IPqtc8gq6Sh8MQGepIgc/de61beILYh46U6GZKh40S8hB5xbT gB+p41tcUfGRHYY6JmPBdO10r5E9XVArv+vLGWj5cjtkR7FSoIbJlO7ZS0vJQu7RkS+dTSBV3yh e5VmuniOau7QugV8WfoqIscOzvMU4PgV6KU3OaxJo07q3KmVhQItePYPEOidBKgp6ufwoHh58X5 yeAlBV508IsKBJoQ1hdecybtP1LB9cVuRx3sYjRoNZcVt/lcW5CVPUZCEeMc9G08ugbfcwhKuYt SNxWDtF/hiZib9Ag1whuRvp4CrMY4/d0uBdBx3//xQjlHDyKzcOI/QQzjKkBVE X-Received: by 2002:a05:6000:26c3:b0:435:b7b9:afe5 with SMTP id ffacd0b85a97d-435f3a66f53mr21021559f8f.1.1770131146957; Tue, 03 Feb 2026 07:05:46 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 10/30] target/ppc: Introduce ppc_env_is_little_endian() helper Date: Tue, 3 Feb 2026 16:04:15 +0100 Message-ID: <20260203150436.71907-11-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131177050154100 Centralize endianness check on MSR via a common helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Message-Id: <20260202210106.93257-10-philmd@linaro.org> --- target/ppc/internal.h | 5 +++++ target/ppc/cpu_init.c | 9 +++------ target/ppc/gdbstub.c | 2 +- target/ppc/mem_helper.c | 8 ++++---- 4 files changed, 13 insertions(+), 11 deletions(-) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index c3d3590cc89..e6e60de95a4 100644 --- a/target/ppc/internal.h +++ b/target/ppc/internal.h @@ -24,6 +24,11 @@ #include "exec/page-protection.h" #include "accel/tcg/tb-cpu-state.h" =20 +static inline bool ppc_env_is_little_endian(const CPUPPCState *env) +{ + return FIELD_EX64(env->msr, MSR, LE); +} + /** * ppc_data_endian_env: * @env: the cpu context diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index 0808284b722..c5cec7c2ed9 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -7364,7 +7364,7 @@ static bool ppc_cpu_is_big_endian(CPUState *cs) { cpu_synchronize_state(cs); =20 - return !FIELD_EX64(cpu_env(cs)->msr, MSR, LE); + return !ppc_env_is_little_endian(cpu_env(cs)); } =20 static bool ppc_get_irq_stats(InterruptStatsProvider *obj, @@ -7456,11 +7456,8 @@ static void ppc_disas_set_info(CPUState *cs, disasse= mble_info *info) { CPUPPCState *env =3D cpu_env(cs); =20 - if ((env->msr >> MSR_LE) & 1) { - info->endian =3D BFD_ENDIAN_LITTLE; - } else { - info->endian =3D BFD_ENDIAN_BIG; - } + info->endian =3D ppc_env_is_little_endian(env) ? BFD_ENDIAN_LITTLE + : BFD_ENDIAN_BIG; info->mach =3D env->bfd_mach; if (!env->bfd_mach) { #ifdef TARGET_PPC64 diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c index 3b28d4e21c7..b19c0f1ea9c 100644 --- a/target/ppc/gdbstub.c +++ b/target/ppc/gdbstub.c @@ -84,7 +84,7 @@ static int ppc_gdb_register_len(int n) void ppc_maybe_bswap_register(CPUPPCState *env, uint8_t *mem_buf, int len) { #ifndef CONFIG_USER_ONLY - if (!FIELD_EX64(env->msr, MSR, LE)) { + if (!ppc_env_is_little_endian(env)) { /* do nothing */ } else if (len =3D=3D 4) { bswap32s((uint32_t *)mem_buf); diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index ca84131d1a9..119dc1df233 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -420,7 +420,7 @@ target_ulong helper_lscbx(CPUPPCState *env, target_ulon= g addr, uint32_t reg, int adjust =3D HI_IDX * (n_elems - 1); \ int sh =3D sizeof(r->element[0]) >> 1; \ int index =3D (addr & 0xf) >> sh; \ - bool byteswap =3D FIELD_EX64(env->msr, MSR, LE); \ + bool byteswap =3D ppc_env_is_little_endian(env); \ \ if (byteswap) { \ index =3D n_elems - index - 1; \ @@ -446,7 +446,7 @@ LVE(LVEWX, cpu_ldl_be_data_ra, bswap32, u32) int adjust =3D HI_IDX * (n_elems - 1); \ int sh =3D sizeof(r->element[0]) >> 1; \ int index =3D (addr & 0xf) >> sh; \ - bool byteswap =3D FIELD_EX64(env->msr, MSR, LE); \ + bool byteswap =3D ppc_env_is_little_endian(env); \ \ if (byteswap) { \ index =3D n_elems - index - 1; \ @@ -479,7 +479,7 @@ void helper_##name(CPUPPCState *env, target_ulong addr,= \ t.s128 =3D int128_zero(); \ if (nb) { \ nb =3D (nb >=3D 16) ? 16 : nb; = \ - if (FIELD_EX64(env->msr, MSR, LE) && !lj) { \ + if (ppc_env_is_little_endian(env) && !lj) { \ for (i =3D 16; i > 16 - nb; i--) { \ t.VsrB(i - 1) =3D cpu_ldub_data_ra(env, addr, GETPC()); \ addr =3D addr_add(env, addr, 1); \ @@ -510,7 +510,7 @@ void helper_##name(CPUPPCState *env, target_ulong addr,= \ } \ \ nb =3D (nb >=3D 16) ? 16 : nb; \ - if (FIELD_EX64(env->msr, MSR, LE) && !lj) { \ + if (ppc_env_is_little_endian(env) && !lj) { \ for (i =3D 16; i > 16 - nb; i--) { \ cpu_stb_data_ra(env, addr, xt->VsrB(i - 1), GETPC()); \ addr =3D addr_add(env, addr, 1); \ --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131205; cv=none; d=zohomail.com; s=zohoarc; b=d8bCQ+hZMosQkNStVvghMCZgganoaFTQ1vBdEv+y9tEqYycWbx/+FrYuDrN0uarKwyCs0LkpiBiTaRcxoP6mZvt5MITkPO7M/F0OJQxzGz6i/G6JoLzibk0PEtJUYk7/PK0zYwnZgGtjJu6uWuYUaH18+kvoUedDpjag3HGPClQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131205; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=e/nUPom7HdBWDeyWRXsLINrGwvV3vAAlXW3k2FdYhiA=; b=nGjLWZ/SMMiSPz6suQ/8ea4vF14Uv9fpZkmnmkt+z2FKST4sO9/k2Vw0ULPwunl9IIpbmYF0Tp1qPfqbLDH5Ko8zizpiKUUm9yq6QZnYDc6zDTaGzyoVNycWsOprzYd0nQGDmRlohuyuxZ1gpqNJcFJrJkczpIUhRQ4RlL9SCKw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131205847631.5178798044682; Tue, 3 Feb 2026 07:06:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHyc-000263-ER; Tue, 03 Feb 2026 10:06:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHyY-0001bS-8L for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:58 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHyW-00023e-KK for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:05:57 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-47ee937ecf2so8827925e9.0 for ; Tue, 03 Feb 2026 07:05:56 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830511bfc6sm124206475e9.2.2026.02.03.07.05.52 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:05:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131155; x=1770735955; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=e/nUPom7HdBWDeyWRXsLINrGwvV3vAAlXW3k2FdYhiA=; b=wKHn+hSWISHaTmgBanznnuzPbwf3aC6v86ddHmHyKeFBUf/RvT4e/cxoePQr+4MnML N4hHL1scMDQXz5RFRXkwErsn1ODIM/uD5MIIkGgzazGjvjl9bgzWbTLeYcYr+OYcw4Cs ORnBONES1kp2SnUs75uG1m7TJMxX8EvEUfi5cSg99oj4AtFLEW+qa0HnkiTbCEeqxTG8 XX4k2yRwMGqfRxQCGuoGzAoKY46685MjZDL7uE722yEneKZdDTDYIIfQBmZ1MfiLxtv0 W/ZBlgbyGbqhSIJlcPh8WjkNQfoB0GzmLmJeJC2u690ALTlwOomz4iOq6vr3EFgrum9J zwpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131155; x=1770735955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=e/nUPom7HdBWDeyWRXsLINrGwvV3vAAlXW3k2FdYhiA=; b=C8nUdZ5ji4SilCGfOYyll7iL1VO52diauINRndeo0if0cLWJMd61RbCa3RNCZExUWQ R+ZC90dAO9gKJPoil/KIqce4cDWdsuNkpg4brZXsnjOi6zKSxqAAAfmJN4EzarZDPN6C H+eH5HIbP9JN9Up8lY7uvYHrakPI0hcTsjqhvr6KkfPoFQwh7kiGlaBNY5DOwwN6qxDI 0NYuBJdfE/X4cv8jE5rf8bZ61ot3EMq4Qs+5FTksdx6Vn6vVqNOELPdrzBWAH/MRQfF8 9C8hrnNfxungt/6r64m1uSvir0lPeVe97QXfWWmK3C/8QW0gax0dCNU2SBQlNneSrg/Z 96rw== X-Gm-Message-State: AOJu0YzqNuqdP5GksVgZRrtONDwqadcw6/nsOhrsx1ZQy6Z0RqfKNutI m2Io2hJ7VyBj4qLk1AJImZOZ8qMVNQgtM3Cz1cNgh3/s7J/d3nBhNP7Vm85gH4OpfukYFEuf8qF q1+7TLr0= X-Gm-Gg: AZuq6aKNHpcc328er25YA2yw3TowhrQIivQlQjpRjSnxUgxuKSVimSG+hxG5fDsDGI3 4bET87c4r9x6rpyFBmDxA8aLSPoyVqyHDFlek7U4OK6iTNG3zI8bSS8fGUEU7sgh31xe5/A/5P9 NUaGGo7m0i5NsQ7ENRRL+pkBmjESi0kiK7AknKbmsTEQyLkjlPFhf/6xh8PxjhYzxvJYJpLiHFq ntuslvXji6FmUiOon+ecyGFK6su3zgdIOS0ysv+vf0xid7Osnx0A4taVe1rsXpKdwCMAcRbgG2p RxMCgbK9Pt0pQaF3eWnng2DkJZWvE098lJfuDmylltUY8SNLKRYo365erl4NI5cRGuBm7mfKo6v c79KwRXpRrZfiMu8nQPQU3bg8IICY6GF5tNFYuomOGabvSGbRV6mr0IgpzgalaNqFuPxAceU9aP 19ZIduD40scslp+4Ene+da1lf/X647V6njyWXEvPch0mwuttgxcSJ/VqzAR+Uj X-Received: by 2002:a05:600c:8718:b0:477:9e0c:f59 with SMTP id 5b1f17b1804b1-48305133282mr43975455e9.2.1770131154595; Tue, 03 Feb 2026 07:05:54 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 11/30] target/ppc: Check endianness at runtime in ppc_data_endian_env() Date: Tue, 3 Feb 2026 16:04:16 +0100 Message-ID: <20260203150436.71907-12-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131207567154100 Rather a runtime endianness check via env MSR over a build-time one. Now CPU can change endianness at runtime. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Message-Id: <20260202210106.93257-11-philmd@linaro.org> --- target/ppc/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index e6e60de95a4..dda23b66096 100644 --- a/target/ppc/internal.h +++ b/target/ppc/internal.h @@ -37,7 +37,7 @@ static inline bool ppc_env_is_little_endian(const CPUPPCS= tate *env) */ static inline MemOp ppc_data_endian_env(const CPUPPCState *env) { - return MO_TE; + return ppc_env_is_little_endian(env) ? MO_LE : MO_BE; } =20 /* PM instructions */ --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131199; cv=none; d=zohomail.com; s=zohoarc; b=Io2mU1YgvZoQmgKXZrwBV9TxewewqTOAZHqXM4tGUjTzJHHT42B/Tea25X+Hf1LoqvCUQ4g+TJU7yH2C/UyZymF+5aKXDOAwFJKL3NVGjOlx/vLxZ2VXw0gGSuamNYQDhaGQM4SQ4kSbXmvT7EkBnDiESE97TCQaDcYjYpKUSi0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131199; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=g8GmMSb34/inwMA1Utl9FRkTYGijQxQFdPfSDa96KPk=; b=INPtuSPOJymMmQD6xMWUnlJVH32uBHQRf0KVwP8SwwftVq6VFSnE1Y4Y0YlwYTzNxpTP2+Fw6iMuL+d+jZJNw7aFb9T8HJGqrzrhJZz5CZ3PKCUX/EPyAn2lNH1/1d50GQUU8rlv0EewKDA2g9noHxn6LB7Jhn4xZymsMM9tdgk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 177013119915096.90544997288634; Tue, 3 Feb 2026 07:06:39 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHyj-0002r1-VI; Tue, 03 Feb 2026 10:06:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHyg-0002az-EW for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:06 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHye-0002DG-BN for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:05 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4801eb2c0a5so55167345e9.3 for ; Tue, 03 Feb 2026 07:06:03 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee057sm58694753f8f.15.2026.02.03.07.06.01 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131162; x=1770735962; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=g8GmMSb34/inwMA1Utl9FRkTYGijQxQFdPfSDa96KPk=; b=y1LLSnncgCasZkPW7cXwu1h1drj0amGk7hnRiOZ3DIHAGL+v+O5Zod/8fglcMminx4 0/x7qwae0IMpM+M8sgOnrFyuntjFPnaGHBZV0Ag+QIph1EH5aYsBPzWEaRrobapRRNnl TTi1/DMA4Y78QYefBavOFGeNnqSnpkeiEnbYqusQI0dB/ueyqqqscNX3UJc63VTy5TxU iBMWLNBLkoXJZ7q8vKhpXb4pGGb5DK0ozAb1fq8eaYmOTcWfqQYcsUh4aNQD0qSAczs1 f3xyy2VkgNbGRwpZBKtlNuXJ3od5941orGM8yXw0/jtJDDHFS5JIcMCBiwemcA/LNKfG H8cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131162; x=1770735962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=g8GmMSb34/inwMA1Utl9FRkTYGijQxQFdPfSDa96KPk=; b=rtM3S9EuIBcvy/pATc3ccPyziotSY37GLCJF34Z3/C7pCSuFB+YIIe00azcPW1IFuv hi6x8eqsGIP9d/ihffIgiMKIGVE5uz/1snjKLQWgRYV4zrP6sw7KJZpkQnIegI7+Q05Y YacZFDi/Gb2RtQTrf2V8+Gm6ZdJZ8z84Ril+nZZ7sLwgukZrj7IKPdPS3JF/NCMI49H3 GqQPb7pH7WTzMbJV5hCMJpa8NexvwKbWVUBCidwMfLDQMTlDsv2ZzejXhmsxt7kWk+oC baWkV5LzApB8urCyzhFMnEw8GYlGtkIZhV1JJCcrWJ00FFGvj3ltMrCDNjQtpHOVydrf rl6A== X-Gm-Message-State: AOJu0YxnySSVqB2gBnK74YCaXR8taymCal9LqLUxFaKfNhO//ecgUg+2 aDodEtBybfycHLVw7cRiSHVst1C3ljsAm+27MkNaz1phOcQn9ntkpDpn+OFnnPzTfM1mq14XL0e Kr9xF8Ok= X-Gm-Gg: AZuq6aL9PLbGOVRCZvaFgKYFEE1MmhFb6fDDCHhDn/4Tk63/S2RMhus5bVjRVP2l75z HKCU4PF20/pBhk9k16HcPF6iXqJlyAV7Ee05e0yOiZjVq3FpWGJzX4BlIrsA+BEXF0ked8Ue4Nd lXrzS8tUc8H9nyb55y7Bf6tOH3AvnO/+2gQgcyScgMlPFgUENVwmznFulm/wvBYx7CPVOtOt79d WR9iYQ1dd4rg/B/yBVQ3Kzv2YprdrldgMq1alyXxCiYHCDk8bdy7PiTfChR31PgFUNnfE0w9Fub AtX9ao8evTSzfqORjDAeK/U5mUdMmpY3UDH8gk0JyYckrb+GTE+AfcApmPd0ZrNtPB42lbItWv7 ReCIxz/hSzsbpr1UwFHvM389Z+SbGfCJVpsXuLrvwyyQz3aMjDv+qjQjRSxy8NcduHCY0STJP3e uCny/NJ5/ddo4U5ryACSlH59p2OLS252IiYTOqd+T9n1NsdXmJlNXUL31C/0ui X-Received: by 2002:a05:600c:310f:b0:480:3a72:5238 with SMTP id 5b1f17b1804b1-482db49243dmr220576615e9.30.1770131162387; Tue, 03 Feb 2026 07:06:02 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 12/30] target/ppc: Inline cpu_ldl_code() call in ppc_ldl_code() Date: Tue, 3 Feb 2026 16:04:17 +0100 Message-ID: <20260203150436.71907-13-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131201392154100 In preparation of removing the cpu_ldl_code wrapper, inline it. Get the runtime endianness with ppc_data_endian_env(), passing it to cpu_ldl_code_mmu(). No need to swap versus qemu-system binary anymore. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Message-Id: <20260202210106.93257-12-philmd@linaro.org> --- target/ppc/tcg-excp_helper.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c index 3f9eb3d924e..5e6c1e326d4 100644 --- a/target/ppc/tcg-excp_helper.c +++ b/target/ppc/tcg-excp_helper.c @@ -428,22 +428,13 @@ G_NORETURN void powerpc_checkstop(CPUPPCState *env, c= onst char *reason) cpu_loop_exit_noexc(cs); } =20 -/* Return true iff byteswap is needed to load instruction */ -static inline bool insn_need_byteswap(CPUArchState *env) -{ - /* SYSTEM builds TARGET_BIG_ENDIAN. Need to swap when MSR[LE] is set */ - return !!(env->msr & ((target_ulong)1 << MSR_LE)); -} - uint32_t ppc_ldl_code(CPUArchState *env, target_ulong addr) { - uint32_t insn =3D cpu_ldl_code(env, addr); + CPUState *cs =3D env_cpu(env); + MemOp op_end =3D ppc_data_endian_env(env); + MemOpIdx oi =3D make_memop_idx(MO_UL | op_end, cpu_mmu_index(cs, true)= ); =20 - if (insn_need_byteswap(env)) { - insn =3D bswap32(insn); - } - - return insn; + return cpu_ldl_code_mmu(env, addr, oi, 0); } =20 #if defined(TARGET_PPC64) --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131192; cv=none; d=zohomail.com; s=zohoarc; b=kZDyXfnM9nl/4yqtHMiy/X8526xIKM0Z8/VToNowCYyHnqWlkPww+kB6uRbm67be9Vpu58mmSRHzK3noq3sHrNflwq7iIV4IV/w7DBFHeL4XgIp06oJ+4zJUNAkYcEEnveQ9f96NJ3KjPSmjAfpiRxfsq4GmubUolN4W3JdumsI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131192; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=sTDZMTu0bvzB2QaTnI2t5fRpduKxAW0hgeqmee/mwkw=; b=T6+7j8bg4cITqidNAcDVHpzP4Gp80d0R24b/VlN6wjQcgBfKFsf7G77SqpwN+i+YCbnFWNKEquuF8dzrkjZ1LHfpi1NERRPqHeLBN2qxYIYSIkl+A8gy2pW/Zu8amjluLAtJfXHe5HW+v7IOCkVxvmSCT3VgWDehs1SWdA023PU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131192144650.8076159475028; Tue, 3 Feb 2026 07:06:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHyz-0003Kf-CN; Tue, 03 Feb 2026 10:06:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHyn-000303-VB for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:15 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHyl-0002G9-S2 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:13 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4801bc32725so44377495e9.0 for ; Tue, 03 Feb 2026 07:06:10 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483051539ddsm74263115e9.9.2026.02.03.07.06.08 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:06:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131169; x=1770735969; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=sTDZMTu0bvzB2QaTnI2t5fRpduKxAW0hgeqmee/mwkw=; b=U0RSQP/m5AG8XZwo1Ze0yoSxRszsmQ+qmDXiBqLno/tY56amQ3/mTvJwp8WAbY2dn1 MsHiyBdbdNclvybXq2K6SC7UOF+B/CwVPXLOfLARTMeiH6sHquSFl12Qu1ZtGEdS7i1G vFL0RyWS9as5zgkM9VQlYk4Mlh6tGdAvVHKBsMPrCF3JAZG0+SDDzOMseXbJQxR63ood YqBPOEqGuwtkDKeFcISQqvT/IudazvkVVeiFWzwUjNqF2UY2wjoF71G2FY9bdispTEwd K/B2P75cz/xR2GBgWihBBsMwlUo3ytIRUiQXB13nYz7e5+V12eWzSW6Pbmx3+djS6dC5 Iiqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131169; x=1770735969; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sTDZMTu0bvzB2QaTnI2t5fRpduKxAW0hgeqmee/mwkw=; b=fFWZCpdedtiEivqYZ9XrilT/x3k5Lz16ooDLiR9NLtZxJlRGyvUlFyAji07yDFfTfv i7tZMi5FFR/d/xgsIRCysiXdU4YoMX7UekXgOH7qqltFH4NhddVRAKAZDMrNwSXCGlX1 NXhQp7ZO10M4gABIxjMBI4baBXq/GQnyksbTrs54+PnYlNIkwKFV8T2dqLeaAkFjCtG/ R3suwTmL6GzBL3f/tgAO6cqJRUrjyRSyreq3ffQUg3DcV1znsV2NntznJ0ltIjAyFXuy QNwZtWEjWxJTF2b0LphECIYwnlnVqAT+Ib2Ct9EJqCwlvjhpS3Pm8TGhPWu0EVrH1E42 HY1w== X-Gm-Message-State: AOJu0YweG70gD6Pld93TmJ+ZjcU5fXP0ZTXCx7WanWOXySnhtD21+Sio qOXqliq4jBnVCuPBVs4HHH9CubDdX0hAF75UODNrrYOOPC7Whba7QE/CmNhJILmb72WciEWYqSp cMz6Dpq8= X-Gm-Gg: AZuq6aI51iHBygeel44voirdw+NUQxMYHIKf9Atu00+QKQ4oCbZDH/vgubTFq5vqROt tBI+mT8/6E/sU43uhmJed7g5P4hNv1956p/X8PuylRrNtW6mKKcdZswT1t2BsHMWHwH9XtVv6XK hDYgyqaFh3RC/Dk/8EQPHRdDmL7LA70yLQyokSl0WBKIGApIqthyw96mWt4bZHLtryTDky+lyyB fYiXLavmqv0GZA/yT3lZBI3pWF4T1lla3lyX9CwfceUXfUNREABExdEre+FN3tbKfMaSTEqDtej YdWDsesQM93ALfTrlE40jDL8saSwpyEUKqM6UkOE5XD8xi1FCQoPrG52g+WgPKlmSSv3Pz9Vn+h JaihjK+js3YEIk979+yNUo7ICzLhtaKi+U1N598W6E6IJIhNCpmZ957QmAEdST51jdhJiTL/jHp l11qHl6WmF+YwGUo07Z3200bZ3HeTppzalph9hJW/qqELP13XDkeXG3kXuzuUu X-Received: by 2002:a05:600c:4e87:b0:459:db7b:988e with SMTP id 5b1f17b1804b1-482db4655c1mr197229435e9.13.1770131169206; Tue, 03 Feb 2026 07:06:09 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 13/30] target/riscv: Inline cpu_ld[lq]_code() calls Date: Tue, 3 Feb 2026 16:04:18 +0100 Message-ID: <20260203150436.71907-14-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131193258154100 In preparation of removing the cpu_ldl_code() and cpu_ldq_code() wrappers, inline them. Since RISC-V instructions are always stored in little-endian order (see "Volume I: RISC-V Unprivileged ISA" document, chapter 'Instruction Encoding Spaces and Prefixes': "instruction fetch in RISC-V is little-endian"), replace MO_TE -> MO_LE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202214317.99090-1-philmd@linaro.org> --- target/riscv/translate.c | 3 ++- target/riscv/zce_helper.c | 8 ++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index f687c75fe43..4a2c08243d1 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -1181,8 +1181,9 @@ static uint32_t opcode_at(DisasContextBase *dcbase, t= arget_ulong pc) DisasContext *ctx =3D container_of(dcbase, DisasContext, base); CPUState *cpu =3D ctx->cs; CPURISCVState *env =3D cpu_env(cpu); + MemOpIdx oi =3D make_memop_idx(MO_LEUL, cpu_mmu_index(cpu, true)); =20 - return cpu_ldl_code(env, pc); + return cpu_ldl_code_mmu(env, pc, oi, 0); } =20 #define SS_MMU_INDEX(ctx) (ctx->mem_idx | MMU_IDX_SS_WRITE) diff --git a/target/riscv/zce_helper.c b/target/riscv/zce_helper.c index 55221f5f375..15bf0a99c8a 100644 --- a/target/riscv/zce_helper.c +++ b/target/riscv/zce_helper.c @@ -23,6 +23,8 @@ =20 target_ulong HELPER(cm_jalt)(CPURISCVState *env, uint32_t index) { + unsigned mmu_index =3D cpu_mmu_index(env_cpu(env), true); + MemOpIdx oi; =20 #if !defined(CONFIG_USER_ONLY) RISCVException ret =3D smstateen_acc_ok(env, 0, SMSTATEEN0_JVT); @@ -43,11 +45,13 @@ target_ulong HELPER(cm_jalt)(CPURISCVState *env, uint32= _t index) } =20 if (xlen =3D=3D 32) { + oi =3D make_memop_idx(MO_LEUL, mmu_index); t0 =3D base + (index << 2); - target =3D cpu_ldl_code(env, t0); + target =3D cpu_ldl_code_mmu(env, t0, oi, 0); } else { + oi =3D make_memop_idx(MO_LEUQ, mmu_index); t0 =3D base + (index << 3); - target =3D cpu_ldq_code(env, t0); + target =3D cpu_ldq_code_mmu(env, t0, oi, 0); } =20 return target & ~0x1; --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131193; cv=none; d=zohomail.com; s=zohoarc; b=Xiya2GDFmDvrALl0Y9AL593ibeO9r0RUNE/4RdPKwecRHqTyhtOYZY8+bR0Jxc4zPRh2dyzQy6LfCixGrihJCBPBnB9cIeW83JqP17EFxNp5EwtBGTuoY0ltOEm/hvpJa2wCf1tdaacA5o9K/KFiE9SzgrjA57VpnkEgEhHxCLs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131193; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=2hF09Gen+VULUnd3BGkuvBLWmpsNvNE9emvDOfPH3pc=; b=ZZTbgVXYITx522ngpbB87W3YLVV3lmytz725DY1QZwPxeHe0rWblhNmUzGdm+0iJr+pISvDvZFdYscxQZciF6HbB8OFl5jQEDIB6Yfim7gaEN5wI14LwrYQY5pGEB2V3Kcc9aGvcPzK0e8bnaYAhvy+TDNgw+V/xJwgQ3/InACo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131193015118.89874963150112; Tue, 3 Feb 2026 07:06:33 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHz1-0003T5-Pd; Tue, 03 Feb 2026 10:06:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHyt-00037U-M2 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:21 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHys-0002HZ-1x for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:19 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-47ee07570deso48386515e9.1 for ; Tue, 03 Feb 2026 07:06:17 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10e483asm50966286f8f.3.2026.02.03.07.06.15 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131176; x=1770735976; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=2hF09Gen+VULUnd3BGkuvBLWmpsNvNE9emvDOfPH3pc=; b=CWLQh8HtZvwE5AMJte3m8EeVM3DUXIkCDL2vP1RjTzDgLO3WT94uM1hhDvCEgjDJ6u kYGs4MZARnvZtVJmIC1gQW1lgCgvgx8z+t9RCstEvEpc/I11YuGleiuF8FUvPFRN4GYX arZwbsELPcsuCYxvyBwFuESWFxolzOlffyPf0rELwq+f0YGAmiZND1Oru2dQboHo4ovr nRCq3OEFca8Ya3spMeabGk2obvukCI9Ty/0eauE/tdCrcZf5/x8Sj4csx3uZBlEl46b7 a9tCOEwejxFDkbSltH1G8799fTjGS1PYcEwlyWUTNGjjFiSqsqBAEFF87SBI34oeAFOk EwCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131176; x=1770735976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2hF09Gen+VULUnd3BGkuvBLWmpsNvNE9emvDOfPH3pc=; b=J/sHzl3HpPhcOXuse99/umEchuqWiHOn/ACroUHsEyacXb6BhexNwOrV6Vj9j1BDFy BF28ztPv+wS2Woh0C2VEbcufwS+T2bw/IEtMzqNFqhNYop8HJIL/vSQhvA221iLygbPn oJtiLFXBCFaZ3MCt5L8/v+oUun6W/4h9yqOOSPlnk96WbEIXinZKfdPyiv4eUzrFsW8G g1gC0ssgXKSqhDX5/5MukoGiz6Bt2nD7laXtDFBCkLiG5tuLvz0EEwH2W5k1wo2yu02E PNKxPsBDsvsHLMDY4LEti5Gjn23U9ObGseK6eD1RkAzRuWtyl/SyAZ9EBHv6IV5CrP7k 0ACQ== X-Gm-Message-State: AOJu0Yxj/mej13Hx7F5xky4SXWiEgRyrRDxqOyx+rDiMyIEtORcMwTjC MCnUcp1YPHray2M4wbp8gBQZ9NR/mR3DF77rICMS1M5PmtKmdMOf1nIxIzYAx9CBE27z1xaWwgS WYN/T/Uo= X-Gm-Gg: AZuq6aLl9lNq9s4nwLuyB71+SYgRBbgWaRW926PlS1Y2+5S3W4CkM5BuJTFEJjLY+WI d1UKizohI1vFruojAQe6LbThCz2XiRUjy/Oke5l47NAD0aSvl709QVb2x3O3QCG/FpA7/7IC1mD eGbkT/EPHsuQ1ivaAebvGZuAgf9DfVaT2igRT6NF59jLWFpYwxGmjf3IH0nhNxOKNWB+e32Gmig 2i37t9hhWYwl1AGucDTL05v2m7qaUZiVZzylsVBAhhvtG1QQKKXxa1CF1WCJ7CvpmaRjxGMfvH6 OZ94dn3jYHJEffIcQEyCxgYdSXZ/+o1/V6a6uP52S4lxMaGF6KDIF0sXWE0rbFlA03WyKegJtSm 1NQaovlWAvB+W6yTP+qub7Wo8+iokQnV1CaemBFaog+JFm6kUJBnlLl3tgWOCkZSfbK+5j0VTls /bRG2Ymk/dfATDWGCyUnWmonDZxyKlvwjU4JV5h1ZHCDvabw1HANLyFwwcqUe5 X-Received: by 2002:a05:6000:1865:b0:430:ff0c:35fb with SMTP id ffacd0b85a97d-435f3aae00fmr24094635f8f.52.1770131176012; Tue, 03 Feb 2026 07:06:16 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 14/30] target/riscv: Inline translator_ld[uw,l,q]() calls Date: Tue, 3 Feb 2026 16:04:19 +0100 Message-ID: <20260203150436.71907-15-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131195308154100 In preparation of removing the translator_ld[uw,l,q]() methods, inline them for the RISC-V targets, using mo_endian(ctx) -- which we introduced in commit 504f7f304ff -- instead of MO_TE. Mechanical change using the following Coccinelle 'spatch' script: @@ expression env, db, pc, do_swap; @@ ( - translator_lduw(env, db, pc) + translator_lduw_end(env, db, pc, mo_endian(ctx)) | - translator_ldl(env, db, pc) + translator_ldl_end(env, db, pc, mo_endian(ctx)) | - translator_ldq(env, db, pc) + translator_ldq_end(env, db, pc, mo_endian(ctx)) ) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202213810.97141-1-philmd@linaro.org> --- target/riscv/translate.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 4a2c08243d1..cb4f4436018 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -1254,13 +1254,16 @@ static void decode_opc(CPURISCVState *env, DisasCon= text *ctx) * real one is 2 or 4 bytes. Instruction preload wouldn't trigger * additional page fault. */ - opcode =3D translator_ldl(env, &ctx->base, ctx->base.pc_next); + opcode =3D translator_ldl_end(env, &ctx->base, ctx->base.pc_next, + mo_endian(ctx)); } else { /* * For unaligned pc, instruction preload may trigger additional * page fault so we only load 2 bytes here. */ - opcode =3D (uint32_t) translator_lduw(env, &ctx->base, ctx->base.p= c_next); + opcode =3D (uint32_t) translator_lduw_end(env, &ctx->base, + ctx->base.pc_next, + mo_endian(ctx)); } ctx->ol =3D ctx->xl; =20 @@ -1280,8 +1283,9 @@ static void decode_opc(CPURISCVState *env, DisasConte= xt *ctx) if (!pc_is_4byte_align) { /* Load last 2 bytes of instruction here */ opcode =3D deposit32(opcode, 16, 16, - translator_lduw(env, &ctx->base, - ctx->base.pc_next + 2)); + translator_lduw_end(env, &ctx->base, + ctx->base.pc_next + 2, + mo_endian(ctx))); } ctx->opcode =3D opcode; =20 @@ -1396,7 +1400,8 @@ static void riscv_tr_translate_insn(DisasContextBase = *dcbase, CPUState *cpu) =20 if (page_ofs > TARGET_PAGE_SIZE - MAX_INSN_LEN) { uint16_t next_insn =3D - translator_lduw(env, &ctx->base, ctx->base.pc_next); + translator_lduw_end(env, &ctx->base, ctx->base.pc_next, + mo_endian(ctx)); int len =3D insn_len(next_insn); =20 if (!translator_is_same_page(&ctx->base, ctx->base.pc_next= + len - 1)) { --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131222; cv=none; d=zohomail.com; s=zohoarc; b=nRbqm2pZwErntqZkeeD5Rr83shQ4yiATyUQXltpVA/CCUY7w6ua4x5ZKaVbB8wpjB46e25Jicb0/8MXrBB2DhbCWEXZRMlhQr+Z9QdSB/EDFLmw87o5+RGO+uGV8q+JB4R6UgZycTkHS1NH8m/6IaF589xKM60N2O+/Ga9NI454= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131222; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=IBMz02HxPx5Ep8SztZCzfzvBJYPYJifqEnFHjrUKd+Q=; b=kim160q1k/Y2UdpzAFec0U5t3eEbmKsqlhs2cYTvmlRuY19kRt1GxYXR3aG8HgfTSez6eWl3zacRXaxfdtWbKdo6JbaLtGoSPSOAPAE7DcP5vpgkfpFdo5TqLKDyQ6LmYWnDE7qyNSZ1AV+ajSGxCkvjApMDomROok87ZoQFqQc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131222460683.3523935525089; Tue, 3 Feb 2026 07:07:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHz3-0003fW-8R; Tue, 03 Feb 2026 10:06:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHz1-0003Ri-GS for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:27 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHyy-0002IY-VI for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:26 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4806d23e9f1so64316895e9.2 for ; Tue, 03 Feb 2026 07:06:24 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10e4757sm54692144f8f.5.2026.02.03.07.06.22 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:06:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131183; x=1770735983; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=IBMz02HxPx5Ep8SztZCzfzvBJYPYJifqEnFHjrUKd+Q=; b=UB55AK5h1gOGh6jXhhYwbf5ZONaKs5wWrcXq0gYKGMUiyA7wBqJzM+cPiEHZ+W3RSa h1L5myGeNwpgJRByaNiO9SzXzlHN243L5hbXknmYst65Mf3BASFMexS72nt6EDuYMRJR WWE3CfRzBeAALb8+L3IqqCriWAlqrl+Wp1JOv6QHdfU99WhR25K9mI6QthkFECVAcHiq s3NM8HvkOuQHZOwxpyb3+JY9vaJTOQ0tAh0MHF6uAUzofH3EOuSZJ0HMTMExgYDTL9Kx EZ6veWnhzxs0qbDwmPIezMUt1PE4qSNPVA1i9McnmqpoPO59OtVniv7baY9fB4qtZGXM 5vSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131183; x=1770735983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IBMz02HxPx5Ep8SztZCzfzvBJYPYJifqEnFHjrUKd+Q=; b=EY11trjY5HuZrfkJ7iZBibcl4mk4SEA5CBPw/PnuRlL9k7ZlCKXrPPi+kS2PfeSij9 XHdlABm0V39GcljsjHsmDjqroYVZ0Qmu+A0iGNuFAcLvHMfP0dSGB+tWZ5Y6k7mUJN2b wt4T6yHyM4spltmyUxi0cS3aXAYQpc/53LhyD2OffiQ3iMf2LHJVzRQPa3mJfGrgrpmx 0via3b/wLFW8440Xl1KH1cW++Jtc2M4nDSk8I4XWDhg/4ekUMWFGkpU4Tn8Qv3QjvS4l WR+jX7/Q/oMZGJZ4AAu/71c0mS0VERz1JCvQ63dDF1CuNalMjRSY1APCGk3PR/PEr2Fp q0Ag== X-Gm-Message-State: AOJu0Yx2JLS5QH/AettLkP7TWpraZZdkq7S+KoL2hPqGNrg76EYBWiKU M7gnLgHA1UvNi7TbrHDTCElPCTGIpU7f5DYsH/85N4Z0ozMip7WVS6QA9ijM2WkiOIXL5R8GtGX +ROeAv/E= X-Gm-Gg: AZuq6aLr9O09x0xbvzCtjECILNjBBu3tIWXYo6pd8REFjqcEl/zoWAiV8P1r+ER1Zxy NXgEswME908VSwFV3pkryJ2FIFVKhCDvmP1om3XlHLwWiASimgP0jgCWOUmiSSU85vzMw/LUsCt 2dVl14d/Y2usDcpoJaisWhXIcFK5kjI9WEIvxR/ccU56tD8NSUQkBj7Xxk0OY5JCvM70a240Rs9 tWgJZe8Y72UPa1HZz70hkyPTvmsDE0domwhVAbTiMvt53YLNn86MJK2SW/xB0VqIa6/hBU169Ix +sQVC7FwJgjEOQfVF+4U7xx0W9ihNMo80qZ9YJrYWaQWKSq6i8j/1t5QMw70sSICNF06V4QEFn1 fZ2SIHHiBDwNL7VVIbGOTF4NhkL+F+Yiae9Sytz/lb6Dov7vB1smBwYSdidp4dGbGJyt+5JNhVE YVSBVvb/DZzdvm0x1+hgWAKQftilSYbKzs1L73JE8VgKbShgkDqagpurRsSc7I X-Received: by 2002:a05:6000:26c1:b0:430:f3ab:56af with SMTP id ffacd0b85a97d-435f3abc7b7mr22465818f8f.48.1770131182902; Tue, 03 Feb 2026 07:06:22 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 15/30] target/i386: Inline translator_ld[uw,l,q]() calls Date: Tue, 3 Feb 2026 16:04:20 +0100 Message-ID: <20260203150436.71907-16-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131223125158500 In preparation of removing the translator_ld[uw,l,q]() methods, inline them for the x86 targets, expanding MO_TE -> MO_LE since the architecture uses little endian order. Mechanical change using the following Coccinelle 'spatch' script: @@ expression env, db, pc, do_swap; @@ ( - translator_lduw(env, db, pc) + translator_lduw_end(env, db, pc, MO_LE) | - translator_ldl(env, db, pc) + translator_ldl_end(env, db, pc, MO_LE) | - translator_ldq(env, db, pc) + translator_ldq_end(env, db, pc, MO_LE) ) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202213348.96754-1-philmd@linaro.org> --- target/i386/tcg/decode-new.c.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index 086a3bcec18..bc105aab9ea 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -315,18 +315,18 @@ static inline uint8_t x86_ldub_code(CPUX86State *env,= DisasContext *s) =20 static inline uint16_t x86_lduw_code(CPUX86State *env, DisasContext *s) { - return translator_lduw(env, &s->base, advance_pc(env, s, 2)); + return translator_lduw_end(env, &s->base, advance_pc(env, s, 2), MO_LE= ); } =20 static inline uint32_t x86_ldl_code(CPUX86State *env, DisasContext *s) { - return translator_ldl(env, &s->base, advance_pc(env, s, 4)); + return translator_ldl_end(env, &s->base, advance_pc(env, s, 4), MO_LE); } =20 #ifdef TARGET_X86_64 static inline uint64_t x86_ldq_code(CPUX86State *env, DisasContext *s) { - return translator_ldq(env, &s->base, advance_pc(env, s, 8)); + return translator_ldq_end(env, &s->base, advance_pc(env, s, 8), MO_LE); } #endif =20 --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131212; cv=none; d=zohomail.com; s=zohoarc; b=Po3UJdRknVrQ0s8plIEwOn79L1gduHW8hGLWn9t7k5Ez1de93v5jUZy1WzB+Ng13hmKfpEl9SEsNM8mu5FNnh+k9810VWDEDAcvvq3ntazsT1gMocvMvjg7JXR6qJKs0jNILpPWJoveaV8SdViorMZF0GzJW7p0JI/O5NNvMgzA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131212; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=2BwdxwgOylBEELY70JUf+5ITZYYVYk6FsH73loe8VHg=; b=mqLPiRQmwF8Oy59DtpYJ6qePSP3L7g1sBbJHZgU7vTuZZsZcKVSM65Lqe/bpSFGFoxMrQIzMCnkR2DWsmk3hSitnjDJx9Jv8iflGSQGiuCLEl7X9yc9vDVB/JMup6E8trdxme4Qzubk/1d9EsIKoZ5zaJCzaH65W8IRzK5yl6cA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131212596232.26310317133436; Tue, 3 Feb 2026 07:06:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHzB-0004UL-32; Tue, 03 Feb 2026 10:06:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHz7-0004Mc-Ht for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:33 -0500 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHz5-0002J5-UJ for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:33 -0500 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-47ff94b46afso9522825e9.1 for ; Tue, 03 Feb 2026 07:06:31 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e131cf16sm52972114f8f.22.2026.02.03.07.06.28 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:06:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131190; x=1770735990; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=2BwdxwgOylBEELY70JUf+5ITZYYVYk6FsH73loe8VHg=; b=y8WyhJ59RfE477CtrvRUST1ZbgPATxfRM4oB1AvJ3M4R843Ot0kkC8BjjWpAZp0ZuF fvkHJbmH1Ts4ulZ1JpyUfzX1AhPDjMuYCscYZv1K+yBtkFMcKWZt0pb6mSWP1dRzBK9L Pu+XlDel6OLYaiR+z0SG+7nqBROc+mDYGtGiQ6530l2oDmeyrEpwDImPQaNzATmxnr2y FiAfCMhoNEgb0NQEkpI1XsBr/h6oEJf3ffXTtJML2K1xytY8Wp99OCd2AqABIEwOEtkT msl2U+9TlUucQjgPS6dcB0BVkkp9gcG+EPyJQPasA376ql4fw6Xn1tGZa3XHY0aq2HmX HGnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131190; x=1770735990; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2BwdxwgOylBEELY70JUf+5ITZYYVYk6FsH73loe8VHg=; b=tsXgdIzVlGRP6yg0tuqWZ+sXRrvVnVTDfuyaTYBqC79fN+TKKyHfb/VN8OzepINliu Ln/JVWLjfZcgA8zkojO0HcVV4G1kJw42wjjgBXndTzo32xeeQLBs4cugwZlpWgQ6SW7b krTc8O2oQyh7/1pE2sApJL8WJ2+ZXYXzgZoMJKUE7sfxCwQ5ZxUMRGwUxikvinYsqhir BQZK/UGSD1wm/tmfIWPyq0wuGpYgma28FlM2VfmX4LNCJwImel4nIFysY/02sl8vHz8B B/GKsuacD7rW6YcpLGszWIit8pQtIAxKM9PJYz2lL6UtdtpExnE97DcY2Q4T9cHFc+Rl fJzg== X-Gm-Message-State: AOJu0Yxsw5JDTetO1t7fGFcZplmLmQZkt0mObI+6p3DThfu54pgtI9/2 WNjbYoBs6tyA5fcXyyFAMVJmuxMR7/NSWOwFOIrS8VJ4RUviEFb0N4BxGWDNfb28linmi/oNzic kt155AU8= X-Gm-Gg: AZuq6aLzkoCTk4VQHp5qApv2HY1zfTY5WU09qKYW+Z+M2fA2KhS1MiQF49UEafZplXt 4QbtxFgSkf+H8SpaN4K5H/NNSwAidUkzf0Ilo0nUbjWO4tylY8+z7ns7gc/L1M0yRFAlwl4edNz iajamZzMzQkRtU+4e4LLuCp7mXdUCthFAQKQoH8fX1LkdKhGcucMqYvGqdShPFNZL70VQDqjYy1 g614jeO+tuOw4K1w3W2hlYOu0W3WYaP28spSb+kXffG4JTuQKzPbPHwW2EvGUnYWrLncQmDkOFZ QmnZXOklTZGPDFrJ/ECkyIEZXeWBB30H9ylhumvv4F3YRxjeZSRPvMpz1R/8J3bWHV1YqR3lQzN ORsKQWiyNiyXtevkQ9KQJsMpjRNRV9B6apAsLrMX4RF0BfExgWfGyDehM8CFKfA/Qh12uO/OuRP k73XaQDoicpRL0b3Za110u0f3LEcwCF7c+f6K2OA6V4DBJXzzBeA1VOulgrklj X-Received: by 2002:a05:600c:3e18:b0:46e:59bd:f7e2 with SMTP id 5b1f17b1804b1-48305144e7cmr45290105e9.11.1770131189987; Tue, 03 Feb 2026 07:06:29 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 16/30] target/m68k: Inline translator_ld[uw,l,q]() calls Date: Tue, 3 Feb 2026 16:04:21 +0100 Message-ID: <20260203150436.71907-17-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131213160158500 In preparation of removing the translator_ld[uw,l,q]() methods, inline them for the m68k target, expanding MO_TE -> MO_BE since this architecture is only available in big endianness. Mechanical change using the following Coccinelle 'spatch' script: @@ expression env, db, pc, do_swap; @@ ( - translator_lduw(env, db, pc) + translator_lduw_end(env, db, pc, MO_BE) | - translator_ldl(env, db, pc) + translator_ldl_end(env, db, pc, MO_BE) | - translator_ldq(env, db, pc) + translator_ldq_end(env, db, pc, MO_BE) ) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Message-ID: <20260202214050.98935-1-philmd@linaro.org> --- target/m68k/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 721668634d9..a0309939012 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -347,7 +347,7 @@ static TCGv gen_ldst(DisasContext *s, int opsize, TCGv = addr, TCGv val, static inline uint16_t read_im16(CPUM68KState *env, DisasContext *s) { uint16_t im; - im =3D translator_lduw(env, &s->base, s->pc); + im =3D translator_lduw_end(env, &s->base, s->pc, MO_BE); s->pc +=3D 2; return im; } @@ -1412,12 +1412,12 @@ static bool semihosting_test(DisasContext *s) if (s->pc % 4 !=3D 0) { return false; } - test =3D translator_lduw(s->env, &s->base, s->pc - 4); + test =3D translator_lduw_end(s->env, &s->base, s->pc - 4, MO_BE); if (test !=3D 0x4e71) { return false; } /* "... and followed by an invalid sentinel instruction movec %sp,0." = */ - test =3D translator_ldl(s->env, &s->base, s->pc); + test =3D translator_ldl_end(s->env, &s->base, s->pc, MO_BE); if (test !=3D 0x4e7bf000) { return false; } --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131226; cv=none; d=zohomail.com; s=zohoarc; b=LxSHhrUuR7bw3JmJM2vzEgZKpW/GvIZ5EZ3xjJnEvMg+WuoWhKWxhyRoxDcG5Fi+n6j2luTRyl5NFIoVzUfDUOkTTDlxAyWSSBao0x/LIWc3ATO0twDUPfoYcUE46JRH8MwGWMnljJvQoZl2ampRIBHxaw1X+IRvEPGK7TPeHAY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131226; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ZHLK9xF6FFZPJdae8zYkCIhr2oN3p3ZEyAeM2tfMACY=; b=C0sVBSBX75JfebL3dqjuO8+E+75wIx8+ToIV3nOuzXMPQJQ17uue4YhY/fjT2sX2sg25EKyVxMWR4DXvkTZoCPM5qt5B2ndsl4vdNAUG1RrwhzbOSAlTBU4yrs/yMEbZNpoOllMmiHlxOmqMNJUikhmRbIxcYRbsB3emK0jFcow= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131226634762.1145744510266; Tue, 3 Feb 2026 07:07:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHzY-00057G-Sw; Tue, 03 Feb 2026 10:07:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHzH-0004kM-HW for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:45 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHzD-0002KA-Io for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:40 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4806b43beb6so42127935e9.3 for ; Tue, 03 Feb 2026 07:06:38 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436143d81desm4627556f8f.42.2026.02.03.07.06.35 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:06:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131197; x=1770735997; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ZHLK9xF6FFZPJdae8zYkCIhr2oN3p3ZEyAeM2tfMACY=; b=fEbxIw7QvqaVtRWmzLE1TVXU4wUDJbLzw3jzdHiA566oCnHWB2XKRAnGotjLZKs9dO f7Bb253B1LSzGnzc5phgib/EEUwJeIJbQ4M/2NMEIPmjYnLLdk7X648NYWiEymuM4wI3 mcCd/KYd55+elGShRXHoOsTjnyBlfCXtpnP6V7UKu+OitObe0IJOP32BLLN1RgDEaRsB 1d2ECyuPJLlkAeaDOR2TbkJIa4/31a5lOr2q/HxWnwvC01UXySmImWHMLKltb12lJKxR B25+Nu/CWfeHrmU5ZKIBrsEc7VohOActqASThnEQs67xFS+H0CfPBlKdfal+3vFCb12R Hmsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131197; x=1770735997; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZHLK9xF6FFZPJdae8zYkCIhr2oN3p3ZEyAeM2tfMACY=; b=RIlTqIzm8oyxswFEDamAWbG5vG+/z2QXW99Sc96rk8qvao1O69WI+irMtZFPxOPVSx gJgX/uKPhUsfWEfzLB/t1uBmt2h7l66SiFUTlSx1klJtkFeayxEzx/UCP4Yl7J0TMrHL 8QvY27xt7QiaAbMcxaJ5Tia8YuDQJkQkcDnxwSmTeN3MGuXUYDheyfvwlNE5wdzQrwtN WN2g9RtdKNYTtY8aa6Rfa8pJI525+qR/NhqE78rdmxXXn1qkPmIicStR/36W0IbOCOVX toPJ4a6A8tek++8lgLHxtv0Xjj1AjJUs/95Pzb9tavWlSkvEzF4VKkdzX96c6HSytlVU nIJw== X-Gm-Message-State: AOJu0YyIDddiPouguHmoIvnjPDY3+A5oni4OaPxu+1dpcPw8HOy5dUpR QgYdQBvM2KrUQXu1DJssb46pgr/Q0Wd8he+ESuu6ht2XxMe1RbJVlypBK+Z8E7IA9gUvk0YbK8P RFN4bMw4= X-Gm-Gg: AZuq6aJh8W/LsZO+yXtcqT/ahxfCS5QTowMEBcMGqnJdImQOO6OY4fK9GAx+T4dct6Y HnSw4bS8zXMP7ZAICIcYDjFzMkMAz3RtmYtinSHZ4Jd3T1RZIDM00iv+RIqe2TZIY0QU//3Jt53 dKgHqFl0Hvq+ZFGWTn1e/X4LZEEFO1N1LHAOyWo9sU+kgiNgQ9r8dLgL7vxJUiuKfDygIiqbpUu lUbASfxCbTOK9RlYLp3EFqm3321QyUIhV9NbiFCoopuBp9BV7aJ1nVQzEQnIPpunTvntD+zD3an jXHrSqgg2KlsuX0XePA8LIldIoYegduQJG0nwCeMKVdMCQt8nhymrkRTCEJIuYIv2rJGlfhgD9Z Ov/wlFzWl6ufu+JumRZB43huRPaE4OvOGnCtyWA4MllrkwJbPzMF1zeyyWNukai4kZxJmWfKHRw coNjXx14pSjjZdaLE28LgX/D7xsA+KnxycxFD1dY0COKCwvGLRaDjIi/lDmmyrg/VQIMWZeX8= X-Received: by 2002:a05:600c:6814:b0:477:9b4a:a82 with SMTP id 5b1f17b1804b1-482db4af871mr207610945e9.35.1770131196956; Tue, 03 Feb 2026 07:06:36 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 17/30] target/alpha: Avoid target-specific migration headers in machine.c Date: Tue, 3 Feb 2026 16:04:22 +0100 Message-ID: <20260203150436.71907-18-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131227758154100 machine.c doesn't use any target-specific macro defined by the "migration/cpu.h" header. Use the minimum header required: "migration/qemu-file-types.h" and "migration/vmstate.h", which are not target-specific. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202234550.34156-2-philmd@linaro.org> --- target/alpha/machine.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/alpha/machine.c b/target/alpha/machine.c index 6828b123ca1..dcba5d441be 100644 --- a/target/alpha/machine.c +++ b/target/alpha/machine.c @@ -1,6 +1,7 @@ #include "qemu/osdep.h" #include "cpu.h" -#include "migration/cpu.h" +#include "migration/qemu-file-types.h" +#include "migration/vmstate.h" =20 static int get_fpcr(QEMUFile *f, void *opaque, size_t size, const VMStateField *field) --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131231; cv=none; d=zohomail.com; s=zohoarc; b=FqccA9syBbMkhtqSeSphX4b5EUnYvkVjDbziu4U4gMPI2GA+nmbZds3lXI8WfniyWt8PeguqAKTFQwfGGhE5ofNx/tGaxB5PKcCCltsPghLi6VwINGBijCntURSQWIUmeGH5dPWgHlpsR6+W4IWByyrilWkeBHKDjKubInFjq3M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131231; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Z+C5PDsnQGcIFMRUR9zAjFAYU8U9yegFI04WOi65q9E=; b=cHnh/9VSid/wVK4EoD0tW47yltAtpuELqZLjKatczTvXsaYPkMsfaJkVDdpJ2rTLbx4o6eXiknSKFBDfV/AwwyOM+YwqgziEIf8g/puF0p+N9zEBF+YpAFJnXc58/ymYQW4vipiQLQN0OiPJI3ZLsvOVtNCBl6aYxok+Zz5MYug= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131231612458.17674794331276; Tue, 3 Feb 2026 07:07:11 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHzb-0005Sw-DA; Tue, 03 Feb 2026 10:07:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHzY-00057c-RO for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:00 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHzS-0002L6-6w for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:06:56 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4806bf39419so5583965e9.1 for ; Tue, 03 Feb 2026 07:06:45 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482dbd3953esm145542275e9.4.2026.02.03.07.06.42 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:06:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131204; x=1770736004; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Z+C5PDsnQGcIFMRUR9zAjFAYU8U9yegFI04WOi65q9E=; b=K0HscoPYFG8ean/01wdAyUbib0w9NyzZchwxrvZGh/AjGkQa3t/Iq/O/Ux8icz2Ib+ yMuVa4hdR1xBvlHATzvdTUsX+DOPyxP/cVdLj8/t/MXqakJUJdURErPbf8w5d2ysWqu0 MwymI8tWtuhjdaO5bo3ZtbPug/qWaMuueIGJhLUZVRay+Q8r/8j2K9w1BTTdA2lCLKFY q5DmcAhLb1u0H9OtGFMvqIW5kP04NiqxeuGRYGeQ4Qk1TIdYa57Obp+mQlRbjhQ5ePpQ lBE2q2bAIbcYe8bQ4kQOWMC2RdMzsL0NUwD/B388SPqLKFpXOSYSlnjIgCsnBIcqTXEe Hywg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131204; x=1770736004; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Z+C5PDsnQGcIFMRUR9zAjFAYU8U9yegFI04WOi65q9E=; b=XnZMmO3UeSVnjIsWFALzD4C69OQirYlQtHccoIleG2UHaM2sWuXYHtwdkqe6AU/i81 lT9ND8XWvAQ7IzK4NuFxYCBGPjkRQjgyKIkXd800ksgA39HQm5JK3/Z6XweyIaaxbWNL bgX0tTzdYbdaVAD7KMfUa2OcT/XZ3ZwsK8XJsYS7EOecP57ncmJL9qpF41mV2bfkCVHV Cx7dtat56WMAE8Qpyd6y29/aUaYis1741NSlRP5ealCVd+MrpF4Z/92lMQ/icmhe8o6Z e6MYLBddHAgoPOBDVnc89lqIq3UHhe4zXeNjP/d6d+r0Jzc9ogfbqSmNQjowdy7/yr8K hslg== X-Gm-Message-State: AOJu0YzTXGkJC1hWC5qoPn/BX971AXq37sTFuDXfTQKwWTiXqXZIqFy3 AwgVSA+wYS2l7X0mc+vUny9f4q+ZUvKOYgrprK9CyTDqstfaGmtgvn7vALNt3pTYt18xVyl6ZBN GjpA1uWE= X-Gm-Gg: AZuq6aL9zzxMZHzNvbRz8M16pfr93apIwRi4A1Fb4H+ieWUZWLzFW310rYiKCAufDb7 9StLDzTfxxF/FQNCRlPLwnI1Z0bjhktX6X3vgiQGdee+lkek07em5hjP93uCuCSb/7+zXzdEuzh Lbmvp8cEIhU2tgd1oEDve37QIGHcmgHs4NkFw2opV6xxhRmb4Blf+qPIe5IVHmACdpxFN3jxGBF K9OWPByHQhs5PSKsH9arNZ6rXMnOwlfwK/j8EVj8xxh7UsB1W0Ad3nU069e53UnrSyEu4PUdLvo hqmSwe6DlmG/uomdY1c6go4qFaz+2Zn+dfX4DIOh0ZGUC42Hj1JMdl8vAYLNgbGunHRgBB04OJr Ag6iKZQYpgLEarusJyUo11CPBGNgkd9N9gS3kPhluN6zVx+vNww9GTy6FAUJwz1tUlNfHe5cIx1 SJGN1YMBI6idLRal13EOKADFqjmg4KE0MKcye/Qi1bElnrwUo/xD4I4oxniD2J X-Received: by 2002:a05:600c:4f4f:b0:47d:6c36:a125 with SMTP id 5b1f17b1804b1-483051553a4mr52551835e9.17.1770131203777; Tue, 03 Feb 2026 07:06:43 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 18/30] target/alpha: Build system units in common source set Date: Tue, 3 Feb 2026 16:04:23 +0100 Message-ID: <20260203150436.71907-19-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131233208158500 Since commits bb5de52524c ("target: Widen pc/cs_base in cpu_get_tb_cpu_state") and 32f0c394bbf ("target: Use vaddr in gen_intermediate_code") we remove all uses of the target_ulong type in target/alpha/. Use the meson target_common_system_arch[] source set to prevent further uses of target-specific types. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202234550.34156-3-philmd@linaro.org> --- target/alpha/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/alpha/meson.build b/target/alpha/meson.build index 7dbbd557171..9447f8020be 100644 --- a/target/alpha/meson.build +++ b/target/alpha/meson.build @@ -18,4 +18,4 @@ alpha_system_ss.add(files( )) =20 target_arch +=3D {'alpha': alpha_ss} -target_system_arch +=3D {'alpha': alpha_system_ss} +target_common_system_arch +=3D {'alpha': alpha_system_ss} --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131237; cv=none; d=zohomail.com; s=zohoarc; b=nfPJp3VoqkP2i6R9iPEzfgVyOeIKHq4O97pDxXrmNiV94ttocu/HHJp4wPKr19G6LbPhJUnTQ2d54Rmc6Mmoa6BIrJWdU3Ioc4NYtnD0+K0aMWe5gPLW9JHcEdCve//rjuxeZ9EddY4FnF3RNSlB/gz2pBXkhCzpEcbf+IKi4iE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131237; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=W9A/okJ7C9PIOD8AAAtJFAFWfHxVqk7++w51LEZY/d8=; b=ObjMbE0djLB3dL3eNRi8I6n725/K0k803lW9AazAAfHgB0JT1FIr45sOoAb1kf5sdqpAs9AuYupW86K89yows4NcDCwpijClUFwyrCpO4j2hcDodXbHCXqSU+2XPiEGG+mXhsK8J9gf4A6TqQGOZpVB1Vz+lHIQi3LShd8izCeo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131237001710.8830954864143; Tue, 3 Feb 2026 07:07:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHzj-00069P-8E; Tue, 03 Feb 2026 10:07:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHzb-0005We-IK for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:03 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHzY-0002M8-Jp for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:03 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-47ee0291921so55060805e9.3 for ; Tue, 03 Feb 2026 07:06:53 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482e297119bsm118866255e9.17.2026.02.03.07.06.49 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131212; x=1770736012; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=W9A/okJ7C9PIOD8AAAtJFAFWfHxVqk7++w51LEZY/d8=; b=sg9rMKavd0KFY82FGroAZeUZTvfh2loVUnvG5THIYytEp2xQan56Y2ibdO80m5pO8d xzmXLd1t9UXoJEMzg0XHuouWYP9b8zktZ+0B3qxjN/T5cTARePbZVk+WOLrgldfISVkN 8NSNst0i6tKbktTEXrJ1HvRev6K/2K1lvG5ItSLcxqKnpDfHT0PsqYhqbeiuQ9BWffQf DBqyuyj7ubQkO3+3JJ+qebxE8tBzNgVCzKnhEr+T7UKHI154qiqz57nNBNBPzVKHUKkr qhm/meo+41OlR1bCtrH5FUDYAQm2CSetfHQ6uLtzoTDjJCb/HfZnZn81v58GjRUbAfZi KUbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131212; x=1770736012; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=W9A/okJ7C9PIOD8AAAtJFAFWfHxVqk7++w51LEZY/d8=; b=YyccGbXgZRIgt8pcT7vVm+b7SK283ttPJFYyB4KYcYBzf2dLWOcaLSJCttY66E9XIb 3bieuyZmZik15iflEVcg2DyHGZEMFnaiUnovc4Gl4hbuUpOST0tPJs2ttzOJSOyCeP51 NZlTrkW9JDqD2qlNwtM3h8PS9lNHBar/qcxI7+glrHnTDNhl8YIgxHeGTlHKvZX3ZbNe y9YkFEa354naZpTbcTWyJtno3jxdp/tU0OnYeMyr9lXwhbZZOkq/p+cSk3ZewouBQjz/ o7D90s+kEFxOxPCfoPH2NfLSavRIXX5xrW2W9aev/XL2GPm/VleWLziWid9bAEzc0Elh UzSw== X-Gm-Message-State: AOJu0Yy6DBFTRgff4h9EZ9UYbR01BYk87O9AeBr+6JkDmlO+FQ82daJk 4h0LtrgNqr3TCLZsA4wzaPipDisjpoUSiBgI4gmFs8v6DGLfBP8EM7D2aQW73pFmX+rzJNjUqTv OxsjBHa0= X-Gm-Gg: AZuq6aL/RcN2um/LLqskuCdNbOO6UvoofL6rpo0jAsdy72JycwIIYFbcQPBxghlsMif oCLc5ByMQIjqqXMqwJnATzVpzzvv8jRzE0yp+z2LX5pVOKBUIGoYMDzfTB7f8TQXDiLZ0d1bwiC xjKzLzji3MMjaDia1SoUddwnyFlW59DeiII1vKCOcmhx1HnvtuBVFw2Q3DkXtjQ9r6KxVd4rBUP Fl8pGtM+PRLekLCLnTitBm1a8VrBZF/6Z+o5q5dvjoNUnlB/5/JExsStLF8tRcU8oU3/XRBle9e MXXQtOwDzZ8dDQ+NRYmw4ndVyxTTLehgOGInfnR31XwpC1mOFWvoLwXOzWTjeuwZQzYKMRJDB6D G/q3keUbJljowXXQbwj3Undxa+gbYfN+X+0q642S29+tFDw18gbQStZVIfCAwtPK77xOoTnLkxD u25GWuJ12NdTEFNrVH8xe8ofaAgdolTxh7OuoPjHnCTeRL4jcBc8JD1uzesWIM X-Received: by 2002:a05:600c:3ba0:b0:47e:e71a:e13a with SMTP id 5b1f17b1804b1-482db4ee2camr214778725e9.32.1770131211557; Tue, 03 Feb 2026 07:06:51 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 19/30] target/alpha: Replace target_ulong -> uint64_t in gdb_write_register() Date: Tue, 3 Feb 2026 16:04:24 +0100 Message-ID: <20260203150436.71907-20-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131237246158500 On Alpha, the target_ulong type expands to uint64_t. Besides, ldq_be_p() returns a uint64_t type, and all field / values accessed are uint64_t, see target/alpha/cpu.h: 200 typedef struct CPUArchState { 201 uint64_t ir[31]; 202 float64 fir[31]; 203 uint64_t pc; 204 uint64_t unique; ... 443 void cpu_alpha_store_fpcr (CPUAlphaState *env, uint64_t val); 445 void cpu_alpha_store_gr(CPUAlphaState *env, unsigned reg, uint64_t va= l); Use uint64_t instead of target_ulong. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202234550.34156-4-philmd@linaro.org> --- target/alpha/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/alpha/gdbstub.c b/target/alpha/gdbstub.c index 1a7e2dd9202..a7110e8d1eb 100644 --- a/target/alpha/gdbstub.c +++ b/target/alpha/gdbstub.c @@ -59,7 +59,7 @@ int alpha_cpu_gdb_read_register(CPUState *cs, GByteArray = *mem_buf, int n) int alpha_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) { CPUAlphaState *env =3D cpu_env(cs); - target_ulong tmp =3D ldq_le_p(mem_buf); + uint64_t tmp =3D ldq_le_p(mem_buf); CPU_DoubleU d; =20 switch (n) { --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131244; cv=none; d=zohomail.com; s=zohoarc; b=Uen5vhP9rcHTl1MF76zoCeXbg7d/EwNPbdtn2fzFsyk0jVZTt3L6yHi3xzOaREWiP3TqkFQxyAbpkO6Dw7Quebd4vaNWiM6lo/LBcQ6bdFgS3DV3AZE3wG2MmHTKA2RgEPvbNwyWiftTrIk8Tz/LJ6p/MWh++MU9aOFzlFfxWxk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131244; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=aOyWNIQY2zrEQlsluNmHHH92qW0jD7NTLVHRoHPN2vs=; b=JIBFl1vvl5RotifSsgMCNhMxNvT5uzTUSxVmunpUobg0UnAQWQgXkoOxUqY82vlG2dDCc+Pg1S1C3utf0HEo8/0hGaSqlGq2vbRxVNizhxNdy4qX6SxRP10wMZL1NCUQOEZkkGrBz2OUZwliS90jRYRRHApPS8LGXs6IIqxOdlk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131244564665.3161065014874; Tue, 3 Feb 2026 07:07:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHzf-0005x8-OP; Tue, 03 Feb 2026 10:07:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHzb-0005Wi-Ic for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:03 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHzY-0002Mp-Jq for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:03 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-480706554beso62323085e9.1 for ; Tue, 03 Feb 2026 07:06:59 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482db623407sm154182265e9.0.2026.02.03.07.06.57 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:06:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131218; x=1770736018; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=aOyWNIQY2zrEQlsluNmHHH92qW0jD7NTLVHRoHPN2vs=; b=GiZ37uEW+fwS5vLWPiwQcsNsPGPovbXdCVzKWrA/8Cy3pU4Poq2chcmEKk6dSZ6DkG OVtTnlZnaFEvDMcZw868c1xhGciIgVelKDMe/WuLp4fGS8XV7FV7qqIqOG0zCxGv2+9l 6ndYi/YWUilFSyWXGz+voDiM+MZ/oYzRQS+yRn08T2aywC7StAD9RujU+ubIuzXLTgk6 wBr0k2b/dCYy/cgyzxHTZoT59ds25GffpdDbo3InYymoqKcW9lvcPPOhXZkmJzldt4bH kK9I6Z846XJzpdmltvD1JEFeawuGWMQgQUyr2o6eHlIjkLjG6ZCVVBEwWRvyMhnlZF8t GzUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131218; x=1770736018; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aOyWNIQY2zrEQlsluNmHHH92qW0jD7NTLVHRoHPN2vs=; b=UnMuzrTydnpUFW+l5eQO+ubCNnsQ2WJr2QsYcmJUY1ea64O95jDYxCRrb/w6QxpJ4t St12KnRENVLEgTm3cfs9VL+4Uuv+GmjBUf/1JvW8sQTWOc0Ro292sJiAK30laTZb6VNk wNuA5ZSfWM5KbYam4wRt1IRALvjEC+s8qQzssVd7YJHdST2ggeoRypgcrg3aubIz0wm7 KWkotfahzF2bprEvL5ktBuO8QI1yId6DyKPgCRf26UE0CrhVjeVj2rdrTwReTsJ7nPZg dpZci/yYaUxfl+qqey4Wz2DOENpo9KghO9rwHmOO6l9wUMzvNoiDQCGk3NI8xn8ekLC5 iBew== X-Gm-Message-State: AOJu0YxZapr93+q0PJGiozsjg5vrodbuIXAvyiHwHQtSMDATGbLvpcsR G6e1g8o9mMDQ821ZWf5g+9+S+531KtcnvHDM/3UFZau9S5WYaSRfmc/K5Q2CB83rM3bWwN+S0UM JJTUesME= X-Gm-Gg: AZuq6aL2ZtjVGxZsXJ5rjUzQ1/PadLRilHW/A6Nh/v6xQSvviiGnbJ1wnbF3Gl15ToX WDbBrWQwa9GCWd1YMTRBvTfLwt9zC8Uxn/WYzh8Ny+ftzuyZNDsT0bfqP0KQuGZOrxCovvFRUoM yynbAbM72jeqov3pkHaSg+jsCNSXamgUNTHJRMpNDF8TlVbDtrL5hsCScq6gE5HuDQSEn5jenKg GyF8JzP6KqAV+8FHYti9Mvi2ASKT0mkYfmplC5Er8OVIslCWeCzwkKXSsKTO8Nf/UzpMDeL+rdz ZT6r+XAnDMuE3K4kijFsBaTlcupCUj1l7xUWEzqErkAC5B0f1ItMyEvHLduGkl9wtNSZcZENAfN DMTrF1a+d9zHaN3CrxKSCO2vJVh4l9M87LPc4VD9/zpkuIMhG03cZMc0KiQloRJXJRPbFuk9Nn0 3eL+BUXhfhXvh0PEayVNO0kcVlWT1K9OspEg+GWhTTzDFS1KxZ0IlVNZ9FhtmW5seOciKOH2g= X-Received: by 2002:a05:600c:530f:b0:47e:e20e:bbb2 with SMTP id 5b1f17b1804b1-482db45dc5emr222739535e9.7.1770131218252; Tue, 03 Feb 2026 07:06:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 20/30] target/alpha: Do not use target_ulong for trap arguments Date: Tue, 3 Feb 2026 16:04:25 +0100 Message-ID: <20260203150436.71907-21-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131246023154100 %mmcsr and %cause are filled with @trap_arg1 / @trap_arg2, both declared as uint64_t in target/alpha/cpu.h: 229 uint64_t trap_arg1; 230 uint64_t trap_arg2; ... Use uint64_t instead of target_ulong. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202234550.34156-5-philmd@linaro.org> --- target/alpha/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/alpha/helper.c b/target/alpha/helper.c index 126a53c829b..2dc52cc4465 100644 --- a/target/alpha/helper.c +++ b/target/alpha/helper.c @@ -129,7 +129,7 @@ void alpha_cpu_record_sigsegv(CPUState *cs, vaddr addre= ss, bool maperr, uintptr_t retaddr) { CPUAlphaState *env =3D cpu_env(cs); - target_ulong mmcsr, cause; + uint64_t mmcsr, cause; =20 /* Assuming !maperr, infer the missing protection. */ switch (access_type) { --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131265; cv=none; d=zohomail.com; s=zohoarc; b=kJVhKqZyBhs31orNjlY/ebhKAgM1DyX2U0dtkYvb9neVWWx5gJCIqMT6GzA0vPkj6VTo5OjUewDo4aDJYMWrqsIRlSRXuAi8K5uzAvkatfpoYTpom78a5vWTAnlIllnKC5QoshkIlKTFZ5jAWRr8EbLP9/ojRnWouhJvnJP8HUc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131265; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Wg3kzQERP1Tgs5FiNcwJ1071cd3u0gLKnJSMnOg+67o=; b=cagAPO17OSzr/Z72cF8zEUhW4hfTiM/XT5Me4J6luM3E4mggxLvJWMcFM3dt9/EPzqCdcfKJVk7kBN2vPYYdZqEt0Bg30f6CJEsBzrd3eDBR2/YU9yHMxHfmkEQnRjgWA5Jz4eMF68Lew5xJhivyNJG1ixuN4PjD5GfFkRzRKVM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17701312655881003.663958836457; Tue, 3 Feb 2026 07:07:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHzm-0006U8-Aw; Tue, 03 Feb 2026 10:07:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHzh-000670-1f for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:09 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHzf-0002OL-0o for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:08 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-47edd6111b4so61139955e9.1 for ; Tue, 03 Feb 2026 07:07:06 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483051372cdsm110909775e9.13.2026.02.03.07.07.04 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:07:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131225; x=1770736025; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Wg3kzQERP1Tgs5FiNcwJ1071cd3u0gLKnJSMnOg+67o=; b=LtTAXhu+HA7gIK9EredfIHL+AZ4/jJdrbHaonA1boRTNBx+X1+HresBys4qHmYA3fx pintEZa0GqnHl55bShO3lJBYp89PEM5uefp9hMMAUCWI5EDr2n3lU11vgXpjIQpUD/aN +mwBX6Ibd3JCNFVvcndVaCv2IvEv0cXF0+zrcuagMCAdlCQ4nvbaE7vVp3JLhwuuli7Y zzUmcWzn2whzZxu87lI9oVATH1czV1XMJ+CW8UNKPqHNs4C86oD9ACocGlvk2A077fS9 kNUjS+66ENJO+UwDDXRMQDjXp/Hnt8dTTkgpVJghgoRY7YaIIPbABjiA+InQAiXuwFbG eM+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131225; x=1770736025; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Wg3kzQERP1Tgs5FiNcwJ1071cd3u0gLKnJSMnOg+67o=; b=ECZlnRRiXgfAVO54IFB9VpCLT8+I73kF32QQ6Bdb029SxmEIPb/NsVkLO0s0bOYS/H UHOI2LGGqBwISWvvuq7nDtbD02qf+KzIPeIaFpx2jc873h7i6ctsB9rKDmYrp+PlAzbR sbqEfH60yAfonWrD/U4eLfTwEIM6tfHFqXDquEp1Uf4NXgKsE1tRU6AZzaYgtAyLcvT+ v5N/zV/L6BBrm5y++4JNlT71+5asL4kMvLbtBgF4tO79Yu6Q0zFzRghB/EHE2iacYGNo kUyFaSfM2Ky4H2VGMm6JgS3Gz0TzRrDl3ebV+pNnGYvc56y+0wx10Z6KlArCrqA+mxK4 SVOw== X-Gm-Message-State: AOJu0YxO4Wr3LDOh6GplG9tetT2bcop+IWoB+6b0sPM3zkAOubcTdn1N 5yfPbq2EW1o1Et3DfzWV3r273/dYy75iPjviTrL/VLHdV+7eVa6l0/wqUObpjjnxmUcPX6gdEbK V0/akCP4= X-Gm-Gg: AZuq6aJ0xnXk7SMWRuF6SDrBbf/sgCHOJIarSwa7LUy9MKXXSLvM6XV1v7x2OFU5HDF oTzEbviZ8RBicmhj9INEhl/ydGB4M4O9YQBaLHwg3CqgX/q7RwhinL8wzVFQXAq8mp4phHaYDa7 sYyDOKRps0vkFquSW+qWKDmx7GKqMmuYEkzELPGEX5NwUxwyiZfJZhrSozan7c6iWPz4CGG8FzG dguNTNDL0tjBsawRYlemGWx0CiC9zDe2brhOV6OaU09DNK03TqDtzcWP0RWiPVLfNPYkilMKoDM cr1aKWLwJfyfMVIzupolWVXOF7ah/lmsEWHy2n29YzJwm5AYONtBB6ngIivu6IPQZKwK+e/uqKw nU1SZG10bGd96QiqNhrGcONCUrJYw9+LC0TeHME5jvejWSFeli1vUK86EzGCZ8dqiFAxj/DIJWq kTLGy7KUyZTvDiTfgAJ3c/Chu+YkeO/VSzMu58m7HGaALHLxx3TiLJ1c06dxe8 X-Received: by 2002:a05:600c:4ed0:b0:479:1ac2:f9b8 with SMTP id 5b1f17b1804b1-482db481b45mr186650405e9.21.1770131224945; Tue, 03 Feb 2026 07:07:04 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 21/30] target/alpha: Do not use target_ulong for page table entries / indexes Date: Tue, 3 Feb 2026 16:04:26 +0100 Message-ID: <20260203150436.71907-22-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131268282154100 %L[123]pte are loaded calling ldq_le_phys() which returns a uint64_t. %pt is loaded with @ptbr, declared as uint64_t in target/alpha/cpu.h: 236 uint64_t ptbr; %index is at most 1024 so can fit in uint16_t. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202234550.34156-6-philmd@linaro.org> --- target/alpha/helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/alpha/helper.c b/target/alpha/helper.c index 2dc52cc4465..d6200d101cc 100644 --- a/target/alpha/helper.c +++ b/target/alpha/helper.c @@ -173,8 +173,9 @@ static int get_physical_address(CPUAlphaState *env, tar= get_ulong addr, CPUState *cs =3D env_cpu(env); target_long saddr =3D addr; target_ulong phys =3D 0; - target_ulong L1pte, L2pte, L3pte; - target_ulong pt, index; + uint64_t L1pte, L2pte, L3pte; + uint64_t pt; + uint16_t index; int prot =3D 0; int ret =3D MM_K_ACV; MemTxResult txres; --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131256; cv=none; d=zohomail.com; s=zohoarc; b=dM8oQXcwjhR1MNRm6T+U7VqRJjBXAniCLjUzWGecJd4dg9OdsSdJp7qK1CPjbk9Hr3VTCaPdzxn42Bcly/vPQvcHbodKvhqPumR+HPenZMebOUPlHuf5u+x6Q2923mr6tgotH60VYAhtIOPHBhH51yeB7bx56TPz+6p1mWFNLwE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131256; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=bjhzaEBGyHaRFQtACgFvrwQWK/lqJCAf9i6R698ij38=; b=GEC/N1OtGGvkQCZP3ZfFCAfjlAli1TX6rB2kD/xgxgedb4VuAx4fIQuG637q6s3geSzdc0J9EzsPdGRmWIoHzm4Vl6v07z2zmqRD6m3OAc2KLRaqOWXW6pFKMCGJLocaD5f+IOJW4obIr332rj/Wdy49vAjaxpLvreR7SzCB1tE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131256297411.77231413751736; Tue, 3 Feb 2026 07:07:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHzu-000777-CQ; Tue, 03 Feb 2026 10:07:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHzo-00071V-N3 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:16 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHzl-0002Oz-JJ for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:15 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-432d2c7dd52so5968891f8f.2 for ; Tue, 03 Feb 2026 07:07:13 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e131cf16sm52975072f8f.22.2026.02.03.07.07.10 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:07:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131232; x=1770736032; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=bjhzaEBGyHaRFQtACgFvrwQWK/lqJCAf9i6R698ij38=; b=awJ/fX9PIPwIeDIJiKtCcayQSn2HMv66NP72PTJ9jyBQijH5mHTHN3J8ZQXjHIgGFp c6OUde9ZczHSQ2oJSpBWt47/aSFB7WhHkgbeIPu1DEGNo42LEbS4qFLf3m5m5xAXElnx EBqRUk7vlztsJOKuJP3EykF8ATc89Ds7RpeBZwPL0OkSM/06QWJoVT15SzSoEWz/jqBn DoTeiAjtLZgstvcxuom8HOvEpHg7Ro2j5WNdGyG1J6Qm08oKVVHK2vPMvJ1eAl04/BPU oX2RLffpkly5YleUx8qXyNXtcZteUrHBJuOQoN7Kl+nEX9MOMEA2kZ2oVPvNEUv9BZjp oqgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131232; x=1770736032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bjhzaEBGyHaRFQtACgFvrwQWK/lqJCAf9i6R698ij38=; b=VdxjrVL0jEaXeqh8rKdkayx7iOScFf5B54zrz/z0u8/89KL/rW2pbUEvmJJByPitU9 lIqj2Qx0XSl1GSBkH3xAxogW8M6RpavBvHBcpgQNBuq47VtwXyohhgR0mbQOig6hfLHG 7Hrd4Y3MlaTABO6csXZ/0hQPImEdQRbbLhRTE4vVhCU56BatHg6zpZ3bWMnDnPA153Zg Dq2MdDOkfIx+YQ07VqBJRMzJ9SwqZREzylc/pMK2eUW1c4SVSEXLdzkORPFFOhko5LRq dXyEbKiS/5X2RfRSO21qZR7MhDgTqBC9MkgQc9uYJ0EuAudRhQsYhylC0agcJhJQ13Jp OPPg== X-Gm-Message-State: AOJu0YyjIwG16wcX9fU3t9YP6QmkOnAPMNcGDfsEcELGjZ8Nu2sWPf2R GJbMYQ5d8n5ysNVzVfJGxmR5VU/APnlSrbqxIBnMNb2RmuUpvvdiEW6qwobeFMcw5PrSweE7eBD KBzfdX/M= X-Gm-Gg: AZuq6aLNEdboAOr2WfsvAjZ8aUMDYuShaLZ4gVaYJQ7ki0yy3XTDUsZtiZwBjVK5QwE Qp9F4EXxPy3f6ynENsfbqHXj8E7CAt3dTx0DSY4MxHU966P0lAyqqltn8c0BnBVUU8kWfYigIOQ iF1lBhE5PMJpIZqXje/UpO7i5SrHCfvmtbAjx8L9jYZau7kBxMpkLejW2YVOBg/fkO9x2FHRHAV DdKm5VzGYwEV2XSqq3ZHv9AhGzicVp+LDz1nDa+IhnM7Gs3/E/d3hK/T3BYWstAO+GB708YGzZt 92wGd26MrWqVanNacFYC+L5tmrPmcTLUJ8LYPlVjitRgUB8tAzoUvuOsCBwArxDEzkP+jL+QyAQ nVJm29bm8QwPaBqm+h2xfLiEfci2HNy1AAGEPoe5i9eCGQgw0HloMxluwJo9UkX0c5/h/hoWCD1 9ZdXvW2upU+XHfRX3SnN5Dtg4EP8NFIkdTFTltScxabdOQaK7IMpqRqguvo2jO X-Received: by 2002:a5d:584d:0:b0:435:a2f8:1533 with SMTP id ffacd0b85a97d-435f3abc7ccmr24715415f8f.52.1770131231598; Tue, 03 Feb 2026 07:07:11 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 22/30] target/alpha: Remove target_ulong uses in get_physical_address() Date: Tue, 3 Feb 2026 16:04:27 +0100 Message-ID: <20260203150436.71907-23-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131258187154100 %addr is a virtual address, so use the 'vaddr' type. %pphys is a pointer to a physical address, so use the 'hwaddr' type. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202234550.34156-7-philmd@linaro.org> --- target/alpha/helper.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/alpha/helper.c b/target/alpha/helper.c index d6200d101cc..179dc2dc7ae 100644 --- a/target/alpha/helper.c +++ b/target/alpha/helper.c @@ -165,14 +165,14 @@ void alpha_cpu_record_sigsegv(CPUState *cs, vaddr add= ress, } #else /* Returns the OSF/1 entMM failure indication, or -1 on success. */ -static int get_physical_address(CPUAlphaState *env, target_ulong addr, +static int get_physical_address(CPUAlphaState *env, vaddr addr, int prot_need, int mmu_idx, - target_ulong *pphys, int *pprot) + hwaddr *pphys, int *pprot) { const MemTxAttrs attrs =3D MEMTXATTRS_UNSPECIFIED; CPUState *cs =3D env_cpu(env); target_long saddr =3D addr; - target_ulong phys =3D 0; + hwaddr phys =3D 0; uint64_t L1pte, L2pte, L3pte; uint64_t pt; uint16_t index; @@ -297,7 +297,7 @@ static int get_physical_address(CPUAlphaState *env, tar= get_ulong addr, =20 hwaddr alpha_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) { - target_ulong phys; + hwaddr phys; int prot, fail; =20 fail =3D get_physical_address(cpu_env(cs), addr, 0, 0, &phys, &prot); @@ -309,7 +309,7 @@ bool alpha_cpu_tlb_fill(CPUState *cs, vaddr addr, int s= ize, bool probe, uintptr_t retaddr) { CPUAlphaState *env =3D cpu_env(cs); - target_ulong phys; + hwaddr phys; int prot, fail; =20 fail =3D get_physical_address(env, addr, 1 << access_type, --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131283; cv=none; d=zohomail.com; s=zohoarc; b=CMb4baRwh8ry0V/Wr8nT0WDdUg7lGHvmyBWQzOAm07QIGt6QBPJezZlyPurB0kDiAJgA0tdCv1F5ofHDj/zJu3U2wtSdKN+9sSQM7qjAAIwpnPmP7UWdN7ANVhUgX7OoumPoosR+IDwxbDl+WwjFJxQTzZ+hOrDXkvygT8DcVC0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131283; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=tRdCKIMFOSLSm98TXb7MXZwQsD3sT0i5k256AlrpB0U=; b=TewIisnGrayajNFkhXA0xnMa1E+4ABLvUeBqxYgy+Q6yUYGiu8LE51Pze9lXAxzfkM2dVUTdBQ+NZR86Udkq3pH14iP4GVg9JDz6lkKxysBtf/tjIXBao7G7dI/pO+xSs9QmIJVJsyf99tp93pbStf1XC/MYcablTh2fnIZHqms= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131283149386.8271748579268; Tue, 3 Feb 2026 07:08:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnHzy-0007oZ-7P; Tue, 03 Feb 2026 10:07:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnHzw-0007YG-9M for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:24 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHzs-0002Pw-Q3 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:23 -0500 Received: by mail-wm1-x341.google.com with SMTP id 5b1f17b1804b1-47ee937ecf2so8846155e9.0 for ; Tue, 03 Feb 2026 07:07:20 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482da903a30sm151291485e9.1.2026.02.03.07.07.17 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:07:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131239; x=1770736039; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=tRdCKIMFOSLSm98TXb7MXZwQsD3sT0i5k256AlrpB0U=; b=N7GW1v1Bf5U65+M0oMtg2dI18BTotUzBNTrsvrlXCCAJmyz9Ar6XF0gQhcfqFBXtiB zZUud6RLikVynOHGmV9599dP/Km6cVaEFnbi4Dw8iGXnHa3XGTvmKnhIvSDeyTu4Nme3 gmpyrTDb8LwY6c8qI3lPeVig36lP126ihesrfCO9OxXRc48w6W1FstFUk3Kpse52F2KZ A3+g/b+Gfmd4ntwnfz1h5nsDQrGEwWda22JnYqzInw6gidO7AyOQRzHYo45kliEDunoQ 2vCGKUJdxZe/MsRQF+9kmkpGRBnW0/jpLPC5HaVklYN33kxj2vP+M7cPOGxxjb+T2zrt ILDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131239; x=1770736039; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tRdCKIMFOSLSm98TXb7MXZwQsD3sT0i5k256AlrpB0U=; b=fP9QEFlpY9wkHeyaHGstfroaZnIBxSK07HBJeyfNcNuRkdCAs2U7KfyW5z1jN09pz6 +8snHquYDBJW7Y5WNrvhLeu7c/QMZtEIVzhq0lteodG08A95c/KV6e0BYwQh+A0x6tcu HTan+ATeZ2SI+zMpOhhZaid/MhNsYR9U3/39XxVe3YXZGeOL1jRM7MVSBhF8+dCE06v/ nqCMqQwiZrSob164Lrmjkx1XdAspAH6DG3Com9AzClbv2pCt+QvoA5xWfdkNCwwi5VPm AbzKfXjP1zXqnXiY0FFDYt2eVnqnC0N+cOAHe7a1EwkJTLfq+VpAc+a6iv/caFcqXKJm y1Eg== X-Gm-Message-State: AOJu0YwmCyK/zElwjsI8R9oXComVqOZTTMBJpXIqX74kIYYEqOPN77LS mZ98s9OykO4SJFzNHCQX/yHT/pDnI9MX7ZrtHSciQVCb8wd6XjEYa09kAupELhbUfda4soru/u3 pB7IITbA= X-Gm-Gg: AZuq6aJX6MgH0ze7LFRakZKN8OXfhpXNeLKwyw5tsSN311CaEsgOqlQDRdEwZJEtvQL nyuwunDUZracDvtEbzjDvHyshGSPl5rJXY3xWX9Zrtfx+7A9H1oe1PZ0CgaA1glJFNxUs1Q/d4m 1sT7SrVwFhK6vedhKhm+ralmNeQ7HE3NR1J+dv8+p4HNIBhzCCOfh7wTrbNS0l6GTQ8JbTnS9cF 3yBKLVzbZzz92rPjq09pjBncEkd4GgMz/fb9QgP+LGrGD7wiOzxwR33YPivII8xVXORa7Znrk/a Bjae6KV151YmuTMxC6SGZe/X8yiV22928uhVjpqoIJPYUmBvEbz/kU6bEU+fFp4+W1p2QI3rSl7 zwQ066vTY6nte3fneTQtr2h9o9m+1u6xmDSR/oduo62UT9BT3GjdeyMVqXH3GpVJK/A9FtN5IXX ETldfXYg68kn4gHgcp/OsM2Gy6hTE/c6/nmwPjULh/osXdpNnNqSoCnw71IcFH X-Received: by 2002:a05:600c:1406:b0:479:13e9:3d64 with SMTP id 5b1f17b1804b1-4830514ec0amr32595905e9.15.1770131238462; Tue, 03 Feb 2026 07:07:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 23/30] target/alpha: Expand TCGv type for 64-bit target Date: Tue, 3 Feb 2026 16:04:28 +0100 Message-ID: <20260203150436.71907-24-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=philmd@linaro.org; helo=mail-wm1-x341.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131283948158500 The Alpha targets are only built as 64-bit: $ git grep TARGET_LONG_BITS configs/targets/alpha-* configs/targets/alpha-linux-user.mak:4:TARGET_LONG_BITS=3D64 configs/targets/alpha-softmmu.mak:2:TARGET_LONG_BITS=3D64 Replace: TCGv -> TCGv_i64 tcg_temp_new -> tcg_temp_new_i64 This is a mechanical replacement, adapting style to pass the checkpatch.pl script. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202234550.34156-8-philmd@linaro.org> --- target/alpha/translate.c | 228 ++++++++++++++++++++------------------- 1 file changed, 116 insertions(+), 112 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 48ac50a7cdf..4442462891e 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -65,11 +65,11 @@ struct DisasContext { int tb_ftz; =20 /* The set of registers active in the current context. */ - TCGv *ir; + TCGv_i64 *ir; =20 /* Temporaries for $31 and $f31 as source and destination. */ - TCGv zero; - TCGv sink; + TCGv_i64 zero; + TCGv_i64 sink; }; =20 #ifdef CONFIG_USER_ONLY @@ -86,21 +86,21 @@ struct DisasContext { #define DISAS_PC_STALE DISAS_TARGET_2 =20 /* global register indexes */ -static TCGv cpu_std_ir[31]; -static TCGv cpu_fir[31]; -static TCGv cpu_pc; -static TCGv cpu_lock_addr; -static TCGv cpu_lock_value; +static TCGv_i64 cpu_std_ir[31]; +static TCGv_i64 cpu_fir[31]; +static TCGv_i64 cpu_pc; +static TCGv_i64 cpu_lock_addr; +static TCGv_i64 cpu_lock_value; =20 #ifndef CONFIG_USER_ONLY -static TCGv cpu_pal_ir[31]; +static TCGv_i64 cpu_pal_ir[31]; #endif =20 void alpha_translate_init(void) { #define DEF_VAR(V) { &cpu_##V, #V, offsetof(CPUAlphaState, V) } =20 - typedef struct { TCGv *var; const char *name; int ofs; } GlobalVar; + typedef struct { TCGv_i64 *var; const char *name; int ofs; } GlobalVar; static const GlobalVar vars[] =3D { DEF_VAR(pc), DEF_VAR(lock_addr), @@ -160,7 +160,7 @@ void alpha_translate_init(void) } } =20 -static TCGv load_zero(DisasContext *ctx) +static TCGv_i64 load_zero(DisasContext *ctx) { if (!ctx->zero) { ctx->zero =3D tcg_constant_i64(0); @@ -168,10 +168,10 @@ static TCGv load_zero(DisasContext *ctx) return ctx->zero; } =20 -static TCGv dest_sink(DisasContext *ctx) +static TCGv_i64 dest_sink(DisasContext *ctx) { if (!ctx->sink) { - ctx->sink =3D tcg_temp_new(); + ctx->sink =3D tcg_temp_new_i64(); } return ctx->sink; } @@ -184,7 +184,7 @@ static void free_context_temps(DisasContext *ctx) } } =20 -static TCGv load_gpr(DisasContext *ctx, unsigned reg) +static TCGv_i64 load_gpr(DisasContext *ctx, unsigned reg) { if (likely(reg < 31)) { return ctx->ir[reg]; @@ -193,7 +193,7 @@ static TCGv load_gpr(DisasContext *ctx, unsigned reg) } } =20 -static TCGv load_gpr_lit(DisasContext *ctx, unsigned reg, +static TCGv_i64 load_gpr_lit(DisasContext *ctx, unsigned reg, uint8_t lit, bool islit) { if (islit) { @@ -205,7 +205,7 @@ static TCGv load_gpr_lit(DisasContext *ctx, unsigned re= g, } } =20 -static TCGv dest_gpr(DisasContext *ctx, unsigned reg) +static TCGv_i64 dest_gpr(DisasContext *ctx, unsigned reg) { if (likely(reg < 31)) { return ctx->ir[reg]; @@ -214,7 +214,7 @@ static TCGv dest_gpr(DisasContext *ctx, unsigned reg) } } =20 -static TCGv load_fpr(DisasContext *ctx, unsigned reg) +static TCGv_i64 load_fpr(DisasContext *ctx, unsigned reg) { if (likely(reg < 31)) { return cpu_fir[reg]; @@ -223,7 +223,7 @@ static TCGv load_fpr(DisasContext *ctx, unsigned reg) } } =20 -static TCGv dest_fpr(DisasContext *ctx, unsigned reg) +static TCGv_i64 dest_fpr(DisasContext *ctx, unsigned reg) { if (likely(reg < 31)) { return cpu_fir[reg]; @@ -243,17 +243,17 @@ static int get_flag_ofs(unsigned shift) return ofs; } =20 -static void ld_flag_byte(TCGv val, unsigned shift) +static void ld_flag_byte(TCGv_i64 val, unsigned shift) { tcg_gen_ld8u_i64(val, tcg_env, get_flag_ofs(shift)); } =20 -static void st_flag_byte(TCGv val, unsigned shift) +static void st_flag_byte(TCGv_i64 val, unsigned shift) { tcg_gen_st8_i64(val, tcg_env, get_flag_ofs(shift)); } =20 -static void gen_pc_disp(DisasContext *ctx, TCGv dest, int32_t disp) +static void gen_pc_disp(DisasContext *ctx, TCGv_i64 dest, int32_t disp) { uint64_t addr =3D ctx->base.pc_next + disp; if (ctx->pcrel) { @@ -284,38 +284,38 @@ static inline DisasJumpType gen_invalid(DisasContext = *ctx) return gen_excp(ctx, EXCP_OPCDEC, 0); } =20 -static void gen_ldf(DisasContext *ctx, TCGv dest, TCGv addr) +static void gen_ldf(DisasContext *ctx, TCGv_i64 dest, TCGv_i64 addr) { TCGv_i32 tmp32 =3D tcg_temp_new_i32(); tcg_gen_qemu_ld_i32(tmp32, addr, ctx->mem_idx, MO_LEUL | UNALIGN(ctx)); gen_helper_memory_to_f(dest, tmp32); } =20 -static void gen_ldg(DisasContext *ctx, TCGv dest, TCGv addr) +static void gen_ldg(DisasContext *ctx, TCGv_i64 dest, TCGv_i64 addr) { - TCGv tmp =3D tcg_temp_new(); + TCGv_i64 tmp =3D tcg_temp_new_i64(); tcg_gen_qemu_ld_i64(tmp, addr, ctx->mem_idx, MO_LEUQ | UNALIGN(ctx)); gen_helper_memory_to_g(dest, tmp); } =20 -static void gen_lds(DisasContext *ctx, TCGv dest, TCGv addr) +static void gen_lds(DisasContext *ctx, TCGv_i64 dest, TCGv_i64 addr) { TCGv_i32 tmp32 =3D tcg_temp_new_i32(); tcg_gen_qemu_ld_i32(tmp32, addr, ctx->mem_idx, MO_LEUL | UNALIGN(ctx)); gen_helper_memory_to_s(dest, tmp32); } =20 -static void gen_ldt(DisasContext *ctx, TCGv dest, TCGv addr) +static void gen_ldt(DisasContext *ctx, TCGv_i64 dest, TCGv_i64 addr) { tcg_gen_qemu_ld_i64(dest, addr, ctx->mem_idx, MO_LEUQ | UNALIGN(ctx)); } =20 static void gen_load_fp(DisasContext *ctx, int ra, int rb, int32_t disp16, - void (*func)(DisasContext *, TCGv, TCGv)) + void (*func)(DisasContext *, TCGv_i64, TCGv_i64)) { /* Loads to $f31 are prefetches, which we can treat as nops. */ if (likely(ra !=3D 31)) { - TCGv addr =3D tcg_temp_new(); + TCGv_i64 addr =3D tcg_temp_new_i64(); tcg_gen_addi_i64(addr, load_gpr(ctx, rb), disp16); func(ctx, cpu_fir[ra], addr); } @@ -324,7 +324,7 @@ static void gen_load_fp(DisasContext *ctx, int ra, int = rb, int32_t disp16, static void gen_load_int(DisasContext *ctx, int ra, int rb, int32_t disp16, MemOp op, bool clear, bool locked) { - TCGv addr, dest; + TCGv_i64 addr, dest; =20 /* LDQ_U with ra $31 is UNOP. Other various loads are forms of prefetches, which we can treat as nops. No worries about @@ -333,7 +333,7 @@ static void gen_load_int(DisasContext *ctx, int ra, int= rb, int32_t disp16, return; } =20 - addr =3D tcg_temp_new(); + addr =3D tcg_temp_new_i64(); tcg_gen_addi_i64(addr, load_gpr(ctx, rb), disp16); if (clear) { tcg_gen_andi_i64(addr, addr, ~0x7); @@ -350,36 +350,36 @@ static void gen_load_int(DisasContext *ctx, int ra, i= nt rb, int32_t disp16, } } =20 -static void gen_stf(DisasContext *ctx, TCGv src, TCGv addr) +static void gen_stf(DisasContext *ctx, TCGv_i64 src, TCGv_i64 addr) { TCGv_i32 tmp32 =3D tcg_temp_new_i32(); gen_helper_f_to_memory(tmp32, addr); tcg_gen_qemu_st_i32(tmp32, addr, ctx->mem_idx, MO_LEUL | UNALIGN(ctx)); } =20 -static void gen_stg(DisasContext *ctx, TCGv src, TCGv addr) +static void gen_stg(DisasContext *ctx, TCGv_i64 src, TCGv_i64 addr) { - TCGv tmp =3D tcg_temp_new(); + TCGv_i64 tmp =3D tcg_temp_new_i64(); gen_helper_g_to_memory(tmp, src); tcg_gen_qemu_st_i64(tmp, addr, ctx->mem_idx, MO_LEUQ | UNALIGN(ctx)); } =20 -static void gen_sts(DisasContext *ctx, TCGv src, TCGv addr) +static void gen_sts(DisasContext *ctx, TCGv_i64 src, TCGv_i64 addr) { TCGv_i32 tmp32 =3D tcg_temp_new_i32(); gen_helper_s_to_memory(tmp32, src); tcg_gen_qemu_st_i32(tmp32, addr, ctx->mem_idx, MO_LEUL | UNALIGN(ctx)); } =20 -static void gen_stt(DisasContext *ctx, TCGv src, TCGv addr) +static void gen_stt(DisasContext *ctx, TCGv_i64 src, TCGv_i64 addr) { tcg_gen_qemu_st_i64(src, addr, ctx->mem_idx, MO_LEUQ | UNALIGN(ctx)); } =20 static void gen_store_fp(DisasContext *ctx, int ra, int rb, int32_t disp16, - void (*func)(DisasContext *, TCGv, TCGv)) + void (*func)(DisasContext *, TCGv_i64, TCGv_i64)) { - TCGv addr =3D tcg_temp_new(); + TCGv_i64 addr =3D tcg_temp_new_i64(); tcg_gen_addi_i64(addr, load_gpr(ctx, rb), disp16); func(ctx, load_fpr(ctx, ra), addr); } @@ -387,9 +387,9 @@ static void gen_store_fp(DisasContext *ctx, int ra, int= rb, int32_t disp16, static void gen_store_int(DisasContext *ctx, int ra, int rb, int32_t disp1= 6, MemOp op, bool clear) { - TCGv addr, src; + TCGv_i64 addr, src; =20 - addr =3D tcg_temp_new(); + addr =3D tcg_temp_new_i64(); tcg_gen_addi_i64(addr, load_gpr(ctx, rb), disp16); if (clear) { tcg_gen_andi_i64(addr, addr, ~0x7); @@ -406,7 +406,7 @@ static DisasJumpType gen_store_conditional(DisasContext= *ctx, int ra, int rb, MemOp op) { TCGLabel *lab_fail, *lab_done; - TCGv addr, val; + TCGv_i64 addr, val; =20 addr =3D tcg_temp_new_i64(); tcg_gen_addi_i64(addr, load_gpr(ctx, rb), disp16); @@ -469,7 +469,8 @@ static DisasJumpType gen_bdirect(DisasContext *ctx, int= ra, int32_t disp) } =20 static DisasJumpType gen_bcond_internal(DisasContext *ctx, TCGCond cond, - TCGv cmp, uint64_t imm, int32_t di= sp) + TCGv_i64 cmp, + uint64_t imm, int32_t disp) { TCGLabel *lab_true =3D gen_new_label(); =20 @@ -616,9 +617,9 @@ static void gen_qual_flushzero(DisasContext *ctx, int f= n11) #endif } =20 -static TCGv gen_ieee_input(DisasContext *ctx, int reg, int fn11, int is_cm= p) +static TCGv_i64 gen_ieee_input(DisasContext *ctx, int reg, int fn11, int i= s_cmp) { - TCGv val; + TCGv_i64 val; =20 if (unlikely(reg =3D=3D 31)) { val =3D load_zero(ctx); @@ -674,9 +675,9 @@ static void gen_fp_exc_raise(int rc, int fn11) } } =20 -static void gen_cvtlq(TCGv vc, TCGv vb) +static void gen_cvtlq(TCGv_i64 vc, TCGv_i64 vb) { - TCGv tmp =3D tcg_temp_new(); + TCGv_i64 tmp =3D tcg_temp_new_i64(); =20 /* The arithmetic right shift here, plus the sign-extended mask below yields a sign-extended result without an explicit ext32s_i64. */ @@ -686,10 +687,10 @@ static void gen_cvtlq(TCGv vc, TCGv vb) } =20 static void gen_ieee_arith2(DisasContext *ctx, - void (*helper)(TCGv, TCGv_ptr, TCGv), + void (*helper)(TCGv_i64, TCGv_ptr, TCGv_i64), int rb, int rc, int fn11) { - TCGv vb; + TCGv_i64 vb; =20 gen_qual_roundmode(ctx, fn11); gen_qual_flushzero(ctx, fn11); @@ -713,7 +714,7 @@ IEEE_ARITH2(cvtts) =20 static void gen_cvttq(DisasContext *ctx, int rb, int rc, int fn11) { - TCGv vb, vc; + TCGv_i64 vb, vc; =20 /* No need to set flushzero, since we have an integer output. */ vb =3D gen_ieee_input(ctx, rb, fn11, 0); @@ -731,10 +732,10 @@ static void gen_cvttq(DisasContext *ctx, int rb, int = rc, int fn11) } =20 static void gen_ieee_intcvt(DisasContext *ctx, - void (*helper)(TCGv, TCGv_ptr, TCGv), + void (*helper)(TCGv_i64, TCGv_ptr, TCGv_i64), int rb, int rc, int fn11) { - TCGv vb, vc; + TCGv_i64 vb, vc; =20 gen_qual_roundmode(ctx, fn11); vb =3D load_fpr(ctx, rb); @@ -760,10 +761,11 @@ static inline void glue(gen_, name)(DisasContext *ctx= , \ IEEE_INTCVT(cvtqs) IEEE_INTCVT(cvtqt) =20 -static void gen_cpy_mask(TCGv vc, TCGv va, TCGv vb, bool inv_a, uint64_t m= ask) +static void gen_cpy_mask(TCGv_i64 vc, TCGv_i64 va, TCGv_i64 vb, + bool inv_a, uint64_t mask) { - TCGv vmask =3D tcg_constant_i64(mask); - TCGv tmp =3D tcg_temp_new_i64(); + TCGv_i64 vmask =3D tcg_constant_i64(mask); + TCGv_i64 tmp =3D tcg_temp_new_i64(); =20 if (inv_a) { tcg_gen_andc_i64(tmp, vmask, va); @@ -776,10 +778,11 @@ static void gen_cpy_mask(TCGv vc, TCGv va, TCGv vb, b= ool inv_a, uint64_t mask) } =20 static void gen_ieee_arith3(DisasContext *ctx, - void (*helper)(TCGv, TCGv_ptr, TCGv, TCGv), + void (*helper)(TCGv_i64, TCGv_ptr, + TCGv_i64, TCGv_i64), int ra, int rb, int rc, int fn11) { - TCGv va, vb, vc; + TCGv_i64 va, vb, vc; =20 gen_qual_roundmode(ctx, fn11); gen_qual_flushzero(ctx, fn11); @@ -808,10 +811,11 @@ IEEE_ARITH3(mult) IEEE_ARITH3(divt) =20 static void gen_ieee_compare(DisasContext *ctx, - void (*helper)(TCGv, TCGv_ptr, TCGv, TCGv), + void (*helper)(TCGv_i64, TCGv_ptr, + TCGv_i64, TCGv_i64), int ra, int rb, int rc, int fn11) { - TCGv va, vb, vc; + TCGv_i64 va, vb, vc; =20 va =3D gen_ieee_input(ctx, ra, fn11, 1); vb =3D gen_ieee_input(ctx, rb, fn11, 1); @@ -848,7 +852,7 @@ static inline uint64_t zapnot_mask(uint8_t lit) /* Implement zapnot with an immediate operand, which expands to some form of immediate AND. This is a basic building block in the definition of many of the other byte manipulation instructions. */ -static void gen_zapnoti(TCGv dest, TCGv src, uint8_t lit) +static void gen_zapnoti(TCGv_i64 dest, TCGv_i64 src, uint8_t lit) { switch (lit) { case 0x00: @@ -873,8 +877,8 @@ static void gen_zapnoti(TCGv dest, TCGv src, uint8_t li= t) } =20 /* EXTWH, EXTLH, EXTQH */ -static void gen_ext_h(DisasContext *ctx, TCGv vc, TCGv va, int rb, bool is= lit, - uint8_t lit, uint8_t byte_mask) +static void gen_ext_h(DisasContext *ctx, TCGv_i64 vc, TCGv_i64 va, + int rb, bool islit, uint8_t lit, uint8_t byte_mask) { if (islit) { int pos =3D (64 - lit * 8) & 0x3f; @@ -885,7 +889,7 @@ static void gen_ext_h(DisasContext *ctx, TCGv vc, TCGv = va, int rb, bool islit, tcg_gen_movi_i64(vc, 0); } } else { - TCGv tmp =3D tcg_temp_new(); + TCGv_i64 tmp =3D tcg_temp_new_i64(); tcg_gen_shli_i64(tmp, load_gpr(ctx, rb), 3); tcg_gen_neg_i64(tmp, tmp); tcg_gen_andi_i64(tmp, tmp, 0x3f); @@ -895,8 +899,8 @@ static void gen_ext_h(DisasContext *ctx, TCGv vc, TCGv = va, int rb, bool islit, } =20 /* EXTBL, EXTWL, EXTLL, EXTQL */ -static void gen_ext_l(DisasContext *ctx, TCGv vc, TCGv va, int rb, bool is= lit, - uint8_t lit, uint8_t byte_mask) +static void gen_ext_l(DisasContext *ctx, TCGv_i64 vc, TCGv_i64 va, + int rb, bool islit, uint8_t lit, uint8_t byte_mask) { if (islit) { int pos =3D (lit & 7) * 8; @@ -906,7 +910,7 @@ static void gen_ext_l(DisasContext *ctx, TCGv vc, TCGv = va, int rb, bool islit, } tcg_gen_extract_i64(vc, va, pos, len); } else { - TCGv tmp =3D tcg_temp_new(); + TCGv_i64 tmp =3D tcg_temp_new_i64(); tcg_gen_andi_i64(tmp, load_gpr(ctx, rb), 7); tcg_gen_shli_i64(tmp, tmp, 3); tcg_gen_shr_i64(vc, va, tmp); @@ -915,8 +919,8 @@ static void gen_ext_l(DisasContext *ctx, TCGv vc, TCGv = va, int rb, bool islit, } =20 /* INSWH, INSLH, INSQH */ -static void gen_ins_h(DisasContext *ctx, TCGv vc, TCGv va, int rb, bool is= lit, - uint8_t lit, uint8_t byte_mask) +static void gen_ins_h(DisasContext *ctx, TCGv_i64 vc, TCGv_i64 va, + int rb, bool islit, uint8_t lit, uint8_t byte_mask) { if (islit) { int pos =3D 64 - (lit & 7) * 8; @@ -927,8 +931,8 @@ static void gen_ins_h(DisasContext *ctx, TCGv vc, TCGv = va, int rb, bool islit, tcg_gen_movi_i64(vc, 0); } } else { - TCGv tmp =3D tcg_temp_new(); - TCGv shift =3D tcg_temp_new(); + TCGv_i64 tmp =3D tcg_temp_new_i64(); + TCGv_i64 shift =3D tcg_temp_new_i64(); =20 /* The instruction description has us left-shift the byte mask and extract bits <15:8> and apply that zap at the end. This @@ -951,8 +955,8 @@ static void gen_ins_h(DisasContext *ctx, TCGv vc, TCGv = va, int rb, bool islit, } =20 /* INSBL, INSWL, INSLL, INSQL */ -static void gen_ins_l(DisasContext *ctx, TCGv vc, TCGv va, int rb, bool is= lit, - uint8_t lit, uint8_t byte_mask) +static void gen_ins_l(DisasContext *ctx, TCGv_i64 vc, TCGv_i64 va, + int rb, bool islit, uint8_t lit, uint8_t byte_mask) { if (islit) { int pos =3D (lit & 7) * 8; @@ -962,8 +966,8 @@ static void gen_ins_l(DisasContext *ctx, TCGv vc, TCGv = va, int rb, bool islit, } tcg_gen_deposit_z_i64(vc, va, pos, len); } else { - TCGv tmp =3D tcg_temp_new(); - TCGv shift =3D tcg_temp_new(); + TCGv_i64 tmp =3D tcg_temp_new_i64(); + TCGv_i64 shift =3D tcg_temp_new_i64(); =20 /* The instruction description has us left-shift the byte mask and extract bits <15:8> and apply that zap at the end. This @@ -978,14 +982,14 @@ static void gen_ins_l(DisasContext *ctx, TCGv vc, TCG= v va, int rb, bool islit, } =20 /* MSKWH, MSKLH, MSKQH */ -static void gen_msk_h(DisasContext *ctx, TCGv vc, TCGv va, int rb, bool is= lit, - uint8_t lit, uint8_t byte_mask) +static void gen_msk_h(DisasContext *ctx, TCGv_i64 vc, TCGv_i64 va, + int rb, bool islit, uint8_t lit, uint8_t byte_mask) { if (islit) { gen_zapnoti(vc, va, ~((byte_mask << (lit & 7)) >> 8)); } else { - TCGv shift =3D tcg_temp_new(); - TCGv mask =3D tcg_temp_new(); + TCGv_i64 shift =3D tcg_temp_new_i64(); + TCGv_i64 mask =3D tcg_temp_new_i64(); =20 /* The instruction description is as above, where the byte_mask is shifted left, and then we extract bits <15:8>. This can be @@ -1008,14 +1012,14 @@ static void gen_msk_h(DisasContext *ctx, TCGv vc, T= CGv va, int rb, bool islit, } =20 /* MSKBL, MSKWL, MSKLL, MSKQL */ -static void gen_msk_l(DisasContext *ctx, TCGv vc, TCGv va, int rb, bool is= lit, - uint8_t lit, uint8_t byte_mask) +static void gen_msk_l(DisasContext *ctx, TCGv_i64 vc, TCGv_i64 va, + int rb, bool islit, uint8_t lit, uint8_t byte_mask) { if (islit) { gen_zapnoti(vc, va, ~(byte_mask << (lit & 7))); } else { - TCGv shift =3D tcg_temp_new(); - TCGv mask =3D tcg_temp_new(); + TCGv_i64 shift =3D tcg_temp_new_i64(); + TCGv_i64 mask =3D tcg_temp_new_i64(); =20 tcg_gen_andi_i64(shift, load_gpr(ctx, rb), 7); tcg_gen_shli_i64(shift, shift, 3); @@ -1100,7 +1104,7 @@ static DisasJumpType gen_call_pal(DisasContext *ctx, = int palcode) =20 /* But make sure and store only the 3 IPL bits from the user. = */ { - TCGv tmp =3D tcg_temp_new(); + TCGv_i64 tmp =3D tcg_temp_new_i64(); tcg_gen_andi_i64(tmp, ctx->ir[IR_A0], PS_INT_MASK); st_flag_byte(tmp, ENV_FLAG_PS_SHIFT); } @@ -1151,7 +1155,7 @@ static DisasJumpType gen_call_pal(DisasContext *ctx, = int palcode) return gen_excp(ctx, EXCP_CALL_PAL, palcode); #else { - TCGv tmp =3D tcg_temp_new(); + TCGv_i64 tmp =3D tcg_temp_new_i64(); =20 gen_pc_disp(ctx, tmp, 0); if (ctx->tbflags & ENV_FLAG_PAL_MODE) { @@ -1199,9 +1203,9 @@ static int cpu_pr_data(int pr) return 0; } =20 -static DisasJumpType gen_mfpr(DisasContext *ctx, TCGv va, int regno) +static DisasJumpType gen_mfpr(DisasContext *ctx, TCGv_i64 va, int regno) { - void (*helper)(TCGv); + void (*helper)(TCGv_i64); int data; =20 switch (regno) { @@ -1249,7 +1253,7 @@ static DisasJumpType gen_mfpr(DisasContext *ctx, TCGv= va, int regno) return DISAS_NEXT; } =20 -static DisasJumpType gen_mtpr(DisasContext *ctx, TCGv vb, int regno) +static DisasJumpType gen_mtpr(DisasContext *ctx, TCGv_i64 vb, int regno) { int data; DisasJumpType ret =3D DISAS_NEXT; @@ -1361,7 +1365,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) uint16_t fn11; uint8_t opc, ra, rb, rc, fpfn, fn7, lit; bool islit, real_islit; - TCGv va, vb, vc, tmp, tmp2; + TCGv_i64 va, vb, vc, tmp, tmp2; TCGv_i32 t32; DisasJumpType ret; =20 @@ -1484,7 +1488,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) break; case 0x02: /* S4ADDL */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_shli_i64(tmp, va, 2); tcg_gen_add_i64(tmp, tmp, vb); tcg_gen_ext32s_i64(vc, tmp); @@ -1496,7 +1500,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) break; case 0x0B: /* S4SUBL */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_shli_i64(tmp, va, 2); tcg_gen_sub_i64(tmp, tmp, vb); tcg_gen_ext32s_i64(vc, tmp); @@ -1512,14 +1516,14 @@ static DisasJumpType translate_one(DisasContext *ct= x, uint32_t insn) break; case 0x12: /* S8ADDL */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_shli_i64(tmp, va, 3); tcg_gen_add_i64(tmp, tmp, vb); tcg_gen_ext32s_i64(vc, tmp); break; case 0x1B: /* S8SUBL */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_shli_i64(tmp, va, 3); tcg_gen_sub_i64(tmp, tmp, vb); tcg_gen_ext32s_i64(vc, tmp); @@ -1534,7 +1538,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) break; case 0x22: /* S4ADDQ */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_shli_i64(tmp, va, 2); tcg_gen_add_i64(vc, tmp, vb); break; @@ -1544,7 +1548,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) break; case 0x2B: /* S4SUBQ */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_shli_i64(tmp, va, 2); tcg_gen_sub_i64(vc, tmp, vb); break; @@ -1554,13 +1558,13 @@ static DisasJumpType translate_one(DisasContext *ct= x, uint32_t insn) break; case 0x32: /* S8ADDQ */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_shli_i64(tmp, va, 3); tcg_gen_add_i64(vc, tmp, vb); break; case 0x3B: /* S8SUBQ */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_shli_i64(tmp, va, 3); tcg_gen_sub_i64(vc, tmp, vb); break; @@ -1570,7 +1574,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) break; case 0x40: /* ADDL/V */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_ext32s_i64(tmp, va); tcg_gen_ext32s_i64(vc, vb); tcg_gen_add_i64(tmp, tmp, vc); @@ -1579,7 +1583,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) break; case 0x49: /* SUBL/V */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_ext32s_i64(tmp, va); tcg_gen_ext32s_i64(vc, vb); tcg_gen_sub_i64(tmp, tmp, vc); @@ -1592,8 +1596,8 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) break; case 0x60: /* ADDQ/V */ - tmp =3D tcg_temp_new(); - tmp2 =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); + tmp2 =3D tcg_temp_new_i64(); tcg_gen_eqv_i64(tmp, va, vb); tcg_gen_mov_i64(tmp2, va); tcg_gen_add_i64(vc, va, vb); @@ -1605,8 +1609,8 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) break; case 0x69: /* SUBQ/V */ - tmp =3D tcg_temp_new(); - tmp2 =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); + tmp2 =3D tcg_temp_new_i64(); tcg_gen_xor_i64(tmp, va, vb); tcg_gen_mov_i64(tmp2, va); tcg_gen_sub_i64(vc, va, vb); @@ -1798,7 +1802,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) if (islit) { tcg_gen_shri_i64(vc, va, lit & 0x3f); } else { - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); vb =3D load_gpr(ctx, rb); tcg_gen_andi_i64(tmp, vb, 0x3f); tcg_gen_shr_i64(vc, va, tmp); @@ -1813,7 +1817,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) if (islit) { tcg_gen_shli_i64(vc, va, lit & 0x3f); } else { - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); vb =3D load_gpr(ctx, rb); tcg_gen_andi_i64(tmp, vb, 0x3f); tcg_gen_shl_i64(vc, va, tmp); @@ -1828,7 +1832,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) if (islit) { tcg_gen_sari_i64(vc, va, lit & 0x3f); } else { - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); vb =3D load_gpr(ctx, rb); tcg_gen_andi_i64(tmp, vb, 0x3f); tcg_gen_sar_i64(vc, va, tmp); @@ -1891,12 +1895,12 @@ static DisasJumpType translate_one(DisasContext *ct= x, uint32_t insn) break; case 0x30: /* UMULH */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_mulu2_i64(tmp, vc, va, vb); break; case 0x40: /* MULL/V */ - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_ext32s_i64(tmp, va); tcg_gen_ext32s_i64(vc, vb); tcg_gen_mul_i64(tmp, tmp, vc); @@ -1905,8 +1909,8 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) break; case 0x60: /* MULQ/V */ - tmp =3D tcg_temp_new(); - tmp2 =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); + tmp2 =3D tcg_temp_new_i64(); tcg_gen_muls2_i64(vc, tmp, va, vb); tcg_gen_sari_i64(tmp2, vc, 63); gen_helper_check_overflow(tcg_env, tmp, tmp2); @@ -2351,7 +2355,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) prediction stack action, which of course we don't implement. */ vb =3D load_gpr(ctx, rb); if (ra !=3D 31) { - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_andi_i64(tmp, vb, ~3); gen_pc_disp(ctx, ctx->ir[ra], 0); tcg_gen_mov_i64(cpu_pc, tmp); @@ -2366,7 +2370,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) #ifndef CONFIG_USER_ONLY REQUIRE_TB_FLAG(ENV_FLAG_PAL_MODE); { - TCGv addr =3D tcg_temp_new(); + TCGv_i64 addr =3D tcg_temp_new_i64(); vb =3D load_gpr(ctx, rb); va =3D dest_gpr(ctx, ra); =20 @@ -2615,7 +2619,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) } tcg_gen_movi_i64(cpu_lock_addr, -1); st_flag_byte(load_zero(ctx), ENV_FLAG_RX_SHIFT); - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_andi_i64(tmp, vb, 1); st_flag_byte(tmp, ENV_FLAG_PAL_SHIFT); tcg_gen_andi_i64(cpu_pc, vb, ~3); @@ -2636,7 +2640,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) /* Longword physical access */ va =3D load_gpr(ctx, ra); vb =3D load_gpr(ctx, rb); - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_addi_i64(tmp, vb, disp12); tcg_gen_qemu_st_i64(va, tmp, MMU_PHYS_IDX, MO_LESL | MO_AL= IGN); break; @@ -2644,7 +2648,7 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) /* Quadword physical access */ va =3D load_gpr(ctx, ra); vb =3D load_gpr(ctx, rb); - tmp =3D tcg_temp_new(); + tmp =3D tcg_temp_new_i64(); tcg_gen_addi_i64(tmp, vb, disp12); tcg_gen_qemu_st_i64(va, tmp, MMU_PHYS_IDX, MO_LEUQ | MO_AL= IGN); break; --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131258; cv=none; d=zohomail.com; s=zohoarc; b=gTM6RGAYVSjP5dl6viIyLRjww/ZpjHoVAYcg7Z6MeDDlGMzCz+ZnmyaoASwJH+m9wpJ/BBholJNgfrDZSkEUx2oReuJ/A0k5BvxiKWrG42CMbJcQWUOg0RYUIzISrUqEXn5Hma4MgpHrTxSe5kxm/hzq4jyKltpulMYfB80W+94= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131258; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=X5Z2duohm6FpVj961qM5fTcwUMs49OrZr5pUH6kFnME=; b=hWNGsdYaCVQKQ1VrGvb0z0kLNeOVedbAgmlkxTBY2UWbbEUIQXd+xX+Ap6ewOiTXY42GCMultS8ApEHZ67n1IXPmtx5sBNU2wVLqDqxLamwUvh1X/uJsC8/SneSopb1l6/jH+TIiNLTXTB1OQUFVpRsLujIGi5TxHP9KDDv2heU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131258813956.9450309431412; Tue, 3 Feb 2026 07:07:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnI02-0007yW-Aw; Tue, 03 Feb 2026 10:07:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnI00-0007w1-AY for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:28 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnHzy-0002R4-QL for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:28 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-48069a48629so59560085e9.0 for ; Tue, 03 Feb 2026 07:07:26 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483051287cfsm110145175e9.6.2026.02.03.07.07.24 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131245; x=1770736045; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=X5Z2duohm6FpVj961qM5fTcwUMs49OrZr5pUH6kFnME=; b=XwsXCnsZ+J12HWwIMbHlcBZJ5QhgEwkDPubvQz0oCClQ7/GDemNc/jUFFRibA5Wtyx YglT8aeONlYqqerywOSBeBHeoCwrVTjt3gAUa1ukzQDI/hSOaD1mB6EbK1qw6y4bE92Y d29/WMJmlZMYEuRvNqcHRAJs4FFFEbZGnq4nDFYZtY1UP3Y1/UuLp6AYq1YCJfBJIgf/ PhMdqmdBvQ3U6jNDJgK6B99fsOM59iC8EXLF+zZVRFD1QJ/74XOE0RocaKpap9Oj3csk A7rr27t9/rXE2WNVO1YZxibeYFmmy83Gk/inuo/NdfmGUyqtqEO/AbeTBHyKzR2uYcpQ WOUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131245; x=1770736045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=X5Z2duohm6FpVj961qM5fTcwUMs49OrZr5pUH6kFnME=; b=m1pM7UTI/YqLlVNyjWMSz8Wb46FdtjSTBDQdBmylNiWBBFqx39m1fU9bp+rUlSIp7X AhLDrRyh3zkguBOEFxwZDzCWNILgMC6q4Op1kaiAtLcPC4+2KUANiVdGACcoEIMJUZ3A 9rapIMXLCsdPfQxEiYA2RPmgMsvdHOn2bHagVYgpM8gKcdQkr4u60EpYriKQl29zSbXw dDt2q2gwuzv0BEX+5Hr0uIAKjTZKqvbCu5Rdb0WKvxIlCmWS6UlV8awUdZVq4k7rs1u3 M8e235V5ZXJTTcx6OAIhDDSrFiN1yq+nEkqvLOWE8Mul0r7ipvzfrplvsS3Zv5ijhCPS YVYw== X-Gm-Message-State: AOJu0YzmACM5eL/tmsbi2Fg1pXQevQCviO7A6BIsnHRmH97myAjk96Qw rVfAl6SLfld5+pZuO/o3qY2vnNSkliVMfMYuCl1wd8o0Y9alVO2NRVwkjbfoWeue8akRXM08KQV qdczkNOE= X-Gm-Gg: AZuq6aIn27P7j/+f05ymjEAFtr3COsILGsvuOURXFyVs+ofLiBtem7BPkO5eyFXaVdG alcxv2hAdp6yaBHbuKKFPTl2aHJO3hwa1525n//xK7+QFCVxgx9hEJAwTXtFm5dNWRp/naUnkoC mBLO37cATGBdO77LS9eFGKSF3BhXcC6ULXGTb5Z4f0bWn3RdkHKjN5BFRICt9bUH1z87GZl/D5+ 0P7v0fWKvsHOXBTaD7M5/4ei5cjAOwdMSJFKn85gYxHhvUJXZuEXnJ+7inSKDtrg64ZmVJ5e97E hyLGSwe/dpVTyiim6cOC1Io6DDjH/JphG4MT88jF5QQUCWUcxdEVoM+sFznKqFhzeq4bh06R8Yh dKtzn1J/89Ny/ZeI8xzhuP41GI4z0eFFh6rzsvy2SLEDY5hWjzSh9BnvW8o6exIwZO6+h5/WL/A XCNq0f92ICWYWSezAGRFivBHf+GSOfFXb8jo6IWnh7vUbq8comkq+Pk7LAvJxe X-Received: by 2002:a05:600c:1385:b0:480:3b4e:41b8 with SMTP id 5b1f17b1804b1-482db497d9bmr199801495e9.33.1770131245013; Tue, 03 Feb 2026 07:07:25 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 24/30] target/arm: Have arm_feature() take a const @env argument Date: Tue, 3 Feb 2026 16:04:29 +0100 Message-ID: <20260203150436.71907-25-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131260220154100 arm_feature() only access @env read-only, make it const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202222412.24923-2-philmd@linaro.org> --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 21fee5e840b..d4a146b4202 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -2140,7 +2140,7 @@ enum arm_features { ARM_FEATURE_BACKCOMPAT_CNTFRQ, /* 62.5MHz timer default */ }; =20 -static inline int arm_feature(CPUARMState *env, int feature) +static inline int arm_feature(const CPUARMState *env, int feature) { return (env->features & (1ULL << feature)) !=3D 0; } --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131278; cv=none; d=zohomail.com; s=zohoarc; b=TBLpdNC2zya1fDA97BYnXq1hodIKTa5eg8bfZvjZIBtDvAnSOQ1mR6SJiGnXyNpa+oVqB38GML/CxNqSR+Vl7ouQRr+Go769oL5KjZpJG+i86W+TRRFyWKwU1zjL0JGZYM6aIUbd0sROoPltI7388wCMBbTCaDBcN5IqSYCeDmw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131278; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=jGqTvkEMHveJWI/zuGw9XswRbOgb7CrfuDpUK6fNXzI=; b=mGgWvvIfoqLCLav7EoWJxbisksixOHT/eNqKInH4Wooz+pDTE4kFrkFnd5QSRvxoP9Cu/7ZgPkBwIr5QzeH39jPDubwtsXsOOXFx1MVq08+kDtB29SdGsLvZpMnOTZhj4S8G16mc23OZlbNWg+fiaDu1DL8Mt8CVBSfRynphuSs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131278301185.10015144801878; Tue, 3 Feb 2026 07:07:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnI0C-0000ML-2r; Tue, 03 Feb 2026 10:07:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnI07-0008TE-FF for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:36 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnI05-0002RF-RU for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:35 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-47edd6111b4so61145135e9.1 for ; Tue, 03 Feb 2026 07:07:33 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4830512e0edsm73669135e9.7.2026.02.03.07.07.30 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131252; x=1770736052; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=jGqTvkEMHveJWI/zuGw9XswRbOgb7CrfuDpUK6fNXzI=; b=OQbYSHFjW3U/ZumSfgSUw0NAht/lEuEg+PxDk5wmpLspjUnleazvAdA/9SHsSjY32R VNkY9LyYb+0mvaM71AeT5e+BKcfS0iamvclM0dg1p8p+ileY9rJqv/QsPfAP2T//rTcH 8NsAkDj1vHOnQG2Fn9RZc5GgKwNlaBUrWVKXmMBEDgin/HPS8KRi35UmSJ0A8W/uLkS5 JJ9w82RoTRx3Axb25DJiLGY4cAxj3LQjnJYj3g18X+D/vul8u+efWQMhgpSvR7D99Fu6 s+Pxkh/QuZBd11/DApMdDYZrTF9B+m3ioHFOkja0UnlUDUCtvyKsuLG1/Qhwidmz0n4+ EeHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131252; x=1770736052; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jGqTvkEMHveJWI/zuGw9XswRbOgb7CrfuDpUK6fNXzI=; b=iiC6LFhO2vURWRUGTiryPiJhrxH/C7QDtlK49PG4rtNV4bv9pwj7zjIUuEfN2X2S+6 Y6cyLDkt0hr/D2uavvPRfOKe8+uLWA4sYVkpC/Ivtolq2jBGvi4Ex1Lc/bP9WdD+xHla jjVCu8TqygLyUomZLmPs5R2HIeMOyfmBSdPCJfReoVGLohQRnewPf2hhC5/qvoT/ONxf 5cXIdBI8BKoNGjQn6HzWAWNOXYvavjLRwBmG9qwv43fR8PR/fqvGcN1FwaD0uVeXl4QD mQvIblkzOVm8rVUBmVITPSXByRg5yKvsHQBQQK2jeXq55SRsH1THBzEpi9zi4rq/O3S8 1gOQ== X-Gm-Message-State: AOJu0YwxJbkMpHcwzIXld9eGGkYfTk3L4nnOHnf14zhHO0O4FAVmxT++ SwsVOrPP9Xxqgleeyora573NoAK3jECB8as3kyDoTgcfgAhJbLh4ue6I1wbXcR/IKE2oHigFGd9 RqHZXwxQ= X-Gm-Gg: AZuq6aKPMrObwyiFIyWSp/OvpNEyPlWMuB2RJAzuPbbKX/gMy2/DdXooWTW782LTP7A GeWRweqEwVDyNG+wpEqAWTv0mX33QSkoNkxJJP/018/t2Qrgo1fydBqrdN+VDTyVSn3PNmx7/FY nwxK5qejrLXAQK/LvcN0Xcpth8kZdkwJltCVan1NEDMHp1qEzyabCY+li+XafkfwKbg471RIuhn pXBUr9a1xsfKdguzXBcDtw2pa6JVOmzILI4GscEYaf2N1oAzl0yCgGRUFKYPn8ra3R+DzV68WuX OQgA50vUYRYmiPHe24bClgJsYkrm1foxfSCh2fF61jZvdZXioz/Cu8wTJzXoRMOCR0yJbo6AY0M 1CwwtdQ/2U7n5bX2iyw/3Nznoo1CEk5tV/NJ4hmbft0D2wSTWerzivWZ2OWqS4l0GJbPlaX9DXx jeMRyruQhHVgs66ZM84UpkkmF5VnFnxTnJ8oYdCElHf329T9jHwAZDmdX+pxbC X-Received: by 2002:a05:600c:8b12:b0:47d:5e02:14e5 with SMTP id 5b1f17b1804b1-482db44e7f7mr203730775e9.5.1770131251833; Tue, 03 Feb 2026 07:07:31 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 25/30] target/arm: Have cpu_isar_feature() use a const ARMCPU object Date: Tue, 3 Feb 2026 16:04:30 +0100 Message-ID: <20260203150436.71907-26-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131280470154100 The @cpu_ variable is only accessed read-only, make it const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202222412.24923-3-philmd@linaro.org> --- target/arm/cpu-features.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h index a7ca410dcb4..f7b14373407 100644 --- a/target/arm/cpu-features.h +++ b/target/arm/cpu-features.h @@ -1643,6 +1643,6 @@ static inline uint64_t make_ccsidr(CCSIDRFormat forma= t, unsigned assoc, * Forward to the above feature tests given an ARMCPU pointer. */ #define cpu_isar_feature(name, cpu) \ - ({ ARMCPU *cpu_ =3D (cpu); isar_feature_##name(&cpu_->isar); }) + ({ const ARMCPU *cpu_ =3D (cpu); isar_feature_##name(&cpu_->isar); }) =20 #endif --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131271; cv=none; d=zohomail.com; s=zohoarc; b=MghdT2aghYVmB5RfL9b0TywExPqh+Ey5YAhM5C4FSG/qWHc1J9fnbEzpNzlXrH765DqqASMaBHHv1TPvct/cK7lMzss0v0y5lQHzmG8so1XBEiuUiYBSSXpDW2DQyU92DqsNeKlxVtpbrky2fr1q9wz+46Hvnf8CE8wxGxxlpBU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131271; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=IIzLo099sN0zLD6WkV6sS2hjdaNXBnyFWYmlkZWjZxc=; b=Zh1i4bQVJjfZA/J6/ubmT6my5QLrmi/fAeJ+RoCNMYqEBX6n9r7v8dTUmBcVM/z+GoFcP+vkKLa6uU15ZQh+cY0M1be+5rGmKxWdF4H/i9jj2q37e2mUdph7p9D5gX4mit69olabLFGKXTPywIejUBrnsPaFD9fQ717nKYhoX4I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131271089277.2364254581297; Tue, 3 Feb 2026 07:07:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnI0G-0000S0-9v; Tue, 03 Feb 2026 10:07:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnI0E-0000Rh-QU for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:42 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnI0C-0002S3-VN for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:42 -0500 Received: by mail-wm1-x341.google.com with SMTP id 5b1f17b1804b1-4801bc32725so44396565e9.0 for ; Tue, 03 Feb 2026 07:07:40 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48305153842sm73705515e9.10.2026.02.03.07.07.37 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:07:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131259; x=1770736059; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=IIzLo099sN0zLD6WkV6sS2hjdaNXBnyFWYmlkZWjZxc=; b=pfJL6xAA56I01iC9Pk0jJMUD7iFDyVg2Z7ZpgdpbO8dzToOSyhPPsnniWjXLz3BoHb YrqN72zpbs169kAv5onfgko7+1hd7Ubdm4F0m9R2Gl3UrRUcN4dKjfM8WFoW6AO2iLU7 9U6MF/EQKcMtnRhcF4LpEN9hDo+Rp2eQbEPrtS8ip25uOrDFvAJtpVkYoa52Pk/HY+Tj zoNAzTp2qJ9FOj14HK75lquyCVf6HSN+MPuKpowxkmc0P3P+YYEwimajzxWDlOfp+MGO fATNqzBTj25d6oRrS1X7oaGlN0TS6UdJNsJgpyEQwuSihzmGAG++a98G5ygi56Rd87qf Uppw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131259; x=1770736059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IIzLo099sN0zLD6WkV6sS2hjdaNXBnyFWYmlkZWjZxc=; b=lTsMIVzoL8QhioU1ODA5RRxGY2Ew6vSoPrBKDFaiAdR+Y+t2Cmf+TwV/mukAMnzMBg bzKqaZidbb9ng+0fR3PuqzU6+8lKAl6V7L8Y5Z5WLb0TsO73ZlTNnzMxSA80Gx+D3raN oAPdqjrrAWUwWOZgtETewkhEEQegAZVevi047sCl4a6cHhVIQqApFSauahWc9N03WGbU bT4FnC7ImTdZwmjHmder1BF6jrNbwchwyG54XdYwIFQvGZhqL7/RzMFyvA6RtFyQGMFJ 69//eBKkdJSXqb0d21i6ypSOffWW4A+7TydVLXPIy6QD4lSD2vZMIXsMMkx+JMf9bUyx l0jw== X-Gm-Message-State: AOJu0YwO/sxioyV0+EGr18JZxYkaSUfW9IYmFRhW2knE8MeJEcn9FH7H 9xzJ8kEz4JLTMQ5FCxNNyn6LzaQPdUT4y7vhH4jdJoBhpEWscY3riwUnx7NCjTRdkDACdKhy5G3 OdZA2SQM= X-Gm-Gg: AZuq6aIxp+wxse9ujyyrKEOLNjYEPF/0TRxbERKtvaazVa0UiogWAOk/j5nt55pyHtL egeJEjdfMUm2mnn9WHu991XC+t/Vg3UjGGjT1Wzoi302gef/Z3khv4OD4u3UXJhXrp77wZQSPa/ Oyf/mwIWO6v2k+iNpK69Z5MjZypehUbw0DAyLKsatkXTqsy9PlmYXW3w4lefT9ChbZvBoPkhIrF 4ZnXWMOgdv6me6pJl2nz4XnCIPIU5gOzN8AKa3l4es+Dca1g0DpNR8nvZ7BGcuSBKMeMD6JrG0h yORATGYSWG0QmBE2KEAXhAuhzthqc4PsdNJdX/FjV3gHVgRx3LI77NKRBd7qcAQ/Z+5AOE7TkE0 ldaUPlcqlYsqvmMMBnWExsRqTUiey+U2zdZs4PuIW+CJKq4AfeWPuubSijl5XYLAiKjdPFDFfTq lsgUfJrtQ5iUtoLJnR4ssZJ04U6quceODqGTiCsmH66VCL4Ee838Em9Qe5dryd X-Received: by 2002:a05:600c:3ba3:b0:46e:4586:57e4 with SMTP id 5b1f17b1804b1-482db49228cmr243053595e9.24.1770131258652; Tue, 03 Feb 2026 07:07:38 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 26/30] target/arm: Have is_64() take a const @env argument Date: Tue, 3 Feb 2026 16:04:31 +0100 Message-ID: <20260203150436.71907-27-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=philmd@linaro.org; helo=mail-wm1-x341.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131272367154100 is_64() only access @env read-only, make it const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202222412.24923-4-philmd@linaro.org> --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index d4a146b4202..40237168419 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1345,7 +1345,7 @@ uint32_t sve_vqm1_for_el_sm(CPUARMState *env, int el,= bool sm); /* Likewise, but using @sm =3D PSTATE.SM. */ uint32_t sve_vqm1_for_el(CPUARMState *env, int el); =20 -static inline bool is_a64(CPUARMState *env) +static inline bool is_a64(const CPUARMState *env) { return env->aarch64; } --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131295; cv=none; d=zohomail.com; s=zohoarc; b=VBP2VE6DvLh+xCSUzyjXwsD3zVYA4nto3pq40LqBELEirGoV5ZVZ+VFmka5ASDQshwrV0ubbvHhLiTorRYFXqOJeEwDwB+nDqDNHSsjg4QvJjxYEntBI/t6E1de7K3tJoeL1VU2XjBpHWJQa9oGyHUbSnURqsaZs8DTX22Nuf6w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131295; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=nc0B+uW3ETyKEu5nC1EKxxR26qikxyzqNn3rfro40aA=; b=RC5ff2ZbwbZm4OJ2kQ0KxBYDO0on9JqM4Sh0V9mz63x07AZ7AtZ5M5SLhzxGgBr/x80oUMb7iKvb8rZBGxSTQx/Z1O9VcR174H9/u6O+OoGiHu1lOa9+EeyDtVHLFvKvYwZk5hVV0dWXtRxQd4CzVe00RU0sqp7aJdkDXxxJ50k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131295693391.9313583888785; Tue, 3 Feb 2026 07:08:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnI0R-0000yA-63; Tue, 03 Feb 2026 10:07:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnI0N-0000ll-BZ for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:51 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnI0J-0002T5-D9 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:49 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4801bc32725so44397425e9.0 for ; Tue, 03 Feb 2026 07:07:47 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482e256482esm119389345e9.12.2026.02.03.07.07.44 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:07:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131266; x=1770736066; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=nc0B+uW3ETyKEu5nC1EKxxR26qikxyzqNn3rfro40aA=; b=NrI53almzVsK0yBgzYbpia9O6NPWyLM5B8yqbcodMNu3cv0DPrQuFl30bNdCjbSHqA 12nw3bp50DobvbdqHN1kdNazG9JUeUduL+BIeIJ6CjvERwNMTyuJrCdlBSvgidRdSd3C t6nuwL/jT5z8+SSPPBZOJDTBgvre3dWYJ/GAMSelf6NK6X8yXMQxTuIDWBR7A5i2owYL Iri2uRWyPrwDtS4raaszjTNU137lfAzfPiB4yHlx43RTphxFC23MTpjUp8tftpSGbsnu AI+6XMYwCzdfZ2OzOBW2qOt5DmMO6SGCbL+6FEhLwhtHDadgEOaLz186MevtIv9LFeL0 Fmvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131266; x=1770736066; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nc0B+uW3ETyKEu5nC1EKxxR26qikxyzqNn3rfro40aA=; b=hvCbDASP8T5YWEF1pr7PKecSb401G5nVKAT7SlRrRElmJSY1BF+upP+q5PGyxie3H/ s/fd4RXJ8l3uPPfNdtI3Hh8VFBAsGOqq3uOXqCHrv0K/ziiXL5pBozFcfuIzTOmGavug hdm+6FKN8c77aOZR8zLcU65KLckNTbCZN//owKFRKHVNXFcLq07ibWlCdxpsHvBwVxbT k0NLOLEQBlq4GNomNTTBdPP+iZrT5glbhBWRDKXqludvbz4f5j7d6ndR6vqZ97kb/v3S Q4J1DB6cijsfKtgPBjljWDidwtqCXQfM5BTmkTgKVEvMJYQX4hT3inLHWOKVYJZ0Qwdn lKVw== X-Gm-Message-State: AOJu0YwE9Rgk8Ews1W6JyCLFj8CzqGKkdAwkTRotTMTYRLM4IP950k0b Pg1IcXPrg1gIbOrXFXD0qhqbFcAZ7mZ0QvhosjOIfN2IIwfN43lsY7JvFVTdjnNjer7rPAo/j6q e+L6KbbM= X-Gm-Gg: AZuq6aJc1onykh9mo0FC1PVTfmQOOQ0nbyb+KxzzhTyxtDA55BZaVyNJyx/Y6iVhPxl Hl/GW04p7C5TcbaUWNG9QPRsfJ0AFPClp7e8CrnWl0olaIlfL5JXPSjwIHdMuajclbJ8DJBQPZp hA0qaMxhrHqDUp1Eu6476qQTqHkWY1oBKRVOEOqVG2V0r778Vh0AIHrFbFuwxC1VRv6m6jKXMf2 XSOvR2ejb15AAZOIjhBmb6WLZ4OloU03wDSJ1snxYwCvfON5xVlD113Dud9uJ2SyQ7J5/5rlEBm O/IFWT6c2zENDEfJs3tLnwTktDBOZzwV2RjP/Vk3dCQwu5CQjmhtYHAzwkohaAyOhQx24IMqc7I qoKSmP8s9xqHnbxq+ETCCqztWTbu0dzetL7K51UTa/YXjmQ2EqTtV8rG0r4mShIwWvW/D/p+7hF 5ugCIm9DawWA5F2SKAgYazQ9OBjPaDfEMTi8ACZyA6zM2LkqAnT2UL1XkBCicN X-Received: by 2002:a05:600c:680a:b0:47e:e20e:bbb0 with SMTP id 5b1f17b1804b1-482db452201mr235159165e9.6.1770131265565; Tue, 03 Feb 2026 07:07:45 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 27/30] target/arm: Have arm_sctlr_b() take a const @env argument Date: Tue, 3 Feb 2026 16:04:32 +0100 Message-ID: <20260203150436.71907-28-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131298739154100 arm_sctlr_b() only access @env read-only, make it const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202222412.24923-5-philmd@linaro.org> --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 40237168419..e146f7e6c41 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -2385,7 +2385,7 @@ static inline bool arm_v7m_csselr_razwi(ARMCPU *cpu) return (GET_IDREG(&cpu->isar, CLIDR) & R_V7M_CLIDR_CTYPE_ALL_MASK) != =3D 0; } =20 -static inline bool arm_sctlr_b(CPUARMState *env) +static inline bool arm_sctlr_b(const CPUARMState *env) { return /* We need not implement SCTLR.ITD in user-mode emulation, so --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131296; cv=none; d=zohomail.com; s=zohoarc; b=SjS1H5WrjL8WTkNv1rrQFUh3STmsG/Slt93iZygyeFU7ySbH8bAfdkqgih1VZBDauuziRf9HpzMaBeTN0ciRaKLrub4JRWmgqLVejvYnvo3YdDvow02/MoWuj7nvP3bXbdheTz2ZaDizEP/tEO1q2/+f89+yJMiEKHanV7XNrX0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131296; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=I1D+oGV5u690BAY34zejmMpSYej+AEt8IrxwvBH9z7Q=; b=aBBuKNDP7gZl2YsE2iDfFVZN59wpNDZc1yfmO7hj26vtdpFOo2osi9xwIjh2/nARdg0LmhDVwvkOHSJ2SXKcvqMd9uZYDp7lTso57Sy1WJdlNTxBIS6lauoqwhhv+BoWzLTjOpK2/kZpWBU8uE9QbHGaeIJYsStq64UNv6wwEc8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131296357117.58319314428445; Tue, 3 Feb 2026 07:08:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnI0W-0001f1-B1; Tue, 03 Feb 2026 10:08:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnI0U-0001Mk-1X for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:58 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnI0R-0002Vz-Hw for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:07:57 -0500 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4806fbc6bf3so61255345e9.2 for ; Tue, 03 Feb 2026 07:07:55 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482dbd21f5dsm142638365e9.8.2026.02.03.07.07.51 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131274; x=1770736074; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=I1D+oGV5u690BAY34zejmMpSYej+AEt8IrxwvBH9z7Q=; b=Mc43ILZKKgimogaQJIdY/h+ann1fVkKzKx+VYek14l7dXCkMIhlhv4x3s9UJIhx0jh OV5abW/f05nN6VxUpBuLsPF1ef0ZvMlwGHMNHOlwbHDb1fjOGGBSiBGAAVgBwdubhi5y ND66Fmf3Y42O8XJej5RnRVwi0SGxRo6HdKOtOLB5q8hv2gdjDjXLc3MAlQTtH2AMFtC3 q6HRCodF9mf9VkLThD4eFxRaRSyD2mGFfz4pcwj7tA4GyLy9PWQ0t8B1twYWvbciN5rN SSjnAHUhf2GqqygmTp8jCvYTeyihxEapaF/2vJGiRgN0pjxtKUv9FfGHYxHgC3MC/c+7 +EYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131274; x=1770736074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=I1D+oGV5u690BAY34zejmMpSYej+AEt8IrxwvBH9z7Q=; b=h1GNNzFBd3poD/oIG9R0HT4Fx1+rk2rmf6sspkNvAJLdx/l4kzd2oRTcGtXQLK96mU EkwWzWjtLD+rFt0OVD7s+wRiIQFbzQ5ra0r5MhDsdEeroIWOV2llUNL7YYhEUvL2442O MEjpxd4xgLtTW9M4HoK2RLbojP5MH5jJeXgLk8YVOWQyiyhTuDCFDOcUWhbi09LoJZpG VIHwH4bePctcTDY1vgzf1FqePFGeYQPhLrbbCAdA7pUzMTAJVVJsZ+GdGpzczS0noiFW NXlZn3X3T+G4mw6jtHCQaB9pJ0vh//XZOxyo2HHiF0xYixEtTjPNrDL/AasSRkyQiQqt I2CQ== X-Gm-Message-State: AOJu0YyNY8/xNNWopVBXN3qOyyCDBy/LEtVREgc/rELulxta0V6Uib2Z b9Rgx0saS3nLiShceZCPCAaVAgJ+ZxPPCJyESMfsR18nqcO2k5gVDjNngRa3Cfcaw/1YX70gXDI v/8F98Y4= X-Gm-Gg: AZuq6aKhiIb3fgOmkQELHnmc7+4Mg0y5atj7HBitxV/p+085vhJ2Y3i+ZsmSgoL6dvZ 7E9O4Qh7WezPRz3aXEH1BURbtLegNzA6VpjKq3Q794ovP4jx5YFoecG9LlujQsOoee2CQn2x7Iq 5QPYSgOrZC8+V0wK4hzImv2na3wVGbQrmI2KwYaqrZn2nvPE/w05UctPOTacdQgHSUcE8eg2Ig8 HsnE1dQUX40aRxvvGrFpde7LQgj1AwptK1aGeuRT0H/l+OhAqyBwENAI/ADGbo9lsGBMf92Q4MW 0Gwop7NnHQTbZL5+cJsouUWoM4eB6dI0Jhdu+JrGLNnyHEFnKH8Vlc1UV9y34em0KUNRHPSkfWW eg/EeGALBbUp4DxGpEHlZqD78Qc+fr7ETa4CzdCqc26dbhO1eEREWj4+wg9dDx6jSKpLJO8L2yM zueBHsej6VYcWx3igXYOHzWtyf0QGkMJf0Fm3lpWwwltKLN8SbfybAHIHzb7LB X-Received: by 2002:a05:600d:8444:20b0:483:a21:7744 with SMTP id 5b1f17b1804b1-4830a217780mr18909125e9.26.1770131273585; Tue, 03 Feb 2026 07:07:53 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 28/30] disas/riscv: Make rv_decode::cfg const Date: Tue, 3 Feb 2026 16:04:33 +0100 Message-ID: <20260203150436.71907-29-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131297503158501 Disassembler is not expected to alter the CPU config. Besides, all other RISC-V methods takes a const RISCVCPUConfig. Make the @cfg field of the rv_decode structure const, passing a const pointer to disasm_inst(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202222412.24923-6-philmd@linaro.org> --- disas/riscv.h | 2 +- disas/riscv.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/disas/riscv.h b/disas/riscv.h index d211700cb2f..379e642ec84 100644 --- a/disas/riscv.h +++ b/disas/riscv.h @@ -189,7 +189,7 @@ typedef struct { } rv_opcode_data; =20 typedef struct { - RISCVCPUConfig *cfg; + const RISCVCPUConfig *cfg; uint64_t pc; uint64_t inst; const rv_opcode_data *opcode_data; diff --git a/disas/riscv.c b/disas/riscv.c index 85cd2a9c2ae..6f2667482dc 100644 --- a/disas/riscv.c +++ b/disas/riscv.c @@ -5409,7 +5409,7 @@ static void decode_inst_decompress(rv_decode *dec, rv= _isa isa) /* disassemble instruction */ =20 static GString *disasm_inst(rv_isa isa, uint64_t pc, rv_inst inst, - RISCVCPUConfig *cfg) + const RISCVCPUConfig *cfg) { rv_decode dec =3D { 0 }; dec.pc =3D pc; @@ -5509,7 +5509,8 @@ print_insn_riscv(bfd_vma memaddr, struct disassemble_= info *info, rv_isa isa) } =20 g_autoptr(GString) str =3D - disasm_inst(isa, memaddr, inst, (RISCVCPUConfig *)info->target_inf= o); + disasm_inst(isa, memaddr, inst, + (const RISCVCPUConfig *)info->target_info); (*info->fprintf_func)(info->stream, "%s", str->str); =20 return len; --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131295; cv=none; d=zohomail.com; s=zohoarc; b=SXRB1MhoXQmVr0125z1sVGgffW7uPYj8PmQFWOYwlB11qpWi4JnCbX2ccA7DZ9HOPps/AxbyMTzZFiCZQmNMPDQyytL1QKosLD/AseTU8mhfY4seGwrm56E0SVymKoeGY1s/iFvXCUwrYKfbcASGv8ub7kie9RMkE3uP88cw7zQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131295; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=5FbGuI09UeGlV1NJ2eeqCeHlDojkDVpM3vN/lPwtocI=; b=aoWtodRYnEvv6ifUPzS3a0kEXGaM4bX3CYDtTugyizX9kdZfiONMNDAhYsNz6jXRfqURdrb7pn9TqT33/2wv7qbKLFI46SSEvkUoRkH4M40m6KdR7cZyPT+WOlNpIxrxJ1gDWBvY/amQ7Ey54oSD39v96euheHVgaI0uj0a2azk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131295851380.8087363711538; Tue, 3 Feb 2026 07:08:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnI0c-000204-SH; Tue, 03 Feb 2026 10:08:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnI0a-0001w9-E9 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:08:04 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnI0Y-0002eF-OC for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:08:04 -0500 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-482f2599980so30126225e9.0 for ; Tue, 03 Feb 2026 07:08:02 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10e48a6sm50886185f8f.8.2026.02.03.07.07.59 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131280; x=1770736080; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=5FbGuI09UeGlV1NJ2eeqCeHlDojkDVpM3vN/lPwtocI=; b=X7gaXUx/PF5VbdHE6JgcdYcSusjhXPEb0aoL6z+lpfm851PAsfNugmUqzPQ0KLo8p9 YHIcnmoIXdXc5rUl5+GCwnUx34wEk03k904gfnhcXUvqu4peOPLgUmLez4nllEh1Pz/N 30gr9drqDp+YnOqE5596nKxXeKJqPoA3qHXNHmkBFr83b7m/a30qiekPOEYvU1Jc1yJk 0BHAtsovvQS4xDY8tBT6NFFDiyPdWUSaUFyVoQx71jFdZz0MVVLnrT5GlZGLIW8eNTcO 7jfNRyyP7h9Rdkl/S6xdd6dJI9QbbJsjawI4KlQ3/PECqe48GYF3FY1fd2quc0Sy9esf +9tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131280; x=1770736080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5FbGuI09UeGlV1NJ2eeqCeHlDojkDVpM3vN/lPwtocI=; b=Ju94MY6CW+sgio+WK5hgmN2DG9KR40Z7AOybK4rli5KUZWnbp9hp7Edx/JBn1N3Ul7 aibiebqZo5tx6ISsLzZXALbIBEn5qrFGjJWqHhIyTwmI3r+FED/EozTNdGO8V7S6lcTd 0TPE1KN0P+BBIZilcLt+tTCfNTJuicIS9EXNBcZG/kO3wpiYJpL1Vv3MrQMRz6AxxCCy hRnZq8yV2d56niJifJOKwkqVt6NV/YLprcvsTh65S6UNNT3QXGRJU6LB1RnH1SkYozl4 zSNhP1mkzrUIEbPMxcPnMUGdbnX78D0ew5Fxn/3VMexuXnqmtOYhTTU24O9jyMWCA2cs bsXA== X-Gm-Message-State: AOJu0YzKPnr0V1Xjx17r0M8DsRRX4lPNxc5i2/jXveA6frAMnxT67ivH QSDD8+rQiXfnoKn7Js0VErk2JYaygDikg0f8Aan43MnNhPc2rBsOHCp9juWH+6fHSbreL3VRID9 F9O6rrEYeRg== X-Gm-Gg: AZuq6aInG/bwZym3jWc8LP8L/ADKRDWuSKlL3tmd2+RDdvkYmpQEdPEBf9yWBuwFnoz TODzksKDfadctW6h2bBVpQJjLum5Jln/uMmFE5YsekKx5Vg7WTQcAyBdjo4tGSNFCMD7xV7uyts ZkstZQX3uFBXH4hd8LjqlIQjPBsW72ybpU/oWe8N4W/y2NmjVkqmWS0aKS/BeVsmNP2cJ7ZCwJ6 qnA0i7aYaEWaOTL5ok58VLacS260zaYSOKpyE6QzkzD2jrXM7DrPFKOknV+as3Ms3DL8EiDlw2o vzAlJTohM6G+wBbJPDbJ/yNiAkLu2e/afqvoAatFSfQTCB4xuk7z9+sW3EhLw8MqxMxI2g8dtFe rebuyqEAEK4ahSHsSsJRioCY2gwtRGxxb/tZZH5B4Zhekb2UvMZsZ7/z8WL+82923oOqwDqc0yY 6sQg80574hc8+lfuuFiSaGrKyC+IQlI6iHQskga7yQ5mIWXIqNVu1oHMFX20E9 X-Received: by 2002:a05:600c:8716:b0:47a:80f8:82ab with SMTP id 5b1f17b1804b1-482db48d4c0mr220074465e9.24.1770131280549; Tue, 03 Feb 2026 07:08:00 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 29/30] disas: Make disassemble_info::target_info field const Date: Tue, 3 Feb 2026 16:04:34 +0100 Message-ID: <20260203150436.71907-30-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philmd@linaro.org; helo=mail-wm1-x342.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131298796154100 Disassemblers shouldn't need writeable context, so make the disassemble_info::target_info field const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260202222412.24923-7-philmd@linaro.org> --- include/disas/dis-asm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/disas/dis-asm.h b/include/disas/dis-asm.h index 3b50ecfb540..911352703ea 100644 --- a/include/disas/dis-asm.h +++ b/include/disas/dis-asm.h @@ -397,7 +397,7 @@ typedef struct disassemble_info { bool show_opcodes; =20 /* Field intended to be used by targets in any way they deem suitable. = */ - void *target_info; + const void *target_info; =20 /* Options for Capstone disassembly. */ int cap_arch; --=20 2.52.0 From nobody Sat Feb 7 05:48:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770131296; cv=none; d=zohomail.com; s=zohoarc; b=hU+spnpcx0J7zPehaLrjnjVNJ/v2PNd5QfErk6Fjuuv4LNLS+GoEs+DDPbbdpcbwGYLHvY+kGv/NYaneUm8lIWVQZmNo4pX7RDElkoB1HUJyYIi6bv4TR0uBrVcHWlvJNtEkm1btAVLcYnICb/p6k1Yb7WMiKVPgaWY1VsOtcVU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770131296; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Bdm0aHGmNQ9zZ+AvlsmblG6PXHwSDdk0ED8Izh6zOxU=; b=TSqgvKULZUVgTMHceeWCSEwrAinzMDFcYosQoPFP4s+SAgq5Y+3tF6Khm46aK9pNvf1UbrhJrjSlXUp1V0vA2yYD2WrHNGrSh96hxDSvkkORhu+TLaGQ0vLfDb/0KmKbaQkFka6schFD017tlIjVp62y6OJMBg0c3OPUNqHm7yY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770131296315651.3845809698039; Tue, 3 Feb 2026 07:08:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnI0k-00025k-UR; Tue, 03 Feb 2026 10:08:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnI0i-00024D-Hp for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:08:12 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnI0g-0002g9-CX for qemu-devel@nongnu.org; Tue, 03 Feb 2026 10:08:12 -0500 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-48069a48629so59568835e9.0 for ; Tue, 03 Feb 2026 07:08:09 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e13235f5sm49413868f8f.29.2026.02.03.07.08.06 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Feb 2026 07:08:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770131288; x=1770736088; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Bdm0aHGmNQ9zZ+AvlsmblG6PXHwSDdk0ED8Izh6zOxU=; b=P4ZNoPV2+Tcqq2YAMELgubZh6CaN2+Ti5BWcqootkB3BnZy02T3Orb19E6ulUGpGyd Jv6aQoYO4McROvXP2FNAy9Jp2Q2Kdb2ho4G8/ve48oPl8JG+z0SIJxt1wH/G++Ueen9p e873sEYbunH0U/Ftz/XNNGlwDy2HyE5+NE4FPBK4iMojV1oImDOlDNqwpnTfFR7zD+P6 PARRFUJRVluFnrZchw2m79gd2Co+VJXaB9/fXTUUKlkvYldjOPFaBfJpD0WMM4PMsgsz dd6jyNFlc/sIgfUg32SaPWSJXaQAzmDj0YRApmzrYD7iwabtghq9Op5ZGEH9bxlD5F5r 9JYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770131288; x=1770736088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Bdm0aHGmNQ9zZ+AvlsmblG6PXHwSDdk0ED8Izh6zOxU=; b=DaG5F2ak7CE6bHgmgVFZiyeOcYw/9swtwiFrAZltrGdSuGPD/faAw16oCJuEJW7qJP DTDhZMaUJfS8u/Qu9ZavKpbGCC8SKfwDM6smk1lvE2MKeCoWAmQAFxoKbg8Bq9vw0eK/ 1eoU+aXCU3jVOWnSXDkMOLPZUKltyjH55S6FJ/p6poY/U29Zp31we2I8MCMCqFBhRRsM SCv58bQed7jv0NhkMaFfX7IEVtH6orGodbncc/i91ScBl71TJORxbCwLQWKAb1UcAl3G n+w3cEuVkuQwxF/kkQuDdS5wy2xsGVyQ7m7QoNP//Vpsrq4qV5cqpyb399SP9sQxw+KX nc+w== X-Gm-Message-State: AOJu0Yx/1bvg9wMYfC54333LtTrnpazi4cSNUay6vDusGnJwTHsBru0L 9lkU3gquwbhSrMZzKlY+WyLui1X2dIvaDn9JizrkxY5mKOxBwjqgNZYxOVVYOHfbsRRs19a1e14 84WU56u9GJQ== X-Gm-Gg: AZuq6aJqhd2GpQQfvlkiN3qowcODkcQULq4drmsSHbaNIaWZVp3+AsK8SYJwpnRiTZw 0xiCU+3ef8ldwPZpvXZJapzGG9fQRACxvOp3rJaB6MVEVGtpWTlLFwQTVi9cXhIABUGGLYNTCZr Qu4/DCks9h8bbCy6jt5xc8QD6u/A2YkraHgM2+/tVkaAcsRdLWyEUBeM/LB3fOIeb+3LUxuclo7 w0f7FS3xU4ozbqwuHWW9LTb07gGpIYoeSNPzPtvqN6OlF31Lsy/2xEqRjFuTOlxhhz81Bo84EDN AvReltYJBmr0KkGk6r3ygzZeKdbU6+T/kWkLhqY5xziycZVOli9KXQtaPLGdpdsxWTHF9Ss0B6C zv6P+hMhfFwuJARIsrtroPF93AyMnmFY89oPSWRm93QVeFuCTnBG0evJ00QFXOK1KFYsH+GTmkq 4ihmWn0k9wC9V3SMKs0eTKGyBpJMY3Yma+TgpmNU8pMLeE0Y/lHvPR9S4yd7Uu X-Received: by 2002:a05:600c:810c:b0:47e:e414:b915 with SMTP id 5b1f17b1804b1-482db44d338mr191892875e9.2.1770131287576; Tue, 03 Feb 2026 07:08:07 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 30/30] disas: Have disas_set_info() take a const CPUState Date: Tue, 3 Feb 2026 16:04:35 +0100 Message-ID: <20260203150436.71907-31-philmd@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260203150436.71907-1-philmd@linaro.org> References: <20260203150436.71907-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philmd@linaro.org; helo=mail-wm1-x342.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770131298794154100 The CPUClass::disas_set_info() handler is meant to initialize the %disassemble_info structure; it shoudn't alter the CPU state. Enforce the CPUState can not be modified by having the handler take a const pointer. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Message-ID: <20260202222412.24923-8-philmd@linaro.org> --- include/hw/core/cpu.h | 2 +- target/alpha/cpu.c | 3 ++- target/arm/cpu.c | 6 +++--- target/avr/cpu.c | 2 +- target/hexagon/cpu.c | 3 ++- target/hppa/cpu.c | 2 +- target/i386/cpu.c | 6 +++--- target/loongarch/cpu.c | 3 ++- target/m68k/cpu.c | 2 +- target/microblaze/cpu.c | 2 +- target/mips/cpu.c | 7 +++++-- target/openrisc/cpu.c | 2 +- target/ppc/cpu_init.c | 5 +++-- target/riscv/cpu.c | 7 ++++--- target/rx/cpu.c | 2 +- target/s390x/cpu.c | 2 +- target/sh4/cpu.c | 3 ++- target/sparc/cpu.c | 3 ++- target/xtensa/cpu.c | 3 ++- 19 files changed, 38 insertions(+), 27 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 98678704a64..ef20cb356a6 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -175,7 +175,7 @@ struct CPUClass { const char * (*gdb_arch_name)(CPUState *cpu); const char * (*gdb_get_core_xml_file)(CPUState *cpu); =20 - void (*disas_set_info)(CPUState *cpu, disassemble_info *info); + void (*disas_set_info)(const CPUState *cpu, disassemble_info *info); =20 const char *deprecation_note; struct AccelCPUClass *accel_cpu; diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c index 932cddac055..1780db7d1e2 100644 --- a/target/alpha/cpu.c +++ b/target/alpha/cpu.c @@ -98,7 +98,8 @@ static int alpha_cpu_mmu_index(CPUState *cs, bool ifetch) return alpha_env_mmu_index(cpu_env(cs)); } =20 -static void alpha_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) +static void alpha_cpu_disas_set_info(const CPUState *cpu, + disassemble_info *info) { info->endian =3D BFD_ENDIAN_LITTLE; info->mach =3D bfd_mach_alpha_ev6; diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 586202071d0..c535b292d99 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -789,10 +789,10 @@ static void arm_wfxt_timer_cb(void *opaque) } #endif =20 -static void arm_disas_set_info(CPUState *cpu, disassemble_info *info) +static void arm_disas_set_info(const CPUState *cpu, disassemble_info *info) { - ARMCPU *ac =3D ARM_CPU(cpu); - CPUARMState *env =3D &ac->env; + const ARMCPU *ac =3D ARM_CPU(cpu); + const CPUARMState *env =3D &ac->env; bool sctlr_b =3D arm_sctlr_b(env); =20 if (is_a64(env)) { diff --git a/target/avr/cpu.c b/target/avr/cpu.c index 52237da3ce9..8579a7283b1 100644 --- a/target/avr/cpu.c +++ b/target/avr/cpu.c @@ -116,7 +116,7 @@ static void avr_cpu_reset_hold(Object *obj, ResetType t= ype) memset(env->r, 0, sizeof(env->r)); } =20 -static void avr_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) +static void avr_cpu_disas_set_info(const CPUState *cpu, disassemble_info *= info) { info->endian =3D BFD_ENDIAN_LITTLE; info->mach =3D bfd_arch_avr; diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index 8ac4f49aa3b..58a22ee41f2 100644 --- a/target/hexagon/cpu.c +++ b/target/hexagon/cpu.c @@ -301,7 +301,8 @@ static void hexagon_cpu_reset_hold(Object *obj, ResetTy= pe type) set_float_default_nan_pattern(0b11111111, &env->fp_status); } =20 -static void hexagon_cpu_disas_set_info(CPUState *s, disassemble_info *info) +static void hexagon_cpu_disas_set_info(const CPUState *cs, + disassemble_info *info) { info->print_insn =3D print_insn_hexagon; info->endian =3D BFD_ENDIAN_LITTLE; diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index 0ca79ee5e23..714f3bbdaf7 100644 --- a/target/hppa/cpu.c +++ b/target/hppa/cpu.c @@ -150,7 +150,7 @@ static int hppa_cpu_mmu_index(CPUState *cs, bool ifetch) return env->psw & PSW_W ? MMU_ABS_W_IDX : MMU_ABS_IDX; } =20 -static void hppa_cpu_disas_set_info(CPUState *cs, disassemble_info *info) +static void hppa_cpu_disas_set_info(const CPUState *cs, disassemble_info *= info) { info->mach =3D bfd_mach_hppa20; info->endian =3D BFD_ENDIAN_BIG; diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 45f0b80deb0..0a7b884528e 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -10359,10 +10359,10 @@ static bool x86_cpu_has_work(CPUState *cs) } #endif /* !CONFIG_USER_ONLY */ =20 -static void x86_disas_set_info(CPUState *cs, disassemble_info *info) +static void x86_disas_set_info(const CPUState *cs, disassemble_info *info) { - X86CPU *cpu =3D X86_CPU(cs); - CPUX86State *env =3D &cpu->env; + const X86CPU *cpu =3D X86_CPU(cs); + const CPUX86State *env =3D &cpu->env; =20 info->endian =3D BFD_ENDIAN_LITTLE; info->mach =3D (env->hflags & HF_CS64_MASK ? bfd_mach_x86_64 diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c index b6539485266..4fa629cb144 100644 --- a/target/loongarch/cpu.c +++ b/target/loongarch/cpu.c @@ -506,7 +506,8 @@ static void loongarch_cpu_reset_hold(Object *obj, Reset= Type type) cs->exception_index =3D -1; } =20 -static void loongarch_cpu_disas_set_info(CPUState *s, disassemble_info *in= fo) +static void loongarch_cpu_disas_set_info(const CPUState *cs, + disassemble_info *info) { info->endian =3D BFD_ENDIAN_LITTLE; info->print_insn =3D print_insn_loongarch; diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index b55e604b11d..c721a23b966 100644 --- a/target/m68k/cpu.c +++ b/target/m68k/cpu.c @@ -176,7 +176,7 @@ static void m68k_cpu_reset_hold(Object *obj, ResetType = type) env->pc =3D 0; } =20 -static void m68k_cpu_disas_set_info(CPUState *s, disassemble_info *info) +static void m68k_cpu_disas_set_info(const CPUState *cs, disassemble_info *= info) { info->print_insn =3D print_insn_m68k; info->endian =3D BFD_ENDIAN_BIG; diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 53649ec6567..ae41a1a3287 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -233,7 +233,7 @@ static void mb_cpu_reset_hold(Object *obj, ResetType ty= pe) #endif } =20 -static void mb_disas_set_info(CPUState *cpu, disassemble_info *info) +static void mb_disas_set_info(const CPUState *cpu, disassemble_info *info) { info->mach =3D bfd_arch_microblaze; info->print_insn =3D print_insn_microblaze; diff --git a/target/mips/cpu.c b/target/mips/cpu.c index f74a9d5f615..e424d115018 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -422,9 +422,12 @@ static void mips_cpu_reset_hold(Object *obj, ResetType= type) #endif } =20 -static void mips_cpu_disas_set_info(CPUState *s, disassemble_info *info) +static void mips_cpu_disas_set_info(const CPUState *cs, disassemble_info *= info) { - if (!(cpu_env(s)->insn_flags & ISA_NANOMIPS32)) { + const MIPSCPU *cpu =3D MIPS_CPU(cs); + const CPUMIPSState *env =3D &cpu->env; + + if (!(env->insn_flags & ISA_NANOMIPS32)) { info->endian =3D TARGET_BIG_ENDIAN ? BFD_ENDIAN_BIG : BFD_ENDIAN_LITTLE; info->print_insn =3D TARGET_BIG_ENDIAN ? print_insn_big_mips diff --git a/target/openrisc/cpu.c b/target/openrisc/cpu.c index 9bbfe22ed3a..c64542a59a2 100644 --- a/target/openrisc/cpu.c +++ b/target/openrisc/cpu.c @@ -94,7 +94,7 @@ static int openrisc_cpu_mmu_index(CPUState *cs, bool ifet= ch) return MMU_NOMMU_IDX; /* mmu is disabled */ } =20 -static void openrisc_disas_set_info(CPUState *cpu, disassemble_info *info) +static void openrisc_disas_set_info(const CPUState *cpu, disassemble_info = *info) { info->endian =3D BFD_ENDIAN_BIG; info->print_insn =3D print_insn_or1k; diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index c5cec7c2ed9..c36fd118a99 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -7452,9 +7452,10 @@ static bool ppc_pvr_match_default(PowerPCCPUClass *p= cc, uint32_t pvr, bool best) return pcc->pvr =3D=3D pvr; } =20 -static void ppc_disas_set_info(CPUState *cs, disassemble_info *info) +static void ppc_disas_set_info(const CPUState *cs, disassemble_info *info) { - CPUPPCState *env =3D cpu_env(cs); + const PowerPCCPU *cpu =3D POWERPC_CPU(cs); + const CPUPPCState *env =3D &cpu->env; =20 info->endian =3D ppc_env_is_little_endian(env) ? BFD_ENDIAN_LITTLE : BFD_ENDIAN_BIG; diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index e95eea02493..e56470a3748 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -795,10 +795,11 @@ static void riscv_cpu_reset_hold(Object *obj, ResetTy= pe type) #endif } =20 -static void riscv_cpu_disas_set_info(CPUState *s, disassemble_info *info) +static void riscv_cpu_disas_set_info(const CPUState *s, disassemble_info *= info) { - RISCVCPU *cpu =3D RISCV_CPU(s); - CPURISCVState *env =3D &cpu->env; + const RISCVCPU *cpu =3D RISCV_CPU(s); + const CPURISCVState *env =3D &cpu->env; + info->target_info =3D &cpu->cfg; =20 /* diff --git a/target/rx/cpu.c b/target/rx/cpu.c index 0437edca1ba..b5284199e6d 100644 --- a/target/rx/cpu.c +++ b/target/rx/cpu.c @@ -178,7 +178,7 @@ static void rx_cpu_set_irq(void *opaque, int no, int re= quest) } } =20 -static void rx_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) +static void rx_cpu_disas_set_info(const CPUState *cpu, disassemble_info *i= nfo) { info->endian =3D BFD_ENDIAN_LITTLE; info->mach =3D bfd_mach_rx; diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c index cd472d38be7..c074e12ba2d 100644 --- a/target/s390x/cpu.c +++ b/target/s390x/cpu.c @@ -222,7 +222,7 @@ static void s390_cpu_reset_hold(Object *obj, ResetType = type) } } =20 -static void s390_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) +static void s390_cpu_disas_set_info(const CPUState *cpu, disassemble_info = *info) { info->mach =3D bfd_mach_s390_64; info->cap_arch =3D CS_ARCH_SYSZ; diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c index 1dd21ad9ed6..e2bde457618 100644 --- a/target/sh4/cpu.c +++ b/target/sh4/cpu.c @@ -164,7 +164,8 @@ static void superh_cpu_reset_hold(Object *obj, ResetTyp= e type) set_float_ftz_detection(float_ftz_before_rounding, &env->fp_status); } =20 -static void superh_cpu_disas_set_info(CPUState *cpu, disassemble_info *inf= o) +static void superh_cpu_disas_set_info(const CPUState *cpu, + disassemble_info *info) { info->endian =3D TARGET_BIG_ENDIAN ? BFD_ENDIAN_BIG : BFD_ENDIAN_LITTLE; diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index bfc6fb9d00d..3991681d1d1 100644 --- a/target/sparc/cpu.c +++ b/target/sparc/cpu.c @@ -103,7 +103,8 @@ static bool sparc_cpu_exec_interrupt(CPUState *cs, int = interrupt_request) } #endif /* !CONFIG_USER_ONLY */ =20 -static void cpu_sparc_disas_set_info(CPUState *cpu, disassemble_info *info) +static void cpu_sparc_disas_set_info(const CPUState *cpu, + disassemble_info *info) { info->print_insn =3D print_insn_sparc; info->endian =3D BFD_ENDIAN_BIG; diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c index ecc5e093a40..86ec899a67c 100644 --- a/target/xtensa/cpu.c +++ b/target/xtensa/cpu.c @@ -226,7 +226,8 @@ static ObjectClass *xtensa_cpu_class_by_name(const char= *cpu_model) return oc; } =20 -static void xtensa_cpu_disas_set_info(CPUState *cs, disassemble_info *info) +static void xtensa_cpu_disas_set_info(const CPUState *cs, + disassemble_info *info) { XtensaCPU *cpu =3D XTENSA_CPU(cs); =20 --=20 2.52.0