From nobody Sat Feb 7 05:57:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770119621; cv=none; d=zohomail.com; s=zohoarc; b=NsCzbUqtpCaN/XdNKY5Punkr2+H3rKWd8Bklz8q51LHuXA35OYxpMCrBjBGpfrXPbf6SgGwRFt2uDsX13YCmR/gZ5223EJVGtH4vOx4zDhecf/UrwdTSdv9jCVs9maJloU/lfhiXUKJPp53yyXVRX5yUrmpSvL//F3twU/lLv3E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770119621; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ruv1Ejeh4EyN1qePTlvxJYVwjWJP4ANv3Gjqm9WaH/s=; b=m1gbfkWv2Mzxjogmd76kUvWKMA7AwMYuizivXaYfqYeMWYRosWS+Y18WPKuDe/SgSoOtjMdnyvZUS294LM1BsLFGrf4nQZeWhZJKzNMWfnsZ5BsOTH1LAjWmnHX8O72sW/CHFzj0OI9X46K7KXkJeMoS9/oYWubEeQNgb2qLpK4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770119621977789.2833038232291; Tue, 3 Feb 2026 03:53:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnEx2-0007vC-V2; Tue, 03 Feb 2026 06:52:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnEwy-0007sq-No for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:10 -0500 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnEwv-00057k-Js for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:08 -0500 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-65808bb859cso8230495a12.2 for ; Tue, 03 Feb 2026 03:52:05 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf2ecc73sm1039332166b.62.2026.02.03.03.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:52:03 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 26F4B5F844; Tue, 03 Feb 2026 11:52:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770119524; x=1770724324; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ruv1Ejeh4EyN1qePTlvxJYVwjWJP4ANv3Gjqm9WaH/s=; b=ZOWOVQG8O3R3Beyhbr0DfLC+y19xlLLLVcwPaq1axmuijbpfZkKCYBv9K5m6gJmkzQ pwYEiYDzyLML9UDfqoHSyOUDkpzTBnH9io+bClImN6JGdeVqY0RRtBFtvAa9zF2rnktS PWf+DxqNxB9GN1oMW5KBuNvIn0P0o5o1KsQD07r0STN2AG8IS7HFdOm/I72/QFiAiGbv 0HWCSQUxV6Amr+tf/WOwIUM/WC/ZCS335oCWaAlse+p9rKRh0/Qjq/yStsRjRhmM2AP5 7nR3OIKo1E+tkTKwrx13hvly32FUhNg9Zi6wrRfX3Yh8PEP5+Zs8Od82w1+fsme6Fmr6 DXOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119524; x=1770724324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ruv1Ejeh4EyN1qePTlvxJYVwjWJP4ANv3Gjqm9WaH/s=; b=ROD4vH0v2otlVx3GlEcsCkopqp+xpTgmHFMho656fp0lq9fEiH3x/rloMh/uvZNJRn FmJbENOhYzdIc308LfSSxCSVNu0rtRr79fbnV5MMFmXALIZcHGGG9gtv7w8UZELM5nGE xqPd/2xQaKsAEugnMOJzEZojC75NRG2/5Yb4RI77OjO7ZC0lUkEirBFLGHcpyEcycLY0 8AwE4cNi4Am75rYTHbDIk0Gu2ftjr66V6KIYUz+fiC/Uya074zmoQCDaxq8rnALTc+kQ OCv2HGfvuGb0Q2aTaHz5PkAnhnT86Tnax7Me+FVDgKrpZvArtHWcLRJhOcsNxBZmpHSv 4djw== X-Gm-Message-State: AOJu0Yxq1ffeDtYWhRqOitokcb9bU+QqaohZ8FhM5+ZD6eh0oW5B4Akt 3nVjre7AYIu6pKf/ycegxqXAx1diRHNQ5U2T0SkZPP3YElKSattHuxnHurOv4mVy9IM= X-Gm-Gg: AZuq6aKsqKyPBq1smLWcgDduzvEuVaUW0Iv3PY1YdQecErkSMhGaCem/SbMN8+biIFz U3vtL1lrOy1tkXc2hXG8UEfmyZyjE1N1hE39/hEQPHCJPTYQydMwGEZAm39rRzxZQZCCXLowxZE pNTxyAePlP4qNKPOhSKjuf8mIaVntz2l0bQfWPq1v4UVxSVrZi2yGWm1FqQNgukNGmWKaTevG8X +bCeTnUwcM+GlXmK0r1L033x6gQCJ9UgICr+2ZKCm4cIMRzQxVh7vx33bh/ued/Iqoesrjz+aDF w5nVzZwFxk1/hFnKTn+JPbVO9kzqDvavmXgfy1AwH3XDKB4FECC3iW6diU55XB59wUKRT9fPyFE uDa/rfnEk3ckp6/+6eUXZlxatAtWU9ClZKwqYIs6vdiMedELMXcewXCY84z3yUW543tVD12VDYj 3GRzy1UzW/4SU= X-Received: by 2002:a17:907:3f17:b0:b8a:f3c0:c14 with SMTP id a640c23a62f3a-b8dff721f68mr889105166b.38.1770119523924; Tue, 03 Feb 2026 03:52:03 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: John Snow , Pierrick Bouvier , qemu-arm@nongnu.org, Markus Armbruster , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Nicholas Piggin , Wainer dos Santos Moschetta , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Edgar E. Iglesias" , qemu-s390x@nongnu.org, Thomas Huth , Paolo Bonzini , Akihiko Odaki , Daniel Henrique Barboza , David Hildenbrand , Ilya Leoshkevich , Richard Henderson , Laurent Vivier , Gustavo Romero Subject: [PATCH 01/11] meson-buildoptions: Remove duplicated entry of --gdb in the help text Date: Tue, 3 Feb 2026 11:51:51 +0000 Message-ID: <20260203115201.2387721-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203115201.2387721-1-alex.bennee@linaro.org> References: <20260203115201.2387721-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::533; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770119623770158500 Since --gdb has recently been added to meson_options.txt, the help text shows up twice in the output of "./configure --help": $ ./configure --help | grep gdb --gdb=3DGDB-path gdb to use for gdbstub tests [/usr/bin/gdb] --gdb=3DVALUE Path to GDB As the probed value is of interest we want to keep the configure text so make meson-buildoptions able to handle deferring to configure. Fixes: b46b3818cf8 ("tests/functional: Provide GDB to the functional tests") Signed-off-by: Alex Benn=C3=A9e Acked-by: Paolo Bonzini Reviewed-by: Gustavo Romero Reviewed-by: Thomas Huth Tested-by: Thomas Huth --- scripts/meson-buildoptions.py | 9 ++++++++- scripts/meson-buildoptions.sh | 1 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/meson-buildoptions.py b/scripts/meson-buildoptions.py index e636d258e8a..9e3a75c8b11 100644 --- a/scripts/meson-buildoptions.py +++ b/scripts/meson-buildoptions.py @@ -53,6 +53,11 @@ "werror", } =20 +# Options that configure prints help for, so we can skip +CONFIGURE_HELP =3D { + "gdb", +} + # Builtin options that should be definable via configure. Some of the oth= ers # we really do not want (e.g. c_args is defined via the native file, not # via -D, because it's a mix of CFLAGS and --extra-cflags); for specific @@ -189,7 +194,9 @@ def print_help(options): key =3D cli_help_key(opt) # The first section includes options that have an arguments, # and booleans (i.e., only one of enable/disable makes sense) - if require_arg(opt): + if opt["name"] in CONFIGURE_HELP: + pass + elif require_arg(opt): metavar =3D cli_metavar(opt) left =3D f"--{key}=3D{metavar}" help_line(left, opt, 27, True) diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh index 3d0d1323446..e8edc5252a3 100644 --- a/scripts/meson-buildoptions.sh +++ b/scripts/meson-buildoptions.sh @@ -58,7 +58,6 @@ meson_options_help() { printf "%s\n" ' --enable-ubsan enable undefined behaviour san= itizer' printf "%s\n" ' --firmwarepath=3DVALUES search PATH for firmware fil= es [share/qemu-' printf "%s\n" ' firmware]' - printf "%s\n" ' --gdb=3DVALUE Path to GDB' printf "%s\n" ' --iasl=3DVALUE Path to ACPI disassembler' printf "%s\n" ' --includedir=3DVALUE Header file directory [inclu= de]' printf "%s\n" ' --interp-prefix=3DVALUE where to find shared librari= es etc., use %M for' --=20 2.47.3 From nobody Sat Feb 7 05:57:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770119600; cv=none; d=zohomail.com; s=zohoarc; b=X9s972jewRILI5uYSyFSLBZilKFH3Ffyffb9zwsBakWAJG15SAVOOko4GUa4s7w1lgY+p8XydNZmMqPidYvmpluUjA+C6P+/jx01TwnHIEkL4f0wW3KC8rJhiguKuxMJViQNA7QUCjA4Wfn8nnCXGUs0TI7XHDBUi0L4YAPHlN8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770119600; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MCrALKTLyk0E2VKZgTKk8x0b5abHTmgDgtK5TpMbn+A=; b=LWW/GYRmnWRyQE5Dao1FItXorOljRHJXLm1YIztXFBWwTMY2vpCqIvXYLWGf9QaRB5CyxvN/Rs7Cx7oB225LPEv7vqv6SFnY1itHIkxUc/73Brfh0mFXyZW8ZHMtc99EcJ75ln05Krw+FzE4VwrdHGnnT2ZuScZR+4HKTdclNqc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770119600866427.36207195363136; Tue, 3 Feb 2026 03:53:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnEx1-0007tm-MV; Tue, 03 Feb 2026 06:52:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnEwy-0007sa-6s for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:08 -0500 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnEwv-00057d-Fv for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:07 -0500 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-b884a84e655so808427966b.0 for ; Tue, 03 Feb 2026 03:52:04 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8df8465cb5sm757815866b.40.2026.02.03.03.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:52:02 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 3C4365F874; Tue, 03 Feb 2026 11:52:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770119524; x=1770724324; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MCrALKTLyk0E2VKZgTKk8x0b5abHTmgDgtK5TpMbn+A=; b=dgnXZb+DRHkH1ZMcFGTQefoN1EA5lXNKqDiJDVppalkylFRS5GdfZFP2vJbts/b/kr TA7uiJAI//WkPklCgHbWy2ijdQES9MQ2tfc40fPBvUe8H0vdasOb8LjBoCZOGojQ+dVh ZBGwbRNyIqF//+qcx2G9K95Xes5rxA+SRhLPigEIc7bK2Ub4vvGzd7QsRFxgQ7+Lfwoo t9+A1I9xoYLoGdkflApm6S5Xo9ZubGNYPsovs6q4uKWW+pE1CfdN5/PJ64C3TQvsWOaU DeG3V1tOkYaie1PxnNc42ybXCmDXkeS+7H0QmOuPATForPCOHZAsSjFla6zfMzr/eweD pxJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119524; x=1770724324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MCrALKTLyk0E2VKZgTKk8x0b5abHTmgDgtK5TpMbn+A=; b=cGO5NARrLMfhc339HV0Z+mNGDkFkShy0RPZGTzwqPOmlvRRNLEza3I5nWDpeWZh3sh hRm/aubgtHKHyJVi8QVfn4fEC54is1VhmzUDrg/6GbsgeYuA452/HqwPOCBSj2NfS35F 1lzVX5a95KdRD3/ew59205jN3Yjz4yDGktBseJPMr9bQRSZK3wf46NYRoGilydJvQWXV GnrqzCRT01LOKidTGbau+HxM6q2O6pVmW0wOidzUA57k3cq8rRgn94vExuUU9QwC8+je PxuhRBxA+be96UDXPxDoztGC88lOHzJE7TcgwJUtDoeW5YK5LhVB1qs/Fif7cs65FneZ 041w== X-Gm-Message-State: AOJu0Yxf0+FxHdrqDPxaAZ8hmiNErY/5cgZd/f86TTqzlfFEmtCqmVne 1aJkjYsWimxFeCBVzkQkMXKqtO5Fb3P4qJOgcjAakLSj08Lhq7PDtN73+yV36YrmBcw= X-Gm-Gg: AZuq6aKALPb3bCroG9p2cT3MOXfIC4ei93l2im9d5Yw2hkLQ+LvD1K7ZBmA6TqcL9JO +FwRDRMhXrTgS5W4Xm8CpPbKg2SvQlp0qsNHVjK+nfXd2oaBuwoYXe2/PwN1LMWU1oLz1ZotRzK RRDpA84Fhc5GOuJCKiuJE6FEsUiSCnZ/l5dl6qZwjXv8ToZ84gxr/1WCEj52HHf9Zr+Cbwkktu3 1ftCpvR5sGe54sI4tq6pJE8BXbyF9ssXteRKhe672UlKZQAwbZJGcUdf64AwtMMbYKdisuGKxfI spynIwaKNv0X1Dvaq9YNMBcB/hr6+uv6cwb0KshMflwcvLe5UbxBKCAPehwmza8WqLJyFatGHRA QBCwBgg1IIHcslW4yi5hL35uv2BFNn8fYUap/VJ1KiHX4NiWFZw/0q+L6MBGzonTZIYz5DH1VWO aW0yQlWW5n6bg= X-Received: by 2002:a17:906:c153:b0:b4f:e12e:aa24 with SMTP id a640c23a62f3a-b8dff5d95e5mr835340666b.22.1770119523543; Tue, 03 Feb 2026 03:52:03 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: John Snow , Pierrick Bouvier , qemu-arm@nongnu.org, Markus Armbruster , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Nicholas Piggin , Wainer dos Santos Moschetta , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Edgar E. Iglesias" , qemu-s390x@nongnu.org, Thomas Huth , Paolo Bonzini , Akihiko Odaki , Daniel Henrique Barboza , David Hildenbrand , Ilya Leoshkevich , Richard Henderson , Laurent Vivier Subject: [PATCH 02/11] Makefile: add python script dependency for meson-buildoptions.sh Date: Tue, 3 Feb 2026 11:51:52 +0000 Message-ID: <20260203115201.2387721-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203115201.2387721-1-alex.bennee@linaro.org> References: <20260203115201.2387721-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770119603769158500 If we update the script we should also make sure we regenerate the help text. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Paolo Bonzini --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9fb55dcf330..54547a37b1a 100644 --- a/Makefile +++ b/Makefile @@ -130,7 +130,7 @@ Makefile.mtest: build.ninja scripts/mtest2make.py =20 .PHONY: update-buildoptions all update-buildoptions: $(SRC_PATH)/scripts/meson-buildoptions.sh -$(SRC_PATH)/scripts/meson-buildoptions.sh: $(SRC_PATH)/meson_options.txt +$(SRC_PATH)/scripts/meson-buildoptions.sh: $(SRC_PATH)/meson_options.txt $= (SRC_PATH)/scripts/meson-buildoptions.py $(MESON) introspect --buildoptions $(SRC_PATH)/meson.build | $(PYTHON) \ scripts/meson-buildoptions.py > $@.tmp && mv $@.tmp $@ endif --=20 2.47.3 From nobody Sat Feb 7 05:57:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770119664; cv=none; d=zohomail.com; s=zohoarc; b=SpfX/DXFQysOtLaiKNVlltAowwVZ9MtEgTlx8XLYo50UTgUyeU38pg+S2IUyXH5/6ytulyl6PAfaaMda4LwGTZTJgYXXfffXGLPmD0eSjTUx7u8TObk+O+FtRsLBdgo8FgpwfikTVHkZe0ch93slcGu5WgYDcceJSLWx5hOtG8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770119664; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gmAQhMQ8vyDaeIAxAhsnVaQsmiKDf2EhtEVKbz4JjHE=; b=m2q//cuYOW41X9czftt8UqjyCQSudrjti5QahHfnwqJNM+M6fKiImlYttydqsG8/S8jdy+htXezRZJ/X3T78jqxx4LSPbKD8H0QA96+oOHnQmZuhITXKTIK3RYpugfXqkkSq6ebZTiotStFaLnqGeFxcjOSnHvl5GFff/KgRpaQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17701196644561021.8724007225445; Tue, 3 Feb 2026 03:54:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnExQ-0008FI-Dq; Tue, 03 Feb 2026 06:52:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnEx2-0007vA-QN for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:12 -0500 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnEx0-000593-74 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:12 -0500 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-6580dbdb41eso8374768a12.0 for ; Tue, 03 Feb 2026 03:52:08 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b4256949sm9087243a12.6.2026.02.03.03.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:52:03 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 51E4A5FAED; Tue, 03 Feb 2026 11:52:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770119527; x=1770724327; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gmAQhMQ8vyDaeIAxAhsnVaQsmiKDf2EhtEVKbz4JjHE=; b=TFDR7sju0zE0PuoNSu/uMyxJYYMJidotjG7VTJ3GT8Cx992GS1H9UjyF5C5gtyaXHZ VzF6aaakBZU0Gh2x0MC+GvhOm0t/SQofefNILNYwdYwQ3DxnnlS0rnQh8Z5zOdjsyQWs Wrs/O0AIcIX3IJ5riw/+yl6u7TQAzEUY0aXqVQatSgapoWqDy59NvESTFDhm8vP0+ORZ 2WKJXI1LfjM+llPywJgqxkbpt3oGWvGOVRniye/uqC9KD/bo8C2c0QVE5ihPgQEATppA LaDG91a6A9lmZcu9NgdXCjq0/N/nIydqnTVpezNW2lGue4QW+NccvhRC6+qklb7vPZlH mU3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119527; x=1770724327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gmAQhMQ8vyDaeIAxAhsnVaQsmiKDf2EhtEVKbz4JjHE=; b=rokyZEYo6OJMgkXKIlMARvCHYxlW/YkmEJUiT2wIlLVc1WfvOOxrjTTW+XRmHUcl8c gmwNIEFB38dhIkJO580nYvtGldS8NlYOsE4x1NgClbP42IgBVrTxwtVotCWvfY4wfCJl djUrg7HUUpdcs9ZuwiIubpjtZRjchYYLiTqvYpLCSwOuVXdMoDpfDj3DUf31FgGLwqjJ s5Uw5WV6O2IFaCcZuyDJRtYxuGL2J9VsjdOWWwo/AIAJNERGhhBMUegY9lCfk8bK0iuf mq7eWtYZ2X4uAjOleyexI0tVQZsfmVl/CRUNyQ9IsYEfHqrUXMHM5x0a4O9AMRMntBCD HIWQ== X-Gm-Message-State: AOJu0YzfiW4pDiVFUi1h2NM3xxxNsjAZgo797GACtYBTF55s15vWhKE2 V8lKA0ZNTItMFgPMDHZoxAnl8GLyCxPJPGEV+5SaF3cXTtL81e8HlnB/+06MoqjWLqo= X-Gm-Gg: AZuq6aLYCe2w61olFSx4DJcagXf4DIveJ/h/pRxgMEP6u0GehjuoS6eVvyRUvYrriSs zmvuJwZibck8yTRqMWoBOknSOGhK5jdOH1VDzh/5A/6rChn6AbujoUZOwrz6KLRIviLwjUVxQB7 5qERj+j9ppqkYMmwQbiZDULy9f6ERHneOxG/r1e5Ta/a9tBzrHzkgCpXvpj2Qvq/K5OrH2C0RWG 0+EkZAQz6jnk/qzJ4CuYpKpnWOBvUg+ZWB7oAEdnj3FGZqFk0bP7upH+JjHJbD2zggs2krHgyh/ bgXyEWpv0S8CTXEeOxbP0XpeMSvlNFBhIZV9A2wxcxB0aLok8YqOcTZ2rMlvyackE9lWT23IVm7 YscbK/xLSP2Jsaf78Ig8wVdnl3kjjWJZDmzdIbMe8ezZnRIf9NdS7BdIvODAun0jXd2b+YUC027 xCM7GSVbx8px+U9h5ee7c6Kg== X-Received: by 2002:a05:6402:538c:b0:659:389c:a0fc with SMTP id 4fb4d7f45d1cf-659389ca359mr909932a12.27.1770119527298; Tue, 03 Feb 2026 03:52:07 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: John Snow , Pierrick Bouvier , qemu-arm@nongnu.org, Markus Armbruster , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Nicholas Piggin , Wainer dos Santos Moschetta , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Edgar E. Iglesias" , qemu-s390x@nongnu.org, Thomas Huth , Paolo Bonzini , Akihiko Odaki , Daniel Henrique Barboza , David Hildenbrand , Ilya Leoshkevich , Richard Henderson , Laurent Vivier Subject: [PATCH 03/11] gdbstub: remove the need for goto cleanup Date: Tue, 3 Feb 2026 11:51:53 +0000 Message-ID: <20260203115201.2387721-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203115201.2387721-1-alex.bennee@linaro.org> References: <20260203115201.2387721-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770119665575158500 We already set a default error reply which we can only overwrite if we successfully follow the chain of checks. Initialise the variables as NULL and use that to gate the construction of the filled out stop/reply packet. Signed-off-by: Alex Benn=C3=A9e --- gdbstub/gdbstub.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 1f8cd118924..d4db7ba30cc 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1413,36 +1413,32 @@ static void handle_v_cont(GArray *params, void *use= r_ctx) =20 static void handle_v_attach(GArray *params, void *user_ctx) { - GDBProcess *process; - CPUState *cpu; + GDBProcess *process =3D NULL; + CPUState *cpu =3D NULL; =20 + /* Default error reply */ g_string_assign(gdbserver_state.str_buf, "E22"); - if (!params->len) { - goto cleanup; - } - - process =3D gdb_get_process(gdb_get_cmd_param(params, 0)->val_ul); - if (!process) { - goto cleanup; + if (params->len) { + process =3D gdb_get_process(gdb_get_cmd_param(params, 0)->val_ul); } =20 - cpu =3D gdb_get_first_cpu_in_process(process); - if (!cpu) { - goto cleanup; + if (process) { + cpu =3D gdb_get_first_cpu_in_process(process); } =20 - process->attached =3D true; - gdbserver_state.g_cpu =3D cpu; - gdbserver_state.c_cpu =3D cpu; + if (cpu) { + process->attached =3D true; + gdbserver_state.g_cpu =3D cpu; + gdbserver_state.c_cpu =3D cpu; =20 if (gdbserver_state.allow_stop_reply) { g_string_printf(gdbserver_state.str_buf, "T%02xthread:", GDB_SIGNA= L_TRAP); gdb_append_thread_id(cpu, gdbserver_state.str_buf); g_string_append_c(gdbserver_state.str_buf, ';'); gdbserver_state.allow_stop_reply =3D false; -cleanup: - gdb_put_strbuf(); } + + gdb_put_strbuf(); } =20 static void handle_v_kill(GArray *params, void *user_ctx) --=20 2.47.3 From nobody Sat Feb 7 05:57:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770119646; cv=none; d=zohomail.com; s=zohoarc; b=bcGmTaN96ia0XsuWHv5qUoeVrONGq0wNW8UNqPxT8QaR55kPnH9WOrq/8P3XE7e++VEStVJnEASHs0qnPKtg5ztCqv1E7MkKLrBNGCeOPtiIDN7bMk5Bdeg7Bizn3MnVBC8HfEdGu+8bvxy7uiusuVPO2ytsGxcorjQ7pfQ3WB8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770119646; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lCQXfrGRlea+C74aku67SoZ+IPzjFLau/OaSoC6An2g=; b=jU4PccYWd/R5r5++88Zoyb6gBjC6QifC6a3TEkdsKE3aOKmnTTJSgFsg75S1F47Id+bqpB1fbmUEHdOW3gsZoHsP/5xC9H0YJM92wjjbYrlyzRSzJ+YY/XDZZPBJADQoAZ5yuEr+lIbN3O4ETfVYffPTeaRa01hU11gpGfSjGR4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770119646677992.3001276859104; Tue, 3 Feb 2026 03:54:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnExK-00087E-FA; Tue, 03 Feb 2026 06:52:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnEx2-0007vJ-S3 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:12 -0500 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnEwx-00058P-8t for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:10 -0500 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-b8837152db5so879614966b.0 for ; Tue, 03 Feb 2026 03:52:06 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e142a57c8sm618914466b.37.2026.02.03.03.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:52:03 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 6C35D60001; Tue, 03 Feb 2026 11:52:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770119526; x=1770724326; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lCQXfrGRlea+C74aku67SoZ+IPzjFLau/OaSoC6An2g=; b=che9Zroo3SiLueyQI4zQbzCAsCi+dZ41lHy7CMXElp+vKwjE2lvHyIwMnSB6+IhNvO erdXsg0iT/zUj5hD2Rt7NNAIY971ABKrRp1E/NzCzymuqCAWMfTW0vQkX5/Djcbx6BpF a8dZ0d+bTVZA9np0eAYpFb3QSMhdGyq+w8lN/ViqVhAm5025I4+YAm5C8rXT4VBVh84f V+qhfuqksju2aJTElJbDNt2sWolHzBBXKEJesFwwTQRwYsR1j5sh9xXNag+HoL5WlKFQ 4W9AcOjwcfnSJxRQ9czoE10nFDbHW4jNBs593axQrNTa6tH64x2ciwOKEy+UcSkp1HN3 UuVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119526; x=1770724326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lCQXfrGRlea+C74aku67SoZ+IPzjFLau/OaSoC6An2g=; b=l4Wqd5m5s3z0geCBH1r4epqmt86/oi4IEXlnpl8GfdWqkIQSaBjk6FPFiY5ENIHvT4 cxeNvOBqkkBS8lSTkPf2AZ4UoyOyJM3wA0QbVBPfREikXCH9B/tdGJ79+0kzxEI99r/b aHu/BGyJ8wAPLT7KsGSLi8rvHGSmV1iynnDkLBNH29SXkptS7Y6Z0shDJYjA0/ZAoPJX jWA9IcRg+uvImiYvXiaHiXrt5Le0IsYvO/AEsmnnV+/QUlcjWgSBA/W84/GD+gLCM8Kh Qyxnio4xsR5W/xb3RuNMKIXA4w+vhdEL8B3QgMn2VV72gMJvrLJN1dBi7j39MXyOB7xv rJNA== X-Gm-Message-State: AOJu0YzhcI96kYIrip4b7yV7Ka2T04SLUuHIxh3TPNHJ9LiJkB4pDEY/ ZN81MbLsPfDOtYePHyE8KfsiSqN2K0GtWW5PXBfnvf6RnulMj6d+HCDbC1fivJgA1D4= X-Gm-Gg: AZuq6aK5KV6gaLQDBvqlZ4iHnDkekYkBhF8m47P24sTAIXcdcPke8f+OuHlljCq2+vY z5liNPSp9sy7BZSTl3qe7UVU6Lyv1zSrSkqzWN6lEaTy293ju1SOjl6U3yP2rYUXQr2tBQbWGAU arnZ5kVq+ueU8cuzw4ppACTLUZvZ8HWVEVMe25MnHF/NGOzulcIkDacgzZsMraMdxtU1JEgEhC+ cAQc5ozwHyTlxqjWDSRE03bcQXCJt0uL/ZHhkshRxjqp/yTgXebykPeHTazLIgXLGNNusBDAJY2 HH30NdzyEPzYykpK7Z31lWvgKrSAj97dpkOLvui6NJ+YNLV1lpVR4n87R/nyoZVYlPap5Y3OjFk nA21hNYkQxJ2MKX9Mf+yBY0P3Ig1nWYOCHW+1vb49hWTW3wbsxEdIVZGy8QTV59CObk2SiFBX62 LYSJkAlTsAqz8= X-Received: by 2002:a17:907:1c1e:b0:b83:b7c5:de2c with SMTP id a640c23a62f3a-b8dff514b5cmr970984866b.10.1770119525723; Tue, 03 Feb 2026 03:52:05 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: John Snow , Pierrick Bouvier , qemu-arm@nongnu.org, Markus Armbruster , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Nicholas Piggin , Wainer dos Santos Moschetta , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Edgar E. Iglesias" , qemu-s390x@nongnu.org, Thomas Huth , Paolo Bonzini , Akihiko Odaki , Daniel Henrique Barboza , David Hildenbrand , Ilya Leoshkevich , Richard Henderson , Laurent Vivier Subject: [PATCH 04/11] gdbstub: extract stop reply message construction Date: Tue, 3 Feb 2026 11:51:54 +0000 Message-ID: <20260203115201.2387721-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203115201.2387721-1-alex.bennee@linaro.org> References: <20260203115201.2387721-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770119647825158500 The stop reply message we send can include a lot of extra information and a bunch is mode dependant. Extract the construction into a helper and add specialised versions for system and user mode. The correct response for system mode should be of the form: T05core:N; Where N is the core ID. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- gdbstub/internals.h | 7 +++++++ gdbstub/gdbstub.c | 15 ++++++--------- gdbstub/system.c | 11 +++++++++++ gdbstub/user.c | 12 ++++++++++++ 4 files changed, 36 insertions(+), 9 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 92466b28c18..3134a6e8eb2 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -237,4 +237,11 @@ void gdb_breakpoint_remove_all(CPUState *cs); int gdb_target_memory_rw_debug(CPUState *cs, hwaddr addr, uint8_t *buf, int len, bool is_write); =20 +/** + * gdb_build_stop_packet() - craft the stop packet + * @cs: CPUState + */ + +void gdb_build_stop_packet(CPUState *cs); + #endif /* GDBSTUB_INTERNALS_H */ diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index d4db7ba30cc..c82fb5ad324 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1431,11 +1431,10 @@ static void handle_v_attach(GArray *params, void *u= ser_ctx) gdbserver_state.g_cpu =3D cpu; gdbserver_state.c_cpu =3D cpu; =20 - if (gdbserver_state.allow_stop_reply) { - g_string_printf(gdbserver_state.str_buf, "T%02xthread:", GDB_SIGNA= L_TRAP); - gdb_append_thread_id(cpu, gdbserver_state.str_buf); - g_string_append_c(gdbserver_state.str_buf, ';'); - gdbserver_state.allow_stop_reply =3D false; + if (gdbserver_state.allow_stop_reply) { + gdb_build_stop_packet(cpu); + gdbserver_state.allow_stop_reply =3D false; + } } =20 gdb_put_strbuf(); @@ -2037,11 +2036,9 @@ static void handle_gen_set(GArray *params, void *use= r_ctx) static void handle_target_halt(GArray *params, void *user_ctx) { if (gdbserver_state.allow_stop_reply) { - g_string_printf(gdbserver_state.str_buf, "T%02xthread:", GDB_SIGNA= L_TRAP); - gdb_append_thread_id(gdbserver_state.c_cpu, gdbserver_state.str_bu= f); - g_string_append_c(gdbserver_state.str_buf, ';'); - gdb_put_strbuf(); + gdb_build_stop_packet(gdbserver_state.c_cpu); gdbserver_state.allow_stop_reply =3D false; + gdb_put_strbuf(); } /* * Remove all the breakpoints when this query is issued, diff --git a/gdbstub/system.c b/gdbstub/system.c index 79f80256e3a..6963c930b01 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -662,3 +662,14 @@ void gdb_breakpoint_remove_all(CPUState *cs) ops->remove_all_breakpoints(cs); } } + +/* + * The minimal system-mode stop reply packet is: + * T05core:{id}; + */ + +void gdb_build_stop_packet(CPUState *cs) +{ + g_string_printf(gdbserver_state.str_buf, + "T%02xcore:%02x;", GDB_SIGNAL_TRAP, gdb_get_cpu_index(= cs)); +} diff --git a/gdbstub/user.c b/gdbstub/user.c index a2327c61352..cc71cda3e33 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -974,3 +974,15 @@ void gdb_handle_query_xfer_siginfo(GArray *params, voi= d *user_ctx) gdb_put_packet_binary(gdbserver_state.str_buf->str, gdbserver_state.str_buf->len, true); } + +/* + * The minimal user-mode stop reply packet is: + * T05thread:{id}; + */ + +void gdb_build_stop_packet(CPUState *cs) +{ + g_string_printf(gdbserver_state.str_buf, "T%02xthread:", GDB_SIGNAL_TR= AP); + gdb_append_thread_id(cs, gdbserver_state.str_buf); + g_string_append_c(gdbserver_state.str_buf, ';'); +} --=20 2.47.3 From nobody Sat Feb 7 05:57:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770119630; cv=none; d=zohomail.com; s=zohoarc; b=HEjoV+QUMTSpEx8Ivw7yZl1ZhQA+4HX7nam6bycwvuNJ7BJ5Vxwj/cQSzUkDC2XnRZuyWI/RaiOp+JJIFtaISdtmAgYxssqZCfXA0fsDjikS4FP5IzE/Lhc9guW5vArL0DZ/5noIgY5XDwBb0vSID8E7s/qG57zp0Y5B6NTIiVM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770119630; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XSrliXOCATefwQIn64R/qg8IArPF/GMhbm/SYSQ7GEc=; b=Rg+U2AES+bK7K+9teDWoKmvIu6scixshhM3GGMtc7qBwR/lwbx3xSvM2Shw4pfqvdm/gaW9fEDbeTjNuSL1hWmTs0C5TmCtx37tcSH4lSQt8Q8+jt5X+ERSQyhXWM3fcgGjUhz0bCg/wddEbD588YSxbQnd1fe78psdPlrT9/M0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17701196303704.3609163497569625; Tue, 3 Feb 2026 03:53:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnExR-0008G3-1t; Tue, 03 Feb 2026 06:52:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnEx3-0007wo-Cq for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:13 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnEx0-00059T-8N for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:13 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-658cc45847cso8434269a12.0 for ; Tue, 03 Feb 2026 03:52:08 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf184e5dsm1040894866b.43.2026.02.03.03.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:52:07 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 8407060072; Tue, 03 Feb 2026 11:52:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770119528; x=1770724328; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XSrliXOCATefwQIn64R/qg8IArPF/GMhbm/SYSQ7GEc=; b=tzrpDTIh4P5p9GJ5JX4dHf0q5vkIxo3w354uoJ9adIX/lh7vrDVxtP1Q6+hLcdaCpC 0IzVV8H1aNgUuBYAhydm97zeMqTzVwddrNQIKeT9RpsIOEPxOYW+lFuJJGSg+FqDHqdW n9VBIpQ0IHYV9T3K4Lk+NZ7pxi63j0z9KbFT+Xr1lUvRvxm08YACPszMNwAf/VL25C/S dUhgXWp0jfEMIkaa3zUelnJHmOK+Qz8bHbVx1Fno6Q8pgtX+drd/oIowrs0DbxcUJnTb sob6HsQ4NpjgYz0YgFjEF3mi6wICz0W3LI3YKKY8PV3Q3l6T3BzfCPkyKiEkZTmto1/b vJLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119528; x=1770724328; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XSrliXOCATefwQIn64R/qg8IArPF/GMhbm/SYSQ7GEc=; b=OZh2/XdcuC24ag9M6z5rtuX7QvM/ma7LNIjfzp6LmAJYCeE7KXm9MCay+axBex6qs+ 8oAEAsuunqHHqDYmuMeFia9bRum7Hmi6rCo/kanwyzLm6iBz6MghLE/yDcMn/xVyzj+y V0fZ32G65/a919HBCmmhAE9fG/zS1KY0gItCJf67Do2XylD/S/4DyQBBbpKph1urhHzi +pEqVOQ7LyZIrFqglHYgyWufnsFQEzs2TnJwAUfFImBTediQdVkxjq+t+d205gtqg3eh sZfwOKsUMiUDcvcmBqoT+I7QAKX5jsRQB6KN2gD707a4nIXkH4Lg8aWd6nvzX9eDyHGm 7ROA== X-Gm-Message-State: AOJu0YzpZTZxl2IaIyVtv5YaxjSCQM7536YAoTUP7G6jLR0cnuO/nsfW X2O8pIzKgOuvkyM5l5fVKczL3y4TaVnq2lmYNjuQRLAgNpfFrxonG6uoEoCdMQGBl1Q= X-Gm-Gg: AZuq6aLazLHa0qh8SEW/HqT8x9njN4RtbIZqW9hPk0QJiKekpQZgBJOCp60Z1pbVmpv ZqSXh34AK1W2luQCbE8yqBFzMfqfEpQLE3T7ec3BhmtLlLnCjl4omcTHyXKVaoXgA53EoLVLWS9 JreWGORpPBTk90K0hzDvOvCJDMnu10lbEi1WJejK36kcM7h2kVSPm5C0Xsptm0sdGgH+WnSvwqM OT//hJjjiSUegocjxQgMKOJ+Pk0IoVvIdXY58SV9tOY7/xRUYfpiDmwKiQKajmJlZws28Rc4Nlv rr9RAGjRDUnIDxPUkaDauPYRRDJj40bdaj7ykmJkfaqz4YIiCLAdYbXDZWjJW9R9LheuRRludi0 bzq89l3OQnTuGlUjF3vlrZ9rWMB1ZfOiN03YLfjXlWdn9kbKhUbPAgRtqzMnk6ilZks7D3U7EwM QKUJ/MR7EUur57NADoUb/LRA== X-Received: by 2002:a17:907:70c:b0:b8a:fa35:989f with SMTP id a640c23a62f3a-b8dff696c1amr916446166b.38.1770119527895; Tue, 03 Feb 2026 03:52:07 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: John Snow , Pierrick Bouvier , qemu-arm@nongnu.org, Markus Armbruster , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Nicholas Piggin , Wainer dos Santos Moschetta , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Edgar E. Iglesias" , qemu-s390x@nongnu.org, Thomas Huth , Paolo Bonzini , Akihiko Odaki , Daniel Henrique Barboza , David Hildenbrand , Ilya Leoshkevich , Richard Henderson , Laurent Vivier Subject: [PATCH 05/11] gdbstub/user: localise variables for reading gdb socket Date: Tue, 3 Feb 2026 11:51:55 +0000 Message-ID: <20260203115201.2387721-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203115201.2387721-1-alex.bennee@linaro.org> References: <20260203115201.2387721-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770119631550158500 Keep things tidy by moving the declarations to the block where they are used. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- gdbstub/user.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/gdbstub/user.c b/gdbstub/user.c index cc71cda3e33..c7a3ef947ed 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -198,9 +198,6 @@ void gdb_qemu_exit(int code) int gdb_handlesig(CPUState *cpu, int sig, const char *reason, void *siginf= o, int siginfo_len) { - char buf[256]; - int n; - if (!gdbserver_state.init || gdbserver_user_state.fd < 0) { return sig; } @@ -246,11 +243,10 @@ int gdb_handlesig(CPUState *cpu, int sig, const char = *reason, void *siginfo, gdbserver_state.state =3D RS_IDLE; gdbserver_user_state.running_state =3D 0; while (gdbserver_user_state.running_state =3D=3D 0) { - n =3D read(gdbserver_user_state.fd, buf, 256); + char buf[256]; + int n =3D read(gdbserver_user_state.fd, buf, 256); if (n > 0) { - int i; - - for (i =3D 0; i < n; i++) { + for (int i =3D 0; i < n; i++) { gdb_read_byte(buf[i]); } } else { --=20 2.47.3 From nobody Sat Feb 7 05:57:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770119616; cv=none; d=zohomail.com; s=zohoarc; b=k6tzGE4jRB7lfb7QeQwFeoBQFlSeI0CPWl66HWvSEMjD7UPZfvxZ8p47Tj78tltsKz5HeTWl2XKoLgC4g4rNyiqbkAWy2pYhxey0XQNATucr80rAig3kRy48vC2kPXPlvn/HnU+ee455n4LlS5nxMrhX/O6A+TPd2FoCCqzzD8I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770119616; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3rnOG7bwrBNwvdTMzR0X6nqTtCuNrtf+RkzdzcDauu4=; b=QDnvmbZVZ6bNVh4E29CCL3AIdmW5xm542TwK6IpGlhOFNefRpnHsbM0DYteNP5nVPI+ap9celNwohWLtaLW+rvqjsagjwHdABZT02naII3IDRBhIgnoTw1b1z+hY/NiKOjom8WgwSRIFybJ9Bg6ZHeLAvlNeYE2BZMcd1b2lngU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770119616389858.8412491333693; Tue, 3 Feb 2026 03:53:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnExH-00084M-H7; Tue, 03 Feb 2026 06:52:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnEx4-0007xg-44 for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:14 -0500 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnEx0-0005A0-Bb for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:13 -0500 Received: by mail-ej1-x641.google.com with SMTP id a640c23a62f3a-b87677a8abeso833060866b.1 for ; Tue, 03 Feb 2026 03:52:09 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbeffedd3sm998692766b.29.2026.02.03.03.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:52:07 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 9CB2B60231; Tue, 03 Feb 2026 11:52:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770119529; x=1770724329; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3rnOG7bwrBNwvdTMzR0X6nqTtCuNrtf+RkzdzcDauu4=; b=u7X0/Zcjt6hImDuEKVy6/J9RRSjC5NQwmuHhPFDoH8l4HyOES4nXQORVU1Ab2nMXnB SW6B9mlKbHYsbTVtSny0YZxcKKRFvjg7I4Lxzb/kRd63isG8x+quJw9+UhTjnrko5W3m SIiMzOCNUmph+ljG8dKtGxmd2ugj4iO65gexr4NPaHF+o73mETnBz04yhUn7FmAHqIXO CIqYZvj25YVnUciX0gxbU0/yb0yVtxtYYHFN8ij/yAMnJg2y0rGnGZxWMNa58PPqD6ry WuluYTKdOVi/6/dpfDq/7o9pxVpdXxHDNTRgUF7dV8ip1Btik9pZsPBtoUH7IREySg5/ KJZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119529; x=1770724329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3rnOG7bwrBNwvdTMzR0X6nqTtCuNrtf+RkzdzcDauu4=; b=DFBdceiLjKKETT0fYlMW4nUqdCiyrwZhTirxl8i6lgZFvtHsJxDBAyy3zaJ9UMZ/XX ZF3AGYV0iQmFPaKkAbpkUpjPpaBIf25ojKHbpttkIt9OGbofhHjwthjCOwHDyNUagZmN 9oLPHAgSz8F0v0BG59grdRaJ4iI6Vkq+43nM4TwT+ZQ4cXc9s5SWTVpUuqtHmN5y4e+j 1FUFd3aJNi3LYD1aT3eZilsk2q5eqn7hVmqrks0jKHlbSO1yynK2b9NciZ++ynKGj2vD Ckr1Vdtf8aC1wdKa7SHKj4YcnJ3NG102RJJ0MS+H8q4q1rv9nsQY5Dah0vm7BOEwY8s+ X5Bg== X-Gm-Message-State: AOJu0YxRl+cnpQyk1eK2ACeS6WS8SzTwhCgV/E9+TP/Y73ON7VUYV/MU RrPXPJiORTZ8LG2hCt48f5HkCmAqzmSnoIN/E48kZMBGE39FZaMEhEA2I/rSr4Wgu3I= X-Gm-Gg: AZuq6aLJGCgVF8pFPl7bLOPnJWpWlliocCQPtOpT/Krah7tjIiM1i74ug9CtbaSpdUZ pghjCw/ilkR8mmfOlhSQNT1wA4BZfQEPN8ovvvS389TgmY1f1blf1xH+sYrhvPNmsLFOZNFjt7E 97kM6H7eihJe5yx8prTOpuLjKCWnqblMH+HKu0VlAvo8JhABtLUb6B1yEtCC8JZ6zUut9XarKHY KTuoIriKMzHVElU2w5M8CZlLo95paxGQti9AxbOaGdHq4yE6fyjGPCyJrm8TpyF6AIAIm1NeBFx HP5JYSHaQsul+joq8K1gw55oo7xez+TprHYo0FtQq3FoS0rXt1+jBw0J5bAaJgZNRXNEGjbDfQ5 5+BP7Q1+Nur4tDrD7A79C5F69TW+KxtlfLht9MggJXmgPo/UPtDhyPEEEkvvyDo1y0JfcTq4GWO MGyA9ukPMVQjbMl5w1lmKnDA== X-Received: by 2002:a17:907:1b03:b0:b87:35fc:ae6e with SMTP id a640c23a62f3a-b8dff69d99bmr912611866b.46.1770119528628; Tue, 03 Feb 2026 03:52:08 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: John Snow , Pierrick Bouvier , qemu-arm@nongnu.org, Markus Armbruster , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Nicholas Piggin , Wainer dos Santos Moschetta , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Edgar E. Iglesias" , qemu-s390x@nongnu.org, Thomas Huth , Paolo Bonzini , Akihiko Odaki , Daniel Henrique Barboza , David Hildenbrand , Ilya Leoshkevich , Richard Henderson , Laurent Vivier Subject: [PATCH 06/11] gdbstub: pass GString to gdb_build_stop_packet Date: Tue, 3 Feb 2026 11:51:56 +0000 Message-ID: <20260203115201.2387721-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203115201.2387721-1-alex.bennee@linaro.org> References: <20260203115201.2387721-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::641; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x641.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770119618166158500 The other functions we are going to clean-up work variously with there own dynamically allocated GStrings or with the common shared buffer. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- gdbstub/internals.h | 5 ++++- gdbstub/gdbstub.c | 4 ++-- gdbstub/system.c | 4 ++-- gdbstub/user.c | 8 ++++---- 4 files changed, 12 insertions(+), 9 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 3134a6e8eb2..9b25bf58b8e 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -239,9 +239,12 @@ int gdb_target_memory_rw_debug(CPUState *cs, hwaddr ad= dr, =20 /** * gdb_build_stop_packet() - craft the stop packet + * @buf: GString buffer for building the packet * @cs: CPUState + * + * Craft the Stop/Reply packet when we halt. */ =20 -void gdb_build_stop_packet(CPUState *cs); +void gdb_build_stop_packet(GString *buf, CPUState *cs); =20 #endif /* GDBSTUB_INTERNALS_H */ diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index c82fb5ad324..b45eb7c7b2b 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1432,7 +1432,7 @@ static void handle_v_attach(GArray *params, void *use= r_ctx) gdbserver_state.c_cpu =3D cpu; =20 if (gdbserver_state.allow_stop_reply) { - gdb_build_stop_packet(cpu); + gdb_build_stop_packet(gdbserver_state.str_buf, cpu); gdbserver_state.allow_stop_reply =3D false; } } @@ -2036,7 +2036,7 @@ static void handle_gen_set(GArray *params, void *user= _ctx) static void handle_target_halt(GArray *params, void *user_ctx) { if (gdbserver_state.allow_stop_reply) { - gdb_build_stop_packet(gdbserver_state.c_cpu); + gdb_build_stop_packet(gdbserver_state.str_buf, gdbserver_state.c_c= pu); gdbserver_state.allow_stop_reply =3D false; gdb_put_strbuf(); } diff --git a/gdbstub/system.c b/gdbstub/system.c index 6963c930b01..8ec8b7ea336 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -668,8 +668,8 @@ void gdb_breakpoint_remove_all(CPUState *cs) * T05core:{id}; */ =20 -void gdb_build_stop_packet(CPUState *cs) +void gdb_build_stop_packet(GString *buf, CPUState *cs) { - g_string_printf(gdbserver_state.str_buf, + g_string_printf(buf, "T%02xcore:%02x;", GDB_SIGNAL_TRAP, gdb_get_cpu_index(= cs)); } diff --git a/gdbstub/user.c b/gdbstub/user.c index c7a3ef947ed..a16f37616b1 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -976,9 +976,9 @@ void gdb_handle_query_xfer_siginfo(GArray *params, void= *user_ctx) * T05thread:{id}; */ =20 -void gdb_build_stop_packet(CPUState *cs) +void gdb_build_stop_packet(GString *buf, CPUState *cs) { - g_string_printf(gdbserver_state.str_buf, "T%02xthread:", GDB_SIGNAL_TR= AP); - gdb_append_thread_id(cs, gdbserver_state.str_buf); - g_string_append_c(gdbserver_state.str_buf, ';'); + g_string_printf(buf, "T%02xthread:", GDB_SIGNAL_TRAP); + gdb_append_thread_id(cs, buf); + g_string_append_c(buf, ';'); } --=20 2.47.3 From nobody Sat Feb 7 05:57:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770119667; cv=none; d=zohomail.com; s=zohoarc; b=I1nYWSWsRYSuSCVsMmFqeFIcvkKwAyaiTu6/2bMJ4EsWK9hrJ7or7ffXs37qaTGz9PWJeOG6dA89Vyv4Pc6r+4Cez8XdhR9vyCsSGZTT/+Ry2pCF6qK20f85ApMDhoHn7k8nwVpUZu0bOTuVJm7hj+pRW31N1innm4cplwwIUDc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770119667; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0V2C0hSasiZ0RXRAJCGAe8Bly/ben/AN3ObuqG7QFIY=; b=W/uxS1YP70J4WrLUMgUiDGcOQwspwc2gNB6PXMON+8i3BOPdBo3MTLJLlpxCXYB94XLbiGnrN/Xk2E/gVVhhPYv+1SF8FzL/9djJghb+xxPZdZG1ufd1ZQWASaC9qW+N45R8jSgYTmh4rMzp7Sq+XJ9VXGJeNy547ZGsjX+mxqY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770119667261808.8674214116711; Tue, 3 Feb 2026 03:54:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnExM-0008Ax-SO; Tue, 03 Feb 2026 06:52:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnEx5-0007zF-JL for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:15 -0500 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnEx2-0005Au-AK for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:15 -0500 Received: by mail-ej1-x642.google.com with SMTP id a640c23a62f3a-b88593aa4dcso757579766b.3 for ; Tue, 03 Feb 2026 03:52:11 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbef86991sm1042865266b.4.2026.02.03.03.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:52:07 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id B4AC9602CD; Tue, 03 Feb 2026 11:52:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770119530; x=1770724330; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0V2C0hSasiZ0RXRAJCGAe8Bly/ben/AN3ObuqG7QFIY=; b=yMOIfzMCS41ghoCvKHzb10f7vGUlRTEtof/FNY9DtIUmXEqz4QSfZaYF5OlkhaS9st 0cCdxS9bDE3E6Qvg0W4NwQsZb9OA0he8jrTOgqPYGags5lK7jchnThcRkjO+7S911TRR ZJ0YghxN4hc8y7GKZoBFi8xeBG0ccopnjqHXRGUjziMpE/Mb3UqllOgLm8tgz4vTePrN zKos9Txs6/oe9HGOJslmMbtDLmKQKIbg7usOuueeCN1bj4HeKR5aHisApdGDSFd5shKn C4bryNf7vXDKDjgPSh4xa0ZZC9q1Qb7yS4ngblvKIh+k9yl91XsU4e1mPtrElzWbON7C s68A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119530; x=1770724330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0V2C0hSasiZ0RXRAJCGAe8Bly/ben/AN3ObuqG7QFIY=; b=nDkEwxByIoAWtJSQkOJwC0LTtL7hZjoug0/n31g4Qc8enCoKdhE5z+ZVJSg0Dc8iUz UEYrx9yUg13lI8IQ+UDDU3WD8hh1d2CTdUQWs+5QkaieFFrWOuDCEPumCRE4Ga4O2nbw /QdBs/c6hqdiwJC59D1mDCz/I6dq+uv/5gJ4F/5m47q0l9thjGZcV9t3/nLgFdNv0Mis l2EpbykWPAZNCi5jvWGHVEDJ10FULAYvQaFXjayYmKN+T+Fj+Qci40yqVi5nyTH4x22G Z8NJfNdsimYSBuFxrRdMgT1zT0jvaG6jGWQpGjoq4y77AeGrV0+qSdcyOeJywWoAVhs8 Eqfg== X-Gm-Message-State: AOJu0YzoanWZEquFsGDPsmt43k8/OFtAHHBxy5qcXv4K6HFAHy4mIKHY b364mUrSFKfaiSY9gjpYyBs90TrEceiO8KYgkW5oZ+X61Kjdv3yULjRFBcUUFrm/jto= X-Gm-Gg: AZuq6aLC+s/LusNc21FYVb+ICJLeHBZZiYrzAy3SbnE24y74ogMWCvZFgfSk1QSTBJZ Vakk57ObYm7yCcz7IEGrelISjAlLmMG3/FH5v+p4UKSWo1kj7Twfi+vMan5oMF4wKUkOFe2W5WN n0mr0/V43dkvt/XUcbEdpjh5r7Zg9ElGIQ6ODn5b6eVVc/ewShybd1KMS0P8tI8to+HexBy1odB v3brkGDiPvMPmq7UAK55zEs9FqJW77ZslfA4cL13aQpTcczJ9+A9mT7wnBPCk/2i0q9RoBkpvVW Sd4RphrSSodeJZ+JFAoidSVy46NNKbOmBg/b8ntHPZZ4uY5wovZiIE7Z6nYgJverlztNahMAJxt txvj1xwhWsMZlHU/lQSqsaLCpGth1JLf7r5WKblhdJ6skaDH6QVKm8MTstegdLQpWAykzmfeyDJ WlewssLzLjIfY= X-Received: by 2002:a17:907:2d0e:b0:b86:e938:1b21 with SMTP id a640c23a62f3a-b8dff5d8e42mr918857266b.23.1770119530082; Tue, 03 Feb 2026 03:52:10 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: John Snow , Pierrick Bouvier , qemu-arm@nongnu.org, Markus Armbruster , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Nicholas Piggin , Wainer dos Santos Moschetta , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Edgar E. Iglesias" , qemu-s390x@nongnu.org, Thomas Huth , Paolo Bonzini , Akihiko Odaki , Daniel Henrique Barboza , David Hildenbrand , Ilya Leoshkevich , Richard Henderson , Laurent Vivier , Yodel Eldar Subject: [PATCH 07/11] include/gdbstub/syscalls: Add EIO and ENOSYS GDB File-I/O errno values Date: Tue, 3 Feb 2026 11:51:57 +0000 Message-ID: <20260203115201.2387721-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203115201.2387721-1-alex.bennee@linaro.org> References: <20260203115201.2387721-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::642; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x642.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770119667506158500 From: Yodel Eldar This patch adds the EIO and ENOSYS errno values that were missing from the GDB Manual [1] when the other errno values were defined. [1] https://sourceware.org/gdb/current/onlinedocs/gdb.html/Errno-Values.html Reviewed-by: Richard Henderson Signed-off-by: Yodel Eldar Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260116014612.226183-2-yodel.eldar@yodel.dev> Signed-off-by: Alex Benn=C3=A9e --- include/gdbstub/syscalls.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/gdbstub/syscalls.h b/include/gdbstub/syscalls.h index d63228e96b4..6200416f77a 100644 --- a/include/gdbstub/syscalls.h +++ b/include/gdbstub/syscalls.h @@ -22,6 +22,7 @@ #define GDB_EPERM 1 #define GDB_ENOENT 2 #define GDB_EINTR 4 +#define GDB_EIO 5 #define GDB_EBADF 9 #define GDB_EACCES 13 #define GDB_EFAULT 14 @@ -37,6 +38,7 @@ #define GDB_ENOSPC 28 #define GDB_ESPIPE 29 #define GDB_EROFS 30 +#define GDB_ENOSYS 88 #define GDB_ENAMETOOLONG 91 #define GDB_EUNKNOWN 9999 =20 --=20 2.47.3 From nobody Sat Feb 7 05:57:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770119604; cv=none; d=zohomail.com; s=zohoarc; b=h6v5/tLk48jKPs1BtiGkx69R/fwA+gWvCFWplTQvcYj1BMSLVRx6Ody7UeOTTAXH6kziI7jCWFQDj58oOkqK1eqZIBAZV1c1DNfhGdMXSszsRM/DTvbeaLhKAadA/lfIcGr4Iwb9B7HRdDgjKZCz2h+CPtl60O95SfghNyrln44= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770119604; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Joeyp3Wt8eRfhFTETp2dv+O0vYWQ3id566kC7NlCTjk=; b=YoXroCP6OFb3lLWLdRSBAMdqaoMHbOiL1L8R22+6dDx17AbUWSRTg4PjiIw0w4/BTiNdKIgLzvmJV9BTnsJmL4KF0we6RJJa9Pb2zrDF4sbYwPcvjblpDtkcD5pXjD+VohcLTpvYR8EMyxTQK6Wngj9gd/0k3H74fmXBWhVmh9M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770119604476549.088801295019; Tue, 3 Feb 2026 03:53:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnExN-0008BE-04; Tue, 03 Feb 2026 06:52:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnEx4-0007yj-VG for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:15 -0500 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnEx2-0005AD-9c for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:14 -0500 Received: by mail-ej1-x641.google.com with SMTP id a640c23a62f3a-b7cf4a975d2so809426166b.2 for ; Tue, 03 Feb 2026 03:52:10 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf1baa42sm1032887166b.46.2026.02.03.03.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:52:07 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id D17B0602F5; Tue, 03 Feb 2026 11:52:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770119529; x=1770724329; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Joeyp3Wt8eRfhFTETp2dv+O0vYWQ3id566kC7NlCTjk=; b=Tw+1LvwBa6J9UZYBsXwnKlUb5tcuukmDIkDMbS0YgEj1T0FYUv7XIhvVwaxwD7Oqu8 zrQp0xPIGlrWqG6uuTYfzoe6Dd7E1hMSvP4ltCRR7vsa8B4gyjrLQ2cB0qtfcqjBueeP 2T/QJQY3yAV3b2xk1VaTuXaChFeyPNAic1Ii4kdlcvFOjjBuS+MQcEW9Q6yv2Idohzw9 EvWgCSyUCQg53I74TCmedh3A3M/M7V1POvMxz72naHbK23acs+OzxsuU3mq7n98cevHj I5EPilShMAHdouzESUiB1lzF2ek3SEqF/rXFZGKI/J/auPywAb9ogop53FejeGcJXyuw qbYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119529; x=1770724329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Joeyp3Wt8eRfhFTETp2dv+O0vYWQ3id566kC7NlCTjk=; b=RM5Sc+m9nt65HBaQ7OqnlgePB3gJxsvLSZzgIkqFZcMO1Nv6EmYZB8Sk3gGDSz+hkE N9qXtLJyw6N158R57SoqPD/VsZ3c+3JXBYhoo8X4txNpma0ocVj9FWh9eKgK63BJvHdo PM9yIBRFBsU90HWVtbyqHfprb4u+4ReTFjOx7tM+eeRLYQt8ZSg09dgQkYaIp2l8I3XY R3/dbliIJOFesWrJ+cLQZOxeE4YOLFaddM51I9XJz4uiUxYEFqpGRjlxT8dYh+EezYMd yCv7NzZB2t7F4YjSho5QYQDO+HMwD1E/xupfZVBaH02zQGnd7b1rZJcHGF9s9/CzPkFR jZCg== X-Gm-Message-State: AOJu0Yz0UuS4RuLYGYUX6K/NHnB0damF5atcKDRfokyakZG+hX11SAuU NTdTw2e0NvvKppG6fRc8hsoMPiTKHNco4jdMwWQOTULbwKjZ5vsmftdOG97MWxxI9Tc= X-Gm-Gg: AZuq6aIGeiYRKIModd7OJIlJir3hPS+6jGB7IcOgXeZ/5mQmvsoGjvBQEsUdW2dlmqs Snrkd4ZSXy0c5/CRAIxpNeQdbru4u/wft/pZwfsLsLGY3/tSH8GrSwBdvrydBp4P4D7+ofr7vCJ JcSNkIWh0PUVjME08pm7qOAKAWCpbjIeXnfVprpFnZi8je8rGLRuYKTyCgvU53eGFAi369TZyT6 tkXR3gmoZL6o3aaZZwf2NduSTV1cDP8f8mIVc3KbqrHxs6r/JlJt8oPTsdl3lN5HYGbTMPSLAWn N5W6PapN1ENlSCvqSzKoKZBbu9sb43RRRe/FK3rv+Vq+JXnsPNbHNiV6t8l63CKxMnr5Ea01Xx5 aqH3GxvSaop4jdtV+bkIrs2F+y4tbxWy98zbUUUmpqvaC2geoC+irNpf2lTK52r27ta3WJKufNq iryyWsBAaVuDw= X-Received: by 2002:a17:906:7308:b0:b8a:f225:ede1 with SMTP id a640c23a62f3a-b8dff72c615mr978091366b.41.1770119529252; Tue, 03 Feb 2026 03:52:09 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: John Snow , Pierrick Bouvier , qemu-arm@nongnu.org, Markus Armbruster , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Nicholas Piggin , Wainer dos Santos Moschetta , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Edgar E. Iglesias" , qemu-s390x@nongnu.org, Thomas Huth , Paolo Bonzini , Akihiko Odaki , Daniel Henrique Barboza , David Hildenbrand , Ilya Leoshkevich , Richard Henderson , Laurent Vivier , Yodel Eldar Subject: [PATCH 08/11] gdbstub: Export host_to_gdb_errno File-I/O helper function Date: Tue, 3 Feb 2026 11:51:58 +0000 Message-ID: <20260203115201.2387721-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203115201.2387721-1-alex.bennee@linaro.org> References: <20260203115201.2387721-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::641; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x641.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770119607787154100 From: Yodel Eldar Move host_to_gdb_errno from target/m68k/m68k-semi.c to gdbstub/syscalls.c. Declare it in include/gdbstub/syscalls.h. Add both newly added GDB File-I/O supported errno values, EIO and ENOSYS, to the mapping. Reviewed-by: Richard Henderson Signed-off-by: Yodel Eldar Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260116014612.226183-3-yodel.eldar@yodel.dev> Signed-off-by: Alex Benn=C3=A9e --- include/gdbstub/syscalls.h | 9 +++++++++ gdbstub/syscalls.c | 36 ++++++++++++++++++++++++++++++++++++ target/m68k/m68k-semi.c | 29 ----------------------------- 3 files changed, 45 insertions(+), 29 deletions(-) diff --git a/include/gdbstub/syscalls.h b/include/gdbstub/syscalls.h index 6200416f77a..a09559128b1 100644 --- a/include/gdbstub/syscalls.h +++ b/include/gdbstub/syscalls.h @@ -102,6 +102,15 @@ void gdb_do_syscall(gdb_syscall_complete_cb cb, const = char *fmt, ...); */ int use_gdb_syscalls(void); =20 +/** + * host_to_gdb_errno: convert host errno to GDB errno value + * @err: errno from host + * + * Given an error number from the host, this helper function returns + * its GDB File-I/O specified representation. + */ +int host_to_gdb_errno(int err); + /** * gdb_exit: exit gdb session, reporting inferior status * @code: exit code reported diff --git a/gdbstub/syscalls.c b/gdbstub/syscalls.c index d8bb90cc1c7..15050984a04 100644 --- a/gdbstub/syscalls.c +++ b/gdbstub/syscalls.c @@ -145,6 +145,42 @@ void gdb_do_syscall(gdb_syscall_complete_cb cb, const = char *fmt, ...) gdb_syscall_handling(gdbserver_syscall_state.syscall_buf); } =20 +/* + * Map host error numbers to their GDB protocol counterparts. + * For the list of GDB File-I/O supported error numbers, please consult: + * https://sourceware.org/gdb/current/onlinedocs/gdb.html/Errno-Values.html + */ +int host_to_gdb_errno(int err) +{ +#define E(X) case E##X: return GDB_E##X + switch (err) { + E(PERM); + E(NOENT); + E(INTR); + E(IO); + E(BADF); + E(ACCES); + E(FAULT); + E(BUSY); + E(EXIST); + E(NODEV); + E(NOTDIR); + E(ISDIR); + E(INVAL); + E(NFILE); + E(MFILE); + E(FBIG); + E(NOSPC); + E(SPIPE); + E(ROFS); + E(NOSYS); + E(NAMETOOLONG); + default: + return GDB_EUNKNOWN; + } +#undef E +} + /* * GDB Command Handlers */ diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c index 578a08dfee8..bdc798a28cb 100644 --- a/target/m68k/m68k-semi.c +++ b/target/m68k/m68k-semi.c @@ -46,35 +46,6 @@ #define HOSTED_ISATTY 12 #define HOSTED_SYSTEM 13 =20 -static int host_to_gdb_errno(int err) -{ -#define E(X) case E##X: return GDB_E##X - switch (err) { - E(PERM); - E(NOENT); - E(INTR); - E(BADF); - E(ACCES); - E(FAULT); - E(BUSY); - E(EXIST); - E(NODEV); - E(NOTDIR); - E(ISDIR); - E(INVAL); - E(NFILE); - E(MFILE); - E(FBIG); - E(NOSPC); - E(SPIPE); - E(ROFS); - E(NAMETOOLONG); - default: - return GDB_EUNKNOWN; - } -#undef E -} - static void m68k_semi_u32_cb(CPUState *cs, uint64_t ret, int err) { CPUM68KState *env =3D cpu_env(cs); --=20 2.47.3 From nobody Sat Feb 7 05:57:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770119586; cv=none; d=zohomail.com; s=zohoarc; b=cUaTcmbD4qtVazo+RMyFHUuK/fXsVqHmZMuZc/5QCxGHkwpdjj2vSFZAoPsLap6g7VR/6BSYoYVgUerp3su231+f8xX/J1PUQO4zmlVEytHvRmj7D0rmnH3opfWTLDEcT989sb1XMGT9hE7LH0cOnySNAv4Oc53s9qP+tDTynjk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770119586; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bbT8qqcdeI/gjCIg66X1LOjHgngepJa584e/oDIZWu8=; b=EmzUpmJgN7eb+Ddijs7tMM39Gx2VPGIlngDobhO2ekeDM5UtleLwEczORoujVEJQ1OCYxbqgUkd9ugoLlKzrqKGSg1hh8A5R5BsiA4+OSNou1NBHyk5WfagoiOyvtZsYRwZB7Yrnie42XW2kMoZqBmnb/3Hz3ZMHLDghLWyLIvg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17701195867564.668607359085286; Tue, 3 Feb 2026 03:53:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnExS-0008IC-Vb; Tue, 03 Feb 2026 06:52:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnEx6-00081Z-UD for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:20 -0500 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnEx3-0005BL-7h for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:16 -0500 Received: by mail-ej1-x642.google.com with SMTP id a640c23a62f3a-b884a84e655so808454266b.0 for ; Tue, 03 Feb 2026 03:52:12 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbefc6685sm1004141966b.17.2026.02.03.03.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:52:07 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id E8B716036C; Tue, 03 Feb 2026 11:52:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770119531; x=1770724331; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bbT8qqcdeI/gjCIg66X1LOjHgngepJa584e/oDIZWu8=; b=If6sZxreiAHlYUsc3i8S0cJGNqjNhF/cLqtlEagvSB7wNMyVNUFRc0yj/7/joLLwZx KZGVJTt8A0u/IMX2SyKeY7PbkniAmIFxzBR8yvIof5bFc8Fa4N9jXN76zHrNlWPqUH4z Yete8AwQsqvepDfQgw6GQ5MOhhIAvpDt1Jcw/DqsH0DZu/ZHQqJOFb6DAkbAZGLgrOpZ wFRhFFKKa1MOm0xNdqFXuRXNW5tnEJ4jNPWYizFNJNIOP2m5cMA+YODmik1s+ZZuqWL+ XvnaI2Pn+eLkq3t+1t5Dvk5Nqg7CHslGwlmj4NKCzMPJ4rO1VMn120dUxIMmi7auINsh jHCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119531; x=1770724331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bbT8qqcdeI/gjCIg66X1LOjHgngepJa584e/oDIZWu8=; b=ZpWDbe6DOiru6s21BZotN40uNIzTzYHo/PgN1gNVVc3/+4p6/U8aOXO2K0mrm9iYvl p+ydC2QT6XfxPdPZSDOgHkhmdseymOuhHF5Hysr+E0W4N8ABoOLPjN9VMQ56RU53UfM8 UDCcr2Y30wGl/Qt3fsQHs788WsYiJVhO8HxAlphuvrYccqzjtJyqGIIswxP/+W8VrpSz 3b9oMx1GbTkF5SX2HjUp+3Q9oZtUBo+1V26rcXtkdtG3PSMoOJ0RdeSvClTV1sJBh+fF buiLbRhFM0Qaf4uJrDTuTT3wga0CavvfrUzMrjDrHhuWA6KPJLr8ujSH/X3sJTrk6lQX 8ibw== X-Gm-Message-State: AOJu0YxWsF8e81uij6h79GUdfMucguMw80eYMawlY4UsZzWi2sj2u7GY Z236XMXRSYzh1OAZbhXD8remaEDkv4H23PKAgw7WKWQc8Bw6nBZk5NWGrzn94W0DhB0= X-Gm-Gg: AZuq6aJpn5dh/rvKWshMQXJxTl15P8/uLtiSGMo+l8EDJfqO+cd9ZIHVA359p7P4CrA MPXyMQhnQ+/Lp2mO3wxekWY23C049t6Gl7JZW0UkQSogH+UtbHiQFr4r8pESs9FR6iGiKCfCTJn R6Ufy2BpbnD4cTjB4BuZZpIB2ehNiWPu+hRymoRcIx87rOkIAi9AXzEi/CIMyXpCRZn16eEygV3 RyZt4qnXTNaHrcU2RDscjLOXs/52GLFUBiQc8JRvhY5mkEw4IYPi8ZKBfseuJZR3ZANe0CWMl/F j3xe0qYFZ69izzDgC/6v6uIVGhreRh0ajyxq2p4uwpwwjhJFQyzIEER5GJC5z34FysByTz2/xvD rsISAqcrCYjHSmcvamHfoEVUDnI42vihU4aUDSzHbx+bxmJt3cosHGP8nK9XCBOpzDEf7HL/+tf N4USGy8NaUek8= X-Received: by 2002:a17:907:ea6:b0:b8a:fc17:56e1 with SMTP id a640c23a62f3a-b8dff56b0d8mr1054983466b.6.1770119531446; Tue, 03 Feb 2026 03:52:11 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: John Snow , Pierrick Bouvier , qemu-arm@nongnu.org, Markus Armbruster , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Nicholas Piggin , Wainer dos Santos Moschetta , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Edgar E. Iglesias" , qemu-s390x@nongnu.org, Thomas Huth , Paolo Bonzini , Akihiko Odaki , Daniel Henrique Barboza , David Hildenbrand , Ilya Leoshkevich , Richard Henderson , Laurent Vivier , Yodel Eldar , Dominik 'Disconnect3d' Czarnota Subject: [PATCH 09/11] gdbstub/user-target: Convert host errno to GDB File-I/O errno Date: Tue, 3 Feb 2026 11:51:59 +0000 Message-ID: <20260203115201.2387721-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203115201.2387721-1-alex.bennee@linaro.org> References: <20260203115201.2387721-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::642; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x642.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770119588227158500 From: Yodel Eldar Use host_to_gdb_errno to convert host-supplied errnos to their GDB File-I/O remote protocol values, and use them in F reply packets. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2751 Reported-by: Dominik 'Disconnect3d' Czarnota Signed-off-by: Yodel Eldar Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260116014612.226183-4-yodel.eldar@yodel.dev> Signed-off-by: Alex Benn=C3=A9e --- gdbstub/user-target.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/gdbstub/user-target.c b/gdbstub/user-target.c index 43231e695e8..7ef0282f70e 100644 --- a/gdbstub/user-target.c +++ b/gdbstub/user-target.c @@ -10,6 +10,7 @@ #include "qemu/osdep.h" #include "exec/gdbstub.h" #include "gdbstub/commands.h" +#include "gdbstub/syscalls.h" #include "qemu.h" #include "internals.h" #ifdef CONFIG_LINUX @@ -315,7 +316,8 @@ void gdb_handle_v_file_open(GArray *params, void *user_= ctx) int fd =3D open(filename, flags, mode); #endif if (fd < 0) { - g_string_printf(gdbserver_state.str_buf, "F-1,%x", errno); + int gdb_errno =3D host_to_gdb_errno(errno); + g_string_printf(gdbserver_state.str_buf, "F-1,%x", gdb_errno); } else { g_string_printf(gdbserver_state.str_buf, "F%x", fd); } @@ -327,7 +329,8 @@ void gdb_handle_v_file_close(GArray *params, void *user= _ctx) int fd =3D gdb_get_cmd_param(params, 0)->val_ul; =20 if (close(fd) =3D=3D -1) { - g_string_printf(gdbserver_state.str_buf, "F-1,%x", errno); + int gdb_errno =3D host_to_gdb_errno(errno); + g_string_printf(gdbserver_state.str_buf, "F-1,%x", gdb_errno); gdb_put_strbuf(); return; } @@ -350,7 +353,8 @@ void gdb_handle_v_file_pread(GArray *params, void *user= _ctx) =20 ssize_t n =3D pread(fd, buf, bufsiz, offset); if (n < 0) { - g_string_printf(gdbserver_state.str_buf, "F-1,%x", errno); + int gdb_errno =3D host_to_gdb_errno(errno); + g_string_printf(gdbserver_state.str_buf, "F-1,%x", gdb_errno); gdb_put_strbuf(); return; } @@ -373,7 +377,8 @@ void gdb_handle_v_file_readlink(GArray *params, void *u= ser_ctx) ssize_t n =3D readlink(filename, buf, BUFSIZ); #endif if (n < 0) { - g_string_printf(gdbserver_state.str_buf, "F-1,%x", errno); + int gdb_errno =3D host_to_gdb_errno(errno); + g_string_printf(gdbserver_state.str_buf, "F-1,%x", gdb_errno); gdb_put_strbuf(); return; } --=20 2.47.3 From nobody Sat Feb 7 05:57:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770119601; cv=none; d=zohomail.com; s=zohoarc; b=mIMCuv5lhzq4z4miRsQ6q4Gk1Ysx/WzBF/KFYaf+UCuub/r2dFN23bZNsYziRyvRtego/UlFI4Hi1v0csxwKVzLzjcQKETSBHmuRnirBntJaxrcsrC7WQSiCCtVOmUdYbAytw7ZuACKoSXriwYRmg36D1zlP9RSR+q1V9f0nmJ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770119601; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=q4p2xjSQh41Ag5LxVuPwppS8kSDsK6cwuipOCAHLv74=; b=FySbuK0Zp3ZzAgg2NNkPM6cVJsqJ0+AK8eOUJPwrz8bhdEPQGFG599t7guoBmUmnlANQYx8SHEXZ8q4KSdw6G9LSlR2cm2VjVOO4EqnnYLD3qawUomjRHJ2XgHzkks8kmR62IKhU2NKQl+MrfKco5OBl/X8r4HsdNqf8QxqZo3k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770119601055963.523022409552; Tue, 3 Feb 2026 03:53:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnExS-0008Hl-RW; Tue, 03 Feb 2026 06:52:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnEx8-00081v-MA for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:22 -0500 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnEx3-0005CU-Sp for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:18 -0500 Received: by mail-ej1-x642.google.com with SMTP id a640c23a62f3a-b8876d1a39bso780093266b.1 for ; Tue, 03 Feb 2026 03:52:13 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b4691e78sm8931802a12.17.2026.02.03.03.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:52:07 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 0AF91603E3; Tue, 03 Feb 2026 11:52:03 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770119532; x=1770724332; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q4p2xjSQh41Ag5LxVuPwppS8kSDsK6cwuipOCAHLv74=; b=xrAV/DZLQFYUJ4F2ROtfldJxJsKbB7I40BkDMDisQGwzAoZa9ugvkDXnUAT7m+DoJh RU0O0YG9Bbs0MFyTLcBaSdlbJq1u6U+oPoN/P2ny5w41RP81pYpMKnF1OktnS3KiamWg uPFtqiZbZv/neTvRUTcOBY/bNzpEi+Y4iioYw+7oanOiUxmtnvKKQKP+cKfLddddByrv pBT4SfLr0CD3C8M3EAR5jZPTPAxEPvONud2XT3tdmGSnj/ajRY5BGbweFw24qphIxtrA n4RxSXnWZ2LXu5uls6y3RU1c6BhX1/Z2yILhFrj0YLegyjIdFOo0Ikk3/hLQebdVky1y X4jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119532; x=1770724332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=q4p2xjSQh41Ag5LxVuPwppS8kSDsK6cwuipOCAHLv74=; b=IpOj38F5XHssy9JhMrpKwmg4tsIAXZWkgrAdoeE+AvWYrQsbWqlt6kgenQd6flm+yq GSeuSSQ6XJ1qGgJdGqdlAsGu/SuzithnrG4N/ZfSgVxx0iqUS2xNPD9hRXazJuGVcu0y D/yxSsMHcGQpaxWhZRFgZi1T00mdtIcZA7nRrzWOvPZguAmNcW4fMCpV/cmIK4A+oXO4 wpKe01LTSRU0eKGQh9krybl9upBew4ZnFUppqOpOyQ87Dih1uJAh90b1vzwpP1/taaAx vQDPw0jNz6wshN+ldGy82Ro3Pvyy4pdmmjuIFlYF28JM6cGT2+IWxPQYezgclEEmIIf0 scSg== X-Gm-Message-State: AOJu0YxgCkWBlbuDSMAzDzoORBzeza6w3LlZPkt6PUXU8uwSv9ngG7Xz fG13HMj0zuuZURgsMBsGUYx/pNTPrXhKLsbj+Ry/IQza676k2qmAbzXWE9LTMqRHTAk= X-Gm-Gg: AZuq6aIf4c4VMPBjglj15RspKWFUMWhlNHsk+xXDBYrLg5/uVn1vvL1iZTy9rqLc5g/ 5Y0mR3wvknpfGw++n6oJk5swPm7Y29Fd3BBdFhQ2H+pt9JzHTu0YLvhltARoroXTMbT2dI4zfhU eP8PnZJleREtUOJ2/2RiEJLJszcY+ooPGCHLh731LDTCpSv2xW/rnAbH7WWyGrOVvFruo9JIxVB 4XK+XOgHydXCG0YMWpJ1th+XxwDd+zbb6VbTA5cdCc7bHGZTA/ObmD4IXy+bgDcdSpjnXzGEYxE wraPbtvgC1DuaHCFBflePVONTJp6E2DNzzWrDL2oHdJUd4JENqpBfOyyAXvKK3D3dnxzN0XcPkv JOhhceaKlWUB873Aqf3T+PwnEKLtbTnHoEs6NbajMDWpfC6ltK+yDwYz29X6tRNoD8DNpfnKxsz va3FcIvqNcf88= X-Received: by 2002:a17:907:7fa9:b0:b8e:7e21:132c with SMTP id a640c23a62f3a-b8e7e214381mr246135166b.59.1770119532214; Tue, 03 Feb 2026 03:52:12 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: John Snow , Pierrick Bouvier , qemu-arm@nongnu.org, Markus Armbruster , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Nicholas Piggin , Wainer dos Santos Moschetta , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Edgar E. Iglesias" , qemu-s390x@nongnu.org, Thomas Huth , Paolo Bonzini , Akihiko Odaki , Daniel Henrique Barboza , David Hildenbrand , Ilya Leoshkevich , Richard Henderson , Laurent Vivier Subject: [PATCH 10/11] include/gdbstub: fix typo Date: Tue, 3 Feb 2026 11:52:00 +0000 Message-ID: <20260203115201.2387721-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203115201.2387721-1-alex.bennee@linaro.org> References: <20260203115201.2387721-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::642; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x642.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770119603740158500 Signed-off-by: Alex Benn=C3=A9e --- include/gdbstub/commands.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h index bff3674872e..989a95c33f9 100644 --- a/include/gdbstub/commands.h +++ b/include/gdbstub/commands.h @@ -50,7 +50,7 @@ typedef union GdbCmdVariant { * '.' -> Skip 1 char unless reached "\0" * Any other value is treated as the delimiter value itself * - * @allow_stop_reply: True iff the gdbstub can respond to this command wit= h a + * @allow_stop_reply: True if the gdbstub can respond to this command with= a * "stop reply" packet. The list of commands that accept such response is * defined at the GDB Remote Serial Protocol documentation. See: * https://sourceware.org/gdb/onlinedocs/gdb/Stop-Reply-Packets.html#Stop-= Reply-Packets. --=20 2.47.3 From nobody Sat Feb 7 05:57:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1770119615; cv=none; d=zohomail.com; s=zohoarc; b=QgUbURWlq2ffNEkVZ29JvzJmgnDsmSF8k+vN8JPueJ44FpRBPQYXRqwck6NW3nvruhLR/gc03ZsqJEMBd9+t9L3O18RISwkKoj73TxONV00q/dod2O3SkSPQ4RFkcGWLDlohpNyuT5/NYNQ1YeSDVS8d59SE0BlEDuPlKNeX3bU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770119615; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tIRBj03rO3D6/ePpgDjzJBDK2sDnW8f3X2SZv5WEDqc=; b=KYM4hPaBlv7qtJjGbUjD+RnCXmAfo16ykZHcQAK75W4SWgoPDheeTfkT0Zc8WR8dDeisx6yrijVTI9cc0i06d4yxdMe9d711aj9GCzTmn8CQ2A/+TitsPnL4Ovic9FJWRcaGau3JfrgK8u/6d5Z6vx+dom435oTbkRCD+qT9GVM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1770119615722881.7260329535932; Tue, 3 Feb 2026 03:53:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vnExf-0008Uw-KZ; Tue, 03 Feb 2026 06:52:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vnEx9-000822-Af for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:22 -0500 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vnEx4-0005C1-Bu for qemu-devel@nongnu.org; Tue, 03 Feb 2026 06:52:19 -0500 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-b886fc047d5so1038093366b.3 for ; Tue, 03 Feb 2026 03:52:13 -0800 (PST) Received: from draig.lan ([185.124.0.126]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbefc667asm1038953166b.22.2026.02.03.03.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:52:07 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 214FB6051B; Tue, 03 Feb 2026 11:52:03 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770119532; x=1770724332; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tIRBj03rO3D6/ePpgDjzJBDK2sDnW8f3X2SZv5WEDqc=; b=YeW91Pb76dHjCiaYbNFvdcAU9wEKRZWa1VsLBlBg36aDYPz38psySanO21TgWbPR2b SmDOu8NcSFYfIW2EwnYTE4KwqiejZiNSfzZYyI9I/Y6xCYsFyvbD26cw1P0JMn6mNw9n LZXJD7cbAEcGYn1LPPF+8eHd5emOsKW+f7sJO0szKNtpBIq2V0yKqF58p8c6j3oLrmJp jKT/DhwdV6scG2bToThjHhOljMABZctGj5QsG6Iem3PB/co1ftUrjn4IoykDtF/Uxv8E SX+kkN4m87MamJjeZqEdxMMMsyK4J+BkjrFPGfn3sLoqVAaO88CRNTpZD9K8QhS6jPNC qMpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770119532; x=1770724332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tIRBj03rO3D6/ePpgDjzJBDK2sDnW8f3X2SZv5WEDqc=; b=Wv0AsMQP75rY67YLocV3qdLDAzRJmQ3y6Um7GXsHUS6eHn6rem3FttLI92dtypqfys hNL7dPbDC9rR5J4U/1o83lBxUMnVkKDAgejvOf/sZwmngIhruj29km5Ebc0aDVM07w5h DwkMEHtNO9/xVCo1hI+e+zWbMeif+sCq+fYQjA+vpW9jmsGn5GY2gojxnYsmp0ft1jbw jDoZy3Pwlk8eDnye/Z2+SOOvbAU8GCE0F3KGGiIAGwYDSZXrWWB2IjIxPWRuNt9G4w/O zYSCIQFRTb86yvSrz1ui/sh7viPQQDDHJY2ooBHBwFdw4WUIWmTZtjLnLltZxMu9OdZ5 HmOw== X-Gm-Message-State: AOJu0YxsOVYRVkeGnw8Cs1EnYpl6NDemYy5AVKlRmiPd78zgOvx+HTT2 D1XD4Rqv0ybzZQ+gH0bRxDtEL7gZlG4MPTAbgGTAx+xcSapXQQN1IH6hR7Z0ArBG8sk= X-Gm-Gg: AZuq6aK+semdYgkJpeDFgZT1CvbB4MWPL3NrudIgeHDaWxUFe+syon4K+yO2dV3+RVf YSM3Xu3sUOpZGDh/SuD5Ezkg91VjUa1/EhvD11wNc8h2XZ7pHatOAQQldd2uaWgRV1FOJX9wXye baFS8gD1M6DO/gW4bqVvsdHTzuJ2j4NuygJXEQASaClmVpxKrzBd7gtPNvEgSFOz3dVC89t+rr0 P1sWFKu0Qdi1Ew+Kko3A25y8NtkamZpfFNyr+uFR+krH/LiFnP3cHRakZQtVN/k+uI4nPba2tAy HKAL9Twl6VUf0vZ4fZfFYzxdrnnBJeUfE59xHONg0TodGnu5aN22ttank+0sQe3uKHZDyTftxbo y6/8J56qGQbMecKyUDxzB1bkoEEdkVqh9CppFiw3kRCSqtdLmStJTTiSE1+1e/gV72UUtLAaid3 JxgaQtbQ8Sv2A= X-Received: by 2002:a17:907:7f88:b0:b72:70ad:b8f0 with SMTP id a640c23a62f3a-b8dff6531eemr919591466b.36.1770119531829; Tue, 03 Feb 2026 03:52:11 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: John Snow , Pierrick Bouvier , qemu-arm@nongnu.org, Markus Armbruster , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , David Gibson , Nicholas Piggin , Wainer dos Santos Moschetta , qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , Cleber Rosa , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , "Edgar E. Iglesias" , qemu-s390x@nongnu.org, Thomas Huth , Paolo Bonzini , Akihiko Odaki , Daniel Henrique Barboza , David Hildenbrand , Ilya Leoshkevich , Richard Henderson , Laurent Vivier Subject: [PATCH 11/11] gdbstub/user: rename and use bool for running_state Date: Tue, 3 Feb 2026 11:52:01 +0000 Message-ID: <20260203115201.2387721-12-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203115201.2387721-1-alex.bennee@linaro.org> References: <20260203115201.2387721-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1770119619141154100 This is just a clean-up to document what we using the running variable for in user-mode. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- gdbstub/user.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/gdbstub/user.c b/gdbstub/user.c index a16f37616b1..97eb13e796a 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -87,7 +87,11 @@ enum GDBForkMessage { typedef struct { int fd; char *socket_path; - int running_state; + /* + * running state of the guest, when we process a packet that restarts + * the guest we set this to true. + */ + bool running; /* * Store syscalls mask without memory allocation in order to avoid * implementing synchronization. @@ -241,8 +245,8 @@ int gdb_handlesig(CPUState *cpu, int sig, const char *r= eason, void *siginfo, =20 sig =3D 0; gdbserver_state.state =3D RS_IDLE; - gdbserver_user_state.running_state =3D 0; - while (gdbserver_user_state.running_state =3D=3D 0) { + gdbserver_user_state.running =3D false; + while (!gdbserver_user_state.running) { char buf[256]; int n =3D read(gdbserver_user_state.fd, buf, 256); if (n > 0) { @@ -611,11 +615,11 @@ void gdbserver_fork_end(CPUState *cpu, pid_t pid) =20 gdbserver_state.state =3D RS_IDLE; gdbserver_state.allow_stop_reply =3D false; - gdbserver_user_state.running_state =3D 0; + gdbserver_user_state.running =3D false; for (;;) { switch (gdbserver_user_state.fork_state) { case GDB_FORK_ENABLED: - if (gdbserver_user_state.running_state) { + if (gdbserver_user_state.running) { close(fd); return; } @@ -728,7 +732,7 @@ void gdb_handle_query_attached(GArray *params, void *us= er_ctx) =20 void gdb_continue(void) { - gdbserver_user_state.running_state =3D 1; + gdbserver_user_state.running =3D true; trace_gdbstub_op_continue(); } =20 @@ -750,7 +754,7 @@ int gdb_continue_partial(char *newstates) cpu_single_step(cpu, gdbserver_state.sstep_flags); } } - gdbserver_user_state.running_state =3D 1; + gdbserver_user_state.running =3D true; return res; } =20 --=20 2.47.3